[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 30 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:194 + + const ASTContext + mutable llvm::DenseMap Data; Storing the `ASTContext` in

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 142459. apazos added a comment. - Simplified hasOtherExtensions() now that we clarified non-standard extensions are separated by '_'. We just need to find the first occurrence of the prefixes. - updated error message, removed "unsupported" from some messages.

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. I prefer to have a dedicated directory to store all the .dwo files. As dblaikie said, all the .dwo files are temporary files. In addition, in order to differentiate the .dwo files generated by different link stage with the same .o, we need to add some suffixes to the

r330068 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Apr 13 14:12:33 2018 New Revision: 330068 URL: http://llvm.org/viewvc/llvm-project?rev=330068=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:77-78 + /// comparison category. For example 'std::strong_equality::equal' + const DeclRefExpr *getResultValue(ComparisonCategoryResult ValueKind) const { +const DeclRefExpr *DR =

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp: +bool Sema::BuildComparisonCategoryData(SourceLocation Loc) { + using CCKT = ComparisonCategoryKind; rsmith wrote: > EricWF wrote: > > rsmith wrote: > > > If you put this on Sema, you'll

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

JetForMe added a comment. Just want to comment that this functionality is also good for security, as it enables hiding of path information in final builds (while still allowing logging to show file and line number). https://reviews.llvm.org/D17741

r330064 - [Analyzer] Fix for SValBuilder expressions rearrangement

Author: baloghadamsoftware Date: Fri Apr 13 13:23:02 2018 New Revision: 330064 URL: http://llvm.org/viewvc/llvm-project?rev=330064=rev Log: [Analyzer] Fix for SValBuilder expressions rearrangement Expression rearrangement in SValBuilder (see rL329780) crashes with an assert if the type of the

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

This revision was automatically updated to reflect the committed changes. Closed by commit rC330064: [Analyzer] Fix for SValBuilder expressions rearrangement (authored by baloghadamsoftware, committed by ). Repository: rC Clang https://reviews.llvm.org/D45557 Files:

r330067 - Use InitLLVM in clang as well.

Author: ruiu Date: Fri Apr 13 13:57:57 2018 New Revision: 330067 URL: http://llvm.org/viewvc/llvm-project?rev=330067=rev Log: Use InitLLVM in clang as well. Differential Revision: https://reviews.llvm.org/D45634 Modified: cfe/trunk/tools/clang-format/ClangFormat.cpp

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:77-78 + /// comparison category. For example 'std::strong_equality::equal' + const DeclRefExpr *getResultValue(ComparisonCategoryResult ValueKind) const { +const DeclRefExpr *DR =

[PATCH] D45634: Use InitLLVM in clang as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330067: Use InitLLVM in clang as well. (authored by ruiu, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D45634?vs=142462=142463#toc

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek created this revision. phosek added reviewers: dexonsmith, compnerd. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Darwin driver currently uses libc++ headers that are part of Clang toolchain when available (by default ../include/c++/v1 relative to executable),

[libcxx] r330045 - support: add missing locale stubs for android L, M

Author: compnerd Date: Fri Apr 13 11:14:57 2018 New Revision: 330045 URL: http://llvm.org/viewvc/llvm-project?rev=330045=rev Log: support: add missing locale stubs for android L, M The strto* family was introduced in android O (API Level 26). However, the support headers were adjusted to

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

efriedma added a comment. This makes sense. Comment at: include/clang/Frontend/Utils.h:241 +/// then the value of this boolean will be true, otherwise false. +extern bool FrontendTimesIsEnabled; + Don't really like global variables, but I guess timers are

[PATCH] D45591: Clean carriage returns from lib/ and include/. NFC.

malcolm.parsons accepted this revision. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM. Can't commit right now - using phone. Repository: rC Clang https://reviews.llvm.org/D45591 ___ cfe-commits mailing

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

efriedma added a comment. > The fcmp opcode has no defined behavior with NaN operands in the comparisions > handled in this patch. Could you describe the problem here in a bit more detail? As far as I know, the LLVM IR fcmp should return the same result as the x86 CMPPD, even without

r330044 - hwasan: add -fsanitize=kernel-hwaddress flag

Author: andreyknvl Date: Fri Apr 13 11:05:21 2018 New Revision: 330044 URL: http://llvm.org/viewvc/llvm-project?rev=330044=rev Log: hwasan: add -fsanitize=kernel-hwaddress flag This patch adds -fsanitize=kernel-hwaddress flag, that essentially enables -hwasan-kernel=1 -hwasan-recover=1

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup thanks! https://reviews.llvm.org/D45557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9384-9385 +def err_spaceship_comparison_of_void_ptr : Error< + "three-way comparison with void pointer %select{operand type|operand types}0 " + "(%1 and %2)">; +def

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330041: Fix evaluation of `__has_include_next` during -frewrite-includes. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D45603?vs=142299=142438#toc

r330041 - Fix evaluation of `__has_include_next` during -frewrite-includes.

Author: vsapsai Date: Fri Apr 13 10:43:15 2018 New Revision: 330041 URL: http://llvm.org/viewvc/llvm-project?rev=330041=rev Log: Fix evaluation of `__has_include_next` during -frewrite-includes. `__has_include_next` requires correct DirectoryLookup for being evaluated correctly. We were using

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai added a comment. Thanks for the prompt review. Repository: rC Clang https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330042 - [OPENMP] Replace push_back by emplace_back, NFC.

Author: abataev Date: Fri Apr 13 10:48:43 2018 New Revision: 330042 URL: http://llvm.org/viewvc/llvm-project?rev=330042=rev Log: [OPENMP] Replace push_back by emplace_back, NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D45046: hwasan: add -fsanitize=kernel-hwaddress

This revision was automatically updated to reflect the committed changes. Closed by commit rC330044: hwasan: add -fsanitize=kernel-hwaddress flag (authored by andreyknvl, committed by ). Changed prior to commit: https://reviews.llvm.org/D45046?vs=142196=142440#toc Repository: rC Clang

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

In the interest of completeness, we now had our first true positive with this warning, here: https://github.com/KhronosGroup/VK-GL-CTS/blob/master/framework/referencerenderer/rrFragmentOperations.cpp#L603 (and another self-assign operator= unittest in that repo). On Fri, Apr 13, 2018 at 3:00 AM,

[PATCH] D45643: [Failing one test] Reword [-Wreturn-type] messages to "non-void x does not return a value"

rsmith added inline comments. Comment at: bindings/python/tests/cindex/test_diagnostics.py:18 self.assertEqual(tu.diagnostics[0].spelling, -'control reaches end of non-void function') +'non-void function does not return a value')

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 142502. apazos added a comment. Fixed failure in release mode https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeah, i think this makes sense, thanks! It feels a bit weird that we have to add it as an exception - i wonder if there are other exceptions that we need to make. Widening over the stack memory

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz updated this revision to Diff 142499. weimingz edited the summary of this revision. weimingz added a comment. split the original into two parts. This one supports -ffile-macro-prefix-to-remove function. I locally verified it. To add a test case, do we need to use VFS?

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ accepted this revision. NoQ added a comment. Wow, you actually did that. Ok, now we can decide if we want this to be analyzer-only (with a `CFG::BuildOptions` flag) or get someone else to have a look at that as a global CFG change (i.e. it may potentially affect compiler warnings). Or at

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ added a comment. (i'd much rather do the latter) Repository: rC Clang https://reviews.llvm.org/D45416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45643: [Failing one test] Reword [-Wreturn-type] messages to "non-void x does not return a value"

Quuxplusone added inline comments. Comment at: bindings/python/tests/cindex/test_diagnostics.py:18 self.assertEqual(tu.diagnostics[0].spelling, -'control reaches end of non-void function') +'non-void function does not return a value')

r330080 - Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)."

Author: vedantk Date: Fri Apr 13 18:40:48 2018 New Revision: 330080 URL: http://llvm.org/viewvc/llvm-project?rev=330080=rev Log: Revert "[Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC)." This reverts commit r330068. It breaks the lldb

Re: r330068 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

I've gone ahead and reverted this in r330080. I tested this with "./bin/lldb-dotest -p TestForwardDecl", and it no longer asserts, etc. @Eugene, regarding the specifics of this commit, there are a number of refactors here that don't make sense. E.g there's no need to create a reference to a

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Function argument constructors (that are used for passing objects into functions by value) are completely unlike temporary object

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

NoQ updated this revision to Diff 142505. NoQ added a comment. Add tests where the argument is passed by reference. These tests work correctly (i.e. they correctly identify the argument constructor as a temporary constructor) because such constructors would include a `MaterializeTemporaryExpr`

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ added a comment. Sorry, overwhelmed a bit, i'll try to get to this as soon as possible. Btw, what sort of UI are you trying to make these extra note pieces of mine work with? Was `-analyzer-config notes-as-events=true` of any help? Repository: rC Clang https://reviews.llvm.org/D45407

r330077 - [Driver] Export profiling symbols for -exported_symbols_list

Author: vedantk Date: Fri Apr 13 16:43:59 2018 New Revision: 330077 URL: http://llvm.org/viewvc/llvm-project?rev=330077=rev Log: [Driver] Export profiling symbols for -exported_symbols_list When profiling is enabled and -exported_symbols_list is specified for the Darwin linker, export the

[PATCH] D43578: -ftime-report switch support in Clang

rsmith added a comment. Last time I looked at doing this, I found that LLVM's timer infrastructure was fundamentally unsuitable for adding timers like these to Clang. The big problems are that Clang switches between "layers" and pieces that should be independently accounted at a very large

[PATCH] D45121: [coroutines] Add noop_coroutine to

GorNishanov closed this revision. GorNishanov added a comment. Committed as: https://reviews.llvm.org/rCXX329237 and a flurry of cleanup fixes: https://reviews.llvm.org/rCXX329239 https://reviews.llvm.org/rCXX329240 https://reviews.llvm.org/rCXX329245 https://reviews.llvm.org/D45121

r330074 - [ODRHash] Support pointer and reference types.

Author: rtrieu Date: Fri Apr 13 15:34:43 2018 New Revision: 330074 URL: http://llvm.org/viewvc/llvm-project?rev=330074=rev Log: [ODRHash] Support pointer and reference types. Recommit r328404 which was reverted in rL328404. r329869 fixed the issue that caused the revert. Modified:

[PATCH] D45643: [Failing one test] Reword [-Wreturn-type] messages to "non-void x does not return a value"

easyaspi314 created this revision. easyaspi314 added a project: clang. Herald added a subscriber: cfe-commits. Replace [-Wreturn-type] messages, "control reaches/may reach end of non-void x", to "non-void x does/might not return a value". F5962917: Screen Shot 2018-04-13 at 6.56.17 PM.png

[clang-tools-extra] r329994 - [clang-tidy] [bugprone-parent-virtual-call] Minor cosmetic changes. NFC

Author: zinovy.nis Date: Fri Apr 13 00:46:27 2018 New Revision: 329994 URL: http://llvm.org/viewvc/llvm-project?rev=329994=rev Log: [clang-tidy] [bugprone-parent-virtual-call] Minor cosmetic changes. NFC Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein added inline comments. Comment at: clangd/index/Index.h:32 +// Character offset on a line in a document (zero-based). +int Character = 0; + }; MaskRay wrote: > hokein wrote: > > sammccall wrote: > > > sammccall wrote: > > > > Column? > > > > > >

[PATCH] D45611: [analyzer] Fix filename in cross-file HTML report

malcolm.parsons created this revision. malcolm.parsons added reviewers: george.karpenkov, dcoughlin, vlad.tsyrklevich. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun. The filename is currently taken from the start of the path, while the line and column are taken from the end

[clang-tools-extra] r329999 - [clang-tidy] Fix ParentVirtualCallCheck for old MSVS compilers

Author: zinovy.nis Date: Fri Apr 13 01:43:47 2018 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32=rev Log: [clang-tidy] Fix ParentVirtualCallCheck for old MSVS compilers Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Modified:

r329989 - [XRay][clang] Make -fxray-modes= additive

Author: dberris Date: Thu Apr 12 22:59:57 2018 New Revision: 329989 URL: http://llvm.org/viewvc/llvm-project?rev=329989=rev Log: [XRay][clang] Make -fxray-modes= additive Summary: This allows us to do the following: clang -fxray-modes=none ... -fxray-modes=xray-basic It's important to be

[PATCH] D45610: [XRay][clang] Make -fxray-modes= additive

This revision was automatically updated to reflect the committed changes. Closed by commit rL329989: [XRay][clang] Make -fxray-modes= additive (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

shiva0217 updated this revision to Diff 142338. shiva0217 added a comment. Add help text for -mrelax, -mno-relax flags as Alex's comments. Repository: rL LLVM https://reviews.llvm.org/D44888 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1613 +def fregister_dtor_with_atexit : Flag<["-"], "fregister-dtor-with-atexit">, Group, Flags<[CC1Option]>, + HelpText<"Use atexit or __cxa_atexit to register destructors">; def fuse_init_array :

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 9, 2018, at 3:47 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 1:25 PM, John McCall > > wrote: >> >> >> >>> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka >> >

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:77-78 + /// comparison category. For example 'std::strong_equality::equal' + const DeclRefExpr *getResultValue(ComparisonCategoryResult ValueKind) const { +const DeclRefExpr *DR =

[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:98 +std::string CGNVCUDARuntime::addPrefixToName(CodeGenModule , + std::string FuncName) const { + if (CGM.getLangOpts().HIP) Can you take these as

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I'd still prefer if someone with more driver-design expertise weighed in, but we might not have any specialists there. LGTM, although you might consider changing your tests a bit:

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r329997 - [clangd] Add line and column number to the index symbol.

Author: hokein Date: Fri Apr 13 01:30:39 2018 New Revision: 329997 URL: http://llvm.org/viewvc/llvm-project?rev=329997=rev Log: [clangd] Add line and column number to the index symbol. Summary: LSP is using Line & column as symbol position, clangd needs to transfer file offset to Line & column

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329997: [clangd] Add line and column number to the index symbol. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D45513?vs=142195=142349#toc Repository: rCTE

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

(Sorry for the delay in responding — I'm actually on vacation.) On Tue, Apr 10, 2018 at 1:52 PM, David Blaikie wrote: > On Tue, Apr 10, 2018 at 10:20 AM John McCall wrote: > >> Do you think they’re bad precedent? > > > Somewhat, yes - though -Wparens is

[PATCH] D45257: [X86] Introduce cldemote intrinsic

GBuella updated this revision to Diff 142340. GBuella added a comment. Rebase. https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2342 + if (isa(Ty)) +return false; return true; I agree with your analysis that this shouldn't be a substitution candidate. However, I think this probably needs an

[PATCH] D45257: [X86] Introduce cldemote intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329993: [X86] Introduce cldemote intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45257?vs=142340=142345#toc

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

Hahnfeld added a comment. In https://reviews.llvm.org/D45212#1066842, @rjmccall wrote: > I'd still prefer if someone with more driver-design expertise weighed in, but > we might not have any specialists there. I think you should at least give @tra the possibility to take a look. Last time we

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

hokein added a comment. In https://reviews.llvm.org/D44882#1065932, @malaperle wrote: > In https://reviews.llvm.org/D44882#1065787, @hokein wrote: > > > @malaperle, what's your plan of this patch? Are you going to land it before > > https://reviews.llvm.org/D45513? With the Line info in the

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM, thanks. https://reviews.llvm.org/D45544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

baloghadamsoftware updated this revision to Diff 142365. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D45557 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/svalbuilder-rearrange-comparisons.c Index:

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

baloghadamsoftware added a comment. No more pending dependency, so we can continue the review. https://reviews.llvm.org/D35110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

lebedev.ri added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D45615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

paulsemel added a comment. In https://reviews.llvm.org/D45615#1066973, @lebedev.ri wrote: > Tests? I can do this. But currently, I am not testing the formats in the tests.. Repository: rC Clang https://reviews.llvm.org/D45615 ___ cfe-commits

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clangd/ClangdLSPServer.cpp:113 + auto KindVal = static_cast(Kind); + if (KindVal >= SymbolKindMin && KindVal <= SymbolKindMax) +SupportedSymbolKinds.set(KindVal);

[clang-tools-extra] r330004 - [clangd] Match AST and Index label for template Symbols

Author: ibiryukov Date: Fri Apr 13 04:03:07 2018 New Revision: 330004 URL: http://llvm.org/viewvc/llvm-project?rev=330004=rev Log: [clangd] Match AST and Index label for template Symbols Summary: Previsouly, class completions items from the index were missing template parameters in both the

[PATCH] D45613: [X86] Introduce archs: goldmont-plus & tremont

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D45613 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/Driver/x86-march.c

[PATCH] D45601: Warn on bool* to bool conversion

lebedev.ri added a comment. @hiraditya I personally don't like when i'm being told so, but i'd like to see some numbers... **Please** run this on //some// big C++ project (LLVM (but you'll have to enable this diag specifically), google chrome, ???), and analyse the results. In

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

paulsemel created this revision. paulsemel added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. There was missing some basic types format (like uint8_t..). This patch is meant to print them the correct way. Repository: rC Clang https://reviews.llvm.org/D45615 Files:

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

ilya-biryukov added inline comments. Comment at: unittests/clangd/FileIndexTests.cpp:218 + EXPECT_EQ(Sym.CompletionLabel, "vector"); + EXPECT_EQ(Sym.CompletionSnippetInsertText, "vector<${1:class Ty}>"); + SeenVector = true; sammccall wrote: > If

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330004: [clangd] Match AST and Index label for template Symbols (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D45482?vs=142372=142373#toc Repository: rL

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL330004: [clangd] Match AST and Index label for template Symbols (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45482

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

ilya-biryukov updated this revision to Diff 142372. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Also test plain text completion text - Clarify the comment - Simplify conditions in getTemplateOrThis Repository: rCTE Clang Tools Extra

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. The fcmp opcode has no defined behavior with NaN operands in the comparisions handled in this patch. Thus, these intrinsics can only be safe lowered to fcmp opcodes when fast-math is

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 142412. dfukalov edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D43281 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn-vi.cl

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45046: hwasan: add -fsanitize=kernel-hwaddress

eugenis added a comment. LGTM (+missing *-commits MLs) https://reviews.llvm.org/D45046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2109 + Opts.HIP = true; + } + rjmccall wrote: > Why is this done here? We infer the language mode from the input kind > somewhere else.

[PATCH] D44984: [HIP] Add hip file type and codegen for kernel launching

yaxunl updated this revision to Diff 142422. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D44984 Files: include/clang/Basic/LangOptions.def lib/CodeGen/CGCUDANV.cpp lib/CodeGen/CGDecl.cpp

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

MTC added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:10 +// +// This file defines a checker that checks cunstructors for possibly +// uninitialized fields. typo :) `cunstructors` -> `constructors`

[PATCH] D45601: Warn on bool* to bool conversion

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I'd also be interested to see the number of false positives and true positives when run over some large code bases (both C and C++). For instance, I would imagine code like this to be somewhat common and very

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D45615#1066975, @paulsemel wrote: > In https://reviews.llvm.org/D45615#1066973, @lebedev.ri wrote: > > > Tests? > > > I can do this. But

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

This revision was automatically updated to reflect the committed changes. Closed by commit rC330009: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition (authored by xazax, committed by ). Repository: rC Clang https://reviews.llvm.org/D45564 Files:

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45601: Warn on bool* to bool conversion

lebedev.ri added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7806 + "comparing %0 as a boolean">, + InGroup; def warn_format_argument_needs_cast : Warning< Also, this really really should be under it's own flag, which in turn may

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

r.stahl updated this revision to Diff 142381. r.stahl edited the summary of this revision. r.stahl added a comment. addressed review comments. I created a new test because certain checkers would cause early exits in the engine (because of undefined func ptr) and not cause the crash. Since I

r330012 - [NEON] Support vrndns_f32 intrinsic

Author: kosarev Date: Fri Apr 13 05:46:02 2018 New Revision: 330012 URL: http://llvm.org/viewvc/llvm-project?rev=330012=rev Log: [NEON] Support vrndns_f32 intrinsic Differential Revision: https://reviews.llvm.org/D45515 Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r329993 - [X86] Introduce cldemote intrinsic

Author: gbuella Date: Fri Apr 13 00:37:24 2018 New Revision: 329993 URL: http://llvm.org/viewvc/llvm-project?rev=329993=rev Log: [X86] Introduce cldemote intrinsic Reviewers: craig.topper, zvi Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D45257 Added:

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:35 + + FieldChain Chain; + // If this is a fieldchain whose last element is an uninitialized region of a I was wondering, do you need the chain at all?

r330009 - [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

Author: xazax Date: Fri Apr 13 05:36:08 2018 New Revision: 330009 URL: http://llvm.org/viewvc/llvm-project?rev=330009=rev Log: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition Patch by: Rafael Stahl! Differential Revision: https://reviews.llvm.org/D45564 Added:

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC330012: [NEON] Support vrndns_f32 intrinsic (authored by kosarev, committed by ). Repository: rC Clang https://reviews.llvm.org/D45515 Files: include/clang/Basic/arm_neon.td

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 created this revision. avt77 added reviewers: mgorny, russell.gallop, efriedma, rsmith, thakis, davezarzycki, RKSimon, simon.f.whittaker. To simplify the review and commit of D43578 I decided to spilt it in several small parts. This patch is the first

r329995 - [X86] Fix cldemote builtin signature

Author: gbuella Date: Fri Apr 13 01:14:21 2018 New Revision: 329995 URL: http://llvm.org/viewvc/llvm-project?rev=329995=rev Log: [X86] Fix cldemote builtin signature Fix for r329993 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified:

[PATCH] D45615: [builtins] __builtin_dump_struct : added more types format

paulsemel added a comment. In https://reviews.llvm.org/D45615#1067068, @aaron.ballman wrote: > In https://reviews.llvm.org/D45615#1066975, @paulsemel wrote: > > > In https://reviews.llvm.org/D45615#1066973, @lebedev.ri wrote: > > > > > Tests? > > > > > > I can do this. But currently, I am not

[PATCH] D45620: [clangd][tests] Fix handling of EOF in delimited input

jkorous-apple created this revision. Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov. Request in delimited input ended by EOF shouldn't be an error state. Comments should be allowed at the end of test files. Input mirroring should work for the last request in delimited test

  1   2   >