[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

zinovy.nis updated this revision to Diff 143053. zinovy.nis added a comment. - Removed exec attribute on file. https://reviews.llvm.org/D45776 Files: docs/clang-tidy/index.rst test/clang-tidy/check_clang_tidy.cpp test/clang-tidy/check_clang_tidy.py Index:

[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

zinovy.nis added a comment. Done. https://reviews.llvm.org/D45776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Hej Henrik, On Thu, 19 Apr 2018, Henrik Gramner via cfe-commits wrote: The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in combination with -mstack-alignment=32 (or larger) would produce a misaligned stack which could result in crashes when accessing

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

krisb created this revision. krisb added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. Generate attribute 'denorms-are-zero'='true' if '-cl-denorms-are-zero' compile option was specified and 'denorms-are-zero'='false' otherwise. Repository: rC Clang

[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

zinovy.nis updated this revision to Diff 143050. zinovy.nis marked 4 inline comments as done. zinovy.nis added a comment. - Fixed issues pointed by Alexander. https://reviews.llvm.org/D45776 Files: test/clang-tidy/check_clang_tidy.cpp test/clang-tidy/check_clang_tidy.py Index:

Fix __attribute__((force_align_arg_pointer)) misalignment bug

The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in combination with -mstack-alignment=32 (or larger) would produce a misaligned stack which could result in crashes when accessing stack buffers using aligned AVX load/store instructions. The attached patch

[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

zinovy.nis updated this revision to Diff 143052. zinovy.nis added a comment. - Updated docs. https://reviews.llvm.org/D45776 Files: docs/clang-tidy/index.rst test/clang-tidy/check_clang_tidy.cpp test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_tidy.py

[PATCH] D45717: [clangd] Using index for GoToDefinition.

sammccall added inline comments. Comment at: clangd/XRefs.cpp:209 + llvm::DenseSet QuerySyms; + llvm::DenseMap ResultCandidates; the approach could some documentation - I find it hard to follow the code. This function is probably too big

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

avt77 added a comment. Hi All, Are there other issues related to this patch? If NO could anyone give me LGTM? I need this patch committed to continue with recursive time counters. https://reviews.llvm.org/D45619 ___ cfe-commits mailing list

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay created this revision. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof. Repository: rCXX libc++ https://reviews.llvm.org/D45805 Files: include/type_traits Index: include/type_traits

[PATCH] D45776: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py

zinovy.nis added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:77 + + check_fixes_prefix = 'CHECK-FIXES' + args.check_suffix + check_messages_prefix = 'CHECK-MESSAGES' + args.check_suffix alexfh wrote: > Maybe the script should add a dash

[PATCH] D45442: Parse .h files as objective-c++ if we don't have a compile command.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jkorous. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45442 ___ cfe-commits

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso added a comment. I tried my checker on 10 famous open source project, this is the outcome: F5977628: curl_lib_transfer_c.html F5977629: ffmpeg_libavformat_sdp_c.html F5977631: openssl_apps_ca_c.html

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

xbolva00 added a comment. Shouldn't it catch in curl also this code? urllen = strlen(url_clone); memcpy(newest, url_clone, urllen); https://reviews.llvm.org/D45050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld added a comment. Ping https://reviews.llvm.org/D42922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r330310 - OpenBSD add C++ runtime in a driver's standpoint

Author: dberris Date: Wed Apr 18 23:55:30 2018 New Revision: 330310 URL: http://llvm.org/viewvc/llvm-project?rev=330310=rev Log: OpenBSD add C++ runtime in a driver's standpoint Summary: - Since 6.2 release, on supporters platforms clang is shipped with both libcxx and libcxxabi. Reviewers:

[PATCH] D45814: Fix an assertion when -print-prog-name= is invoked without parameter. Returns an empty string.

chrib created this revision. Herald added a subscriber: cfe-commits. Fix an assertion when -print-prog-name= Repository: rC Clang https://reviews.llvm.org/D45814 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp ===

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Sorry for the delay, I think I'll come back to this one soon. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. This one still applies and tests pass. Please review. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. A quick comment on the error message, inlined. It's about the quality of the diagnostics. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:336-337 +def

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang https://reviews.llvm.org/D45808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

ilya-biryukov added a comment. Herald added a subscriber: jkorous. In https://reviews.llvm.org/D45478#1064027, @sammccall wrote: > Is this patch still relevant after haojian's string deduplication? Apparently it does. It has an advantage of distributing the work more evenly between the

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

sammccall added a comment. In https://reviews.llvm.org/D45478#1071983, @ilya-biryukov wrote: > In https://reviews.llvm.org/D45478#1064027, @sammccall wrote: > > > Is this patch still relevant after haojian's string deduplication? > > > Apparently it does. It has an advantage of distributing the

r330323 - Lowering x86 adds/addus/subs/subus intrinsics (clang)

Author: aivchenk Date: Thu Apr 19 05:15:11 2018 New Revision: 330323 URL: http://llvm.org/viewvc/llvm-project?rev=330323=rev Log: Lowering x86 adds/addus/subs/subus intrinsics (clang) This is the patch that lowers x86 intrinsics to native IR in order to enable optimizations. Patch by tkrupa

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik added a comment. @ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might be also useful for clangd. Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, Do you have commit access, or do you want me to commit it for you? https://reviews.llvm.org/D45812 ___ cfe-commits mailing list

r330331 - Fix __attribute__((force_align_arg_pointer)) misalignment bug

Author: erichkeane Date: Thu Apr 19 07:27:05 2018 New Revision: 330331 URL: http://llvm.org/viewvc/llvm-project?rev=330331=rev Log: Fix __attribute__((force_align_arg_pointer)) misalignment bug The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

erichkeane added a comment. Can you make sure that this doesn't cause stackrealign to happen 2x if using -mstackrealign? Additionally, please provide the diff with full-context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). What is the commit before

[PATCH] D45764: [clangd][tests] Fix delimiter handling

jkorous added a comment. [ultranit] Sorry, just to be sure - did you really mean any number of dashes if (LineRef.startswith("-") && LineRef.find_first_not_of('-') == llvm::StringRef::npos) or at least three? if (LineRef.startswith("---") && LineRef.find_first_not_of('-') ==

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:883 if (UseLibcall) { +CGM.getDiags().Report(E->getLocStart(), diag::warn_atomic_op_misaligned); + compnerd wrote: > It is kinda unfortunate that you need to look up 125 lines

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Gramner updated this revision to Diff 143083. Gramner added a comment. Full context. https://reviews.llvm.org/D45812 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

asb added a comment. Hi @spetrovic - I think Hal Finkel's earlier request to update the comments of IsBetterAsSingleFieldRun remains unaddressed. It looks like at least the comment string immediately before `auto IsBetterAsSingleFieldRun` needs to be updated to reflect the changed behaviour.

[PATCH] D45764: [clangd][tests] Fix delimiter handling

sammccall added a comment. In https://reviews.llvm.org/D45764#1072067, @jkorous wrote: > [ultranit] Sorry, just to be sure - did you really mean any number of dashes > > if (LineRef.startswith("-") && LineRef.find_first_not_of('-') == > llvm::StringRef::npos) > > > or at least three? > > if

[clang-tools-extra] r330327 - [clang-tidy] Fix unused-variable warning.

Author: hokein Date: Thu Apr 19 06:34:03 2018 New Revision: 330327 URL: http://llvm.org/viewvc/llvm-project?rev=330327=rev Log: [clang-tidy] Fix unused-variable warning. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp Modified:

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Gramner added a comment. In https://reviews.llvm.org/D45812#1072066, @erichkeane wrote: > Can you make sure that this doesn't cause stackrealign to happen 2x if using > -mstackrealign? Additionally, please provide the diff with full-context (see >

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

Thanks! I didn't see this warning when running check-clang-tools on my machine. Fixed in r330327. On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén wrote: > Hi, > > > On 04/18/2018 10:54 AM, Haojian Wu via cfe-commits wrote: > >> Author: hokein >> Date: Wed Apr 18

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai, klimek. As an addition to CXTranslationUnit_SkipFunctionBodies, provide the new options CXTranslationUnit_LimitSkipFunctionBodiesToPreamble CXTranslationUnit_LimitSkipFunctionBodiesToNonTemplates. The first

[PATCH] D45095: [clang-tidy] Align usage of ClangTool interface with new VFS injection

whisperity added inline comments. Comment at: clang-tidy/tool/CMakeLists.txt:19 clangBasic + clangFrontend clangTidy ilya-biryukov wrote: > whisperity wrote: > > ilya-biryukov wrote: > > > Why do we need an extra dependency? > > In the current state of

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Gramner added a comment. In https://reviews.llvm.org/D45812#1072128, @erichkeane wrote: > LGTM, Do you have commit access, or do you want me to commit it for you? I do not have commit access, so please do. Thanks for the review. https://reviews.llvm.org/D45812

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

This revision was automatically updated to reflect the committed changes. Closed by commit rC330331: Fix __attribute__((force_align_arg_pointer)) misalignment bug (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D45812 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D45763: [clangd][tests] Fix handling of EOF in delimited input

jkorous added a comment. By "Comments should be allowed at the end of test files." I meant that we shouldn't log it as an exceptional state. Should've worded that better. I included a wrong test in the patch. I had realized the same thing as you and had written another test but messed up.

[PATCH] D45726: Format closing braces when reformatting the line containing theopening brace.This required a couple of yaks to be shaved:1. MatchingOpeningBlockLineIndex was misused to also store the

krasimir added a comment. Great patch! Comment at: lib/Format/AffectedRangeManager.cpp:144 + Line->First->is(tok::r_brace) && + Line->MatchingOpeningBlockLineIndex != -1 && + Lines[Line->MatchingOpeningBlockLineIndex]->Affected; nit: replace

[PATCH] D45763: [clangd][tests] Fix handling of EOF in delimited input

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I can't see the bug/change related to "Comments should be allowed at the end of test files." can you elaborate? Comment at:

[PATCH] D45095: [clang-tidy] Align usage of ClangTool interface with new VFS injection

ilya-biryukov added inline comments. Comment at: clang-tidy/ClangTidy.cpp:91 public: - ErrorReporter(ClangTidyContext , bool ApplyFixes, -llvm::IntrusiveRefCntPtr BaseFS) - : Files(FileSystemOptions(), BaseFS), DiagOpts(new DiagnosticOptions()), +

[PATCH] D45763: [clangd][tests] Fix handling of EOF in delimited input

jkorous updated this revision to Diff 143079. jkorous added a comment. Include the correct test. https://reviews.llvm.org/D45763 Files: JSONRPCDispatcher.cpp clangd/delimited-input-comment-at-the-end.test Index: clangd/delimited-input-comment-at-the-end.test

[PATCH] D45812: Fix __attribute__((force_align_arg_pointer)) misalignment bug

Gramner created this revision. Gramner added a reviewer: erichkeane. Gramner added a project: clang. Herald added a subscriber: javed.absar. The force_align_arg_pointer attribute was using a hardcoded 16-byte alignment value which in combination with -mstack-alignment=32 (or larger) would produce

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

krisb updated this revision to Diff 143072. krisb added a comment. Applied the comments Repository: rC Clang https://reviews.llvm.org/D45808 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCL/denorms-are-zero.cl Index: test/CodeGenOpenCL/denorms-are-zero.cl

[PATCH] D45284: [RISCV] More validations on the input value of -march=

asb added a comment. Herald added a subscriber: edward-jones. This is looking great, the only remaining code comment I have is that getExtensionFeatures needs a comment describing it. The remaining issue I have is more of a spec issue - do canonical ordering requirements apply to extension

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/denorms-are-zero.cl:9 +// CHECK-LABEL: define void @f() +// CHECK: attributes #{{[0-9]*}} = {{{[^}]*}} "denorms-are-zero"="true" Could we add a check for the false case too?

[PATCH] D45764: [clangd][tests] Fix delimiter handling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, thanks! LG, optional suggestion Comment at: JSONRPCDispatcher.cpp:281 // found a delimiter -if (LineRef.find_first_not_of('-') == llvm::StringRef::npos)

[PATCH] D45777: [UnitTests] NFC/build-perf: Break up nontrivial compile jobs

davezarzycki added a comment. Ping. Any review feedback would be appreciated. Thanks! Repository: rC Clang https://reviews.llvm.org/D45777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware updated this revision to Diff 143068. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D33537 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo abandoned this revision. mstorsjo added a comment. https://reviews.llvm.org/D45504 fixed the same issue in a better way. Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rL330310: OpenBSD add C++ runtime in a drivers standpoint (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45717: [clangd] Using index for GoToDefinition.

sammccall added inline comments. Comment at: clangd/XRefs.cpp:209 + llvm::DenseSet QuerySyms; + llvm::DenseMap ResultCandidates; sammccall wrote: > the approach could some documentation - I find it hard to follow the code. > > This

[PATCH] D45807: [libclang] Fix test LibclangReparseTest.FileName when TMPDIR is set to a symbolic link

petpav01 created this revision. petpav01 added reviewers: MaskRay, jbcoe. Herald added a subscriber: cfe-commits. Commit r329515 recently added new test `LibclangReparseTest.FileName`. This test fails in an environment which has

[PATCH] D45373: [clang-format] Don't remove empty lines before namespace endings

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/NamespaceEndCommentsFixer.h:24 +// Finds the namespace token corresponding to a closing namespace `}`, if that +// is to be formatted.

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl marked 21 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Driver/Options.td:552-553 +def : Joined<["--"], "offload-arch=">, Alias; +def offload_archs : Joined<["--"], "offload-archs=">, Flags<[DriverOption]>, + HelpText<"List of offload

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

Thanks! On 04/19/2018 03:39 PM, Haojian Wu wrote: Thanks! I didn't see this warning when running check-clang-tools on my machine. Fixed in r330327. On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén > wrote: Hi, On

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 143220. malaperle added a comment. Remove more includes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl updated this revision to Diff 143218. yaxunl marked 14 inline comments as done. yaxunl added a comment. Revised by Artem's comments. https://reviews.llvm.org/D45212 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Options.td

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 143219. malaperle marked 5 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. Sorry for the embarrassing clean-ups I forgot! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

modocache created this revision. modocache added reviewers: GorNishanov, EricWF. http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a proposed change to Coroutines TS that would have any exceptions thrown after the initial suspend point of a coroutine be caught by the handler

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

JDevlieghere added inline comments. Comment at: test/CodeGen/no-ident-version.c:1 +// RUN: %clang_cc1 -Qn -emit-llvm -debug-info-kind=limited -o - %s | FileCheck %s + Please test both -Qy and -Qn as well as the default case. https://reviews.llvm.org/D45255

r330338 - [CXX] Templates specialization visibility can be wrong

Author: steven_wu Date: Thu Apr 19 08:46:43 2018 New Revision: 330338 URL: http://llvm.org/viewvc/llvm-project?rev=330338=rev Log: [CXX] Templates specialization visibility can be wrong Summary: Under some conditions, LinkageComputer can get the visibility for ClassTemplateSpecializationDecl

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

aprantl added a comment. Does gcc's Qy/Qn option also affect the generated debug information? Clang is embedding the version number also into the DICompileUnit's producer string; I wonder if that should be affected by this option, too. https://reviews.llvm.org/D45255

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

This revision was automatically updated to reflect the committed changes. Closed by commit rL330338: [CXX] Templates specialization visibility can be wrong (authored by steven_wu, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44670

[PATCH] D45670: [NEON] Define vfma_n_f32() and vfmaq_n_f32() intrinsics in AArch32 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL330336: [NEON] Define vfma_n_f32() and vfmaq_n_f32() intrinsics in AArch32 mode (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

sammccall added a comment. I think this implementation will have problems in a "real" multi-machine MR framework. The lifetime of the Merger is the whole program, with output only coming at the end. With N workers, each will store >1/N of the symbols (more because of overlap), and the

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. In https://reviews.llvm.org/D45255#1072200, @aprantl wrote: > Does gcc's Qy/Qn option also affect the generated debug information? No, it does not. Do you think it would be better to leave debug information unchanged as well? https://reviews.llvm.org/D45255

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

JDevlieghere added a comment. Please run your changes through clang format before checking this in; otherwise LGTM. Repository: rC Clang https://reviews.llvm.org/D45045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45771: [Driver] Support for -save-stats in AddGoldPlugin.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM with comment nit Comment at: lib/Driver/ToolChains/CommonArgs.h:107 llvm::opt::OptSpecifier Group); +SmallString<128>

r330336 - [NEON] Define vfma_n_f32() and vfmaq_n_f32() intrinsics in AArch32 mode

Author: kosarev Date: Thu Apr 19 08:27:28 2018 New Revision: 330336 URL: http://llvm.org/viewvc/llvm-project?rev=330336=rev Log: [NEON] Define vfma_n_f32() and vfmaq_n_f32() intrinsics in AArch32 mode Differential Revision: https://reviews.llvm.org/D45670 Modified:

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

This revision was automatically updated to reflect the committed changes. Closed by commit rC330338: [CXX] Templates specialization visibility can be wrong (authored by steven_wu, committed by ). Changed prior to commit: https://reviews.llvm.org/D44670?vs=142961=143103#toc Repository: rC

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

xbolva00 added a comment. Another idea if you want to implement it - check fopen. FILE *f = fopen("file", "r"); // read only fputs("str", f); // we are writing -> boom, sigsegv or something like that. https://reviews.llvm.org/D45050 ___

[PATCH] D45726: Format closing braces when reformatting the line containing theopening brace.

krasimir added a comment. Another point: for the example in the summary about bailing-out early, is there a test for this already? If not, we should add one. Repository: rC Clang https://reviews.llvm.org/D45726 ___ cfe-commits mailing list

[PATCH] D44786: Lowering x86 adds/addus/subs/subus intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL330323: Lowering x86 adds/addus/subs/subus intrinsics (clang) (authored by aivchenk, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44786

[PATCH] D45373: [clang-format] Don't remove empty lines before namespace endings

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/NamespaceEndCommentsFixer.h:24 +// Finds the namespace token corresponding to a closing namespace `}`, if that +// is to be formatted. djasper wrote: > I don't

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

ilya-biryukov added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:53 +/// Combines occurrences of the same symbols across translation units. +class SymbolMerger { ilya-biryukov wrote: > sammccall wrote: > > Seems

[PATCH] D45373: [clang-format] Don't remove empty lines before namespace endings

This revision was automatically updated to reflect the committed changes. krasimir marked an inline comment as done. Closed by commit rL330324: [clang-format] Dont remove empty lines before namespace endings (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Changed

r330324 - [clang-format] Don't remove empty lines before namespace endings

Author: krasimir Date: Thu Apr 19 06:02:15 2018 New Revision: 330324 URL: http://llvm.org/viewvc/llvm-project?rev=330324=rev Log: [clang-format] Don't remove empty lines before namespace endings Summary: This implements an alternative to r327861, namely preserving empty lines before namespace

r330353 - [UnitTests] NFC/build-perf: Break up nontrivial compile jobs

Author: davezarzycki Date: Thu Apr 19 11:19:02 2018 New Revision: 330353 URL: http://llvm.org/viewvc/llvm-project?rev=330353=rev Log: [UnitTests] NFC/build-perf: Break up nontrivial compile jobs RecursiveASTVisitorTest.cpp is one of the longest compile jobs and a build bottleneck on many-core

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

efriedma added inline comments. Comment at: lib/Frontend/FrontendTiming.cpp:14 + +#include "llvm/Support/Timer.h" + This should include clang/Frontend/Utils.h . Comment at: test/Frontend/ftime-report-template-decl.cpp:2 +// RUN: %clang %s -S

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld updated this revision to Diff 143136. Hahnfeld marked 2 inline comments as done. Hahnfeld added a comment. Move `FunctionType`s to methods and change test prefixes. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device-stub.cu Index:

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:283-285 + llvm::FunctionType *RegisterGlobalsFnTy; + llvm::FunctionType *RegisterLinkedBinaryFnTy; + llvm::Function *DummyCallback; tra wrote: > Instead of tracking these through the

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:364-377 + llvm::Constant *NVModuleIDConstant; + SmallString<64> NVModuleID; + if (RelocatableDeviceCode) { +// Generate a unique module ID. +llvm::raw_svector_ostream OS(NVModuleID); +OS << "__nv_" <<

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya added a comment. The bug which motivated this warning is: https://github.com/jemalloc/jemalloc/commit/4df483f0fd76a64e116b1c4f316f8b941078114d#diff-7b26b977303fe92c093a2245b0eaf255 https://reviews.llvm.org/D45601 ___ cfe-commits mailing

[PATCH] D45827: [CUDA] Enable CUDA compilation with CUDA-9.2

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. https://reviews.llvm.org/D45827 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Driver/ToolChains/Cuda.cpp clang/lib/Headers/__clang_cuda_runtime_wrapper.h Index:

[PATCH] D37475: Make MultiplexASTDeserializationListener part of the API [NFC]

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D37475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45777: [UnitTests] NFC/build-perf: Break up nontrivial compile jobs

davezarzycki closed this revision. davezarzycki added a comment. Thanks @thakis! Committed as r330353 Repository: rC Clang https://reviews.llvm.org/D45777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45829: Remove impossible _MSC_VER check

rnk created this revision. rnk added a reviewer: EricWF. Herald added a subscriber: christof. It is immediately preceded by this check: #if _MSC_VER < 1900 #error "MSVC versions prior to Visual Studio 2015 are not supported" #endif https://reviews.llvm.org/D45829 Files:

[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:287 +CtorSuffix.append("_"); +CtorSuffix.append(ModuleName); + } There is a general problem with this approach. File name can contain the characters that PTX does not allow. We currently

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld updated this revision to Diff 143145. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Move module ID to corresponding `else` branch. https://reviews.llvm.org/D42922 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGenCUDA/device-stub.cu Index:

[PATCH] D45777: [UnitTests] NFC/build-perf: Break up nontrivial compile jobs

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rC Clang https://reviews.llvm.org/D45777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

aprantl added a comment. I'm not sure. Compatibility with GCC and getting identical output for debugging purposes seem to be at odds here. I personally lean slightly towards stripping it from the debug info as well. https://reviews.llvm.org/D45255

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:283-285 + llvm::FunctionType *RegisterGlobalsFnTy; + llvm::FunctionType *RegisterLinkedBinaryFnTy; + llvm::Function *DummyCallback; Instead of tracking these through the conditionals of pretty

[PATCH] D44435: CUDA ctor/dtor Module-Unique Symbol Name

tra added a comment. Could you please resubmit your patch with complete context? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface https://reviews.llvm.org/D44435 ___ cfe-commits mailing list

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman added a comment. In https://reviews.llvm.org/D45835#1072557, @efriedma wrote: > The list of features/extensions seems okay; it's information which is already > available through a stable interface (specifically, clang -E). JSON also > seems fine as a representation. > >

  1   2   >