r339651 - [X86] Lowering addus/subus intrinsics to native IR

Author: tkrupa Date: Tue Aug 14 01:01:38 2018 New Revision: 339651 URL: http://llvm.org/viewvc/llvm-project?rev=339651=rev Log: [X86] Lowering addus/subus intrinsics to native IR Summary: This is the patch that lowers x86 intrinsics to native IR in order to enable optimizations. Reviewers:

[PATCH] D46892: [X86] Lowering addus/subus intrinsics to native IR (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rC339651: [X86] Lowering addus/subus intrinsics to native IR (authored by tkrupa, committed by ). Changed prior to commit: https://reviews.llvm.org/D46892?vs=159461=160523#toc Repository: rC Clang

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

JonasToth added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:5 + +void DirectAcess(){ + absl::strings_internal::InternalFunction(); Please run clang-format over the test code as well. The braces here in `FriendUsage` miss a space.

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clangd/CodeComplete.cpp:721 + // would get 'std::basic_string'). + if (auto Func = Candidate.getFunction()) { +if (auto Pattern =

[libunwind] r339642 - [cmake] Add MINGW_LIBRARIES to the linker flags

Author: mstorsjo Date: Mon Aug 13 23:13:36 2018 New Revision: 339642 URL: http://llvm.org/viewvc/llvm-project?rev=339642=rev Log: [cmake] Add MINGW_LIBRARIES to the linker flags This is essential when building with -nodefaultlibs. In some CMake versions (noticed in 3.5.1), the same libraries

[PATCH] D50663: [libunwind] [cmake] Add MINGW_LIBRARIES to the linker flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL339642: [cmake] Add MINGW_LIBRARIES to the linker flags (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

thopre added a comment. Hi George, This commit seems to be causing some testsuite regression on Armv8 (both Aarch64 and ARM) architectures: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450 http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5625 Best regards,

[PATCH] D46892: [X86] Lowering addus/subus intrinsics to native IR (Clang part)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. https://reviews.llvm.org/D50689 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160622. owenpan added a comment. Simplified the test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

No test? On Tue, Aug 14, 2018 at 8:06 PM, Kevin P. Neal via cfe-commits wrote: > Author: kpn > Date: Tue Aug 14 10:06:56 2018 > New Revision: 339693 > > URL: http://llvm.org/viewvc/llvm-project?rev=339693=rev > Log: > > We have in place support for parsing #pragma FENV_ACCESS, but that >

[PATCH] D50564: Add support for SEH unwinding on Windows.

zturner added a comment. In https://reviews.llvm.org/D50564#1199285, @rnk wrote: > In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > > > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > > `` for the Win8 and Win10 SDKs? I can't install them right now. > >

[PATCH] D21767: Fix instantiation of friend function templates

sepavloff added a comment. In https://reviews.llvm.org/D21767#1197783, @rjmccall wrote: > Shouldn't there just be a link in the AST from the instantiated > `FunctionTemplateDecl ` back to the original pattern? Maybe a generalization > of `InstantiatedFromMember` in

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Yes, investigating. Will rollback if not fixed in a few hours. > On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator > wrote: > > yroux added a comment. > > Notice that the affected bots run two times the test cases where one > execution passes and one fails, as you can see in (search >

[PATCH] D50726: [clangd] Show function documentation in sigHelp

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Previously, clangd was trying to show documentation for the active parameter instead, which is wrong per LSP specification. Moreover, the code path

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

dexonsmith accepted this revision. dexonsmith added a comment. In https://reviews.llvm.org/D50719#1199427, @mclow.lists wrote: > I have pissed in this area, too - See > https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: > https://bugs.llvm.org/attachment.cgi?id=20692

[PATCH] D50715: [AST] Store the OwnedTagDecl as a trailing object in ElaboratedType.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D50715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, kadircet. Herald added subscribers: arphaman, mgrang, jkorous, MaskRay. Sema can only be used for documentation in the current file, other doc comments should be fetched from the index. Repository: rCTE Clang

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne marked an inline comment as done. ldionne added a comment. Ok, I'm pushing with JF's suggested change (use `TEST_STD_VER >= 11` instead of `__cplusplus >= 201103L`). Let's cross fingers that this is going to unbreak the testers -- like I said it fixed my Docker container. Repository:

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne added a comment. The goal of this commit is to fix build bot failures here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions/builds/286/steps/test.libcxx/logs/stdio. This failure was introduced when I fixed some unit tests that were no-ops in

[PATCH] D50526: Model type attributes as regular Attrs

rnk added a comment. The issue was related to ignored calling convention attributes on Win64: int a(int, const int *, int, int, __int64); class b { public: typedef int c; }; template void AtlAxDialogCreateT(int, d, int, int, __int64); int g, i, j, k; char *h; void l() {

[PATCH] D50724: SafeStack: Disable Darwin support

vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D50724#1199345, @kubamracek wrote: > Doesn't this need any tests to be updated? Otherwise, LGTM. There were no Darwin-specific safestack driver tests. I ran check-clang just to make sure and it passes. Repository: rC Clang

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160636. kadircet marked 4 inline comments as done. kadircet added a comment. - Get rid of getCancellationError. - Add replyError helper. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet added inline comments. Comment at: clangd/Cancellation.cpp:17 +namespace { +static Key>> CancellationTokenKey; +} // namespace ilya-biryukov wrote: > Having a `shared_ptr` key in the Context can cause data races (e.g. if we > copy it concurrently from

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1886 case BuiltinType::ObjCId: -mangleArtificalTagType(TTK_Struct, "objc_object"); +mangleArtificalTagType(TTK_Struct, ".objc_object"); break; DHowett-MSFT wrote: > I'm

[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help

ilya-biryukov updated this revision to Diff 160647. ilya-biryukov added a comment. - run clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50727 Files: clangd/ClangdServer.cpp clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.cpp

[libcxx] r339702 - [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

Author: ldionne Date: Tue Aug 14 11:16:56 2018 New Revision: 339702 URL: http://llvm.org/viewvc/llvm-project?rev=339702=rev Log: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES Summary: The macro was not defined in C++11 mode when it should have been, at least according to how

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339702: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D50719?vs=160616=160648#toc Repository:

RE: r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

It's a very small incremental change and I'm not sure it can be tested at this granularity. I see we have tests for FP_CONTRACT in tools/clang/tests/CodeGen/fp-contract* but I don't know how to run them. If you can tell me how to run them I can start on making FENV_ACCESS versions of them and

[PATCH] D50724: SafeStack: Disable Darwin support

kubamracek added a comment. Doesn't this need any tests to be updated? Otherwise, LGTM. Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r339697 - [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

Author: mstorsjo Date: Tue Aug 14 10:33:10 2018 New Revision: 339697 URL: http://llvm.org/viewvc/llvm-project?rev=339697=rev Log: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option This option should be available if LIBCXX_ENABLE_SHARED is enabled, not LIBCXX_ENABLE_STATIC.

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

george.karpenkov added subscribers: dcoughlin, bogner, NoQ, vlad.tsyrklevich. george.karpenkov added a comment. Yes, investigating. Will rollback if not fixed in a few hours. Repository: rC Clang https://reviews.llvm.org/D50594 ___ cfe-commits

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Let's watch out for possible breakages in any of the clients, though. I've checked VSCode and it seems to be fine with the added fields. Repository: rCTE Clang Tools

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

This revision was automatically updated to reflect the committed changes. Closed by commit rL339697: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. ...And it turns out Phab marked the comments as done when I uploaded the new change. I didn't know it would do that. That's useful to know. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 160642. Quuxplusone marked an inline comment as done. Quuxplusone added a comment. Rebased, and ping! Repository: rC Clang https://reviews.llvm.org/D50119 Files: docs/LanguageExtensions.rst include/clang/AST/DeclCXX.h include/clang/AST/Type.h

[PATCH] D50726: [clangd] Show function documentation in sigHelp

ilya-biryukov added a comment. There's a test for the new behavior in https://reviews.llvm.org/D50726 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. The macro was not defined in C++11 mode when it should have been, at least according to how _LIBCPP_HAS_C11_FEATURES is defined.

[PATCH] D50641: [clangd][test] Fix exit messages in tests

jkorous added a comment. I can see the value of getting more information in case of unexpected test behaviour but I still don't really like to have separate codepath for testing purposes. Anyway, it's not a big deal and it looks like you guys are all in agreement about this. I created a

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. From `__ISO_C_VISIBLE >= 2011` it looks like this tries to test C11 features regardless of the C++ version. That's probably fine, but we're walking this line where only C++17 really guarantees C11

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 160638. cdavis5x marked 3 inline comments as done. cdavis5x edited the summary of this revision. cdavis5x added a comment. - Update checks for DISPATCHER_CONTEXT definition. - Add link to KJK::Hyperion's articles on SEH. Repository: rUNW libunwind

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. Marked some comments as done. (Phab won't let me post an empty comment, so...) Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. I have pissed in this area, too - See https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: https://bugs.llvm.org/attachment.cgi?id=20692 How about I just make this change as part of that fix? Repository: rCXX libc++

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/TargetInfo.cpp:72 +// For 64-bit Android, alignment is 8 bytes for allocations <= 8 bytes. +NewAlign = (Triple.isArch64Bit() ||

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. Roughly, this is the direction where we are heading with `Expected`: https://github.com/Ericsson/clang/pull/457/commits/783b7f5cce9de589a5c3c3ae983398cf499077ec (If you are interested, here is our whole thought process: https://github.com/Ericsson/clang/pull/457)

[PATCH] D50564: Add support for SEH unwinding on Windows.

rnk added a comment. In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > `` for the Win8 and Win10 SDKs? I can't install them right now. I checked both, and they are available, so I think we should guard the

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

This revision was automatically updated to reflect the committed changes. Closed by commit rL339693 (authored by kpn, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49865?vs=158351=160626#toc Repository: rL LLVM

[PATCH] D50724: SafeStack: Disable Darwin support

vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: pcc, kubamracek. Herald added a subscriber: cfe-commits. Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-trivial programs. Repository: rC Clang

r339691 - Revert test commit

Author: kpn Date: Tue Aug 14 09:57:10 2018 New Revision: 339691 URL: http://llvm.org/viewvc/llvm-project?rev=339691=rev Log: Revert test commit Modified: cfe/trunk/lib/Parse/ParseAST.cpp Modified: cfe/trunk/lib/Parse/ParseAST.cpp URL:

r339690 - Test commit

Author: kpn Date: Tue Aug 14 09:56:25 2018 New Revision: 339690 URL: http://llvm.org/viewvc/llvm-project?rev=339690=rev Log: Test commit Modified: cfe/trunk/lib/Parse/ParseAST.cpp Modified: cfe/trunk/lib/Parse/ParseAST.cpp URL:

r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

Author: kpn Date: Tue Aug 14 10:06:56 2018 New Revision: 339693 URL: http://llvm.org/viewvc/llvm-project?rev=339693=rev Log: We have in place support for parsing #pragma FENV_ACCESS, but that information is then discarded with a warning to the user that we don't support it. This patch gets us

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. In https://reviews.llvm.org/D50564#1195985, @cdavis5x wrote: > In https://reviews.llvm.org/D50564#1195794, @mstorsjo wrote: > > > > Special thanks to KJK::Hyperion for his excellent series of articles on > > > how EH works on x86-64 Windows. (Seriously, check it out.

[PATCH] D50564: Add support for SEH unwinding on Windows.

mstorsjo added a comment. In https://reviews.llvm.org/D50564#1199285, @rnk wrote: > In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > > > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > > `` for the Win8 and Win10 SDKs? I can't install them right now. > >

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne added a comment. In https://reviews.llvm.org/D50719#1199427, @mclow.lists wrote: > I have pissed in this area, too - See > https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: > https://bugs.llvm.org/attachment.cgi?id=20692 > How about I just make this change

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. In https://reviews.llvm.org/D50719#1199450, @dexonsmith wrote: > If the bots are red from a previous commit I think it would be better for > Louis to commit this separately. I'm ok with that. Repository: rCXX libc++ https://reviews.llvm.org/D50719

[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

rjmccall added a comment. Sure, that seems like a reasonable optimization. Repository: rC Clang https://reviews.llvm.org/D50630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D48896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

ldionne added a comment. In https://reviews.llvm.org/D50341#1198863, @ldionne wrote: > In https://reviews.llvm.org/D50341#1198339, @vsapsai wrote: > > > What about defining a feature for unsupported configurations? I've tried > > > > if '__cpp_aligned_new' not in macros or \ > >

[PATCH] D50724: SafeStack: Disable Darwin support

This revision was automatically updated to reflect the committed changes. Closed by commit rL339720: SafeStack: Disable Darwin support (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50724 Files:

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. thinking about this more, I think this the wrong long-term direction. The presence/absence of C11 features in the underlying C library does not depend on what version of the C++ language we're compiling with. The tests that use `TEXT_HAS_C11_XXX` should be updated

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160652. kadircet marked 8 inline comments as done. kadircet added a comment. - Resolve discussions. - Get rid of CancellationHandler class. - Change error class name. - Improve documentation. Repository: rCTE Clang Tools Extra

r339709 - [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL

Author: george.karpenkov Date: Tue Aug 14 11:55:34 2018 New Revision: 339709 URL: http://llvm.org/viewvc/llvm-project?rev=339709=rev Log: [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL Modified: cfe/trunk/test/CMakeLists.txt Modified:

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Should be fixed now. > On Aug 14, 2018, at 1:10 AM, Thomas Preud'homme via Phabricator > wrote: > > thopre added a comment. > > Hi George, > > This commit seems to be causing some testsuite regression on Armv8 (both > Aarch64 and ARM) architectures: >

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

george.karpenkov added a comment. Should be fixed now. Repository: rC Clang https://reviews.llvm.org/D50594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r339720 - SafeStack: Disable Darwin support

Author: vlad.tsyrklevich Date: Tue Aug 14 12:50:41 2018 New Revision: 339720 URL: http://llvm.org/viewvc/llvm-project?rev=339720=rev Log: SafeStack: Disable Darwin support Summary: Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-trivial

[PATCH] D50731: [ASTImporter] Add test for ExprWithCleanups

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50731 Files: test/Import/expr-with-cleanups/Inputs/S.cpp test/Import/expr-with-cleanups/test.cpp Index:

[PATCH] D50732: [ASTImporter] Add test for CXXDefaultInitExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50732 Files: test/Import/cxx-default-init-expr/Inputs/S.cpp test/Import/cxx-default-init-expr/test.cpp Index:

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: mclow.lists, EricWF, jasonliu. Herald added subscribers: ldionne, christof. When a seed sequence would lead to having no non-zero significant bits in the initial state of a `mersenne_twister_engine`, the

r339704 - [OPENMP] Fix processing of declare target construct.

Author: abataev Date: Tue Aug 14 11:31:20 2018 New Revision: 339704 URL: http://llvm.org/viewvc/llvm-project?rev=339704=rev Log: [OPENMP] Fix processing of declare target construct. The attribute marked as inheritable since OpenMP 5.0 supports it + additional fixes to support new functionality.

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Should be fixed. > On Aug 14, 2018, at 10:32 AM, George Karpenkov via cfe-commits > wrote: > > Yes, investigating. Will rollback if not fixed in a few hours. > >> On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator >> wrote: >> >> yroux added a comment. >> >> Notice that the affected

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. @baloghadamsoftware @xazax.hun we've had very promising results with using Z3 for refutation so far, almost at no cost, see Mikhail's recent email on cfe-dev (and sometimes at a negative cost!). Do you still not want to try it first? False negatives could be

[PATCH] D50724: SafeStack: Disable Darwin support

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Hi, this should have been fixed by https://reviews.llvm.org/rC339709 > On Aug 14, 2018, at 12:16 PM, Galina Kistanova wrote: > > Hello George, > > This commit broke few of our builders: > >

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

morehouse added a comment. In https://reviews.llvm.org/D50670#1199556, @emmettneyman wrote: > Should I switch my focus to nested loops instead? I think nested loops will > increase coverage. Yes, I'd recommend doing that. Repository: rC Clang https://reviews.llvm.org/D50670

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

morehouse added a comment. Another option would be to allow simple control flow within the loop itself. Repository: rC Clang https://reviews.llvm.org/D50670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. A few more minor nits to be cleared up, but otherwise LGTM. You should wait for @rsmith to sign off before committing in case he has further comments, however.

r339721 - [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly

Author: ctopper Date: Tue Aug 14 13:21:05 2018 New Revision: 339721 URL: http://llvm.org/viewvc/llvm-project?rev=339721=rev Log: [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly Summary: Another piece of my ongoing to work for

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne updated this revision to Diff 160680. ldionne added a comment. Herald added a subscriber: mgorny. Add a way to change the default behavior of _LIBCPP_HIDE_FROM_ABI at build time. Also, rename the macro to _LIBCPP_ABI_HIDDEN_USE_INTERNAL_LINKAGE to align with other ABI-related macros.

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

emmettneyman added a comment. No, it doesn't actually. I thought it would try to combine the separate loops into one block of vectorized instructions but after looking at the coverage of multiple loops vs single loop, they cover exactly the same parts of the Loop Vectorizer. Should I switch my

[PATCH] D50618: Refactor Darwin driver to refer to runtimes by component

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 160660. cdavis5x added a comment. - Get rid of DISPATCHER_CONTEXT def for ARM. We only support ARM on Win8+ anyway. Repository: rUNW libunwind https://reviews.llvm.org/D50564 Files: include/__libunwind_config.h src/AddressSpace.hpp

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Hello George, This commit broke few of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/34845 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/19056

[PATCH] D50214: Add inherited attributes before parsed attributes.

aaron.ballman added inline comments. Comment at: lib/AST/DeclBase.cpp:854-859 + auto I = Attrs.begin(), E = Attrs.end(); + for (; I != E; ++I) { +if (!(*I)->isInherited()) + break; + } + Attrs.insert(I, A); Meinersbur wrote: > aaron.ballman wrote: >

[PATCH] D50735: [ASTImporter] Add test for CXXScalarValueInit

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50735 Files: test/Import/cxx-scalar-value-init/Inputs/S.cpp test/Import/cxx-scalar-value-init/test.cpp Index:

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. I will clean this up as part of https://bugs.llvm.org/show_bug.cgi?id=38495 Repository: rCXX libc++ https://reviews.llvm.org/D50719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans added a comment. @jolesiak let me know what you think Repository: rC Clang https://reviews.llvm.org/D50535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50678: [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rC339721: [InlineAsm] Update the min-legal-vector-width function attribute based on… (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D50678 Files:

[PATCH] D50733: [ASTImporter] Add test for ArrayInitLoopExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50733 Files: test/Import/array-init-loop-expr/Inputs/S.cpp test/Import/array-init-loop-expr/test.cpp Index:

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

mstorsjo added a comment. @hans I think this should be merged to 7.0, if reviewers agree with the change. Repository: rCXX libc++ https://reviews.llvm.org/D50691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r339661 - Merging r339431:

Author: hans Date: Tue Aug 14 02:13:39 2018 New Revision: 339661 URL: http://llvm.org/viewvc/llvm-project?rev=339661=rev Log: Merging r339431: r339431 | ldionne | 2018-08-10 15:24:56 +0200 (Fri, 10 Aug 2018) | 16 lines

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

ilya-biryukov updated this revision to Diff 160536. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Use 'auto*' instead of 'auto' Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50645 Files: clangd/CodeComplete.cpp

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:721 + // would get 'std::basic_string'). + if (auto Func = Candidate.getFunction()) { +if (auto Pattern = Func->getTemplateInstantiationPattern()) hokein wrote: > nit:

[PATCH] D50559: [gnu-objc] Make selector order deterministic.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339668: [gnu-objc] Make selector order deterministic. (authored by theraven, committed by ). Changed prior to commit: https://reviews.llvm.org/D50559?vs=160312=160545#toc Repository: rC Clang

r339668 - [gnu-objc] Make selector order deterministic.

Author: theraven Date: Tue Aug 14 03:05:25 2018 New Revision: 339668 URL: http://llvm.org/viewvc/llvm-project?rev=339668=rev Log: [gnu-objc] Make selector order deterministic. Summary: This probably fixes PR35277, though there may be other sources of nondeterminism (this was the only case of

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160531. kadircet marked 7 inline comments as done. kadircet added a comment. - Polished API. - Resolved discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Cancellation.cpp

Re: r339597 - Enforce instantiation of template multiversion functions

Merged to 7.0 in r339663. On Mon, Aug 13, 2018 at 8:33 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Mon Aug 13 11:33:20 2018 > New Revision: 339597 > > URL: http://llvm.org/viewvc/llvm-project?rev=339597=rev > Log: > Enforce instantiation of template multiversion functions

r339662 - [XRay][clang] Add more test cases of -fxray-modes= (NFC)

Author: dberris Date: Tue Aug 14 02:16:37 2018 New Revision: 339662 URL: http://llvm.org/viewvc/llvm-project?rev=339662=rev Log: [XRay][clang] Add more test cases of -fxray-modes= (NFC) This confirms expectations for multiple values provided through the driver when selecting specific modes and

[PATCH] D50695: [clangd] Always use the latest preamble

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, javed.absar. Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble` in TUScheduler (see the test for details), AST should always use NewPreamble.

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

yroux added a comment. Notice that the affected bots run two times the test cases where one execution passes and one fails, as you can see in (search Analysis/plist-macros.cpp for instance): http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450/steps/ninja%20check%201/logs/stdio

  1   2   3   >