[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

saghir created this revision. saghir added reviewers: ABataev, kkwli0, Hahnfeld, RaviNarayanaswamy, mikerice, hfinkel, gtbercea. saghir added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. This patch provides codegen support for close map-type-modifier in map clause. A map

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55892/new/ https://reviews.llvm.org/D55892 ___ cfe-commits

[PATCH] D55847: [gn build] Add build file for clang/lib/Basic and dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55847/new/ https://reviews.llvm.org/D55847 ___ cfe-commits mailing list

LLVM lab maintenance works in the nearest hour

Hello everyone, LLVM lab could be unavailable for very short time in about next half hour due to maintenance works in llvm lab. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3492 +def warn_ignored_objc_externally_retained : Warning< + "'objc_externally_retained' can only be applied to strong retainable " + "object pointer types with automatic

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 178928. erik.pilkington marked 10 inline comments as done. erik.pilkington added a comment. Address @aaron.ballman comments, rebase onto r349535. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus updated this revision to Diff 178927. Szelethus added a comment. I'm still looking for a sensible solution, but I'll at least share a patch that actually works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 Files:

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: test/Analysis/invalid-analyzer-config-value.c:72 +// even if -analyze isn't specified. +// RUN: %clang --analyze -Xclang -analyzer-config -Xclang remember=TheVasa %s +

r349655 - [CodeComplete] Properly determine qualifiers of 'this' in a lambda

Author: ibiryukov Date: Wed Dec 19 10:01:24 2018 New Revision: 349655 URL: http://llvm.org/viewvc/llvm-project?rev=349655=rev Log: [CodeComplete] Properly determine qualifiers of 'this' in a lambda Summary: The clang used to pick up the qualifiers of the lamba's call operator (which is always

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1335826 , @rjmccall wrote: > You're gating on OpenCL C++ in several places in this patch, but I don't > think you need to. This extension should be available to anyone using > address spaces and C++. Ok, I am

r349657 - [OPENMP]Mark the loop as started when initialized.

Author: abataev Date: Wed Dec 19 10:16:37 2018 New Revision: 349657 URL: http://llvm.org/viewvc/llvm-project?rev=349657=rev Log: [OPENMP]Mark the loop as started when initialized. Need to mark the loop as started when the initialization statement is found. It is required to prevent possible

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6162 +} + } + Anastasia wrote: > rjmccall wrote: > > This is enforcing a restriction that users write `const __private`, which > > seems unreasonable. It looks like

[PATCH] D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame.

NoQ updated this revision to Diff 178936. NoQ marked 2 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55804/new/ https://reviews.llvm.org/D55804 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/temporaries.cpp Index:

[PATCH] D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:224 +bool IsArray = false; +V = makeZeroElementRegion(State, V, ReturnTy, IsArray); +assert(!IsArray && "Returning array from a function!"); dcoughlin wrote:

[PATCH] D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered.

NoQ updated this revision to Diff 178938. NoQ marked an inline comment as done. NoQ added a comment. Indeed :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55873/new/ https://reviews.llvm.org/D55873 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.cpp

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai updated this revision to Diff 178921. vsapsai added a comment. - [ObjC++] Verify there are no unexpected calls. `--implicit-check-not` seems reasonable approach in this case. It causes adding `Inheritor` destructors but gives higher confidence there are no unexpected calls in unexpected

r349669 - PR40096: Forwards-compatible with C++20 rule regarding aggregates not having user-declared ctors

Author: dblaikie Date: Wed Dec 19 11:33:35 2018 New Revision: 349669 URL: http://llvm.org/viewvc/llvm-project?rev=349669=rev Log: PR40096: Forwards-compatible with C++20 rule regarding aggregates not having user-declared ctors Looks like these were in place to make these types move-only. That's

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ updated this revision to Diff 178963. NoQ added a comment. Remove the test change that wasn't caused by this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55875/new/ https://reviews.llvm.org/D55875 Files: lib/StaticAnalyzer/Core/Store.cpp test/Analysis/casts.c

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin updated this revision to Diff 178956. alexey.lapshin edited the summary of this revision. alexey.lapshin added a comment. Please consider this change: 1. addressed style issues and formatted patch with clang-format 2. renamed pragma pipeline_ii_count to

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

phosek added a comment. In D54724#1304986 , @dim wrote: > I think I understand the motivation, it's just that the toolchain classes > were split up specifically to avoid `if(OS==foo) ... else if(OS==bar) ... > else if(OS==baz)` mazes. So this feels a

r349691 - Disable -faddsig by default for PS4 target.

Author: dyung Date: Wed Dec 19 14:45:26 2018 New Revision: 349691 URL: http://llvm.org/viewvc/llvm-project?rev=349691=rev Log: Disable -faddsig by default for PS4 target. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/addrsig.c Modified:

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 179018. courbet marked 3 inline comments as done. courbet added a comment. address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files:

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

erik.pilkington updated this revision to Diff 178952. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Add Aaron's testcase, improve the documentation a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55628/new/ https://reviews.llvm.org/D55628

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

erik.pilkington added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3161 + if (!Tok.is(tok::period)) { +PP.Diag(Tok.getLocation(), diag::err_pragma_attribute_expected_period) +<< II; aaron.ballman wrote: > Can you reuse

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. It works! :D I guess, please commit this if you don't find anything better. Comment at: test/Analysis/invalid-analyzer-config-value.c:72 +// even if -analyze isn't specified. +//

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak updated this revision to Diff 178957. ahatanak added a comment. Remove the call to `CheckPlaceholderExpr` in `Sema::BuildDecltypeType` and move it to `Sema::DeduceAutoType`. Assert that the expression that is passed to `Sema::BuildDecltypeType` isn't a placeholder. Repository: rC

[PATCH] D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered.

NoQ updated this revision to Diff 178959. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55873/new/ https://reviews.llvm.org/D55873 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.cpp Index: test/Analysis/string.cpp

[PATCH] D55853: Ignore ConstantExpr in IgnoreParenNoopCasts

rnk updated this revision to Diff 178960. rnk added a comment. - move to IgnoreParens CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55853/new/ https://reviews.llvm.org/D55853 Files: clang/lib/AST/Expr.cpp clang/test/CodeGenCXX/mangle-ms-templates.cpp Index:

[PATCH] D55853: Ignore ConstantExpr in IgnoreParenNoopCasts

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/lib/AST/Expr.cpp:2694 while (true) { E = E->IgnoreParens(); rsmith wrote: > Maybe `IgnoreParens` should be doing this itself? I can do that, it passes tests. CHANGES

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak added a comment. In D55662#1335773 , @rjmccall wrote: > Okay. You may need to push an unevaluated context when doing that. Since I'm just moving the call to `CheckPlaceholderExpr` to the call site, I don't think I have to push an unevaluated

r349682 - [analyzer] CStringChecker: Fix a crash on C++ overloads of standard functions.

Author: dergachev Date: Wed Dec 19 13:50:46 2018 New Revision: 349682 URL: http://llvm.org/viewvc/llvm-project?rev=349682=rev Log: [analyzer] CStringChecker: Fix a crash on C++ overloads of standard functions. It turns out that it's not all that uncommon to have a C++ override of, say, memcpy

[PATCH] D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349682: [analyzer] CStringChecker: Fix a crash on C++ overloads of standard functions. (authored by dergachev, committed by ). Changed prior to commit:

r349683 - [analyzer] CStringChecker: Add the forgotten test file.

Author: dergachev Date: Wed Dec 19 13:51:59 2018 New Revision: 349683 URL: http://llvm.org/viewvc/llvm-project?rev=349683=rev Log: [analyzer] CStringChecker: Add the forgotten test file. Differential Revision: https://reviews.llvm.org/D55873 rdar://problem/45366551 Added:

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 178904. Anastasia marked an inline comment as done. Anastasia added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 Files: lib/Parse/ParseDecl.cpp

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6162 +} + } + rjmccall wrote: > This is enforcing a restriction that users write `const __private`, which > seems unreasonable. It looks like `ParseTypeQualifierList` takes a

[PATCH] D55885: [CodeComplete] Properly determine qualifiers of 'this' in a lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rL349655: [CodeComplete] Properly determine qualifiers of this in a lambda (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay updated this revision to Diff 178908. MaskRay edited the summary of this revision. MaskRay added a comment. Bring back MIPS special case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 Files:

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3694 + { +auto AnalyzerConfigArg = When I dump `Args` for the following invocation, I get this: `clang -c dummie.cpp -Xclang

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48753/new/ https://reviews.llvm.org/D48753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55895: NFC: simplify Darwin environment handling

jfb created this revision. jfb added reviewers: dexonsmith, arphaman. Herald added subscribers: cfe-commits, jkorous. The previous code detected conflicts through copy-pasta, this versions uses a 'loop'. Repository: rC Clang https://reviews.llvm.org/D55895 Files:

[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9492 static Value *EmitX86AddSubSatExpr(CodeGenFunction , - SmallVectorImpl , + SmallVectorImpl , bool IsSigned,

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:12357 + Context.getAsConstantArrayType(BaseExpr->getType()); + const Type *BaseType = BaseExpr->getType()->getPointeeOrArrayElementType(); + Using getPointeeOrArrayElementType here is

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

rjmccall added a comment. Thanks, LGTM. Somewhat surprised that we don't have an implicit copy of the `Strong` argument, but it's not a bad thing that we don't. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55543/new/ https://reviews.llvm.org/D55543

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3492 +def warn_ignored_objc_externally_retained : Warning< + "'objc_externally_retained' can only be applied to strong retainable " + "object pointer types with automatic storage">,

[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

RKSimon updated this revision to Diff 178946. RKSimon added a comment. Use ArrayRef Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55890/new/ https://reviews.llvm.org/D55890 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx2-builtins.c

Re: [PATCH] D55828: [clang] [Driver] Disable -faddrsig by default on NetBSD

On Wed, 2018-12-19 at 21:51 +0100, Joerg Sonnenberger wrote: > On Tue, Dec 18, 2018 at 04:35:54PM +, Michał Górny via Phabricator via > cfe-commits wrote: > > mgorny created this revision. > > mgorny added reviewers: krytarowski, pcc. > > > > Avoid passing -faddrsig by default on NetBSD.

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

sdardis added a comment. > I can't find rationale behind the MIPS discrepancy in the original commit. I > can add the if branch back if you tell me why... From my recollections, the gnu-hash style isn't supported in ld.bfd for MIPS. A patch was posted to the binutils list

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349676: [libcxx] Use custom allocators `construct` in C++03 when available. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: test/Analysis/bstring.cpp:47 + // The TRUE warning shows up on the path on which the vector is empty. clang_analyzer_eval(i == 66); // expected-warning {{UNKNOWN}} dcoughlin

[PATCH] D55847: [gn build] Add build file for clang/lib/Basic and dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL349677: [gn build] Add build file for clang/lib/Basic and dependencies (authored by nico, committed by ). Herald added subscribers: llvm-commits, delcypher, mgorny. Changed prior to commit:

[PATCH] D52117: Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

Meinersbur updated this revision to Diff 178944. Meinersbur added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52117/new/ https://reviews.llvm.org/D52117 Files: lib/CodeGen/CGLoopInfo.cpp lib/CodeGen/CGLoopInfo.h

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6117 + // to ensure that the variable is 'const' so that we can error on + // modification, which can otherwise overrelease. + VD->setType(Ty.withConst()); erik.pilkington wrote:

Re: [PATCH] D55828: [clang] [Driver] Disable -faddrsig by default on NetBSD

On Tue, Dec 18, 2018 at 04:35:54PM +, Michał Górny via Phabricator via cfe-commits wrote: > mgorny created this revision. > mgorny added reviewers: krytarowski, pcc. > > Avoid passing -faddrsig by default on NetBSD. This platform is still > using old GNU binutils that crashes on executables

[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55890/new/ https://reviews.llvm.org/D55890 ___

[PATCH] D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2317-2320 else if (isCPPStdLibraryFunction(FDecl, "copy")) evalFunction = ::evalStdCopy; else if (isCPPStdLibraryFunction(FDecl, "copy_backward")) evalFunction =

[PATCH] D55895: NFC: simplify Darwin environment handling

arphaman added a comment. I think we might need to run it past the internal builds to see if anything breaks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55895/new/ https://reviews.llvm.org/D55895 ___ cfe-commits

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: test/Analysis/invalid-analyzer-config-value.c:72 +// even if -analyze isn't specified. +// RUN: %clang --analyze -Xclang -analyzer-config -Xclang remember=TheVasa %s + NoQ

[PATCH] D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349696: [analyzer] Improve modeling for returning an object from the top frame with RVO. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r349696 - [analyzer] Improve modeling for returning an object from the top frame with RVO.

Author: dergachev Date: Wed Dec 19 15:14:06 2018 New Revision: 349696 URL: http://llvm.org/viewvc/llvm-project?rev=349696=rev Log: [analyzer] Improve modeling for returning an object from the top frame with RVO. Static Analyzer processes the program function-by-function, sometimes diving into

r349698 - [analyzer] GenericTaint: Fix formatting to prepare for incoming improvements.

Author: dergachev Date: Wed Dec 19 15:35:08 2018 New Revision: 349698 URL: http://llvm.org/viewvc/llvm-project?rev=349698=rev Log: [analyzer] GenericTaint: Fix formatting to prepare for incoming improvements. Patch by Gábor Borsik! Differential Revision: https://reviews.llvm.org/D54918

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rC349698: [analyzer] GenericTaint: Fix formatting to prepare for incoming improvements. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55875/new/ https://reviews.llvm.org/D55875 ___ cfe-commits

r349701 - [analyzer] pr38668: Do not attempt to cast loaded values of non-scalar types.

Author: dergachev Date: Wed Dec 19 15:48:44 2018 New Revision: 349701 URL: http://llvm.org/viewvc/llvm-project?rev=349701=rev Log: [analyzer] pr38668: Do not attempt to cast loaded values of non-scalar types. It is expected to have the same object (memory region) treated as if it has different

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349701: [analyzer] pr38668: Do not attempt to cast loaded values of non-scalar types. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55879: [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic intrinsics (clang)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, nikic, tkrupa. Herald added a subscriber: llvm-commits. Sibling patch to D55855 , this emits UADD_SAT/USUB_SAT generic intrinsics for the SSE saturated math intrinsics instead of

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

riccibruno updated this revision to Diff 178848. riccibruno marked 4 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55862/new/ https://reviews.llvm.org/D55862 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/array-bounds.cpp Index:

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus added a comment. Yea, should've used `hasArg` anyways. I'll look into this tonight. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 ___ cfe-commits mailing list

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

riccibruno added a comment. > Yes, I was thinking about the same thing! However, I believe that some people > may find this kind of "redundant" access specs actually more readable, so > maybe it makes sense to add a check option for this > to allow users to > disable it? Perhaps ? I will

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay marked 3 inline comments as done. dylanmckay added a comment. > I'm not certain if it will be possible to devise test cases for the two > diagnostics I pointed out or not I don't think it will be. The compile warning logic works by directly querying the physical filesystem using the

[PATCH] D55818: [clangd] Unify path canonicalizations in the codebase

This revision was automatically updated to reflect the committed changes. Closed by commit rL349618: [clangd] Unify path canonicalizations in the codebase (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] r349618 - [clangd] Unify path canonicalizations in the codebase

Author: kadircet Date: Wed Dec 19 02:46:21 2018 New Revision: 349618 URL: http://llvm.org/viewvc/llvm-project?rev=349618=rev Log: [clangd] Unify path canonicalizations in the codebase Summary: There were a few different places where we canonicalized paths, each one had its own flavor. This patch

[PATCH] D55818: [clangd] Unify path canonicalizations in the codebase

kadircet updated this revision to Diff 178856. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55818/new/ https://reviews.llvm.org/D55818 Files:

[PATCH] D55862: [Sema] Don't try to account for the size of an incomplete type in CheckArrayAccess

riccibruno added inline comments. Comment at: test/SemaCXX/array-bounds.cpp:294 + C () { return reinterpret_cast(xxx)[1]; } // no-warning + C () { return reinterpret_cast(xxx)[2]; } // expected-warning {{array index 2 is past the end of the array (which contains 2 elements)}}

[PATCH] D55818: [clangd] Unify path canonicalizations in the codebase

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clangd/SourceCode.cpp:203 +FilePath)) { + elog("Could not turn relative path to absolute: {0}: {1}", FilePath, +

[PATCH] D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D55784#1334929 , @hwright wrote: > @aaron.ballman I am both grateful and sad that I don't possess the same macro > creativity as you

[PATCH] D55879: [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic intrinsics (clang)

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - I haven't looked in a while to see if it works, but I thought we have a script to auto-generate the CHECK lines for C-->IR tests, so we wouldn't need to 'CHECK-NOT' in these functions.

[PATCH] D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered.

Szelethus accepted this revision. Szelethus added a comment. Cheers! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55873/new/ https://reviews.llvm.org/D55873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55848/new/ https://reviews.llvm.org/D55848

[PATCH] D55885: [CodeComplete] Properly determine qualifiers of 'this' in a lambda

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. The clang used to pick up the qualifiers of the lamba's call operator (which is always const) and fail to show non-const methods of 'this' in completion results. Repository: rC Clang

[PATCH] D55199: Python2/3 compat - urllib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC349627: Portable Python script across Python version (authored by serge_sans_paille, committed by ). Herald added a

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

aaron.ballman added a comment. In D55628#1335841 , @erik.pilkington wrote: > After looking through some users of `#pragma clang attribute`, I don't think > that the begin/end solution is what we want here. Some users of this > attribute write macros

r349627 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 19 05:46:13 2018 New Revision: 349627 URL: http://llvm.org/viewvc/llvm-project?rev=349627=rev Log: Portable Python script across Python version urllib2 as been renamed into urllib and the library layout has changed. Workaround that in a consistent manner.

[PATCH] D55861: [OpenMP] Fix data sharing analysis in nested clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55861/new/ https://reviews.llvm.org/D55861 ___ cfe-commits

[PATCH] D55879: [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC349631: [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic… (authored by RKSimon, committed by ). Changed prior to commit:

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin added reviewers: rsmith, chandlerc, rnk, ABataev. rengolin added a comment. Adding clang/omp developers for proper review. Please feel free to add more. FYI, there are four main ongoing discussions on the LLVM thread (D53927 ): 1. There is collusion

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1357 + bool isARCPseudoStrong() const { return VarDeclBits.ARCPseudoStrong; } + void setARCPseudoStrong(bool ps) { VarDeclBits.ARCPseudoStrong = ps; } Can you update `ps` to be

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

aaron.ballman added a comment. In D55793#1335243 , @m4tx wrote: > In D55793#1333723 , @riccibruno > wrote: > > > In D55793#1333691 , @m4tx wrote: > > > > > Don't use

[clang-tools-extra] r349623 - [clang-tidy] use "const SourceManager&" parameter, NFC.

Author: hokein Date: Wed Dec 19 05:25:08 2018 New Revision: 349623 URL: http://llvm.org/viewvc/llvm-project?rev=349623=rev Log: [clang-tidy] use "const SourceManager&" parameter, NFC. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified:

r349626 - [Index] Index paremeters in lambda expressions.

Author: hokein Date: Wed Dec 19 05:44:41 2018 New Revision: 349626 URL: http://llvm.org/viewvc/llvm-project?rev=349626=rev Log: [Index] Index paremeters in lambda expressions. Summary: This fixes clangd couldn't find references for lambda parameters. Reviewers: ilya-biryukov Subscribers:

[PATCH] D55437: [Index] Index declarations in lambda expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349626: [Index] Index paremeters in lambda expressions. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D55437?vs=178688=178870#toc Repository: rC Clang

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178882. courbet marked 2 inline comments as done. courbet added a comment. move PrintQualifiedTypes to PrintingPolicy Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files:

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet added inline comments. Comment at: include/clang/AST/Stmt.h:847 + const ASTContext *Context = nullptr, + bool PrintCanonicalTypes = false) const; aaron.ballman wrote: > I'm pretty wary of long lists of parameters

[clang-tools-extra] r349632 - [clangd] Fix a syntax error on the test.

Author: hokein Date: Wed Dec 19 06:51:07 2018 New Revision: 349632 URL: http://llvm.org/viewvc/llvm-project?rev=349632=rev Log: [clangd] Fix a syntax error on the test. Modified: clang-tools-extra/trunk/unittests/clangd/FindSymbolsTests.cpp Modified:

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

aaron.ballman added inline comments. Comment at: lib/AST/StmtPrinter.cpp:78 const PrintingPolicy , unsigned Indentation = 0, -StringRef NL = "\n", -const ASTContext *Context = nullptr) +StringRef NL = "\n", const

[PATCH] D55885: [CodeComplete] Properly determine qualifiers of 'this' in a lambda

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55885/new/ https://reviews.llvm.org/D55885 ___

r349631 - [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic intrinsics (clang)

Author: rksimon Date: Wed Dec 19 06:43:47 2018 New Revision: 349631 URL: http://llvm.org/viewvc/llvm-project?rev=349631=rev Log: [X86][SSE] Auto upgrade PADDUS/PSUBUS intrinsics to UADD_SAT/USUB_SAT generic intrinsics (clang) Sibling patch to D55855, this emits UADD_SAT/USUB_SAT generic

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 178884. steleman added a comment. Removed spurious patch for an unrelated change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928 Files: include/clang/Basic/Builtins.def

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

ilya-biryukov added a comment. Could we add a capability to the init request to check for this extension? We don't want to send those notifications to clients that don't have the code to handle them. Another observation: when I played around with the previous version of the patch,

[PATCH] D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-comparison.cpp:146 +#define VALUE_IF_2(e) (e) +#define VALUE_IF(v, e, type) (v ? VALUE_IF_2(absl::To##type##Seconds(e)) : 0) + int a3 = VALUE_IF(1, d1, Double);

[clang-tools-extra] r349636 - [clang-tidy] Diagnose abseil-duration-comparison on macro arguments

Author: hwright Date: Wed Dec 19 08:03:34 2018 New Revision: 349636 URL: http://llvm.org/viewvc/llvm-project?rev=349636=rev Log: [clang-tidy] Diagnose abseil-duration-comparison on macro arguments Summary: This change relaxes the requirements on the utility `rewriteExprFromNumberToDuration`

  1   2   >