[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. Herald added a project: clang. Could you please update this to match the LLD version? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/ https://reviews.llvm.org/D57404 ___ cfe-commits

[PATCH] D57553: [Fixed Point Arithmetic] Check against source value when converting during saturation

ebevhan added a comment. This doesn't seem to address the particular case in the integer conversion patch. In fact, I don't see those conversions at all. Comment at: clang/test/Frontend/fixed_point_add.c:382 + // CHECK-NEXT: [[USE_MIN:%[0-9]+]] = icmp slt i39 [[SUM]], -32768

[clang-tools-extra] r352841 - [clangd] Fix -DBUILD_SHARED_LIBS=ON build - SwapIfBranches needs clangAST.

Author: lebedevri Date: Fri Feb 1 00:23:23 2019 New Revision: 352841 URL: http://llvm.org/viewvc/llvm-project?rev=352841=rev Log: [clangd] Fix -DBUILD_SHARED_LIBS=ON build - SwapIfBranches needs clangAST. Else, fails with: [1/2] Linking CXX executable bin/clangd FAILED: bin/clangd : &&

[clang-tools-extra] r352843 - [clangd] clangDaemonTweaks - fix -DBUILD_SHARED_LIBS=ON build

Author: lebedevri Date: Fri Feb 1 00:58:37 2019 New Revision: 352843 URL: http://llvm.org/viewvc/llvm-project?rev=352843=rev Log: [clangd] clangDaemonTweaks - fix -DBUILD_SHARED_LIBS=ON build Followup for rL352841. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clangd/XRefs.cpp:38 + // Only a single declaration is allowed. + if (isa(D)) // except cases above +return D; sammccall wrote: >

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. @arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place. There are two issues still pending: - `index-file.cu` still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just

[PATCH] D57573: Disable tidy checks with too many hits

This revision was automatically updated to reflect the committed changes. Closed by commit rC352862: Disable tidy checks with too many hits (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D57573?vs=184714=184715#toc Repository: rC Clang CHANGES

r352862 - Disable tidy checks with too many hits

Author: ibiryukov Date: Fri Feb 1 03:20:13 2019 New Revision: 352862 URL: http://llvm.org/viewvc/llvm-project?rev=352862=rev Log: Disable tidy checks with too many hits Summary: Some tidy checks have too many hits in the codebase, making it hard to spot other results from clang-tidy, therefore

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352864: [clangd] Implement textDocument/declaration from LSP 3.14 (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D57388?vs=184710=184718#toc Repository:

[PATCH] D57571: [clang-tidy] A new OpenMP module

lebedev.ri added a comment. In D57571#1380421 , @JonasToth wrote: > LGTM. In D57571#1380421 , @JonasToth wrote: > Committing both revision together would be good :) Yes. I can't land them since D57112

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong updated this revision to Diff 184694. martong marked 2 inline comments as done. martong added a comment. Herald added a project: clang. - Remove unrelated hunks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong added a comment. Update: I just removed the unrelated changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57573: Disable tidy checks with too many hits

ilya-biryukov created this revision. ilya-biryukov added a reviewer: alexfh. Herald added projects: clang, LLVM. Some tidy checks have too many hits in the codebase, making it hard to spot other results from clang-tidy, therefore rendering the tool less useful. Two checks were disabled: -

[clang-tools-extra] r352857 - [clangd] Unbreak fuzzer target

Author: sammccall Date: Fri Feb 1 03:09:06 2019 New Revision: 352857 URL: http://llvm.org/viewvc/llvm-project?rev=352857=rev Log: [clangd] Unbreak fuzzer target Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp

[PATCH] D57573: Disable tidy checks with too many hits

ilya-biryukov updated this revision to Diff 184714. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57573/new/ https://reviews.llvm.org/D57573 Files:

r352865 - [CUDA] Relax lit test condition after r352798.

Author: ioeric Date: Fri Feb 1 03:36:23 2019 New Revision: 352865 URL: http://llvm.org/viewvc/llvm-project?rev=352865=rev Log: [CUDA] Relax lit test condition after r352798. Clang executable doesn't match clang.* in all test environment. Modified: cfe/trunk/test/Driver/cuda-detect.cu

[PATCH] D57242: [RISCV] Specify MaxAtomicInlineWidth for RISC-V

lewis-revill abandoned this revision. lewis-revill added a comment. Herald added a project: clang. Abandoned in favour of D57450 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57242/new/ https://reviews.llvm.org/D57242

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 184692. lebedev.ri retitled this revision from "[clang-tidy] openmp-use-default-none - a new module and a check" to "[clang-tidy] openmp-use-default-none - a new check". lebedev.ri edited the summary of this revision. lebedev.ri added a parent revision:

[PATCH] D57571: [clang-tidy] A new OpenMP module

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, xazax.hun, hokein. lebedev.ri added projects: clang-tools-extra, OpenMP. Herald added subscribers: openmp-commits, arphaman, guansong, rnkovacs, mgorny. Herald added a project: clang. Just the empty

[PATCH] D57573: Disable tidy checks with too many hits

ilya-biryukov updated this revision to Diff 184704. ilya-biryukov added a comment. - Also disable 'misc-non-private-member-variables-in-classes' in llvm/.clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57573/new/

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Sure, r352854. On Wed, Jan 30, 2019 at 10:16 PM Erik Pilkington wrote: > > Hans, can you cherry-pick this into LLVM 8? > > Thanks! > > On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: > > Author: epilk > > Date: Wed Jan 30 13:14:08 2019 > > New Revision: 352672 > > > > URL:

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

sammccall updated this revision to Diff 184710. sammccall added a comment. address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57388/new/ https://reviews.llvm.org/D57388 Files: clangd/ClangdLSPServer.cpp

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/XRefs.cpp:38 + // Only a single declaration is allowed. + if (isa(D)) // except cases above +return D; hokein wrote: > sammccall wrote: > > hokein wrote: > > >

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Thanks! I've merged r352822 to the branch in r352855. On Fri, Feb 1, 2019 at 1:37 AM Shoaib Meenai wrote: > > +Hans for managing the 8.0 branch. > > On 1/31/19, 4:15 PM, "ahatan...@apple.com on behalf of Akira Hatanaka" > wrote: > > Reverted patch in r352822. I’ll send a new patch later

[PATCH] D57573: Disable tidy checks with too many hits

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I'm +1 on disabling these checks as they add too much noise in editors (even though the naming check is correct, we can't do a global cleanup on the codebase). Let's commit it, we could

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 184712. ilya-biryukov added a comment. - Revert "changes to main" - Compute the path in parseTranslationUnit2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532

Re: r352156 - [AArch64] Make the test for rsr and rsr64 stricter

Merged to 8.0 in r352859. On Fri, Jan 25, 2019 at 3:42 AM Petr Hosek via cfe-commits wrote: > > Author: phosek > Date: Thu Jan 24 18:42:30 2019 > New Revision: 352156 > > URL: http://llvm.org/viewvc/llvm-project?rev=352156=rev > Log: > [AArch64] Make the test for rsr and rsr64 stricter > > ACLE

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai created this revision. nemanjai added reviewers: rogfer01, bruno, ahatanak, scanon. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. We unconditionally predefine these macros. However, they may be used to determine if the type is

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4693 +T2Quals.addAddressSpace(AS2); + QualType WithAScv1T4 = S.Context.getQualifiedType(IgnoreAScv2T2, T1Quals); +

[PATCH] D57571: [clang-tidy] A new OpenMP module

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. Committing both revision together would be good :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57571/new/

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 184697. martong added a comment. Herald added a project: clang. - Move hunks into this patch from parent patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files:

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

Merged in r352860. On Tue, Jan 29, 2019 at 2:48 PM Hans Wennborg wrote: > > Thanks! I'll merge it after it's been in trunk for a little. Please > let me know if there are any issues or follow-up commits. > > Cheers, > Hans > > On Tue, Jan 29, 2019 at 4:04 AM Sam Parker wrote: > > > > Hi Hans, >

Re: r352463 - [AArch64] Update int64_t ACLE builtin arguments

Merged to 8.0 in r352860. On Tue, Jan 29, 2019 at 10:03 AM Sam Parker via cfe-commits wrote: > > Author: sam_parker > Date: Tue Jan 29 01:04:03 2019 > New Revision: 352463 > > URL: http://llvm.org/viewvc/llvm-project?rev=352463=rev > Log: > [AArch64] Update int64_t ACLE builtin arguments > >

[clang-tools-extra] r352863 - [clangd] Use delimited style to make life easier for the fuzzer

Author: sammccall Date: Fri Feb 1 03:20:20 2019 New Revision: 352863 URL: http://llvm.org/viewvc/llvm-project?rev=352863=rev Log: [clangd] Use delimited style to make life easier for the fuzzer Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified:

[clang-tools-extra] r352864 - [clangd] Implement textDocument/declaration from LSP 3.14

Author: sammccall Date: Fri Feb 1 03:26:13 2019 New Revision: 352864 URL: http://llvm.org/viewvc/llvm-project?rev=352864=rev Log: [clangd] Implement textDocument/declaration from LSP 3.14 Summary: LSP now reflects the declaration/definition distinction. Language server changes: -

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: lib/Basic/Targets/WebAssembly.h:55 IntPtrType = SignedLong; +HasFloat16 = true; } There are test cases that check for the macros for WebAssembly so I assumed they

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } ebevhan wrote: > Anastasia wrote: > > Anastasia wrote: > > > ebevhan wrote: > > > > Is there a reason that the attributes are

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

sgraenitz added a comment. In D57521#1379837 , @beanz wrote: > @phosek, does LLVM’s runtime directory do this correctly? > > At some point we should try and deprecate and remove this option in favor of > the LLVM directory because the LLVM approach is

[clang-tools-extra] r352868 - [clangd] Penalize file-scope symbols in the ranking for non-completion queries

Author: sammccall Date: Fri Feb 1 05:07:37 2019 New Revision: 352868 URL: http://llvm.org/viewvc/llvm-project?rev=352868=rev Log: [clangd] Penalize file-scope symbols in the ranking for non-completion queries Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D56653

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai created this revision. nemanjai added reviewers: ilya-biryukov, jfb, takuto.ikuta, rjmccall, rsmith, SjoerdMeijer, t.p.northover, erichkeane. Herald added a subscriber: eraman. Herald added a project: clang. One of the platforms on which we do regular builds has some system headers that

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

xazax.hun added a comment. Thank you for working on this! I have two concerns: - The logic when should we import the initializer of a VarDecl is duplicated. I think to have better maintainability it would be better to have only one implementation of the decision in a function and call it

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh updated this revision to Diff 184740. lildmh added a comment. Herald added a subscriber: openmp-commits. Rebase. Hi Alexey, Thanks a lot for the review! It seems no one else will review it. If you think it's ready to go, could you please accept this patch? I also need help to commit

[clang-tools-extra] r352874 - [clangd] Lib to compute and represent selection under cursor.

Author: sammccall Date: Fri Feb 1 07:05:11 2019 New Revision: 352874 URL: http://llvm.org/viewvc/llvm-project?rev=352874=rev Log: [clangd] Lib to compute and represent selection under cursor. Summary: The primary problem this solves is to expose the codeAction selection to AST-based

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

lebedev.ri added a comment. In D57585#1380673 , @ABataev wrote: > LG Okay, that sounds promising, thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57585/new/ https://reviews.llvm.org/D57585

[clang-tools-extra] r352875 - [clangd] Lib to compute and represent selection under cursor.

Author: sammccall Date: Fri Feb 1 07:09:41 2019 New Revision: 352875 URL: http://llvm.org/viewvc/llvm-project?rev=352875=rev Log: [clangd] Lib to compute and represent selection under cursor. Summary: The primary problem this solves is to expose the codeAction selection to AST-based

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, OpenMP. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: openmp-commits, guansong. I'm working on a clang-tidy check, much like existing bugprone-exception-escape

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

sunfish added a comment. I think WebAssembly is in the same situation as most other architectures, as discussed here: http://llvm.org/viewvc/llvm-project?view=revision=352221 and should not enable _Float16 yet. The test/Preprocessor/init.c tests were semi-automatically generated, so it wasn't

[clang-tools-extra] r352876 - [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches.

Author: sammccall Date: Fri Feb 1 07:09:47 2019 New Revision: 352876 URL: http://llvm.org/viewvc/llvm-project?rev=352876=rev Log: [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches. Summary: This reduces the per-check implementation burden and redundant work. It also

r352881 - [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

Author: stefan.graenitz Date: Fri Feb 1 07:35:25 2019 New Revision: 352881 URL: http://llvm.org/viewvc/llvm-project?rev=352881=rev Log: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests Summary: Apparently `LLVMTestingSupport` must be built before

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL352881: [CMake] External compiler-rt-configure requires LLVMTestingSupport when… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST

r352882 - [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

Author: lebedevri Date: Fri Feb 1 07:41:54 2019 New Revision: 352882 URL: http://llvm.org/viewvc/llvm-project?rev=352882=rev Log: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks Summary: I'm working on a clang-tidy check, much like existing [[

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC352882: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

xazax.hun added a comment. Herald added a project: clang. In D46421#1375147 , @r.stahl wrote: > In D46421#1374807 , @NoQ wrote: > > > At the same time, i don't have any test cases for the actual change in > >

[PATCH] D57556: Fix for -DBUILD_SHARED_LIBS=ON build after rL352803

MaskRay added a comment. Sorry I didn't notice this. D57345 has been fixed in rC352872 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57556/new/ https://reviews.llvm.org/D57556

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Accepted, just was not marked as accepted for an unknown reason. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57585/new/ https://reviews.llvm.org/D57585 ___ cfe-commits

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh added a comment. Thanks a lot Alexey! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM. I'll trust you on the actual address-class values. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57162/new/

r352842 - Test commit: fix typo

Author: smateo Date: Fri Feb 1 00:39:01 2019 New Revision: 352842 URL: http://llvm.org/viewvc/llvm-project?rev=352842=rev Log: Test commit: fix typo Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

r352838 - Fix isInSystemMacro to handle pasted macros

Author: serge_sans_paille Date: Thu Jan 31 22:11:44 2019 New Revision: 352838 URL: http://llvm.org/viewvc/llvm-project?rev=352838=rev Log: Fix isInSystemMacro to handle pasted macros Token pasted by the preprocessor (through ##) have a Spelling pointing to scratch buffer. As a result they are

r352849 - Provide reason messages for unviable inlining

Author: yrouban Date: Fri Feb 1 02:44:43 2019 New Revision: 352849 URL: http://llvm.org/viewvc/llvm-project?rev=352849=rev Log: Provide reason messages for unviable inlining InlineCost's isInlineViable() is changed to return InlineResult instead of bool. This provides messages for failure

[PATCH] D56555: Add Attribute to define nonlazy objc classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555

r352872 - [libclang] Fix -DBUILD_SHARED_LIBS=on build after rC352803

Author: maskray Date: Fri Feb 1 06:31:01 2019 New Revision: 352872 URL: http://llvm.org/viewvc/llvm-project?rev=352872=rev Log: [libclang] Fix -DBUILD_SHARED_LIBS=on build after rC352803 Modified: cfe/trunk/tools/libclang/CMakeLists.txt Modified: cfe/trunk/tools/libclang/CMakeLists.txt

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong added a comment. Herald added a project: clang. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://reviews.llvm.org/D57236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM with a renaming request. Comment at: include/clang/AST/ASTDumpTraverser.h:83 + + NodeVisitorType () { return

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Herald added a project: clang. Comment at: test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:360-361 + struct Type { +Typo(); // expected-error{{deduction guide must be declared in

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

erichkeane added a comment. This seems innocuous to me. I don't see any problem with it, but please don't commit until the others have had time to look. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581

[PATCH] D57576: Adding support to the OpenMP mutexinoutset dependency type

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57576/new/ https://reviews.llvm.org/D57576 ___ cfe-commits

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

mgorny added a comment. Ideally we wouldn't introduce such a complex dependency for 2 test cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___ cfe-commits mailing list

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

ilya-biryukov added a comment. The change looks reasonable to me, given that you can change the default language version via a build argument. I don't have the required experience with the lit-tests to give proper approval, though, would wait for someone more relevant to do this. Do have a

[PATCH] D57576: Adding support to the OpenMP mutexinoutset dependency type

smateo added a comment. Thanks for the review, I will upload it shortly! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57576/new/ https://reviews.llvm.org/D57576 ___ cfe-commits mailing list

[PATCH] D57220: Test fix for isViableInline remark message

xbolva00 added inline comments. Herald added a project: clang. Comment at: test/Frontend/optimization-remark-with-hotness.c:63 // NO_PGO: '-fdiagnostics-hotness-threshold=' requires profile-guided optimization information // expected-remark@+1 {{foo inlined into bar with

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > Anastasia wrote: > > > > ebevhan wrote: > > > > > Is there a reason that the attributes are parsed here and not

Re: r352055 - Fix failing buildbots

Hello Sorry for the late reply. I'm not sure this ifdef is quite correct. It will be testing the _host_ architecture, presuming the default target is the same. If they are different (for example if the default target is aarch64 on an x86 machine), the test will presumably still fail. I went

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

ABataev added a comment. In D57162#1380795 , @probinson wrote: > LGTM. I'll trust you on the actual address-class values. Thanks, Paul! If you want, you can find those values in the table here

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai added a comment. In D57581#1380609 , @ilya-biryukov wrote: > ... > Do have a comment, though. Any, reason to use `-std=gnu++14` and not > `-std=c++14`? > Most (all?) of the tests do not seem to have anything to do with the gnu > extensions,

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s updated this revision to Diff 184766. Dor1s added a comment. Herald added a project: clang. Clarify that only linkers other than LLD are affected. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 Files:

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl added a comment. Thanks for the comments! All good points. Nice idea with the constructor, but that can probably happen in a follow up patch. In D46421#1380619 , @xazax.hun wrote: > I know you probably tired of me making you split all the

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s marked 2 inline comments as done. Dor1s added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. +

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___

r352887 - Fix some sphinx doc errors.

Author: jyknight Date: Fri Feb 1 09:06:41 2019 New Revision: 352887 URL: http://llvm.org/viewvc/llvm-project?rev=352887=rev Log: Fix some sphinx doc errors. Modified: cfe/trunk/docs/ClangTools.rst Modified: cfe/trunk/docs/ClangTools.rst URL:

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

rjmccall added a comment. I agree: if a test doesn't seem to require the GNU extensions, let's not use `-std=gnu++XX`. Otherwise this LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4693 +T2Quals.addAddressSpace(AS2); + QualType WithAScv1T4 = S.Context.getQualifiedType(IgnoreAScv2T2, T1Quals); + Sequence.AddQualificationConversionStep(WithAScv1T4, ValueKind);

Re: r352055 - Fix failing buildbots

Hi, Thank you for catching this. I thought that the macros like __x86_64__ are defined for the target. I just don't understand: If they are defined for the host, that would mean we can't cross compile on the same host for different targets, wouldn't it? I couldn't find out which macros to use to

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

This revision was automatically updated to reflect the committed changes. Dor1s marked an inline comment as done. Closed by commit rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. (authored by Dor1s, committed by ). Changed prior to commit:

r352890 - Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Author: dor1s Date: Fri Feb 1 09:12:35 2019 New Revision: 352890 URL: http://llvm.org/viewvc/llvm-project?rev=352890=rev Log: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. Summary: There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

justice_adams added a comment. @stella.stamenova These are the changes from our previous discussion regarding the usage of %T Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57592/new/ https://reviews.llvm.org/D57592

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added inline comments. Comment at: test/SemaCXX/address-space-method-overloading.cpp:28 + //inas4.bar(); + noas.bar(); // expected-error{{call to member function 'bar' is ambiguous}} +} ebevhan wrote: > Anastasia wrote: > > ebevhan wrote: > > > Just

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Normally when needing a directory you'd `mkdir %t.dir` before using it, but since you don't' want the directory to exist here this should be good as-is. Thanks! Repository: rC Clang

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, OpenMP. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: openmp-commits, guansong. `OpenMP Application Programming Interface Version 5.0 November 2018`

[PATCH] D57594: [AST][OpenMP] OpenMP single Construct contains Structured block

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57594/new/ https://reviews.llvm.org/D57594 ___ cfe-commits

[PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

thakis closed this revision. thakis added a comment. David landed a better fix in r260388. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16951/new/ https://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. > Previously this was not required since all VarDecls were canonical. Not sure > if this change was intended. I did some digging, but am not familiar enough > with the code base to figure out what changed. Does anyone have an idea about > this? We changed the

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r352055 - Fix failing buildbots

Hello I think, because this is a unit-test, the compile will happen for the host (x86_64 in this case). So the binary will still be x86_64. The compile that the test runs will pick up whatever the default target triple is (hexagon for the bot, aarch64 for us). I don't know a lot about these

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. @ABataev i'm not sure i have fully followed the https://bugs.llvm.org/show_bug.cgi?id=40563#c1 > The outlined function is not generated for the loop, so there is no problem > with the standard compatibility. Are you saying that in these cases of `master`,

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381428 , @ABataev wrote: > In D57615#1381427 , @lebedev.ri > wrote: > > > In D57615#1381418 , @ABataev wrote: > > > > > In

[PATCH] D57615: [AST][OpenMP] OpenMP master Construct contains Structured block

lebedev.ri added a comment. In D57615#1381447 , @ABataev wrote: > > Okay, enough is enough :) > > I think a very important phrase was repeated a number of times, and it > > highlights the **actual** problem here: > > > >> is not the representation of

[PATCH] D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo

benhamilton created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is another test for the new Herald rules to subscribe cfe-commits to revisions sent out from the Github monorepo under the "clang/" subdirectory. Repository: rG LLVM Github Monorepo

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

glandium added a comment. In D51204#1271564 , @dmajor wrote: > In D51204#1253230 , @mgrang wrote: > > > Will abandon this patch since I have implementations of these which I will > > upstream soon. > > > Just to

  1   2   >