[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet created this revision. kadircet added reviewers: akyrtzi, gribozavr. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. In current indexing logic we get references to class itself when we see a constructor/destructor which is not true. Eventough spelling is

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

balazske added a comment. Looks good now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/D58743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r355190 - [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

Author: pgousseau Date: Fri Mar 1 02:05:15 2019 New Revision: 355190 URL: http://llvm.org/viewvc/llvm-project?rev=355190=rev Log: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC. enum SanitizerOrdinal has reached maximum capacity, this change

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

This revision was automatically updated to reflect the committed changes. pgousseau marked an inline comment as done. Closed by commit rL355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau, committed by ). Herald added a project: LLVM. Herald

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri added a comment. In D58811#1414784 , @amalykh wrote: > Currently getCharWidth and getCharAlign functions are hard coded to return 8 > in clang with no way to change it for target. > This can be seen in TargetInfo.h file: > > unsigned

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Please also add a test for find references on a constructor. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

Hahnfeld added a comment. I think this patch is right in also sorting the function names: AFAICS `StringMap` doesn't provide that guarantee. Comment at: lib/ProfileData/InstrProfWriter.cpp:393-403 + llvm::sort(OrderedFuncData, [](const RecordType , const RecordType ) { +

[clang-tools-extra] r355188 - Fix file headers. NFC

Author: maskray Date: Fri Mar 1 01:52:53 2019 New Revision: 355188 URL: http://llvm.org/viewvc/llvm-project?rev=355188=rev Log: Fix file headers. NFC Modified: clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp clang-tools-extra/trunk/clang-doc/Generators.cpp

[PATCH] D58811: [clang] Fix misuses of char width to char align

amalykh added a comment. Currently getCharWidth and getCharAlign functions are hard coded to return 8 in clang with no way to change it for target. This can be seen in TargetInfo.h file: unsigned getCharWidth() const { return 8; } // FIXME unsigned getCharAlign() const { return 8; } //

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D58814: [clang][Index] Constructors and Destructors do not reference

[PATCH] D58815: [clangd] Make sure constructors do not reference class

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/XRefsTests.cpp:1361 +} + )cpp", }; Add the new test right after the "Method call" test, to keep it

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri added a reviewer: thakis. lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar are you planning to land this soon? It'll conflict with D58791 , but I'm not planning to land that for another few days, so I can rebase on top of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek updated this revision to Diff 188999. phosek marked an inline comment as done. Herald added a subscriber: dschuff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D58854: [WebAssembly] Temporarily disable bulk-memory with -pthread

This revision was automatically updated to reflect the committed changes. Closed by commit rC355248: [WebAssembly] Temporarily disable bulk-memory with -pthread (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D58854?vs=188997=189000#toc Repository: rC

r355248 - [WebAssembly] Temporarily disable bulk-memory with -pthread

Author: tlively Date: Fri Mar 1 16:18:09 2019 New Revision: 355248 URL: http://llvm.org/viewvc/llvm-project?rev=355248=rev Log: [WebAssembly] Temporarily disable bulk-memory with -pthread Summary: To prevent the instability of bulk-memory in the wasm backend from blocking separate pthread

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek added a comment. In D58374#1411376 , @chandlerc wrote: > Maybe update at least some of the tests using these targets to additionally > run with the new pass manager explicitly enabled via flag? Done Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58854: [WebAssembly] Temporarily disable bulk-memory with -pthread

tlively created this revision. tlively added a reviewer: sbc100. Herald added subscribers: cfe-commits, jfb, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. aheejin accepted this revision. This revision is now accepted and ready to land. To prevent the instability of

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rL355253: lib/Header: Simplify CMakeLists.txt (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r355253 - lib/Header: Simplify CMakeLists.txt

Author: tstellar Date: Fri Mar 1 16:50:13 2019 New Revision: 355253 URL: http://llvm.org/viewvc/llvm-project?rev=355253=rev Log: lib/Header: Simplify CMakeLists.txt Summary: Replace cut and pasted code with cmake macros and reduce the number of install commands. This fixes an issue where the

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits : DiagGroup<"type-limits", [TautologicalInRangeCompare]>; def

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188973. leonardchan added a comment. Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. Update to current working version without needing LTO Repository: rG LLVM

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr added a comment. > These references were added to support using the index data for symbol rename. Understood -- thank you for providing the context (the original commit that added this code didn't have the explanation why this reference was added). However, my suggestion would be to

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58819/new/ https://reviews.llvm.org/D58819 ___ cfe-commits mailing list

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188987. leonardchan added a comment. - Remove `hasHiddenLTOVisibility` from `CXXRecordDecl` and rename the flag to `-frelative-c++-abi-vtables` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 189002. mgrang added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57986/new/ https://reviews.llvm.org/D57986 Files: lib/ProfileData/InstrProfWriter.cpp Index: lib/ProfileData/InstrProfWriter.cpp

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

This revision was automatically updated to reflect the committed changes. Closed by commit rL355252: [ProfileData] Sort FuncData before iteration to remove non-determinism (authored by mgrang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58844: Give builtins and alloc/dealloc operators the default calling convention.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58844/new/ https://reviews.llvm.org/D58844 ___ cfe-commits mailing

[PATCH] D58847: AMDGPU: Fix the mapping of sub group sync scope

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58847/new/ https://reviews.llvm.org/D58847 ___ cfe-commits mailing list

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/D58743 ___ cfe-commits mailing

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 marked an inline comment as done. xbolva00 added a comment. Ok, if concers Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits :

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1792 +else if (Trimmed == "// clang-format on" || + Trimmed == "/* clang-format on */") FormattingOff = false;

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:485 +// For compatibility with GCC; -Wtype-limits = -Wtautological-constant-in-range-compare +def TypeLimits : DiagGroup<"type-limits",

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1415534 , @smeenai wrote: > @tstellar are you planning to land this soon? It'll conflict with D58791 > , but I'm not planning to land that for > another few days, so I can rebase on

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/ProfileData/InstrProfWriter.cpp:431-432 + for (const auto : OrderedFuncData) { +const auto = record.first; +const auto = record.second; +

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + Twine ManglePublicSymbol(StringRef Name) { +return StringRef(CGM.getTriple().isOSBinFormatCOFF() ? "$_" : "._") + Name; DHowett-MSFT wrote: > As of the latest revision,

[PATCH] D58321: [WIP] Support for relative vtables

riccibruno added a comment. I think that you need to update the serialization code in `Serialization/ASTReaderDecl.cpp` and `Serialization/ASTWriterDecl.cpp` to account for the new flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

JonasToth added inline comments. Comment at: clang/lib/Format/Format.cpp:1792 +else if (Trimmed == "// clang-format on" || + Trimmed == "/* clang-format on */") FormattingOff = false; MyDeveloperDay wrote: > JonasToth wrote: > > Should we

r355226 - [DWARF] Make -g with empty assembler source work better.

Author: probinson Date: Fri Mar 1 12:58:04 2019 New Revision: 355226 URL: http://llvm.org/viewvc/llvm-project?rev=355226=rev Log: [DWARF] Make -g with empty assembler source work better. This was sometimes causing clang or llvm-mc to crash, and in other cases could emit a bogus DWARF line-table

[PATCH] D58828: [analyzer] Fix taint propagation in GenericTaintChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58828/new/ https://reviews.llvm.org/D58828 ___

[PATCH] D58844: Give builtins and alloc/dealloc operators the default calling convention.

erichkeane created this revision. erichkeane added reviewers: SjoerdMeijer, Anastasia, yaxunl, rnk. Herald added a subscriber: kristina. Herald added a project: clang. On SPIR targets, the default calling convention is SpirFunction. However, operator new/delete and builtins were being created

[PATCH] D58847: AMDGPU: Fix the mapping of sub group sync scope

kzhuravl created this revision. kzhuravl added reviewers: b-sumner, rampitec, t-tye. Herald added subscribers: jfb, tpr, dstuttard, yaxunl, wdng. Map memory_scope_sub_group to "wavefront" sync scope https://reviews.llvm.org/D58847 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 188951. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57986/new/ https://reviews.llvm.org/D57986 Files: lib/ProfileData/InstrProfWriter.cpp Index: lib/ProfileData/InstrProfWriter.cpp

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/UseRaiiLocksCheck.cpp:35 +void UseRaiiLocksCheck::registerMatchers(MatchFinder *Finder) { + // lock_guards require c++11 or later + if (!getLangOpts().CPlusPlus11) If we allow boost, pre

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

george.burgess.iv added a comment. Thanks for working on this! I hope to take an in-depth look at this patch next week (if someone else doesn't beat me to it...), but wanted to note that I think enabling clang to emit these warnings on its own is a good thing. `diagnose_if` is great for

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 188955. xur added a comment. Integrated Teresa's suggestion to change the err() to assert. Added documentation change suggested by David. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files:

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1852 +IntResult = +llvm::APSInt::get(EVResult.Val.getLValueOffset().getQuantity()); + else This always returns an APSInt with width 64; is that really right? I

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

shafik added a comment. @teemperor ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/D58743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1409565 , @mgrang wrote: > In D50488#1407975 , @Szelethus wrote: > > > But, as a work-in-progress alpha checker, the direction is set and looks > > great. Please let @NoQ have the

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. See D41512 , rC322901 , D51545 . Comment at:

r355209 - [PGO] Use the explicit parameter in ProfileSummary API. NFC

Author: xur Date: Fri Mar 1 09:50:20 2019 New Revision: 355209 URL: http://llvm.org/viewvc/llvm-project?rev=355209=rev Log: [PGO] Use the explicit parameter in ProfileSummary API. NFC Use the explicit parameter in setProfileSummary() and getSummary(). This is a follow-up of r355131. Modified:

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58841 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sema/compare.c

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

riccibruno added a comment. Ugh, could you please avoid doing lots a tiny changes every 5 minutes ? This causes spam on cfe-commits /: Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

MyDeveloperDay updated this revision to Diff 188931. MyDeveloperDay added a comment. Fix negative test case support the same /*clang-format off*/ in the sort includes that the TokenLexer supports. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58819/new/ https://reviews.llvm.org/D58819

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

void added a comment. My opinion doesn't carry as much weight as others who are more familiar with the front-end code, but LGTM. One question, the code you added looks similar. Is there a way to extrapolate it into its own function? Maybe yet another `EvaluateAs*` method?

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 updated this revision to Diff 188957. xbolva00 added a comment. Remove from -Wextra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sema/compare.c

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + Twine ManglePublicSymbol(StringRef Name) { +return StringRef(CGM.getTriple().isOSBinFormatCOFF() ? "$_" : "._") + Name; As of the latest revision, this now fails at

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

JonasToth added inline comments. Comment at: clang/lib/Format/Format.cpp:1792 +else if (Trimmed == "// clang-format on" || + Trimmed == "/* clang-format on */") FormattingOff = false; Should we allow ``` /* clang-format off It is just

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes requested changes to this revision. nathawes added a comment. This revision now requires changes to proceed. These references were added to support using the index data for symbol rename. I.e. so that when you rename the class, you can use the index data to find all occurrences of its

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

dblaikie added inline comments. Comment at: lib/ProfileData/InstrProfWriter.cpp:389-397 + auto nameA = A.first; + auto nameB = B.first; + int comp = nameA.compare(nameB); +

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 188988. smeenai added a comment. Release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. I added an entry to the release notes. The release notes change only covers the changes in this diff. My plan is to land this, wait for a few days (so that users of the target get broken in an obvious way), and then add the new install-clang-headers target (for

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. In D58791#1415496 , @tstellar wrote: > This looks good, but could you also add an entry in the ReleaseNotes for this. Will do – thanks for the reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 189014. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

tstellar added a comment. This looks good, but could you also add an entry in the ReleaseNotes for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___

[PATCH] D58862: [cmake] Create exports for umbrella library targets

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added projects: clang, LLVM. When using the umbrella llvm-libraries and clang-libraries targets, we should export all library targets, otherwise they'll be part of our distribution but

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Looks good to me. On ELF and Mach-O, I think we get the equivalent behaviour automatically from the ODR linkage type. I'd really like to see linkage type and COMDAT made orthogonal, but

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

theraven added a comment. It would probably benefit from a test so that we don't regress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58807/new/ https://reviews.llvm.org/D58807 ___ cfe-commits

[PATCH] D58811: [clang] Fix misuses of char width to char align

amalykh created this revision. amalykh added reviewers: rsmith, momchil.velikov, stephenkelly. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces getCharWidth with getCharAlign where it is used incorrectly Repository: rC Clang

r355181 - CodeGen: Fix PR40605 by splitting constant struct initializers

Author: glider Date: Fri Mar 1 01:00:41 2019 New Revision: 355181 URL: http://llvm.org/viewvc/llvm-project?rev=355181=rev Log: CodeGen: Fix PR40605 by splitting constant struct initializers When emitting initializers for local structures for code built with -ftrivial-auto-var-init, replace

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

bjope added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:45 + +short _Accum sa_const9 = 2u; // DEFAULT-DAG: @sa_const9 = {{.*}}global i16 256, align 2 +unsigned short _Accum usa_const3 = 2; Perhaps we should verify that we do not

r355182 - [clang-format] [NFC] clang-format the Format library

Author: paulhoad Date: Fri Mar 1 01:09:54 2019 New Revision: 355182 URL: http://llvm.org/viewvc/llvm-project?rev=355182=rev Log: [clang-format] [NFC] clang-format the Format library Previously revisions commited non-clang-formatted changes to the Format library, this means submitting any

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri added a comment. Can you be more specific? Is there some bugreport this fixes? Is there some test? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58811/new/ https://reviews.llvm.org/D58811 ___ cfe-commits

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

glider closed this revision. glider added a comment. Landed r355181, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 188878. kadircet marked an inline comment as done. kadircet added a comment. Re-arrange test location Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files:

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk created this revision. lewmpk added reviewers: hokein, aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, jdoerfert, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: clang. lewmpk added a subscriber: clang-tools-extra. Repository: rCTE Clang Tools

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/include/clang/Frontend/FrontendOptions.h

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, JonasToth, krasimir. MyDeveloperDay added projects: clang, clang-tools-extra. If the clang-format on/off is in a /* comment */ then the sorting of headers is not ignored PR40901 -

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven updated this revision to Diff 15. theraven marked an inline comment as done. theraven added a comment. - Address Dustin's review comments. - [objc-gnustep] Use $ in symbol names on Windows. - Add fix from Dustin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58216: Support attribute used in member funcs of class templates II

modocache added a comment. Friendly ping! @aaron.ballman it looks like you accepted D56928 , could you take a look at this as well? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

MyDeveloperDay added inline comments. Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:47 +"cppcoreguidelines-use-raii-locks"); CheckFactories.registerCheck( "cppcoreguidelines-avoid-c-arrays"); Nit: by and large

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

hans created this revision. hans added reviewers: efriedma, rnk, rsmith, void. Herald added subscribers: jdoerfert, eraman. Apparently GCC allows this, and there's code relying on it (see bug, which is a release blocker for llvm 8). The idea is to allow expression that would have been allowed

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188912. lewmpk added a comment. fixed documentation again Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188913. lewmpk added a comment. fixed documentation formatting Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk marked 3 inline comments as done. lewmpk added inline comments. Comment at: clang-tidy/cppcoreguidelines/UseRaiiLocksCheck.cpp:26 + recordType(hasDeclaration(cxxRecordDecl(hasName("::std::mutex")); + // Match expressions of type mutex or mutex pointer + const

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188915. lewmpk added a comment. fixed documentation formatting Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D58830: [ASTImporter] Import member expr with explicit template args

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Member expressions with explicit template arguments were not imported

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188918. lewmpk added a comment. improved tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188919. lewmpk added a comment. support try_lock_for and try_lock_until Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files:

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188920. lewmpk added a comment. remove support for try_lock_for and try_lock_until Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files:

[clang-tools-extra] r355200 - [clangd] Enable SuggestMissingIncludes by default.

Author: ioeric Date: Fri Mar 1 06:17:55 2019 New Revision: 355200 URL: http://llvm.org/viewvc/llvm-project?rev=355200=rev Log: [clangd] Enable SuggestMissingIncludes by default. Summary: This seems to work stably now. Turn on by default. Reviewers: kadircet Subscribers: ilya-biryukov,

[PATCH] D58772: [clangd] Enable SuggestMissingIncludes by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355200: [clangd] Enable SuggestMissingIncludes by default. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D58772?vs=188701=188894#toc Repository: rCTE Clang

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

MyDeveloperDay added a comment. This looks good to me but I would wait for one of @JonasToth or @alexfh to perhaps take a look, maybe you should add some nested scope example too using the same name, I know the compiler should warn about a shadow variable anyway but std::mutex m;

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk added a comment. I'll improve the tests :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:132 + "#include \n" + "/* clang-format off */\n" + "#include \n" alexfh

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188908. lewmpk added a comment. handle other basiclockable types Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188910. lewmpk added a comment. renamed option for cppcoreguidelines-use-raii-locks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files:

[PATCH] D58819: [clang-format] clang-format off/on not respected when using C Style comments

alexfh added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:132 + "#include \n" + "/* clang-format off */\n" + "#include \n" Add a test with `/* clang-format officially supports C++ */` ;)

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

lewmpk updated this revision to Diff 188893. lewmpk added a comment. fixed ordering of cppcoreguidelines module checks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58818/new/ https://reviews.llvm.org/D58818 Files:

  1   2   >