r359353 - [driver][macOS] Link libarclite from the default toolchain when clang

Author: arphaman Date: Fri Apr 26 15:40:47 2019 New Revision: 359353 URL: http://llvm.org/viewvc/llvm-project?rev=359353=rev Log: [driver][macOS] Link libarclite from the default toolchain when clang is running in a toolchain outside of xcode 'libarclite' usually lives in the same toolchain as

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Anastasia marked an inline comment as done. Anastasia added a comment. In D60763#1478672 , @Pierre wrote: > I also think we could reduce the size of the tables. > To sum up how this is working right now: > > 1. The isOpenCLBuiltin(char* functionName)

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

rsmith added a comment. In D60943#1475038 , @void wrote: > In D60943#1474926 , @rsmith wrote: > > > Is `"n"` really special in this regard, or is it just the first one that > > we've encountered? > > > I think

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. @rjmccall I'm not sure if this is the right place to continue discussing this, but I don't have a patch I am happy with and I would rather not post something half-baked. Currently for AMDGPU we have the behavior that the user can set the visibility of these

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/readability-redundant-smartptr-get-msvc.cpp:37 +void Positive() { + + std::unique_ptr* up; Unnecessary empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. By using `no_destroy`, you're saying that exit-time destructor doesn't matter because the OS will either reclaim the resources automatically, or its just doesn't matter since the process is going down. I don't think that implies that we can safely ignore the

r359359 - [Driver] Support priority for multilibs

Author: phosek Date: Fri Apr 26 17:25:11 2019 New Revision: 359359 URL: http://llvm.org/viewvc/llvm-project?rev=359359=rev Log: [Driver] Support priority for multilibs When more than one multilib flag matches, try to select the best possible match based on priority. When two different multilibs

[PATCH] D60990: [Driver] Support priority for multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rC359359: [Driver] Support priority for multilibs (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60990?vs=196905=196933#toc Repository: rC Clang CHANGES SINCE

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rC359360: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61040?vs=196791=196934#toc

r359360 - [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

Author: phosek Date: Fri Apr 26 17:25:13 2019 New Revision: 359360 URL: http://llvm.org/viewvc/llvm-project?rev=359360=rev Log: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions This introduces a support for multilibs to Fuchsia driver. Unlike the existing multilibs that are

r359366 - [AArch64] Initialize HasMTE

Author: vitalybuka Date: Fri Apr 26 19:40:01 2019 New Revision: 359366 URL: http://llvm.org/viewvc/llvm-project?rev=359366=rev Log: [AArch64] Initialize HasMTE Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp URL:

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

vitalybuka added a comment. fixed with r359366 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 196945. gtbercea marked 2 inline comments as done. gtbercea added a comment. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington planned changes to this revision. erik.pilkington added a comment. In D61165#1480976 , @rjmccall wrote: > I believe at least one of the goals of `nodestroy` is to allow the type to > potentially not provide a destructor at all, so if

r359356 - [clang][driver] Weaken the test from 359353 to appease Windows bots

Author: arphaman Date: Fri Apr 26 15:58:31 2019 New Revision: 359356 URL: http://llvm.org/viewvc/llvm-project?rev=359356=rev Log: [clang][driver] Weaken the test from 359353 to appease Windows bots Modified: cfe/trunk/test/Driver/arclite-link-external-toolchain.c Modified:

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar created this revision. tstellar added reviewers: smeenai, vzakhari, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is a follow up to r355253 and a better fix than the first attempt which was r359257. We can't install anything from ${CMAKE_CFG_INTDIR},

r359350 - Add to the release notes the fact that UninitializedObject checker is now

Author: sylvestre Date: Fri Apr 26 14:46:33 2019 New Revision: 359350 URL: http://llvm.org/viewvc/llvm-project?rev=359350=rev Log: Add to the release notes the fact that UninitializedObject checker is now considered as stable Modified: cfe/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. Okay, SGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61165/new/ https://reviews.llvm.org/D61165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

rsmith added a comment. In D52521#1479907 , @erik.pilkington wrote: > Looks like @rsmith fixed this in r359266. Sorry, I completely forgot about the existence of this when working on that patch! :( CHANGES SINCE LAST ACTION

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington added a comment. No worries! It happens, I probably should have pinged this more aggressively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52521/new/ https://reviews.llvm.org/D52521 ___ cfe-commits mailing list

r359367 - Reinstate r359059, reverted in r359361, with a fix to properly prevent

Author: rsmith Date: Fri Apr 26 19:58:17 2019 New Revision: 359367 URL: http://llvm.org/viewvc/llvm-project?rev=359367=rev Log: Reinstate r359059, reverted in r359361, with a fix to properly prevent us emitting the operand of __builtin_constant_p if it has side-effects. Original commit message:

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. I believe at least one of the goals of `nodestroy` is to allow the type to potentially not provide a destructor at all, so if we're going to implicitly require the destructor anyway in certain situations, we should clearly document that, and we should be aware that we

[PATCH] D61217: Fix PCH skipping to handle all Lexers

mikerice created this revision. mikerice added reviewers: rnk, cfe-commits. When skipping code at the start of a file during PCH use, Preprocessor::Lex is not used since it consumes all preprocessor directives until it returns a real token. Using the specific Lexer (i.e. CurLexer->Lex) makes

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

vitalybuka added subscribers: hctim, vitalybuka. vitalybuka added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12035 -- Testing: 14692 tests, 96 threads -- Testing: FAIL: Clang :: AST/float16.cpp (132 of 14692) TEST

r359361 - Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC.

Author: jgorbe Date: Fri Apr 26 17:32:04 2019 New Revision: 359361 URL: http://llvm.org/viewvc/llvm-project?rev=359361=rev Log: Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC. This reverts r359059 (git commit

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Input: // this is my comment. ^ // and it continues on the next line. Expected: // this is my comment. // ^ // and it continues on the next line. Actual: // this is my comment. ^ // and it continues on the next line. Repository: rCTE Clang

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 196849. ilya-biryukov added a comment. - Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files: clang/include/clang/Tooling/Syntax/Tokens.h

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall created this revision. sammccall added a reviewer: gribozavr. Herald added subscribers: cfe-commits, jfb, kadircet, arphaman, jkorous, MaskRay, javed.absar, mgorny. Herald added a project: clang. sammccall added a comment. Herald added a subscriber: ormris. @ilya-biryukov Can you check

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added a comment. @sammccall, could we do another round of review? I think it's perfect now... (Just kidding :-) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887

[PATCH] D42642: [CUDA] Detect installation in PATH

Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Herald added a subscriber: ormris. In D42642#1479013 , @aganea wrote: > Just a quick heads-up - the `cuda-detect-path.cu` test fails on WSL/Ubuntu > 18.04: Hmm, maybe that's because

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

jfb added a comment. In D61165#1479937 , @rjmccall wrote: > Are you sure these are the right semantics for `nodestroy`? I think there's > a reasonable argument that we should not destroy previous elements of a > `nodestroy` array just because an

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 3 inline comments as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2390 } + case OMPRTL__tgt_target_data_mapper: { +// Build void __tgt_target_data_mapper(int64_t device_id, int32_t arg_num, ABataev wrote:

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. Confirmed just now that the current diff (196774) does work, but it'd be good to correct user-provided constructors and trivial destructors before this lands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1480428 , @jdenny wrote: > It seems we have roughly the same situation for their ABIs. That is, for .so > files, someone noted that libc++ and libunwind have always used the same > version, .1, and openmp doesn't use a

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7851 + (isa(D) && + (D->hasAttr() || D->hasAttr())); } is format right? Comment at: clang/test/CodeGenCUDA/amdgpu-visibility.cu:1 +// RUN: %clang_cc1

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 196880. lildmh added a comment. Combine 2 pointers into one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp lib/CodeGen/CGDecl.cpp

[clang-tools-extra] r359329 - Fix typo in documentation.

Author: nicholas Date: Fri Apr 26 10:56:22 2019 New Revision: 359329 URL: http://llvm.org/viewvc/llvm-project?rev=359329=rev Log: Fix typo in documentation. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-comparison.rst Modified:

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7851 + (isa(D) && + (D->hasAttr() || D->hasAttr())); } yaxunl wrote: > is format right? yeah, it's the format after clang-format.

r359340 - [OPENMP]Added check for non-random access types for the dependent loop

Author: abataev Date: Fri Apr 26 12:28:37 2019 New Revision: 359340 URL: http://llvm.org/viewvc/llvm-project?rev=359340=rev Log: [OPENMP]Added check for non-random access types for the dependent loop counters. According to the OpenMP 5.0, For any associated loop where the b or lb expression is

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61194/new/ https://reviews.llvm.org/D61194

r359344 - [HIP] Fix visibility of `__constant__` variables.

Author: hliao Date: Fri Apr 26 12:31:48 2019 New Revision: 359344 URL: http://llvm.org/viewvc/llvm-project?rev=359344=rev Log: [HIP] Fix visibility of `__constant__` variables. Summary: - `__constant__` variables should not be `hidden` as the linker may turn them into `LOCAL` symbols.

r359343 - [MinGW] Do dllexport inline methods in template instantiation

Author: mstorsjo Date: Fri Apr 26 12:31:46 2019 New Revision: 359343 URL: http://llvm.org/viewvc/llvm-project?rev=359343=rev Log: [MinGW] Do dllexport inline methods in template instantiation Normally, in MinGW mode, inline methods aren't dllexported. However, in the case of a dllimported

r359345 - [MinGW] Always emit local typeinfo

Author: mstorsjo Date: Fri Apr 26 12:31:51 2019 New Revision: 359345 URL: http://llvm.org/viewvc/llvm-project?rev=359345=rev Log: [MinGW] Always emit local typeinfo This makes sure that code built with headers for a statically linked libc++ also works when linking to the DLL version, when the

r359342 - [MinGW] Don't let template instantiation declarations cover nested classes

Author: mstorsjo Date: Fri Apr 26 12:31:39 2019 New Revision: 359342 URL: http://llvm.org/viewvc/llvm-project?rev=359342=rev Log: [MinGW] Don't let template instantiation declarations cover nested classes An explicit template instantiation declaration used to let callers assume both outer and

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

This revision was automatically updated to reflect the committed changes. Closed by commit rC359342: [MinGW] Dont let template instantiation declarations cover nested classes (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61176: [MinGW] Do dllexport inline methods in template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rC359343: [MinGW] Do dllexport inline methods in template instantiation (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61176/new/

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359344: [HIP] Fix visibility of `__constant__` variables. (authored by hliao, committed by ). Changed prior to commit: https://reviews.llvm.org/D61194?vs=196857=196902#toc Repository: rC Clang

[PATCH] D61177: [MinGW] Always emit local typeinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC359345: [MinGW] Always emit local typeinfo (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61177/new/ https://reviews.llvm.org/D61177

[PATCH] D60990: [Driver] Support priority for multilibs

phosek added a comment. In D60990#1475116 , @lebedev.ri wrote: > Can this have test coverage? Done, I've added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp:60 // Catch '!ptr.get()' - const auto CallToGetAsBool = ignoringParenImpCasts(callToGet(recordDecl( - QuacksLikeASmartptr,

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8021 + /// the extracted map clauses. + void generateAllInfoForMapper(MapBaseValuesArrayTy , +MapValuesArrayTy , This code has too many common parts with

[PATCH] D61194: [HIP] Fix visibility of `__constant__` variables.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-visibility.cu:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -fapply-global-visibility-to-externs -fvisibility default -emit-llvm -o - %s |

r359338 - [ASTImporter] Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

Author: shafik Date: Fri Apr 26 11:51:28 2019 New Revision: 359338 URL: http://llvm.org/viewvc/llvm-project?rev=359338=rev Log: [ASTImporter] Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition Summary: For a CXXRecordDecl the RecordDeclBits are stored in the

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson added a comment. In D60283#1480546 , @aganea wrote: > Thanks Paul, your solution is even better. I'll apply rL11 > locally - if everything's fine, do you > mind if I re-land it again? I suggest you do

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 196894. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196905. phosek marked an inline comment as done. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D61209: Fix readability-redundant-smartptr-get for MSVC STL

fgross created this revision. fgross added reviewers: aaron.ballman, alexfh, sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. The MSVC STL defines smart pointer `operator*` and `operator->` as method templates. The existing duck typing implementation doesn't catch

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

fgross updated this revision to Diff 196911. fgross added a comment. Fixed format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61209/new/ https://reviews.llvm.org/D61209 Files: clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. In D61147#1479956 , @rjmccall wrote: > In D61147#1479940 , @erik.pilkington > wrote: > > > In D61147#1479932 , @rjmccall > > wrote: > > >

r359348 - [AArch64] Add support for MTE intrinsics

Author: javed.absar Date: Fri Apr 26 14:08:11 2019 New Revision: 359348 URL: http://llvm.org/viewvc/llvm-project?rev=359348=rev Log: [AArch64] Add support for MTE intrinsics This provides intrinsics support for Memory Tagging Extension (MTE), which was introduced with the Armv8.5-a architecture.

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/readability-redundant-smartptr-get-msvc.cpp:96 +} \ No newline at end of file Please add new line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC359348: [AArch64] Add support for MTE intrinsics (authored by javed.absar, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60485?vs=196297=196915#toc

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. JF, Michael, and I were talking about this offline, and we think that the right choice of semantics for the static local case is to call the destructors. struct HoldsResource { HoldsResource() { tryToAcquireItMayThrow(); } ~HoldsResource() {

[PATCH] D61173: [BPF] do not generate predefined macro bpf

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder ) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); +

[PATCH] D61173: [BPF] do not generate predefined macro bpf

yonghong-song updated this revision to Diff 196799. yonghong-song edited the summary of this revision. yonghong-song added a comment. remove __bpf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/ https://reviews.llvm.org/D61173 Files:

[PATCH] D59725: Additions to creduce script

lebedev.ri added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + akhuang wrote: > lebedev.ri wrote: > > akhuang wrote: > > >

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

sammccall added a comment. Thanks for doing this! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:395 + DiagLevel != DiagnosticsEngine::Fatal && + LineIsMarkedWithNOLINTinMacro(Info.getSourceManager(), +

r359283 - [Analyzer] Iterator Checkers - Do an early return after handling calls

Author: baloghadamsoftware Date: Fri Apr 26 00:30:07 2019 New Revision: 359283 URL: http://llvm.org/viewvc/llvm-project?rev=359283=rev Log: [Analyzer] Iterator Checkers - Do an early return after handling calls This patch is more of a fix than a real improvement: in checkPostCall() we should

[PATCH] D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC359283: [Analyzer] Iterator Checkers - Do an early return after handling calls (authored by baloghadamsoftware, committed by ). Changed prior to commit:

[PATCH] D61173: [BPF] do not generate predefined macro bpf

ast added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder ) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); + Builder.defineMacro("__bpf__"); I don't think anyone is using

[PATCH] D61173: [BPF] do not generate predefined macro bpf

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. shipit Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/

[PATCH] D61174: [clang-format] Fix documentation for FixNamespaceComments

owenpan created this revision. owenpan added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR40409 . Repository: rC Clang https://reviews.llvm.org/D61174 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

a_sidorin accepted this revision. a_sidorin added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r359280 - [clang-format] Fix documentation for FixNamespaceComments

Author: owenpan Date: Fri Apr 26 00:05:47 2019 New Revision: 359280 URL: http://llvm.org/viewvc/llvm-project?rev=359280=rev Log: [clang-format] Fix documentation for FixNamespaceComments Fixes PR40409 Differential Revision: https://reviews.llvm.org/D61174 Modified:

[PATCH] D61174: [clang-format] Fix documentation for FixNamespaceComments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL359280: [clang-format] Fix documentation for FixNamespaceComments (authored by owenpan, committed by ). Herald added a

[PATCH] D61176: [MinGW] Do dllexport inline methods in template instantiation

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai. Herald added a project: clang. Normally, in MinGW mode, inline methods aren't dllexported. However, in the case of a dllimported template instantiation, the inline methods aren't instantiated locally, but referenced

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems okay to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61175/new/ https://reviews.llvm.org/D61175 ___

[PATCH] D61177: [MinGW] Always emit local typeinfo

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61177/new/ https://reviews.llvm.org/D61177 ___ cfe-commits

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus added a comment. I suspect the problem is similar. I'll take a look at this either today or tomorrow, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___

[clang-tools-extra] r359284 - [clangd] Query index in code completion no-compile mode.

Author: sammccall Date: Fri Apr 26 00:45:49 2019 New Revision: 359284 URL: http://llvm.org/viewvc/llvm-project?rev=359284=rev Log: [clangd] Query index in code completion no-compile mode. Summary: We scrape the enclosing scopes from the source file, and use them in the query. Reviewers:

[PATCH] D61177: [MinGW] Always emit local typeinfo

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai. Herald added a project: clang. This makes sure that code built with headers for a statically linked libc++ also works when linking to the DLL version, when the DLL hasn't been built with --export-all-symbols. This

[clang-tools-extra] r359291 - [clangd] Remove unused ClangdServer::dynamicIndex(). NFC

Author: ibiryukov Date: Fri Apr 26 02:36:22 2019 New Revision: 359291 URL: http://llvm.org/viewvc/llvm-project?rev=359291=rev Log: [clangd] Remove unused ClangdServer::dynamicIndex(). NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified:

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: unittests/clangd/SourceCodeTests.cpp:325 +TEST(SourceCodeTests, VisibleNamespaces) { + std::vector>> Cases = { sammccall

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

baloghadamsoftware added a comment. In D61136#1479454 , @NoQ wrote: > Aha, yup, thx! > > Do you plan to centralize other code paths on which you conjure symbols? Only in a small rework of `handleAssign()` because that is a place where we conjure a

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1929-1930 + + auto = State->getSymbolManager(); + auto Sym = SymMgr.conjureSymbol(E, LCtx, T, BlockCount, "end"); +

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359284: [clangd] Query index in code completion no-compile mode. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai. Herald added a project: clang. An explicit template instantiation declaration used to let callers assume both outer and nested classes instantiations were defined in a different translation unit. If the instantiation

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. In D60605#1478922 , @sammccall wrote: > In D60605#1478581 , @ilya-biryukov > wrote: > > > Input: > > > > int test() { > > }^ > > > > > > Actual: > > > > int test() {} > > ^ >

r359285 - [MinGW] Fix dllexport of explicit template instantiation

Author: mstorsjo Date: Fri Apr 26 01:09:51 2019 New Revision: 359285 URL: http://llvm.org/viewvc/llvm-project?rev=359285=rev Log: [MinGW] Fix dllexport of explicit template instantiation Contrary to MSVC, GCC/MinGW needs to have the dllexport attribute on the template instantiation declaration,

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL359285: [MinGW] Fix dllexport of explicit template instantiation (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61176: [MinGW] Do dllexport inline methods in template instantiation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61176/new/ https://reviews.llvm.org/D61176 ___ cfe-commits

[clang-tools-extra] r359289 - filecheck etc are not clangd-specific deps. NFC

Author: sammccall Date: Fri Apr 26 02:20:36 2019 New Revision: 359289 URL: http://llvm.org/viewvc/llvm-project?rev=359289=rev Log: filecheck etc are not clangd-specific deps. NFC Modified: clang-tools-extra/trunk/test/CMakeLists.txt Modified: clang-tools-extra/trunk/test/CMakeLists.txt URL:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 196822. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments - Drop include stack Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added inline comments. Comment at: clangd/Diagnostics.cpp:78 +// offsets when displaying that information to users. +Position toOneBased(Position P) { + ++P.line; ilya-biryukov wrote: > Could we avoid introducing a function that breaks the invariant of

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

gribozavr added a comment. Thank you for the fix! Another crash: https://bugs.llvm.org/show_bug.cgi?id=41611 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert edited reviewers, added: riccibruno; removed: efriedma. aaronpuchert removed a subscriber: riccibruno. aaronpuchert added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https://reviews.llvm.org/D59402

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Input: if (something) foo; // a comment^ Expected: if (something) foo; // a comment ^ Actual (indented to align with a comment): if (something) foo; // a comment ^ Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 196847. ilya-biryukov added a comment. - s/llvm::unittest::ValueIs/llvm::ValueIs. - Add tests for empty macro expansions and directives around macro expansions. - Record all gaps between spelled and expanded tokens. - Tweak test dump to distinguish

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. Herald added a subscriber: ormris. @ilya-biryukov Can you check this with a shared library build? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny added a comment. In D59168#1479939 , @phosek wrote: > In D59168#1474715 , @jdenny wrote: > > > Does the following match what you have in mind? > > > > $prefix/ > > include/ > > c++/ > >

  1   2   >