[PATCH] D61222: [clang-format] Fix bug in determineTokenType() for TT_StartOfName

owenpan created this revision. owenpan added reviewers: klimek, MyDeveloperDay, sammccall, krasimir, djasper. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes PR37175 . Repository: rC Clang

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

sylvestre.ledru added a comment. I took the liberty to add that in the release notes of clang https://reviews.llvm.org/rG5f163c7e2e62 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. I think potentially reusing OpenCL features is desirable since the device code of SYCL is largely OpenCL. However I don't think we are clear enough about the overall device compilation flow of SYCL and I can easily suggest a number of different approaches including

[PATCH] D61222: [clang-format] Fix bug in determineTokenType() for TT_StartOfName

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

yvvan added a comment. Now we know that somebody else also uses libclang :) I the mentioned change I only wanted to follow the same logic as in TypePrinter::printTag to cover more anonymity cases. Adding the old one as an extra function seems totally fine to me. Can you please add some tests

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee updated this revision to Diff 196988. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index:

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. @yvvan Hows that as a test? I'm pretty new at this, and it took a while to figure out how to run the tests. I used something like: `build\Release\bin\c-index-test.exe -test-print-type .\test\Index\print-type.c | ..\llvm\build\Release\bin\FileCheck

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

thakis added a comment. (Just for the record, I'm happy with whatever y'all end up with.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee added a comment. Also, I don't have commit access, so I would need some help with that if this gets accepted :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. It seems to fine just forbid `hidden`. Again, I suspect other targets do not care because they are not using a standard dynamic loader to load the code containing kernel functions. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

JornVernee created this revision. JornVernee added reviewers: yvvan, nik, rsmith. JornVernee added a project: clang. Herald added a subscriber: arphaman. https://reviews.llvm.org/D54996 Changed the behaviour of clang_Cursor_isAnonymous, but there is no alternative available to get the old

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

owenpan updated this revision to Diff 196994. owenpan retitled this revision from "[clang-format] Fix bug in determineTokenType() for TT_StartOfName" to "[clang-format] Fix a bug in AlignConsecutiveDeclarations". owenpan added a comment. This revision is now accepted and ready to land. Fix it

[PATCH] D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp:171 #ifndef TEST_HAS_NO_EXCEPTIONS -{ +

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:173 set(header_install_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}) Please add "/include" at the end. Comment at: clang/lib/Headers/CMakeLists.txt:176

[PATCH] D61222: [clang-format] Fix bug in determineTokenType() for TT_StartOfName

owenpan planned changes to this revision. owenpan added a comment. Tested it a bit more and found another problem. The code DECOR1 uint32_t DECOR2 function1 (int arg1, int arg2) { return 1U; } DECOR1 unsigned DECOR2 function2 (int arg1, int arg2) { return 1U; } would still be misformatted

Re: r359361 - Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC.

On Sat, Apr 27, 2019 at 3:29 AM Jorge Gorbe Moya via cfe-commits wrote: > > Author: jgorbe > Date: Fri Apr 26 17:32:04 2019 > New Revision: 359361 > > URL: http://llvm.org/viewvc/llvm-project?rev=359361=rev > Log: > Revert Fix interactions between __builtin_constant_p and constexpr to match >

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Ok, I have excluded Darwin and PS4 for the changes. The fix mainly targets at Linux so that we can compile a project with parts by GCC and parts by LLVM given that they follow the same ABI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

fgross updated this revision to Diff 196960. fgross added a comment. Fixed test file format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61209/new/ https://reviews.llvm.org/D61209 Files: clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 updated this revision to Diff 196967. wxiao3 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-align-linux.c

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 196955. teemperor retitled this revision from "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior." to "[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.". teemperor edited the summary of this

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

JornVernee added a comment. Herald added a project: LLVM. This seems to have changed the behaviour w.r.t inline struct or union decls in fields and global variables e.g. struct foo { struct { int x; } bar; }; For the StructDecl cursor of 'bar' isAnonymous now returns

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

TomTan created this revision. TomTan added a reviewer: efriedma. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. According to alignment section in below ARM64 ABI document, MSVC could increase alignment of global data based on its total size.

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 marked 2 inline comments as done. wxiao3 added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:919 /// IsX86_MMXType - Return true if this is an MMX type. bool IsX86_MMXType(llvm::Type *IRType) { - // Return true if the type is an MMX type <2 x i32>, <4 x i16>,