[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added a comment. I've managed to get what I needed by returning a flag from `Lex`. @rsmith, could you take a look? Is there a better way to do the equivalent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61335/new/ https://reviews.llvm.org/D61335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360265: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198664=198677#toc Repository: rC Clang

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

Anastasia updated this revision to Diff 198678. Anastasia added a comment. - Improved comments - Switched to SPIR kernel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61488/new/ https://reviews.llvm.org/D61488 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CodeGenFunction.cpp

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

yvvan added a comment. @ilya-biryukov What do you think about D53072 ? It can be polished and combined with this change removing some code from here (which I assume is a good thing). The idea there is that clang-format knows that it's not allowed to remove new

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

MaskRay created this revision. MaskRay added reviewers: compnerd, rsmith, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since July 15, 2015 (binutils-gdb commit 19a7fe52ae3d0971e67a134bcb1648899e21ae1c, included in 2.26), gas --compress-debug-sections=zlib (gcc

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

sgraenitz added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:68 + return *ret_or_error; +} else { + Log *log = aprantl wrote: > The `else` is redundant. Here it's necessary for the scope of `ret_or_error`. That's a bit

[clang-tools-extra] r360277 - [clang-tidy] Update documentation on ReSharper integration.

Author: dergachev Date: Wed May 8 11:12:12 2019 New Revision: 360277 URL: http://llvm.org/viewvc/llvm-project?rev=360277=rev Log: [clang-tidy] Update documentation on ReSharper integration. It's now possible to set custom clang-tidy binary. Patch by Alexander Zaitsev! Differential Revision:

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 198662. ilya-biryukov added a comment. Herald added subscribers: jsji, kbarton, nemanjai. - Propagate whether the token came from a token stream through CachingLex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. In D60605#1495268 , @yvvan wrote: > @ilya-biryukov > What do you think about D53072 ? It can be > polished and combined with this change removing some code from here (which I > assume is

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/ https://reviews.llvm.org/D61454 ___

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

sidneym accepted this revision. sidneym added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61130/new/ https://reviews.llvm.org/D61130

r360271 - Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS

Author: mikerice Date: Wed May 8 10:15:21 2019 New Revision: 360271 URL: http://llvm.org/viewvc/llvm-project?rev=360271=rev Log: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This allows some applications developed with MSVC to compile with clang without

[PATCH] D60910: [WIP] Dumping the AST to JSON

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. If you're happy with these two conditions, then I have no concerns with this moving forward: - There is no implied stability for the content or format of the dump between major releases,

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda created this revision. hintonda added a reviewer: zturner. Herald added subscribers: llvm-commits, delcypher. Herald added projects: clang, LLVM. This test fails to link shared libraries because tries to run a copied version of clang-check to see if the mock version of libcxx in the same

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

mikerice added a comment. For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers. So this would presumably affect only a small numbers of compilation units that only include stddef.h and

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Is there any good reason not to land this? Clangd is crashing for me on macOS with stack overflow in the worker threads. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak updated this revision to Diff 198716. ahatanak marked 3 inline comments as done. ahatanak edited the summary of this revision. ahatanak added a comment. Move the code that was in `AlignedExceptionObject.h` to `getExnObjectAlignment` and remove the header. Repository: rC Clang

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:411 def OpenCLUnsupportedRGBA: DiagGroup<"opencl-unsupported-rgba">; +def UnderalignedExcpObj : DiagGroup<"underaligned-exception-object">; def DeprecatedObjCIsaUsage :

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

thakis added a comment. I agree with that. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61646/new/ https://reviews.llvm.org/D61646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: include/clang/Basic/AlignedExceptionObject.h:31 + case llvm::Triple::MacOSX: // Earliest supporting version is 10.14. +return llvm::VersionTuple(10U, 14U); + case llvm::Triple::IOS:

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

mgehre updated this revision to Diff 198714. mgehre added a comment. Herald added a project: clang. Implement review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24892/new/ https://reviews.llvm.org/D24892 Files:

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. @zturner, I only disabled this on Darwin because that's all I can test on right now. Please let me know if there's a better way to do this or if it should fire on different platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

mgehre created this revision. mgehre added reviewers: alexfh, danielmarjamaki. Herald added a subscriber: xazax.hun. Herald added a project: clang. readability-redundant-declaration was diagnosing a redundant declaration on "extern inline void f();", which is needed in C code to force an external

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. By the way, index/Background.{cpp,h} also need to be changed to use the new API. I made that change locally and clangd with full project indexing is now working for me on macOS. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai created this revision. vsapsai added reviewers: arphaman, erik.pilkington, jkorous. Herald added a subscriber: dexonsmith. A filename can be remapped with a header map to point to a framework header and we can find the corresponding framework without the header. But if the original

r360302 - When typo-correcting a function name, consider correcting to a type name

Author: rsmith Date: Wed May 8 17:57:24 2019 New Revision: 360302 URL: http://llvm.org/viewvc/llvm-project?rev=360302=rev Log: When typo-correcting a function name, consider correcting to a type name for a function-style cast. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

rnk added a comment. In D61646#1495778 , @phosek wrote: > This change broke our build which is using Clang and the > `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the > compilation fails >

r360291 - Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility.

Author: rnk Date: Wed May 8 15:01:20 2019 New Revision: 360291 URL: http://llvm.org/viewvc/llvm-project?rev=360291=rev Log: Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This reverts r360271 (git commit a0933bd8ec1515167ea653f7ee788b8bbde27d51)

r360297 - Try to restore some clang test headers lost in r360291

Author: rnk Date: Wed May 8 15:30:46 2019 New Revision: 360297 URL: http://llvm.org/viewvc/llvm-project?rev=360297=rev Log: Try to restore some clang test headers lost in r360291 I'm not sure why 'git llvm revert' removed them. Added: cfe/trunk/test/Headers/Inputs/

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:6369 // very difficult. Ideally, we should handle them more gracefully. -if (!EIA->getCond()->EvaluateWithSubstitution( +if (EIA->getCond()->isValueDependent() || +

[PATCH] D61709: [NewPM] Port HWASan

leonardchan created this revision. leonardchan added reviewers: philip.pfaffe, fedor.sergeev, chandlerc, phosek. leonardchan added projects: LLVM, clang. Herald added subscribers: hiraditya, srhines. Port hardware assisted address sanitizer to new PM following the same guidelines as msan and

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

phosek added a comment. This change broke our build which is using Clang and the `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the compilation fails

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added a comment. @aaron.ballman and @JonasToth: Thank you for the patience and all the feedback! It means a great deal to me to have a patch accepted here! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:95-98 +if (!S->getQualifierLoc() &&

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda added a comment. In D60629#1494908 , @aaron.ballman wrote: > This LGTM, but you may want to wait a day or so to see if @alexfh has any > remaining concerns. Will do, thanks Aaron... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); We don't typically commit FIXME's into LLVM code. Why not just deal

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS (authored by mikerice, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

I went ahead and did this in r360310. On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > wrote: > > Do I just edit the HTML file directly? > > Or is it generated by something? > > Just edit the HTML file directly. > > > On Wed,

r360310 - [cxx_status] Mark support for std::is_constant_evaluated as done.

Author: rsmith Date: Wed May 8 20:49:47 2019 New Revision: 360310 URL: http://llvm.org/viewvc/llvm-project?rev=360310=rev Log: [cxx_status] Mark support for std::is_constant_evaluated as done. Eric implemented this in r359067. Modified: cfe/trunk/www/cxx_status.html Modified:

[PATCH] D41911: [clangd] Include scanner that finds compile commands for headers.

klimek added inline comments. Comment at: clangd/IncludeScanner.cpp:75 + bool WasEmpty = Queue.empty(); + for (const auto : Cmds) { +QueueEntry E(Cmd, VFS); Usually I'd try to not lock a loop, as a large number of compile commands now blocks other

[PATCH] D41911: [clangd] Include scanner that finds compile commands for headers.

nridge added a comment. Herald added subscribers: jfb, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Are there are plans to move forward with this sort of an include scanning approach? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61716: Expose AtomicType

slowhog created this revision. slowhog added reviewers: yvvan, jbcoe. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. Expose atomic type through the C API. Repository: rC Clang https://reviews.llvm.org/D61716 Files: clang/include/clang-c/Index.h

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

Sorry, I should have been on top of this. /Eric On Wed., May 8, 2019, 11:47 p.m. Richard Smith, wrote: > I went ahead and did this in r360310. > > On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > > wrote: > > > Do I just

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

asbirlea updated this revision to Diff 198587. asbirlea added a comment. Updated test. Improvement suggestions are always *very* much welcome! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61617/new/ https://reviews.llvm.org/D61617 Files:

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Just wanted to update. My latest revision (r360225) seems to have fixed the bots.  On Tue, May 7, 2019 at 3:50 PM Jonas Devlieghere wrote: > Hi Leonard, > > My personal rule of thumb is that if I can fix it in something like 30 > minutes or less, I'll leave the bot red and commit a fix.

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

alexandre.isoard added a comment. I'm not convinced by the approach. Can it still recognize the loop idiom into memcpy implementation but use `memmove` (as only `memcpy` has been blacklisted)? Can it do the same for `memmove` (for the case without overlap), and end-up with infinite recursion?

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664

[clang-tools-extra] r360231 - [clang-tidy] Do not show incorrect fix in modernize-make-unique

Author: ibiryukov Date: Wed May 8 01:52:18 2019 New Revision: 360231 URL: http://llvm.org/viewvc/llvm-project?rev=360231=rev Log: [clang-tidy] Do not show incorrect fix in modernize-make-unique Summary: The case when initialize_list hides behind an implicit case was not handled before.

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

This revision was automatically updated to reflect the committed changes. Closed by commit rL360231: [clang-tidy] Do not show incorrect fix in modernize-make-unique (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak created this revision. ahatanak added reviewers: rjmccall, ldionne. ahatanak added a project: clang. Herald added a reviewer: EricWF. Herald added subscribers: dexonsmith, jkorous. This patch resurrects r264998, which was committed to work around a bug in libc++abi that was causing

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr updated this revision to Diff 198603. gribozavr added a comment. Addressed review comments: - Simplified error handling in SemaOpenMP, - Only check isValueDependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr marked an inline comment as done. gribozavr added a comment. In D61522#1494155 , @rsmith wrote: > The right thing to check in all of these cases should be only > `isValueDependent()`. Every type-dependent expression should generally also > be

[PATCH] D61485: Added an assert in `isConstantInitializer`: initializer lists must be in semantic form

gribozavr added a comment. @rsmith Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61485/new/ https://reviews.llvm.org/D61485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

dnsampaio created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added reviewers: keith.walker.arm, DavidSpickett, carwil. When using `clang -mcpu=CPUNAME+FEATURELIST`, the intrinsic features defined by CPUNAME are not

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Corpus.h:23 +/// token buffers, source manager, etc. +class Corpus { +public: sammccall wrote: > I think plain SyntaxArena might be a better name here :-/ > Corpus refers to

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198609. ilya-biryukov added a comment. - s/corpus/arena - Remove an accidental cmake change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637 Files:

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198606. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Make traverse() internal to its only use-site. - s/Corpus/Arena. - Address some other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

DavidSpickett added a comment. LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61668/new/

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

glider added a comment. Rubberstamp LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. In GCC, the .refptr stubs are only generated for x86_64, and only for code models medium and larger (and medium is the default for x86_64 since this was introduced). They can be omitted (for projects

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia added a comment. In D61506#1493953 , @keryell wrote: > In D61506#1490555 , @rsmith wrote: > > > Per the OpenCL C++ 1.0 specification, section 2: > > > > > The OpenCL C++ programming language is based on

[clang-tools-extra] r360247 - Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

Author: gribozavr Date: Wed May 8 05:02:31 2019 New Revision: 360247 URL: http://llvm.org/viewvc/llvm-project?rev=360247=rev Log: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches Reviewers: alexfh Subscribers: cfe-commits Tags: #clang

[PATCH] D60910: [WIP] Dumping the AST to JSON

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/JSONNodeDumper.h:55 + } + + /// Add a child of the current node with an optional label. aaron.ballman wrote: > riccibruno wrote: > > Perhaps you should

[PATCH] D61506: [OpenCL] Switch to C++17

kpet accepted this revision. kpet added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 ___ cfe-commits mailing list

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198630. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments - Make little modifications to existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:574 - // We want to include the template in the Hover. - if (TemplateDecl *TD = D->getDescribedTemplate()) -D = TD; +llvm::raw_ostream <<(llvm::raw_ostream , +

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno updated this revision to Diff 198629. riccibruno marked 4 inline comments as done. riccibruno added a comment. Address Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60956/new/ https://reviews.llvm.org/D60956 Files:

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360256: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones (authored by owenpan, committed by ). Herald

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. Tests do not pass on current trunk: /d2/llvm/trunk/builds/DebugShared % bin/llvm-lit -a /d2/llvm/trunk/source/tools/clang/test/Index/cxx14-lambdas.cpp llvm-lit: /d2/llvm/trunk/source/utils/lit/lit/llvm/config.py:341: note: using clang:

r360256 - [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones

Author: owenpan Date: Wed May 8 06:49:17 2019 New Revision: 360256 URL: http://llvm.org/viewvc/llvm-project?rev=360256=rev Log: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones Also fix a typo for the SCSU byte order mark. Differential Revision:

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

martong updated this revision to Diff 198626. martong marked 2 inline comments as done. martong added a comment. - Improve and fix typo in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61424/new/ https://reviews.llvm.org/D61424 Files:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:539 -/// Generate a \p Hover object given the declaration \p D. -static Hover getHoverContents(const Decl *D) { - Hover H; - llvm::Optional NamedScope =

r360250 - Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.

Author: aaronballman Date: Wed May 8 06:24:36 2019 New Revision: 360250 URL: http://llvm.org/viewvc/llvm-project?rev=360250=rev Log: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode. Patch by Soumi Manna. Modified:

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov created this revision. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. ilya-biryukov added a parent revision: D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library. Repository: rG LLVM Github Monorepo

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198623. martong added a comment. - Use LLDB_LOG_ERROR in ImportDefinitionTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files:

r360257 - [clang-format] Fix the crash when formatting unsupported encodings

Author: owenpan Date: Wed May 8 07:11:12 2019 New Revision: 360257 URL: http://llvm.org/viewvc/llvm-project?rev=360257=rev Log: [clang-format] Fix the crash when formatting unsupported encodings Fixes PR33946 Differential Revision: https://reviews.llvm.org/D61559 Modified:

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan added a comment. This was accepted a while ago, but never landed. I don't have commit access; could someone commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 ___ cfe-commits

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198618. martong added a comment. - Add braces to 'true' cases when 'false' case has braces - Simplify logging and error handling with LLDB_LOG_ERROR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/

[PATCH] D52967: Extend shelf-life by 70 years

bmwiedemann accepted this revision. bmwiedemann added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Can someone please merge this change? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52967/new/ https://reviews.llvm.org/D52967

r360258 - [Sema][OpenCL] Make address space conversions a bit stricter.

Author: stulova Date: Wed May 8 07:23:49 2019 New Revision: 360258 URL: http://llvm.org/viewvc/llvm-project?rev=360258=rev Log: [Sema][OpenCL] Make address space conversions a bit stricter. The semantics for converting nested pointers between address spaces are not very well defined. Some

[PATCH] D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61644/new/ https://reviews.llvm.org/D61644

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:482 FileDigest Digest; +bool IsMainFile; }; NIT: maybe initialize with `=false` to avoid potential UB. `Digest` seems uninitialized too, could also `={}`

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198654. nik edited the summary of this revision. nik added a comment. Rebased for current trunk. If I miss something obvious, please tell me. Otherwise I'm waiting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:273 +.StartsWith("\xFF\xFE", "UTF-16 (LE)") +.StartsWith("\x2B\x2F\x76", "UTF-7") +.StartsWith("\xF7\x64\x4C", "UTF-1")

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

ZaMaZaN4iK added a subscriber: Szelethus. ZaMaZaN4iK added a comment. @JonasToth @NoQ @Szelethus can anyone merge it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61475/new/ https://reviews.llvm.org/D61475

[PATCH] D58236: Make address space conversions a bit stricter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360258: [Sema][OpenCL] Make address space conversions a bit stricter. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52967: Extend shelf-life by 70 years

aaron.ballman closed this revision. aaron.ballman added a comment. In D52967#1494969 , @bmwiedemann wrote: > Can someone please merge this change? I commit the change in r360254, thank you for the patch! Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1494722 , @ebevhan wrote: > This was accepted a while ago, but never landed. I don't have commit access; > could someone commit it? Sure! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you may want to wait a day or so to see if @alexfh has any remaining concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 198637. nik added a comment. The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to the external diagnostic engine. @alexfh: What do you think? If that looks roughly OK for you, I'll finish it. Repository: rCTE Clang Tools Extra

r360254 - Allow test to pass after 2030.

Author: aaronballman Date: Wed May 8 06:42:44 2019 New Revision: 360254 URL: http://llvm.org/viewvc/llvm-project?rev=360254=rev Log: Allow test to pass after 2030. Patch by Bernhard M. Wiedemann. Modified: cfe/trunk/test/Modules/fmodules-validate-once-per-build-session.c Modified:

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan updated this revision to Diff 198652. owenpan added a comment. Fixed the typo for SCSU. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https://reviews.llvm.org/D61559 Files: clang/tools/clang-format/ClangFormat.cpp Index:

[PATCH] D61559: Fix the crash when formatting unsupported encodings

This revision was automatically updated to reflect the committed changes. Closed by commit rL360257: [clang-format] Fix the crash when formatting unsupported encodings (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198656. nik added a comment. Herald added a subscriber: dexonsmith. Minor diff update fixing indentation and removing not needed include. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov added a comment. Sorry for losing this. Neat change, minimal and focused, thanks! Just wanted to clarify why we need the change in `SourceManager.cpp`, will LGTM as soon as we resolve this Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName =

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov added a comment. This actually works, but still far from landing. Notable problems: - this adds a dependency on `TokenBuffer`, so we need to land it first. - this change is too big, planning to split into multiple changes: (1) collecting tokens when building the AST for clangd,

[PATCH] D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360247: Documentation for bugprone-inaccurate-erase: added an example of a bug that… (authored by gribozavr, committed by ). Changed prior to commit:

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia updated this revision to Diff 198627. Anastasia added a comment. Added `HexFloat`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 Files: include/clang/Frontend/LangStandards.def test/CodeGenOpenCLCXX/addrspace-of-this.cl Index:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a formatting issue, this LGTM, thank you! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:93 +DeclarationName Name =

r360249 - [libclang] PR41649: Remove pointless duplicate flag. NFC.

Author: nik Date: Wed May 8 06:19:29 2019 New Revision: 360249 URL: http://llvm.org/viewvc/llvm-project?rev=360249=rev Log: [libclang] PR41649: Remove pointless duplicate flag. NFC. Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL:

  1   2   >