[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Final review ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as

thakis added a comment. I think https://reviews.llvm.org/D65108 is a better fix, for the reason rnk gave above. I think this one can be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64655/new/ https://reviews.llvm.org/D64655

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis added a comment. Note to self: Check https://github.com/ClangBuiltLinux/linux/issues/598 before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) (This

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

aaron.ballman added inline comments. Comment at: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:57 + assert(Decl->getNumParams() > 0); + SourceLocation NoexceptLoc = Decl->getParamDecl(Decl->getNumParams() - 1) +

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:181 +std::string TextNode::getHTMLEntity(const char ) { + switch (C) { There is printHTMLEscaped() in ADT/StringExtras.h. May b it could be used or common code

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. @jfb’s comment seems to be not addressed. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. CHANGES SINCE LAST

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

leonardchan created this revision. leonardchan added reviewers: chandlerc, craig.topper, spatel, RKSimon. leonardchan added a project: clang. This patch changes the following tests to run under the new pass manager only: Clang :: CodeGen/avx512-reduceMinMaxIntrin.c (1 of 4) Clang ::

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus added a comment. In D64991#1596292 , @NoQ wrote: > In D64991#1595853 , @Szelethus wrote: > > > `CFGElementRef` > > > Wait, is it a thing already?? Did i miss anything??? Oh, yea, I have it locally,

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211184. dgoldman added a comment. - Bug fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp Index:

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Ping. I am going to submit this patch if nobody objects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

efriedma edited reviewers, added: aaron.ballman; removed: doug.gregor, eli.friedman, lvoufo. efriedma added a comment. Is this the only place where a compound type can contain a PackExpansionType? The code could probably use a brief comment explaining why we need to check this explicitly, even

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Replace <, > and " with its corresponding html entities before rendering text nodes. https://reviews.llvm.org/D65107 Files:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek requested changes to this revision. klimek added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/LibASTMatchersReference.html:5277

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

NoQ added a comment. In D64991#1595853 , @Szelethus wrote: > `CFGElementRef` Wait, is it a thing already?? Did i miss anything??? > This analysis isn't conservative enough yet, I really should include function > calls with non-const references into

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. I created D65110 if we're ok with just using the new PM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___ cfe-commits mailing list

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added a comment. Thanks, LGTM. Do you need someone to commit this for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 ___ cfe-commits mailing list

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211213. Nathan-Huckleberry added a comment. - Add tracking of declaration of initializers in Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files:

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > (This just wraps all the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args))

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > nit: I'd just

[libunwind] r366734 - [runtimes] Don't depend on libpthread on Android

Author: kongyi Date: Mon Jul 22 13:41:03 2019 New Revision: 366734 URL: http://llvm.org/viewvc/llvm-project?rev=366734=rev Log: [runtimes] Don't depend on libpthread on Android r362048 added support for ELF dependent libraries, but broke Android build since Android does not have libpthread.

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

vsk created this revision. vsk added reviewers: ahatanak, JDevlieghere, friss. Herald added a subscriber: dexonsmith. rdar://53267670 https://reviews.llvm.org/D65116 Files: clang/lib/Driver/ToolChains/MSVC.h clang/test/Misc/win32-macho.c Index: clang/test/Misc/win32-macho.c

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rL366744: [Driver] Set the default win32-macho debug format to DWARF (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r366744 - [Driver] Set the default win32-macho debug format to DWARF

Author: vedantk Date: Mon Jul 22 14:46:45 2019 New Revision: 366744 URL: http://llvm.org/viewvc/llvm-project?rev=366744=rev Log: [Driver] Set the default win32-macho debug format to DWARF rdar://53267670 Differential Revision: https://reviews.llvm.org/D65116 Modified:

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs()); I think it would be better

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman added a comment. In D62648#1596535 , @rsmith wrote: > Thanks, LGTM. Do you need someone to commit this for you? Nope, I can commit it. There's still one outstanding issue though: typo-correction-cxx11.cpp is still failing with the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis created this revision. thakis added a reviewer: rnk. This relands r365703 (and r365714), originally reviewed at https://reviews.llvm.org/D64527. The problem with the old approach was that clang would now warn about -Wa flags that the integrated assembler didn't understand even when

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > nickdesaulniers wrote: >

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nathanchance added a comment. I tested this patch on top of r366728 and saw no regressions in my set of kernel builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.h:81 /// Set CodeView as the default debug info format. Users can use -gcodeview /// and -gdwarf to override the default. Let's update the comment. CHANGES SINCE LAST

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

davide accepted this revision. davide added a comment. Minor otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65116/new/ https://reviews.llvm.org/D65116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran updated this revision to Diff 211201. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Use printHTMLEscaped() in ADT/StringExtras.h to write HTML entities. CHANGES SINCE LAST ACTION

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, Thank you again for working on this patch. I think it can be committed after minor stylish issues are fixed. Comment at: clang/lib/AST/ASTImporter.cpp:1677

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman added a comment. In D64666#1596619 , @xbolva00 wrote: > I think @jfb wanted to say that if we know we always lose the precision, we > should warn even without -Wxyz, no? Oh, good catch! I hadn't noticed that *both* diagnostics were

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366761: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65125: clang-format: Fix namespace end comments for namespaces with attributes and macros

thakis created this revision. thakis added reviewers: klimek, sammccall. Fixes PR39247. While here, also make C++20 `namespace A::inline B::inline C` nested inline namespaced definitions work. Before: #define DEPRECATE_WOOF [[deprecated("meow")]] namespace DEPRECATE_WOOF woof { void

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. This patch extends the warnings for additional cases: 1. When the temporary is the

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman accepted this revision. aaron.ballman added a comment. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. We don't often add

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1689 + void popDeclForInitializer() { +DeclForInitializer.pop_back(); + } might be nice to return the result, but maybe YAGNI? Repository: rG LLVM Github Monorepo

r366761 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 1.

Author: zer0 Date: Mon Jul 22 16:10:10 2019 New Revision: 366761 URL: http://llvm.org/viewvc/llvm-project?rev=366761=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. Moves list of phases into Types.def table: Currently Types.def contains a table of strings that are used to

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think we should warn in that case even if GCC does not warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry updated this revision to Diff 211230. Nathan-Huckleberry added a comment. - Disable self reference checking for C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64678/new/ https://reviews.llvm.org/D64678 Files:

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

alexfh added a comment. LessClangTidyError only compares location and message, but it could also compare other things like notes, fixes, etc. For the problem outlined in the description of this patch we can probably include the checker name into the key. WDYT? Repository: rCTE Clang Tools

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun added a parent revision: D65120: More warnings regarding gsl::Pointer and

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 211245. ziangwan added a comment. Update diff 1. Fix trailing whitespaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev created this revision. sdmitriev added reviewers: hfinkel, ABataev. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. This is the first set of changes for eliminating OpenMP linker script that adds new

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1698 +} +return nullptr; + } Does: `return DeclForInitializer.empty() ? DeclForInitializer.back() : nullptr;` fit on one line? Comment at:

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1596512 , @xbolva00 wrote: > @jfb’s comment is not addressed yet. > > In D64666#1583629 , @jfb wrote: > > > I think you want to default-ignore the "may lose precision" warnings,

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211224. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2009 +AnalysisDeclContext , +SmallVector PUDs) { + is `clang` namespace required here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6564 +static bool shouldTrackImplicitObjectArg(const CXXMethodDecl *Callee, + const CXXMemberCallExpr *MCE) { + if (auto

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > aaron.ballman

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:2 // RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.InnerPointer \ -// RUN: %s -analyzer-output=text -verify I had to disable

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; george.burgess.iv wrote: > aaron.ballman wrote: > > george.burgess.iv

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think @jfb wanted to say that if we know we always lose the precision, we should warn even without -Wxyz, no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211221. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A new function will be added to get the original SourceLocation for a SourceLocation that was

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske added a comment. New patch: https://reviews.llvm.org/D65064 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -emit-llvm -target-feature +sve -o - %s | FileCheck %s + rovka wrote: > Can you also add a test without +sve, to make

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib created this revision. bruntib added reviewers: alexfh, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, mgrang, rnkovacs, whisperity. Herald added a project: clang. In case a checker is registered multiple times as an alias, the emitted warnings are uniqued by the report

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added reviewers: srhines, danalbert. peter.smith added a comment. I think that this may not apply for Android as AFAIK their ABI still requires 128-bit alignment in some cases. Adding some more reviewers from Android. Comment at: lib/Basic/Targets/ARM.cpp:311

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

martong added a comment. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me! Comment at: lib/AST/ASTImporter.cpp:1286 - return Importer.getToContext().getAutoType(*ToDeducedTypeOrErr, - T->getKeyword(), -

[PATCH] D65067: [clangd] Fix auto expand not work on "const au^to s = 123;"

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65067 Files:

r366670 - [OpenCL] Improve destructor support in C++ for OpenCL

Author: mantognini Date: Mon Jul 22 02:39:13 2019 New Revision: 366670 URL: http://llvm.org/viewvc/llvm-project?rev=366670=rev Log: [OpenCL] Improve destructor support in C++ for OpenCL This re-applies r366422 with a fix for Bug PR42665 and a new regression test. Added:

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65064/new/ https://reviews.llvm.org/D65064

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue)); TRY_TO(TraverseSynOrSemInitListExpr( S->isSemanticForm() ? S : S->getSemanticForm(), Queue));

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211034. dnsampaio added a comment. - Set androideabi alignment to 128 bits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/ARM.cpp

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov updated this revision to Diff 211035. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rewrite code as suggested in the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64762/new/

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476 + NewImporter->setFileIDImportHandler( + [this, Unit](FileID ToID, FileID FromID, ASTImporter ) { +assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() &&

r366672 - [AST] Treat semantic form of InitListExpr as implicit code in traversals

Author: ibiryukov Date: Mon Jul 22 02:58:53 2019 New Revision: 366672 URL: http://llvm.org/viewvc/llvm-project?rev=366672=rev Log: [AST] Treat semantic form of InitListExpr as implicit code in traversals Summary: In particular, do not traverse the semantic form if shouldVisitImplicitCode()

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

This revision was automatically updated to reflect the committed changes. Closed by commit rL366672: [AST] Treat semantic form of InitListExpr as implicit code in traversals (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r366674 - [clangd] Log input code of failed highlighting tests. NFC

Author: ibiryukov Date: Mon Jul 22 03:05:11 2019 New Revision: 366674 URL: http://llvm.org/viewvc/llvm-project?rev=366674=rev Log: [clangd] Log input code of failed highlighting tests. NFC Modified: clang-tools-extra/trunk/clangd/unittests/SemanticHighlightingTests.cpp Modified:

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Set android-abi default to 128. Added tests for android and not-android. Comment at: lib/Basic/Targets/ARM.cpp:311 // Maximum alignment for ARM NEON data types should be 64-bits (AAPCS) if (IsAAPCS

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 211042. SjoerdMeijer added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Moved the codegen test to a separate file - Added a langref description for this new metadata node. CHANGES SINCE LAST ACTION

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. Thanks for the update. Will be worth adding some reviewers from Apple to see if this change should be IsAAPCS only. I've no more further comments myself besides a small nit on style. Comment at: lib/Basic/Targets/ARM.cpp:331 + // but

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

rovka added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -emit-llvm -target-feature +sve -o - %s | FileCheck %s + sdesmalen wrote: > rovka wrote: > > Can you also add a test

[clang-tools-extra] r366675 - [clangd] Set buffer name for main file. NFCI

Author: sammccall Date: Mon Jul 22 04:12:16 2019 New Revision: 366675 URL: http://llvm.org/viewvc/llvm-project?rev=366675=rev Log: [clangd] Set buffer name for main file. NFCI Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D64863: [clangd] Ignore diags from builtin files

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info,

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske updated this revision to Diff 211059. balazske marked an inline comment as done. balazske added a comment. Removed ASTImporter from "callback" function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65064/new/

[PATCH] D65064: [CrossTU] Add a function to retrieve original source location.

balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:476 + NewImporter->setFileIDImportHandler( + [this, Unit](FileID ToID, FileID FromID, ASTImporter ) { +assert(ImportedFileIDs.find(ToID) == ImportedFileIDs.end() &&

r366682 - Revert the change to the [[nodiscard]] feature test macro value.

Author: aaronballman Date: Mon Jul 22 05:49:28 2019 New Revision: 366682 URL: http://llvm.org/viewvc/llvm-project?rev=366682=rev Log: Revert the change to the [[nodiscard]] feature test macro value. This value only gets bumped once both P1301 and P1771 are implemented. Modified:

Re: r366626 - Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute.

On Sun, Jul 21, 2019 at 7:40 AM Richard Smith wrote: > > On Sat, 20 Jul 2019 at 09:55, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Sat Jul 20 00:56:34 2019 >> New Revision: 366626 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=366626=rev >> Log: >> Implement

r366683 - Updated the signature for some stack related intrinsics (CLANG)

Author: cdevadas Date: Mon Jul 22 05:50:30 2019 New Revision: 366683 URL: http://llvm.org/viewvc/llvm-project?rev=366683=rev Log: Updated the signature for some stack related intrinsics (CLANG) Modified the intrinsics int_addressofreturnaddress, int_frameaddress & int_sponentry. This commit

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366683: Updated the signature for some stack related intrinsics (CLANG) (authored by cdevadas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

aaron.ballman added a comment. Is it intentional that this review has no reviewers listed (like, is this a work in progress you don't expect review on yet)? Comment at: clang/include/clang/Basic/Attr.td:2985 + "pipeline",

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM alongside NS_ENUM.

heijink updated this revision to Diff 211065. heijink edited the summary of this revision. heijink added a comment. Also added support for formatting CF_CLOSED_ENUM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer added a comment. > Is it intentional that this review has no reviewers listed (like, is this a > work in progress you don't expect review on yet)? No, sorry about this, that's not intentional. It started indeed as a work-in-progress patch when I wrote to the clang/llvm with an

[clang-tools-extra] r366687 - Update documentation for all CERT checks that correspond to a recommendation.

Author: aaronballman Date: Mon Jul 22 06:22:08 2019 New Revision: 366687 URL: http://llvm.org/viewvc/llvm-project?rev=366687=rev Log: Update documentation for all CERT checks that correspond to a recommendation. CERT removed their C++ secure coding recommendations from public view and so the

[PATCH] D65067: [clangd] Fix auto expand not work on "const au^to s = 123;"

hokein abandoned this revision. hokein added a comment. as discussed, this is an issue of selection tree (selection tree should give the `AutoTypeLoc` on `const aut^o`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65067/new/

[PATCH] D63126: [clangd] Implement "prepareRename"

hokein updated this revision to Diff 211080. hokein added a comment. Update the patch, and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63126/new/ https://reviews.llvm.org/D63126 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

r366689 - [OPENMP]Add support for analysis of firstprivate variables.

Author: abataev Date: Mon Jul 22 06:51:07 2019 New Revision: 366689 URL: http://llvm.org/viewvc/llvm-project?rev=366689=rev Log: [OPENMP]Add support for analysis of firstprivate variables. Summary: Firstprivate variables are the variables, for which the private copies must be created in the

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366689: [OPENMP]Add support for analysis of firstprivate variables. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. This patch adds isDirectlyDerivedFrom AST-matcher which is similar to isDerivedFrom but only matches against direct base classes. Repository: rC Clang

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211094. erichkeane marked an inline comment as done. erichkeane added a comment. Rebased and did all the comments (including the www_status). @aaron.ballman : Wasn't positive what you meant about the conversion functions, but I think I got one? I would

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer updated this revision to Diff 211096. SjoerdMeijer added a comment. More doc changes added to `AttrDocs.td` and `LangRef.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64744/new/ https://reviews.llvm.org/D64744 Files: clang/docs/LanguageExtensions.rst

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. @a_sidorin, @shafik This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 ___ cfe-commits mailing list

  1   2   >