[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:646 + bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { +

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet updated this revision to Diff 225837. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + ilya-biryukov wrote: > How is

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + ilya-biryukov wrote: > kadircet

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet updated this revision to Diff 225850. kadircet added a comment. - Store unique_ptr instead of a raw one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files:

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

ilya-biryukov added a comment. Overall LG, just a few quick questions. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:65 SelectionTree ASTSelection; +/// The Index being used by ClangdServer. +const SymbolIndex *Index = nullptr; NIT: Let's

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69241 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc created this revision. poelmanc added reviewers: gribozavr, etienneb, alexfh. Herald added subscribers: cfe-commits, mgehre, dylanmckay. Herald added a project: clang. `readability-redundant-string-init` was one of several clang-tidy checks documented as failing for C++17 by

[PATCH] D69242: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: Anastasia. Herald added a project: clang. ilya-biryukov retitled this revision from "[Sema] Make helper in Sema.h 'inline' instead of 'static'" to "[Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC".

[PATCH] D69242: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

merge_guards_bot added a comment. Build result: fail - 33519 tests passed, 1 failed and 464 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

ilya-biryukov added a comment. This can be obtained from the file manager inside the AST. I guess a helper function to do this would be helpful, but I don't think we need to strore another copy of it. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:844 +int $1^abc; +$2^X(): $3^abc() {} + }; Could you also add a test with the initializer containing a base

[PATCH] D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67543/new/ https://reviews.llvm.org/D67543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 33623 tests passed, 1 failed and 462 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + kadircet wrote: > ilya-biryukov wrote: > > How is this index populated?

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet updated this revision to Diff 225871. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files:

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

sammccall added a comment. Thanks! I'd been meaning to do this before my vacation (and had a draft I'll dig up in case there were other issues). Generally I think we should be willing to change behavior in some marginal cases, and I do think it's important to care about the layering of seltree

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

echristo added a comment. I kinda want the option to be encoded in the triple for earlier testing of linking issues, but for now this is probably OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Writing support for two ACLE functions: unsigned int __cls(uint32_t x) unsigned int __clsl(unsigned long x) CLS stands for "Count number of

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:78 +const clang::NamedDecl *Decl, const clang::Expr *CtorExpr) { + const auto = *Result.SourceManager; + const StringRef Name =

[PATCH] D67025: Add .inl as valid C++ header type

abbaswasim added a comment. Herald added a subscriber: usaxena95. Hi All, I am not fully aware of the process here could anyone point me to what is the next step? Has anyone looked at this Patch? //Wasim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +Selection(ParsedAST , unsigned

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

kadircet abandoned this revision. kadircet added a comment. As discussed offline, dropping the change to fetch the FS from filemanager, to prevent any consistency that might be caused due to having different contents for files in AST while creating it vs while generating refactorings.

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 225896. poelmanc added a comment. Rebase to latest master (tests moved into new "checkers" subdirectory.) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 Files:

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. gental ping~ @modocache @GorNishanov Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69213: Avoid appending the source directory to an absolute path

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69213/new/ https://reviews.llvm.org/D69213 ___

[PATCH] D69213: Avoid appending the source directory to an absolute path

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:541 +MainFileDir = MainFile->getDir()->getName(); +if (MainFileDir != "." && !llvm::sys::path::is_absolute(MainFileName)) { llvm::SmallString<1024> MainFileDirSS(MainFileDir);

[PATCH] D69213: Avoid appending the source directory to an absolute path

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:541 +MainFileDir = MainFile->getDir()->getName(); +if (MainFileDir != "." && !llvm::sys::path::is_absolute(MainFileName)) {

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin updated this revision to Diff 225900. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. - Rebased patch, removed extra sext & zext combine from DAGCombine which are no longer necessary - Added isVectorLoadExtDesirable to AArch64ISelLowering - Added more

[PATCH] D69266: [clangd] Define out-of-line availability checks

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Initial availability checks for performing define out-of-line code action, which is a refactoring

[PATCH] D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

bjope created this revision. bjope added a reviewer: rnk. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. Use a forward declaration of DataLayout instead of including DataLayout.h in clangs TargetInfo.h. This reduces include dependencies toward

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @dmgreen! I have updated the patch to make use of the changes to DAGCombine introduced by D68337 . Comment at:

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I finally got my system well setup enough to check this patch with my risc-v toolchains. It looks good, I'm happy for this to land. There's no requirement to support MULTILIB_REUSE yet. It

[PATCH] D69213: Avoid appending the source directory to an absolute path

This revision was automatically updated to reflect the committed changes. Closed by commit rG122e7af03df6: PCH debug info: Avoid appending the source directory to an absolute path (authored by aprantl). Herald added a project: clang. Changed prior to commit:

[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI

bjope created this revision. bjope added a reviewer: rnk. Herald added subscribers: cfe-commits, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. Reduce include dependencies by no longer including Pass.h from DataLayout.h. That include seemed irrelevant to DataLayout, as wee as lots of

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

nhlubek added a comment. In D14484#1689271 , @MyDeveloperDay wrote: > Looking at this I'm wondering if this Isn't at least partially handled by the > `BreakConstructorInitializersStyle` in combination with >

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added a comment. tests are missing, but the patch should be sufficient for initial review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 ___

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc marked an inline comment as done. poelmanc added a comment. Checked "Done". (I addressed @jonathanmeier's comment feedback with a previous update but forgot to check the box!) I welcome any more feedback. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. Thanks for implementing this. I think we could split it into multiple changes to make understanding it easier, see inline comments, I've tried to point out the places I find relevant. Would definitely be nice to have some unit-tests for this. Another important

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225899. dgoldman added a comment. - Swap to reinterpret_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman marked 4 inline comments as done. dgoldman added inline comments. Comment at: tools/clang-fuzzer/handle-objc/handle_objc.cpp:50 +); +} + morehouse wrote: > Since this is ~identical to handle_cxx, I'd like to reuse the

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc updated this revision to Diff 225894. poelmanc added a comment. Removed the two uses of auto where the type was not an iterator or clear from the right-hand-side. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 2 inline comments as done. poelmanc added a comment. Thanks for the quick feedback, fixed. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/ https://reviews.llvm.org/D69238 ___

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 33608 tests passed, 1 failed and 462 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69241: [clangd] Handle the missing consturctor initializers in findExplicitReferences.

ilya-biryukov added a comment. NIT: there's a typo in the revision title: should be **constructor**, not **consturctor** Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69241/new/ https://reviews.llvm.org/D69241

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc updated this revision to Diff 225897. poelmanc added a comment. Rebase to latest master (tests moved into new "checkers" directory.) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145 Files:

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc marked 2 inline comments as done. poelmanc added a comment. Addressed these the other day but failed to check the "Done" boxes. Done! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman updated this revision to Diff 225898. dgoldman added a comment. - Refactor to use handle-cxx Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 Files: tools/clang-fuzzer/CMakeLists.txt

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

As expected, this broke the Chromium build again (but it seems only at -Oz this time). I'm still not a big fan of the warning: the #pragma tells the compiler to vectorize, and then vectorization doesn't happen -- that sounds like a compiler bug to me, and instead of pushing the problem on the

r375423 - PCH debug info: Avoid appending the source directory to an absolute path

Author: adrian Date: Mon Oct 21 09:44:37 2019 New Revision: 375423 URL: http://llvm.org/viewvc/llvm-project?rev=375423=rev Log: PCH debug info: Avoid appending the source directory to an absolute path When building a precompiled header in -fmodule-format=obj (i.e., `-gmodules) in an absolute

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

glider added subscribers: rsmith, dvyukov, dblaikie, arthur.j.odwyer, fwyzard, kristina, mehdi_amini, troyj. glider added a comment. Adding more people from the original discussion. Folks, we're now stuck in a situation where there's a potential buy-in from the Linux kernel community for stack

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein created this revision. hokein added reviewers: ilya-biryukov, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This is the initial version. The cross-file rename is purely based on the index (plus a text-match

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 225943. ajpaverd marked 6 inline comments as done. ajpaverd added a comment. Final changes and tests suggested by @rnk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk added a comment. I was able to test this on a Windows machine. The `ExtraDeps` are already being added to the dependency output (this code does that - https://github.com/llvm/llvm-project/blob/master/clang/lib/Frontend/DependencyFile.cpp#L188). My suspicion for why I wasn't seeing them

[PATCH] D68969: [clang-format] Remove the dependency on frontend

thakis added a comment. klimek: ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe5ecba4f53e7: [clang-fuzzer] Add new fuzzer target for Objective-C (authored by dgoldman). Changed prior to commit:

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

jfb added a comment. In D66046#1717229 , @thakis wrote: > Mr Trieu, what do you think about adding some or all of the > Wtautological-compare warnings to Wall It's addressed in the patch description:

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; andrew.w.kaylor wrote: > rjmccall wrote: > > What's the purpose of this restriction? Whether

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. That comment explains why this is not by default (= without any -W flag) but does not explain why this is not part of -Wall (if user enables -Wall, he/she cares about warnings) [you asked about default ignore]. We have many warnings flagged as DefaultIgnore but they

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225834. abelkocsis added a comment. Findig SIGTERM replaced on checker Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files:

[PATCH] D69276: Add missing assertions in testcase

jonathanmeier created this revision. jonathanmeier added reviewers: clang, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add two missing assertions for testcases introduced in rL373874 . Repository: rG LLVM Github Monorepo

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm updated this revision to Diff 225939. twardakm added a comment. Rebase with master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added a comment. Mr Trieu, what do you think about adding some or all of the Wtautological-compare warnings to Wall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

andrew.w.kaylor added a comment. Thanks for the patch! I don't have time to review this in detail this week, but I'm very happy to see this functionality. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">,

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc /tmp/vectorize.cc:1:6: error: loop not interleaved: the

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

On 10/21/19 4:00 PM, Jordan Rupprecht via cfe-commits wrote: There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

twardakm added a comment. In D55793#1571534 , @aaron.ballman wrote: > In D55793#1535895 , @m4tx wrote: > > > @JonasToth thanks for asking! Yes, since I do not have commit access, I > > need someone to do the

r375453 - [clang-fuzzer] Add new fuzzer target for Objective-C

Author: dgoldman Date: Mon Oct 21 13:45:02 2019 New Revision: 375453 URL: http://llvm.org/viewvc/llvm-project?rev=375453=rev Log: [clang-fuzzer] Add new fuzzer target for Objective-C Summary: - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 225955. ajpaverd marked 3 inline comments as done. ajpaverd added a comment. Formatting fixes for CFGuard patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

yaxunl created this revision. yaxunl added a reviewer: tra. Add this option to allow device side class type global variables with non-trivial ctor/dtor. device side init/fini functions will be emitted, which will be executed by HIP runtime when the fat binary is loaded/unloaded. This feature is

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 225915. mgorny added a comment. Rebased and updated coding style. @ruiu, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Writer.cpp

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > MaskRay wrote: > > This is obvious. The comment can be removed. > Not done. `// default`

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. This looks good as an intermediate step to make lld saner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r375438 - Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

Author: bjope Date: Mon Oct 21 10:58:14 2019 New Revision: 375438 URL: http://llvm.org/viewvc/llvm-project?rev=375438=rev Log: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC Summary: Use a forward declaration of DataLayout instead of including DataLayout.h in clangs

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, andrew.w.kaylor, kpn, hfinkel, cameron.mcinally, uweigand. Herald added a project: clang. This change implements support of '#pragma STDC FENV_ACCESS' in frontend. The pragma is supported only at namespace level and in

[PATCH] D69268: [HIP] Add option -fgpu-allow-device-init

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. I wish we could do that for CUDA. Comment at: lib/Frontend/CompilerInvocation.cpp:2530 Opts.GPURelocatableDeviceCode = Args.hasArg(OPT_fgpu_rdc); +

[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f43ea41c330: Prune Pass.h include from DataLayout.h. NFCI (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69261/new/

[PATCH] D69271: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. stevewan abandoned this revision. Herald added subscribers: wuzish, ormris. This patch adds AIX toolchain infrastructure into driver, and enables AIX system

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. Does this work for C++? C++ templates? I only see C tests. Is there a way forward to support having the #pragma at the start of any block inside a function? The effect won't be restricted to that block, true, but the standard does say the #pragma is allowed. Repository:

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a subscriber: aaron.ballman. xbolva00 added a comment. This needs explicit -Wtautological-compare - which makes me sad (useful warning but hidden for users). cc @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > This is obvious. The comment can be removed. Not

[PATCH] D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG78424e5f8417: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225925. stevewan marked 8 inline comments as done. stevewan added a comment. Tidy code with lambda expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

mehdi_amini added a comment. In D64742#1606244 , @glider wrote: > As a data point, Linus Torvalds suggested that we need a similar feature for > GCC so that the "kernel C standard" mandates zero-initialization for locals: >

r375440 - SemaExceptionSpec - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 21 11:28:31 2019 New Revision: 375440 URL: http://llvm.org/viewvc/llvm-project?rev=375440=rev Log: SemaExceptionSpec - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063 const_cast(D), PID); } } aprantl wrote: > rjmccall wrote: > > Is this special treatment still necessary? Won't we encounter the getter

[PATCH] D68884: Add support to -Wa,-W in clang

MaskRay added inline comments. Comment at: clang/test/Driver/as-w-option.c:1 +// RUN: %clang -### %s -c -o tmp.o -fno-integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHECK-NOIAS %s +// RUN: %clang -### %s -c -o tmp.o -integrated-as -Wa,-W 2>&1 | FileCheck

r375434 - Fix Wdocumentation warning. NFCI.

Author: rksimon Date: Mon Oct 21 10:45:18 2019 New Revision: 375434 URL: http://llvm.org/viewvc/llvm-project?rev=375434=rev Log: Fix Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AST/ExprCXX.h URL:

r375439 - [test] Merge Driver/as-w-warnings.c into as-no-warnings.c

Author: maskray Date: Mon Oct 21 11:04:52 2019 New Revision: 375439 URL: http://llvm.org/viewvc/llvm-project?rev=375439=rev Log: [test] Merge Driver/as-w-warnings.c into as-no-warnings.c For -integrated-as RUN lines we can remove -target. Removed: cfe/trunk/test/Driver/as-w-option.c

r375436 - Prune Pass.h include from DataLayout.h. NFCI

Author: bjope Date: Mon Oct 21 10:51:54 2019 New Revision: 375436 URL: http://llvm.org/viewvc/llvm-project?rev=375436=rev Log: Prune Pass.h include from DataLayout.h. NFCI Summary: Reduce include dependencies by no longer including Pass.h from DataLayout.h. That include seemed irrelevant to

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); jasonliu wrote: > Xiangling_L wrote: > > Is there any

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 225926. SouraVX added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:890 + "cannot apply to inline functions, ignoring pragma">, + InGroup; What's the purpose of this restriction? Whether `inline` really has much to do with

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); I don't see a pattern match for the `cls64` on ARM32, would that not fail to lower?

[PATCH] D67247: Added missing unqualified name lookup of operator overloads for fold expressions

jonathanmeier updated this revision to Diff 225928. jonathanmeier changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. jonathanmeier added a comment. - Rebased to adapt to the latest changes for spaceship operator and comparison operator rewrite support in rL375305

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added a comment. Ah, that's a good reason. Are they in -Wall? We've sometimes reconned "-Wall == needs CFG" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rG87cb734c04be: [Clang] Add VerboseOutputStream to CompilerInstance (authored by scott.linder). Herald added a project: clang. Changed prior to commit:

r375443 - SemaTemplateDeduction - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 21 12:08:31 2019 New Revision: 375443 URL: http://llvm.org/viewvc/llvm-project?rev=375443=rev Log: SemaTemplateDeduction - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in

[PATCH] D69261: Prune Pass.h include from DataLayout.h. NFCI

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > That include seemed irrelevant to DataLayout, as > wee as lots of users of DataLayout. Typo in commit message (well as...), worth fixing before landing. lgtm Comment at:

  1   2   >