[clang-tools-extra] b5f295f - AvoidBindCheck.cpp: Fix unused variables warning

Author: Hans Wennborg Date: 2019-12-03T08:59:01+01:00 New Revision: b5f295ffcec2fa7402e39eb1262acbd55a7d39f5 URL: https://github.com/llvm/llvm-project/commit/b5f295ffcec2fa7402e39eb1262acbd55a7d39f5 DIFF: https://github.com/llvm/llvm-project/commit/b5f295ffcec2fa7402e39eb1262acbd55a7d39f5.diff

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:532 + const IdentifierInfo *II = MacroRef.first; + if (const auto *MI = PP->getMacroDefinition(II).getMacroInfo()) +if (auto ID = getSymbolID(II->getName(), MI, PP->g

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231834. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Will update the increase in size of index shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. klimek wrote: > Personally, I'm somewhat

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: pass - 60166 tests passed, 0 failed and 730 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks fine to me. Comment at: clang/docs/SourceBasedCodeCoverage.rst:330 +last case ends). This gap region has a zero count: this causes "gap" areas in +between case statements,

[clang-tools-extra] 9091f06 - [NFC] Slightly improve wording in the comments

Author: Kirill Bobyrev Date: 2019-12-03T10:12:17+01:00 New Revision: 9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0 URL: https://github.com/llvm/llvm-project/commit/9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0 DIFF: https://github.com/llvm/llvm-project/commit/9091f06994f09fceb079aa01e0fa3e1ea5c9e9f0.diff

[PATCH] D70943: [NFC] Slightly improve wording in the comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG9091f06994f0: [NFC] Slightly improve wording in the comments (authored by kbobyrev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

russell.gallop added a comment. Thanks for the updated timings. I have no objection to this going in. I haven't gone through the code changes in detail so I think you should probably get approval from someone who has (such as @hans). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover marked an inline comment as done. t.p.northover added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:587 +"Apple A10", [ +ProcAppleA7, +Featu

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added a comment. **Before this patch** `CollectMacro` is disabled by default Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes - number of symbols: 462463 - number of refs: 6361763 - numnber of relations: 20322 **Before this patch** `CollectMacr

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. In D68101#1766359 , @rjmccall wrote: > I can't speak for the pragma authors, but I strongly doubt the pragma is > intended to force all affected globals to go into a single section unit, > since the division into section units

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice, thanks! Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1349 + // the base dtor is emitted. + // FIXME: To match MSVC, this should only be done when the class was + //

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VMULH/VRMULH intrinsics and unit tests. Repository: rG LLVM Github Mo

[clang] 01a26fa - [clang][CodeGen] Make use of cc1 instead of clang in the tests

Author: Kadir Cetinkaya Date: 2019-12-03T12:02:26+01:00 New Revision: 01a26fa74a9b3ab876a7d3bf30d9aca2d5dfcc7d URL: https://github.com/llvm/llvm-project/commit/01a26fa74a9b3ab876a7d3bf30d9aca2d5dfcc7d DIFF: https://github.com/llvm/llvm-project/commit/01a26fa74a9b3ab876a7d3bf30d9aca2d5dfcc7d.dif

[PATCH] D70950: Add ProcName to TimeTraceProfiler

russell.gallop created this revision. russell.gallop added a reviewer: anton-afanasyev. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This was hard-coded to "clang". This change allows it to to be used on processes other than clang (such as lld). This gets

[clang] 6713670 - [OpenCL] Fix mangling of single-overload builtins

Author: Sven van Haastregt Date: 2019-12-03T11:09:16Z New Revision: 6713670b17324b81cc457f3a37dbc8c1ee229b88 URL: https://github.com/llvm/llvm-project/commit/6713670b17324b81cc457f3a37dbc8c1ee229b88 DIFF: https://github.com/llvm/llvm-project/commit/6713670b17324b81cc457f3a37dbc8c1ee229b88.diff

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70902/new/ https://reviews.llvm.org/D70902 ___

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG7483eb656fd2: [AArch64][SVE] Implement shift intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70437/new/ https://reviews.

[clang-tools-extra] aa189ed - Fix compatibility with python3 of clang-include-fixer.py

Author: Yannick Brehon Date: 2019-12-03T12:55:13+01:00 New Revision: aa189ed25fbd861b07eb5d5116dfd8e33e2b1991 URL: https://github.com/llvm/llvm-project/commit/aa189ed25fbd861b07eb5d5116dfd8e33e2b1991 DIFF: https://github.com/llvm/llvm-project/commit/aa189ed25fbd861b07eb5d5116dfd8e33e2b1991.diff

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa189ed25fbd: Fix compatibility with python3 of clang-include-fixer.py (authored by Yannick Brehon , committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231866. kadircet marked 5 inline comments as done. kadircet added a comment. - Extract replacement applying part to a new function and add a fixme for sharing it with define inline code-action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

gribozavr2 added inline comments. Comment at: clang/include/clang/Format/Format.h:1651 + /// parameters in a fuction call. + bool ObjCDontBreakBeforeNestedBlockParam; + I don't know much about ClangFormat, but I'd prefer to keep the option name positive ("ObjC

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1651 + /// parameters in a fuction call. + bool ObjCDontBreakBeforeNestedBlockParam; + gribozavr2 wrote: > I don't know much about ClangFormat, but I'd prefer to keep the opti

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: fail - 60408 tests passed, 1 failed and 726 were skipped. failed: Clangd Unit Tests._/ClangdTests/DefineOutlineTest.QualifyReturnValue Log files: console-log.txt

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover updated this revision to Diff 231872. t.p.northover added a comment. Stop inheriting CPU features because they aren't necessarily strictly monotonic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70779/new/ https://reviews.llvm.org/D70779 Files: clang/lib/Driver/ToolCha

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. In D45444#1766156 , @0x8000- wrote: > Thank you for rebasing on current master. > > I have ran it today on our code base and found three classes of false > positives: > > 1. Writing to a bitfield of a struct. The struct stil

[PATCH] D69223: WDocumentation: Implement the \anchor.

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. With that last comment, LGTM. Do you have commit access? Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor: +O

[clang] aedeab7 - [Support] Add ProcName to TimeTraceProfiler

Author: Russell Gallop Date: 2019-12-03T13:04:27Z New Revision: aedeab7f85caaa0946152e5d73e37455267019bb URL: https://github.com/llvm/llvm-project/commit/aedeab7f85caaa0946152e5d73e37455267019bb DIFF: https://github.com/llvm/llvm-project/commit/aedeab7f85caaa0946152e5d73e37455267019bb.diff LOG

[PATCH] D70950: Add ProcName to TimeTraceProfiler

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedeab7f85ca: [Support] Add ProcName to TimeTraceProfiler (authored by russell.gallop). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70950/new/ https://rev

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

aaron.ballman added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. MyDeveloperDay wrote: > klimek wrote: > > Personally, I'm somewhat against having 3 differ

[clang] cc3c935 - Add FunctionDecl::getParameterSourceRange()

Author: Nicolas Manichon Date: 2019-12-03T08:21:55-05:00 New Revision: cc3c935da24c8ebe4fd92638574462b762d92335 URL: https://github.com/llvm/llvm-project/commit/cc3c935da24c8ebe4fd92638574462b762d92335 DIFF: https://github.com/llvm/llvm-project/commit/cc3c935da24c8ebe4fd92638574462b762d92335.di

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman closed this revision. aaron.ballman added a comment. I committed on your behalf in cc3c935da24c8ebe4fd92638574462b762d92335 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. aaron.ballman wrote: > MyDeveloperDay wr

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG8881ac9c3986: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D70253?vs=229341&id=231886#toc Repository:

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, kcc, dvyukov. Herald added subscribers: llvm-commits, dberris. Herald added a project: LLVM. Use a new %run wrapper for ASAN/MSAN/TSAN tests that calls paxctl in order to disable ASLR on the test executables. This makes i

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

dmajor added a comment. Are there any plans to implement `__declspec(guard(nocf))` or an equivalent mechanism? `__attribute__((nocf_check))` doesn't do anything without the -fcf-protection flag. (https://bugs.llvm.org/show_bug.cgi?id=44096) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. I'm also supported, even though the gains are smaller than first thought. It depends on D70568 though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some minor nits. Comment at: clang/lib/Parse/ParseStmt.cpp:1219 + void Check() { + +NeedsChecking = false; Spurious whitespace, but it would be useful to add a newline above the

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske updated this revision to Diff 231905. balazske marked an inline comment as done. balazske added a comment. - rearrangement in evelFreopen, updated comment in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.llv

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske added inline comments. Comment at: clang/test/Analysis/stream.c:160 +} else { + // Open failed, f1 points now to an invalid stream but this condition is currently not checked. + rewind(f1); martong wrote: > This comment is confusing for me

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, but wait for others please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.llvm.org/D69948

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong added a comment. @NoQ Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/ https://reviews.llvm.org/D70439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

alexfh added a comment. There's a problem with this patch. Consider the following code: // In some remote header: #define SOME_RANDOM_MACRO internal // In a completely unrelated file that transitively includes the header: namespace internal { void f(); } // namespace internal It m

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lewis-revill added a comment. So I have a quick comment about this patch, perhaps it might help to get things moving again. I'd like to see the actual frontend changes, IE separate from the header implementations, to be split into a separate patch. So we can have things like the __riscv_bitman

[clang] 980133a - [OpenCL] Use generic addr space for lambda call operator

Author: Anastasia Stulova Date: 2019-12-03T16:07:18Z New Revision: 980133a2098cf6159785b8ac0cbe4d8fbf99bfea URL: https://github.com/llvm/llvm-project/commit/980133a2098cf6159785b8ac0cbe4d8fbf99bfea DIFF: https://github.com/llvm/llvm-project/commit/980133a2098cf6159785b8ac0cbe4d8fbf99bfea.diff

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG980133a2098c: [OpenCL] Use generic addr space for lambda call operator (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D69938?vs=231409&id=23191

[clang] c094e7d - [SYCL] Add sycl_kernel attribute for accelerated code outlining

Author: Mariya Podchishchaeva Date: 2019-12-03T16:13:22+03:00 New Revision: c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd URL: https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd DIFF: https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496a

[PATCH] D70864: update trailing newline treatment in clang-format.py

MyDeveloperDay added a comment. I guess this isn't something we could test with lit right? Can you explain how this goes wrong, I've not seen it myself and I use the vim plugin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

This revision was automatically updated to reflect the committed changes. Closed by commit rGc094e7dc4b3f: [SYCL] Add sycl_kernel attribute for accelerated code outlining (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lewis-revill added inline comments. Comment at: clang/lib/Headers/rv32bintrin-builtins.h:27 +_rv32_clz(const uint_xlen_t rs1) { + // Calling these builtins with 0 results in undefined behaviour. + if (rs1 == 0) { Does GCC perform this check before calling the b

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. Just FYI for now as I'm trying to dig futher... I have been trying this fix in our downstream environment and managed to get a hang with this backtrace: #0 needPadding (BoundarySize=, Size=, StartAddr=) at ./llvm/lib/MC/MCAssembler.cpp:1028 #1 llvm::MCAssembler::r

[clang] c9c714c - Reland [clangd] Rethink how SelectionTree deals with macros and #includes.

Author: Sam McCall Date: 2019-12-03T17:53:43+01:00 New Revision: c9c714c7054d555398c767cb39d7d97600b3d9d1 URL: https://github.com/llvm/llvm-project/commit/c9c714c7054d555398c767cb39d7d97600b3d9d1 DIFF: https://github.com/llvm/llvm-project/commit/c9c714c7054d555398c767cb39d7d97600b3d9d1.diff LO

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. Ping? This would be super useful to have: it avoids copying most of cc1as. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commi

[clang] 26748a3 - [clang-format] Add new option to add spaces around conditions

Author: Mitchell Balan Date: 2019-12-03T12:20:54-05:00 New Revision: 26748a321e20a7aa952ce8daa4f030c384ae7032 URL: https://github.com/llvm/llvm-project/commit/26748a321e20a7aa952ce8daa4f030c384ae7032 DIFF: https://github.com/llvm/llvm-project/commit/26748a321e20a7aa952ce8daa4f030c384ae7032.diff

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG26748a321e20: [clang-format] Add new option to add spaces around conditions Summary: This… (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D68346?vs=225345&id=231930#to

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 231929. yaxunl added a comment. use calling convention to mangle the stub differently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 Files: clang/include/clang/Basic/Specifiers.h clang/lib/AST/ItaniumMa

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:1879 + Create(const ASTContext &C, SourceLocation StartLoc, SourceLocation EndLoc, + ArrayRef Clauses, Stmt *AssociatedStmt, bool HasCancel); + `HasCancel` param? =

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. In D68101#1766670 , @bd1976llvm wrote: > In D68101#1766359 , @rjmccall wrote: > > > I can't speak for the pragma authors, but I strongly doubt the pragma is > > intended to force all affec

[clang] fa6c157 - Differentiate between the presumed and actual file when dumping the AST to JSON

Author: Aaron Ballman Date: 2019-12-03T13:05:59-05:00 New Revision: fa6c157ebeef55fd1e00266d1d1ad6aaa6161ef2 URL: https://github.com/llvm/llvm-project/commit/fa6c157ebeef55fd1e00266d1d1ad6aaa6161ef2 DIFF: https://github.com/llvm/llvm-project/commit/fa6c157ebeef55fd1e00266d1d1ad6aaa6161ef2.diff

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

Eugene.Zelenko added a comment. Please take a look on PR44206. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D70764: build: reduce CMake handling for zlib

JDevlieghere added a comment. Having one canonical variable controlling zlib support seems indeed desirable. In D70519#1754618 , @labath wrote: > With this patch, what is the output of `llvm-config --system-libs` ? @compnerd What's the answer to this fo

[clang] 898df29 - Correcting the offsets within the test to fix the bots.

Author: Aaron Ballman Date: 2019-12-03T13:21:35-05:00 New Revision: 898df29c5b2ebbc4a24143e476d8e9a54569d2e5 URL: https://github.com/llvm/llvm-project/commit/898df29c5b2ebbc4a24143e476d8e9a54569d2e5 DIFF: https://github.com/llvm/llvm-project/commit/898df29c5b2ebbc4a24143e476d8e9a54569d2e5.diff

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd added a comment. In D70764#1767395 , @JDevlieghere wrote: > Having one canonical variable controlling zlib support seems indeed desirable. > > In D70519#1754618 , @labath wrote: > > > With this patch, what

[PATCH] D70779: AArch64: add support for newer Apple CPUs

ab accepted this revision. ab added a comment. (but either way, LGTM) Comment at: llvm/lib/Target/AArch64/AArch64.td:587 +"Apple A10", [ +ProcAppleA7, +FeatureCRC, --

[PATCH] D70779: AArch64: add support for newer Apple CPUs

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:587 +"Apple A10", [ +ProcAppleA7, +FeatureCRC, ab wrote: > t.p.northover wrote: >

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions &getLangOpts() const { +return getASTContext().getLangOpts(); ---

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

nickdesaulniers added a comment. Just some more thoughts after being able to sleep on it. The merge-able sections is generally handy for sections which I'm not specific about (in the added test case, the "implicit" sections). For example, if I have global const data that I don't take the addre

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

kadircet updated this revision to Diff 231947. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments - Change helper to take absolute paths, instead of taking a currentdir - Update tests to make use of FS - Add a new test for container-relative filenames Reposit

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231949. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h clang

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. We're not talking about putting objects in a different section *in the image*. But ELF allows object files to contain an arbitrary number of what I've been calling "section units" that will be assembled into a single section in the image. In theory, we could even emi

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. After some discussion, it was decided to allow not only identifiers as context selectors, but also string literals. Repository: rG LLVM Github Monorepo https

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

merge_guards_bot added a comment. Build result: pass - 60441 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] c375dc2 - Revert "Fix llvm-namespace-comment for macro expansions"

Author: Alexander Kornienko Date: 2019-12-03T20:30:41+01:00 New Revision: c375dc230d16f451cf1c7e2868237da6ef7bc4cf URL: https://github.com/llvm/llvm-project/commit/c375dc230d16f451cf1c7e2868237da6ef7bc4cf DIFF: https://github.com/llvm/llvm-project/commit/c375dc230d16f451cf1c7e2868237da6ef7bc4cf

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60439 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. Just a small side note. If the state was same as the previous we do not end up creating a new ExplodedNode right? Is this also the case when we add a NoteTag? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725

[PATCH] D70974: [clang-tidy] Fix PR26274

alexfh created this revision. alexfh added reviewers: gribozavr, aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. This commit fixes http://llvm.org/PR26274 in a simpler and more correct way than 4736d63f752f8d13f4c6a9afd558565c32119718

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun updated this revision to Diff 231955. xazax.hun added a comment. - Use the new notes API for path notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h clang

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:362 } - C.addTransition(State); + const NoteTag *T = C.getNoteTag([this, notes](BugReport &BR) -> std::string { +if (&BR.ge

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. You were right, the new API looks cleaner even in this case :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1761514 , @awpandey wrote: > Hi @aprantl and @dblaikie. Currently, there is no test case for the > unspecified type, so I have added that in the regression test suite. It looks to me like there are a few tests for un

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. Many of the test cases could be collapsed into one file - using different variables that are used, unused, locally or globally declared, etc. Is this new code only active for C compilations? (does clang reject requests for the bpf target when the input is C++?) I ask d

[PATCH] D70974: [clang-tidy] Fix PR26274

merge_guards_bot added a comment. Build result: pass - 60438 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @rnk up? the mozilla folks confirmed there's no significant regression (see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk marked an inline comment as done. vsk added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:330 +last case ends). This gap region has a zero count: this causes "gap" areas in +between case statements, which contain no executable code, to appear uncovered.

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Still looking for someone to take a look. Happy to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-c

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

Charusso added a comment. In D70725#1767579 , @xazax.hun wrote: > Just a small side note. If the state was same as the previous we do not end > up creating a new ExplodedNode right? Is this also the case when we add a > NoteTag? It only happens for eva

[clang] bc840b2 - [Diagnostic] add a warning which warns about misleading indentation

Author: Tyker Date: 2019-12-03T21:21:27+01:00 New Revision: bc840b21e1612adb603b6c17be0329e3737bb943 URL: https://github.com/llvm/llvm-project/commit/bc840b21e1612adb603b6c17be0329e3737bb943 DIFF: https://github.com/llvm/llvm-project/commit/bc840b21e1612adb603b6c17be0329e3737bb943.diff LOG: [D

[clang] 2f96047 - [NFCI] update formating for misleading indentation warning

Author: Tyker Date: 2019-12-03T21:21:27+01:00 New Revision: 2f9604727526dedcd20b776ace4adfc058641ab2 URL: https://github.com/llvm/llvm-project/commit/2f9604727526dedcd20b776ace4adfc058641ab2 DIFF: https://github.com/llvm/llvm-project/commit/2f9604727526dedcd20b776ace4adfc058641ab2.diff LOG: [N

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2933 +OMPPrivateScope PrivateScope(CGF); +bool Copyins = CGF.EmitOMPCopyinClause(S); +(void)CGF.EmitOMPFirstprivateClause(S, PrivateScope);

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc840b21e161: [Diagnostic] add a warning which warns about misleading indentation (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/ne

[PATCH] D70861: [NFCI] update formating for misleading indentation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9604727526: [NFCI] update formating for misleading indentation warning (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] bf830b0 - Switch to opening the temp file in binary mode

Author: Aaron Ballman Date: 2019-12-03T15:31:46-05:00 New Revision: bf830b01a21e6ff2f44c17be4ad4ee897465a677 URL: https://github.com/llvm/llvm-project/commit/bf830b01a21e6ff2f44c17be4ad4ee897465a677 DIFF: https://github.com/llvm/llvm-project/commit/bf830b01a21e6ff2f44c17be4ad4ee897465a677.diff

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

NoQ added a comment. Yay, it actually works! I only have minor comments and ignorable hand-waving now. In D70725#1767643 , @Charusso wrote: > In D70725#1767579 , @xazax.hun wrote: > > > Just a small side note. If

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/test/OpenMP/nesting_of_regions.cpp:3024 + { +#pragma omp master // OK, though second 'master' is redundant +{ ABataev wrote: > Is this allowed by the standard? I didn't se

[clang] 859bf4d - [Coverage] Emit a gap region to cover switch bodies

Author: Vedant Kumar Date: 2019-12-03T12:35:54-08:00 New Revision: 859bf4d2bea2404bd2eac92451f2db4371ec6eb4 URL: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4 DIFF: https://github.com/llvm/llvm-project/commit/859bf4d2bea2404bd2eac92451f2db4371ec6eb4.diff

Re: Github build status reporting

Hi Galina, Thanks for doing this! I'm curious as to how the buildbot CI communicates with Github, is the buildbot itself capable of performing the Github API requests, or do you have an external tool/script that does that? Thanks, Alex On Mon, 25 Nov 2019 at 12:59, Galina Kistanova via cfe-commi

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rG859bf4d2bea2: [Coverage] Emit a gap region to cover switch bodies (authored by vsk). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D70571?vs=231724&id=231964#toc Repo

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 231966. yaxunl added a comment. Herald added subscribers: nhaehnle, jvesely. clean up and fix assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 Files: clang/include/clang/Basic/Specifiers.h clan

  1   2   >