[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.llvm.org/D69948 ___ cfe-commits mailing

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, aaron.ballman, gribozavr. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: mgehre, Szelethus, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a project: clang. Finds cases

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232079. usaxena95 added a comment. Explicitly turn off CollectMacro in test. #Updatin D70489 : [clangd] Add xref for macro to static index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232078. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files:

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

hans added a subscriber: tstellar. hans added a comment. In D67463#1767919 , @rnk wrote: > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > release candidate. +Tom: ^ Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] cb9be3f - [clangd] Remove the hanging lit exit-signal.test.

Author: Haojian Wu Date: 2019-12-04T12:35:16+01:00 New Revision: cb9be3fa551ba1974c1a38a3f12da4e399adb85c URL: https://github.com/llvm/llvm-project/commit/cb9be3fa551ba1974c1a38a3f12da4e399adb85c DIFF: https://github.com/llvm/llvm-project/commit/cb9be3fa551ba1974c1a38a3f12da4e399adb85c.diff

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. fbmem.c case reduced: https://godbolt.org/z/ma4aFA Looks like kernel uses tabs here So we have BinaryOperator If we use spaces: BinaryOperator 'int' '=' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added inline comments. Comment at: clang/test/Parser/warn-misleading-indentation.cpp:209 +} \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Many thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70740/new/ https://reviews.llvm.org/D70740

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. so now I think this is better because it's encased inside your TT_ObjCMethodExpr method which means it should only impact ObjectiveC Nit on the documentation Nit missing parse tests but otherwise you are pretty close, make those changes and I'll mark accepted

[PATCH] D70864: update trailing newline treatment in clang-format.py

pseyfert added a comment. As a demonstrator I put this docker image together: docker run -it --rm gitlab-registry.cern.ch/pseyfert/vim-clang-format-docker:latest open `vim Chi2PerDoF.h` and hit Ctrl+I. There is a

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

kmclaughlin updated this revision to Diff 232072. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. - Removed AArch64 specific ISDNodes for MLOAD & MSTORE CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71000/new/ https://reviews.llvm.org/D71000 Files:

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

thakis added a comment. ApplyTest fails on Windows; probably the usual delayed template parsing thing: http://45.33.8.238/win/3368/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298

[clang-tools-extra] ba71e84 - [clangd] Add no delayed templates to outline tests

Author: Kadir Cetinkaya Date: 2019-12-04T12:19:47+01:00 New Revision: ba71e84430f98639957f002bf424aef5248832c7 URL: https://github.com/llvm/llvm-project/commit/ba71e84430f98639957f002bf424aef5248832c7 DIFF:

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: lib/Format/Format.cpp:455 +IO.mapOptional("BitFieldDeclarationsOnePerLine", Style.BitFieldDeclarationsOnePerLine);

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. As a consensus how about I drop Before/After and Keep Left/Right and West/East const support? (as no one is asking for Before/After?) can we handle having 2 options to aid language issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, paulwalker-arm, dancgr, mgudim, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following intrinsics: -

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:158 +case X86::AND16i16: +case X86::AND16mr: +case X86::AND16ri: craig.topper wrote: > None of the AND/ADD/SUB instructions

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added a comment. Can you please put the macro fusion changes in a separate phabricator review. I’ll review it in the morning US time and if it all looks good we can get that part committed while the other comments are being addressed. CHANGES SINCE LAST ACTION

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1768389 , @craig.topper wrote: > Can you please put the macro fusion changes in a separate phabricator review. > I’ll review it in the morning US time and if it all looks good we can get > that part committed while the

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

dmgreen added a comment. Looks good to me, with a couple of minor nitpicks (that I'm not sure matter or not). Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3626 -class MVE_VxMULH size, +class MVE_VxMULH size, bit U, bit round, list pattern=[]>

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

hans marked 2 inline comments as done. hans added a comment. Thanks for the review! Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2232 + if (ParsingClassDepth == 0) +ActOnFinishCXXNonNestedClass(Instantiation); rnk wrote: > This function

[clang] e6522a9 - [OpenCL] Allow addr space qualifiers on lambda call expressions

Author: Anastasia Stulova Date: 2019-12-04T12:25:20Z New Revision: e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6 URL: https://github.com/llvm/llvm-project/commit/e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6 DIFF: https://github.com/llvm/llvm-project/commit/e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6.diff

[PATCH] D70041: register cuda language activation event and activate for .cuh files

This revision was automatically updated to reflect the committed changes. Closed by commit rG689c11486396: [clangd] register cuda language activation event and activate for .cuh files (authored by ptaylor, committed by hokein). Changed prior to commit:

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein updated this revision to Diff 232101. hokein marked 3 inline comments as done. hokein added a comment. address comments - re-define the concept of a near miss - add metric for evaluate how good a near miss is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

merge_guards_bot added a comment. Build result: pass - 60453 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

sammccall added a comment. In D69764#1768420 , @MyDeveloperDay wrote: > As a consensus how about I drop Before/After and Keep Left/Right and > West/East const support? (as no one is asking for Before/After?) can we > handle having 2 options to aid

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.h:95 + /// \p getBest, exposing for testing only. + static MatchType match(llvm::ArrayRef LHS, llvm::ArrayRef RHS); + sammccall wrote: > Oops, forgot this... > I think the

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea updated this revision to Diff 232100. aganea marked an inline comment as done. aganea added subscribers: tstellar, Meinersbur. aganea added a comment. Just after I hit Submit last night, I found a better way, by disabling ACL for that folder. Ping @tstellar @Meinersbur in case they have

[clang] 45ef055 - [clang][Tooling] Add support for .rsp files in compile_commands.json

Author: Kadir Cetinkaya Date: 2019-12-04T15:13:12+01:00 New Revision: 45ef055d4ffda4d2b04b62f73e36cc6d5252758b URL: https://github.com/llvm/llvm-project/commit/45ef055d4ffda4d2b04b62f73e36cc6d5252758b DIFF:

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232126. usaxena95 added a comment. Removed unintended space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files:

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev marked 2 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:472 } - if (Opts.CollectMacro) { -assert(PP); hokein wrote: > hokein wrote: > > this code should not be modified, since we don't use the `CollectMacro` > >

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

This revision was automatically updated to reflect the committed changes. hans marked an inline comment as done. Closed by commit rG92ce2aff680e: Actually delay processing DelayedDllExportClasses until the outermost class is… (authored by hans). Herald added a project: clang. Changed prior to

[clang] 92ce2af - Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

Author: Hans Wennborg Date: 2019-12-04T13:13:41+01:00 New Revision: 92ce2aff680e31a726c17267e36ff13a1ef31696 URL: https://github.com/llvm/llvm-project/commit/92ce2aff680e31a726c17267e36ff13a1ef31696 DIFF: https://github.com/llvm/llvm-project/commit/92ce2aff680e31a726c17267e36ff13a1ef31696.diff

[clang-tools-extra] 82f6ae5 - [clang-change-namespace] Change file pattern to be an anchored regex

Author: Kadir Cetinkaya Date: 2019-12-04T15:48:44+01:00 New Revision: 82f6ae5433cac1ba0d02e8df253da3d3b3ce68e1 URL: https://github.com/llvm/llvm-project/commit/82f6ae5433cac1ba0d02e8df253da3d3b3ce68e1 DIFF:

[clang] 0f12f90 - Revert "[llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles"

Author: Kadir Cetinkaya Date: 2019-12-04T15:58:01+01:00 New Revision: 0f12f9096e1e33d88cb0b5601b0e035a2674c19a URL: https://github.com/llvm/llvm-project/commit/0f12f9096e1e33d88cb0b5601b0e035a2674c19a DIFF:

[clang-tools-extra] 689c114 - [clangd] register cuda language activation event and activate for .cuh files

Author: ptaylor Date: 2019-12-04T15:06:21+01:00 New Revision: 689c11486396dbf7815caff3671bdcb1303e5143 URL: https://github.com/llvm/llvm-project/commit/689c11486396dbf7815caff3671bdcb1303e5143 DIFF: https://github.com/llvm/llvm-project/commit/689c11486396dbf7815caff3671bdcb1303e5143.diff LOG:

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.h:95 + /// \p getBest, exposing for testing only. + static MatchType match(llvm::ArrayRef LHS, llvm::ArrayRef RHS); + hokein wrote: > sammccall wrote: > > Oops, forgot

[clang] fa9dd41 - [opencl] Fix address space deduction on array variables.

Author: Michael Liao Date: 2019-12-04T09:37:50-05:00 New Revision: fa9dd410a9a9aa65ce6731cbe1ee12c5941eb3e8 URL: https://github.com/llvm/llvm-project/commit/fa9dd410a9a9aa65ce6731cbe1ee12c5941eb3e8 DIFF: https://github.com/llvm/llvm-project/commit/fa9dd410a9a9aa65ce6731cbe1ee12c5941eb3e8.diff

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:1875 + /// \param AssociatedStmt Statement, associated with the directive. + /// \param HasCancel true if current directive has inner cancel directive. + /// No such param.

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D71015: [OpenCL] Handle address space conversions for constexpr (PR44177)

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: ebevhan, yaxunl. Herald added a project: clang. The AST for the `constexpr.cl` test contains address space conversion nodes to cast through the implicit generic address space. These caused the evaluator

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 232088. arsenm added a comment. Rename functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader created this revision. bader added reviewers: aaron.ballman, Anastasia. Herald added subscribers: cfe-commits, ebevhan, yaxunl. Herald added a project: clang. Enable a way to set OpenCL language address space using attributes in addition to existing keywords. Signed-off-by: Victor Lomuller

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, jfb, yaxunl, mgorny. Herald added a project: clang. Fznamznon added reviewers: bader, Naghasan, ABataev. All SYCL memory objects shared between host and device (buffers/images, these objects map to OpenCL

[clang] b3b3778 - Reapply "[llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles"

Author: Kadir Cetinkaya Date: 2019-12-04T17:00:47+01:00 New Revision: b3b37783034cab31db2d60cf79d0c1c82a8c3419 URL: https://github.com/llvm/llvm-project/commit/b3b37783034cab31db2d60cf79d0c1c82a8c3419 DIFF:

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM marked 3 inline comments as done. MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3644 +multiclass MVE_VxMULH_m { dmgreen wrote: > Formatting. I took a guess as to what you wanted here. Repository: rG LLVM

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM updated this revision to Diff 232093. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/ https://reviews.llvm.org/D70948 Files: clang/include/clang/Basic/arm_mve.td

[clang] d3f62ce - [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

Author: Mark Murray Date: 2019-12-04T14:27:12Z New Revision: d3f62ceac0ce5d35f888c5a2de9c4a41780c8040 URL: https://github.com/llvm/llvm-project/commit/d3f62ceac0ce5d35f888c5a2de9c4a41780c8040 DIFF: https://github.com/llvm/llvm-project/commit/d3f62ceac0ce5d35f888c5a2de9c4a41780c8040.diff LOG:

[PATCH] D70489: [clangd] Add xref for macro to static index.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:472 } - if (Opts.CollectMacro) { -assert(PP); hokein wrote: > this code should not be modified, since we don't use the `CollectMacro` > option. this comment

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG75656005dbc8: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ee277b86b34: [Support] add vfs support for ExpandResponseFiles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

aaron.ballman added a comment. If there's strong sentiment to only go with East/West, I'll not block the feature to argue about the names further. That said, I still think East/West is a kitschy phrasing and I've seen multiple people get temporarily confused by it (while wearing the bracelets,

[PATCH] D70981: [opencl] Fix address space deduction on array variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9dd410a9a9: [opencl] Fix address space deduction on array variables. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D70981?vs=231970=232123#toc Repository: rG LLVM Github

[PATCH] D70974: [clang-tidy] Fix PR26274

aaron.ballman added a comment. In D70974#1768871 , @gribozavr2 wrote: > I'm not convinced this feature is worth implementing at all, because there's > a good alternative to a macro here -- a namespace alias. What is the reason > to use a macro instead

[PATCH] D70489: [clangd] Add xref for macro to static index.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good with a few nits. I think the benchmark data doesn't correct any more with the latest patch, we don't increase number of symbols. Comment at:

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D71001#1768963 , @baloghadamsoftware wrote: > In D71001#1768880 , @gribozavr2 > wrote: > > > Is this a common problem? There's a lot of silly code we could try to find, > > but if

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. > ASan can help debug this issue, and more. This is dynamic analysis, and detection of problem depends on test case. Detection of such problem during static analysis makes sense. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. In D71001#1768964 , @baloghadamsoftware wrote: > In D71001#1768704 , @Eugene.Zelenko > wrote: > > > What about new operator? May be check should have option for custom > >

[PATCH] D70242: [OpenCL] Allow addr space qualifiers on lambda call expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6522a96f56c: [OpenCL] Allow addr space qualifiers on lambda call expressions (authored by Anastasia). Herald added a project: clang. Changed prior to commit:

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3645 +Intrinsic pred_int, bit round> { + def "" : MVE_VxMULH; + Should this be `VTI.Suffix, VTI.Unsigned, VTI.Size, round` now? Repository: rG LLVM Github

[PATCH] D70974: [clang-tidy] Fix PR26274

gribozavr2 added a reviewer: gribozavr2. gribozavr2 added a comment. I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias? Repository: rG LLVM

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

thakis added a comment. Test fails on Windows: http://45.33.8.238/win/3379/step_10.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70857/new/ https://reviews.llvm.org/D70857 ___ cfe-commits mailing

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232125. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files:

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"private">, Clang<"ocl_private">];

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

merge_guards_bot added a comment. Build result: pass - 60453 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM updated this revision to Diff 232094. MarkMurrayARM marked an inline comment as done. MarkMurrayARM added a comment. Fix incorrect argument order error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. What about new operator? May be check should have option for custom allocators? Comment at: clang-tools-extra/docs/ReleaseNotes.rst:207 +- New :doc:`bugprone-misplaced-pointer-arithmetic-in-alloc + ` check. Please move to new

[PATCH] D69878: Consoldiate internal denormal flushing controls

scanon added inline comments. Comment at: llvm/docs/LangRef.rst:1834 +``"denormal-fp-math-f32"`` + Same as ``"denorm-fp-math-f32"``, except for float types. If both + are present, this overrides ``"denorm-fp-math"``. Can you clarify this a little bit? I'd

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske updated this revision to Diff 232097. balazske added a comment. Rebased to monorepo and newer master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader updated this revision to Diff 232098. bader added a comment. Change attribute prefix: `ocl_` -> `opencl_`. Updated OpenCL spelling in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71005/new/ https://reviews.llvm.org/D71005

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">,

[PATCH] D70981: [opencl] Fix address space deduction on array variables.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address the comment in your final commit. Comment at: clang/lib/Sema/SemaDecl.cpp:6136 + if (!OrigTy.getQualifiers().hasAddressSpace() &&

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/ https://reviews.llvm.org/D70948

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

hans created this revision. hans added a reviewer: rnk. See bug. https://reviews.llvm.org/D71012 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c Index: clang/test/Driver/clang_f_opts.c === ---

[PATCH] D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ef055d4ffd: [clang][Tooling] Add support for .rsp files in compile_commands.json (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60453 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. Is this a common problem? There's a lot of silly code we could try to find, but if people don't actually write it, then we get all downsides of maintenance without the benefits of the checker. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D70948: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3f62ceac0ce: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70948/new/

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware added a comment. In D71001#1768880 , @gribozavr2 wrote: > Is this a common problem? There's a lot of silly code we could try to find, > but if people don't actually write it, then we get all downsides of > maintenance without the

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware added a comment. In D71001#1768704 , @Eugene.Zelenko wrote: > What about new operator? May be check should have option for custom > allocators? Do you mean `new[]`. Thus e.g. `const *carr = new C[n] + 10;` instead of `const *carr =

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. In D69825#1768111 , @arphaman wrote: > @aganea Please disable the new behavior for the Darwin platform. We rely on > the fact that Clang `-cc1` processes crash to report crashes using system's > crash reporting infrastructure.

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware added a comment. In D71001#1769018 , @gribozavr2 wrote: > This check is quite limited. For example, if the addition is done in a > separate statement, this check wouldn't catch the problem. ASan would. That is not a simple and common

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong created this revision. martong added reviewers: balazske, a_sidorin. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, jfb, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong added a parent

[PATCH] D70974: [clang-tidy] Fix PR26274

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. In D70974#1768902 , @aaron.ballman wrote: > In D70974#1768871 , @gribozavr2 > wrote: > > > I'm not

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D71001#1769035 , @Eugene.Zelenko wrote: > > ASan can help debug this issue, and more. > > This is dynamic analysis, and detection of problem depends on test case. > Detection of such problem during static analysis makes

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. @ABataev, thanks for your time and patient for the review! Could you land this patch for me when you have free time? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70974: [clang-tidy] Fix PR26274

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:54 + const LangOptions ) { + // Loc should be at the begin of the namespace decl (usually, `namespace` +

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

gribozavr2 added a comment. In D69855#1769318 , @twardakm wrote: > @alexfh, @gribozavr2, @aaron.ballman I think the best way out here is just to > implement the basic fix for the above problem and only allow to use macro > definition in closing comment

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM A little advice as you fix each comment check the "Done" button. I notice you are a new user, will you need help landing it? Repository: rG LLVM Github Monorepo

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

tstellar added a comment. In D67463#1767919 , @rnk wrote: > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > release candidate. I'm still accepting patches until rc2 (which should have been Monday, but was delayed), so I

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson created this revision. arichardson added reviewers: EricWF, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using the same approach as d0782a69ff4c04dc4f1dc1c11cb2fb43c6b638f5 and 91cef98d2c41eff0dea474a760d2dce5ba873209. Repository: rG LLVM Github

[clang] cdbed2d - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Melanie Blower Date: 2019-12-04T11:32:33-08:00 New Revision: cdbed2dd856c14687efd741c2d8321686102acb8 URL: https://github.com/llvm/llvm-project/commit/cdbed2dd856c14687efd741c2d8321686102acb8 DIFF:

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

jkorous added a comment. The use of `xcrun` looks sound to me. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) { The `trim()` is probably safe - just wondering if that

[PATCH] D70987: [AMDGPU][HIP] Improve opt-level handling

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/HIP.cpp:153 + // Pass optimization arg to llc. + addOptLevelArgs(Args, LlcArgs, true); +

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong created this revision. martong added reviewers: balazske, a_sidorin. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. In the past we had to use

  1   2   3   >