[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + EricWF wrote: > rogeeff wrote: > > aaron.ballman

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. Thanks for pinging on this @thegameg. I had been looking at this a day or two ago but got side-tracked. Will take another look. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. This appears to only happen with -fintegrated-cc1, with fno-integrated-cc1 it does not repro. Still looking into this. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. No, I don't have commit privileges. I'd appreciate if you'd commit this for me. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

ykfre added a comment. In D72910#1826293 , @dim wrote: > Aha, which version of clang-cl are you using? With the released version of > clang-cl 9.0.1, I get a warning instead of an error: > > cleanup.cpp(15,5): warning: jump from this goto statement to

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith updated this revision to Diff 238881. rsmith added a comment. - Explicitly put implicit virtual functions in the right order, rather Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 Files:

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith added a comment. In D72897#1825791 , @rjmccall wrote: > I know that Sema used to have a lot of issues with implicitly declaring > special members, but I also know that that was bound up with how we tracked > special state for the class, and that

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242 +--+--+--+---+ -|

[clang] 383ff4e - [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

Author: Sergej Jaskiewicz Date: 2020-01-18T01:29:09+03:00 New Revision: 383ff4eac1db8313ec522ba3ac0903aaeda7ff63 URL: https://github.com/llvm/llvm-project/commit/383ff4eac1db8313ec522ba3ac0903aaeda7ff63 DIFF:

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

denik added a comment. We are hitting the warning in template code with bool and loop like this: "for (const auto& element : value)" where element is bool from template. But not always. When it is bool the warning triggers: error: loop variable 'element' is always a copy because the range of

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. Tank you for splitting the patch. For CMake parts @beanz would be the person to make the call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 ___ cfe-commits mailing list

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 238858. fghanim added a comment. Addressing reviewer's comments regarding styling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 Files:

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238893. tstellar added a comment. - Fix indentation. - Remove placeholder AttributeReference.rst. The install target was replacing the generated AttributeReference.rst with this which caused the html page to be empty. - Tested with stand-alone clang

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238914. tstellar marked 2 inline comments as done. tstellar added a comment. - Add quotes around ${CMAKE_CURRENT_SOURCE_DIR} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. The weird template test case might is derived from an old failure that I believe was addressed in Clang, but regression tests are fine by me. The macro expansion fix is correct and

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thegameg added a comment. Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dragon: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6886/consoleFull The following tests are failing: Clang :: InterfaceStubs/driver-test.c Clang ::

[clang] 90bdb03 - Update clang test.

Author: Alina Sbirlea Date: 2020-01-17T11:08:59-08:00 New Revision: 90bdb037276be43df260af004f620b21645d2617 URL: https://github.com/llvm/llvm-project/commit/90bdb037276be43df260af004f620b21645d2617 DIFF: https://github.com/llvm/llvm-project/commit/90bdb037276be43df260af004f620b21645d2617.diff

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt -wholeprogramdevirt-summary-action=import

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

ykfre created this revision. ykfre added a reviewer: clang-tools-extra. ykfre added a project: clang-tools-extra. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. add ConfigurationsFilesToImport option - to make it possible to import another configurations files

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ff4eac1db: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake… (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. It wouldn't be a bad idea to track that correspondence in the AST just on the general principle that it's useful information (for diagnostics, tooling, etc.) that's otherwise hard to

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61674 tests passed, 181 failed and 781 were skipped. failed: Clangd.Clangd/background-index.test failed: Clangd.Clangd/code-action-request.test failed: Clangd.Clangd/compile-commands-path-in-initialize.test

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. I don't know if there were other reviewers who haven't commented on how you addressed their concerns, but this looks good to me. Thanks for taking the time to improve our

[PATCH] D71732: Move the sysroot attribute from DIModule to DICompileUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b30370e5bcf: Move the sysroot attribute from DIModule to DICompileUnit (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed prior to

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

ianlevesque updated this revision to Diff 238866. ianlevesque added a comment. Add x86 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72890/new/ https://reviews.llvm.org/D72890 Files: clang/include/clang/Basic/XRayInstr.h

[PATCH] D69740: [profile] Support counter relocation at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db13af7e5c: [profile] Support counter relocation at runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D69740?vs=238689=238901#toc Repository: rG LLVM Github Monorepo

[clang] d3db13a - [profile] Support counter relocation at runtime

Author: Petr Hosek Date: 2020-01-17T15:02:23-08:00 New Revision: d3db13af7e5c01632fbf28149a2d4f9c4841aeba URL: https://github.com/llvm/llvm-project/commit/d3db13af7e5c01632fbf28149a2d4f9c4841aeba DIFF: https://github.com/llvm/llvm-project/commit/d3db13af7e5c01632fbf28149a2d4f9c4841aeba.diff

[clang] c33ba8c - [OPENMP]Improve debug locations in OpenMP regions.

Author: Alexey Bataev Date: 2020-01-17T14:24:32-05:00 New Revision: c33ba8c15858c0316378caf2667c8feee32dad36 URL: https://github.com/llvm/llvm-project/commit/c33ba8c15858c0316378caf2667c8feee32dad36 DIFF: https://github.com/llvm/llvm-project/commit/c33ba8c15858c0316378caf2667c8feee32dad36.diff

[clang] 1d62be2 - [clang][xray] Add -fxray-ignore-loops option

Author: Ian Levesque Date: 2020-01-17T13:32:24-08:00 New Revision: 1d62be244108547558c6d42ddcf2e4a7f3c6dd03 URL: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03 DIFF: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03.diff

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

rjmccall added a comment. Remember that the design is that constrained intrinsics must be used whenever *any* code in the function is constrained. It is not unreasonable that part of the function might be constrained and the rest subject to fast-math; it'd be a shame if the intrinsics

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > andrew.w.kaylor wrote: > > cameron.mcinally wrote: > > > cameron.mcinally wrote: > > > > cameron.mcinally wrote: > > > > > I don't

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

delcypher added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33 + if (NOT ARG_SOURCE_DIR) +set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + endif() @tstellar I'm not 100% sure about this but I think you probably want

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 238902. kbobyrev added a comment. I started using TokenBuffer, but I ran into the following issue: when I'm creating `TokenBuffer` and `TokenCollector`, they do not contain any tokens. `Preprocessor` does not seem to have a non-null Lexer instance,

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 238868. serge-sans-paille added a comment. Update size computation + test case involving null byte inside the format string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61975 tests passed, 1 failed and 783 were skipped. failed: LLVM.Bindings/Go/go.test {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240 ++--+--+--+---+ +| misc

[clang] a42fd84 - Remove redundant CXXScopeSpec from TemplateIdAnnotation.

Author: Richard Smith Date: 2020-01-17T15:47:21-08:00 New Revision: a42fd84cff265b7e9faa3fe42885ee171393e4db URL: https://github.com/llvm/llvm-project/commit/a42fd84cff265b7e9faa3fe42885ee171393e4db DIFF: https://github.com/llvm/llvm-project/commit/a42fd84cff265b7e9faa3fe42885ee171393e4db.diff

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I've left some comments suggesting how to rebase this on rGa42fd84cff265b7e9faa3fe42885ee171393e4db ; otherwise, some

[PATCH] D70183: Detect source location overflow due includes

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but since we both work at Arm, let's wait a week for other folks to chime in if they have any objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

MaskRay added a comment. Herald added a subscriber: dexonsmith. I think we should not rely too much on the driver emitting object files. There can be many subtle differences (D68897 ). When the -emit-obj output is feed to llvm-nm, the clang cc1 command line

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -|

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d62be244108: [clang][xray] Add -fxray-ignore-loops option (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba483026cd: [xray] Allow instrumenting only function entry and/or only function exit (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally accepted this revision. cameron.mcinally added a comment. LGTM too. Would be good if an expert reviewed the target-specific changes, but they seem safe enough either way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + andrew.w.kaylor wrote: > cameron.mcinally wrote: > > cameron.mcinally wrote: > > > cameron.mcinally wrote: > > > > I don't think it's safe to fuse a FMUL

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

rnk added a comment. `ArmMveAliasValid` is the second slowest function to compile in all of clang, according to ClangBuildAnalyzer: https://reviews.llvm.org/P8185 We shouldn't spend 28 CPU seconds per rebuild on a switch. Please do something to speed it up. Generally, it is best to emit tables

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

xazax.hun added subscribers: phosek, NoQ, haowei, xazax.hun. xazax.hun added a comment. Hi! This patch breaks scan-build-py which parses the output of "-###" to get -cc1 command. There might be other tools with the same problems. Could we either remove `(in-process)` from `CC1Command::Print`

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238933. wristow added a comment. Updated patch to correct a comment and fix a typo. Regarding the point from @spatel : > This follows the reasoning from the earlier discussion, but after re-reading > the gcc comment in particular, I'm wondering whether

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte added a comment. If @yaxunl has no objections, could someone merge this as I don't have commit access? Also do we want to also apply this to older versions, since the change is trivial? I confirmed the same problem is in clang 8, 9 and 10 and am certain it is in clang 7,

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

JDevlieghere added a comment. Please upload the diff with full context . This would also need a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72940/new/ https://reviews.llvm.org/D72940

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72970/new/ https://reviews.llvm.org/D72970 ___ cfe-commits mailing list

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm closed this revision. arsenm added a comment. a4451d88ee456304c26d552749aea6a7f5154bde CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878

Buildbot numbers for the week of 01/05/2020 - 01/11/2020

Hello everyone, Below are some buildbot numbers for the last week of 01/05/2020 - 01/11/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. For now, this ABI simply expands all possible aggregate arguments and returns all possible aggregates directly. This

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte abandoned this revision. DieGoldeneEnte added a comment. Adding the paths for llvm/lld is not needed, because GetProgramPath is actually also searching in $PATH. This means D72903 already is enough to fix my problem. CHANGES SINCE LAST ACTION

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61974 tests passed, 2 failed and 783 were skipped. failed: LLVM.Bindings/Go/go.test failed:

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

dexonsmith created this revision. dexonsmith added reviewers: rjmccall, arphaman. Herald added a subscriber: ributzka. Since 2009 (in r63846) we've been `#define`-ing OBJC_NEW_PROPERTIES all the time on Darwin, but this macro only makes sense for `-x objective-c` and `-x objective-c++`. Restrict

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries

annita.zhang added a comment. In D72463#1826821 , @MaskRay wrote: > In D72463#1826499 , @annita.zhang > wrote: > > > @MaskRay Did you merge it to LLVM 10 branch? > > > It is included in the release branch. > >

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte created this revision. DieGoldeneEnte added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces the manual building of executable paths using llvm::sys::path::append with GetProgramPath. This enables adding other

Re: [clang] 4456076 - Revert "Further implement CWG 2292"

(Note to self: I double checked that the "Further implement CWG 2292" patch landed just after the 10.x branch, so this revert doesn't need to be cherry-picked there.) On Thu, Jan 16, 2020 at 12:46 AM Amy Huang via cfe-commits wrote: > > > Author: Amy Huang > Date: 2020-01-15T15:46:07-08:00 > New

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should: cleanup.cpp:15:5: error: cannot jump from this goto statement to its label goto clean_up; ^ cleanup.cpp:20:7: note: jump bypasses

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

This revision was automatically updated to reflect the committed changes. kmclaughlin marked an inline comment as done. Closed by commit rGfe3bb8ec9683: [AArch64][SVE] Add ImmArg property to intrinsics with immediates (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -|

[clang] d293417 - Add __warn_memset_zero_len builtin as a workaround for glibc issue

Author: serge-sans-paille Date: 2020-01-17T09:58:32+01:00 New Revision: d293417931d3a9d46799b42795988ca3b5cfd766 URL: https://github.com/llvm/llvm-project/commit/d293417931d3a9d46799b42795988ca3b5cfd766 DIFF:

[PATCH] D72848: Remove some SVN-specific code.

hans added inline comments. Comment at: clang/lib/Basic/Version.cpp:33 #else - StringRef URL(""); + return ""; #endif Eugene.Zelenko wrote: > return {} should be better. Why? I think "" is clearer for a string. Repository: rG LLVM Github Monorepo

[PATCH] D72907: clang-format: [JS] pragmas for tslint, tsc.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst added a project: clang. tslint and tsc (the TypeScript compiler itself) use comment pragmas of the style: // tslint:disable-next-line:foo // @ts-ignore These must not be wrapped and must stay on their own line, in

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. Hmm, maybe they should then? The only reason I didn't add them initially was that I wasn't sure they were useful for anything; if they are, it should be straightforward to add them back.

Re: [clang] b72a8c6 - PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

cherry-picked in 7a8b8f09daa and fdb501e59f2 Maybe we should expand the release note since this can be a compatibility problem for some? For example it affected Chromium as it broke something in Skia: https://bugs.chromium.org/p/chromium/issues/detail?id=1042470 On Wed, Jan 15, 2020 at 10:18 PM

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGd293417931d3: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d437fba - Reapply Allow system header to provide their own implementation of some builtin

Author: serge-sans-paille Date: 2020-01-17T09:58:32+01:00 New Revision: d437fba8ef626b6d8b7928540f630163a9b04021 URL: https://github.com/llvm/llvm-project/commit/d437fba8ef626b6d8b7928540f630163a9b04021 DIFF:

Re: [clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Cherry-picked in 0a08d2c4e7830a1b2428c2c77f205ac74fa29899 and 2d2d057ae23036baecb5a2a4a7f929626f46921a. Thanks! On Fri, Jan 17, 2020 at 3:14 AM Richard Smith wrote: > > Also b78e8e0d79c47a6698a0abc10a37b8a253cb6064 which has an extra test file > that I forgot to git add. > > On Wed, 15 Jan 2020

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238708. DieGoldeneEnte added a comment. This patch now only adds the executable dirs to the program path, the code to search them is now in D72903 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

mprobst added a comment. I've added tests and a fix for try/catch and if/else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72827/new/ https://reviews.llvm.org/D72827 ___ cfe-commits mailing list

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

mprobst added a comment. In D72827#1823895 , @krasimir wrote: > How about `if` and `try`? Is there a list somewhere for all such valid > identifiers? This is a bit annoying - generally speaking, we should parse all keywords in declaration locations as

Re: [clang] 6b29aa2 - Revert "[OPENMP]Do not use RTTI by default for NVPTX devices."

Cherry-picked to 10.x in 572c7f6fe7b55ce5f7591fb7a445dea27329074a. On Wed, Jan 15, 2020 at 11:42 PM Alexey Bataev via cfe-commits wrote: > > > Author: Alexey Bataev > Date: 2020-01-15T17:42:26-05:00 > New Revision: 6b29aa21180cf14bfb619d38fc4826913cabfb66 > > URL: >

Re: [clang] 3d210ed - Revert "Allow system header to provide their own implementation of some builtin"

Cherry-picked to 10.x in 9007f06af0e009f41b876ae30e6b1ca96feee02e On Thu, Jan 16, 2020 at 12:04 AM Amy Huang via cfe-commits wrote: > > > Author: Amy Huang > Date: 2020-01-15T15:03:45-08:00 > New Revision: 3d210ed3d1880c615776b07d1916edb400c245a6 > > URL: >

Re: [clang] e8f198d - Fix pack deduction to only deduce the arity of packs that are actually

Cherry-picked in e241c8fe6d2e6d83e9fb32bd34da8ffcdc0dd83d. Thanks! On Thu, Jan 16, 2020 at 1:22 AM Richard Smith wrote: > > Hi Hans, > > Please consider this bugfix for the Clang 10 release branch. > > On Wed, 15 Jan 2020 at 16:21, Richard Smith via cfe-commits > wrote: >> >> >> Author:

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0734fb21ed5e: clang-format: [JS] Handle more keyword-named methods. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D72827?vs=238442=238713#toc Repository: rG LLVM Github

[clang] 0734fb2 - clang-format: [JS] Handle more keyword-named methods.

Author: Martin Probst Date: 2020-01-17T10:10:16+01:00 New Revision: 0734fb21ed5e267dda1a91e5f8b82f653ac3562d URL: https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d DIFF: https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d.diff

[PATCH] D72910: Fix a bug with clang with object destructor creation, while skipping object initialization - make clang crash

ykfre created this revision. ykfre added a project: clang. Herald added a subscriber: cfe-commits. The following code crashes clang: extern int g; class A { public: A() {}; ~A() {}; }; void b() { if(g) { goto clean_up; } A a; int i =

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:2717 +// operator Foo*() +// dependant on PointerAlignment style. + typo dependent

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238743. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238741. krasimir added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2722 +FormatToken *Before = Left.getPreviousNonComment(); +while (Before && Before->isOneOf(tok::kw_const, tok::kw_volatile)) { + Before =

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238746. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61943 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72907: clang-format: [JS] pragmas for tslint, tsc.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9835cf159014: clang-format: [JS] pragmas for tslint, tsc. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72907/new/

Re: [clang] 4456076 - Revert "Further implement CWG 2292"

On Fri, Jan 17, 2020 at 4:40 AM Hans Wennborg via cfe-commits wrote: > > (Note to self: I double checked that the "Further implement CWG 2292" > patch landed just after the 10.x branch, so this revert doesn't need > to be cherry-picked there.) Can confirm. I did the commit after the branch

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: mprobst. Revision a75f8d98d7ac9e557b238a229a9a2647c71feed1 fixed spacing for operators, but

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238753. njames93 added a comment. - added few more functions, fix format error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files:

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thank you for factoring our this library! I briefly read the UninitializedValues analysis and I also think that this change is a no-op. Comment at:

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error: cleanup.cpp(15,5): warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto] goto

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61941 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238738. krasimir added a comment. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp

[clang] 33463cf - clang-format: fix spacing in `operator const char*()`

Author: Krasimir Georgiev Date: 2020-01-17T13:33:41+01:00 New Revision: 33463cfba2be7c8d6c08e666123cc34f114a1f3e URL: https://github.com/llvm/llvm-project/commit/33463cfba2be7c8d6c08e666123cc34f114a1f3e DIFF:

  1   2   >