[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak marked 2 inline comments as done. llunak added inline comments. Comment at: clang/lib/Sema/Sema.cpp:985-986 + +// FIXME: Instantiating implicit templates already in the PCH breaks some +// OpenMP-specific code paths, see https://reviews.llvm.org/D69585 . +

[clang] fe0d1b6 - [Clang] Warn about 'z' printf modifier in old MSVC.

Author: Simon Tatham Date: 2020-01-28T09:04:45Z New Revision: fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 URL: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 DIFF: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0.diff LOG:

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. In D73457#1842605 , @amccarth wrote: > clang will still (by default) use the MS runtime libraries for Windows > builds, in which case it's important for the compatibility version to match > the one for the libraries that

[PATCH] D71965: include missing for std::abort

kadircet closed this revision. kadircet added a comment. Looks like this has landed with https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71965/new/

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. tests look good, but please upload the logs to the bug report for investigation. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:137 +llvm::StringRef Arg = CommandLine[I]; +if (llvm::any_of(FlagsToPreserve, [](auto &) { return S

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0d1b6a8ac5: [Clang] Warn about z printf modifier in old MSVC. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73457?vs=240626=240796#toc Repository: rG LLVM Github

[clang-tools-extra] af071f0 - [clangd] Improve ObjC property handling in SelectionTree.

Author: Sam McCall Date: 2020-01-28T11:07:19+01:00 New Revision: af071f03f379f7f1071e9da23ee4ca26d2c5c509 URL: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509 DIFF: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509.diff

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4871ead55f5: [clangd] Support pseudo-obj expr, opaque values, and property references in… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf071f03f379: [clangd] Improve ObjC property handling in SelectionTree. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72634/new/

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall updated this revision to Diff 240809. sammccall marked 4 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72508/new/ https://reviews.llvm.org/D72508 Files:

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 marked 2 inline comments as done. njames93 added a comment. Hmm a lot of the code in the redundant-string-init check is designed to be macro unsafe. Not sure the best way to follow up, discard the old macro behaviour or keep it Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/DependencyFlags.h:17-28 +enum class DependencyFlags : uint8_t { + Type = 1, + Value = 2, + Instantiation = 4, + UnexpandedPack = 8, + + // Shorthands for

[clang-tools-extra] f4871ea - [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

Author: Sam McCall Date: 2020-01-28T11:13:33+01:00 New Revision: f4871ead55f59a7dfee56ea97c32b5df4209d9ce URL: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce DIFF: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce.diff

[PATCH] D73562: [ASTMatchers] Add isPlacement traversal matcher for CXXNewExpr

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6763 +/// matches the expression 'new (Storage) MyClass()'. +AST_MATCHER(CXXNewExpr, isPlacement) { return Node.getNumPlacementArgs() > 0; } + I think a better

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman added a comment. In D73457#1844475 , @thakis wrote: > Since we auto-detect -fmsc-version if it's not explicitly installed and since > this warning is on by default, it makes the test suite depend on the > environment a good bit. Given how

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim marked an inline comment as done. fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } jdoerfert wrote: > Why do we need all of this? Can't we just *not do

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM There's maybe some argument that we should be calling getNonClosureContext() or something like that to find the parent function, at least for some attributes. But that seems less

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + njames93 wrote: > Quuxplusone wrote: > > Is it worth adding

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

gchatelet added a comment. Thx for the fix @thegameg Comment at: clang/lib/CodeGen/CGCall.cpp:1845 + + // First, handle the language options passed through -fno-builtin[-] + if (LangOpts.NoBuiltin) { Can you remove the trailing `[-]`? Repository: rG LLVM

[PATCH] D72531: Set traversal explicitly where needed in tests

shafik added a comment. I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to me how you determined where it was needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik added a comment. Example as requested, using the same code from `clang/test/CodeGenCXX/debug-info-block-invocation-linkage-name.cpp` the DWARF for block created in `f()` and passed to `g()` as an argument changes from: 0x0052: DW_TAG_subprogram DW_AT_low_pc

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:907 + +.. option:: -fsemantic-interposition, -fno-semantic-interposition + This looks like it should be reordered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61841 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

wgml added a comment. In D52136#1844384 , @grandinj wrote: > Hi > > Thanks a lot for this checker - would it be possible to enhance it to also > update stuff in associated header files? > > Thanks Check out D61989 ,

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62281 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 4e799ad - [CodeGen] Attach no-builtin attributes to function definitions with no Decl

Author: Francis Visoiu Mistrih Date: 2020-01-28T13:59:08-08:00 New Revision: 4e799ada5860d1029ea89226b9b867302e792251 URL: https://github.com/llvm/llvm-project/commit/4e799ada5860d1029ea89226b9b867302e792251 DIFF:

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e799ada5860: [CodeGen] Attach no-builtin attributes to function definitions with no Decl (authored by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

risa2000 added a comment. I wonder if someone could explain what happened and if this has been dropped because of the comment from @beanz? I am not using XCode so I cannot comment on its requirements nor fix the code for it. Someone has subscribed to this bug on

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, aaron.ballman, njames93, MyDeveloperDay. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. Also use //check// in add_new_check.py for

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Alundra added a comment. @Wawha In the same style of this missing feature, I think you are also aware of the miss of clang-format about struct/array initializer like: https://bugs.llvm.org/show_bug.cgi?id=40411 Basically to have the break for braces after the '=' of the struct/array

[clang] eaabaf7 - Revert "[MS] Overhaul how clang passes overaligned args on x86_32"

Author: Hans Wennborg Date: 2020-01-28T22:25:07+01:00 New Revision: eaabaf7e04fe98990a8177a3e053346395efde1c URL: https://github.com/llvm/llvm-project/commit/eaabaf7e04fe98990a8177a3e053346395efde1c DIFF: https://github.com/llvm/llvm-project/commit/eaabaf7e04fe98990a8177a3e053346395efde1c.diff

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman added a comment. In D73464#1844402 , @f00kat wrote: > In D73464#1844310 , @aaron.ballman > wrote: > > > LGTM! Do you need someone to commit on your behalf? > > > Yes, please. I don`t know how :)

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } fghanim wrote: > jdoerfert wrote: > > Why do we need all of this? Can't we just *not do it* instead? This is

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added a comment. Yeah, in general I think special casing a particular name mangling is probably not a great idea (what about in Microsoft mode with a different mangling scheme?), so I'm somewhat inclined towards doing this in general as @aprantl was suggesting. CHANGES SINCE LAST

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

arichardson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR

[clang] a153d78 - [Driver] Fix implicit conversion guarded by #ifdef _WIN32

Author: Benjamin Kramer Date: 2020-01-29T00:18:45+01:00 New Revision: a153d78c7eb079bcba5ebb37fc1ab9b3c82b99a4 URL: https://github.com/llvm/llvm-project/commit/a153d78c7eb079bcba5ebb37fc1ab9b3c82b99a4 DIFF:

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py Comment at: clang/unittests/Format/FormatTestJS.cpp:1229 " (param): param is {\n" -

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 2 inline comments as done. antiagainst added inline comments. Herald added a reviewer: mclow.lists. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static inline bool areAllValuesMemref(Operation *op) { + auto isOfMemrefType =

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

lebedev.ri added a comment. SGTM, but please wait for the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org/D73548 ___ cfe-commits mailing list

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. https://reviews.llvm.org/D73548 Next step is to fire off an email to llvm-dev about adding it to the coding standard :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added a comment. Messed up the revision history with Arc... Please show the diff between "Diff 1" and "Diff 4" to check the modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. I wanted this to go in because I'm actually using it – pre-2015 C libraries are useful to link against if you need an application to run on very old versions of Windows, and that means you need the compiler to warn you if you do something those libraries don't

[PATCH] D73492: [clang-format] Handle quotes and escaped braces in C# interpolated strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d212e83e920: [clang-format] Handle quotes and escaped braces in C# interpolated strings (authored by Jonathan Coe jb...@google.com). Herald added a project: clang. Herald added a subscriber:

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

Quuxplusone added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + Is it worth adding an example of a double pointer? auto

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

thegameg marked 2 inline comments as done. thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim updated this revision to Diff 240886. fghanim added a comment. Adding lit test to clang for testing the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.llvm.org/D73285 Files:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 240888. tnorth added a comment. - Add a unit-test loading a format and test file from temporary files. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files:

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240853. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files:

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > hokein wrote: > > kadircet wrote: > > >

[PATCH] D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: efriedma, sdesmalen, dancgr, cameron.mcinally, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62260 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG42e9478e0bbb: [clang][CodeComplete] Support for designated initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 39fe440 - [clang] Fix EOL whitespace. NFC

Author: Jonathan Roelofs Date: 2020-01-28T08:47:37-07:00 New Revision: 39fe44024689cf6d10b249db8694efbdcc6afc14 URL: https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14 DIFF:

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31a61dafeaa: [clangd][Hover] Handle uninstantiated templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire updated this revision to Diff 240816. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sammccall added a comment. This check as configured for LLVM itself is pretty noisy, generating warnings like: > warning: 'auto *CTSD' can be declared as 'const auto *CTSD' > [llvm-qualified-auto] which the LLVM dev guide doesn't have an opinion about. AFAICS there's no option to disable

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 3 inline comments as done. mprobst added inline comments. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, sammccall wrote:

[clang] aaae6b1 - Revert "PR44684: Look through parens and similar constructs when determining"

Author: Nico Weber Date: 2020-01-28T09:03:27-05:00 New Revision: aaae6b1b617378362462c1685e754813ed82b394 URL: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394 DIFF: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394.diff

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst marked 2 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3165 + } +} + RKSimon wrote: > @mprobst - this is breaking buildbots: >

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

grandinj added a comment. Herald added a project: LLVM. Hi Thanks a lot for this checker - would it be possible to enhance it to also update stuff in associated header files? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52136/new/

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:16145 +'``llvm.experimental.constrained.fmuladd``' Intrinsic +^^^ + jhenderson wrote: > This underline

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 240861. antiagainst added a comment. Clean up unrelated commits again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files:

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/6812/step_7.txt Since we auto-detect -fmsc-version if it's not explicitly installed and since this warning is on by default, it makes the test suite depend on the environment a good bit. Given how old 2015 is by now,

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb74d2e1bdec: [clangd] Make bin/llvm-lit run standalone clangd tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73538/new/

[clang-tools-extra] cb74d2e - [clangd] Make bin/llvm-lit run standalone clangd tests

Author: Kadir Cetinkaya Date: 2020-01-28T16:17:58+01:00 New Revision: cb74d2e1bdec8510f4ddd41e1ec879d745f40597 URL: https://github.com/llvm/llvm-project/commit/cb74d2e1bdec8510f4ddd41e1ec879d745f40597 DIFF:

[clang] 42e9478 - [clang][CodeComplete] Support for designated initializers

Author: Kadir Cetinkaya Date: 2020-01-28T16:34:15+01:00 New Revision: 42e9478e0bbbe3468a74d9d07275a61558b220c4 URL: https://github.com/llvm/llvm-project/commit/42e9478e0bbbe3468a74d9d07275a61558b220c4 DIFF:

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

sanwou01 marked 2 inline comments as done. sanwou01 added a comment. Thanks Eli. > The "trick" is something like the following? > [...] Yeah, that's exactly right. Your assessment of the options (dedicated pass, "volatile") matches our thinking as well. I'll update the commit message to make

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Adds an option called `AddConstQualifier` to readability-qualified-auto to toggle adding const to the auto typed pointers and references. By default its enabled but in the LLVM

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 16 warnings

[clang] e916c8d - Revert "[Clang] Warn about 'z' printf modifier in old MSVC."

Author: Nico Weber Date: 2020-01-28T09:27:54-05:00 New Revision: e916c8dfe461e272aa7ea115851db7ddda36b971 URL: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971 DIFF: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971.diff

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:209 + llvm::StringRef PtrConst = + (AddConstQualifier && isPointerConst(Var->getType())) ? "const " : "";

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 TargetIDs.insert(SymbolID(USR)); - std::vector Results; nit: maybe revert this

[clang] 9d212e8 - [clang-format] Handle quotes and escaped braces in C# interpolated strings

Author: Jonathan Coe Date: 2020-01-28T14:46:27Z New Revision: 9d212e83e920363762eb265293adf0bd6fda5a13 URL: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13 DIFF: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13.diff LOG:

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240873. mprobst marked an inline comment as done. mprobst added a comment. - - only run comma insertion for JavaScript. - review fixes - Fix col limit - test for comma insertion - - validate options, reject bin packing + trailing commas Repository: rG

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 6 inline comments as done. mprobst added a comment. PTAL. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, mprobst wrote:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth marked 7 inline comments as done. tnorth added a comment. > This makes sense for command-line args, but if I understand correctly this > patch will also allow BasedOnStyle: file:some/path. Is that the case? No, it should not, and I also think it's better not to. I think that all points

[clang-tools-extra] a31a61d - [clangd][Hover] Handle uninstantiated templates

Author: Kadir Cetinkaya Date: 2020-01-28T11:22:02+01:00 New Revision: a31a61dafeaa9110687110fc127ea6f7c91dd3e6 URL: https://github.com/llvm/llvm-project/commit/a31a61dafeaa9110687110fc127ea6f7c91dd3e6 DIFF:

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d1f0ce3b9f8: [X86] Add combination for fma and fneg on X86 under strict FP. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/

[clang] aec6210 - [ASTMatchers] Add cxxNoexceptExpr AST matcher

Author: Nathan Date: 2020-01-28T13:12:28Z New Revision: aec6210367de714caf876fe19c4b475889890e21 URL: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21 DIFF: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21.diff LOG:

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240815. topisani marked an inline comment as done. topisani added a comment. Address CR Comments I couldn't think of a good way to check for `--sysroot /my/sysroot` in the test in posix shell, so i hope the grep usage is OK. CHANGES SINCE LAST ACTION

[clang-tools-extra] dea1147 - [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

Author: Haojian Wu Date: 2020-01-28T12:23:26+01:00 New Revision: dea11473db38d03cbfd77f0d46e92dceb202a24a URL: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a DIFF: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a.diff

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 edited the summary of this revision. njames93 edited the summary of this revision. njames93 added a reviewer: rsmith. Adds a helper method `ArrayRef getTokenLocations() const` to

[clang] 3239b50 - [FPEnv] Add pragma FP_CONTRACT support under strict FP.

Author: Wang, Pengfei Date: 2020-01-28T20:43:43+08:00 New Revision: 3239b5034ee97b63572e61713b15be8444eeab25 URL: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25 DIFF: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25.diff

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3239b5034ee9: [FPEnv] Add pragma FP_CONTRACT support under strict FP. (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D72820?vs=240474=240840#toc Repository: rG LLVM Github

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman added a comment. In D72448#1844320 , @njames93 wrote: > In D72448#1844309 , @aaron.ballman > wrote: > > > In D72448#1844032 , @njames93 > > wrote: > > > > >

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, JDevlieghere. steakhal added a subscriber: boga95. **Remove taint from symbolic expressions if used in comparison expressions.** **Problem statement

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall added a comment. (the clang-tidy check doesn't reflect a style guideline and I'm not sure it's a good idea, raised on D72217 which added it) Comment at: clang-tools-extra/clangd/XRefs.cpp:287 +// We may be overridding

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: >

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Currently clangd lit tests can't be run in isolation because we don't set some of the config

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240822. hokein marked an inline comment as done. hokein added a comment. move the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files:

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdea11473db38: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73537: [clangd] add CODE_OWNERS

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73537/new/ https://reviews.llvm.org/D73537 ___

[PATCH] D73537: [clangd] add CODE_OWNERS

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > hokein wrote: > > >

  1   2   3   >