[PATCH] D74112: [clangd] Filter out implicit references while renaming

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch is based on D72746 and prevents non-spelled references from bei

[PATCH] D74112: [clangd] Filter out implicit references while renaming

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:309 return; +if ((R.Kind & RefKind::Spelled) == RefKind::Unknown) + return; -

[clang] 863d975 - [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

Author: Alexey Bader Date: 2020-02-06T08:42:31+03:00 New Revision: 863d9752105f390b31b3d08d1980d2888c15b034 URL: https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034 DIFF: https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034.diff

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque added a comment. @hiraditya or @smeenai can i get a merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits mailing list cfe-commits@

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio updated this revision to Diff 242823. dnsampaio added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. - Removed test - Added clear at the end of run as well, to clear waste - Moved clearing to a more sensible position Repository: rG LLVM

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein planned changes to this revision. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:674 -c^allback foo; - )cpp"); - auto AST = TestTU::withCode(T.code()).build(); - EXPECT_THAT(loca

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG863d9752105f: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048

[PATCH] D74112: [clangd] Filter out implicit references while renaming

kbobyrev updated this revision to Diff 242822. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74112/new/ https://reviews.llvm.org/D74112 Files: clang-to

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecove

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio planned changes to this revision. dnsampaio added a comment. Updated wrong patch here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

teemperor added a comment. I ran the patch on macOS and Linux through check-lldb and there were no regressions, so this is LGTM. The libc++ failures should go away when you add `libcxx;libcxxabi` to LLVM_ENABLE_PROJECTS (the tests are using libc++). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] 10540e4 - [clangd] Filter out implicit references while renaming

Author: Kirill Bobyrev Date: 2020-02-06T11:28:23+01:00 New Revision: 10540e480dfb243d992ff77db14219f696cc774a URL: https://github.com/llvm/llvm-project/commit/10540e480dfb243d992ff77db14219f696cc774a DIFF: https://github.com/llvm/llvm-project/commit/10540e480dfb243d992ff77db14219f696cc774a.diff

[PATCH] D74112: [clangd] Filter out implicit references while renaming

This revision was automatically updated to reflect the committed changes. Closed by commit rG10540e480dfb: [clangd] Filter out implicit references while renaming (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D74112?vs=242822&id=242844#toc Repository: rG LLVM Githu

[clang-tools-extra] d5e6e0a - Fix build after D74112

Author: Kirill Bobyrev Date: 2020-02-06T11:41:17+01:00 New Revision: d5e6e0a58b188627084d4714a4b2862c529870f8 URL: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8 DIFF: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8.diff

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242845. bader added a comment. Applied suggestions from Alexey and Ruyman and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Pragma.cpp:42 #include "llvm/ADT/StringRef.h" #include "llvm/Support/CrashRecoveryContext.h" #include "llvm/Support/Compiler.h"

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecoveryContext::GetCurrent(); hans wrote: > Maybe also add to the

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch <

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. Anastasia edited the summary of this revision. Currently in C++ we don't set/propagate what type of implicit conversions occurs on assignments/initializations/params/etc. Therefore the diagn

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 242855. hokein added a comment. no regression on non-definition of renaming alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clangd/XRef

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia added a comment. In D73360#1857073 , @rjmccall wrote: > Okay, we can go with this for now, since it does fix a bug. Thanks! Btw I uploaded straw-man patch for improving the diagnostics: https://reviews.llvm.org/D74116. CHANGES SINCE LAST ACT

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 242856. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr

[PATCH] D74087: [Sema] Fix Sema checkArgCount function

Yi-Hong.Lyu requested changes to this revision. Yi-Hong.Lyu added a comment. This revision now requires changes to proceed. Please add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74087/new/ https://reviews.llvm.org/D74087 ___

[PATCH] D74117: [AArch64][SVE] SVE2 intrinsics for character match & histogram generation

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, dancgr, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: - @llvm.aarch

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:405 +- New checker: ``fuchsia.HandleChecker`` to detect leaks related to Fuchsia + handles. xazax.hun wrote: > NoQ wrote: > > D74004 > > > > 1

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus updated this revision to Diff 242860. Szelethus marked an inline comment as done. Szelethus added a comment. //Actually// update the revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://reviews.llvm.org/D73966 Files: clang/docs/ReleaseNotes.rst Index

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus updated this revision to Diff 242869. Szelethus added a comment. //Actually//, **actually** upload the correct one. Getting rusty eh. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://reviews.llvm.org/D73966 Files: clang/docs/ReleaseNotes.rst Index: clang/d

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:99 bool isBlacklisted(const NamedDecl &RenameDecl) { + if (isProtoFile(RenameDecl.getLocation(),

[clang] 09a8812 - [clang][driver][ARM] Clean up ARM target & feature checking in clang driver.

Author: Michael Liao Date: 2020-02-06T08:57:52-05:00 New Revision: 09a88120c9269a9af0d80bc59afb2cb5806140ff URL: https://github.com/llvm/llvm-project/commit/09a88120c9269a9af0d80bc59afb2cb5806140ff DIFF: https://github.com/llvm/llvm-project/commit/09a88120c9269a9af0d80bc59afb2cb5806140ff.diff

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

kadircet updated this revision to Diff 242883. kadircet added a comment. - Add unittests to ASTDeclPrinter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73693/new/ https://reviews.llvm.org/D73693 Files: clang-tools-extra/clangd/unittests/FindTar

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09a88120c926: [clang][driver][ARM] Clean up ARM target & feature checking in clang driver. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D74112: [clangd] Filter out implicit references while renaming

hokein added a comment. In D74112#1861285 , @kbobyrev wrote: > Address review comments. looks like the code you submitted is the old version, not the one you addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. DeclarationName for cxx constructor is special, it is not an identifier. thus the "Spelled" flag are not set fo

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

hokein updated this revision to Diff 242890. hokein added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74125/new/ https://reviews.llvm.org/D74125 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-extra/c

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597 +bool IsTargetKind = NameKind == DeclarationName::Identifier || + NameKind == DeclarationName::CXXConstructorName; +bool Spelled = IdentifierToken && IsTarg

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:595 DeclarationName Name = DeclAndRef.first->getDeclName(); -bool Spelled = Identifier

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:122 + enum class SYCLVersionList { SYCL_2015, SYCL_1_2_1 = SYCL_2015, undefined }; + s/undefined/Undefined/g Comment at: clang/include/clang/Basic/LangOptions

[clang-tools-extra] d6da8a1 - [clangd] don't rename on protobuf symbols.

Author: Haojian Wu Date: 2020-02-06T15:40:14+01:00 New Revision: d6da8a1d945361327b8da79195dbfccc2e533e87 URL: https://github.com/llvm/llvm-project/commit/d6da8a1d945361327b8da79195dbfccc2e533e87 DIFF: https://github.com/llvm/llvm-project/commit/d6da8a1d945361327b8da79195dbfccc2e533e87.diff LO

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

hokein updated this revision to Diff 242892. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74036/new/ https://reviews.llvm.org/D74036 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extr

[PATCH] D74127: [clangd] Bump index version number.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Though we don't have new changes to the index format, we have changes to symbol collector, e.g. collect marcos, spelled re

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6da8a1d9453: [clangd] don't rename on protobuf symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74036/new/ https://reviews.llvm

[clang] 0fff659 - [OpenCL] Reduce size of builtin function tables

Author: Sven van Haastregt Date: 2020-02-06T15:08:32Z New Revision: 0fff6593f8962784d1e2e4d2ad986f2759a8 URL: https://github.com/llvm/llvm-project/commit/0fff6593f8962784d1e2e4d2ad986f2759a8 DIFF: https://github.com/llvm/llvm-project/commit/0fff6593f8962784d1e2e4d2ad986f2759a8.diff

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

kianm added a comment. In D68896#1861048 , @rsmith wrote: > In D68896#1861040 , @rsmith wrote: > > > In D68896#1778193 , @kianm wrote: > > > > > Hi, I am still seeing problem

[PATCH] D74127: [clangd] Bump index version number.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. i've thought change introducing `RefKind::Spelled` would've already bumped it. Please make sure to bump it only if it didn't Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 242900. balazske added a comment. Uploading new diff with added comments and renaming. (And a new feature of leaking pointer detection.) The code is at least saved here, can be used as starting point for smaller changes. Repository: rG LLVM Github Monore

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane marked an inline comment as done. erichkeane added a comment. In D73967#1861073 , @rsmith wrote: > Have you considered how this would interact with our other language > extensions? Can we form a vector of `_ExtInt(N)`? A `_Complex _ExtInt(N)`?

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 242901. erichkeane added a comment. Go through @rsmith 's comments. Current opens: 1- Getting an official mangling. This will likely need to wait until WG14 has seen the paper, in the meantime, use @rsmith suggested version. 2- _Atomic _ExtInt creates i

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @craig.topper up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. @hans : clang 10.0.0rc1 doesn't build on ppc64le in Fedora without that patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74129/new/ https://reviews.llvm.org/D74129

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. serge-sans-paille added a reviewer: hans. @hans : clang 10.0.0

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

sberg added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73637/new/ https://reviews.llvm.org/D73637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. This patch introduces the `clang_analyzer_isTainte

[clang-tools-extra] ca9fd22 - [clangd] Set "spelled" flag for constructor references.

Author: Haojian Wu Date: 2020-02-06T16:59:45+01:00 New Revision: ca9fd22adb5a633429ea85d2d62e5414ca35ab11 URL: https://github.com/llvm/llvm-project/commit/ca9fd22adb5a633429ea85d2d62e5414ca35ab11 DIFF: https://github.com/llvm/llvm-project/commit/ca9fd22adb5a633429ea85d2d62e5414ca35ab11.diff LO

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

hokein marked 3 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597 +bool IsTargetKind = NameKind == DeclarationName::Identifier || + NameKind == DeclarationName::CXXConstructorName; +b

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242909. bader marked 2 inline comments as done. bader added a comment. Applied Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/c

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

This revision was automatically updated to reflect the committed changes. Closed by commit rGca9fd22adb5a: [clangd] Set "spelled" flag for constructor references. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74125?vs=242890&id=242911#toc Repository: rG LLVM Github

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { Should this option also be controlled by `-fsycl`?

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > kiranchandramohan wrote: > > Compiler throws up th

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 7 inline comments as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote: >

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch implements the following Arm ACLE MVE intrinsics: - vcvtq_n_* - vcvt

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. I see, thanks. Is there the same or similar functionality in GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 ___ cfe-commits mai

[clang] 2694cc3 - [ARM][MVE] Add fixed point vector conversion intrinsics

Author: Mikhail Maltsev Date: 2020-02-06T16:49:45Z New Revision: 2694cc3dca94dbaec15eea40bf69872e0b0d8a5c URL: https://github.com/llvm/llvm-project/commit/2694cc3dca94dbaec15eea40bf69872e0b0d8a5c DIFF: https://github.com/llvm/llvm-project/commit/2694cc3dca94dbaec15eea40bf69872e0b0d8a5c.diff LO

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. This looks familiar and reassuring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/ https://reviews.llvm.org/D74134 __

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > Should this option a

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG2694cc3dca94: [ARM][MVE] Add fixed point vector conversion intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/ https:/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote: >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > bader wrote: > > > A

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + kiranchandramohan wrote: > jdoerf

[clang] 318d0ed - Fix warning on unused variables. NFC.

Author: Michael Liao Date: 2020-02-06T12:21:20-05:00 New Revision: 318d0ede572080f18d0106dbc354e11c88329a84 URL: https://github.com/llvm/llvm-project/commit/318d0ede572080f18d0106dbc354e11c88329a84 DIFF: https://github.com/llvm/llvm-project/commit/318d0ede572080f18d0106dbc354e11c88329a84.diff

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

benhamilton accepted this revision. benhamilton added a comment. LGTM, just one nit-pick. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.h:24 +/// http://clang.llvm.org/extra/clang-tidy/checks/objc-dealloc-in-category.html +class DeallocInCategoryCheck : p

[PATCH] D68720: Support -fstack-clash-protection for x86

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added a comment. Any plans to merge this feature to 10 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commit

[clang] 65f0785 - [ubsan] Omit return value check when return block is unreachable

Author: Vedant Kumar Date: 2020-02-06T10:24:03-08:00 New Revision: 65f0785fff0e45f8cd1b9e90328597197beef899 URL: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899 DIFF: https://github.com/llvm/llvm-project/commit/65f0785fff0e45f8cd1b9e90328597197beef899.diff

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. In D68720#1862050 , @xbolva00 wrote: > Any plans to merge this feature to 10 release? I would love to have it in -10 for Firefox ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai added a comment. I can commit this for you, but is it possible to write a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits mai

[clang-tools-extra] d5e6e0a - Fix build after D74112

Author: Kirill Bobyrev Date: 2020-02-06T11:41:17+01:00 New Revision: d5e6e0a58b188627084d4714a4b2862c529870f8 URL: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8 DIFF: https://github.com/llvm/llvm-project/commit/d5e6e0a58b188627084d4714a4b2862c529870f8.diff

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Added basic representation and parsing/sema handling of array-shaping operations. Array shaping expression is a

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a subscriber: hans. serge-sans-paille added a comment. I would love too, @hans what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 __

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 242947. mwyman marked an inline comment as done. mwyman added a comment. Make check class `final`, based on feedback.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Fi

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman added a comment. Updated based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

Kai created this revision. Kai added a reviewer: uweigand. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. When specifying -march=arch[8|9|10], those CPU types do NOT support the vector extension. In this case the vector ABI must be disabled. Th

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rjmccall added a comment. Oh thank goodness, they finally fixed this. Comment at: clang/lib/Sema/SemaDecl.cpp:4365 + // C++ [dcl.typedef]p9: [P1766R1] + // An unnamed class with a typedef name for linkage purposes shall not + if (RD->isInvalidDecl()) Start

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } If the argument type has a C++ destructor, will we end its lifetime before we call destructors at the end of the full-expression? CHA

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 242961. erichkeane added a comment. Deal with _Atomic. There isn't really a sensible way to do _Atomics on all platforms for these types, so this patch now limits to the LLVM atomic instruction limits, which is powers-of-2 >=8. CHANGES SINCE LAST ACTIO

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

pcc created this revision. pcc added reviewers: eugenis, hctim, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74150 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index: clang/docs/Hard

[clang] 208470d - [FPEnv][X86] Platform-specific builtin constrained FP enablement

Author: Kevin P. Neal Date: 2020-02-06T14:20:44-05:00 New Revision: 208470dd5d0a46bc3c24b66489b687eda4954262 URL: https://github.com/llvm/llvm-project/commit/208470dd5d0a46bc3c24b66489b687eda4954262 DIFF: https://github.com/llvm/llvm-project/commit/208470dd5d0a46bc3c24b66489b687eda4954262.diff

[PATCH] D74087: [Sema] Fix Sema checkArgCount function

bsaleil updated this revision to Diff 242963. bsaleil added a comment. Adding test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74087/new/ https://reviews.llvm.org/D74087 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/custom-checking.c Index: clang/test/Sema/custom-

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG208470dd5d0a: [FPEnv][X86] Platform-specific builtin constrained FP enablement (authored by kpn). Repository: rG LLVM G

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

kcc accepted this revision. kcc added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74150/new/ https://reviews.llvm.org/D74150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

hctim added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and th

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

rsmith added a comment. In D73967#1861757 , @erichkeane wrote: > Extended-vector types don't really make sense for non-powers-of-two (plus > have some odd gotchas when it comes to vectors of i1 for example), so I've > added a test that shows that this is

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. In D73967#1862268 , @rsmith wrote: > We allow _Complex T for integral types T in general, so this seems > inconsistent. Are there problems supporting this? Is it just a parser > limitation or something deeper? If there's some

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington planned changes to this revision. erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } rjmccall wrote: > If the argu

[clang] 6f5a159 - [clang][driver] Clean up unnecessary reference to TC. NFC.

Author: Michael Liao Date: 2020-02-06T15:14:21-05:00 New Revision: 6f5a159eab8d3fecdbbc741a38c970c0149b3c96 URL: https://github.com/llvm/llvm-project/commit/6f5a159eab8d3fecdbbc741a38c970c0149b3c96 DIFF: https://github.com/llvm/llvm-project/commit/6f5a159eab8d3fecdbbc741a38c970c0149b3c96.diff

[clang-tools-extra] da3dc00 - PR44684: Look through parens and similar constructs when determining

Author: Richard Smith Date: 2020-02-06T12:21:54-08:00 New Revision: da3dc0011e06c9f1aebe71d76eae92dc76e3db2e URL: https://github.com/llvm/llvm-project/commit/da3dc0011e06c9f1aebe71d76eae92dc76e3db2e DIFF: https://github.com/llvm/llvm-project/commit/da3dc0011e06c9f1aebe71d76eae92dc76e3db2e.diff

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

keryell added a comment. In D73967#1862273 , @erichkeane wrote: > At the moment it doesn't work because of parsing. I'm unaware of there is a > deeper limitation, but I'll look at it. I was unaware that we allow integral > types for _Complex, I'd looke

[clang] 8ecde3a - [Clang] Remove unused #pragma clang __debug handle_crash

Author: Alexandre Ganea Date: 2020-02-06T15:27:04-05:00 New Revision: 8ecde3ac34bbb5a8d53d8ec5cd32867658646df1 URL: https://github.com/llvm/llvm-project/commit/8ecde3ac34bbb5a8d53d8ec5cd32867658646df1 DIFF: https://github.com/llvm/llvm-project/commit/8ecde3ac34bbb5a8d53d8ec5cd32867658646df1.dif

[clang] 80e17e5 - [FPEnv][X86] Speculative fix for failures introduced by eda495426.

Author: Kevin P. Neal Date: 2020-02-06T15:28:36-05:00 New Revision: 80e17e5fcc09dc5baa940022e6988fcb08c5d92d URL: https://github.com/llvm/llvm-project/commit/80e17e5fcc09dc5baa940022e6988fcb08c5d92d DIFF: https://github.com/llvm/llvm-project/commit/80e17e5fcc09dc5baa940022e6988fcb08c5d92d.diff

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } erik.pilkington wrote: > rjmccall wrote: > > If the argument type has a C++ destructor, will we end its lifetime before > > we call des

  1   2   >