[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added a comment. Gentle ping) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein updated this revision to Diff 252238. hokein marked 2 inline comments as done. hokein added a comment. add -fno-recovery-ast, and negative tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252237. oontvoo added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Prepr

[clang] 733edf9 - [AST] Add RecoveryExpr to retain expressions on semantic errors

Author: Haojian Wu Date: 2020-03-24T09:20:37+01:00 New Revision: 733edf9750a4893d5f50329ad68b3901935303a9 URL: https://github.com/llvm/llvm-project/commit/733edf9750a4893d5f50329ad68b3901935303a9 DIFF: https://github.com/llvm/llvm-project/commit/733edf9750a4893d5f50329ad68b3901935303a9.diff LO

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. @MarcusJohnson91 To get a review past its better that you mark the comments as done so the reviewers know when the comments have been addressed and not missed. (this is important as the number of comments grows) Developers need to explain why they haven't changed

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG733edf9750a4: [AST] Add RecoveryExpr to retain expressions on semantic errors (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D69330?vs=2

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. > Not sure if tagging is considered rude, I figure that @MyDeveloperDay's > notification fell off your radar. Definitely not rude from my perspective...perfectly happy to come and look and be tagged to get my attention. If I'm ignoring its, its only becuase I'm b

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:2468 "}"); - verifyFormat("extern \"C\" int foo() {}"); - verifyFormat("extern \"C\" int foo();"); - verifyFormat("extern \"C\" int foo() {\n" + verifyFormat("extern \"C\"

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1088 if (FormatTok->Tok.is(tok::l_brace)) { -if (Style.BraceWrapping.AfterExternBlock) { - parseBlock(/*MustBeDeclaration=*/true); -} else { +if (Sty

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added a comment. is there overlap here D76197: clang-format: Use block indentation for braced initializations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 ___

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer, rovka. Herald added subscribers: mgrang, tschuett, mgorny. Herald added a project: clang. sdesmalen added a child revision: D76679: [SveEmitter] Add more immediate operand checks.. This patch adds a mechanism to e

[PATCH] D76621: [clang-format] No space inserted between commas in C#

MyDeveloperDay added a comment. nice, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76621/new/ https://reviews.llvm.org/D76621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer, rovka. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. sdesmalen added a parent revision: D76678: [SveEmitter] Add range checks for immediates and predicate pa

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added a comment. I want to believe that it was a mistake on the original developers part, but I just can't tell. A search of github shows people using this in their repos https://github.com/search?q=ForContinuationAndIndentation&type=Code I almost feel unless the original author

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 252248. kadircet marked 14 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files: clang-tools-e

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:277 build(std::move(*CurrentReq)); + bool IsEmpty = false; + { sammccall wrote: > kadircet wrote: > > sammccall wrote: > > > Seems clearer to do this immediately

[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer, rovka. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D76679: [SveEmitter] Add more immediate operand checks.. Adds another bunch of of intrinsics that take

[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

kbobyrev added a comment. In D76595#1936408 , @hokein wrote: > thanks. regarding files in `.vscode`, I think they are just local configs in > VSCode, we can probably remove the whole directory from git since we already > ignore them in the `llvm/.gitigno

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:709 } SwitchDiagnoser(Cond); + // The TypoExpr might be corrected to a non-intergral-or-enum type in the + // later stage without the proper type check, which is in

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name

[PATCH] D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!

simon_tatham updated this revision to Diff 252252. simon_tatham added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added an entry to the Clang release notes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

andwar added a comment. Cheers for the fix @sdesmalen ! Comment at: clang/include/clang/Basic/TargetBuiltins.h:187 -SVETypeFlags(uint64_t F) : Flags(F) {} -SVETypeFlags(EltType ET, bool IsUnsigned) : Flags(ET) {} +SVETypeFlags(uint64_t F) : Flags(F), EltTypeShift(

[clang] 080d046 - [ARM][CMSE] Implement CMSE attributes

Author: Momchil Velikov Date: 2020-03-24T10:21:26Z New Revision: 080d046c91d26bd3b0afba817cf5c2f99d1288ff URL: https://github.com/llvm/llvm-project/commit/080d046c91d26bd3b0afba817cf5c2f99d1288ff DIFF: https://github.com/llvm/llvm-project/commit/080d046c91d26bd3b0afba817cf5c2f99d1288ff.diff LO

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

SjoerdMeijer added a comment. Patches with functional changes but without tests are a bit "suspicious". In this case, I see it might be tricky. You could argue that it should be incorporated in the patch that includes the tests, so we can see what's happening. But perhaps separating this out i

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG080d046c91d2: [ARM][CMSE] Implement CMSE attributes (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

RKSimon added a comment. In D76622#1938009 , @NoQ wrote: > Sounds good but eventually i hope we re-enable this assert in release+assert > builds (D57062 ). SGTM as long as you don't reintroduce a compiler specific guard

[PATCH] D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76513/new/ https://reviews.llvm.org/D76513

[clang-tools-extra] b194e7d - [clangd] Change line break behaviour for hoverinfo

Author: Lorenz Junglas Date: 2020-03-24T12:41:08+01:00 New Revision: b194e7d6313be3b6e6db6e2d617a76c6dde2651b URL: https://github.com/llvm/llvm-project/commit/b194e7d6313be3b6e6db6e2d617a76c6dde2651b DIFF: https://github.com/llvm/llvm-project/commit/b194e7d6313be3b6e6db6e2d617a76c6dde2651b.diff

[clang] f282b6a - [ReleaseNotes, ARM] MVE intrinsics are all implemented!

Author: Simon Tatham Date: 2020-03-24T11:42:25Z New Revision: f282b6ab23a0f6ede0f1c8b6ccb5ad3c17a5ed2f URL: https://github.com/llvm/llvm-project/commit/f282b6ab23a0f6ede0f1c8b6ccb5ad3c17a5ed2f DIFF: https://github.com/llvm/llvm-project/commit/f282b6ab23a0f6ede0f1c8b6ccb5ad3c17a5ed2f.diff LOG:

[clang] 8fa322d - Increase DIAG_SIZE_DRIVER as we're close to hitting it

Author: Russell Gallop Date: 2020-03-24T11:45:53Z New Revision: 8fa322dd39a8ac32c46479511e8be20ab898f897 URL: https://github.com/llvm/llvm-project/commit/8fa322dd39a8ac32c46479511e8be20ab898f897 DIFF: https://github.com/llvm/llvm-project/commit/8fa322dd39a8ac32c46479511e8be20ab898f897.diff LOG

[PATCH] D76605: [analyzer] Display the checker name in the text output

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name for textual outputs", +true) + ---

[PATCH] D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!

This revision was automatically updated to reflect the committed changes. Closed by commit rGf282b6ab23a0: [ReleaseNotes,ARM] MVE intrinsics are all implemented! (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76513/new/ ht

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGb194e7d6313b: [clangd] Change line break behaviour for hoverinfo (authored by lolleko, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D76094?vs=252159&id=252269#toc Reposito

[PATCH] D76688: [AArch64][SVE] Add SVE intrinsics for masked loads & stores

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, efriedma, cameron.mcinally, dancgr. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the follow

[clang] 896fa30 - Fix unused variable warning

Author: Simon Pilgrim Date: 2020-03-24T11:51:49Z New Revision: 896fa30fc03091f7ea679f38616cae05166fb4be URL: https://github.com/llvm/llvm-project/commit/896fa30fc03091f7ea679f38616cae05166fb4be DIFF: https://github.com/llvm/llvm-project/commit/896fa30fc03091f7ea679f38616cae05166fb4be.diff LOG:

Re: [PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

Hi Momchil, Can I just check that you've seen this bot failure here since this patch: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/64604/steps/test-check-all/logs/FAIL%3A%20Clang%3A%3Asave-temps.c The new case that you've added to save-temps.c doesn't work

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. Built-in SVE types are POD in much the same that scalars and f

[PATCH] D76691: [AST][SVE] Treat built-in SVE types as trivially copyable

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a child revision: D76692: [AST][SVE] Treat b

[PATCH] D76692: [AST][SVE] Treat built-in SVE types as trivial

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent revision: D76691: [AST][SVE] Treat

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The built-in SVE types are supposed to be treated as opaque ty

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. Casts from an SVE type to itself aren't very useful, but they

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. When compiling C, a ?: between two values of the same SVE type

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

hokein updated this revision to Diff 252280. hokein added a comment. adjust the assertion based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76592/new/ https://reviews.llvm.org/D76592 Files: clang/lib/Sema/SemaStmt.cp

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

hokein updated this revision to Diff 252281. hokein added a comment. fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76592/new/ https://reviews.llvm.org/D76592 Files: clang/lib/Sema/SemaStmt.cpp clang/test/Parser/switch-typo-correcti

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Hi David, On 23.3.20. 18:51, David Blaikie wrote: > On Mon, Mar 23, 2020 at 12:56 AM Djordje > wrote: > > (+ CCing some debug info folks as well) > > Hi David, > > OK, I agree, my apologize. > > The patch enables the whole feature by default an

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76696 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/OpenMP/target_update_from_messages.cpp clang/test/OpenMP/target

[clang] a2aa997 - [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

Author: Sam McCall Date: 2020-03-24T13:56:38+01:00 New Revision: a2aa9970e1fec589591f7b8ac5557c47be4e8550 URL: https://github.com/llvm/llvm-project/commit/a2aa9970e1fec589591f7b8ac5557c47be4e8550 DIFF: https://github.com/llvm/llvm-project/commit/a2aa9970e1fec589591f7b8ac5557c47be4e8550.diff LO

[clang] 0b59982 - [CodeGen] Fix test attr-noreturn.c when run from my home directory

Author: Sam McCall Date: 2020-03-24T13:59:16+01:00 New Revision: 0b5998213415147d901d394cfc47d7daedacc3cf URL: https://github.com/llvm/llvm-project/commit/0b5998213415147d901d394cfc47d7daedacc3cf DIFF: https://github.com/llvm/llvm-project/commit/0b5998213415147d901d394cfc47d7daedacc3cf.diff LO

Re: [PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

From: Russell Gallop > The new case that you've added to save-temps.c doesn't work if you only build > with > DLLVM_TARGETS_TO_BUILD=X86 (i.e. not building ARM). Please could you take a > look? Yes, I've been looking into it. I may revert that test alone, until I figure out how to fix it. http

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2aa9970e1fe: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 2ae2564 - [CUDA][HIP] Add -Xarch_device and -Xarch_host options

Author: Yaxun (Sam) Liu Date: 2020-03-24T10:13:05-04:00 New Revision: 2ae25647d1a363515ecbd193dc66d8ada80dd054 URL: https://github.com/llvm/llvm-project/commit/2ae25647d1a363515ecbd193dc66d8ada80dd054 DIFF: https://github.com/llvm/llvm-project/commit/2ae25647d1a363515ecbd193dc66d8ada80dd054.dif

[clang] 386f95e - [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

Author: Haojian Wu Date: 2020-03-24T15:17:04+01:00 New Revision: 386f95e168b09603595864a5956624792ccb59c4 URL: https://github.com/llvm/llvm-project/commit/386f95e168b09603595864a5956624792ccb59c4 DIFF: https://github.com/llvm/llvm-project/commit/386f95e168b09603595864a5956624792ccb59c4.diff LO

[clang] 10bd842 - [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

Author: Alexander Belyaev Date: 2020-03-24T15:24:14+01:00 New Revision: 10bd8422d041e2964c146a38b5514d9d92fc458d URL: https://github.com/llvm/llvm-project/commit/10bd8422d041e2964c146a38b5514d9d92fc458d DIFF: https://github.com/llvm/llvm-project/commit/10bd8422d041e2964c146a38b5514d9d92fc458d.d

[PATCH] D76688: [AArch64][SVE] Add SVE intrinsics for masked loads & stores

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76688/new/ https://reviews.llvm.org/D76688 ___

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen added a comment. In D76617#1938787 , @SjoerdMeijer wrote: > Patches with functional changes but without tests are a bit "suspicious". In > this case, I see it might be tricky. You could argue that it should be > incorporated in the patch that

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

pifon2a created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. pifon2a added reviewers: bkramer, momchil.velikov. bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository:

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://reviews.llvm.org/D76703 ___

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

john.brawn created this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. john.brawn added a child revision: D31343: Add an attribute plugin example. Currently square-bracket-style (CXX11/C2X) attribute names are normalised to start with ::

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 252309. john.brawn added a comment. A few small changes: - Don't start C++11 spelling with :: (changes to name normalisation to allow this are in D76704 ) - Don't check that the Decl is null in diagAppertainsToDecl - Retur

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rG386f95e168b0: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76592/new/ ht

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10bd8422d041: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test. (authored by pifon2a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://r

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae25647d1a3: [CUDA][HIP] Add -Xarch_device and -Xarch_host options (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76520?vs=252105&id=252311#toc

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 252320. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. fix the clangd test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76696/new/ https://reviews.llvm.org/D76696 Fi

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620 ___ cfe-com

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 252325. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Renamed PPC32_SVR4ABIInfo class to PPC32ABIInfo. Fixed test case to use builtins. Changed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 6 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { sf

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#1939224 , @bader wrote: > LGTM. Thanks! Thanks! I'll give this 24 hrs for other comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Does anyone have any comments for me? This is blocking using pipes on windows targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-c

[PATCH] D76582: [Hexagon] Don't clear libpath when target is linux-musl

bcain added a comment. Seems like we might want a new test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76582/new/ https://reviews.llvm.org/D76582 ___ cfe-commits mailing list cfe-commi

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. In D71524#1924508 , @steakhal wrote: > I think `CallDescription` can only identify objects/functions which has > `IdefntifyerInfo` in them. AFAIK operators don't have such. Though someho

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. (note: I forgot to submit this a couple weeks ago) LLVM is crashing on me due to the issue mentioned in D75678 , but on Bitcoin, Xerces, CppCheck and Rtags I observed no difference in between t

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto &LCV1 = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +} NoQ wrote: >

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. In D75682#1931108 , @balazske wrote: > Adding special test functions is not as easy, then `StreamState` should be > accessible from another checker. It could be added to the same file, or new > file but then moving the data str

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:456 + SVal RetVal) const { + const auto *ContReg = Cont.getAsRegion(); + if (!ContReg) martong wrote: > Just out of curiosity:

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

xazax.hun added a comment. In D63279#1939349 , @Szelethus wrote: > (note: I forgot to submit this a couple weeks ago) > > LLVM is crashing on me due to the issue mentioned in D75678 > , but on Bitcoin, Xerces, CppCheck and

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. Do you also want to update LangOpts.td to make the default for the langopt equal to CPlusPlus? (I saw other opts doing that, not sure exactly what it affects, may be voodoo cargo cult stuff) Comment at: clang-tools-extra/clangd/unittests/CodeComplet

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:803 + +} // end "cert.str" + NoQ wrote: > `alpha.cert.str`. This text may be hard to understand. The option means "if it is off, the problem report happens only i

[PATCH] D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes

wchilders updated this revision to Diff 252357. wchilders added a comment. Updated the patch to correct formatting issues, and removed application of the `ConstantEvaluated` evaluation context to var decls as it introduces too much complexity. Additionally removed a fix for `decltype` with imme

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

simon_tatham created this revision. simon_tatham added a reviewer: miyuki. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. These were accidentally left out of D76123 . I added tests for the other three instructions in

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 252364. baloghadamsoftware added a comment. Updated according to a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp clang

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->ge

[PATCH] D76717: feedback

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76717 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp ===

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin updated this revision to Diff 252368. kmclaughlin marked 3 inline comments as done. kmclaughlin added a comment. Use SmallPtrSet instead of SmallVector for storing functions found by runOnModule Add more comments to clarify the purpose of the pass and some of the negative reinterpret

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done. oontvoo added a comment. Addressed comments. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-com

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252371. oontvoo added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this cleanup! Comment at: clang/lib/Basic/Attributes.cpp:89 SmallString<64> FullName = ScopeName; - if (Scope || SyntaxUsed == Attribute

[PATCH] D31343: Add an attribute plugin example

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 ___ cfe-commits

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp:233 + bool Changed = false; + for (auto *F : Functions) { +DominatorTree *DT = &getAnalysis(*F).getDomTree(); Iterating over a SmallPtrSet is non-deterministic. In th

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. Ping.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso marked 4 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:803 + +} // end "cert.str" + balazske wrote: > NoQ wrote: > > `alpha.cert.str`. > This text may be hard to understand. T

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

efriedma added a comment. Semantically, this makes sense. I'm not really happy with the use of the term "scalar initializer" to refer to initializing a vector. Seems likely to confuse users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76689/new

[PATCH] D76724: Prevent immediate evaluations inside of decltype

wchilders created this revision. wchilders added reviewers: Tyker, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes an issue where immediate invocations were queued inside of decltype, resulting in decltype's operand being evaluated. Repository: rG LLV

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

efriedma added a comment. Is it not legal to cast an SVE type to any type other than itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76694/new/ https://reviews.llvm.org/D76694 ___ cfe-commits mai

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

efriedma added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + Can you rearrange this so isSizelessBuiltinType() is at the bottom? It should be rare. (Assuming it doesn't need to be before th

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

efriedma added a comment. Do we want to allow stuff like `x ? (svint8_t)0 : (signed char)0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76693/new/ https://reviews.llvm.org/D76693 ___ cfe-commits mail

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76304: [clangd] Update TUStatus api to accommodate prea

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

SjoerdMeijer added a comment. > Yes you're right, the patch that I've made dependent needs this one to work > properly. Ah ok, I may have missed that, will have a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://reviews.llvm.

  1   2   >