[clang] 9bd6b77 - Don't print `&` as part of reference template arguments.

Author: Richard Smith Date: 2020-04-15T00:07:12-07:00 New Revision: 9bd6b77ac66fddadc50ca99ca327f1b7f9b0d6e4 URL: https://github.com/llvm/llvm-project/commit/9bd6b77ac66fddadc50ca99ca327f1b7f9b0d6e4 DIFF: https://github.com/llvm/llvm-project/commit/9bd6b77ac66fddadc50ca99ca327f1b7f9b0d6e4.diff

[clang] b09ee88 - Generalize our two different kinds of declaration argument for

Author: Richard Smith Date: 2020-04-15T00:07:12-07:00 New Revision: b09ee8882010ff2a7d55e30c46c19533d0ab562d URL: https://github.com/llvm/llvm-project/commit/b09ee8882010ff2a7d55e30c46c19533d0ab562d DIFF: https://github.com/llvm/llvm-project/commit/b09ee8882010ff2a7d55e30c46c19533d0ab562d.diff

[clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Author: Kadir Cetinkaya Date: 2020-04-15T09:10:10+02:00 New Revision: dffa9dfbda56820c02e357ad34c24ce8759b4d26 URL: https://github.com/llvm/llvm-project/commit/dffa9dfbda56820c02e357ad34c24ce8759b4d26 DIFF: https://github.com/llvm/llvm-project/commit/dffa9dfbda56820c02e357ad34c24ce8759b4d26.dif

[clang-tools-extra] 6d53897 - [clangd] Fix MSVC builds

Author: Kadir Cetinkaya Date: 2020-04-15T09:24:58+02:00 New Revision: 6d538975543475ce64e840b6b7c9915250bdac36 URL: https://github.com/llvm/llvm-project/commit/6d538975543475ce64e840b6b7c9915250bdac36 DIFF: https://github.com/llvm/llvm-project/commit/6d538975543475ce64e840b6b7c9915250bdac36.dif

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz abandoned this revision. tamas.petz added a comment. In D75364#1966818 , @MyDeveloperDay wrote: > In D75364#1966743 , @tamas.petz > wrote: > > > Wow, I have missed that configuration option. > > I will

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78181 Files: clang-tools-extra/clangd/Find

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

This revision was automatically updated to reflect the committed changes. Closed by commit rGdffa9dfbda56: [clangd] Shard preamble symbols in dynamic index (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77732/new/ https://revi

[clang-tools-extra] 2cd0be0 - [clangd] Fix MSVC compile error, attempt 2

Author: Kadir Cetinkaya Date: 2020-04-15T09:33:12+02:00 New Revision: 2cd0be02b9cbe4592dbf1ad3faef13970674b468 URL: https://github.com/llvm/llvm-project/commit/2cd0be02b9cbe4592dbf1ad3faef13970674b468 DIFF: https://github.com/llvm/llvm-project/commit/2cd0be02b9cbe4592dbf1ad3faef13970674b468.dif

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } Probably too much of assert here (but it works)? (There is not a way to get the de

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 257616. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp Index: clang/lib/AST/Mangle.cpp ==

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith - I think that should work - like this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list cfe-c

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 257617. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Herald added a subscriber: mgorny. Improved Negate function in terms of handling `[MIN,A]U[B,MAX] => [MIN,-B]U[-A,MAX]` (previously was `[MIN,MIN]U[MIN+1,-B]U[-A,M

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:702 continue; +if (!D.getField()) + continue; thanks for fixing this ! But I suppose we should rather return a result with empty `TargetDecl` as this

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } balazske wrote: > Probably too much of

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257622. gamesh411 added a comment. Reorganize test code to overcome testing infrastructure limitations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } Szelethus wrote: > balazske wrote: > >

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257633. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257632. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/in

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein updated this revision to Diff 257638. hokein marked an inline comment as done. hokein added a comment. Use isAlignmentErrorDependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://reviews.llvm.org/D78085 Files: clang/li

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257635. DmitryPolukhin added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @sammccall thank you for review! I'll wait for one more day for additional feedback if any, and land this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

nand updated this revision to Diff 257637. nand marked 2 inline comments as done. nand added a comment. fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files: clang/docs/ConstantInterpreter.rs

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:400 + for (; I != E; ++I) { +if (!I->isAlignmentDependent()) + Align = std::max(Align, I->getAlignment(Ctx)); sammccall wrote: > This doesn't seem great - previously if e.g. codegen en

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

sammccall added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:74 for (const auto *I : D->specific_attrs()) { +// FIXME: should we propagate the error bit? if (I->isAlignmentDependent()) maybe just do this unless it causes regression

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://reviews.llvm.org/D78085 _

[PATCH] D78189: [analyzer] StdLibraryFunctionsChecker: Add statistics

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a projec

[clang] b3387d1 - [ConstExprPreter] Updated constant interpreter documentation

Author: Nandor Licker Date: 2020-04-15T11:25:23+01:00 New Revision: b3387d1c30ae7da28b34378fb5d9bc29a213e991 URL: https://github.com/llvm/llvm-project/commit/b3387d1c30ae7da28b34378fb5d9bc29a213e991 DIFF: https://github.com/llvm/llvm-project/commit/b3387d1c30ae7da28b34378fb5d9bc29a213e991.diff

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

kmclaughlin updated this revision to Diff 257657. kmclaughlin marked an inline comment as done. kmclaughlin added a comment. Ensure LoadChain is always preserved in performLD1RQCombine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 Files: llv

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257658. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Address the current round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Fi

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257659. kbobyrev added a comment. Trim dexp output in remote index README. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/CMakeLists

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:194 + + add_definitions(-DGOOGLE_PROTOBUF_NO_RTTI=1) + include_directories(${Protobuf_INCLUDE_DIRS}) sammccall wrote: > these global s

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3387d1c30ae: [ConstExprPreter] Updated constant interpreter documentation (authored by nand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ http

[clang] 6f64dac - Upgrade calls to CreateShuffleVector to use the preferred form of passing an array of ints

Author: Benjamin Kramer Date: 2020-04-15T12:51:38+02:00 New Revision: 6f64daca8f3cbcf850ce7d502291017187e9fc08 URL: https://github.com/llvm/llvm-project/commit/6f64daca8f3cbcf850ce7d502291017187e9fc08 DIFF: https://github.com/llvm/llvm-project/commit/6f64daca8f3cbcf850ce7d502291017187e9fc08.dif

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257665. ekatz edited the summary of this revision. ekatz added a comment. Simplify function using IgnoreParenNoopCasts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:229-234 BufferSizeConstraint(ArgNo BufArgN, ArgNo SizeArgN) : ValueConstraint(BufArgN), SizeArgN(SizeArgN) {} +BufferSizeConstraint(ArgNo BufArgN, Ar

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > ekatz wrote: > > > > rjmccall wrote: > > > > > I liked the struct

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > ekatz wrote: > > > rjmccall wrote: > > > > ekatz wrote: > > > > > rjmccall wrote: > > >

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257664. kbobyrev added a comment. Fix protobuf & grpc_cpp_plugin settings in system-installed libs scenario and confirm that everything works as expected with -DLLVM_OPTIMIZED_TABLEGEN=On. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

njames93 added inline comments. Comment at: clang/lib/AST/NestedNameSpecifier.cpp:314 +InnerPolicy); +} else if (const auto *SpecType = + dyn_cast(T)) { Can this be renamed as it shadows the `SpecType` variabl

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

aaron.ballman added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > rsmith wrote: > > > Please heed this comment, and check in a

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 _

[clang-tools-extra] f058673 - [dexp] NFC: Change positional argument format

Author: Kirill Bobyrev Date: 2020-04-15T13:28:07+02:00 New Revision: f05867339737bb203b64a95e096fee509313122d URL: https://github.com/llvm/llvm-project/commit/f05867339737bb203b64a95e096fee509313122d DIFF: https://github.com/llvm/llvm-project/commit/f05867339737bb203b64a95e096fee509313122d.diff

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij commandeered this revision. stuij edited reviewers, added: LukeGeeson; removed: stuij. stuij added a comment. commandeering as I've got some changes to push CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, arphaman, kristof.beyls. Herald added a project: clang. This patch upstreams support for a new storage only bfloat16 C type. This type is used to implement primitive support for bfloat16 data, in line with the Bfloat16

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. changes in the last patch: depend on bfloat IR type, and resolve some conflicts that crept in CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___ cfe-commits mailing list cfe-

[PATCH] D78089: [dexp] NFC: Change positional argument format

This revision was automatically updated to reflect the committed changes. Closed by commit rGf05867339737: [dexp] NFC: Change positional argument format (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78089/new/ https://reviews

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm updated this revision to Diff 257676. arsenm added a comment. Fix comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/cl-denorms-are-zero.cl clang/test/Driver/cuda-

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

Szelethus added a comment. The idea is noble with the addition of `validate` functions, assert in debug builds and just move on in release. However, I'd expect it to be integrated into the signature matching function. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryF

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm updated this revision to Diff 257681. arsenm added a comment. Check triple for support. Report 2.0 for -amdhsa and -amdpal with flat support, but 1.2 for clover/-mesa3d. Also require targets to explicitly set a value to define, rather than defaulting. CHANGES SINCE LAST ACTION https:/

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm updated this revision to Diff 257684. arsenm added a comment. Attach correct diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77923/new/ https://reviews.llvm.org/D77923 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targe

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 ___ cfe-commits mailing list cfe-

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

Szelethus added reviewers: NoQ, xazax.hun. Szelethus added a subscriber: NoQ. Szelethus added a comment. Herald added a subscriber: rnkovacs. Adding @NoQ and @xazax.hun , I don't have much experience building CFGs. Comment at: clang/lib/Analysis/CFG.cpp:2855 + VarDecl *VD =

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added a comment. The tests are getting better, thanks Endre! Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility ctu-other.c","file":

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

Szelethus added a comment. In D77062#1977613 , @ASDenysPetrov wrote: > I've investigated graph.dot of the sample. F11723847: tmp63ucwe5i.html > This is the exploded graph for which code? The t37503.cpp file you uplo

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } Szelethus wrote: > Szelethus wrote: > > balazske wrote: > > > Probably too much of a

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

aykevl updated this revision to Diff 257687. aykevl marked an inline comment as done. aykevl added a comment. - added comment explaining the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125/new/ https://reviews.llvm.org/D78125 Files:

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11622 + if (VT.isFloatingPoint()) +Load = DAG.getNode(ISD::BITCAST, DL, VT, Load); + I'd expect this to then use `Load.getValue(0)` ? CHANGES SINCE LAST ACTION h

[clang] 3a61245 - clang/AMDGPU: Assume denormals are enabled for the default target.

Author: Matt Arsenault Date: 2020-04-15T09:17:26-04:00 New Revision: 3a612450508b314b7a6f4db142d0c619031d760e URL: https://github.com/llvm/llvm-project/commit/3a612450508b314b7a6f4db142d0c619031d760e DIFF: https://github.com/llvm/llvm-project/commit/3a612450508b314b7a6f4db142d0c619031d760e.diff

[PATCH] D78198: [Format] Work around current vim bugs in clang-format.py

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do line/col to byte conversions on the python side rather than relying on vim. Its calculations are off when text annotations are present: - https://github.c

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. @Szelethus > This is the exploded graph for which code? The t37503.cpp file you uploaded > earlier doesn't have the functions/variables found here, nor does the test > case included in this patch. This //html //corresponds to the test case in the patch. You can f

[PATCH] D76957: HIP: Merge builtin library handling

arsenm updated this revision to Diff 257694. arsenm added a comment. Update for new library structure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76957/new/ https://reviews.llvm.org/D76957 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/AMDGPU.h clang/

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77885/new/ https://reviews.llvm.org/D77885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11985-11986 }); if (Res.isInvalid()) { VDecl->setInvalidDecl(); } else if (Res.get() != Args[Idx]) { rsmith wrote: > S

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm closed this revision. arsenm added a comment. 3a612450508b314b7a6f4db142d0c619031d760e CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 __

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein updated this revision to Diff 257689. hokein marked 4 inline comments as done. hokein added a comment. address comments: - don't modify the existing tests - add new tests for -frecovery-ast only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] cb1ee34 - [clang-tidy] Optional inheritance of file configs from parent directories 

Author: Dmitry Polukhin Date: 2020-04-15T06:41:31-07:00 New Revision: cb1ee34e9d32fce84613827693a8ed3aff1d36cf URL: https://github.com/llvm/llvm-project/commit/cb1ee34e9d32fce84613827693a8ed3aff1d36cf DIFF: https://github.com/llvm/llvm-project/commit/cb1ee34e9d32fce84613827693a8ed3aff1d36cf.dif

[clang] 316b49d - Pass shufflevector indices as int instead of unsigned.

Author: Benjamin Kramer Date: 2020-04-15T15:52:49+02:00 New Revision: 316b49d37336258e11f16b5822d078c6407cd34f URL: https://github.com/llvm/llvm-project/commit/316b49d37336258e11f16b5822d078c6407cd34f DIFF: https://github.com/llvm/llvm-project/commit/316b49d37336258e11f16b5822d078c6407cd34f.dif

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

xazax.hun requested changes to this revision. xazax.hun added a comment. This revision now requires changes to proceed. I am not an expert when it comes to VLAs but I do see some problems here. First of all, we do not want to include typedef statements in the CFG as they are noops in terms of th

[PATCH] D78204: [AArch64][SVE] Remove LD1/ST1 dependency on llvm.masked.load/store

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, cameron.mcinally, c-rhodes. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. The SVE masked load and stor

[PATCH] D78198: [Format] Work around current vim bugs in clang-format.py

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for tracing it down! looks good, I assume you have test it locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78198/new/ https://revi

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Ping. Just a polite ping to keep it alive. I hope that's all right. Not urgent at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257704. mibintc added a comment. Lost power in Monday's storm, back online today. I made the changes requested by @rjmccall. Look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

aykevl added a comment. Honestly I don't know the convention but I agree with @rjmccall that the convention appears to be to not use a separate subdirectory (I don't see any other arch-specific subdirectories). So, should the files be moved to clang/test/Preprocessor/avr-*.c (e.g. clang/test/Pr

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:1500 +RefCountBug::KIND); + // TODO: Ideally, we should have a checker for each of these bug types. + INIT_BUGTYPE

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1ee34e9d32: [clang-tidy] Optional inheritance of file configs from parent directories  (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 17198df - [AST] Fix recovery-expr crash on invalid aligned attr.

Author: Haojian Wu Date: 2020-04-15T16:15:20+02:00 New Revision: 17198dfaff53a897edfc8d440a91cb9430982dcf URL: https://github.com/llvm/llvm-project/commit/17198dfaff53a897edfc8d440a91cb9430982dcf DIFF: https://github.com/llvm/llvm-project/commit/17198dfaff53a897edfc8d440a91cb9430982dcf.diff LO

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:194 + const ProgramPointTag *Tag = nullptr) { +// Sa

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

martong added a comment. In D77866#1983685 , @martong wrote: > Looks good to me! Just take care of the failures you have with harbourmaster, there seem to be CSA failures with the bot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein updated this revision to Diff 257712. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://reviews.llvm.org/D78085 Files: clang/lib/AST/ComputeDependence.cpp clang/lib/AST/DeclBase.c

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#1980665 , @NoQ wrote: > Aha, ok, sounds like i thought that it's not worth it to inline the > constructor for an argument when the call itself is not inlined, therefore i > didn't model the construction conte

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78122/new/ https://reviews.llvm.org/D78122

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17198dfaff53: [AST] Fix recovery-expr crash on invalid aligned attr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

yaxunl added a comment. If we really want to do this, device lib change and hipcc change need to be ready. Since once this is committed without corresponding device lib and hipcc change, HIP will break. On ROCM, device lib is currently installed at /opt/rocm/lib with extension .amdgcn.bc. This

[clang] a73a81d - [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

Author: Hubert Tong Date: 2020-04-15T10:45:00-04:00 New Revision: a73a81dce5bcae4f14004c09ee1844d7572d4f1e URL: https://github.com/llvm/llvm-project/commit/a73a81dce5bcae4f14004c09ee1844d7572d4f1e DIFF: https://github.com/llvm/llvm-project/commit/a73a81dce5bcae4f14004c09ee1844d7572d4f1e.diff L

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:1500 +RefCountBug::KIND); + // TODO: Ideally, we should have a checke

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

hokein updated this revision to Diff 257718. hokein added a comment. emit empty decl and simplify the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78181/new/ https://reviews.llvm.org/D78181 Files: clang-tools-extra/clangd/FindTarget.c

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

martong accepted this revision. martong added a comment. Looks good! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 ___ cfe-commits mailing list cfe-co

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:441 + case GlobalValue::ExternalWeakLinkage: +if (TM.getTargetTriple().isOSBinFormatXCOFF()) { + OutStreamer->emitSymbolAttribute(GVSym, MCSA_Weak); Maybe an assert o

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. LGTM But a better approach can be to make a new kind of dependency. (Or split the StreamChecker.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

Szelethus added a comment. In D77866#1983690 , @martong wrote: > In D77866#1983685 , @martong wrote: > > > Looks good to me! > > > Just take care of the failures you have with harbourmaster, there seem to be > CSA

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#1983693 , @baloghadamsoftware wrote: > I am trying to understand where I have to implement this but I have some > problems. The first is that when a function is not inlined it does not have a > `StackFrameContext`. What to

[PATCH] D77923: OpenCL: Fix some missing predefined macros

yaxunl added a comment. LGTM. The objective of the change is to simplify offline compilation. We want to avoid asking users to add -D if a proper macro can be inferred from triple and cpu. Ideally, users only need to specify triple and cpu with clang driver. In case users want to override the d

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73a81dce5bc: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

john.brawn added a comment. Herald added subscribers: frgossen, grosul1. Herald added a reviewer: MaskRay. With this patch the Threading.PhysicalConcurrency unit test fails when run with an affinity less than the number of physical cpus. I've raised https://bugs.llvm.org/show_bug.cgi?id=45556.

[clang] 789215d - [ASTImporter] Add support for importing fixed point literals

Author: Vince Bridgers Date: 2020-04-15T10:36:44-05:00 New Revision: 789215dc0db174c9fdd273436fdd60d8289a9fc0 URL: https://github.com/llvm/llvm-project/commit/789215dc0db174c9fdd273436fdd60d8289a9fc0 DIFF: https://github.com/llvm/llvm-project/commit/789215dc0db174c9fdd273436fdd60d8289a9fc0.diff

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

martong added a comment. Looks okay to me (other than the redundant import code that I have a comment about). > Also this seems to be testable via a Clang unit test, so I think this patch > should have one. Yeah, would be nice to have a Clang unit test. I believe we have the infrastructure fo

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

milianw created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. milianw added reviewers: nik, yvvan. This makes the BindingDecl accessible to consumers of libclang as CXCursor_UnexposedDecl where previously these AST nodes were not visited at all from

[PATCH] D78214: [libclang]: visit C++17 if init statements

milianw created this revision. milianw added reviewers: nik, yvvan. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. This makes the previously unaccessible AST nodes for C++17 "if with init statements" accessible to consumers of libclang. Repository: rG LLVM Gith

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

thakis added a comment. Breaks Windows due to slashiness in the test: http://45.33.8.238/win/12984/step_8.txt Please take a look, and revert if it takes a while to investigate. (I'd find the diag easier to read without the "the": just "is disabled in") Repository: rG LLVM Github Monorepo C

  1   2   3   >