[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

zinovy.nis updated this revision to Diff 267546. zinovy.nis added a comment. Fix and simplify the condition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp

[PATCH] D80884: [ASTMatchers] Force c++ unittests to specify correct language standard

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d23f2efc64: [ASTMatchers] Force c++ unittests to specify correct language standard (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 40a3fcb - [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

Author: Djordje Todorovic Date: 2020-06-01T09:10:05+02:00 New Revision: 40a3fcb05c83c41862038277aa667c956e7cac82 URL: https://github.com/llvm/llvm-project/commit/40a3fcb05c83c41862038277aa667c956e7cac82 DIFF:

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Fix crash on CXXFoldExpr

njames93 added a comment. This fix has expanded from preventing the crash to adding support for `CXXFoldExpr` to misc-redundant-expression. Maybe rename the revision to explain that better. If that is the case then you may as well add a test case showing a redundant fold expression

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

This revision was automatically updated to reflect the committed changes. Closed by commit rG40a3fcb05c83: [DebugInfo][CallSites] Remove decl subprograms from retainedTypes: (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

labrinea added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4493 + case NeonTypeFlags::BFloat16: +if (HasBFloat16Type) + return llvm::VectorType::get(CGF->BFloatTy, V1Ty ? 1 : (4 << IsQuad)); This is not what we should be checking for

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover created this revision. Herald added subscribers: danielkiss, jdoerfert, asbirlea, hiraditya, kristof.beyls, mcrosier. Herald added projects: clang, LLVM. Some of the system registers readable on AArch64 & ARM platforms return different values with each read (for example a timer

[PATCH] D80910: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover abandoned this revision. t.p.northover added a comment. Sorry. Keyboard decided to create diff before I'd filled everything in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80910/new/ https://reviews.llvm.org/D80910

[PATCH] D80910: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, jdoerfert, asbirlea, hiraditya, kristof.beyls, mcrosier. Herald added projects: clang, LLVM. t.p.northover abandoned this revision. t.p.northover added a comment. Sorry. Keyboard decided to

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

psmith added a comment. FWIW I'm happy for Clang to match GCC behaviour for Linux (non-Android) targets with respect to the frame pointer. Outside of Android I would expect most developers of linux applications to build with both GCC and clang so they should already have the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/arm-bf16-params-returns.c:5 +// RUN: %clang_cc1 -triple aarch64-arm-none-eabi -target-abi aapcs -mfloat-abi softfp -target-feature +bf16 -target-feature +neon -emit-llvm -O2 -o - %s | opt -S -mem2reg -sroa |

[clang] b6d23f2 - [ASTMatchers] Force c++ unittests to specify correct language standard

Author: Nathan James Date: 2020-06-01T07:52:01+01:00 New Revision: b6d23f2efc64c226d30094bcc4258e0b63029da8 URL: https://github.com/llvm/llvm-project/commit/b6d23f2efc64c226d30094bcc4258e0b63029da8 DIFF: https://github.com/llvm/llvm-project/commit/b6d23f2efc64c226d30094bcc4258e0b63029da8.diff

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, lei, stefanp, saghir, power-llvm-team. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. This patch implements builtins for the following prototypes: unsigned long long

[clang] 8a8d703 - Fix how cc1 command line options are mapped into FP options.

Author: John McCall Date: 2020-06-01T22:00:30-04:00 New Revision: 8a8d703be0986dd6785cba0b610c9c4708b83e89 URL: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89 DIFF: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89.diff

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1009 + Actions, Sema::ExpressionEvaluationContext::Unevaluated, + Sema::ReuseLambdaContextDecl); + Res = Actions.TransformToPotentiallyEvaluated(Res.get());

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall closed this revision. rjmccall added a comment. 8a8d703be0986dd6785cba0b610c9c4708b83e89 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/

[PATCH] D80858: [HIP] Support accessing static device variable in host code

rjmccall added a comment. In addition to everyone else's concerns about generating this number randomly, it's also inherently less testable. I'm sure there's something else you could use that's reasonably likely to be unique, like a hash of the input filename or output filename or a

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267783. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1582 +clear that it is a single line. Note that comments should only be hoisted for loops and +'if', and not in 'else if' or 'else', where it would be unclear whether the comment +belonged

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, lei, stefanp, saghir, power-llvm-team, hfinkel. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. This patch implements builtins for the following prototypes: unsigned long long

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267710. vitalybuka marked an inline comment as done. vitalybuka added a comment. SmallPtrSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files:

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

jdoerfert added a comment. Thanks for finally writing this down :) Two minor comments. Comment at: llvm/docs/CodingStandards.rst:1580 +statement is accompanied by a comment that loses its meaning if hoisted above the if +or loop statement, or where the single statement is

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; eugenis wrote: > vitalybuka wrote: > > eugenis wrote: > > > Alloca order

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

MyDeveloperDay added a comment. In D80933#2066648 , @thopre wrote: > That was a speedy patch! I can confirm that my non reduced testcase (git diff > -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b >

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen created this revision. ychen added reviewers: ABataev, jdenny, lebedev.ri, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Right now it is a '' for cases like this. CounterCoverageMappingBuilder relies on the information to decide the region for a

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 267695. kmclaughlin marked 7 inline comments as done. kmclaughlin added a comment. - Restricted the illegal types which should be lowered for EXTRACT_SUBVECTOR to those handled in this patch (nxv8i8, nxv4i16 & nxv2i32) - Removed unnecessary changes in

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for taking another look at this, @efriedma! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10676 +ConstantSDNode *C = dyn_cast(Dup->getOperand(0)); +uint64_t ExtVal =

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cfded350a7e: [PowerPC] Add clang option -m[no-]pcrel (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80757/new/

[clang] 7cfded3 - [PowerPC] Add clang option -m[no-]pcrel

Author: Lei Huang Date: 2020-06-01T15:34:59-05:00 New Revision: 7cfded350a7edc87f4a67f84e4261e44954600d0 URL: https://github.com/llvm/llvm-project/commit/7cfded350a7edc87f4a67f84e4261e44954600d0 DIFF: https://github.com/llvm/llvm-project/commit/7cfded350a7edc87f4a67f84e4261e44954600d0.diff

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267663. nickdesaulniers added a comment. - add Android target triple handling, see https://developer.android.com/ndk/guides/other_build_systems#overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22 #include "InputInfo.h" +#include "MSP430.h" #include "PS4CPU.h" Note to reviewers: the linter really wanted to touch

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. As a functional change it should definitely have a functional test. Let me double-check on how our stuff behaves, I may be mis-remembering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: clang/lib/CodeGen/CGExpr.cpp:3787 + ColIdx->getType()->getScalarSizeInBits()); + llvm::Type *IntTy =

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPGridValues.h:134 +} // namespace clang +#endif Can we move this into llvm core (subfolder `Frontend/OpenMP/`)? We probably need this during OpenMPOpt, and for Flang as well.

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Indeed I am mis-remembering, sorry about that! We use gnu-style command-line options but we change RSPQuoting from Default to Windows; assuming getProcessTriple() is the host not the target, your change should have the same effect. I'll try removing our private

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:565 +case llvm::Triple::thumbeb: + if (Triple.getEnvironment() == llvm::Triple::Android) +return true; Triple.isAndroid() is more clear. Comment

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

amccarth accepted this revision. amccarth added a comment. Yowza. Mingw still links against MSVCRT?! Anyway, I think the patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80880/new/ https://reviews.llvm.org/D80880

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

lebedev.ri added a comment. Why not lower it to `@llvm.cttz(and(a, b))`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 ___ cfe-commits mailing list

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev added a comment. In D80925#2066728 , @rjmccall wrote: > Narrowly this seems to fix the immediate problem, but I feel like we're in > trouble if tentative parsing is changing the semantic context in ways that > persist. In particular, I'm

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: lld/ELF/LTO.cpp:79 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent `--lto-basic-block-sections` I

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267683. nickdesaulniers added a comment. - update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added a comment. LLD side changes look good. Are you waiting on an explicit approval from @rmisth ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D80897#2066723 , @tra wrote: > Hmm. I'm pretty sure tensorflow is using std::complex for various types. I'm > surprised that we haven't seen these functions missing. Which

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Clang side of these changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267682. nickdesaulniers added a comment. - prefer Triple#isAndroid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan updated this revision to Diff 267684. leonardchan added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836 Files: clang/include/clang/Sema/Initialization.h

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. In D80828#2067110 , @MaskRay wrote: > (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less > information. `[Driver]` emphasizes this is related to clangDriver. Nothing in > sema/codegen/analyzer/etc is

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added a comment. Narrowly this seems to fix the immediate problem, but I feel like we're in trouble if tentative parsing is changing the semantic context in ways that persist. In particular, I'm concerned that we could end up tentatively parsing an ODR use as part of an expression

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

tra added a comment. Hmm. I'm pretty sure tensorflow is using std::complex for various types. I'm surprised that we haven't seen these functions missing. Plain CUDA (e.g. https://godbolt.org/z/Us6oXC) code appears to have no references to `__mul*` or `__div*`, at least for optimized builds, but

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a subscriber: rnk. probinson added a comment. I was about to add @rnk who I remember has been in Windows driver behavior discussions in the past; except he has cleverly left a note that he's away June-Sept. Oh well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=46159 Linux Kernel code using is try as a variable name (as its 'C' code they can), they

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane updated this revision to Diff 267714. erichkeane added a comment. Attempt improvements based on feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80947/new/ https://reviews.llvm.org/D80947 Files: llvm/docs/CodingStandards.rst Index: llvm/docs/CodingStandards.rst

[clang] 8f3f88d - [Matrix] Implement matrix index expressions ([][]).

Author: Florian Hahn Date: 2020-06-01T20:08:49+01:00 New Revision: 8f3f88d2f50d97011bf48ccc507bef033715e566 URL: https://github.com/llvm/llvm-project/commit/8f3f88d2f50d97011bf48ccc507bef033715e566 DIFF: https://github.com/llvm/llvm-project/commit/8f3f88d2f50d97011bf48ccc507bef033715e566.diff

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram marked an inline comment as done. tmsriram added a comment. In D68049#2066937 , @MaskRay wrote: > LLD side changes look good. Are you waiting on an explicit approval from > @rmisth ? Yes. Comment at: lld/ELF/LTO.cpp:79

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn marked an inline comment as done. fhahn added a comment. Thanks for all the feedback John! Comment at: clang/lib/CodeGen/CGExpr.cpp:3787 + ColIdx->getType()->getScalarSizeInBits()); + llvm::Type *IntTy =

[PATCH] D80771: [MTE] Convert StackSafety into analysis

eugenis added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; vitalybuka wrote: > eugenis wrote: > > Alloca order can easily change in the future. Not sure how to make this > >

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 267693. yaxunl added a comment. emit empty target id module flag if no -target-cpu is set CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Nick, for cleaning this up and always striving to make things more compatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:136-137 + __d = _COPYSIGNf(_ISINFf(__d) ? 1 : 0, __d); + if (_ISNANf(__a)) +__a = _COPYSIGNf(0, __a); + if (_ISNANf(__b)) Why does this try to

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Oh, meant to approve on the last. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

dblaikie added a comment. Seems like a reasonable direction - presumably every flag (that has a similar form in both driver and frontend) would be classified as one of these (opt in or opt out)? The ones you've migrated are just a sample/example? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, jdoerfert, jroelofs. Herald added a project: LLVM. This is a rule that seems to have been enforced for the better part of the decade, so we should document it for new contributors. Repository: rG LLVM Github Monorepo

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. It looks like your patch will allow us to remove a private patch that has a similar effect. Incidentally if I apply this to an upstream checkout on Windows, I see clang/test/Driver/at_file.c fails, so you'd at least need to do something for that. (`UNSUPPORTED:

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

nickdesaulniers updated this revision to Diff 267700. nickdesaulniers added a comment. - double backticks in release notes, -O1 rather than -O2 in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

MaskRay added inline comments. Comment at: clang/test/Driver/frame-pointer-elim.c:125 +// For Android, keep the framepointers always. +// RUN: %clang -### -target armv7a-linux-androideabi- -marm -O2 -S %s 2>&1 | \ +// RUN: FileCheck --check-prefix=KEEP-ALL %s

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3f88d2f50d: [Matrix] Implement matrix index expressions ([][]). (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D76791?vs=267601=267701#toc Repository: rG LLVM Github

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

tra added a comment. In D80897#2066952 , @jdoerfert wrote: > In D80897#2066723 , @tra wrote: > > > Hmm. I'm pretty sure tensorflow is using std::complex for various types. > > I'm surprised that we haven't seen

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:964 +<< Opts.BBSections; + } + grimar wrote: > Doesn't seem you need "{}" around this

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/docs/CodingStandards.rst:1582 +clear that it is a single line. Note that comments should only be hoisted for loops and +'if', and not in 'else if'

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. In D60620#2064839 , @yaxunl wrote: > It means HIP will create two compilation passes: one for gfx908 and one for > gfx908:xnack+:sramecc+. OK, so empty feature list may also be valid. > > >> One thing you'll need is a way to

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Re testing, you could copy clang/test/Driver/at_file_win.c, which has an explicit `--rsp-quoting=windows`; remove that option and make it `REQUIRES: system-windows`. That should do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay accepted this revision. MaskRay added a comment. (You can change `[Clang]` to `[Driver]` as `[Clang]` may carry less information. `[Driver]` emphasizes this is related to clangDriver. Nothing in sema/codegen/analyzer/etc is affected.) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev added a comment. In D80925#2067145 , @rjmccall wrote: > In D80925#2066915 , @ABataev wrote: > > > In D80925#2066728 , @rjmccall > > wrote: > > > > > Narrowly this

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1580 +statement is accompanied by a comment that loses its meaning if hoisted above the if +or loop statement, or where the single statement is complex enough that it stops being +clear

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

rjmccall added a comment. In D80925#2066915 , @ABataev wrote: > In D80925#2066728 , @rjmccall wrote: > > > Narrowly this seems to fix the immediate problem, but I feel like we're in > > trouble if tentative

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

lebedev.ri added a comment. SGTM Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +^ `case` too

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address small documentation nitpick before committing... Btw does your change fix this bug: https://bugs.llvm.org/show_bug.cgi?id=33103 Comment

[clang] 6bedfaf - [analyzer][MallocChecker] Fix the incorrect retrieval of the from argument in realloc()

Author: Kirstóf Umann Date: 2020-06-01T22:38:29+02:00 New Revision: 6bedfaf5200474f9a72b059f0d99dd39ece1c03e URL: https://github.com/llvm/llvm-project/commit/6bedfaf5200474f9a72b059f0d99dd39ece1c03e DIFF: https://github.com/llvm/llvm-project/commit/6bedfaf5200474f9a72b059f0d99dd39ece1c03e.diff

[clang] 959517a - Clean up clang/test/CodeGenObjC/os_log.m

Author: Akira Hatanaka Date: 2020-06-01T13:47:20-07:00 New Revision: 959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 URL: https://github.com/llvm/llvm-project/commit/959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 DIFF:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. > At the moment when going through the GCC compatibility driver (standard > interface), we get __bf16 is not supported on this target. If this is the current behaviour, and consistent with GCC, that sounds reasonable. Probably best to be explicit about this and

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

LukeGeeson added a comment. A few nits, it looks largely uncontroversial but I'll let someone else give the ok since an external eye is always good :) Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || +

[PATCH] D80584: [utils] change update_test_checks.py use of 'TMP' value names

jdoerfert added a comment. > I think we're good enough. I agree. If this doesn't bother anyone anymore there is no need for any options ;) Thanks for the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80584/new/

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

labrinea created this revision. labrinea added reviewers: fpetrogalli, LukeGeeson, stuij, momchil.velikov, SjoerdMeijer, miyuki. Herald added subscribers: hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch is part of a series implementing the Bfloat16 extension of the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. In D76077#2066520 , @SjoerdMeijer wrote: > > At the moment when going through the GCC compatibility driver (standard > > interface), we get __bf16 is not supported on this target. > > If this is the current behaviour, and

[clang] 7968981 - [SVE] Eliminate calls to default-false VectorType::get() from Clang

Author: Christopher Tetreault Date: 2020-06-01T10:02:14-07:00 New Revision: 796898172c48a475f27f038e587c35dbba9ab7a6 URL: https://github.com/llvm/llvm-project/commit/796898172c48a475f27f038e587c35dbba9ab7a6 DIFF:

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

arsenm added inline comments. Comment at: clang/include/clang/Basic/OpenMPGridValues.h:96 +256, // GV_Slot_Size +64, // GV_Warp_Size +6,// GV_Warp_Size_Log2 What about wave32? Comment at:

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG796898172c48: [SVE] Eliminate calls to default-false VectorType::get() from Clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = ::cl::TokenizeWindowsCommandLine;

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. If the variables must be globalized in OpenMP mode (local automatic variable, GPU compilation mode, the variable may escape its declaration

[PATCH] D80925: Fix compiler crash when trying to parse alignment argument as a constant expression.

ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added a project: clang. Clang crashes when trying to finish function body. MaybeODRUseExprs is not empty because of const static data member parsed in outer evaluation context, upon call for isTypeIdInParens()

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk updated this revision to Diff 267648. amyk added a comment. Updated a typo within the comment in `llvm/test/CodeGen/PowerPC/p10-bit-manip-ops.ll`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80935/new/ https://reviews.llvm.org/D80935

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: lei, stefanp, nemanjai, saghir, power-llvm-team. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. Herald added projects: clang, LLVM. amyk updated this revision to Diff 267648. amyk added a comment. Updated a typo within

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

thopre added a comment. That was a speedy patch! I can confirm that my non reduced testcase (git diff -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b ^ 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = ::cl::TokenizeWindowsCommandLine; Testing the triple is a functional

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

probinson added a comment. In D80242#2045362 , @nickdesaulniers wrote: > For C++, I'd imagine: > > class foo {}; > using my_foo = foo; > template > struct baz { > bar my_bar; > }; > > > but it seems that `g++` doesn't emit debug info the

[PATCH] D80840: [Clang][CGM] style cleanups NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGef1d4bec891b: [Clang][CGM] style cleanups NFC (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/

  1   2   >