[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. A followup of D79938 . Repository: rG LLVM Github Monorepo

[clang] e6ba0a5 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2020-06-03T11:12:43+01:00 New Revision: e6ba0a55fd39b600f3f431308f4a7e36e48f91ae URL: https://github.com/llvm/llvm-project/commit/e6ba0a55fd39b600f3f431308f4a7e36e48f91ae DIFF: https://github.com/llvm/llvm-project/commit/e6ba0a55fd39b600f3f431308f4a7e36e48f91ae.diff

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. Great! thanks for the review @rsmith . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-commits mailing list

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f32bfcc7cd: [clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions. (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 268140. simoll added a comment. NFC. Undid stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst

[PATCH] D81075: [ASTMatchers] Fix crash with HasName and HasAnyName

njames93 updated this revision to Diff 268142. njames93 added a comment. Fix clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81075/new/ https://reviews.llvm.org/D81075 Files: clang/include/clang/AST/PrettyPrinter.h

[clang] b34b769 - Syntax tree: ignore implicit expressions at the top level of statements

Author: Dmitri Gribenko Date: 2020-06-03T10:58:12+02:00 New Revision: b34b7691facd89022e7fee174debdbd2bf7920f3 URL: https://github.com/llvm/llvm-project/commit/b34b7691facd89022e7fee174debdbd2bf7920f3 DIFF:

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing eduucaldas wrote: > I

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This saves something like 20% latency on the AST build with a typical load of

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066 +int func3b(int *); +int func4(int a, float b); +int func4a(int, float); hlopko wrote: > func4 -> func4a > func4a -> func4b? Fixed, thanks. Repository: rG LLVM

[clang] 8beaba1 - [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

Author: Lucas Prates Date: 2020-06-03T11:39:27+01:00 New Revision: 8beaba13b8a61697008854b82ed3b45377af9d9d URL: https://github.com/llvm/llvm-project/commit/8beaba13b8a61697008854b82ed3b45377af9d9d DIFF: https://github.com/llvm/llvm-project/commit/8beaba13b8a61697008854b82ed3b45377af9d9d.diff

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 268105. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. In D80950#2069733 , @curdeius wrote: > The change seems to me technically sound, but I'm not sure of the scope of > its effects. There might be users that rely on this behavior. On the other > hand, adding an option to

[PATCH] D81040: Split syntax tree tests into more granular ones

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7d5dd31fc6f: Split syntax tree tests into more granular ones (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr updated this revision to Diff 268104. gribozavr added a comment. Address code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/ https://reviews.llvm.org/D81040 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268116. njames93 added a comment. Included more builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files:

[clang] a2f32bf - [clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions.

Author: Bruno Ricci Date: 2020-06-03T12:35:12+01:00 New Revision: a2f32bfcc7cd6828785011ce90f6e0314d096e89 URL: https://github.com/llvm/llvm-project/commit/a2f32bfcc7cd6828785011ce90f6e0314d096e89 DIFF: https://github.com/llvm/llvm-project/commit/a2f32bfcc7cd6828785011ce90f6e0314d096e89.diff

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81019/new/ https://reviews.llvm.org/D81019

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske added a comment. There may be still a problem somewhere else. I think assume of "a" and "a==0" should have the same results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 268082. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80366/new/ https://reviews.llvm.org/D80366 Files:

[PATCH] D80877: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fa0a9f7f3e: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + vsavchenko wrote: > Szelethus wrote: > > baloghadamsoftware wrote: >

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

balazske added a comment. Here is an improved fix for the problem: D81061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing

[PATCH] D81040: Split syntax tree tests into more granular ones

hlopko accepted this revision. hlopko added a comment. Thanks for working on this! :) Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066 +int func3b(int *); +int func4(int a, float b); +int func4a(int, float); func4 -> func4a func4a -> func4b?

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll created this revision. simoll added reviewers: hfinkel, erichkeane, craig.topper, rsandifo-arm, kaz7, k-ishizaka. simoll added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a reviewer: rengolin. simoll updated this revision to Diff 268140. simoll

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

curdeius added a comment. I would have nothing against if you'd added this option and we kept current behaviour by default. The only drawback is the (bit of) complexity it adds bit that seems justified to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. In D69825#2063979 , @dim wrote: > FWIW, this change causes > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630#c18. > > For some reason, not

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80536/new/ https://reviews.llvm.org/D80536

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:39 +"__builtin_classify_type", +// "__builtin_va_start", +// "__builtin_stdarg_start", I think we may want to keep this one as

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + baloghadamsoftware wrote: > NoQ wrote: > > What's the point of overriding one pure virtual

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:127-129 +// Despite the previous assumptions for non-zero and positiveness, +// this value might be zero or negative. +// At least check for zero again.

[clang-tools-extra] add51e1 - [clang-tidy] add new check readability-use-anyofallof

Author: Matthias Gehre Date: 2020-06-03T12:19:06+02:00 New Revision: add51e152aa6dc3aa7a51901a099b2ebe8cfe377 URL: https://github.com/llvm/llvm-project/commit/add51e152aa6dc3aa7a51901a099b2ebe8cfe377 DIFF:

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre updated this revision to Diff 268120. mgehre added a comment. Implemented njames93's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files:

[PATCH] D81075: [ASTMatchers] Fix crash with HasName and HasAnyName

njames93 created this revision. njames93 added reviewers: klimek, sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes crashes caused by matching fully qualified RecordDecls inside Function bodies. See https://bugs.llvm.org/show_bug.cgi?id=43639. I'm still unsure

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:369 + Inputs.Index && !BuildDir.getError()) { auto Style = getFormatStyleForFile(Filename, Inputs.Contents, VFS.get()); auto Inserter = std::make_shared( while

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 268131. baloghadamsoftware added a comment. Comment fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + NoQ wrote: > What's the

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

gribozavr2 added a comment. This change broke the build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/29716. The build is already fixed by https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc. Please always run `ninja check-all` before

[PATCH] D77168: Add a flag to debug automatic variable initialization

llozano added a comment. In D77168#2070083 , @MaskRay wrote: > In D77168#2070049 , @jcai19 wrote: > > > In D77168#2069783 , @MaskRay wrote: > > > > > Do we have a mechanism

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:6158 public: - TypoExpr(QualType T) : Expr(TypoExprClass, T, VK_LValue, OK_Ordinary) { + TypoExpr(QualType T, SourceLocation Start, SourceLocation End) + : Expr(TypoExprClass, T, VK_LValue,

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice find, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 accepted this revision. njames93 added a comment. LGTM, but I wouldn't say no to a test case using `(Limit) -= 1`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang.

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr updated this revision to Diff 268100. gribozavr added a comment. Refreshing this patch after pushing the patch that this one depends on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81040/new/ https://reviews.llvm.org/D81040 Files:

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGb34b7691facd: Syntax tree: ignore implicit expressions at the top level of statements (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d7d5dd3 - Split syntax tree tests into more granular ones

Author: Dmitri Gribenko Date: 2020-06-03T11:17:11+02:00 New Revision: d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a URL: https://github.com/llvm/llvm-project/commit/d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a DIFF:

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

This revision was automatically updated to reflect the committed changes. Closed by commit rGadd51e152aa6: [clang-tidy] add new check readability-use-anyofallof (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/

[clang-tools-extra] fd27401 - attempt to fix build after add51e152aa

Author: Nico Weber Date: 2020-06-03T06:49:50-04:00 New Revision: fd2740143e626ca32432aac0b51b2880a3b1e0bc URL: https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc DIFF: https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc.diff

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG8beaba13b8a6: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1108 + std::move(CI), + !CompletingInPreamble ? &(Input.Preamble.Preamble) : nullptr,

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + baloghadamsoftware wrote: > vsavchenko wrote: > > Szelethus wrote: > > > baloghadamsoftware wrote: > > > > Szelethus wrote: > > > > >

[PATCH] D80876: [clang] Default to windows response files when running on windows

mati865 added a comment. I don't have strong opinion here as I don't know this topic well (things just worked so far). That said if Clang stops working as a drop-in replacement for GCC with commonly used build systems, MSYS2 will have to carry one more patch to bring back old behaviour.

[clang-tools-extra] 65fa0a9 - [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

Author: Nathan James Date: 2020-06-03T09:23:32+01:00 New Revision: 65fa0a9f7f3e6090e335c14f9edea19358d87613 URL: https://github.com/llvm/llvm-project/commit/65fa0a9f7f3e6090e335c14f9edea19358d87613 DIFF: https://github.com/llvm/llvm-project/commit/65fa0a9f7f3e6090e335c14f9edea19358d87613.diff

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Ping. Furthermore: how can I schedule another CI build with the newest version of the diff? When I go to the failed build from Harbormaster and I click restart, it rebuilds an older version of the diff. Thanks for the info! CHANGES SINCE LAST ACTION

[PATCH] D81080: [clang-tidy] Compile fix: Change CPlusPlus2a to CPlusPlus20.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The name of the option was changed here:

[PATCH] D81079: [clangd] Add std::move() to a return statement to please some compilers.

mboehme created this revision. mboehme added a reviewer: sammccall. mboehme added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This has been causing build errors in Swift CI.

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 4 inline comments as done. LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +llvm::APFloat Probability = Eval.Val.getFloat(); +if (!(Probability >= llvm::APFloat(0.0) || + Probability <=

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

mclow.lists added a comment. I've got nothing to say here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80743/new/ https://reviews.llvm.org/D80743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau added a comment. @amccarth The assert that I am getting is at line 1701 of VirtualFileSystem.cpp: assert(!isTraversalComponent(*Start) && !isTraversalComponent(From->getName()) && "Paths should not contain traversal components"); path is

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 268246. kmclaughlin added a comment. - Use APInt::trunc to truncate the constant in performSVEAndCombine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/ https://reviews.llvm.org/D79587 Files: llvm/include/llvm/CodeGen/ValueTypes.h

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. In D80450#2071696 , @tra wrote: > In D80450#2055463 , @tra wrote: > > > Is this patch supposed to be used with D79526 > > or instead of it? > > > ^^^ I

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam updated this revision to Diff 268264. saiislam added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. 1. Added wave32 as an additional alternate wave size. 2. Replaced long long with uint64_t and int with unsigned. 3. Removed unnecessary casts. 4. Moved

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268162. miyuki retitled this revision from "[clang][BFloat] add create/set/get/dup intrinsics" to "[clang][BFloat] Add create/set/get/dup intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Addressed reviewers' comments. CHANGES

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

arsenm added inline comments. Comment at: llvm/docs/CodingStandards.rst:1573 +Don't Use Braces on Simple Single-Statement Bodies of if/else/loop Statements +^ I would rather just ban

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein updated this revision to Diff 268164. hokein marked 2 inline comments as done. hokein added a comment. Revert an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81066/new/ https://reviews.llvm.org/D81066 Files:

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81090 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp Index: clang/test/AST/ast-dump-recovery.cpp

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1108 + std::move(CI), + !CompletingInPreamble ? &(Input.Preamble.Preamble) : nullptr, std::move(ContentsBuffer), std::move(VFS), IgnoreDiags); sammccall wrote: >

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 268165. LukeGeeson added a comment. ran `llvm/utils/update_llc_test_checks.py` on test to get proper `CHECK`s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files:

[PATCH] D81092: Add support for `nullptr` in SyntaxTrees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81092 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay updated this revision to Diff 268163. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80940/new/ https://reviews.llvm.org/D80940 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatTokenLexer.h

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome! > /workspace/llvm-project/clang/test/SemaCXX/cxx0x-initializer-constructor.cpp > Line 166: expected ';' after expression This is just a previously-uncaught typo in the test,

[clang] 7113271 - [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

Author: Paul Pelzl Date: 2020-06-03T19:06:04+03:00 New Revision: 7113271528a4c6efc8b57f25ead28f65b5e48757 URL: https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757 DIFF: https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757.diff

[clang] e941921 - [analyzer] Add support for ObjCIndirectCopyRestoreExpr.

Author: Paul Pelzl Date: 2020-06-03T19:06:04+03:00 New Revision: e94192198f8a949c7880620b06e9ef85d87ad4b3 URL: https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3 DIFF: https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3.diff

[PATCH] D81071: [analyzer] Add initial support for ObjCIndirectCopyRestoreExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe94192198f8a: [analyzer] Add support for ObjCIndirectCopyRestoreExpr. (authored by Paul Pelzl ppe...@apple.com, committed by dergachev.a). Herald added a project: clang. Herald added a subscriber:

[PATCH] D81072: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7113271528a4: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools. (authored by Paul Pelzl ppe...@apple.com, committed by dergachev.a). Herald added a project: clang. Herald added a

[clang] bee2c27 - [doc] Fix typo.

Author: Richard Smith Date: 2020-06-03T09:56:38-07:00 New Revision: bee2c2708f3e38261825439bc8b0fbe8b795854d URL: https://github.com/llvm/llvm-project/commit/bee2c2708f3e38261825439bc8b0fbe8b795854d DIFF: https://github.com/llvm/llvm-project/commit/bee2c2708f3e38261825439bc8b0fbe8b795854d.diff

[clang] ba4afe6 - [AIX] Change the default target CPU to power4 for AIX on Power

Author: Steven Wan Date: 2020-06-03T13:50:26-04:00 New Revision: ba4afe6f7a8453b24ee0b664e40d157d15a54034 URL: https://github.com/llvm/llvm-project/commit/ba4afe6f7a8453b24ee0b664e40d157d15a54034 DIFF: https://github.com/llvm/llvm-project/commit/ba4afe6f7a8453b24ee0b664e40d157d15a54034.diff

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:290 assert(DataLayout->getAllocaAddrSpace() == Private); + GridValues = &(llvm::GPU::AMDGPUGpuGridValues[0]); + LongGridValues = &(llvm::GPU::AMDGPUGpuLongGridValues[0]); Don't

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. We don't store physical absolute paths in pdbs if you hold things right. Look for /pdbsourcepath: in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html . rnk's change seems to store the main TU's dir as cwd, which likely either takes the dir from

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 268226. LukeZhuang added a comment. **updated 06/03/2020**: (1) fix bug of range checking in SemaChecking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268256. njames93 added a comment. - Detect va_list type VarDecls to warn on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files:

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2069962 , @jdoerfert wrote: > In D79744#2069786 , @arsenm wrote: > > > In D79744#2069774 , @arsenm wrote: > > > > > I think this is

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked an inline comment as done. aganea added a comment. I didn't change the PWD/CWD stored in `LF_BUILDINFO`, it has already been done by Reid a while ago: D53179 (it already stores absolute paths) However absolute paths are stored by design, if we

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4afe6f7a84: [AIX] Change the default target CPU to power4 for AIX on Power (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay added a comment. In D80940#2071247 , @curdeius wrote: > LGTM. > > For a second, I thought that you could simplify the code by removing this > @try condition (and calling the function > `FormatTokenLexer::tryTransformTryUsageForC()` only

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. > IMO this *is* actually a good heuristic: `<<` between string literals > indicates some intent to break, and when the stream is entirely literals the > formatting is good. I take your point, how do you feel about an option even if the default was

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev updated this revision to Diff 268242. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79948/new/ https://reviews.llvm.org/D79948 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. In D69825#2070926 , @hans wrote: > In D69825#2063979 , @dim wrote: > > > FWIW, this change causes > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular > >

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. In D80450#2055463 , @tra wrote: > Is this patch supposed to be used with D79526 > or instead of it? ^^^ I don't think this has been answered. I would like to test this change before it lands.

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. Bumping for review. Are there other trusted reviewers we could add the to review to help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Tested with tensorflow build. The patch- does not seem to break anything now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79237/new/ https://reviews.llvm.org/D79237

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre added a comment. Sorry for breaking the build and thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 ___ cfe-commits mailing list

[clang] 5f47865 - [doc] Fix use of ` where `` was intended in attribute docs.

Author: Richard Smith Date: 2020-06-03T10:52:55-07:00 New Revision: 5f478651eb31ac81acf9a521c3d44c5e1c4af49a URL: https://github.com/llvm/llvm-project/commit/5f478651eb31ac81acf9a521c3d44c5e1c4af49a DIFF: https://github.com/llvm/llvm-project/commit/5f478651eb31ac81acf9a521c3d44c5e1c4af49a.diff

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

hans added a comment. In D80833#2071818 , @aganea wrote: > I didn't change the PWD/CWD stored in `LF_BUILDINFO`, it has already been > done by Reid a while ago: D53179 (it > already stores absolute paths) That's

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1962-1964 + QualType TransformElaboratedType(TypeLocBuilder , ElaboratedTypeLoc TL) { +return TransformType(TLB, TL.getNamedTypeLoc()); + } Removing the qualifier seems like it might

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. I'm just investigating migrating D80222 away from the static methods. When I try to just add an OpenMPIRBuilder type and initialize it I get failures on the tests. I'm just adding in the module as you have `CGOpenMPRuntime.h`

  1   2   3   >