[clang] 3928436 - Attempt to fix hip-include-path.hip

Author: Yaxun (Sam) Liu Date: 2020-06-05T15:31:53-04:00 New Revision: 392843617acbce5baf6ca7c7fff8dbac58bf853f URL: https://github.com/llvm/llvm-project/commit/392843617acbce5baf6ca7c7fff8dbac58bf853f DIFF:

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dd83a923046: [ASan][Test] Fix globals test for Mach-O (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81306/new/

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. Can we do this conservatively only if something is changed within the function definition, and otherwise respect the global settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 268869. dang marked an inline comment as done. dang added a comment. Updating the patch with the correct merge base CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files:

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - TODO: Differ between NameQualifiers - TODO: Box all operators - Done: Treat NestedNameSpecifiers - Done: [Try] Unbox all operators Repository: rG LLVM Github Monorepo

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko created this revision. atrosinenko added reviewers: howard.hinnant, samsonov. Herald added subscribers: Sanitizers, mgorny. Herald added a project: Sanitizers. There are two different _generic_ lists of source files in the compiler-rt/lib/builtins/CMakeLists.txt. Now there is no

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

glider accepted this revision. glider added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ https://reviews.llvm.org/D80805

[clang] 5eedf07 - [apple clang] disable in-process CC1 to preserve crashlog compatibility

Author: Alex Lorenz Date: 2020-06-05T10:55:42-07:00 New Revision: 5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11 URL: https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11 DIFF: https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11.diff

[PATCH] D59520: [WebAssembly] Address review comments on r352930

thakis added a comment. This breaks check-clang everywhere, e.g. here http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/39534/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Awarning-flags.c Please take a look and revert if it takes a while to fix. Going forward,

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:14 int blacklisted_global; +int __attribute__((section(".foo.bar"))) sectioned_global; nickdesaulniers wrote: >

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077319 , @thakis wrote: > Still broken: http://45.33.8.238/win/16976/summary.html reverted. The difficulty for fixing these failures is that they only show up on some systems I do not have access and cannot see the

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Still broken: http://45.33.8.238/win/16976/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits mailing list

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077254 , @thakis wrote: > Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt I will try to fix it one more time. If it still fails I will revert it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added a comment. Hi, this broke check-clang on mac: http://45.33.8.238/mac/14998/step_7.txt Please take a look, and if it takes a while to fix please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/

[clang] 2dd83a9 - [ASan][Test] Fix globals test for Mach-O

Author: Marco Elver Date: 2020-06-05T23:08:11+02:00 New Revision: 2dd83a923046a5cd9585dbf9f90daeab6c37265c URL: https://github.com/llvm/llvm-project/commit/2dd83a923046a5cd9585dbf9f90daeab6c37265c DIFF: https://github.com/llvm/llvm-project/commit/2dd83a923046a5cd9585dbf9f90daeab6c37265c.diff

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader marked an inline comment as done. bader added a comment. In D80932#2074792 , @Anastasia wrote: > I think my biggest problem is that I don't understand how you can just run > C++ libraries on OpenCL devices. If we were able to compile plain C++ for

[clang] e987c37 - Fix lit tests hip-include-path.hip and hip-host-cpu-macros.cu

Author: Yaxun (Sam) Liu Date: 2020-06-05T13:21:35-04:00 New Revision: e987c372185d805e3a30097366af2c6f94bc0b29 URL: https://github.com/llvm/llvm-project/commit/e987c372185d805e3a30097366af2c6f94bc0b29 DIFF:

[PATCH] D59520: [WebAssembly] Address review comments on r352930

This revision was automatically updated to reflect the committed changes. Closed by commit rG931fcd3ba011: [WebAssembly] Improve clang diagnostics for wasm attributes (authored by sunfishcode). Changed prior to commit: https://reviews.llvm.org/D59520?vs=268329=268900#toc Repository: rG LLVM

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268903. jurahul added a comment. Fix Clang build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 268906. aganea added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

njames93 added a comment. I feel the refactoring of Aliasing should be in its own PR, with this being a child of it. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:38 + ifStmt(hasCondition(anyOf( +

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:78 ^^ +- New :doc:`misc-redundant-condition + ` check. Please keep alphabetical order in new checks list. Comment at:

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268905. jurahul added a comment. fix MLIR test failure due to change in error message. Reinstate the old message for a single parent case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added a comment. I have a couple of drive-by suggestions, up to @dang and @Bigcheese whether to incorporate them. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:137-142 +.Case("static", llvm::Reloc::Static) +.Case("pic",

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. This is still failing on Windows: http://45.33.8.238/win/16970/step_7.txt Please take a look and revert for now if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

This revision was automatically updated to reflect the committed changes. Closed by commit rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:14 int blacklisted_global; +int __attribute__((section(".foo.bar"))) sectioned_global; /Users/thakis/src/llvm-project/clang/test/CodeGen/asan-globals.cpp:14:28: error:

[PATCH] D81176: [HIP] Add default header and include path

This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG11d06b9511bd: [HIP] Add default header and include path (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 931fcd3 - [WebAssembly] Improve clang diagnostics for wasm attributes

Author: Dan Gohman Date: 2020-06-05T11:27:51-07:00 New Revision: 931fcd3ba011c27626a95e5e35b657763284882a URL: https://github.com/llvm/llvm-project/commit/931fcd3ba011c27626a95e5e35b657763284882a DIFF: https://github.com/llvm/llvm-project/commit/931fcd3ba011c27626a95e5e35b657763284882a.diff

[clang] 3aec298 - Revert "[WebAssembly] Improve clang diagnostics for wasm attributes"

Author: Dan Gohman Date: 2020-06-05T11:52:11-07:00 New Revision: 3aec298349fbc901a51b47004fb156090b3d6bce URL: https://github.com/llvm/llvm-project/commit/3aec298349fbc901a51b47004fb156090b3d6bce DIFF: https://github.com/llvm/llvm-project/commit/3aec298349fbc901a51b47004fb156090b3d6bce.diff

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 268872. dang added a comment. This is the good diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CompilerInvocation.h

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I patched this in and verified that it fixes the test on a mac I have access to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81306/new/

[clang] 0d4e243 - [WebAssembly] Improve clang diagnostics for wasm attributes

Author: Dan Gohman Date: 2020-06-05T14:32:51-07:00 New Revision: 0d4e243456809eabd6914669753eda242b5da4cb URL: https://github.com/llvm/llvm-project/commit/0d4e243456809eabd6914669753eda242b5da4cb DIFF: https://github.com/llvm/llvm-project/commit/0d4e243456809eabd6914669753eda242b5da4cb.diff

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis added a comment. In D80896#2076735 , @njames93 wrote: > How are you landing these changes, because the commit message isn't lining up > with the PR name? It was my fault: I hadn't changed a title in my local branch and pushed it with git.

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eedf07ab999: [apple clang] disable in-process CC1 to preserve crashlog compatibility (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 866ee23 - [KernelAddressSanitizer] Make globals constructors compatible with kernel

Author: Marco Elver Date: 2020-06-05T20:20:46+02:00 New Revision: 866ee2353f7d0224644799d0d1faed53c7f3a06d URL: https://github.com/llvm/llvm-project/commit/866ee2353f7d0224644799d0d1faed53c7f3a06d DIFF: https://github.com/llvm/llvm-project/commit/866ee2353f7d0224644799d0d1faed53c7f3a06d.diff

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

melver created this revision. melver added reviewers: nickdesaulniers, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use a portable section name, as for the test's purpose any name will do. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81306

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, stuij, ctetreau. Herald added subscribers: cfe-commits, tschuett. Herald added a reviewer: shafik. Herald added a reviewer: rengolin. Herald added a project: clang. The new SVE builtin type __SVBFloat16_t` is

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul added a comment. This is ready for review. The 2 Clang hip related failure are not caused by this change, and the offending change has been reverted now (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20200601/323475.html) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268929. jurahul added a comment. Remove {} in ScalarEvolution.cpp to match existing style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files:

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

melver added a comment. In D80805#2077396 , @thakis wrote: > Hi, this broke check-clang on mac: http://45.33.8.238/mac/14998/step_7.txt > > Please take a look, and if it takes a while to fix please revert while you > investigate. Sent

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666 +FirstNonOverlappingEmptyFieldHandled + } FirstNonOverlappingEmptyFieldStatus; + Instead of specifically tracking whether you've found an OverlappingEmpty field, could

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen updated this revision to Diff 268958. ychen added a comment. - Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files: clang/lib/Parse/ParsePragma.cpp

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen marked 4 inline comments as done. ychen added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2941 LoopHintTok.setKind(tok::annot_pragma_loop_hint); -LoopHintTok.setLocation(PragmaName.getLocation()); +LoopHintTok.setLocation(Introducer.Loc);

[PATCH] D81313: Fix handling of constinit thread_locals with a forward-declared type.

rsmith added a comment. Your FIXME is a concern. I think it would be preferable for this function to require as a precondition that the type is complete. If the only call where that isn't true is the call from `ItaniumCXXABI::usesThreadWrapperFunction`, it seems reasonable to perform a

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 268881. aganea marked 11 inline comments as done. aganea added a comment. Addressed comments (see inline). Ensured the generated .OBJ contains relative paths when passing `-fdebug-compilation-dir . -no-canonical-prefixes`. Repository: rG LLVM Github

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

atrosinenko created this revision. atrosinenko added a reviewer: howard.hinnant. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. This patch changes types of some integer function arguments or return values from `si_int` to the default `int` type (`typedef`ed to

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2073458 , @hans wrote: > a. The compiler path is only absolute because it was absolute when put into > argv[0] right? I don't see anything in the code that makes it absolute? I > imagine most build systems will invoke

[clang] ee60847 - Attempt to fix hip-include-path.hip

Author: Yaxun (Sam) Liu Date: 2020-06-05T14:36:36-04:00 New Revision: ee608478623a716da38cd09383f640f3a96f8d61 URL: https://github.com/llvm/llvm-project/commit/ee608478623a716da38cd09383f640f3a96f8d61 DIFF:

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG866ee2353f7d: [KernelAddressSanitizer] Make globals constructors compatible with kernel (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 268893. saghir added a comment. Updated the diff based on latest changes in master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80758/new/ https://reviews.llvm.org/D80758 Files:

[clang] 672ed53 - [codeview] Put !heapallocsite on calls to operator new

Author: Reid Kleckner Date: 2020-06-05T12:52:38-07:00 New Revision: 672ed5386024ba5cee53e19d637b7920a4889837 URL: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837 DIFF: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837.diff

[PATCH] D81313: Fix handling of constinit thread_locals with a forward-declared type.

jyknight created this revision. jyknight added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. ItaniumCXXABI::usesThreadWrapperFunction calls VarDecl::needsDestruction, which calls QualType::isDestructedType, which checks

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. We have a very similar problem with the constrained FP intrinsics where the use of the intrinsics anywhere in a function requires (1) an attribute to be set on the function and (2) all the other code in the function to be emitted with intrinsics. What I've been

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf39e12a06b60: PR34581: Dont remove an if (p) guarding a call to operator delete(p) under… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D79378?vs=261963=268971#toc

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cd264068ee: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

efriedma added a comment. On a normal, stack-based machine, there are two ways to pass an aggregate to a function: directly, or indirectly. Directly means something like "byval" or "preallocated": the value of the pointer is not a value the caller can control, but instead refers to some fixed

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan added a comment. The unit test failure (`instrprof-gcov-multithread_fork.test`) in pre merge checks is caused by another commit. See http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

stevewan added a comment. Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Even fails on some linux bots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/49595/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ahip-host-cpu-macros.cu Re-reverted in 2920348063221a0603ee96909536bc480f43a7ac

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm added a comment. In D81311#2077868 , @rjmccall wrote: > Most of the generalized optimization properties of this attribute seem to be > redundant with existing attributes. What are the properties you're trying to > convey exactly? The argument

Re: [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

On Thu, 4 Jun 2020 at 23:45, Jonas Devlieghere via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey Richard, > > It appears this broke the lldb bots: > > http://lab.llvm.org:8011/builders/lldb-x86_64-debian > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ > That's not

[clang] 825e3bb - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: 825e3bb58082eafa8db87a9034379b88f892ce9d URL: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d DIFF: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d.diff

[clang] ebcbd5b - Set the captures on a CXXRecordDecl representing a lambda closure type

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: ebcbd5ba39c017bb621eefa3175a224aae85ddc8 URL: https://github.com/llvm/llvm-project/commit/ebcbd5ba39c017bb621eefa3175a224aae85ddc8 DIFF: https://github.com/llvm/llvm-project/commit/ebcbd5ba39c017bb621eefa3175a224aae85ddc8.diff

[clang] f39e12a - PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

Author: Richard Smith Date: 2020-06-05T17:13:43-07:00 New Revision: f39e12a06b6018db195848ca1f7bd01bf0240fac URL: https://github.com/llvm/llvm-project/commit/f39e12a06b6018db195848ca1f7bd01bf0240fac DIFF: https://github.com/llvm/llvm-project/commit/f39e12a06b6018db195848ca1f7bd01bf0240fac.diff

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale added a comment. In D80462#2077569 , @rjmccall wrote: > Can we do this conservatively only if something is changed within the > function definition, and otherwise respect the global settings? I'm not sure I understand what you mean.

[PATCH] D81315: [Draft] [Prototype] warning for default constructed unique pointer dereferences

vrnithinkumar created this revision. vrnithinkumar added reviewers: vsavchenko, xazax.hun, NoQ. Herald added subscribers: cfe-commits, martong, Charusso, rnkovacs. Herald added a project: clang. This is just a prototype review for my changes since I thought it will be easier to ask code related

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077333 , @yaxunl wrote: > In D81176#2077319 , @thakis wrote: > > > Still broken: http://45.33.8.238/win/16976/summary.html > > > reverted. > > The difficulty for fixing these

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. This is causing some tests under check-clang to fail, taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 ___ cfe-commits

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm created this revision. arsenm added reviewers: rjmccall, jdoerfert, efriedma, t-tye, yaxunl, scott.linder, rnk, spatel, lebedev.ri, nlopes, fhahn, hfinkel, Anastasia. Herald added subscribers: tpr, wdng. Herald added a project: LLVM. This allows tracking the in-memory type of a pointer

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

inglorion abandoned this revision. inglorion added a comment. Ok, thanks for clarifying. The benefit this would get us is not having to spell the flags differently depending on whether the frontend is clang or clang-cl. I figured this would fit in with all the -f options we already take and

[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4348 + /// Query for the use of constrained floating point math + bool isStrictFP() { return Builder.getIsFPConstrained(); } + How is this set that we don't end up also setting it

[clang] 1c44ace - Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after ebcbd5ba39c017bb621eefa3175a224aae85ddc8

Author: Fangrui Song Date: 2020-06-05T16:16:49-07:00 New Revision: 1c44ace1e517f8c852fd2bd1d92c6443b525b2e2 URL: https://github.com/llvm/llvm-project/commit/1c44ace1e517f8c852fd2bd1d92c6443b525b2e2 DIFF: https://github.com/llvm/llvm-project/commit/1c44ace1e517f8c852fd2bd1d92c6443b525b2e2.diff

[clang] 61cd264 - [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

Author: stevewan Date: 2020-06-05T19:55:28-04:00 New Revision: 61cd264068ee77ae4e7a503ecd93f0d9fc6120c8 URL: https://github.com/llvm/llvm-project/commit/61cd264068ee77ae4e7a503ecd93f0d9fc6120c8 DIFF: https://github.com/llvm/llvm-project/commit/61cd264068ee77ae4e7a503ecd93f0d9fc6120c8.diff

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. One more example failure: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 (Note I had re-reverted your reland, see the 2 comments above your comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid updated this revision to Diff 268991. Tridacnid added a comment. Add (Limit) -= 1 test cases to bugprone-infinite-loop tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files:

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mehdi_amini added a comment. In D81223#2076420 , @rcorcs wrote: > This patch standardizes the use of OptimizationLevel across PassBuilder, > PassManagerBuilder, LTO configuration, and LTO code generators. Even with > this patch, further work is still

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks updated this revision to Diff 268993. aeubanks added a comment. Update some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. Could you take a look again at the test changes? LTO + sanitizers doesn't work under NPM because [1] never ends up calling the passes registered via registerOptimizerLastEPCallback(). [1]

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. Most of the generalized optimization properties of this attribute seem to be redundant with existing attributes. What are the properties you're trying to convey exactly? The argument is a pointer to memory of a certain size and alignment, and that memory is known to

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

efriedma added a comment. I think the important bit here is that we need to distinguish between the C function types `void f(A)` and `void f(A*)`. If they're both lowered to pointers with the same type, we need an attribute to distinguish them. CHANGES SINCE LAST ACTION

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks created this revision. aeubanks added reviewers: leonardchan, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes pr33372.cpp under the new pass manager. ASan adds padding to globals. For example, it will change a {i32, i32, i32} to a {{i32,

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. The recommit again broke tests on mac and windows: http://45.33.8.238/win/17004/step_7.txt http://45.33.8.238/mac/15014/step_7.txt This is like the 8th distinct build break today (most not yours, of course). Let's revert and call it a weekend, and try again next week.

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 268840. Xiangling_L added a comment. Replace `int` with an more self-explanatory enum; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 Files:

[PATCH] D81272: [Clang-Tidy] New check `misc-redundant-condition`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: aaron.ballman, gribozavr2. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, steakhal, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a

[PATCH] D81272: [Clang-Tidy] New check `misc-redundant-condition`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. This check was made upon user request. I think it is a good base that can later be extended also for the negated cases (where the code inside the inner `if` never executes). That case is even more

[PATCH] D81273: [WIP] Enable new pass manager as default DO NOT SUBMIT

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Just for bot testing Depends on D81175 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81273 Files:

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

jdenny added a comment. This looks like a continuation of the work started in D61643 (which makes the loc of `#pragma` available to pragma handlers) and D61509 (which changes the start loc for OpenMP pragmas from `omp` to

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thank you. I'm trying to balance stability with getting the fixes I need and so have been avoiding the "bleeding edge". I find that unfortunately the newest code tends to be "unstable", as those releases are rightfully named, and I need clangd for my daily work. There

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

njames93 added a comment. How are you landing these changes, because the commit message isn't lining up with the PR name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896

Re: [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

Hey Richard, It appears this broke the lldb bots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ It's hitting an assertion in llvm-project/clang/include/clang/AST/DeclCXX.h:887: Assertion

[clang] df53f09 - Revert "PR46209: properly determine whether a copy assignment operator is"

Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: df53f09056b0f6a91029cae5f1cdc941c21b URL: https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b DIFF:

[clang] 70ad03d - Revert "Set the captures on a CXXRecordDecl representing a lambda closure type"

Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: 70ad03d93818532ef19f149f8ff89bcd8af80163 URL: https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163 DIFF:

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mehdi_amini added a comment. > This patch is the first in the sequence of three patches for supporting size > optimization with LTO. Can you start by describing the problem you're trying to solve and the overall approach, including the end-to-end user-interface? Repository: rG LLVM Github

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. In D74025#2073946 , @jaafar wrote: > I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or > 10.0.1-rc1 either. Is there any chance it can be released? unfortunately, it is not picked up in 10.0.0 release,

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

rcorcs created this revision. rcorcs added a reviewer: hiraditya. rcorcs added projects: LLVM, lld. Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst,

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:660 + /// with [[no_unique_attr]] Empty CXXRD invovled in the CXXRD. + int IsRealFirstMember; + Please explain here what the different values (-1, 0, 1, 2) mean. Or use an

[clang] 6dd738e - [StackSafety,NFC] Switch tests to aarch64

Author: Vitaly Buka Date: 2020-06-05T00:24:02-07:00 New Revision: 6dd738e2f0609f7d3313b574a1d471263d2d3ba1 URL: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1 DIFF: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1.diff

[clang] 78702de - [Driver] Migrate some -f/-fno options to use OptInFFlag and OptOutFFlag

Author: Fangrui Song Date: 2020-06-04T23:25:19-07:00 New Revision: 78702dec3bbc9eadf7c0469f2c54e5c105ffea78 URL: https://github.com/llvm/llvm-project/commit/78702dec3bbc9eadf7c0469f2c54e5c105ffea78 DIFF: https://github.com/llvm/llvm-project/commit/78702dec3bbc9eadf7c0469f2c54e5c105ffea78.diff

  1   2   >