[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

mboehme added a comment. In D81392#2088131 , @rsmith wrote: > I think renaming the flag in the AST dump output would be a good idea, though > it'll be a lot of churn in the tests. I would prefer that we continue to dump > a marker only if the

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 270335. baloghadamsoftware retitled this revision from "[Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling" to "[Analyzer] Avoid handling of LazyCompundVals in IteratorModeling". baloghadamsoftware edited the summary of this

[PATCH] D81720: [clangd] Change prepareCompilerInstance to take an FSProvider

kadircet updated this revision to Diff 270333. kadircet added a comment. - Use Cmd.Directory when creating includefixer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81720/new/ https://reviews.llvm.org/D81720 Files:

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

anil9 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:305 +// P10 Vector Centrifuge +BUILTIN(__builtin_altivec_vcfuged, "V2ULLiV2ULLiV2ULLi", "") nit : // P10 Vector Centrifuge built-in. Comment at:

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/WebAssembly.h:139 +// Emscripten targets. +return getTriple().isOSEmscripten(); + } I'm not sure we need

[clang] 2e92b39 - [clang] Rename Decl::isHidden() to isUnconditionallyVisible().

Author: Martin Boehme Date: 2020-06-12T09:33:42+02:00 New Revision: 2e92b397ae4bd846d34d151749ef09c1a1b81dab URL: https://github.com/llvm/llvm-project/commit/2e92b397ae4bd846d34d151749ef09c1a1b81dab DIFF: https://github.com/llvm/llvm-project/commit/2e92b397ae4bd846d34d151749ef09c1a1b81dab.diff

[PATCH] D81721: [SVE] Ensure proper mangling of ACLE tuple types

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, c-rhodes, efriedma. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. sdesmalen added a parent revision: D81459: [SveEmitter]

[PATCH] D81720: [clangd] Change prepareCompilerInstance to take an FSProvider

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This makes API easier to use by moving setcwd and fscache setup into it. Also ensures no side effects

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It was used inside buildCompilerInvocation to speed up stats. But preambleStatCache doesn't contain

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar added a comment. In D78024#2087800 , @Higuoxing wrote: > > btw, do you know why FileCheck seems intentionally allows the case when > > --check-prefixes=KNOWN,UNKNOWN? > > I've mentioned in the description of D78110 > >

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

asb added a comment. In D79155#2088191 , @efriedma wrote: > Please add a comment explaining what OffsetInRecord means; then LGTM. Thanks. It's not easy to follow, but having stepped through it I agree with yu that it is the size in bits of the current

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270328. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. @eugenis review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files:

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D81474: Handle delayed-template-parsing functions imported into a non-dtp TU

sammccall added a comment. Thanks for reviewing! Going to land this now as the bug is surfaced by other pending changes. In D81474#2087095 , @kadircet wrote: > Looking at this some more, it looks like whenever clang is building a TU > prefix(preamble),

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428

[PATCH] D81721: [SVE] Ensure proper mangling of ACLE tuple types

sdesmalen added a comment. See https://github.com/ARM-software/abi-aa/blob/master/aapcs64/aapcs64.rst#appendix-c-mangling for details on the mangling rules. I thought it would be easier to review if I kept these changes separate from D81459 . Repository:

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } jtmott-intel wrote: > rjmccall wrote: > > I know this is existing code, but this is a broken mess. Please change > >

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

NoQ added a comment. No, please don't do this. The checker should *always* know the nature of the object in advance. If you look at the SVal in order to figure out the nature of the object, you are unable to discriminate between objects of completely different nature that are intentionally

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

dnsampaio added a comment. Perhaps we could move to making half a valid type for the arm back-end as follow up patches. Allowing half as argument through the IR is already a step to that direction. IMO this patch is already quite big and it excels in fixing the bugs it proposed. Repository:

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3dcfd482cb17: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets… (authored by asb).

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

eugenis added a comment. In D81678#2088284 , @efriedma wrote: > I usually like to start reading this sort of patch with the proposed LangRef > change, but I'm not seeing one. > > There are a couple of related issues here in the existing representation of

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added a comment. As it stands, this attribute is applied whether or not msan is enabled, specifically because we think it can be useful in other contexts. As for the negativity of this attribute, it's true that it would be more intuitive to have it be something like `fullinit` instead.

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

rsmith added a comment. It's not entirely clear to me what `partialinit` means. Does it mean that some bytes of the parameter might be undef / poison? Or does it mean that some bytes of the parameter that (for a struct parameter or array thereof) correspond to a struct member might be undef /

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

aqjune added a comment. Hi, this is really interesting. I was interested in statically analyzing whether a value is undef/poison, so I also thought about the existence of this attribute, but I never imagined that MSan would benefit from this attribute as well. > The partialinit attribute is,

[clang] 82a2122 - (PR46111) Properly handle elaborated types in an implicit deduction guide

Author: Erich Keane Date: 2020-06-12T05:32:13-07:00 New Revision: 82a21229da36bc53004dc54203e3bdeea718c942 URL: https://github.com/llvm/llvm-project/commit/82a21229da36bc53004dc54203e3bdeea718c942 DIFF: https://github.com/llvm/llvm-project/commit/82a21229da36bc53004dc54203e3bdeea718c942.diff

[clang] 33fb9cb - [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Author: Kirstóf Umann Date: 2020-06-12T14:59:48+02:00 New Revision: 33fb9cbe211d1b43d4b84edf34e11001f04cddf0 URL: https://github.com/llvm/llvm-project/commit/33fb9cbe211d1b43d4b84edf34e11001f04cddf0 DIFF: https://github.com/llvm/llvm-project/commit/33fb9cbe211d1b43d4b84edf34e11001f04cddf0.diff

[clang] e22f1c0 - [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Author: Kirstóf Umann Date: 2020-06-12T14:08:38+02:00 New Revision: e22f1c02a27f4471af1b9ae3aa6d8324b86ab2d0 URL: https://github.com/llvm/llvm-project/commit/e22f1c02a27f4471af1b9ae3aa6d8324b86ab2d0 DIFF: https://github.com/llvm/llvm-project/commit/e22f1c02a27f4471af1b9ae3aa6d8324b86ab2d0.diff

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

This revision was automatically updated to reflect the committed changes. Closed by commit rG82a21229da36: (PR46111) Properly handle elaborated types in an implicit deduction guide (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

Author: Haojian Wu Date: 2020-06-12T15:42:29+02:00 New Revision: e4b3fc18d33199e2081d300f14687d81be48b6a0 URL: https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0 DIFF: https://github.com/llvm/llvm-project/commit/e4b3fc18d33199e2081d300f14687d81be48b6a0.diff

[PATCH] D81734: Initial smart pointer check

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. vrnithinkumar abandoned this revision. vrnithinkumar added a comment. It was a mistake I was supposed to update an existing review. first time use of arc Repository: rG LLVM

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:8 +// RUN: FileCheck %s struct test { Looks like the non-inline comments are easier to get ignored and missed, so I will copy paste the non-inlined comment I previously had: ```

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2089680 , @yaxunl wrote: > In D81713#2089672 , @arsenm wrote: > > > Can you add tests for this? Is this also sufficient with the directory > > layout change? > > > You mean does

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein updated this revision to Diff 270402. hokein added a comment. rebase to master and adjust the diagnostic tests after "-frecovery-ast" is flipped on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81090/new/ https://reviews.llvm.org/D81090

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein added a comment. ok, the current status seems quite stable now. We rolled it out to all our internal users for a while, didn't see big crashes. I'm going to land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov added a comment. @xazax.hun, I've made performance measurements you concerned about. Could you look at it and make decision on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

sammccall added a comment. As discussed offline, the cache is always missing today, but we do have reason to believe we're doing a fair amount of IO in `buildCompilerInvocation` and it should be very cacheable. So dropping the cache here might be the wrong direction vs fixing it. I don't know:

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

mboehme created this revision. mboehme added a reviewer: rsmith. mboehme added a project: clang. Herald added a subscriber: cfe-commits. For context, see https://bugs.llvm.org/show_bug.cgi?id=46248 This handles only the easy cases in Sema/SemaDeclObjC.cpp. The cases in AST/DeclObjC.{h,cpp} will

[clang] 05ed3ef - Handle delayed-template-parsing functions imported into a non-dtp TU

Author: Sam McCall Date: 2020-06-12T16:09:38+02:00 New Revision: 05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5 URL: https://github.com/llvm/llvm-project/commit/05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5 DIFF: https://github.com/llvm/llvm-project/commit/05ed3efc2ac7b34bd62b1cbac88ff9a47b649cc5.diff

[clang] b2a37cf - [Analyzer] Replace `assert` with `ASSERT_TRUE` in a unit test to silence warnings

Author: Adam Balogh Date: 2020-06-12T17:09:34+02:00 New Revision: b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc URL: https://github.com/llvm/llvm-project/commit/b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc DIFF: https://github.com/llvm/llvm-project/commit/b2a37cfe2bda0bc8c4d2e981922b5ac59c429bdc.diff

[clang-tools-extra] 58ea105 - [AST][RecoveryExpr] Build recovery expressions by default for C++.

Author: Haojian Wu Date: 2020-06-12T15:21:38+02:00 New Revision: 58ea1059df97c71c023ec9de3940040c2c9bbc64 URL: https://github.com/llvm/llvm-project/commit/58ea1059df97c71c023ec9de3940040c2c9bbc64 DIFF: https://github.com/llvm/llvm-project/commit/58ea1059df97c71c023ec9de3940040c2c9bbc64.diff

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. In D60620#2067134 , @tra wrote: > Do you expect users to specify these IDs? How do you see it being used in > practice? I think you do need to implement a user-friendly shortcut and > expand it to the detailed offload-id

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas added a comment. Hi @efriedma, From @SjoerdMeijer's comment and the links he pointed to, it seems to me that making `f16` types legal for all ARM subtargets would be a major undertaking and far from trivial to implement. It's also not clear to me how significant would be the returns

[clang-tools-extra] 4160f4c - Reland [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

Author: Sam McCall Date: 2020-06-12T16:18:26+02:00 New Revision: 4160f4c37615f6d5b7615666eb202d9cbb58f4bb URL: https://github.com/llvm/llvm-project/commit/4160f4c37615f6d5b7615666eb202d9cbb58f4bb DIFF: https://github.com/llvm/llvm-project/commit/4160f4c37615f6d5b7615666eb202d9cbb58f4bb.diff

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

efriedma added a reviewer: aqjune. efriedma added a comment. Herald added a subscriber: wuzish. I usually like to start reading this sort of patch with the proposed LangRef change, but I'm not seeing one. There are a couple of related issues here in the existing representation of IR: 1. The

[PATCH] D80901: [analyzer][NFC] Change checker dependency unit tests to check for the registration order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd61b1f8534c6: [analyzer][NFC] Change checker dependency unit tests to check for the… (authored by Szelethus).

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:439-441 + // Do not handle untracked stream. It is probably escaped. + if (!State->get(StreamSym)) +return; balazske wrote: > Szelethus wrote: > > How

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

ASDenysPetrov added a comment. Herald added subscribers: martong, steakhal. @Charusso I think this patch may fix this bug https://bugs.llvm.org/show_bug.cgi?id=25284 Could you please verify and close it if so? At least I couldn't reproduce it on the latest build. Repository: rG LLVM Github

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. Thank you for taking a look on this! Let me explain! An iterator may be implemented by multiple ways. It can be a simple pointer, which means that it is a basic type passed by value both as argument and return value. Thus here `getArgSVal()` and

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 270370. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { njames93 wrote: > jkorous wrote: > > aaron.ballman

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ea1059df97: [AST][RecoveryExpr] Build recovery expressions by default for C++. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. Can you add tests for this? Is this also sufficient with the directory layout change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 ___ cfe-commits mailing list

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG33fb9cbe211d: [analyzer][NFC] Dont allow dependency checkers to emit diagnostics (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78126?vs=262387=270372#toc Repository: rG

[PATCH] D81474: Handle delayed-template-parsing functions imported into a non-dtp TU

This revision was automatically updated to reflect the committed changes. Closed by commit rG05ed3efc2ac7: Handle delayed-template-parsing functions imported into a non-dtp TU (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl added a comment. In D81713#2089672 , @arsenm wrote: > Can you add tests for this? Is this also sufficient with the directory layout > change? You mean does this work after we move device lib from /opt/rocm/lib to /opt/rocm/amdgcn/bitcode ?

[PATCH] D81734: Initial smart pointer check

vrnithinkumar abandoned this revision. vrnithinkumar added a comment. It was a mistake I was supposed to update an existing review. first time use of arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81734/new/ https://reviews.llvm.org/D81734

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 270351. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h

[clang] d61b1f8 - [analyzer][NFC] Change checker dependency unit tests to check for the registration order

Author: Kirstóf Umann Date: 2020-06-12T12:43:56+02:00 New Revision: d61b1f8534c6ee0f9dad528cda641d1429920ed4 URL: https://github.com/llvm/llvm-project/commit/d61b1f8534c6ee0f9dad528cda641d1429920ed4 DIFF: https://github.com/llvm/llvm-project/commit/d61b1f8534c6ee0f9dad528cda641d1429920ed4.diff

[PATCH] D80901: [analyzer][NFC] Change checker dependency unit tests to check for the registration order

Szelethus added a comment. I hesitated on whether to make a revision out of this rather than just committing it -- its nothing clever and is clearly superior the the previous state of the file. I hope you don't mind if I commit this as-is. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 270391. vrnithinkumar retitled this revision from "[analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences" to "[analyzer] Warning for default constructed unique pointer dereferences". vrnithinkumar added a comment.

[PATCH] D81740: [AArch32]: BFloat MatMul Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: stuij, t.p.northover, SjoerdMeijer, sdesmalen, fpetrogalli. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D81486: [ARM][BFloat]

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 ___ cfe-commits mailing list

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 270387. LukeGeeson added a comment. - removed unnecessary contents of test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D81739: [clangd] Turn on RecoveryAST for clangd by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81739 Files:

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar marked 38 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:31 namespace { -class SmartPtrModeling : public Checker { +struct RegionState { +private: vsavchenko wrote:

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

hokein updated this revision to Diff 270413. hokein added a comment. rebase and adjust the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81163/new/ https://reviews.llvm.org/D81163 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270445. dang edited the summary of this revision. dang added a comment. Implemented a draft of normalizer generation for simple enum based options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. Bumping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2079419 , @aaron.ballman wrote: > In D80961#2079044 , @klimek wrote: > > > In D80961#2076242 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added inline comments. Comment at: clang/include/clang/AST/Type.h:2139-2141 + /// Check if this type has only two possible values, and so may be lowered to + /// a bool. + bool hasBooleanRepresentation() const; rsmith wrote: > This seems like a

[PATCH] D81750: [analyzer] Don't allow hidden checkers to emit diagnostics

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, dcoughlin, martong, balazske, baloghadamsoftware, xazax.hun. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

saugustine added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:43 #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" #include "llvm/ADT/ArrayRef.h"

[PATCH] D81745: [analyzer][MallocChecker] PR46253: Correctly recognize standard realloc

Szelethus created this revision. Szelethus added reviewers: NoQ, hokein, baloghadamsoftware, balazske, xazax.hun, dcoughlin, vsavchenko, martong. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy,

Re: [clang] 1eddce4 - Fix non-determinism issue with implicit lambda captures.

On Fri, 12 Jun 2020 at 09:17, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Erich Keane > Date: 2020-06-12T09:16:43-07:00 > New Revision: 1eddce4177cfddc86d4696b758904443b0b4f193 > > URL: >

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2089760 , @arsenm wrote: > In D81713#2089680 , @yaxunl wrote: > > > In D81713#2089672 , @arsenm wrote: > > > > > Can you add tests for this?

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:12 ~test(); -} t; +} t1, t2; I suggest adding also one each of the following: - a dynamic initialization of a non-local variable of type `int` - a `constinit`

[clang] c32d261 - Don't diagnose a redeclaration of a deduction guide if the prior

Author: Richard Smith Date: 2020-06-12T10:29:01-07:00 New Revision: c32d261e27c8c63653799fa6e411c373bd81d519 URL: https://github.com/llvm/llvm-project/commit/c32d261e27c8c63653799fa6e411c373bd81d519 DIFF: https://github.com/llvm/llvm-project/commit/c32d261e27c8c63653799fa6e411c373bd81d519.diff

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2090265 , @tra wrote: > In D81713#2089760 , @arsenm wrote: > > > In D81713#2089680 , @yaxunl wrote: > > > > > In D81713#2089672

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

erik.pilkington created this revision. erik.pilkington added a reviewer: rjmccall. Herald added subscribers: ributzka, dexonsmith, jkorous. We were previously bypassing the conditional expression special case for binary conditional expressions. Also, dig through the OpaqueValueExpr on the left

[PATCH] D81739: [clangd] Turn on RecoveryAST for clangd by default.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:285 +desc("Preserve expressions in AST for broken code (C++ only)."), +init(true), }; Ah actually in other options, we set the default in the struct and reference

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

kadircet added a comment. I am not the best person to review this, but dig a little bit into your issues and history of this file. Your diagnosis and fix seems reasonable, AFAICT the existing caching behavior was chosen to optimize files with many macro invocations that are expanding into

[clang] 1eddce4 - Fix non-determinism issue with implicit lambda captures.

Author: Erich Keane Date: 2020-06-12T09:16:43-07:00 New Revision: 1eddce4177cfddc86d4696b758904443b0b4f193 URL: https://github.com/llvm/llvm-project/commit/1eddce4177cfddc86d4696b758904443b0b4f193 DIFF: https://github.com/llvm/llvm-project/commit/1eddce4177cfddc86d4696b758904443b0b4f193.diff

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

rsmith added a comment. In D81392#2089251 , @mboehme wrote: > In D81392#2088131 , @rsmith wrote: > > > Maybe we should dump the ModuleOwnershipKind in general, not only an > > indicator of whether it's Visible or

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:807 void CodeGenFunction::GenerateCXXGlobalDtorsFunc( llvm::Function *Fn, This function is to be renamed. Comment at:

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun accepted this revision. xazax.hun added a comment. I would not call the results of the measurement within the margin of error but the results do not look bad. Unless there is some objection from someone else I am ok with committing this but please change the title of revision before

[clang] 270d580 - [analyzer] Avoid unused variable warning in opt build

Author: Jacques Pienaar Date: 2020-06-12T09:48:49-07:00 New Revision: 270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa URL: https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa DIFF:

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

saugustine created this revision. saugustine added reviewers: echristo, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

kadircet added a comment. Also forgot to say, thanks a lot for taking your time to investigate this issue and coming up with a patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681

[clang] 58de24c - [AMDGPU] Sorted targets in amdgpu-features.cl. NFC.

Author: Stanislav Mekhanoshin Date: 2020-06-12T11:57:40-07:00 New Revision: 58de24ce6cb413afea1470ec183f3fc5d9ca6817 URL: https://github.com/llvm/llvm-project/commit/58de24ce6cb413afea1470ec183f3fc5d9ca6817 DIFF:

[clang] e640598 - Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

Author: Sterling Augustine Date: 2020-06-12T12:10:13-07:00 New Revision: e64059828f19f629081220bffeb3ef7582870111 URL: https://github.com/llvm/llvm-project/commit/e64059828f19f629081220bffeb3ef7582870111 DIFF:

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64059828f19: Revert [analyzer][NFC] Dont allow dependency checkers to emit diagnostics (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl added a comment. In D81627#2090499 , @tra wrote: > LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. @arsenm Are you OK with fixing -fgpu-rdc in a separate patch? The fix for that is orthogonal to the current patch.

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, dcoughlin, xazax.hun, balazske, martong, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Reverted in rGe64059828f19f629081220bffeb3ef7582870111 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. In D60620#2089722 , @yaxunl wrote: > In D60620#2067134 , @tra wrote: > > > Do you expect users to specify these IDs? How do you see it being used in > > practice? I think you do need to

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270517. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; zixuw wrote: >

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270536. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

  1   2   >