[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 272621. hliao added a comment. Rebase to trunk. All prerequisites are landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files:

[PATCH] D82369: [SveEmitter] Add verify-checks to Clang bfloat16 tests

sdesmalen created this revision. sdesmalen added reviewers: c-rhodes, fpetrogalli, kmclaughlin. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82369 Files:

[clang-tools-extra] 82a882d - Silence gcc warning about extra "; " [NFC]

Author: Mikael Holmen Date: 2020-06-23T11:28:34+02:00 New Revision: 82a882db083236a02f7d12fc7016bddb2b47488d URL: https://github.com/llvm/llvm-project/commit/82a882db083236a02f7d12fc7016bddb2b47488d DIFF: https://github.com/llvm/llvm-project/commit/82a882db083236a02f7d12fc7016bddb2b47488d.diff

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_sel.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. lh123 retitled this revision from "[CodeComplete] Tweak code completion for "typename" to "[CodeComplete] Tweak code completion

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2108423 , @uweigand wrote: > > Line 4 here fails on s390x but not on other Unix flavors, see: > >

[clang] 2168d69 - Mangle.cpp - fix implicit Format.h dependency. NFC.

Author: Simon Pilgrim Date: 2020-06-23T14:42:30+01:00 New Revision: 2168d69d1f304cb2ab5eec2a6c55cf8c1498f08d URL: https://github.com/llvm/llvm-project/commit/2168d69d1f304cb2ab5eec2a6c55cf8c1498f08d DIFF: https://github.com/llvm/llvm-project/commit/2168d69d1f304cb2ab5eec2a6c55cf8c1498f08d.diff

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko updated this revision to Diff 272639. atrosinenko added a comment. Address the review comments. Now include directories should be set in a much more similar way to msp430-gcc v8.3.1. The test was added as well. The most significant difference is that Clang adds one **extra**

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

uweigand added a comment. > Line 4 here fails on s390x but not on other Unix flavors, see: > http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33346/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-codeview-buildinfo.c > > @thakis @uweigand Any ideas would could go wrong

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

uweigand added a comment. Ping? I'd really appreciate feedback about this ABI issue, in particular from other affected target maintainers ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

atrosinenko added a comment. > could you please clarify what exactly is wrong? Windows not building > 'compiler-rt'? Yes. Maybe I misunderstood the intention. It just looked quite strange to me that when only the `compiler-rt/` subtree of the repository was changed, pre-merge check was

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8fae2bb4afe: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE (authored by c-rhodes). Changed prior to commit: https://reviews.llvm.org/D82178?vs=272091=272664#toc Repository: rG LLVM

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument :

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} gribozavr2 wrote: > C99 has bool literals, but the program should include stdbool.h. > > I feel

[clang] 5eca1d5 - AST dump: recurse into type template arguments when dumping.

Author: Richard Smith Date: 2020-06-23T00:07:00-07:00 New Revision: 5eca1d5e0d22a2a578370fdc780cd4003e28ad61 URL: https://github.com/llvm/llvm-project/commit/5eca1d5e0d22a2a578370fdc780cd4003e28ad61 DIFF: https://github.com/llvm/llvm-project/commit/5eca1d5e0d22a2a578370fdc780cd4003e28ad61.diff

[PATCH] D82369: [SveEmitter] Add verify-checks to Clang bfloat16 tests

c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_bfdot.c:3-6 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE_BF16 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! Committed in 8a9311940a26372dab6706edfd07288667394cfe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82279/new/

[clang] 264f0db - [OPENMP][DOCS]Update status of supported constructs, NFC.

Author: Alexey Bataev Date: 2020-06-23T08:53:58-04:00 New Revision: 264f0dbef813913d4463f4528c44c844f914222e URL: https://github.com/llvm/llvm-project/commit/264f0dbef813913d4463f4528c44c844f914222e DIFF: https://github.com/llvm/llvm-project/commit/264f0dbef813913d4463f4528c44c844f914222e.diff

[clang] cb90e6a - [OPENMP50]Codegen for scan directives in parallel for simd regions.

Author: Alexey Bataev Date: 2020-06-23T08:41:11-04:00 New Revision: cb90e6a7c0afdc04c5882d596e8f0b06888b5344 URL: https://github.com/llvm/llvm-project/commit/cb90e6a7c0afdc04c5882d596e8f0b06888b5344 DIFF: https://github.com/llvm/llvm-project/commit/cb90e6a7c0afdc04c5882d596e8f0b06888b5344.diff

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb90e6a7c0af: [OPENMP50]Codegen for scan directives in parallel for simd regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:154 assert(this->IndexStorageFactory && "Storage factory can not be null!"); - for (unsigned I = 0; I < ThreadPoolSize; ++I) { + for (unsigned I

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

eugenis added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4095 +} + } call->setCallingConv(getRuntimeCC()); guiand wrote: > jdoerfert wrote: > > Why would we do this? Function attributes are valid at the call site, no > > need to copy

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand marked 2 inline comments as done. guiand added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:507 +def disable_frozen_args : Flag<["-"], "disable-frozen-args">, + HelpText<"Disable emitting frozen attribute in LLVM IR">; def load : Separate<["-"],

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

uabelho added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:242 llvm::IntrusiveRefCntPtr - getFileSystem() const override { + getFileSystem(llvm::NoneType) const override { return VFS; A warning here too ```

[clang] 121e585 - [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

Author: Sander de Smalen Date: 2020-06-23T12:12:35+01:00 New Revision: 121e585ec8aa5f973ea56807ed0a73f13ab4937e URL: https://github.com/llvm/llvm-project/commit/121e585ec8aa5f973ea56807ed0a73f13ab4937e DIFF:

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1123-1124 + "abs", Summary(ArgTypes{IntTy}, RetType{IntTy}, EvalCallAsPure) + .Case({ArgumentCondition(0, WithinRange, SingleValue(0)), +

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1123-1124 + "abs", Summary(ArgTypes{IntTy}, RetType{IntTy}, EvalCallAsPure) + .Case({ArgumentCondition(0, WithinRange, SingleValue(0)), +

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

miyuki updated this revision to Diff 272668. miyuki retitled this revision from "[AArch32]: BFloat MatMul Intrinsics" to "[ARM] BFloat MatMul Intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Herald added a subscriber: danielkiss. Addressed the review comments

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_sel.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272674. jaafar added a comment. Applied feedback from Nathan James CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928 ___ cfe-commits mailing list

[clang] 9c57954 - [ARM] BFloat MatMul Intrinsics

Author: Mikhail Maltsev Date: 2020-06-23T12:06:37Z New Revision: 9c579540ff6945d126a680d01db38548db9a972d URL: https://github.com/llvm/llvm-project/commit/9c579540ff6945d126a680d01db38548db9a972d DIFF: https://github.com/llvm/llvm-project/commit/9c579540ff6945d126a680d01db38548db9a972d.diff

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:72-75 + bool isCXX17OrLater() const { +return Language == Lang_CXX17 || Language == Lang_CXX20; +

[PATCH] D79425: [analyzer] StdLibraryFunctionsChecker: Add overload for adding the same summary for different names

martong marked 2 inline comments as done. martong added a comment. In D79425#2022245 , @xazax.hun wrote: > I'd prefer to have this functionality committed together its first actual use > with tests. Okay, at the current state we add a summary

[PATCH] D79411: [VE] Clang toolchain for VE

simoll updated this revision to Diff 272632. simoll marked an inline comment as done. simoll added a comment. Removed `getEHDataRegisterNumber`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 Files:

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

c-rhodes added a comment. In D82178#2106847 , @fpetrogalli wrote: > LGTM! Thanks. Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178

[clang] 15b9dc4 - Revert "[AVR] Explicitly set the address of the data section when invoking the linker"

Author: Dylan McKay Date: 2020-06-23T22:23:05+12:00 New Revision: 15b9dc46c6d2eed64dc72143172f5fb0d4049f33 URL: https://github.com/llvm/llvm-project/commit/15b9dc46c6d2eed64dc72143172f5fb0d4049f33 DIFF: https://github.com/llvm/llvm-project/commit/15b9dc46c6d2eed64dc72143172f5fb0d4049f33.diff

[PATCH] D79411: [VE] Clang toolchain for VE

kaz7 added a comment. Please check an inline comment. Comment at: clang/lib/Basic/Targets/VE.h:166 + + int getEHDataRegisterNumber(unsigned RegNo) const override { +// S0 = ExceptionPointerRegister, S1 = ExceptionSelectorRegister Current VE backend

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

david-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE_BF16 -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

hans added a comment. In D79895#2107604 , @nick wrote: > This diagnostic bring headaches because frequently `-Wunused-variable` > suppression is done via no-op pseudo-consuming function like > `boost::ignore_unused` >

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei accepted this revision as: lei. lei added a comment. LGTM, please address the 1 comment I have on commit. Comment at: clang/test/Parser/altivec-bool-128.c:6 +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-cpu pwr10 \ +// RUN:-target-feature

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data member without explicit "this"

[PATCH] D82362: Move default module cache from system temporary directory

davezarzycki marked an inline comment as done. davezarzycki added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3253 + CmdArgs.push_back(Args.MakeArgString(Path)); +} } sammccall wrote: > what happens in the else case? No module

[PATCH] D82362: Move default module cache from system temporary directory

sammccall added a comment. Can you update the commit message to also reflect the change in `cache_directory` behavior? (This is going to move clangd index files on macOS, for instance... I think that's OK, but let's not bury it) Comment at:

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1266 + +TEST_P(SyntaxTreeTest, CharacterLiteralCxx11) { + if (!GetParam().isCXX11OrLater()) { Rename to `CharacterLiteralUtf`?

[PATCH] D79425: [analyzer] StdLibraryFunctionsChecker: Add overload for adding the same summary for different names

martong abandoned this revision. martong marked an inline comment as done. martong added a comment. At the current state we add a summary individually for each name, that makes it easier to modify a summary for each function without effecting other functions. I'll add this functionality in the

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong added a comment. In D79432#2022207 , @xazax.hun wrote: > I think testing summaries this way can be really hard to manage in the future. > I see two possible ways forward to make this easier: > a) Make something like

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

uabelho added a comment. Hi! I see a bunch of failures when I run libcxx testcases with this patch. Should there be "noexcept" on a number of more places? Failed Tests (8): libc++ :: libcxx/experimental/language.support/support.coroutines/dialect_support.pass.cpp libc++ ::

[PATCH] D82360: Add StringLiteral to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c579540ff69: [ARM] BFloat MatMul IntrinsicsCodeGen (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/

[clang] c8fae2b - [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

Author: Cullen Rhodes Date: 2020-06-23T10:24:10Z New Revision: c8fae2bb4afed8073096860d23e5759055c9bf88 URL: https://github.com/llvm/llvm-project/commit/c8fae2bb4afed8073096860d23e5759055c9bf88 DIFF: https://github.com/llvm/llvm-project/commit/c8fae2bb4afed8073096860d23e5759055c9bf88.diff

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL MaskRay wrote: > This variable is

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

aganea added a comment. LGTM. Thanks for reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82352/new/ https://reviews.llvm.org/D82352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

jdoerfert added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:507 +def disable_frozen_args : Flag<["-"], "disable-frozen-args">, + HelpText<"Disable emitting frozen attribute in LLVM IR">; def load : Separate<["-"], "load">, MetaVarName<"">,

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

sammccall added inline comments. Herald added subscribers: msifontes, jurahul, Kayjukh, stephenneuendorffer, aartbik. Herald added a project: MLIR. Comment at: clang-tools-extra/clangd/index/Background.cpp:154 assert(this->IndexStorageFactory && "Storage factory can not be

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

NoQ added inline comments. Comment at: clang/test/Analysis/std-c-library-functions.c:231 + if (p > 0) +clang_analyzer_eval(abs(p) < 0); // expected-warning{{TRUE}} + if (p < 0) Emm :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82362: Move default module cache from system temporary directory

davezarzycki created this revision. davezarzycki added reviewers: compnerd, aprantl, jakehehrlich, espindola, respindola, ilya-biryukov, pcc, sammccall. davezarzycki added projects: clang, LLVM. Herald added a subscriber: hiraditya. 1. Shared writable directories like /tmp are a security

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; c-rhodes wrote: >

[PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki updated this revision to Diff 272661. davezarzycki added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Moved clang specific changes to: https://reviews.llvm.org/D82362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE_BF16 -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

This revision was automatically updated to reflect the committed changes. Closed by commit rG121e585ec8aa: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D82187?vs=272342=272678#toc Repository: rG LLVM

[clang] 8a93119 - Handle invalid types in the nullPointerConstant AST matcher

Author: Aaron Ballman Date: 2020-06-23T07:14:33-04:00 New Revision: 8a9311940a26372dab6706edfd07288667394cfe URL: https://github.com/llvm/llvm-project/commit/8a9311940a26372dab6706edfd07288667394cfe DIFF: https://github.com/llvm/llvm-project/commit/8a9311940a26372dab6706edfd07288667394cfe.diff

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/ https://reviews.llvm.org/D81740

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

This revision was automatically updated to reflect the committed changes. Closed by commit rG508050317403: [SVE][CodeGen] Legalisation of vsetcc with scalable types (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79167/new/

[PATCH] D82354: [clangd] Implement RepoScheme for portable URIs

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is not a complete patch, but rather RFC: while the schema implementation itself does

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

sammccall created this revision. sammccall added reviewers: kadircet, aganea. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This confusion was inadvertently introduced in a change to the

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

goncharov added a comment. In D81408#2105188 , @atrosinenko wrote: > @goncharov > > Meanwhile, looking at the latest Buildkite build > for this > review, we have: > >

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

uabelho added inline comments. Comment at: clang-tools-extra/clangd/support/FSProvider.h:39 + virtual llvm::IntrusiveRefCntPtr + getFileSystem(PathRef CWD) const; }; I noticed that gcc (7.4) warns on this line: ```

[PATCH] D79411: [VE] Clang toolchain for VE

kaz7 accepted this revision. kaz7 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

sammccall added a comment. I've sent https://reviews.llvm.org/D82352 to clean up some of the logic in clangd. Comment at: clang-tools-extra/clangd/index/Background.cpp:154 assert(this->IndexStorageFactory && "Storage factory can not be null!"); - for (unsigned I = 0; I <

Re: [PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

Yes, that seems to be strange that 'compiler-rt' was dropped. Will check why. On Tue, Jun 23, 2020 at 10:32 AM Anatoly Trosinenko via Phabricator < revi...@reviews.llvm.org> wrote: > atrosinenko added a comment. > > > could you please clarify what exactly is wrong? Windows not building >

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, but wait for others too, please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672

[PATCH] D82317: [Clang/Test]: Update tests where `frozen` attribute is necessary

jdoerfert added a comment. > This very large diff affects more than 1,000 files. Use the Changeset List to > browse changes. This we will "look" at once the rest is settled ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f353a2e5a98: [BFloat] Add convert/copy instrinsic support (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D80928?vs=272406=272731#toc Repository: rG LLVM Github Monorepo

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

jdoerfert added a comment. In D81678#2109059 , @nlopes wrote: > I'm a bit concerned with this patch as it increases the amount of UB that > LLVM exploits without any study of the impact. > For example, right now it's ok do this with clang (not with

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. @LukeZhuang : This patch causes the buildbots to fail, as O1 means something slightly different with the new pass manager :

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval marked 2 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen)

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. When using `clang-cl`, this code should set it to the right format, on any platform: https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/Driver.cpp#L1071 However maybe something else happens on big endian architectures? @uweigand Would you mind running the

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. - Add

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. The reason to not call into LLVM directly is because I want to use the compiler driver, to be compatible with all the compiler flags. Reimplementing the assembler driver would be a pain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. (sorry, I missed your comment) I basically want to run `clang` by linking to it and calling it directly, without invoking any external commands. You can see here how I did it: https://github.com/tinygo-org/tinygo/blob/master/builder/clang.cpp I copied the cc1as code in

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

uweigand added a comment. Hmm, with clang-cl it seems the driver is trying to use this: Target: s390x-pc-windows-msvc which of course doesn't exist. Not sure what is supposed to be happening here, but it seems that it's falling back on s390x-linux since on s390x, Linux is currently the only

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

thakis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen) All other tblgen outputs are called .inc, not

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind added a comment. Test failures are being fixed in https://reviews.llvm.org/D82338/new/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029 ___ cfe-commits

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 272729. vsavchenko added a comment. Add forgotten nodiscards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files:

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:556 RangeSet infer(SymbolRef Sym) { -const RangeSet *AssociatedRange = State->get(Sym); - -// If Sym is a difference of symbols A - B, then maybe we have range set -//

[clang] 79ceda2 - Fix test added by D79830

Author: Erich Keane Date: 2020-06-23T08:39:25-07:00 New Revision: 79ceda2e394cefd6ce650dc40fce44295e76be2b URL: https://github.com/llvm/llvm-project/commit/79ceda2e394cefd6ce650dc40fce44295e76be2b DIFF: https://github.com/llvm/llvm-project/commit/79ceda2e394cefd6ce650dc40fce44295e76be2b.diff

[clang-tools-extra] ddf7ae8 - [openmp] Add missing dependencies for OMP.h.inc after d90443b

Author: Valentin Clement Date: 2020-06-23T11:48:04-04:00 New Revision: ddf7ae852c48ff66c1da1e536ad2b8e77fa3d2b2 URL: https://github.com/llvm/llvm-project/commit/ddf7ae852c48ff66c1da1e536ad2b8e77fa3d2b2 DIFF:

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 272722. vsavchenko added a comment. Remove hunk that is meant for the next commmit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files:

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. The new functions are now considered as iterator-specific thus moved into D77229 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81718/new/ https://reviews.llvm.org/D81718

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 272735. baloghadamsoftware added a comment. No new functions in `CallEvent` needed, instead new functions in the iterator library. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, this LGTM Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:414-415 + for (const clang::Decl *D :

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko updated this revision to Diff 272743. atrosinenko added a comment. Unit test: fix for path separators on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files:

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 272724. vsavchenko added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files:

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1123-1124 + "abs", Summary(ArgTypes{IntTy}, RetType{IntTy}, EvalCallAsPure) + .Case({ArgumentCondition(0,

[PATCH] D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang

lei added a comment. This is PR still valid? I see dup def in https://reviews.llvm.org/D82365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81836/new/ https://reviews.llvm.org/D81836 ___ cfe-commits

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, gamesh411, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

sammccall created this revision. sammccall added reviewers: kadircet, adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This is a piece from the design in https://tinyurl.com/clangd-config

  1   2   3   >