[PATCH] D81725: [AArch64][SVE] Enable __ARM_FEATURE_SVE macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfabe67728eea: [AArch64][SVE] Enable __ARM_FEATURE_SVE macros. (authored by sdesmalen). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D82362: Move default module cache from system temporary directory

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3253 + CmdArgs.push_back(Args.MakeArgString(Path)); +} } davezarzycki wrote: > sammccall wrote: > > what happens in the else case? > N

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Btw, I've recently learned about http://llvm-compile-time-tracker.com/ so you might want to check the effect afterwards. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] d6efc98 - Reland "[clang][Driver] Correct tool search path priority"

Author: David Spickett Date: 2020-06-25T09:33:43+01:00 New Revision: d6efc9811646edbfe13f06c2676fb469f1c155b1 URL: https://github.com/llvm/llvm-project/commit/d6efc9811646edbfe13f06c2676fb469f1c155b1 DIFF: https://github.com/llvm/llvm-project/commit/d6efc9811646edbfe13f06c2676fb469f1c155b1.diff

[PATCH] D82526: [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and TemplateNameDependence.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. We might lose the error-bit if the error-bit goes through the code path "error type/expr" -> "error template argument" -> "nested name specifier" -> ... -> "template Specialization type" Template name

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:1 +//===--- clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp ---===// +// I find this name too

[PATCH] D82313: [OpenCL] Reject block arguments

svenvh updated this revision to Diff 273253. svenvh added a comment. Add test case with a block as a parameter of another block. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/ https://reviews.llvm.org/D82313 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

sammccall updated this revision to Diff 273254. sammccall marked 38 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82386/new/ https://reviews.llvm.org/D82386 Files: clang

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

sammccall added a comment. Thanks! > Apart from the comments(IIRC which are mostly minor), it felt like there were > a few lines that aren't clang-format'd. Please make sure to run clang-format > on the files at some point. git-clang-format thinks it's clean, so please point out any examples y

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

kadircet added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:1649 const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index, bool *Invalid = nullptr) const { assert(Index < LocalSLocEntryTable.size() &

[PATCH] D82532: [libclang] Get rid of relience on SourceManager member signature

kadircet created this revision. kadircet added reviewers: sammccall, bkramer. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Libclang was enforcing a singature on SourceManager::getLocalSLocEntry which isn't possible to satisfy as pointed out in https://reviews.llv

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

whisperity added a comment. As a future work, when something support `if`s, it should also support `?:`, and eliminate redundant conditionals from there, too. I believe this check (together with `misc-redundant-expr`) should go into the `readability-` group. CHANGES SINCE LAST ACTION https:

[clang] e010d14 - [analyzer] SATest: Add initial docker infrastructure

Author: Valeriy Savchenko Date: 2020-06-25T12:28:21+03:00 New Revision: e010d1432fa15cff7a6d369f5e372d995e2eba5d URL: https://github.com/llvm/llvm-project/commit/e010d1432fa15cff7a6d369f5e372d995e2eba5d DIFF: https://github.com/llvm/llvm-project/commit/e010d1432fa15cff7a6d369f5e372d995e2eba5d.d

[clang] 3770f5c - [analyzer] SATest: Add convenience 'docker' command

Author: Valeriy Savchenko Date: 2020-06-25T12:28:22+03:00 New Revision: 3770f5c9b98c5bae2f099f5c24e05eb4a0cca1d0 URL: https://github.com/llvm/llvm-project/commit/3770f5c9b98c5bae2f099f5c24e05eb4a0cca1d0 DIFF: https://github.com/llvm/llvm-project/commit/3770f5c9b98c5bae2f099f5c24e05eb4a0cca1d0.d

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

bjope added a comment. I think the warnings can be hidden by something like this (I'm no expert in this area though, but it seems like this technique has been used a number of times before in llvm, so hopefully it applies here as well): diff --git a/clang-tools-extra/clangd/Preamble.cpp b/cl

[PATCH] D82532: [libclang] Get rid of relience on SourceManager member signature

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Regardless of the outcome on the other patch, I like this code better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82532/new/ https://re

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett closed this revision. DavidSpickett added a comment. Relanded as d6efc9811646edbfe13f06c2676fb469f1c155b1 . Change was to get the default triple from clang itself, as on MacOS this can be different to the value y

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGe010d1432fa1: [analyzer] SATest: Add initial docker infrastructure (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81571/new/ https:

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

This revision was automatically updated to reflect the committed changes. Closed by commit rG3770f5c9b98c: [analyzer] SATest: Add convenience 'docker' command (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81572/new/ https:/

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc2802773ce: [analyzer] SATest: Add a set of initial projects for testing (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81592/new/

[PATCH] D81600: [analyzer] SATest: Fix package versions for test dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a84ab9f9bdb: [analyzer] SATest: Fix package versions for test dependencies (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81600/new

[PATCH] D81595: [analyzer] SATest: Make main script Python2 compatible

This revision was automatically updated to reflect the committed changes. Closed by commit rG94f0eb83a2e5: [analyzer] SATest: Make main script Python2 compatible (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81595/new/ http

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG11f287826fb3: [analyzer] SATest: Add an easy option to connect to docker for debugging (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D81596: [analyzer] SATest: Do not re-run CMake in Docker if not needed

This revision was automatically updated to reflect the committed changes. Closed by commit rG061b5bf914c6: [analyzer] SATest: Do not re-run CMake in Docker if not needed (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81596/ne

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG495fd6404190: [analyzer] SATest: Use logger in single-threaded mode as well (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81601/new

[PATCH] D81593: [analyzer] SATest: Make docker interfaces transparent

This revision was automatically updated to reflect the committed changes. Closed by commit rGe30706af2e14: [analyzer] SATest: Make docker interfaces transparent (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81593/new/ https

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f55355c16b6: [analyzer] SATest: Add 5 more projects for testing (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/ https://

[clang] e4e2d8e - Ensure that CompilerInvocationTest normalizes default target triples

Author: Daniel Grumberg Date: 2020-06-25T10:41:40+01:00 New Revision: e4e2d8e4c2d2d61a5baf7eeab69a3f539343eca6 URL: https://github.com/llvm/llvm-project/commit/e4e2d8e4c2d2d61a5baf7eeab69a3f539343eca6 DIFF: https://github.com/llvm/llvm-project/commit/e4e2d8e4c2d2d61a5baf7eeab69a3f539343eca6.dif

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82373: [CodeComplete] Tweak code completion for `typename`.. Add code completion for using alias. Repository: rG LLVM Github Mo

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

hokein updated this revision to Diff 273281. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80981/new/ https://reviews.llvm.org/D80981 Files: clang/lib/AST/ExprCon

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

hokein added a comment. Thanks for the review! Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), rsmith wrote: > hokein wrote: > > rsmith wrote

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] b5d3abe - [libclang] Get rid of relience on SourceManager member signature

Author: Kadir Cetinkaya Date: 2020-06-25T12:04:12+02:00 New Revision: b5d3abea228bf17a009a007061c82d14461766c7 URL: https://github.com/llvm/llvm-project/commit/b5d3abea228bf17a009a007061c82d14461766c7 DIFF: https://github.com/llvm/llvm-project/commit/b5d3abea228bf17a009a007061c82d14461766c7.dif

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

vrnithinkumar added a comment. In D82256#2113233 , @NoQ wrote: > @vrnithinkumar what's your preferred `Full Name ` for llvm's git? Nithin Vadukkumchery Rajendrakumar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D82532: [libclang] Get rid of relience on SourceManager member signature

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5d3abea228b: [libclang] Get rid of relience on SourceManager member signature (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82532/ne

[clang] 9fb7e98 - [AST] Fix a crash on accessing a class without definition in constexpr function context.

Author: Haojian Wu Date: 2020-06-25T12:13:05+02:00 New Revision: 9fb7e98db5aaef617878a127b663efa4d01aa834 URL: https://github.com/llvm/llvm-project/commit/9fb7e98db5aaef617878a127b663efa4d01aa834 DIFF: https://github.com/llvm/llvm-project/commit/9fb7e98db5aaef617878a127b663efa4d01aa834.diff LO

RE: [clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces].

Thanks for the feedback! 😊 -Original Message- From: David Blaikie Sent: Wednesday, June 24, 2020 1:49 PM To: Huihui Zhang ; Huihui Zhang Cc: cfe-commits Subject: [EXT] Re: [clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces]. Generally it'd be helpful to describe what t

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { Other types that we should thin

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

jdoerfert added a comment. > We don't have any optimizations that infer either "speculatable" or "frozen", > though, so I'm not sure there's any practical impact here. `speculatable` is on the shortlist for the Attributor. Will happen eventually. I am sure `frozen` will follow once it is in. We

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273287. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/ordin

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fb7e98db5aa: [AST] Fix a crash on accessing a class without definition in constexpr function… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 22f02db - [Matrix] Group matrix diagnostics together (NFC).

Author: Florian Hahn Date: 2020-06-25T11:47:33+01:00 New Revision: 22f02db625dd3ffd7d041edb6ef5af371f4fa474 URL: https://github.com/llvm/llvm-project/commit/22f02db625dd3ffd7d041edb6ef5af371f4fa474 DIFF: https://github.com/llvm/llvm-project/commit/22f02db625dd3ffd7d041edb6ef5af371f4fa474.diff

[clang] 043b608 - [Matrix] Use 1st/2nd instead of first/second in matrix diags.

Author: Florian Hahn Date: 2020-06-25T11:55:03+01:00 New Revision: 043b608399559969f563eaa52e11a7ffe37137d9 URL: https://github.com/llvm/llvm-project/commit/043b608399559969f563eaa52e11a7ffe37137d9 DIFF: https://github.com/llvm/llvm-project/commit/043b608399559969f563eaa52e11a7ffe37137d9.diff

[clang] 8938a6c - [NFC] update test to make diff of the following commit clear

Author: Tyker Date: 2020-06-25T12:59:44+02:00 New Revision: 8938a6c9ede29a2d738357c44d66a017d74fcc7e URL: https://github.com/llvm/llvm-project/commit/8938a6c9ede29a2d738357c44d66a017d74fcc7e DIFF: https://github.com/llvm/llvm-project/commit/8938a6c9ede29a2d738357c44d66a017d74fcc7e.diff LOG: [N

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple aarch64-none-linux-gnu -target-feature +sve2 -target-feat

[PATCH] D82473: [Matrix] Use 1st/2nd instead of first/second in matrix diags.

This revision was automatically updated to reflect the committed changes. Closed by commit rG043b60839955: [Matrix] Use 1st/2nd instead of first/second in matrix diags. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82473/new/ ht

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc95ffadb2474: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/ne

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

aykevl added a comment. Look reasonable from my POV, but I don't know enough about CMake or the compiler-rt build system to LGTM this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282

[clang-tools-extra] 95a3550 - Repair various issues with modernize-avoid-bind

Author: Jeff Trull Date: 2020-06-25T07:29:53-04:00 New Revision: 95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf URL: https://github.com/llvm/llvm-project/commit/95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf DIFF: https://github.com/llvm/llvm-project/commit/95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf.diff LO

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/n

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr updated this revision to Diff 273302. gribozavr added a comment. Addressed code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files: clang/unittests/Tooling/CMakeLists.txt c

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr2 marked 5 inline comments as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:16 +template +class RecordingVisitorBase : public TestVisitor { + bool VisitPostOrder; ymandel wrote: > Add

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

kadircet added a comment. mostly LG, apart from the comments around the fallthrough, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2061 +if (SemaRef.getLangOpts().CPlusPlus11) + AddUsingAliasResult(Results); there's already a fallthrough do

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

kadircet added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:1649 const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index, bool *Invalid = nullptr) const { assert(Index < LocalSLocEntryTable.size() &

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} gribozavr2 wrote: > eduucaldas wrote: > > gribozavr2 wrote: > > > C99 has bool literals, but the program should include stdbool.h. > > > > > > I

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

c-rhodes added a comment. We need to guard the LLVM patterns on the +bf16 feature as we've done in other patches Comment at: clang/include/clang/Basic/arm_sve.td:694 def SVDUPQ_16 : SInst<"svdupq[_n]_{d}", "d", "sUsh", MergeNone>; +let ArchGuard = "defined(__ARM_FEAT

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas updated this revision to Diff 273310. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. isC -> hasBoolType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82310/new/ https://reviews.llvm.org/D82310 Files: clang/in

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm added a comment. I did realize one edge case that is different between carrying the size and the type. You can have a zero sized type with an alignment, but 0 is naturally an invalid value for the attribute (and all the others that carry an integer) CHANGES SINCE LAST ACTION https://r

[clang] 32ea339 - [OPENMP]Dynamic globalization for parallel target regions.

Author: Alexey Bataev Date: 2020-06-25T08:25:24-04:00 New Revision: 32ea3397bec820f98f0b77ca37244142ce700207 URL: https://github.com/llvm/llvm-project/commit/32ea3397bec820f98f0b77ca37244142ce700207 DIFF: https://github.com/llvm/llvm-project/commit/32ea3397bec820f98f0b77ca37244142ce700207.diff

[clang] 3765799 - Fix a crash with [[clang::acquire_handle]] when written as a type

Author: Aaron Ballman Date: 2020-06-25T08:45:32-04:00 New Revision: 37657991d17a274b1ac9c6ee63697a0138eab317 URL: https://github.com/llvm/llvm-project/commit/37657991d17a274b1ac9c6ee63697a0138eab317 DIFF: https://github.com/llvm/llvm-project/commit/37657991d17a274b1ac9c6ee63697a0138eab317.diff

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } Is there any reason to find and validate candidates now only to have to re

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} eduucaldas wrote: > gribozavr2 wrote: > > eduucaldas wrote: > > > gribozavr2 wrote: > > > > C99 has b

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG32ea3397bec8: [OPENMP]Dynamic globalization for parallel target regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ htt

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko marked 4 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:452 + EquivalenceClass(const EquivalenceClass &) = default; + EquivalenceClass &operator=(const EquivalenceClass &) = default; +

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. In D69987#2079524 , @rogfer01 wrote: > The patch as it stands now LGTM and I think it can be committed. Is there any > objection remaining? > > Any further c

Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

Thanks for alerting me. Why is it important to strip out this information? Also, might this be something we can change on the arcanist side (to not add to the commit message) rather than strip out on the git end? On Wed, Jun 24, 2020 at 3:28 PM Fangrui Song via Phabricator < revi...@reviews.llvm.o

[clang] 5b9ce07 - [openmp] Use Directive_enumSize instead of OMPD_unknown position

Author: Valentin Clement Date: 2020-06-25T09:18:54-04:00 New Revision: 5b9ce07a761f7d62ad793f9827750243de597215 URL: https://github.com/llvm/llvm-project/commit/5b9ce07a761f7d62ad793f9827750243de597215 DIFF: https://github.com/llvm/llvm-project/commit/5b9ce07a761f7d62ad793f9827750243de597215.di

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

asb added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:9 +/// +/// This file describes the RISC-V instructions from the standard 'V', +/// Vector instruction set extension. Please add similar language as in RISCVInstrInfoB.td to indicate

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273321. lh123 marked 3 inline comments as done. lh123 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeCo

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

clementval marked 2 inline comments as done. clementval added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:583 OpenMPDirectiveKind DKind) { - assert(DKind <= OMPD_unknown); + assert(unsigned(DKind) <= llvm::omp::Directive_enumSize); switch (DKind) {

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b9ce07a761f: [openmp] Use Directive_enumSize instead of OMPD_unknown position (authored by clementval). Changed prior to commit: https://reviews.llvm.org/D82518?vs=273216&id=273327#toc Repository: r

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:537 + // true for equality and false for disequality. + bool IsEquality = true; + vsavchenko wrote: > NoQ wrote: > > Do i understand correctly that this isn't used y

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added a comment. The last patchset contains the comment about rounding, so I think I will consider this accepted. As a final addendum to the discussion on rounding and overflow... The last Appendix to the E-C TR does actually say: 2. In the first edition requires that overflow hand

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

ymandel added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:335 + template struct is_same_method_impl { +static bool isSameMethod(...) { return false; } + }; Why use var-args rather than spelling out the type arguments like you

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this again, @fpetrogalli! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin updated this revision to Diff 273331. kmclaughlin added a comment. - Added HasSVE to Predicates in AArch64SVEInstrInfo.td - Removed unnecessary indentation changes in AArch64SVEInstrInfo.td - Removed hasBF16 variable from performST1Combine/performSTNT1Combine CHANGES SINCE LAST ACTIO

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro created this revision. djtodoro added reviewers: vsk, aprantl, dblaikie, probinson. djtodoro added projects: debug-info, LLVM. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. djtodoro added a parent revision: D82546: [Debugify][OriginalMode] Export the

[PATCH] D82226: Add Metadata to Transformer tooling

ymandel added a comment. Looks good! Only real question is one of design -- should we consider the (deeper) change of templating the various types rather than using dynamic typing? For that matter, the decision doesn't even have to be the same for both AtomicChange and the Transformer types. T

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273343. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Add tests for unicode characters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/ https://reviews.llvm.org/D82312 Fil

[PATCH] D82548: [CodeComplete] add code completion for `delete` and `default` specifier.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82535: [CodeComplete] Add code completion for using alias.. add code completion for `delete` and `default` specifier. Repository:

[PATCH] D82360: Add StringLiteral to SyntaxTree

eduucaldas updated this revision to Diff 273346. eduucaldas added a comment. Add unicode tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82360/new/ https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 273347. eduucaldas marked an inline comment as done. eduucaldas added a comment. Fix indenting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files: clang/include

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; evand

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:9 +/// +/// This file describes the RISC-V instructions from the standard 'V', +/// Vector instruction set extension. asb wrote: > Pl

[PATCH] D70603: Change while to do-while

pi1024e added a comment. Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_A

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c:5 + +#include + david-arm wrote: > Hi @fpetrogalli, in the same way that you asked @kmclaughlin

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

c-rhodes updated this revision to Diff 273365. c-rhodes added a comment. Changes: - Guard patterns on `+bf16`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 Files: clang/include/clang/Basic/arm_sve.td clang/test/CodeGen/aarch64-sve-intrin

Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

On Thu, Jun 25, 2020 at 5:53 AM Yitzhak Mandelbaum wrote: > > Thanks for alerting me. Why is it important to strip out this information? > Also, might this be something we can change on the arcanist side (to not add > to the commit message) rather than strip out on the git end? Mostly to keep c

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

gamesh411 updated this revision to Diff 273372. gamesh411 added a comment. update test value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82561/new/ https://reviews.llvm.org/D82561 Files: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.

[PATCH] D70603: Change while to do-while

pi1024e added a comment. @MaskRay it's been months yet this hasn't landed yet. Why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

gamesh411 created this revision. gamesh411 added reviewers: martong, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer:

[PATCH] D82563: [Sema][NFC] Remove Redundant Condition

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: sammccall, rsmith. baloghadamsoftware added a project: clang. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs. Condition `TypeQuals` is checked both in an outer and in an inner `if` statement i

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane created this revision. erichkeane added reviewers: craig.topper, echristo. The x86-64 "avx" feature changes how >128 bit vector types are passed, instead of being passed in separate 128 bit registers, they can be passed in 256 bit registers. "avx512f" does the same thing, except it swi

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 ___ cfe-commits mail

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.o

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; HsiangKai wrote: > evandro wrote: > > HsiangKai wro

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen abandoned this revision. aelitashen added a comment. Mistakenly created two diffs on same commit, See D82477 for the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://revie

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } laytonio wrote: > Is there any reason to

  1   2   3   >