[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal abandoned this revision. steakhal added a comment. I no longer think that we should support Symbol to Symbol comparisons. It would introduce certain anomalies, like //Why could the CM reason about this and that comparisons wile could not in others//. As of now, it's clear that we can

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 286209. steakhal marked an inline comment as done. steakhal added a comment. Add an extra `RUN` line without //refutation//. The expected result is the same as with refutation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal updated this revision to Diff 286212. steakhal marked 2 inline comments as done. steakhal edited the summary of this revision. steakhal added a comment. Herald added a subscriber: mgorny. Fixed Artem's inline comments: - `cstring::getCStringLength` now takes `StateRef` by value -

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGe33ec9d90400: [clangd] Target member of dependent base made visible via a using-decl (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal added a comment. In D84979#2190996 , @balazske wrote: > Really I am still not totally familiar how the checkers work and if it is > good to have these function names. Yea, naming things is pretty hard. I'm open to have a less verbose one -

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

hokein created this revision. hokein added a reviewer: rsmith. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86130 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle.cpp Index:

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

sepavloff added inline comments. Comment at: compiler-rt/test/builtins/Unit/divdf3_test.c:29-34 +// qNaN / any = qNaN +if (test__divdf3(makeQNaN64(), 3., UINT64_C(0x7ff8))) + return 1; +// NaN / any = NaN +if

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84316/new/ https://reviews.llvm.org/D84316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] e33ec9d - [clangd] Target member of dependent base made visible via a using-decl

Author: Nathan Ridge Date: 2020-08-18T03:03:49-04:00 New Revision: e33ec9d90400a906314ccbd5821dbe05d070108a URL: https://github.com/llvm/llvm-project/commit/e33ec9d90400a906314ccbd5821dbe05d070108a DIFF: https://github.com/llvm/llvm-project/commit/e33ec9d90400a906314ccbd5821dbe05d070108a.diff

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

CarolineConcatto created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CarolineConcatto requested review of this revision. If a folder's name, where the test fortran.f95 is running, has cc1 the test fails because of CHECK-ASM-NOT: cc1. The solution used in

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286258. eduucaldas added a comment. Fail on non-matching number of tree dumps and annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:199 + auto AnnotatedRanges = AnnotatedCode.ranges(); + assert(AnnotatedRanges.size() == TreeDumps.size()); + for (auto i = 0ul; i < AnnotatedRanges.size(); i++) {

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

tambre added a comment. For reference, I've been using this + D75960 in my employer's Clang build for almost two months. We have been using `std::bit_cast` in our codebase quite a bit and haven't encountered any issues with these two changes. It would be nice

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286251. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

DavidTruby requested changes to this revision. DavidTruby added a comment. This revision now requires changes to proceed. On my clang line, when compiling a C file, this appears as "-cc1" not "cc1". I don't see a cc1as so I can't check that one but I assume it will be the same. Repository:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286248. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko added a comment. @sepavloff Thank you for the test cases. Looks like it is worth completely rewriting the three tests as table-driven tests, so for example adding four cases for `[+-]Inf / [+-]0.0` would be almost as easy as testing only one of them (something similar is already

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

ebevhan added a comment. It doesn't feel like this patch got a very positive reception, but I'd still like to try a bit more to get it in. Even though it's difficult to test this particular change upstream, would it still be acceptable to take the patch since it reverts the behavior to what it

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor created this revision. fodinabor added reviewers: bkramer, djasper, klimek. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. fodinabor requested review of this revision. Currently newer clang-format options cannot be included in

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b93ebccaa09: [OPENMP]Do not capture base pointer by reference if it is used as a base for… (authored by ABataev). Repository: rG LLVM Github

[clang] 1b93ebc - [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

Author: Alexey Bataev Date: 2020-08-18T09:05:35-04:00 New Revision: 1b93ebccaa094c079db7ad729e2f7fea7bac2f34 URL: https://github.com/llvm/llvm-project/commit/1b93ebccaa094c079db7ad729e2f7fea7bac2f34 DIFF: https://github.com/llvm/llvm-project/commit/1b93ebccaa094c079db7ad729e2f7fea7bac2f34.diff

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 286270. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

sammccall added inline comments. Comment at: clang/test/PCH/preamble-modules.cpp:8 + +#ifndef MAIN_FILE +#define MAIN_FILE what are these ifdefs about? you never seem to define this symbol (Possible you're copying from a test that is doing something tricky like

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

CarolineConcatto updated this revision to Diff 286257. CarolineConcatto added a comment. Missing a - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86132/new/ https://reviews.llvm.org/D86132 Files: clang/test/Driver/fortran.f95 Index:

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, xazax.hun, martong, balazske, baloghadamsoftware, gamesh411. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin,

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

adamcz added inline comments. Comment at: clang/test/PCH/preamble-modules.cpp:8 + +#ifndef MAIN_FILE +#define MAIN_FILE sammccall wrote: > what are these ifdefs about? you never seem to define this symbol > > (Possible you're copying from a test that is doing

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286259. eduucaldas added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:477 struct X { friend X operator+(const X&, const X&); }; A test for this part was created below Comment at:

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

atrosinenko updated this revision to Diff 286255. atrosinenko added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84932/new/ https://reviews.llvm.org/D84932 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8c92b54d74c: [SyntaxTree] Use Annotations based tests for expressions (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[clang] c8c92b5 - [SyntaxTree] Use Annotations based tests for expressions

Author: Eduardo Caldas Date: 2020-08-18T13:00:56Z New Revision: c8c92b54d74c1b9256f9aed6ba89d66fbd1d01ae URL: https://github.com/llvm/llvm-project/commit/c8c92b54d74c1b9256f9aed6ba89d66fbd1d01ae DIFF: https://github.com/llvm/llvm-project/commit/c8c92b54d74c1b9256f9aed6ba89d66fbd1d01ae.diff

[clang] ab58c9e - [SyntaxTree] Implement annotation-based test infrastructure

Author: Eduardo Caldas Date: 2020-08-18T13:00:56Z New Revision: ab58c9ee8a6e9ace3a93198496b4d85e8cb2b5a9 URL: https://github.com/llvm/llvm-project/commit/ab58c9ee8a6e9ace3a93198496b4d85e8cb2b5a9 DIFF: https://github.com/llvm/llvm-project/commit/ab58c9ee8a6e9ace3a93198496b4d85e8cb2b5a9.diff

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86132/new/ https://reviews.llvm.org/D86132

[clang] ca77ab4 - Disable use of _ExtInt with '__atomic' builtins

Author: Mott, Jeffrey T Date: 2020-08-18T09:17:26-07:00 New Revision: ca77ab494aa29f7521ff797d230cd1b36cbe4e62 URL: https://github.com/llvm/llvm-project/commit/ca77ab494aa29f7521ff797d230cd1b36cbe4e62 DIFF:

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki created this revision. miyuki added reviewers: dmgreen, simon_tatham, ostannard. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki requested review of this revision. This patch adjusts the following

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGca77ab494aa2: Disable use of _ExtInt with __atomic builtins (authored by jtmott-intel). Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2151 + +TEST_P(SyntaxTreeTest, Namepace_UsingDirective) { + if (!GetParam().isCXX()) {

[PATCH] D86100: [Clang][SVE] NFC: Move info about ACLE types into separate function.

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM, just one minor nit but seems like a nice improvement Comment at: clang/include/clang/AST/ASTContext.h:1318 + BuiltinVectorTypeInfo +

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

hans added a comment. I suppose this is just piling on heuristics, but I guess it fixes the reported bug. Krasimir, what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 ___ cfe-commits

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev updated this revision to Diff 286272. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein updated this revision to Diff 286274. hokein added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86048/new/ https://reviews.llvm.org/D86048 Files: clang/lib/AST/ComputeDependence.cpp

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86139 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1226 +TStream.injextRange( +const_cast(PrevParamMap)[__VA_ARGS__II]); +TStream.next(TheTok); Oh, this has to be fixed as well.

[clang-tools-extra] 8c9ffe3 - [NFC][clang-tidy] Put abseil headers in alphabetical order

Author: Nathan James Date: 2020-08-18T15:52:47+01:00 New Revision: 8c9ffe34d932e2e17cbcf351d6e37783ea5453ae URL: https://github.com/llvm/llvm-project/commit/8c9ffe34d932e2e17cbcf351d6e37783ea5453ae DIFF: https://github.com/llvm/llvm-project/commit/8c9ffe34d932e2e17cbcf351d6e37783ea5453ae.diff

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

jtmott-intel added a comment. Committed to master, and created bug to cherry pick into 11.0. https://bugs.llvm.org/show_bug.cgi?id=47222 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84049/new/ https://reviews.llvm.org/D84049

[libunwind] a20f5fe - Default to disabling the libunwind frameheader cache.

Author: Sterling Augustine Date: 2020-08-18T14:37:36-07:00 New Revision: a20f5fe70810e0a768c1814d69d10862965c21e4 URL: https://github.com/llvm/llvm-project/commit/a20f5fe70810e0a768c1814d69d10862965c21e4 DIFF:

[clang] 4cbceb7 - [X86] Add basic support for -mtune command line option in clang

Author: Craig Topper Date: 2020-08-18T15:13:19-07:00 New Revision: 4cbceb74bb5676d0181d4d0cab5194d90a42c2ec URL: https://github.com/llvm/llvm-project/commit/4cbceb74bb5676d0181d4d0cab5194d90a42c2ec DIFF: https://github.com/llvm/llvm-project/commit/4cbceb74bb5676d0181d4d0cab5194d90a42c2ec.diff

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cbceb74bb56: [X86] Add basic support for -mtune command line option in clang (authored by craig.topper). Herald added a project: clang. Changed prior to commit:

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

bruno added a comment. Hi Zixu, thanks for working on improving this. I agree with @vsapsai on the the `GenModuleActionWrapper` approach. Also, it seems to me that even though it would somehow improve the accuracy, it would be solving a more general problem, not really specific to this patch.

[PATCH] D86116: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

zequanwu updated this revision to Diff 286387. zequanwu added a comment. Minor fix on test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86116/new/ https://reviews.llvm.org/D86116 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

aprantl added inline comments. Comment at: clang/include/clang/Serialization/ModuleManager.h:62 + struct EntryKey { +const FileEntry *Entry; Can you add a doxygen comment explaining why we compute our own hashing as opposed to using the FileEntry

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

aprantl added inline comments. Comment at: clang/include/clang/Serialization/ModuleManager.h:62 - /// All loaded modules, indexed by name. - llvm::DenseMap Modules; + /// All loaded modules, indexed by file name. + llvm::StringMap Modules; CodaFi wrote: >

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Here's a testcase that produces a name with external linkage: struct X { int i, j; }; auto [a,b] = X{1,2}; template void f(decltype(a + T())) {} template void f(int); We should make

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:734 + if (Info.ElementType == CGM.getContext().BoolTy) +NumElemsPerVG /= 8; + I guess NumElemsPerVG of a bool vector is always divisible by 8 because we don't expose ``

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

fpetrogalli added a comment. I merged it in the release branch as https://github.com/llvm/llvm-project/commit/7e6bf0bfe6de9e0d0e58764a66f93210f296bbfa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/ https://reviews.llvm.org/D85977

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:49 + +// RUN: not %clang_cc1 -triple x86_64--- -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE_X86_64 +// TUNE_X86_64: error: unknown target CPU 'not-a-cpu'

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

aprantl added inline comments. Comment at: clang/include/clang/Serialization/ModuleManager.h:62 + struct EntryKey { +const FileEntry *Entry; aprantl wrote: > Can you add a doxygen comment explaining why we compute our own hashing as > opposed to using

[PATCH] D86065: [SVE] Make ElementCount members private

efriedma added a comment. > Perhaps now would be a good time to combine TypeSize and ElementCount into a > single Polynomial type? We don't have to implement the whole abstraction of > c*x^n (since we currently don't use the exponent, and don't distinguish > between X's) but if it's ever

[clang] b34b1e3 - [Analysis] Bug fix for exploded graph branching in evalCall for constructor

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-19T00:03:31+02:00 New Revision: b34b1e38381fa4d1b1d9751a6b5233b68e734cfe URL: https://github.com/llvm/llvm-project/commit/b34b1e38381fa4d1b1d9751a6b5233b68e734cfe DIFF:

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb34b1e38381f: [Analysis] Bug fix for exploded graph branching in evalCall for constructor (authored by vrnithinkumar). Repository: rG LLVM Github

[PATCH] D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Adds support for detecting cases like `if (!true) ...`. Addresses

[clang] 592b899 - Hook up OpenBSD 64-bit RISC-V support

Author: Brad Smith Date: 2020-08-18T18:59:55-04:00 New Revision: 592b8996bf9b55eec21e1c9e563f51b6108ec2d2 URL: https://github.com/llvm/llvm-project/commit/592b8996bf9b55eec21e1c9e563f51b6108ec2d2 DIFF: https://github.com/llvm/llvm-project/commit/592b8996bf9b55eec21e1c9e563f51b6108ec2d2.diff

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

erichkeane added a comment. Were you able to make any progress on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85990/new/ https://reviews.llvm.org/D85990 ___ cfe-commits mailing list

[PATCH] D84736: [analyzer] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal added inline comments. Comment at: clang/test/Analysis/pointer-arithmetic.c:88 + clang_analyzer_dump_int(p - pn); // expected-warning-re {{0 - (reg_${{[0-9]+}})}} + clang_analyzer_dump_int((p + 1) - q); // expected-warning {{Unknown}} // FIXME: Might point to

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi added a comment. Switched tactics here. Rather than just change the source of the entropy, let's increase it from just inodes to (64-bits of inode) plus (file size) plus (mod time). It is still possible to defeat this scheme, but it means an attacker would have to replace the PCM with

[PATCH] D84736: [analyzer] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal updated this revision to Diff 286318. steakhal marked 4 inline comments as done. steakhal retitled this revision from "[analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion" to "[analyzer] Handle pointer difference of ElementRegion and SymbolicRegion". steakhal

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

nhaehnle added a comment. Note that part of my motivation here over D84639 is to support more general types on the lane intrinsics, since they also express some semantic content which would be interesting to be able to express e.g. on descriptors. I wasn't

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM as is, minor suggestion below. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo created this revision. modimo added reviewers: wenlei, asbirlea, vsk. modimo added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. modimo requested review of this revision. D65060

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. > Not sure that's the best place to be designing this fairly integral and > complicated piece of infrastructure from, but hoping we can find some good > places/solutions/etc. I sent an email to llvm-dev several weeks ago, but things seem to have moved here. Either

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice catch! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

ABataev created this revision. ABataev added reviewers: jdoerfert, cchen. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. If the function is not marked exlicitly as declare target and it

[clang] 6b1f9f2 - [X86] Don't call SemaBuiltinConstantArg from CheckX86BuiltinTileDuplicate if Argument is Type or Value Dependent.

Author: Craig Topper Date: 2020-08-18T12:33:40-07:00 New Revision: 6b1f9f2bd4437910804d571284b7c5bb66eac250 URL: https://github.com/llvm/llvm-project/commit/6b1f9f2bd4437910804d571284b7c5bb66eac250 DIFF: https://github.com/llvm/llvm-project/commit/6b1f9f2bd4437910804d571284b7c5bb66eac250.diff

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:483 bool GapRegion = CR.value().Kind == CounterMappingRegion::GapRegion; if (CR.index() + 1 == Regions.size() || zequanwu wrote: > vsk wrote: > > Why is this

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

efriedma added a comment. I'm still concerned your approach to the computation of getTypeSize() is a ticking time bomb, but I'll take the cleanup even if the underlying motivation doesn't really make sense. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1847 +

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 286392. modimo added a comment. Commit my changes (crazy I know) so that the diff is actually updated for linting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files:

[PATCH] D86116: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86116/new/ https://reviews.llvm.org/D86116

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one minor comment Comment at: clang/test/Misc/target-invalid-cpu-note.c:49 + +// RUN: not %clang_cc1 -triple x86_64--- -tune-cpu not-a-cpu -fsyntax-only %s

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko created this revision. jonathan.protzenko added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathan.protzenko requested review of this revision. This is a preliminary patch that I hope can serve as a basis for discussion.

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 286390. modimo added a comment. Linting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll llvm/include/llvm/Analysis/BlockFrequencyInfo.h

[PATCH] D84736: [analyzer] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal added inline comments. Comment at: clang/test/Analysis/pointer-arithmetic.c:88 + clang_analyzer_dump_int(p - pn); // expected-warning-re {{0 - (reg_${{[0-9]+}})}} + clang_analyzer_dump_int((p + 1) - q); // expected-warning {{Unknown}} // FIXME: Might point to

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

arsenm added a comment. In D86154#2224270 , @nhaehnle wrote: > Note that part of my motivation here over D84639 > is to support more general types on the > lane intrinsics, since they also express some semantic content

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi updated this revision to Diff 286361. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index:

[PATCH] D85150: [OpenMP] Ensure testing for versions 4.5 and default - Part 2

saiislam added a comment. Please let me know if there are any changes/suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85150/new/ https://reviews.llvm.org/D85150 ___ cfe-commits mailing list

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; erichkeane wrote: >

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, nit: Is there a "not" missing in the the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86164/new/

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG673dbe1b5eef: [clang codegen] Use IR align attribute for static array arguments. (authored by efriedma). Repository: rG LLVM Github Monorepo

[clang] 673dbe1 - [clang codegen] Use IR "align" attribute for static array arguments.

Author: Eli Friedman Date: 2020-08-18T12:51:16-07:00 New Revision: 673dbe1b5eef09db39783c828a84f1213a47bad0 URL: https://github.com/llvm/llvm-project/commit/673dbe1b5eef09db39783c828a84f1213a47bad0 DIFF: https://github.com/llvm/llvm-project/commit/673dbe1b5eef09db39783c828a84f1213a47bad0.diff

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2224619 , @cchen wrote: > In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there > is a reduced test case that failed after adding this patch. The assertion is > from

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi updated this revision to Diff 286334. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index:

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

nhaehnle created this revision. nhaehnle added a reviewer: arsenm. Herald added subscribers: cfe-commits, kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added projects: clang, LLVM. nhaehnle requested review of this revision. Herald added a subscriber: wdng.

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

arsenm added a comment. Do we really have to use worse names here? Keeping the name works even if suboptimal for the attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86154/new/ https://reviews.llvm.org/D86154

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw added a comment. Hey Bruno! Thanks for the review. In D82118#2224423 , @bruno wrote: > Hi Zixu, thanks for working on improving this. > > I agree with @vsapsai on the the `GenModuleActionWrapper` approach. Also, it > seems to me that even though

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

ABataev added a comment. In D86164#2224577 , @jdoerfert wrote: > LGTM, nit: Is there a "not" missing in the the commit message? Yes, will add it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

cchen added a comment. In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there is a reduced test case that failed after adding this patch. The assertion is from OMPChildren::getInnermostCapturedStmt. Test case: #include #include #include class Myclass {

[PATCH] D85810: [clang] Pass-through remarks options to linker

bruno added a comment. Hi Wei, this looks handy! Minor stylish comments below. Comment at: clang/include/clang/Driver/Driver.h:638 +/// This checks for clang specific R-value ('-Rpass-*') group. +bool hasRpassOptions(const llvm::opt::ArgList ); + Nitpicking

[clang] 84fffa6 - [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

Author: Zequan Wu Date: 2020-08-18T13:26:19-07:00 New Revision: 84fffa67283139954b7764328966b5f766db1003 URL: https://github.com/llvm/llvm-project/commit/84fffa67283139954b7764328966b5f766db1003 DIFF: https://github.com/llvm/llvm-project/commit/84fffa67283139954b7764328966b5f766db1003.diff

[PATCH] D86116: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file as regions' {start, end}Loc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84fffa672831: [Coverage] Adjust skipped regions only if {Prev,Next}TokLoc is in the same file… (authored by zequanwu). Repository: rG LLVM Github

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi updated this revision to Diff 286460. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index:

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi added a comment. @aprantl Good idea. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >