[clang] e00f189 - [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Author: Roman Lebedev Date: 2020-10-06T00:00:30+03:00 New Revision: e00f189d392dd9bf95f6a98f05f2d341d06cd65c URL: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c DIFF: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c.diff

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

jrtc27 added a comment. In D88759#2313236 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt > > Can you take a look and revert for now if it takes a while to fix? I see it should already have been fixed in

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. In D88659#2306403 , @jyknight wrote: > Hm, to start with, the current state of this confuses me. > > In GCC, the preprocessor macro `__BIGGEST_ALIGNMENT__` was supposed to expose > the alignment used by

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14381 + OpLoc, CurFPFeatureOverrides()); +switch (Opc) { +case BO_Assign: now the only thing that differs between the cases is the type.

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D88349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d6d8a2769b3: [RISCV] Add SiFive cores to the CPU option (authored by evandro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Changed prior to commit:

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { sfertile wrote: > Can this change can be split out into its own patch?

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

yaxunl added a comment. This patch may break some existing HIP applications. For rdc mode, device vars are merged. Host shadow vars should also be in comdat and merged. HIP runtime just ignores the same shadow var registered with the same device var, everything should work. For nordc mode,

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil accepted this revision. bsaleil added a comment. LGTM, please fix the unrelated change when committing. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1 -// REQUIRES: powerpc-registered-target +// requires: powerpc-registered-target // RUN: %clang_cc1

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

nikic added a comment. This ended up having a rather large impact... Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=567462b48eba1c2d286ce97117994463f4535d2e=e00f189d392dd9bf95f6a98f05f2d341d06cd65c=instructions Code size:

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak planned changes to this revision. ahatanak added a comment. The parenthesis initialization does not work as documented for GCC or OpenCL vectors, so that has to be fixed too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88863/new/

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2312617 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes I need! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296340. shivanshu3 added a comment. Address Reid's comments: - Use hasFlag instead of hasArg - Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe00f189d392d: [InstCombine] Revert rL226781 Teach InstCombine to canonicalize loads which… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman added a comment. One request though: can you add a release note about the removal with a brief explanation of why it was removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt Can you take a look and revert for now if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88759/new/

[clang] 5d6d8a2 - [RISCV] Add SiFive cores to the CPU option

Author: Evandro Menezes Date: 2020-10-05T15:50:57-05:00 New Revision: 5d6d8a2769b3a91fd65b125c2cda64ea27a894bf URL: https://github.com/llvm/llvm-project/commit/5d6d8a2769b3a91fd65b125c2cda64ea27a894bf DIFF:

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak created this revision. ahatanak added reviewers: nemanjai, ayartsev. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. ahatanak requested review of this revision. Guard the AltiVec vector variables with `#ifdef __VEC__` and remove the last line,

[clang] ded79be - [c++17] Implement P0145R3 during constant evaluation.

Author: Richard Smith Date: 2020-10-05T19:04:14-07:00 New Revision: ded79be63555f4e5bfdb0db27ef22b71fe568474 URL: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474 DIFF: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474.diff

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. In D88275#2305989 , @aaron.ballman wrote: > In D88275#2303283 , @ymandel wrote: > >>> I'm not concerned about the basic idea behind the proposed matcher, I'm >>> only worried we're making

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd created this revision. compnerd added reviewers: gribozavr2, MForster. Herald added subscribers: jfb, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds the skeleton of the YAML Compiler for APINotes. This change only adds the YAML IO model for

[clang] a48d480 - [RISCV] Fix broken test

Author: Evandro Menezes Date: 2020-10-05T19:28:31-05:00 New Revision: a48d480e1f7ebc5d5f93507fe1f519496621e259 URL: https://github.com/llvm/llvm-project/commit/a48d480e1f7ebc5d5f93507fe1f519496621e259 DIFF:

Buildbot numbers for the week of 09/20/2020 - 09/26/2020

Hello everyone, Below are some buildbot numbers for the week of 09/20/2020 - 09/26/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green

Buildbot numbers for the week of 09/13/2020 - 09/19/2020

Hello everyone, Below are some buildbot numbers for the week of 09/13/2020 - 09/19/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green

Buildbot numbers for the week of 09/27/2020 - 10/03/2020

Hello everyone, Below are some buildbot numbers for the last week of 09/27/2020 - 10/03/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[clang] 1dce692 - Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload"

Author: Joseph Huber Date: 2020-10-05T12:35:39-04:00 New Revision: 1dce692de1896412693f25a3afb4818883a611e7 URL: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7 DIFF: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7.diff

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296204. jhuber6 added a comment. Changing method of determining architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 Files:

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

nemanjai added a comment. Hi @gribozavr do you think we can do something about this test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 ___ cfe-commits mailing

[clang-tools-extra] 95262ee - [clangd] Describe non-handling of most IWYU pragmas. NFC

Author: Sam McCall Date: 2020-10-05T20:50:26+02:00 New Revision: 95262ee2be75daffd05e9a8a985ca2c8e34c9af7 URL: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7 DIFF: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7.diff

[PATCH] D88822: [clangd] Describe non-handling of most IWYU pragmas. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG95262ee2be75: [clangd] Describe non-handling of most IWYU pragmas. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88822/new/

[clang] 8d51d37 - [flang] Introduce DiagnosticConsumer classes in libflangFrontend

Author: Andrzej Warzynski Date: 2020-10-05T17:46:44+01:00 New Revision: 8d51d37e0628bde3eb5a3200507ba7135dfc2751 URL: https://github.com/llvm/llvm-project/commit/8d51d37e0628bde3eb5a3200507ba7135dfc2751 DIFF:

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296218. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files:

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1643 + } else { +// Handle AIX oversized Long Long bitfield under 32 bit compile mode. +if (StorageUnitSize > 32 && I get different results for using a long

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. Hi -- We (Sony) are running into a bit of difficulty with the test for this change, as it relies on the configuration of the -O1 optimisation pipeline. Would it be possible to reduce down to a frontend test, and then tests for whatever passes are to interpret the IR

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. > If such a variable (which has a comdat group) is discarded (a copy from > another > translation unit is prevailing and selected), accessing the variable from > outside the section group (__cuda_register_globals) is a violation of the ELF > specification and will be

[clang] a2cc883 - [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

Author: Fangrui Song Date: 2020-10-05T12:53:59-07:00 New Revision: a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 URL: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 DIFF: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8.diff

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2cc8833683d: [CUDA] Dont call __cudaRegisterVariable on C++17 inline variables (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM to remove rather than move into `readability` unless someone has a good argument as to why it belongs there. I don't think this pattern makes code more readable in general as it recommends using a more verbose syntax

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

aprantl added a comment. I think that this should either hardcode a 64-bit architecture or it shouldn't test for explicit offsets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. In D88789#2312510 , @lebedev.ri wrote: > So, we can't really teach SCEV about this: D88788 > (not without the > https://bugs.llvm.org/show_bug.cgi?id=47592 at least) > And we can't recover

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng updated this revision to Diff 296269. fanbo-meng added a comment. fix no newline at end of file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88845/new/ https://reviews.llvm.org/D88845 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/CodeGen/zos-alignment.c Index:

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 296267. DiggerLin marked 3 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files:

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14365 + "Should only occur in error-recovery path."); +if (BinaryOperator::isCompoundAssignmentOp(Opc)) + return CompoundAssignOperator::Create( sammccall wrote: >

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 296221. mibintc added a comment. In the previous version of this patch, I enabled FENV_ACCESS if frounding-math, but @sepavloff commented that this deduction is not correct. I changed the logic to check for the "ffp-model=strict" settings, and if those

[clang] 85d5064 - docs: add documentation describing API Notes

Author: Saleem Abdulrasool Date: 2020-10-05T18:29:13Z New Revision: 85d506400081e121ef876a4c66fb337b050dcae6 URL: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6 DIFF: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6.diff

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. In D88786#2312365 , @MaskRay wrote: >> Could you provide an example where this is causing an issue? > > If the C++17 inline variable appears in two TUs. They have the same comdat > group. The first comdat group is prevailing and the

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

efriedma added a comment. > Keeping loads and stores of pointers as pointers to the extent possible > doesn't seem like a bad idea, but I'm worried people will feel like this > gives a *semantic* guarantee that isn't really there. Fundamentally, LLVM > still doesn't currently have typed

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. So, we can't really teach SCEV about this: D88788 (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at lease) And we can't recover the situation post-inlining in instcombine: D88842 . It

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast, Kai, uweigand. Herald added a project: clang. Herald added a subscriber: cfe-commits. fanbo-meng requested review of this revision. Set the default alignment control variables for z/OS

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. For the LIT test clang/test/AST/const-fpfeatures.cpp, currently failing in this patch, the variables V1 and others are initialized via call to "global var init" which performs the rounding at execution time, I think that's correct not certain. Repository: rG LLVM

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

MaskRay added a comment. In D88786#2312329 , @tra wrote: >> If such a variable (which has a comdat group) is discarded (a copy from >> another >> translation unit is prevailing and selected), accessing the variable from >> outside the section group

[PATCH] D88446: docs: add documentation describing API Notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d506400081: docs: add documentation describing API Notes (authored by compnerd). Changed prior to commit:

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/test/Layout/aix-bitfield-alignment.cpp:118 + +typedef __attribute__((aligned(32))) short mySHORT; +struct D { We should have a similar test for an overaligned long or long long. CHANGES SINCE LAST ACTION

[PATCH] D88844: [clangd] Add `score` extension to workspace/symbol response.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The protocol doesn't really incorporate

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert added a comment. In D88491#2306099 , @aaron.ballman wrote: > Do you have test cases for this change? I didn't see any relevant ones in > D88384 . In the revert (rG4fc69ab002382675d84f611f22599cb3cb4a0787

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

NoQ added a comment. With Z3 //constraint// manager you absolutely want your constraints to be as precise as possible. The only reason we don't add these casts is because it confuses the constraint manager a lot. With a better constraint manager we would have spared ourselves a lot of

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. > i'm pretty worried about our ability to actually achieve that in the near > future This whole cast problem that you're looking into in D85528 is definitely a part of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

asbirlea added a comment. Thank you, Ankit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88138/new/ https://reviews.llvm.org/D88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

chandlerc added a comment. In D88789#2310967 , @efriedma wrote: > In D88789#2310606 , @chandlerc wrote: > >> FWIW, I still very much feel that this is the correct canonicalization, and >> that downstream problems

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:410-411 setRoundingMode(LO.getFPRoundingMode()); +// FENV access is true if rounding math is enabled. +setAllowFEnvAccess((getRoundingMode() == llvm::RoundingMode::Dynamic));

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. In D88789#2310967 , @efriedma wrote: > To address the issue at hand, I think changing the isNonIntegralPointerType() > check to just isPtrOrPtrVectorTy() would be enough. I think that might make > sense? I briefly

[PATCH] D85354: [clangd] Reduce availability of extract function

kadircet updated this revision to Diff 296110. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85354/new/ https://reviews.llvm.org/D85354 Files:

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296111. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88411/new/ https://reviews.llvm.org/D88411 Files:

[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

kadircet updated this revision to Diff 296114. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88415/new/ https://reviews.llvm.org/D88415 Files: clang-tools-extra/clangd/TUScheduler.cpp

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 296115. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://reviews.llvm.org/D88417 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet updated this revision to Diff 296113. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88414/new/ https://reviews.llvm.org/D88414 Files: clang-tools-extra/clangd/index/Background.cpp

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet updated this revision to Diff 296112. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88413/new/ https://reviews.llvm.org/D88413 Files: clang-tools-extra/clangd/support/Trace.cpp

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. LGTM, thanks for working on this! As this is a fairly large change, could you wait for one more reviewer to approve? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

sammccall accepted this revision. sammccall added a comment. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87350/new/ https://reviews.llvm.org/D87350 ___ cfe-commits mailing list

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:35 + + /// No copy of the \p Name. + MemoryTree *addChild(llvm::StringLiteral Name) { return (Name); } Maybe mention that child pointers are invalidated by future

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor added a comment. > I am not sure how much do you guys value these diags in LLDB I think we don't even display them most of the time (IIUC they go to the diagnostic engine which is not always hooked up for the ASTs in LLDB as only a few actually come from Clang). Repository: rG

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added a comment. I think this patch is ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 ___ cfe-commits mailing list

[PATCH] D88810: [clangd] Add isKeyword function.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:638 + // Keywords are initialized in constructor. + clang::IdentifierTable KeywordsTable(LangOpts); + return

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 296118. nomanous added a comment. In this revision I delete the useless main function in the new test case and rename ext_multichar_character_literal & ext_four_char_character_literal to warn_multichar_character_literal & warn_four_char_character_literal.

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12880 return Result.getValueOr(QualType()); } sammccall wrote: > hokein wrote: > > sammccall wrote: > > > Wouldn't we be better to handle undeduced type here rather than in the > >

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

hokein updated this revision to Diff 296120. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87350/new/ https://reviews.llvm.org/D87350 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88665/new/ https://reviews.llvm.org/D88665

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:419 + IndexedSymbols.attachMemoryUsage(*MT.addChild("symbols")); + MT.addChild("index")->addUsage(estimateMemoryUsage()); +} Hmm, we should be careful now,

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296135. simoll added a comment. Herald added subscribers: llvm-commits, nikic, pengfei, hiraditya, mgorny. Herald added a project: LLVM. fixed for privatized ElementCount members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3423d5c9da81: [AST][RecoveryExpr] Popagate the error-bit from a VarDecls initializer to… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein added a comment. @rsmith I'm landing this patch now. Happy to follow-up if you have other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86048/new/ https://reviews.llvm.org/D86048 ___

[clang] 3423d5c - [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

Author: Haojian Wu Date: 2020-10-05T10:35:29+02:00 New Revision: 3423d5c9da812b0076d1cf14e96ce453e35257b6 URL: https://github.com/llvm/llvm-project/commit/3423d5c9da812b0076d1cf14e96ce453e35257b6 DIFF: https://github.com/llvm/llvm-project/commit/3423d5c9da812b0076d1cf14e96ce453e35257b6.diff

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will enable queries like "clangd::" to find symbols under clangd namespace,

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:36 + /// No copy of the \p Name. + MemoryTree *addChild(llvm::StringLiteral Name) { return (Name); } + sammccall wrote: > actually, why do these return pointers rather

[PATCH] D88810: [clangd] Add isKeyword function.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will be used in rename for doing basic name

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:578 +for (const NamedDecl *ND : getMembersReferencedViaDependentName( + resolveNestedNameSpecifierToType(DTST->getQualifier()), + [DTST](ASTContext &) {

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! (and sorry for taking too long on this one.) Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest,

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks good - some concerns that the traversal isn't flexible enough but we can address that later once it's used. Comment at:

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto accepted this revision. CarolineConcatto added a comment. This revision is now accepted and ready to land. Thank you @awarzynski for working on this. It is good because now we do not depend on clang frontend to build flang frontend. LGTM Repository: rG LLVM Github Monorepo

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296137. simoll added a comment. (wrong Diff attached in earlier update) - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files:

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f05fe1aeeb0: [AST][RecoveryExpr] Fix a crash on undeduced type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7f05fe1 - [AST][RecoveryExpr] Fix a crash on undeduced type.

Author: Haojian Wu Date: 2020-10-05T12:52:04+02:00 New Revision: 7f05fe1aeeb005b552c6a3093b61659e7b578b14 URL: https://github.com/llvm/llvm-project/commit/7f05fe1aeeb005b552c6a3093b61659e7b578b14 DIFF: https://github.com/llvm/llvm-project/commit/7f05fe1aeeb005b552c6a3093b61659e7b578b14.diff

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2308601 , @zahen wrote: > This patch doesn't need a test case outside of the one that @rnk requested to > make sure that the flag flows from the clang-cl driver appropriately. > `pch-instantiate-templates` as authored

  1   2   >