[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind added a comment. In D89066#2324115 , @junparser wrote: > why we should not do this with normal await call? To be honest, I don't know yet. My understanding of how expression cleanup and temp lifetime management is insufficient at the moment. But

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

aqjune added a comment. +1 for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88979/new/ https://reviews.llvm.org/D88979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang] 849c605 - PR47792: Include the type of a pointer or reference non-type template

On Sun, 11 Oct 2020 at 20:19, Jonas Devlieghere wrote: > I've reverted this in ba2dff0159fcd1d2349bc610331914618ca9bc30 because it > also caused a build failure when building a stage 2 clang: > Thanks! > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24177/console > > FAILED:

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. why we should not do this with normal await call? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89066/new/ https://reviews.llvm.org/D89066 ___ cfe-commits mailing list

[clang] cec49a5 - Revert "[SYCL] Implement __builtin_unique_stable_name."

Author: John McCall Date: 2020-10-12T01:10:09-04:00 New Revision: cec49a583693752b3984e49f9c193de07c2a7698 URL: https://github.com/llvm/llvm-project/commit/cec49a583693752b3984e49f9c193de07c2a7698 DIFF: https://github.com/llvm/llvm-project/commit/cec49a583693752b3984e49f9c193de07c2a7698.diff

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith added a comment. What are the expected semantics in this case? Is this: - the function is still the builtin, but if it ends up being a libcall, call a function with a different asm name, or - the function is not considered to be the builtin any more, or - something else? I think this

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rjmccall added a comment. This seems like a good idea in the abstract; we'll need to figure out what the practical consequences are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89212/new/ https://reviews.llvm.org/D89212

[clang] ba2dff0 - Revert "PR47792: Include the type of a pointer or reference non-type template"

Author: Jonas Devlieghere Date: 2020-10-11T20:16:46-07:00 New Revision: ba2dff0159fcd1d2349bc610331914618ca9bc30 URL: https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30 DIFF:

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. Herald added a subscriber: yaxunl. Richard and I just found out about this commit, and we've decided to revert it. I apologize for the very late reversion, but the reality of Clang development is that it's very difficult for the code owners to watch literally every

[clang] 849c605 - PR47792: Include the type of a pointer or reference non-type template

Author: Richard Smith Date: 2020-10-11T15:59:49-07:00 New Revision: 849c60541b630ddf8cabf9179fa771b3f4207ec8 URL: https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207ec8 DIFF: https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207ec8.diff

Re: [clang] 849c605 - PR47792: Include the type of a pointer or reference non-type template

The bots don't seem happy building with a Clang that incorporates this change: ``` /b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/ASTMatchers/ASTMatchersInternal.cpp:943:5: error: redefinition of 'hasAnyName' with a different type: 'const VariadicFunction<...>' vs 'const

Re: [clang] 849c605 - PR47792: Include the type of a pointer or reference non-type template

I've reverted this in ba2dff0159fcd1d2349bc610331914618ca9bc30 because it also caused a build failure when building a stage 2 clang: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24177/console FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rsmith created this revision. rsmith added reviewers: rjmccall, aaron.ballman. Herald added a project: clang. rsmith requested review of this revision. Such code will not work in general; we might have already used the non-weakness, for example when constant-evaluating an address comparison

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

Please can you try building with https://reviews.llvm.org/D89212 applied first, and see if it produces any warnings? If so, you're probably hitting PR47663, and should fix that by moving the 'weak' attribute earlier. On Sun, 11 Oct 2020 at 11:18, Richard Smith wrote: > On Fri, 9 Oct 2020 at

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 297443. dougpuob added a comment. - Support to add Class prefix for Hungarian Notation. - Support to add Enum prefix for Hungarian Notation. - Support `unsigned long long`, `ULONG`, and `HANDLE` types and others. - Support options for Hungarian Notation in

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297444. MaskRay added a comment. Update X86.td ProcModel Update llvm/test/CodeGen/X86/cpus-other.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files:

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay added inline comments. Comment at: llvm/lib/Target/X86/X86.td:580 // Nehalem - list NHMFeatures = [FeatureX87, -FeatureCMPXCHG8B, -FeatureCMOV, -

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. Please can you add an entry to the 12.00 release notes describing this? Maybe somewhere in the clang docs as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge updated this revision to Diff 297445. nridge marked an inline comment as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/new/ https://reviews.llvm.org/D88469 Files:

[PATCH] D89198: [X86] Define __LAHF_SAHF__ if feature 'sahf' is set

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89198/new/ https://reviews.llvm.org/D89198

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. In D88363#2319242 , @bdf wrote: > In D88363#2319157 , @jmorse wrote: > >> In D88363#2317241 , @Mordante wrote: >> >>> Can you explain the kind of

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis updated this revision to Diff 297458. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 Files: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the additional information. I agree that the current situation seems a bit arbitrary. I did some further research to see what GCC allows https://godbolt.org/. I've updated the patch to match that behavior.

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante updated this revision to Diff 297456. Mordante added a comment. Match the behavior of `const_cast` to match GCC's behavior. N4261 was proposed as solution to DR330. Since GCC allows the new `const_cast` behavior retroactively the patch also matches that behavior and no longer restricts

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. In D88154#2314352 , @spatel wrote: > In D88154#2310653 , > @venkataramanan.kumar.llvm wrote: > >> In D88154#2290205 , @abique

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

On Fri, 9 Oct 2020 at 19:12, Arthur Eubanks wrote: > I think this is the cause of https://crbug.com/1134762. Can we > speculatively revert while coming up with a repro? Or would you like a > repro first? > If you're blocked on this, sure, please go ahead and revert until you have a repro. But

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297480. venkataramanan.kumar.llvm added a comment. Changed library naming to LIBMVEC-X86 as per comments and also selected based on Target Tripple in clang. I am still working on auto generating FileCheck for the test cases. CHANGES

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay added a comment. In D89197#2323979 , @craig.topper wrote: > In D89197#2323946 , @MaskRay wrote: > >> Test __LAHF_SAHF__ >> Update clang/docs/ReleaseNotes.rst >> Update clang/test/CodeGen/attr-target-x86.c

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 ___ cfe-commits mailing list

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge updated this revision to Diff 297482. nridge added a comment. Slightly simplified test (base class does not need to be a template to trigger the issue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsMultiFile) { + MockFS FS; kadircet wrote: > kadircet wrote: > > nridge

[clang-tools-extra] f82346f - [clangd] Avoid relations being overwritten in a header shard

Author: Nathan Ridge Date: 2020-10-11T15:32:54-04:00 New Revision: f82346fd7391fdd15b77355deb6f7c030a89dcb5 URL: https://github.com/llvm/llvm-project/commit/f82346fd7391fdd15b77355deb6f7c030a89dcb5 DIFF: https://github.com/llvm/llvm-project/commit/f82346fd7391fdd15b77355deb6f7c030a89dcb5.diff

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf82346fd7391: [clangd] Avoid relations being overwritten in a header shard (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge added a reviewer: sammccall. nridge added a comment. Sam, perhaps you could have a look at this? It involves tricky macro location stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88463/new/ https://reviews.llvm.org/D88463

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

nikic added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:560 // Fold away bit casts of the loaded value by loading the desired type. - // We can do this for BitCastInsts as well as casts from and to pointer types, - // as long

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

thakis added a comment. https://clang.llvm.org/docs/ThinLTO.html#controlling-backend-parallelism should probably be updated to mention "all". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75153/new/ https://reviews.llvm.org/D75153

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri added a comment. In D88979#2323935 , @nikic wrote: > LGTM @nlopes does this look good to you? > Looking through other uses of isNoopCast(), I don't think it makes sense to > push this change into it, as many other usages do need it to work

[clang] cbe4d97 - [X86] Define __LAHF_SAHF__ if feature 'sahf' is set or 32-bit mode

Author: Fangrui Song Date: 2020-10-11T09:46:00-07:00 New Revision: cbe4d973edadba7664ab8783770fa51742cd93b9 URL: https://github.com/llvm/llvm-project/commit/cbe4d973edadba7664ab8783770fa51742cd93b9 DIFF: https://github.com/llvm/llvm-project/commit/cbe4d973edadba7664ab8783770fa51742cd93b9.diff

[PATCH] D89198: [X86] Define __LAHF_SAHF__ if feature 'sahf' is set or 32-bit mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbe4d973edad: [X86] Define __LAHF_SAHF__ if feature sahf is set or 32-bit mode (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297473. MaskRay added a comment. Test __LAHF_SAHF__ Update clang/docs/ReleaseNotes.rst Update clang/test/CodeGen/attr-target-x86.c to test X86.td changes. Ideally "target-features" should be testable with llc to have better layering Repository: rG LLVM

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

nlopes accepted this revision. nlopes added a comment. In D88979#2323940 , @lebedev.ri wrote: > In D88979#2323935 , @nikic wrote: > >> LGTM > > @nlopes does this look good to you? > >> Looking through other uses of

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri added a comment. @nlopes @nikic thank you for the review! In D88979#2323948 , @nlopes wrote: > In D88979#2323940 , @lebedev.ri > wrote: > >> In D88979#2323935 ,

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

This revision was automatically updated to reflect the committed changes. Closed by commit rG544a6aa2674e: [InstCombine] combineLoadToOperationType(): dont fold int-ptr cast into load (authored by lebedev.ri). Changed prior to commit: https://reviews.llvm.org/D88979?vs=297217=297475#toc

[clang] 544a6aa - [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

Author: Roman Lebedev Date: 2020-10-11T20:24:28+03:00 New Revision: 544a6aa2674e3875e4014eafb101a982f9296439 URL: https://github.com/llvm/llvm-project/commit/544a6aa2674e3875e4014eafb101a982f9296439 DIFF: https://github.com/llvm/llvm-project/commit/544a6aa2674e3875e4014eafb101a982f9296439.diff

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

nikic added a comment. In D88979#2323940 , @lebedev.ri wrote: > In D88979#2323935 , @nikic wrote: > >> Looking through other uses of isNoopCast(), I don't think it makes sense to >> push this change into it, as

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

craig.topper added a comment. In D89197#2323946 , @MaskRay wrote: > Test __LAHF_SAHF__ > Update clang/docs/ReleaseNotes.rst > Update clang/test/CodeGen/attr-target-x86.c to test X86.td changes. Ideally > "target-features" should be testable with llc to

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Mordante requested review of this revision. This implements the likelihood attribute for the switch statement. Based on the discussion in D85091

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

JonasToth added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4658 +/// functionDecl(isWeak()) +/// matches the weak declaration foo, but not bar. +AST_MATCHER(FunctionDecl, isWeak) { return Node.isWeak(); } Short oversight. Please

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis added a comment. In D89194#2323868 , @JonasToth wrote: > LGTM. > Short reminder to please use full context patches. Its not an issue right > now, but review sometimes just needs the context to understand the changes :) Sorry. Done.

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:563 if (auto* CI = dyn_cast(LI.user_back())) - if (CI->isNoopCast(DL)) + if (CI->isNoopCast(DL) && LI.getType()->isPtrOrPtrVectorTy() == +

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

JonasToth accepted this revision. JonasToth added a comment. I am fine now, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

JonasToth added a comment. You can land it. Worst case would be post-commit comments, but this is not a complicated patch and should be fine! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 ___

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

lebedev.ri added a comment. In D89194#2323920 , @JonasToth wrote: > You can land it. Worst case would be post-commit comments, but this is not a > complicated patch and should be fine! +1 @JonasToth Thanks! CHANGES SINCE LAST ACTION

[PATCH] D89204: Make likelihood lit test less brittle

Mordante created this revision. Mordante added a reviewer: jmorse. Mordante added a project: clang. Mordante requested review of this revision. Jeremy Morse discovered an issue with the lit test introduced in D88363 . The test gives different results for Sony's

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante added a comment. I created D89204 which hopefully fixes Sony's issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88363/new/ https://reviews.llvm.org/D88363

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis updated this revision to Diff 297462. zinovy.nis added a comment. - Updated docs on the matcher. - Register the new matcher. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 Files:

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis added a comment. Done. Any other comments/ideas? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

lebedev.ri accepted this revision. lebedev.ri added a comment. Since this is touching more than just a clang-tidy check i still want someone else to sign off, but this looks ok to me in principle. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

JonasToth accepted this revision. JonasToth added a comment. LGTM. Short reminder to please use full context patches. Its not an issue right now, but review sometimes just needs the context to understand the changes :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis updated this revision to Diff 297463. zinovy.nis added a comment. Full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 Files: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

JonasToth added a comment. The context thingie was not that important here, but still thanks :) Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4658 +/// functionDecl(isWeak()) +/// matches the weak declaration foo, but not bar. +AST_MATCHER(FunctionDecl, isWeak) {

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

nlopes added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:563 if (auto* CI = dyn_cast(LI.user_back())) - if (CI->isNoopCast(DL)) + if (CI->isNoopCast(DL) && LI.getType()->isPtrOrPtrVectorTy() == +

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

JonasToth added a comment. The issue is resolved now in the CppCoreGuidelines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79113/new/ https://reviews.llvm.org/D79113 ___ cfe-commits mailing list

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis updated this revision to Diff 297468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/ https://reviews.llvm.org/D89194 Files: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

zinovy.nis added a comment. In D89194#2323917 , @JonasToth wrote: > I am fine now, thank you! Thanks! Is this patch ready for landing? Or should I wait for a few more approvals? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89194/new/

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297469. MaskRay added a comment. Add release note Fix F16C and BMI of x86-64-v3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files:

[clang-tools-extra] 32d565b - [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

Author: Zinovy Nis Date: 2020-10-11T18:52:38+03:00 New Revision: 32d565b4618d31511e79dbe77aae8d456f2bf466 URL: https://github.com/llvm/llvm-project/commit/32d565b4618d31511e79dbe77aae8d456f2bf466 DIFF: https://github.com/llvm/llvm-project/commit/32d565b4618d31511e79dbe77aae8d456f2bf466.diff

[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG32d565b4618d: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:563 if (auto* CI = dyn_cast(LI.user_back())) - if (CI->isNoopCast(DL)) + if (CI->isNoopCast(DL) && LI.getType()->isPtrOrPtrVectorTy() == +

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Looking through other uses of isNoopCast(), I don't think it makes sense to push this change into it, as many other usages do need it to work with ptrtoint/inttoptr (some of them using it