[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

gamesh411 added a comment. In D89528#2334795 , @martong wrote: > What is the context here? Did it cause any crash/bug or were you just reading > through the code for a good night sleep? :D Actually I was debugging thru iterator-related code and was

[clang] 45a15dc - [clang-rename] Fix rename on function template specializations.

Author: Haojian Wu Date: 2020-10-19T09:32:17+02:00 New Revision: 45a15dc682c06b95cd9182a889e972e93b58aa8e URL: https://github.com/llvm/llvm-project/commit/45a15dc682c06b95cd9182a889e972e93b58aa8e DIFF: https://github.com/llvm/llvm-project/commit/45a15dc682c06b95cd9182a889e972e93b58aa8e.diff

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45a15dc682c0: [clang-rename] Fix rename on function template specializations. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[clang] 1e32df2 - [clang-rename] Fix rename on variable templates.

Author: Haojian Wu Date: 2020-10-19T09:44:59+02:00 New Revision: 1e32df2f91f1aa1f8cd400ce50a621578fa0534e URL: https://github.com/llvm/llvm-project/commit/1e32df2f91f1aa1f8cd400ce50a621578fa0534e DIFF: https://github.com/llvm/llvm-project/commit/1e32df2f91f1aa1f8cd400ce50a621578fa0534e.diff

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e32df2f91f1: [clang-rename] Fix rename on variable templates. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13e22961f8b4: [clang] update of the DragonFlyBSDs driver for the 5.8.x releases (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 13e2296 - [clang] update of the DragonFlyBSD's driver for the 5.8.x releases

Author: David Carlier Date: 2020-10-19T14:04:49+01:00 New Revision: 13e22961f8b45fb76e6d60c0f987a07009815f02 URL: https://github.com/llvm/llvm-project/commit/13e22961f8b45fb76e6d60c0f987a07009815f02 DIFF: https://github.com/llvm/llvm-project/commit/13e22961f8b45fb76e6d60c0f987a07009815f02.diff

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski updated this revision to Diff 299033. awarzynski added a comment. Simplify the API for creating output files The originally implemented API was overly complicated and not yet required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall updated this revision to Diff 298959. sammccall added a comment. Oops, forgot newly added files :-\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files:

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520

[clang-tools-extra] d0f2874 - [clangd] Add $/memoryUsage LSP extension

Author: Kadir Cetinkaya Date: 2020-10-19T12:30:25+02:00 New Revision: d0f287464d8a2b6940cc968850b7a013c665981a URL: https://github.com/llvm/llvm-project/commit/d0f287464d8a2b6940cc968850b7a013c665981a DIFF:

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

njames93 added a comment. Come to think of it, this is a pretty illogical way to solve this problem, just append `::std::function` to the AllowedTypes vector in `registerMatchers` and be do with it. Will require dropping the const Qualifier on AllowedTypes, but aside from that it is a much

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

devnexen created this revision. devnexen added reviewers: sepavloff, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. devnexen requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89690 Files:

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 299014. david-arm added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX marked 2 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 added a comment. In D87830#2336572 , @njames93 wrote: > Probably not quite as verbose but should do the job > > // RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* > -- -std=c++11 Thanks  ! I can live with this

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 299034. ArcsinX added a comment. Comments fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89529/new/ https://reviews.llvm.org/D89529 Files:

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall updated this revision to Diff 298961. sammccall added a comment. (for real this time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

ZarkoCA created this revision. ZarkoCA added reviewers: Xiangling_L, cebowleratibm, sfertile. Herald added subscribers: llvm-commits, cfe-commits, dang, dmgreen, arphaman, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. ZarkoCA requested review of this revision. Added support

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 299017. ArcsinX added a comment. auto => StringRef add comment for `llvm::sys::path::native()` call Result.str().str() => std::string(Result) add back removed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88239/new/ https://reviews.llvm.org/D88239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3696-3697 + +if (E->isValueDependent() || E->isTypeDependent()) + continue; + Should this move up above the point where we're checking whether the expression has an array

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f287464d8a: [clangd] Add $/memoryUsage LSP extension (authored by kadircet). Changed prior to commit:

[clang] 0628bea - Revert "[PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting"

Author: Hans Wennborg Date: 2020-10-19T12:31:14+02:00 New Revision: 0628bea5137047232f37c94b74bf26aa9b55f605 URL: https://github.com/llvm/llvm-project/commit/0628bea5137047232f37c94b74bf26aa9b55f605 DIFF: https://github.com/llvm/llvm-project/commit/0628bea5137047232f37c94b74bf26aa9b55f605.diff

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hans added a comment. This broke Chromium's build, causing it to fail with "Cannot pop empty stack!" from one of the backend passes. That specific error is probably a perhaps a previously existing problem, but I think it was triggered by hot-cold-splitting getting enabled by this pass. This

[PATCH] D89297: [clangd] Add a TestWorkspace utility

kadircet added a comment. thanks this mostly looks good. can you move implementations from TestWorkspace.h to TestWorkspace.cpp ? Comment at: clang-tools-extra/clangd/unittests/FileIndexTests.cpp:431 +TEST(FileIndexTest, RelationsMultiFile) { + TestWorkspace

[clang-tools-extra] accda62 - [nfc][clang-change-namespace] Remove unnecessary isScoped EnumDecl Matcher

Author: Nathan James Date: 2020-10-19T12:53:51+01:00 New Revision: accda625b8e10393f5ea681845dd6602c0096680 URL: https://github.com/llvm/llvm-project/commit/accda625b8e10393f5ea681845dd6602c0096680 DIFF: https://github.com/llvm/llvm-project/commit/accda625b8e10393f5ea681845dd6602c0096680.diff

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2336335 , @rjmccall wrote: > We can't have it always match, that would require us to reject the conversion > to a bare function-pointer type, which is required by the standard. > > I'm not sure if MSVC's multiple

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Also, please hit "Done" on the comments you resolved so that it's easier to track which ones are fixed, otherwise it's hard to follow :( The patch looks good now, almost ready

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

Anastasia added a comment. In D89520#2335628 , @rsmith wrote: > In D89520#2334477 , @Anastasia wrote: > >>> I couldn't find any spec justification for accepting the kinds of cases >>> that D20090

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if (!Path.endswith(PosixSeparator))

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 298994. ZarkoCA added a comment. Fixed typo in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/lib/Target/PowerPC/PPCCallingConv.td

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

njames93 added a comment. It may be a pain, but I'd also like to see an option like `RemovePrefix`. Generally most unscoped enums constants have prefixes based on the enum name. A simple way around this would just be to get the longest common prefix in all the enums constants. There is probably

[clang] 7fe7d9b - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: Simon Pilgrim Date: 2020-10-19T11:48:31+01:00 New Revision: 7fe7d9b130d4318274eb8b17f15542013e59ca32 URL: https://github.com/llvm/llvm-project/commit/7fe7d9b130d4318274eb8b17f15542013e59ca32 DIFF: https://github.com/llvm/llvm-project/commit/7fe7d9b130d4318274eb8b17f15542013e59ca32.diff

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

njames93 added a comment. Should point out there is already a check for cert-oop57-cpp, added in D72488 . Do these play nice with each other or should they perhaps be merged or share code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89690/new/ https://reviews.llvm.org/D89690

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm marked an inline comment as done. david-arm added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueExpr, St->getBeginLoc())) +return

[PATCH] D77062: [analyzer] [NFC] Simplify CStringChecke::assumeZero function

ASDenysPetrov updated this revision to Diff 299018. ASDenysPetrov retitled this revision from "[analyzer] Improve zero assumption in CStringChecke::assumeZero" to "[analyzer] [NFC] Simplify CStringChecke::assumeZero function". ASDenysPetrov edited the summary of this revision. ASDenysPetrov

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 298991. ZarkoCA marked 3 inline comments as done. ZarkoCA retitled this revision from "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option" to "[PPC][AIX] Add vector callee saved registers for AIX extended

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if (!Path.endswith(PosixSeparator))

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. In D89529#2337197 , @ArcsinX wrote: > In D89529#2334517 , @kbobyrev wrote: > >> The solution

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:242 // Add only valid headers. - Header.IncludeHeader = Strings.save( - URI::createFile("/usr/local/user/home/project/Header.h").toString());

[PATCH] D89685: [clangd] Rename edge name for filesymbols to slabs in memorytree

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was causing duplicate `symbols`

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

njames93 added a comment. In D85697#2234468 , @janosbenjaminantal wrote: > The known "limitations" are mostly similar to other checks: > > - It cannot detect unfixable cases from other translation units. Practically > that means if an `enum` is used in

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:621-623 + if (auto AT = TL->getAs()) +S = AT.getModifiedLoc() +.getSourceRange(); // should we just return false? dgoldman wrote: > Let me know if

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff added inline comments. Comment at: clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics-constrained.c:26 +// metadata from the AST instead of the global default from the command line. +// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. + kpn

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 299039. arichardson added a comment. Herald added a subscriber: mgorny. Split the token annotion test into a separate file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

FStefanni added a comment. Hi, thank you for the suggestion, but it does **not**, at least with `BreakConstructorInitializers: AfterColon` (which is what I use). If initializers are "small enough" to fit the constructor line, all will finish on the same line. E.g. MyClass::MyClass(): a(),

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin marked an inline comment as done. AlexanderLanin added a comment. Could someone commit this as I cannot? Thanks a lot! Alexander Lanin Thanks for review @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl updated this revision to Diff 299044. yaxunl marked 2 inline comments as done. yaxunl added a comment. Add constructors to StreamingDiagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:410 + if (const auto *EnumConst = dyn_cast(D)) {

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:611 + // robust. + return false; if (!SelChecker.mayHit(S)) { I'm not sure we actually want to *do it* at this point, as you're seeing we may have some unintended

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:63 + +llvm::GlobalVariable *CGOpenMPRuntimeNVPTX::allocateTransferMediumGlobal( +CodeGenModule , llvm::ArrayType *Ty, StringRef TransferMediumName) { Perhaps (typed

[PATCH] D89702: [clang] [msvc] Automatically link against oldnames just as linking against libcmt

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth. Herald added a project: clang. mstorsjo requested review of this revision. If invoking clang-cl, both libcmt (or another lib, depending on the /M[TD](|d) options) and oldnames are passed as dependent libs. If compiling and

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2580-2581 if (!isStructEmpty(Base.getType())) { llvm::Optional Size = structHasUniqueObjectRepresentations( Context, Base.getType()->castAs()->getDecl()); if (!Size)

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299081. jhuber6 added a comment. Checking tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696 Files: clang/test/OpenMP/driver-openmp-target.c

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:131 +} +/*FunctionCallCollector Collector{[](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) Remove commented-out code?

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG866dc0978449: [clang-tidy] Better support for Override function in RenamerClangTidy based… (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D79674?vs=298616=299043#toc

[clang-tools-extra] 866dc09 - [clang-tidy] Better support for Override function in RenamerClangTidy based checks

Author: Nathan James Date: 2020-10-19T15:21:06+01:00 New Revision: 866dc09784495bd2c204945144cd31cd8e653f0e URL: https://github.com/llvm/llvm-project/commit/866dc09784495bd2c204945144cd31cd8e653f0e DIFF: https://github.com/llvm/llvm-project/commit/866dc09784495bd2c204945144cd31cd8e653f0e.diff

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

arichardson created this revision. arichardson added a reviewer: bkramer. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. arichardson requested review of this revision. This allows removing the clangAST dependency from libclangToolingCore and therefore allows

[PATCH] D89699: [ExtVector] Make .even/.odd/.lo/.hi return vectors for single elements.

scanon added a comment. I'm fairly certain that this will cause some breaks internally at Apple, but I'm also pretty sure that it's a step in the right direction, and we should just sign up to fix any issues it causes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. With that change, somehow this extract test is now failing: - TEST 'Clangd Unit Tests :: ./ClangdTests/ExtractFunctionTest.FunctionTest' FAILED Note: Google Test filter = ExtractFunctionTest.FunctionTest [==] Running 1 test from 1 test

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

aaron.ballman added a comment. In D89332#2338319 , @njames93 wrote: > Come to think of it, this is a pretty illogical way to solve this problem, > just append `::std::function` to the AllowedTypes vector in > `registerMatchers` and be do with it. Will

[clang-tools-extra] b91a236 - Revert "Extend tests of run-clang-tidy"

Author: Aaron Ballman Date: 2020-10-19T10:37:22-04:00 New Revision: b91a236ee1c3e9fa068df058164385732cb46bba URL: https://github.com/llvm/llvm-project/commit/b91a236ee1c3e9fa068df058164385732cb46bba DIFF: https://github.com/llvm/llvm-project/commit/b91a236ee1c3e9fa068df058164385732cb46bba.diff

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman added a comment. In D74299#2338823 , @aaron.ballman wrote: > In D74299#2338772 , @AlexanderLanin > wrote: > >> Could someone commit this as I cannot? Thanks a lot! >> Alexander Lanin >> >> Thanks

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

sammccall added a subscriber: rsmith. sammccall added a comment. In D86936#2338664 , @erichkeane wrote: > Why did we select the 'bracket-depth' for this? The documentation on that > doesn't seem to be anything close to what this should be based on:

[PATCH] D89709: [clang-format] Drop clangFrontend dependency for FormatTests

arichardson created this revision. arichardson added reviewers: klimek, MyDeveloperDay. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. arichardson requested review of this revision. This allows building the clang-format unit tests in only 657 ninja steps rather than

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

erichkeane added a comment. In D86936#2338664 , @erichkeane wrote: > Why did we select the 'bracket-depth' for this? The documentation on that > doesn't seem to be anything close to what this should be based on: > > Sets the limit for nested

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2608 +continue; + else if (!Context.hasUniqueObjectRepresentations(Field->getType())) +return llvm::None; You can drop the `else` after this sorta-return if you'd

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. SourceLocation implements `operator<`, so `SourceLocation`-s can be used as keys in `std::map` directly, there is no

[PATCH] D89699: [ExtVector] Make .even/.odd/.lo/.hi return vectors for single elements.

scanon added a comment. I guess the counterargument here would be that `.x` does not produce an extvector(1), and there is at least a plausible argument that `.x` should be the same as `.lo` for a two-element vector. I'm not really convinced by this, but it's not totally outrageous.

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

erichkeane added subscribers: rjmccall, erichkeane. erichkeane added a comment. Why did we select the 'bracket-depth' for this? The documentation on that doesn't seem to be anything close to what this should be based on: Sets the limit for nested parentheses, brackets, and braces to N in

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299038. dgoldman marked 5 inline comments as done. dgoldman added a comment. Update with changes requested - Looking into extract failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/

[PATCH] D89699: [ExtVector] Make .even/.odd/.lo/.hi return vectors for single elements.

fhahn created this revision. fhahn added reviewers: rjmccall, jfb, scanon, rsmith, hfinkel. Herald added a subscriber: dexonsmith. Herald added a project: clang. fhahn requested review of this revision. Currently the 'swizzle' accessors .even/.odd/.lo/.hi return a scalar instead of a vector with

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6435-6436 +Attr *WeakA = nullptr; +for (Attr *A : VD->getAttrs()) { + if (!isa(A)) +continue; rsmith wrote: > aaron.ballman wrote: > > Ah, it's too bad that

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list

[clang-tools-extra] 4074914 - [clangd] Rename edge name for filesymbols to slabs in memorytree

Author: Kadir Cetinkaya Date: 2020-10-19T16:09:46+02:00 New Revision: 40749141030b8172b8490ebbdcd0d3440cbe041b URL: https://github.com/llvm/llvm-project/commit/40749141030b8172b8490ebbdcd0d3440cbe041b DIFF:

[PATCH] D89685: [clangd] Rename edge name for filesymbols to slabs in memorytree

This revision was automatically updated to reflect the committed changes. Closed by commit rG40749141030b: [clangd] Rename edge name for filesymbols to slabs in memorytree (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89696/new/ https://reviews.llvm.org/D89696

[clang-tools-extra] 86ef379 - [clang-tidy] Add scoped enum constants to identifier naming check

Author: Nathan James Date: 2020-10-19T15:57:47+01:00 New Revision: 86ef379800162e5d6bb0d478c5bfb4b56498a272 URL: https://github.com/llvm/llvm-project/commit/86ef379800162e5d6bb0d478c5bfb4b56498a272 DIFF: https://github.com/llvm/llvm-project/commit/86ef379800162e5d6bb0d478c5bfb4b56498a272.diff

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

This revision was automatically updated to reflect the committed changes. Closed by commit rG86ef37980016: [clang-tidy] Add scoped enum constants to identifier naming check (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D89407?vs=298349=299058#toc Repository: rG

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D72218#2334787 , @ffrankies wrote: > Addressed comments by @aaron.ballman regarding the diagnostic warning. > > I tried to add a test

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2338794 , @kbobyrev wrote: > Thank you for the patch! Ready to land it now. Thank you for review! > Please update the patch message before commiting though: > >> Without this patch 7 marshalling tests fails on Windows.

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in `SourceLocation` into https://reviews.llvm.org/D89705. > A general comment is that there are a couple of functional changes in this > patch,

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2868 +Only supported On AIX. Specify usage of volatile and nonvolatile vector registers, the extended vector ABI on AIX. Defaults to '-mnovecnvol' when Altivec is enabled. +

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:611 + // robust. + return false; if (!SelChecker.mayHit(S)) { sammccall wrote: > I'm not sure we actually want to *do it* at this point, as you're seeing we > may

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

aaron.ballman added a comment. I tend to be very skeptical of the value of checks that basically throw out entire usable chunks of the base language because the check is effectively impossible to apply to an existing code base. Have you run the check over large C++ code bases to see just how

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. There's frontend changes anyway, so there should be changes for the predefined macros? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1481 +def DarwinABI : DeclOrTypeAttr { + let Spellings = [GCC<"darwin_abi">]; +// let Subjects = [Function, ObjCMethod]; I suspect this should be using the `Clang` spelling as I

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thank you for the patch! Ready to land it now. Please update the patch message before commiting though: > Without this patch 7 marshalling tests fails on Windows. > This patch contains

[clang-tools-extra] 627c01b - Extend tests of run-clang-tidy

Author: Alexander Lanin Date: 2020-10-19T10:29:08-04:00 New Revision: 627c01bee0deb353b3e3e90c1b8d0b6d73464466 URL: https://github.com/llvm/llvm-project/commit/627c01bee0deb353b3e3e90c1b8d0b6d73464466 DIFF:

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman closed this revision. aaron.ballman added a comment. In D74299#2338772 , @AlexanderLanin wrote: > Could someone commit this as I cannot? Thanks a lot! > Alexander Lanin > > Thanks for review @aaron.ballman! Happy to do so! I've commit on

[PATCH] D89700: [clangd] Don't offer to expand auto in structured binding declarations.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. auto must be used for the code to parse.

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

arichardson updated this revision to Diff 299054. arichardson added a comment. fix name of test class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88956/new/ https://reviews.llvm.org/D88956 Files: clang/lib/Format/TokenAnnotator.cpp

[clang-tools-extra] cf814fc - [clangd] Add test for structured-binding completion. NFC

Author: Sam McCall Date: 2020-10-19T16:45:51+02:00 New Revision: cf814fcd3939a705f8bdf67bcf54cbf821aa6f75 URL: https://github.com/llvm/llvm-project/commit/cf814fcd3939a705f8bdf67bcf54cbf821aa6f75 DIFF: https://github.com/llvm/llvm-project/commit/cf814fcd3939a705f8bdf67bcf54cbf821aa6f75.diff

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. Yeah, it might be reasonable to just do that on targets where the defaults are different (just MSVC, I think?) and otherwise preserve the method's calling convention. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2339192 , @rjmccall wrote: > Yeah, it might be reasonable to just do that on targets where the defaults > are different (just MSVC, I think?) and otherwise preserve the method's > calling convention. I think it is

  1   2   >