erichkeane added a comment. In D89559#2339192 <https://reviews.llvm.org/D89559#2339192>, @rjmccall wrote:
> Yeah, it might be reasonable to just do that on targets where the defaults > are different (just MSVC, I think?) and otherwise preserve the method's > calling convention. I think it is actually just MSVC-32 bit! Since the work is 99% the same, I think I should start doing that (emitting BOTH in the case where it matches the default member but NOT the default free function CC) in this review, then do a separate commit for the MSVC compat mode where we emit a version for ALL of the calling conventions. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
