[PATCH] D90192: WIP: Speculative fix for ASTImporter crash with SLocEntry changes

dexonsmith created this revision. dexonsmith added a reviewer: teemperor. Herald added subscribers: ributzka, martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. dexonsmith requested review of this revision. This is a speculative fix for the ASTImporter crash in

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith planned changes to this revision. dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:219 + return FileEntryRef(*SeenFileInsertResult.first); +return FileEntryRef(*Value.V.get()); } arphaman wrote: > It looks like

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, manojgupta, rnk. Herald added subscribers: cfe-commits, dexonsmith, pengfei. Herald added a project: clang. nickdesaulniers requested review of this revision. Follow up to: 1. commit b7926ce6d7a8

[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

bsaleil updated this revision to Diff 300805. bsaleil added a comment. Herald added a subscriber: dexonsmith. Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81748/new/ https://reviews.llvm.org/D81748 Files:

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300754. tianshilei1992 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LinuxKernelTidyModule.cpp:25 "linuxkernel-must-check-errs"); +CheckFactories.registerCheck( +"linuxkernel-switch-semi"); Please fix the linter error, here

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman, ldionne. Herald added subscribers: dexonsmith, ributzka, arphaman, jkorous. erik.pilkington requested review of this revision. This attribute applies to a using declaration, and permits importing a

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

sfertile added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:6 + +// RUN: %clang_cc1 -triple powerpc-unknown-aix -mcmodel=large -fvisibility-inlines-hidden -emit-llvm -o - -x c++ %s | \ +// RUN: FileCheck

[PATCH] D90079: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4c667c9af03: Avoid unnecessary uses of `MDNode::getTemporary`, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90187/new/ https://reviews.llvm.org/D90187

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

kiranchandramohan added a comment. I have added a fix to run the test only when the X86 target is available. Please feel free to change if it is not the correct fix. https://github.com/llvm/llvm-project/commit/c551ba0e90bd2b49ef501d591f8362ba44e5484d Repository: rG LLVM Github Monorepo

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers added a comment. > An alternative approach to consider would be not adding a new enum, and > making -stack-protector ALWAYS be specified when invoking cc1. I did not > quantify the amount of changes to existing tests, but am happy to do so if > reviewers would like. Making

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

tra added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + yaxunl wrote: > tra wrote: > > I don't think it's a good idea to force this. > > > > Perhaps a better

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

Reduces to: int d; int = d; double e = h; ... but only fails under -fms-compatibility. On Mon, 26 Oct 2020 at 13:46, Nico Weber wrote: > The original snippet: > > const int64_t& kGraceMs = > AffiliationFetchThrottler::kGracePeriodAfterReconnectMs; >

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, martong wrote: > This seems a bit redundant to `Attrs.td`. I'd prefer to

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith added a comment. In D89749#2354386 , @dexonsmith wrote: > That means it's not safe to store an address from `getSLocEntry` when there > will be another call. I can update `ASTImporter` to use a copy, but I think > this is too much of a

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. Yes, this automates the fixit to something precise. There are about 10,000 problems in the kernel with -Wextra-semi, all of those fixes would be too many and diverse to practically submit. Also the -Wextra-semi fix removes just the semi and so it's fix will fail the

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante planned changes to this revision. Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1854 + for(int i = 0; i != size; ++i) [[likely]] { +... // The loop the likely path of

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + tra wrote: > I don't think it's a good idea to force this. > > Perhaps a better way to address this

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 300780. arames added a comment. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

sfertile added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[libunwind] df6d2e8 - [libunwind] Add -Wno-dll-attribute-on-redeclaration when building for windows

Author: Martin Storsjö Date: 2020-10-26T23:23:01+02:00 New Revision: df6d2e8ab1a4212284e4763724a2211df2c7394a URL: https://github.com/llvm/llvm-project/commit/df6d2e8ab1a4212284e4763724a2211df2c7394a DIFF:

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith added a comment. @teemperor, I don't get test failures: % (cd build && env LIT_FILTER=Modules ninja -k20 check-lldb) ld: warning: spew Testing Time: 10.54s Excluded : 2105 Unsupported: 17 Passed : 13 Could this be because I used

[clang] c551ba0 - Run test only if X86 target is available

Author: Kiran Chandramohan Date: 2020-10-26T21:28:59Z New Revision: c551ba0e90bd2b49ef501d591f8362ba44e5484d URL: https://github.com/llvm/llvm-project/commit/c551ba0e90bd2b49ef501d591f8362ba44e5484d DIFF: https://github.com/llvm/llvm-project/commit/c551ba0e90bd2b49ef501d591f8362ba44e5484d.diff

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames

[clang] a2ac64d - Revert "Ensure that checkInitIsICE is called exactly once for every variable"

Author: Zequan Wu Date: 2020-10-26T11:59:55-07:00 New Revision: a2ac64dd905422ed84e273a98d846df022a5e2ec URL: https://github.com/llvm/llvm-project/commit/a2ac64dd905422ed84e273a98d846df022a5e2ec DIFF: https://github.com/llvm/llvm-project/commit/a2ac64dd905422ed84e273a98d846df022a5e2ec.diff

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 300796. compnerd added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files:

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

Fixed in a5c7b46862ec0531964eb52329cdf009862abecf. On Mon, 26 Oct 2020 at 15:59, Richard Smith wrote: > Reduces to: > > int d; > int = d; > double e = h; > > ... but only fails under -fms-compatibility. > > On Mon, 26 Oct 2020 at 13:46, Nico Weber wrote: > >> The original snippet: >> >>

[clang] a5c7b46 - Fix checking for C++98 ICEs in C++11-and-later mode to not consider use

Author: Richard Smith Date: 2020-10-26T16:59:48-07:00 New Revision: a5c7b46862ec0531964eb52329cdf009862abecf URL: https://github.com/llvm/llvm-project/commit/a5c7b46862ec0531964eb52329cdf009862abecf DIFF: https://github.com/llvm/llvm-project/commit/a5c7b46862ec0531964eb52329cdf009862abecf.diff

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

gribozavr2 added a comment. > I am having a hard time to accept "this is how it is implemented in our fork" > as a technical argument. Besides, I am not sure how could the Clang community > benefit about being backward compatible with a specialized fork and thus > making superfluous

[clang-tools-extra] 26750a1 - [clang-tidy] Silence unused variable warning in Release builds. NFCI.

Author: Benjamin Kramer Date: 2020-10-26T20:20:23+01:00 New Revision: 26750a1264b3df114a1efae7cde6f0784206b2ce URL: https://github.com/llvm/llvm-project/commit/26750a1264b3df114a1efae7cde6f0784206b2ce DIFF:

[clang-tools-extra] d071bba - [clangd] Add back dependency on proto generated targets

Author: Kirill Bobyrev Date: 2020-10-26T20:39:10+01:00 New Revision: d071bba9a4477290d0b164a2d338fb22ad2d3c3d URL: https://github.com/llvm/llvm-project/commit/d071bba9a4477290d0b164a2d338fb22ad2d3c3d DIFF:

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG22e6b1863e74: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 22e6b18 - SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-10-26T15:38:13-04:00 New Revision: 22e6b1863e74136908842d71b4f942313d89b273 URL: https://github.com/llvm/llvm-project/commit/22e6b1863e74136908842d71b4f942313d89b273 DIFF:

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 300791. dexonsmith added a comment. Adding a test for multi-level indirection. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://reviews.llvm.org/D89488 Files: clang/include/clang/Basic/FileManager.h

[clang] 5159732 - [CodeView] Emit static data members as S_CONSTANTs.

Author: Amy Huang Date: 2020-10-26T15:30:35-07:00 New Revision: 515973222ed29abe49f241e89edb6854f44162d4 URL: https://github.com/llvm/llvm-project/commit/515973222ed29abe49f241e89edb6854f44162d4 DIFF: https://github.com/llvm/llvm-project/commit/515973222ed29abe49f241e89edb6854f44162d4.diff

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 300811. dexonsmith added a comment. Updated to address remaining review comments. Note that we discussed double-redirection use case offline, and agreed it doesn't come up in practice (even with multiple RedirectingFileSystem layers) so we shouldn't

[clang] b698ad0 - [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

Author: Nathan James Date: 2020-10-27T00:03:43Z New Revision: b698ad00cbc76f34f48bb639ffb1cfee47a9737e URL: https://github.com/llvm/llvm-project/commit/b698ad00cbc76f34f48bb639ffb1cfee47a9737e DIFF: https://github.com/llvm/llvm-project/commit/b698ad00cbc76f34f48bb639ffb1cfee47a9737e.diff LOG:

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

This revision was automatically updated to reflect the committed changes. Closed by commit rGb698ad00cbc7: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90127?vs=300623=300831#toc Repository:

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e076a8d8099: Make sure Objective-C category support in IncludeSorter handles top-level… (authored by compositeprimes). Repository: rG LLVM

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 300766. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/LangOptions.def

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM with minor nit. Comment at: clang/lib/AST/Decl.cpp:1481 LinkageInfo LinkageComputer::getDeclLinkageAndVisibility(const NamedDecl *D) { - return getLVForDecl(D, -

[PATCH] D90063: [AIX] Also error on -G for link-only step

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d4aebbb9d99: [AIX] Also error on -G for link-only step (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D90063?vs=300391=300782#toc Repository: rG LLVM Github Monorepo

[clang] 3d4aebb - [AIX] Also error on -G for link-only step

Author: Xiangling Liao Date: 2020-10-26T16:51:28-04:00 New Revision: 3d4aebbb9d99642fcc277c8bd199ead400de2703 URL: https://github.com/llvm/llvm-project/commit/3d4aebbb9d99642fcc277c8bd199ead400de2703 DIFF:

[PATCH] D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rGad1b9daa4bf4: Prepend __uniq to symbol names hash with -funique-internal-linkage-names. (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] ad1b9da - Prepend "__uniq" to symbol names hash with -funique-internal-linkage-names.

Author: Sriraman Tallam Date: 2020-10-26T14:24:28-07:00 New Revision: ad1b9daa4bf40c1907794fd5de7807aad1f0553c URL: https://github.com/llvm/llvm-project/commit/ad1b9daa4bf40c1907794fd5de7807aad1f0553c DIFF:

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

njames93 added a comment. Is this not already handled by `-Wextra-semi`. If it isn't I feel like it should be handled there rather than in clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith marked 3 inline comments as done. dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:217 FileEntry *FE; -if (LLVM_LIKELY(FE = Value.dyn_cast())) - return FileEntryRef(SeenFileInsertResult.first->first(), *FE); -return

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, daltenty. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Since we fixed the definition of `SuitableAlign` here:

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

sfertile added a comment. Sorry, missed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:439 + static void enumeration(IO , EnumExtensibilityKind ) { +IO.enumCase(EEK, "none", EnumExtensibilityKind::None); +IO.enumCase(EEK,

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 300815. compnerd added a comment. Add more testing coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files:

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jdoerfert added a comment. Looks generally good. We seem to have way to many places dealing with the mapping stuff but that is not your fault. One thing I found weird though: Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8078 + for (auto LI =

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 300830. trixirt added a comment. Comment on the matcher Comment explaining need to look for empty macro Add test for normal switch Add test for switch with empty macro Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith added a comment. In D89749#2353602 , @teemperor wrote: > The tests are just loading a Clang module and then trying to import some > Decls into another ASTContext, so I don't think the error here is specific to > LLDB. We just don't have any

[clang] e56e7bd - Revert "Revert "Ensure that checkInitIsICE is called exactly once for every variable""

Author: Zequan Wu Date: 2020-10-26T12:08:57-07:00 New Revision: e56e7bd4698d29f6197a5f756b6f0bab02d0b3c8 URL: https://github.com/llvm/llvm-project/commit/e56e7bd4698d29f6197a5f756b6f0bab02d0b3c8 DIFF: https://github.com/llvm/llvm-project/commit/e56e7bd4698d29f6197a5f756b6f0bab02d0b3c8.diff

[clang-tools-extra] 1e076a8 - Make sure Objective-C category support in IncludeSorter handles top-level imports

Author: Joe Turner Date: 2020-10-26T12:24:43-07:00 New Revision: 1e076a8d8099a6c179c8773f2e621f9408ee2402 URL: https://github.com/llvm/llvm-project/commit/1e076a8d8099a6c179c8773f2e621f9408ee2402 DIFF: https://github.com/llvm/llvm-project/commit/1e076a8d8099a6c179c8773f2e621f9408ee2402.diff

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

Hi Richard, this makes clang assert when building chromium/win. https://bugs.chromium.org/p/chromium/issues/detail?id=1142009#c4 has a reduced repro. Could you take a look? Thanks, Nico On Mon, Oct 19, 2020 at 10:04 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > >

Re: [clang] 76c0092 - Ensure that checkInitIsICE is called exactly once for every variable

The original snippet: const int64_t& kGraceMs = AffiliationFetchThrottler::kGracePeriodAfterReconnectMs; ASSERT_NO_FATAL_FAILURE(AssertReleaseInBetween( true, kGraceMs * (1 - kPolicy.jitter_factor), kGraceMs)); kGracePeriod is declared here

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG357715ce97d0: [NFC] Remove max_align.c LIT testcase (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 357715c - [NFC] Remove max_align.c LIT testcase

Author: Xiangling Liao Date: 2020-10-26T17:14:30-04:00 New Revision: 357715ce97d0bc937301b0b006d145c24a9d23aa URL: https://github.com/llvm/llvm-project/commit/357715ce97d0bc937301b0b006d145c24a9d23aa DIFF:

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Argh, sorry! I meant to say "I have *no* objections". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

nickdesaulniers added a comment. In D90180#2354931 , @njames93 wrote: > Is this not already handled by `-Wextra-semi`. If it isn't I feel like it > should be handled there rather than in clang-tidy That was my initial thought too, but I think the value

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge abandoned this revision. nridge added a comment. Abandoning as per discussion. Running this locally has led me to propose D90134 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

nridge added a comment. My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me.

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

usaxena95 updated this revision to Diff 300582. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90014/new/ https://reviews.llvm.org/D90014 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh updated this revision to Diff 300587. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 Files:

[PATCH] D90133: clang-format: Allow fallback-style to take formatting arguments

Chizi123 updated this revision to Diff 300586. Chizi123 added a comment. Accidentally added patch to commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90133/new/ https://reviews.llvm.org/D90133 Files: clang/lib/Format/Format.cpp Index: clang/lib/Format/Format.cpp

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh added a comment. In D90130#2352826 , @dvyukov wrote: > This now looks like a patch for some other change :) Sorry! It's my first time with llvm patch submission. I think it's ok now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

nikic added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1439 if (CodeGenOpts.OptimizationLevel == 0) { + PB.runRegisteredEPCallbacks(MPM, Level, CodeGenOpts.DebugPassManager); + It should be possible to simplify this function a lot

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh marked 2 inline comments as done. mzh added a comment. Thanks @dvyukov All done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 ___ cfe-commits mailing

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. Looks good to me. Do you want me to merge this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Sorry about missing this... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! LG with comment nit Comment at: clang/lib/Sema/SemaOverload.cpp:12808 + // using RecoveryExpr. + return

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300590. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files:

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), sammccall wrote:

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh added a comment. In D90130#2352831 , @dvyukov wrote: > Looks good to me. > Do you want me to merge this change? Sure, Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir added a comment. This looks reasonable. I'm curious about DiagnosticsEngine: previously we were using the defaults for `client` and `ShouldOwnClient` ctor params (`nullptr` and `true`). If this usage leads to crashes, isn't the issue in `DiagnosticsEngine` itself? Repository: rG

[clang-tools-extra] 15f6bad - [clangd] Add dependency on remote index service proto

Author: Kirill Bobyrev Date: 2020-10-26T07:08:49+01:00 New Revision: 15f6bad6d74a993e366c8fc93a9c91f213ac6bc3 URL: https://github.com/llvm/llvm-project/commit/15f6bad6d74a993e366c8fc93a9c91f213ac6bc3 DIFF:

[PATCH] D90133: clang-format: Allow fallback-style to take formatting arguments

Chizi123 created this revision. Chizi123 added reviewers: llvm-commits, cfe-commits, djasper, rsmith, klimek. Herald added a project: clang. Chizi123 requested review of this revision. Currently, -style is capable of accepting configuration options in its argument, while -fallback-style must be

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/CommentLexer.h:244 + /// command, including command marker. + SmallString<16> VerbatimBlockEndCommandName; + I'm not a fan of this change to `Lexer` because it breaks the grouping of

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh updated this revision to Diff 300588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 Files: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp compiler-rt/lib/sanitizer_common/sanitizer_platform.h

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

dvyukov added a comment. This now looks like a patch for some other change :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 ___ cfe-commits mailing list

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 ___

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added a comment. In D90009#2354849 , @kiranchandramohan wrote: > I have added a fix to run the test only when the X86 target is available. > Please feel free to change if it is not the correct fix. >

[clang] aab50af - SourceManager: Use the same fake SLocEntry whenever it fails to load

Author: Duncan P. N. Exon Smith Date: 2020-10-26T20:56:28-04:00 New Revision: aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 URL: https://github.com/llvm/llvm-project/commit/aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 DIFF:

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2355443 , @Hiralo wrote: > In D90010#2355432 , @dblaikie wrote: > >> Looks like you might be able to do something like >> "llvm::errs().setBuffered()" ? > > Do we need to set it

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2355489 , @Hiralo wrote: > In D90010#2355460 , @dblaikie wrote: > >> In D90010#2355443 , @Hiralo wrote: >> >>> In D90010#2355432

[PATCH] D89748: SourceManager: Use the same fake SLocEntry whenever it fails to load

This revision was automatically updated to reflect the committed changes. Closed by commit rGaab50af8c18a: SourceManager: Use the same fake SLocEntry whenever it fails to load (authored by dexonsmith). Herald added a project: clang. Changed prior to commit:

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf7ffd4e1aa: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when… (authored by chandlerc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300869. tianshilei1992 added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. In D90010#2355490 , @dblaikie wrote: > By the looks of the code, you may want to call SetBufferSize only (do not > call SetBuffered after that - or it'll go back to the default buffer size of > 0. Oh! I missed it! For

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

njames93 added a comment. Taking a step back, clang-tidy checks are supposed to enforce guidelines for the specific module they live in. If there are 10'000 occurrences of a semi directly after a switch closing brace in the linux kernel code base it could be argued that its a style guideline of

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + tra wrote: > yaxunl wrote: > > tra wrote: > > > I don't think it's a good idea to force this. > > >

  1   2   3   >