[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. > This approach should be fully complementary to `vectorize_with` so that it > would be possible to have: > > // Use scalable vectors, but leave it to the cost-model to choose the most > efficient N in . > // If the pragma is not specified, it defaults to

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:68 +const SourceManager , Preprocessor *pp, Preprocessor *ModuleExpanderPP) { + PP = pp; +} whisperity wrote: > Global state is

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1267 assert(!isa(constant)); - emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant); + emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true); } jdoerfert

[clang] 2f3055c - [clang][cli] Add support for options with two flags for controlling the same field.

Author: Jan Svoboda Date: 2020-11-16T10:21:54+01:00 New Revision: 2f3055c543f8f5e8cd975350fae5f4b0ac4871c3 URL: https://github.com/llvm/llvm-project/commit/2f3055c543f8f5e8cd975350fae5f4b0ac4871c3 DIFF: https://github.com/llvm/llvm-project/commit/2f3055c543f8f5e8cd975350fae5f4b0ac4871c3.diff

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 305437. jansvoboda11 added a comment. Rebase and add documenting possible reference lifetime extension issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added a comment. Addressed review feedback. WDYT @Bigcheese? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH);

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 305439. abelkocsis added a comment. Fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

ehjogab created this revision. ehjogab added reviewers: dsanders, arsenm, qcolombet, ab, bjope, rovka. Herald added a project: clang. Herald added a subscriber: cfe-commits. ehjogab requested review of this revision. Herald added a subscriber: wdng. Change-Id:

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

peterwaller-arm added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp: if (srcIsVector || destIsVector) { +// We can bitcast between SVE VLATs and VLSTs, and vice-versa. +if (Self.isValidSveBitcast(SrcType, DestType)) { It's good to avoid

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added a comment. didn't finish all parts (looked at the FunctionDecl and RecordDecl), I think we need more documentation/comments in the code to specify the canonical behavior (templates are tricky). Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:239 + if

[PATCH] D83071: Add support for options with two flags for controlling the same field.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3055c543f8: [clang][cli] Add support for options with two flags for controlling the same… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90691/new/ https://reviews.llvm.org/D90691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca2e7e59994d: [IRGen] Add !annotation metadata for auto-init stores. (authored by fhahn). Changed prior to commit:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2380910 , @lebedev.ri wrote: > What i would however like to be improved, is better docs. I hope I'll addressed your questions in documentation. Please tell me whether you still have any unanswered questions. CHANGES

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305468. DaanDeMeyer added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Would you like me to commit this one on your behalf or would you like to request your own commit access

[clang] a6ac2b3 - Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T08:28:21-05:00 New Revision: a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8 URL: https://github.com/llvm/llvm-project/commit/a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8 DIFF: https://github.com/llvm/llvm-project/commit/a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8.diff

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'll land on your behalf momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91498/new/

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305489. DaanDeMeyer added a comment. Fix all the bugs after doing some proper testing. One thing we don't handle yet is header files since those don't appear in the compilation database. Maybe we need to add prebuilding for those as well? Repository:

[clang] 6c185ac - Revert "Move the test compiler setup in a common place. NFCI"

Author: Vitaly Buka Date: 2020-11-16T04:21:28-08:00 New Revision: 6c185acfffc1f7cdf2a6e785cb4a422140c34f06 URL: https://github.com/llvm/llvm-project/commit/6c185acfffc1f7cdf2a6e785cb4a422140c34f06 DIFF: https://github.com/llvm/llvm-project/commit/6c185acfffc1f7cdf2a6e785cb4a422140c34f06.diff

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted because of memory leaks: http://lab.llvm.org:8011/#/builders/5/builds/1262 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

lebedev.ri added a comment. `Libc` option name doesn't really make sense to me, maybe `FunctionSet` would fit better. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:32-33 + +// Initial list was extracted from gcc documentation +static const StringRef

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG54e655b3f8dc: Reland Move the test compiler setup in a common place. NFCI (authored by v.g.vassilev). Changed prior to commit: https://reviews.llvm.org/D91061?vs=305327=305483#toc Repository: rG

[clang] 54e655b - Reland "Move the test compiler setup in a common place. NFCI"

Author: Vassil Vassilev Date: 2020-11-16T13:22:10Z New Revision: 54e655b3f8dc1d005655d9138880f3823d58224f URL: https://github.com/llvm/llvm-project/commit/54e655b3f8dc1d005655d9138880f3823d58224f DIFF: https://github.com/llvm/llvm-project/commit/54e655b3f8dc1d005655d9138880f3823d58224f.diff

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman added a comment. In D91498#2397187 , @aaron.ballman wrote: > LGTM! I'll land on your behalf momentarily. I lied. The patch doesn't apply cleanly for me -- can you rebase and upload a new diff? Repository: rG LLVM Github Monorepo

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305488. pmatos added a comment. Ensure the program address spaces vector doesn't contain duplicates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files:

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2388622 , @bader wrote: > In D89909#2353931 , @Anastasia wrote: > >> In the RFC it has been discussed to either use target address spaces or >> perhaps to introduce a new

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

tschuett added a comment. I am happy, if you could commit this for me. I am still learning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 305460. segoon added a comment. - minor changes to docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman added a comment. In D91506#2397158 , @tschuett wrote: > I am happy, if you could commit this for me. I am still learning. I'm happy to do so -- how would you like me to attribute the patch? Is `Thorsten ` what you'd like me to use?

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman closed this revision. aaron.ballman added a comment. In D91506#2397181 , @tschuett wrote: > Yes. Thank you! You're welcome! I've commit on your behalf in a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added a comment. Just a general drive by point, is it wise to add a new tidy module to clang-tidy called `threads` (or similar). We have got a few other checks related to multi-threaded code in the pipeline (D77493 , D75229

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

tschuett added a comment. Yes. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

tschuett updated this revision to Diff 305490. tschuett added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91498/new/ https://reviews.llvm.org/D91498 Files: clang/include/clang/AST/TypeLoc.h clang/include/clang/Basic/Specifiers.h

[clang] f9e639e - Fix bots that are running with assertions enabled; NFC.

Author: Aaron Ballman Date: 2020-11-16T09:23:10-05:00 New Revision: f9e639efda4aa391a2f247abf69912ca2d29217f URL: https://github.com/llvm/llvm-project/commit/f9e639efda4aa391a2f247abf69912ca2d29217f DIFF: https://github.com/llvm/llvm-project/commit/f9e639efda4aa391a2f247abf69912ca2d29217f.diff

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

arsenm added inline comments. Comment at: lld/MachO/SymbolTable.cpp:137 // error message. -if (auto *defined = dyn_cast(s)) +if (dyn_cast(s)) error("found defined symbol with illegal name " + DSOHandle::name); Should use isa Repository:

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added inline comments. Comment at: llvm/include/llvm/CodeGen/LiveRegMatrix.h:44 VirtRegMap *VRM; + MachineRegisterInfo *MRI; what's the purpose of this member? Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:917 + } + for

[clang] 02bdbdc - [clang][SveEmitter] Fix enum declarations. [NFCI]

Author: Francesco Petrogalli Date: 2020-11-16T14:49:45Z New Revision: 02bdbdc76021fcfb8cae465363b362cb889406d2 URL: https://github.com/llvm/llvm-project/commit/02bdbdc76021fcfb8cae465363b362cb889406d2 DIFF:

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bdbdc76021: [clang][SveEmitter] Fix enum declarations. [NFCI] (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added a comment. Please add register allocation code owner: "qcolombet" to the reviewer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + psionic12 wrote: > aaron.ballman wrote: > > psionic12 wrote: > > > aaron.ballman wrote: > > > > aaron.ballman wrote: > > > > > The

[clang] 7c6412e - Convert TypeSpecifierSign from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T09:08:08-05:00 New Revision: 7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2 URL: https://github.com/llvm/llvm-project/commit/7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2 DIFF: https://github.com/llvm/llvm-project/commit/7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2.diff

[PATCH] D91540: [preprocessor] Assertions on the inferrable null pointers in Preprocessor befere dereference

OikawaKirie created this revision. OikawaKirie added reviewers: dnsampaio, rsmith, lattner, ilya-biryukov. OikawaKirie added a project: clang. Herald added a subscriber: cfe-commits. OikawaKirie requested review of this revision. This patch asserts on some smart pointers that can be statically

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { rsmith wrote: > Quuxplusone wrote: > > Why does this attribute go on the class template? Shouldn't it be an > > attribute on the

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbe44cb2936: Add pass to add !annotate metadata from @llvm.global.annotations. (authored by fhahn). Herald added a project: clang. Herald added a

[clang] 4369223 - BPF: make __builtin_btf_type_id() return 64bit int

Author: Yonghong Song Date: 2020-11-16T07:08:41-08:00 New Revision: 4369223ea73c4b8a3fa9a8a84533125c7d0eea98 URL: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98 DIFF: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98.diff

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4369223ea73c: BPF: make __builtin_btf_type_id() return 64bit int (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305521. pmatos added a comment. Fix type check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/CodeGen/CGException.cpp

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman closed this revision. aaron.ballman added a comment. In D91498#2397251 , @tschuett wrote: > rebased Thanks! I've commit on your behalf in 7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2

[PATCH] D91311: Add new 'preferred_name' attribute.

Quuxplusone added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { aaron.ballman wrote: > rsmith wrote: > > Quuxplusone wrote: > > > Why does this attribute go on the class template? Shouldn't it be

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira updated this revision to Diff 305504. avieira added a comment. Rebased on top of trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. Do not warn for "pointer to aggregate" in a `sizeof(A) / sizeof(A[0])` expression if `A`

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added a comment. In D90188#2394361 , @erik.pilkington wrote: > Add support for C++11-style attributes on using-declarations. FWIW, it'd be a bit easier if those changes were split off into their own patch, as they're orthogonal to

[PATCH] D90984: Update matchers to be traverse-aware

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; aaron.ballman wrote: > If the traversal is not `AsIs`, that doesn't mean it's >

[clang] f7c881b - Adding some explicit casts to appease build bots; NFC

Author: Aaron Ballman Date: 2020-11-16T09:13:24-05:00 New Revision: f7c881b89eabec1af65073ede344da818292d62b URL: https://github.com/llvm/llvm-project/commit/f7c881b89eabec1af65073ede344da818292d62b DIFF: https://github.com/llvm/llvm-project/commit/f7c881b89eabec1af65073ede344da818292d62b.diff

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2392032 , @Anastasia wrote: > In D89869#2388499 , @azabaznov wrote: > >> Addressed all concerns except replacing //__opencl_c_int64 //definition into >> header. The reason for

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 305494. joechrisellis added a comment. Remove failing test; it was checking that a conversion _failed_, although the conversion should now _pass_ given the changes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8dbe44c - Add pass to add !annotate metadata from @llvm.global.annotations.

Author: Florian Hahn Date: 2020-11-16T14:57:11Z New Revision: 8dbe44cb2936ecafea4b26ef16d1727371ad203f URL: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f DIFF: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f.diff LOG:

[clang] 9e407af - [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Author: Xiangling Liao Date: 2020-11-16T10:07:57-05:00 New Revision: 9e407afd9bd3b5181db24b08f78cb43344bd8292 URL: https://github.com/llvm/llvm-project/commit/9e407afd9bd3b5181db24b08f78cb43344bd8292 DIFF:

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link… (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D91361?vs=305160=305501#toc

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

fhahn marked an inline comment as done. fhahn added a comment. Thanks Jessica & Francis! I committed the initial version, with a small change to only run if the `!annotation` remarks are enabled. Comment at: llvm/include/llvm/Transforms/IPO/Annotation2Metadata.h:1 +//===-

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington updated this revision to Diff 305506. erik.pilkington added a comment. Use a bit on Declarator instead of an ad-hoc bool parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 Files: clang/include/clang/Sema/DeclSpec.h

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. ymandel requested review of this revision. Adds support for setting the `Rule` field. In the process, refactors the code that accesses that field and adds a

[PATCH] D91428: Add support for multiple program address spaces

jdoerfert added a subscriber: tianshilei1992. jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I'll be on the lookout for the RFC. There, and in an updated commit message, you have to provide more details.

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. Ping; I'd let to get this sorted out so I can continue to make progress towards serialization and deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; steveire wrote: > aaron.ballman wrote: > > If the traversal is not `AsIs`,

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. Sorry I was disrupted and not able to work on this last week! I've just got started trying to integrate this with my kernel patches. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} FYI - I just

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Patch description could use a pointer to more details about the unsafe atomics. Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} jackmanb wrote: > FYI - I just spotted some stray `\t` in here (is it helpful to point this > out? If not let me know, I will ignore in

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arsenm. Herald added subscribers: dang, kerbowa, jfb, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. Add an option -munsafe-fp-atomics for AMDGPU

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32,

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 305526. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Update testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

tra added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + Is there a suitable constant for `don't know` result? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added a comment. Some very minor nits - the 68060 omission is the biggest one (apple might not have used it but commodore did!) Comment at: clang/include/clang/Driver/Options.td:155 +def m_m68k_Features_Group: OptionGroup<"">, + Group,

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked 3 inline comments as done. hliao added a comment. Kindly ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91121/new/ https://reviews.llvm.org/D91121 ___ cfe-commits mailing

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > Sorry I'm a beginner with the LLVM code, could you explain

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > jackmanb wrote: > > Sorry I'm a beginner with the LLVM code,

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGace9653c11c6: [clang-tidy] performance-unnecessary-copy-initialization: Check for const… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ace9653 - [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

Author: Felix Berger Date: 2020-11-16T17:08:18-05:00 New Revision: ace9653c11c6308401dcda2e8b26bf97e6e66e30 URL: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30 DIFF: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30.diff

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + aeubanks wrote: > This test fails with the NPM, >

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, dang, arphaman. Herald added a project: clang. bnbarham requested review of this revision. As with precompiled headers, it's useful for indexers to be able to continue through compiler

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, Nov 16, 2020 at 7:24 PM Richard Smith wrote: > > On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: >> >> On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits >> wrote: >> > >> > >> > Author: Richard Smith >> > Date: 2020-11-11T15:05:51-08:00 >> > New Revision:

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. > Performing the mandatory inlinings first simplifies the problem the full > inliner needs to solve That confuses me a bit - is that suggesting that we don't run the AlwaysInliner when we are running the Inliner (ie: we only run the AlwaysInliner at -O0, and use the

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf375885ab86d: [InferAddrSpace] Teach to handle assumed address space. (authored by hliao). Changed prior to commit:

[clang] f375885 - [InferAddrSpace] Teach to handle assumed address space.

Author: Michael Liao Date: 2020-11-16T17:06:33-05:00 New Revision: f375885ab86d1b3e82269725c8e9aa49f347b4a7 URL: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7 DIFF: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7.diff

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

keith commandeered this revision. keith added a reviewer: ksuther. keith added a comment. Note the test case shown here passes on master, so we can drop this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17922/new/ https://reviews.llvm.org/D17922

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > URL: > https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > DIFF: >

[PATCH] D90507: Adding DWARF64 clang flag

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM with nits Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + hliao wrote: > tra wrote: > > Is there a

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. What the attribute achieves is great, however I must say I'm really with Arthur's original comment regarding the ergonomics of it. IMO, it makes a lot more sense to permit the typedef author to pick how their typedef is going to be "named" by the compiler. If they pick

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. Please note: the patch isn't 100% ready, there are those tests that check how the pipeline is composed, which are unpleasant to fix, so I want to defer them to after we get agreement over the larger points this patch brings (i.e. pre-performing always inlinings, value

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2394109 , @wenlei wrote: > This change covers non-LTO cases. For LTO, I think we would need to pass it > from driver to LTO. Something like this: tools::addLTOOptions -> lld -> > lto::Config

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2393434 , @jansvoboda11 wrote: > Hi @ayermolo, do you think this might be triggered by D82756 > ? (my only upstream patch ATM) Oh, no. Sorry I wasn't clear. I was just looking for

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. In D91567#2398461 , @mtrofin wrote: > In D91567#2398440 , @dblaikie wrote: > >>> Performing the mandatory inlinings first simplifies the problem the full >>> inliner needs to solve >> >>

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv64-toolchain.c:5 +// RUN: %clang %s -### -no-canonical-prefixes -target riscv64 \ +// RUN: --gcc-toolchain=%S/Inputs/basic_riscv64_tree 2>&1 | FileCheck -check-prefix=CC1 %s // CC1: clang{{.*}} "-cc1" "-triple"

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Please modify the commit subject and add a proper message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >