[PATCH] D83315: Turn arcmt-* options into a single option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] 05eeda9 - [clang][cli] Turn arcmt-* options into a single option

Author: Jan Svoboda Date: 2020-11-18T10:53:41+01:00 New Revision: 05eeda9752b393c074dd22716670bc3b9671270d URL: https://github.com/llvm/llvm-project/commit/05eeda9752b393c074dd22716670bc3b9671270d DIFF: https://github.com/llvm/llvm-project/commit/05eeda9752b393c074dd22716670bc3b9671270d.diff

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306026. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve some comments, simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

njames93 added a comment. If you are doing this may as well cover `DefineOutline` and `RemoveUsingNamespace` - that one can do away with formatv too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); + } jroelofs wrote: > Is the

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis updated this revision to Diff 306043. joechrisellis added a comment. Remove redundant tests from clang/test/Sema/attr-arm-sve-vector-bits.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/ https://reviews.llvm.org/D91696

[PATCH] D91626: [clangd] Implement textDocument/implementation.

hokein added a comment. thanks, just reviewed at the xrefs code. I think we can narrow the scope of the patch by splitting it into two patches - find-implementation in xrefs.cpp - LSP & clangd server layer (needs a smoke lit test) Comment at:

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

JonChesterfield added a comment. If data mappings can overlap, then it follows that copies to/from the target must be done sequentially by the runtime, unless additional information on their independence exists. Alias analysis style. I see the programmer convenience angle, but it is a shame to

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh updated this revision to Diff 306036. abidh added a comment. Handle review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91559/new/ https://reviews.llvm.org/D91559 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index:

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 updated this revision to Diff 306042. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 Files: clang/include/clang/Driver/Options.td

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 306046. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. - addressed comments in the diff - stop ignoring system macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein updated this revision to Diff 306045. hokein added a comment. Fix other code actions as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694 Files:

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein added a comment. In D91694#2402203 , @njames93 wrote: > If you are doing this may as well cover `DefineOutline` and > `RemoveUsingNamespace` - that one can do away with formatv too. good catch, thanks! Repository: rG LLVM Github Monorepo

[clang] bcaa198 - Remove unportable test

Author: Stephen Kelly Date: 2020-11-18T12:42:07Z New Revision: bcaa19894994f1363a10c082541efb67435399d1 URL: https://github.com/llvm/llvm-project/commit/bcaa19894994f1363a10c082541efb67435399d1 DIFF: https://github.com/llvm/llvm-project/commit/bcaa19894994f1363a10c082541efb67435399d1.diff

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

OikawaKirie added a comment. In D91410#2400018 , @tejohnson wrote: > > ... the new checking is a mix of assert and fatal errors. Is that intended? No. The added checks are based on the checks on other calls to the `Target::createXXX` functions in

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST , Position Pos, const SymbolIndex *Index, kadircet wrote: > nridge wrote: > > kadircet

[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

hokein added a comment. In D91162#2400723 , @hokein wrote: > oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should > have landed it, sorry), that patch should fix a general recovery-expr crash > inside constexpr function body. I

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. MarkMurrayARM requested review of this revision. Add support for the Neoverse N2 CPU to the ARM and AArch64 backends. Repository:

[PATCH] D83690: Port Migator option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83690/new/

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Can you remove the code related to adding the mt-unsafe-posix check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. @njames93 thank you for the feedback! Still waiting for more feedback and especially high level one about this feature in general. Does it look useful? Should it be behind a flag i.e. changing default behaviour is too dangerous? Comment at:

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. This LGTM. May I ask to extend the commit message to add a reference to the paragraph in section "3.7.3.3", item 2 on page 23 of the specs version 00bet6? Repository: rG LLVM

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over the revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Now that you have added the concurrency module as a new patch, all that code needs removing from this diff. If you generate the diff from that patch it should work. You should only be left with the code needed to add this check to that module. CHANGES SINCE LAST

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); rjmccall

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 updated this revision to Diff 306047. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 Files: clang/include/clang/Driver/Options.td

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

paulwalker-arm added a comment. As I see it there are a bunch of pragmas that all enable vectorisation, with each pragma providing a unit of information. One component of this information is the vectorisation factor hint provided by vectorize_width. With the introduction of scalable vectors

[clang] 955341a - test commit

Author: Thorsten Schütt Date: 2020-11-18T09:20:37+01:00 New Revision: 955341a722a0a204c79f6b948e4fe0f23bb56e30 URL: https://github.com/llvm/llvm-project/commit/955341a722a0a204c79f6b948e4fe0f23bb56e30 DIFF:

[clang-tools-extra] 9d77584 - [clangd] Call hierarchy (Protocol layer)

Author: Nathan Ridge Date: 2020-11-18T03:41:31-05:00 New Revision: 9d77584fe04010a2aa536308d4032bf5677d7000 URL: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000 DIFF: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000.diff

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d77584fe040: [clangd] Call hierarchy (Protocol layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83315: Turn arcmt-* options into a single option

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83315/new/

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein updated this revision to Diff 306015. hokein marked 9 inline comments as done. hokein added a comment. rebase and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 Files:

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306027. kbobyrev added a comment. Remove leftover test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Index:

[clang] 1e6fc2f - [clang][cli] Port Migrator option flags to new option parsing system

Author: Jan Svoboda Date: 2020-11-18T12:18:27+01:00 New Revision: 1e6fc2fa532c280abec04f83410dfdb3760dfc0f URL: https://github.com/llvm/llvm-project/commit/1e6fc2fa532c280abec04f83410dfdb3760dfc0f DIFF: https://github.com/llvm/llvm-project/commit/1e6fc2fa532c280abec04f83410dfdb3760dfc0f.diff

[PATCH] D83690: Port Migator option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e6fc2fa532c: [clang][cli] Port Migrator option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG680931af2757: [Matrix] Adjust matrix pointer type for inline asm arguments. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES

[clang] 680931a - [Matrix] Adjust matrix pointer type for inline asm arguments.

Author: Florian Hahn Date: 2020-11-18T11:44:11Z New Revision: 680931af2757fb495c5727d335ffa580fb3dbe98 URL: https://github.com/llvm/llvm-project/commit/680931af2757fb495c5727d335ffa580fb3dbe98 DIFF: https://github.com/llvm/llvm-project/commit/680931af2757fb495c5727d335ffa580fb3dbe98.diff LOG:

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

RKSimon added subscribers: stephenkelly, RKSimon. RKSimon added a comment. @stephenkelly This is breaking a large number of bots - please can you revert your patch series to get things green again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2402245 , @njames93 wrote: > Can you remove the code related to adding the mt-unsafe-posix check. Sorry, I've added unnecessary files. Removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Herald added a subscriber: steakhal. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

dmgreen added a comment. Can you add the cpuid to host.cpp too? Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:154 +AARCH64_CPU_NAME("neoverse-n2", ARMV8_5A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_BF16 | AArch64::AEK_DOTPROD |

[clang] 8cdc538 - Add sysroot/lib to library search path of baremetal toolchain.

Author: Hafiz Abid Qadeer Date: 2020-11-18T12:38:52Z New Revision: 8cdc538873879bd57c3ba71956d68b49a2973a45 URL: https://github.com/llvm/llvm-project/commit/8cdc538873879bd57c3ba71956d68b49a2973a45 DIFF: https://github.com/llvm/llvm-project/commit/8cdc538873879bd57c3ba71956d68b49a2973a45.diff

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

This revision was automatically updated to reflect the committed changes. abidh marked an inline comment as done. Closed by commit rG8cdc53887387: Add sysroot/lib to library search path of baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao added a comment. As mentioned earlier, that's very experimental support. Even though the SASS looks reasonable, it still needs verifying on real systems. For non-kernel functions, it seems we share the path. So that we should do a similar thing. The current approach fixes that in the

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

sylvestre.ledru added a comment. I am not 100% that it is thanks to this patch but reformatting Firefox code with clang-format 11 significantly improves the readability of the usage of ternary operators. See: https://phabricator.services.mozilla.com/D90795 Thanks for the change! Repository:

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. In D84637#2345353 , @rsmith wrote: > There are a couple of cases where you're returning `EvalStmtResult` from a > function with a `bool` return type, that I'd like to see fixed before this > lands. > > All the other comments are

[clang] 5e696d8 - [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead

Author: Jan Svoboda Date: 2020-11-18T11:31:13+01:00 New Revision: 5e696d895bde1eb584a9de5c9feba1a98c6bb487 URL: https://github.com/llvm/llvm-project/commit/5e696d895bde1eb584a9de5c9feba1a98c6bb487 DIFF: https://github.com/llvm/llvm-project/commit/5e696d895bde1eb584a9de5c9feba1a98c6bb487.diff

[PATCH] D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix, I've commit on your behalf in 871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 871fe71 - Fix typo for hasAnyOverloadedOperatorName; NFC

Author: Keishi Hattori Date: 2020-11-18T07:48:59-05:00 New Revision: 871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 URL: https://github.com/llvm/llvm-project/commit/871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 DIFF:

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use +// dlinfo(RTLD_DI_LINKMAP) instead which works on both Solaris 11.3 and

[clang] 2be5698 - [clang][cli] Add ability to make fixups to CompilerInvocation after option parsing

Author: Jan Svoboda Date: 2020-11-18T10:35:38+01:00 New Revision: 2be569870486a2068667f4625723c0a7409f4c97 URL: https://github.com/llvm/llvm-project/commit/2be569870486a2068667f4625723c0a7409f4c97 DIFF: https://github.com/llvm/llvm-project/commit/2be569870486a2068667f4625723c0a7409f4c97.diff

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2be569870486: [clang][cli] Add ability to make fixups to CompilerInvocation after option… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e696d895bde: [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83406/new/

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306022. segoon retitled this revision from "[clang-tidy] add concurrent module" to "[clang-tidy] add concurrency module". segoon added a comment. - concurrent -> concurrency CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 306035. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

willlovett added a comment. I found this one. The fix looks sensible, and I believe the test is correct and consistent with the spec. I'll leave it to someone else to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306044. segoon added a comment. - remove garbage files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske updated this revision to Diff 306134. balazske added a comment. Adding FIXME comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91543/new/ https://reviews.llvm.org/D91543 Files:

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. >> I'll run this through llvm-compile-time-tracker to see what the compile time >> implications are. > > You mean for the variant where we ran some of the function passes, or you'd > try running all of them? Probably the latter would be quite interesting as a > 'worst

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:116 +Defining CallSuperAttr +== psionic12 wrote: > After a whole day's research of `Sphinx`, I figured out that > `ClangPlugins.rst` is the "proto-type" of >

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/M68k.cpp:51 +} +return CPUName.str(); + } Can't we just use StringSwitch here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin updated this revision to Diff 306141. mtrofin added a comment. Running just the always inliner variant, without other passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91567/new/ https://reviews.llvm.org/D91567 Files:

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403216 , @aeubanks wrote: >>> I'll run this through llvm-compile-time-tracker to see what the compile >>> time implications are. >> >> You mean for the variant where we ran some of the function passes, or you'd >> try

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 306143. njames93 added a comment. Added test cases to ensure clang-tidy doesn't crash. Expanded auto out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91485/new/ https://reviews.llvm.org/D91485 Files:

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306162. zibi marked an inline comment as done. zibi added a comment. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. I moved the logic from `memory_resource.cpp` to `__config` as since I'm not

[PATCH] D83693: Port analyzer flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/include/clang/AST/StmtDataCollectors.td:67-75 +if (auto *ParamTypeDecl = dyn_cast(TemplParam)) { + const clang::Type *ParamType = ParamTypeDecl->getTypeForDecl(); + if (auto *autoT =

[PATCH] D83691: Port Comment option flags to new parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you fix a couple of nits. Comment at: clang/include/clang/Driver/Options.td:405 +// Comment Options + Nit: please end the comment with

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 306020. segoon retitled this revision from "[clang-tidy] implement concurrent-mt-unsafe" to "[clang-tidy] implement concurrency-mt-unsafe". segoon added a comment. - concurrent -> concurrency - split the patch apart CHANGES SINCE LAST ACTION

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein created this revision. hokein added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. to be consistent witih other code actions.

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:239 + if (const auto *Template = D->getPrimaryTemplate()) +return canonicalRenameDecl(Template); + return D; hokein wrote: > the `auto` + varies `canonicalRenameDecl`

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis created this revision. joechrisellis added reviewers: fpetrogalli, peterwaller-arm. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. Previously,

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire added a comment. I've removed the offending test (which in this case is the correct fix - it is not a temporary fix). @RKSimon Is there some way I can see what is causing the failures on the other platforms? Was it because of this test? How can I monitor this? I knew how to see it

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2402886 , @jhuber6 wrote: > Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash > using this patch, I haven't encountered any errors on my machine. Could you > verify that this doesn't

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM I've left one minor comment, if that suggestion works it should be fine to fix it before committing Comment at: clang/lib/Sema/SemaExpr.cpp:7210-7212 +const

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403173 , @aeubanks wrote: > In D91567#2400699 , @mtrofin wrote: > >> In D91567#2400207 , @aeubanks wrote: >> >>> What about removing the

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:278-283 -// Test implicit conversion between SVE and GNU vector is invalid when -// __ARM_FEATURE_SVE_BITS != N -#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512 -typedef

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306146. yonghong-song edited the summary of this revision. yonghong-song added a comment. add fetch_and_{and,or,xor} support force cmpxchg insn return results in r0 like r0 = cmpxchg(addr, r0, new) Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 068da2c - [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

Author: Yitzhak Mandelbaum Date: 2020-11-18T18:25:21Z New Revision: 068da2c749a58b46bd59381890a6a137d6e3128e URL: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e DIFF: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e.diff

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG068da2c749a5: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly. (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D91544?vs=305516=306151#toc

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91625/new/ https://reviews.llvm.org/D91625

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:317 + sum = sizeof(PtrArray) / sizeof(PtrArray1[0]); + // There is no warning for 'sizeof(T*)/sizeof(Q)' case. + sum += sizeof(PtrArray) / sizeof(A[0]);

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:317 + sum = sizeof(PtrArray) / sizeof(PtrArray1[0]); + // There is no warning for 'sizeof(T*)/sizeof(Q)' case. +

[clang] 0415cf4 - Fix unused variable warning. NFCI.

Author: Simon Pilgrim Date: 2020-11-18T16:50:51Z New Revision: 0415cf470bfbf16a06938424c3cad30c12cc2284 URL: https://github.com/llvm/llvm-project/commit/0415cf470bfbf16a06938424c3cad30c12cc2284 DIFF: https://github.com/llvm/llvm-project/commit/0415cf470bfbf16a06938424c3cad30c12cc2284.diff

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

sfertile accepted this revision. sfertile added a comment. Thanks for the updates. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 0016ab6 - Revert "[clangd] Implement textDocument/implementation (Xref layer)"

Author: Utkarsh Saxena Date: 2020-11-18T18:05:16+01:00 New Revision: 0016ab6f3632968e52eb83de021908f0c94bbb10 URL: https://github.com/llvm/llvm-project/commit/0016ab6f3632968e52eb83de021908f0c94bbb10 DIFF:

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. In D91567#2400699 , @mtrofin wrote: > In D91567#2400207 , @aeubanks wrote: > >> What about removing the existing AlwaysInlinerPass and replacing it with >> this one? Or is that something

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. One thing that would be nice would be to have both inliners in the same CGSCC pass manager to avoid doing SCC construction twice, but that would require some shuffling of module/cgscc passes in ModuleInlinerWrapperPass. Maybe as a future cleanup. Repository: rG

[clang-tools-extra] 130da80 - Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)""

Author: Utkarsh Saxena Date: 2020-11-18T19:09:16+01:00 New Revision: 130da802ff6e59d59ac5afce9e6a4235f3fe4959 URL: https://github.com/llvm/llvm-project/commit/130da802ff6e59d59ac5afce9e6a4235f3fe4959 DIFF:

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91721 Files:

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC] (authored by dreachem, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7046be1 - [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

Author: dreachem Date: 2020-11-18T10:46:42-06:00 New Revision: 7046be17307d7439053d6693bf81540e3dc479d2 URL: https://github.com/llvm/llvm-project/commit/7046be17307d7439053d6693bf81540e3dc479d2 DIFF: https://github.com/llvm/llvm-project/commit/7046be17307d7439053d6693bf81540e3dc479d2.diff

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403236 , @aeubanks wrote: > One thing that would be nice would be to have both inliners in the same CGSCC > pass manager to avoid doing SCC construction twice, but that would require > some shuffling of module/cgscc

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy added a comment. In D86502#2245734 , @wmi wrote: > In D86502#2245578 , @hoy wrote: > >> In D86502#2245460 , @wmi wrote: >> The early instrumentation also allows the

  1   2   3   >