[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. The exact call chain, if the added test is called without the fix: $ ./tools/clang/unittests/AST/ASTTests --gtest_filter='*HasNoDescribedTemplateSet*' Note: Google Test filter = *HasNoDescribedTem* [==] Running 4 tests from 1 test case. [--]

[clang] 6725860 - Sema::BuildCallExpr - use cast<> instead of dyn_cast<> for dereferenced pointer. NFCI.

Author: Simon Pilgrim Date: 2021-01-05T09:34:00Z New Revision: 6725860d21a03741d6c3331ab0560416bb19e068 URL: https://github.com/llvm/llvm-project/commit/6725860d21a03741d6c3331ab0560416bb19e068 DIFF: https://github.com/llvm/llvm-project/commit/6725860d21a03741d6c3331ab0560416bb19e068.diff

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

NoQ added a comment. This patch adds a new core checker. I wouldn't be comfortable enabling it by default without a much more careful evaluation (than a single lit test). In particular, i'm worried about false positives due to constraint solving issues and our incorrect cast representation -

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein updated this revision to Diff 314522. hokein marked 2 inline comments as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92749/new/ https://reviews.llvm.org/D92749 Files:

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein added a comment. In D92749#2436658 , @njames93 wrote: > How does this handle Dependent base classes (including CRTP). Can tests be > added to demonstrate that behaviour if its supported. Thanks, this is a good point. Repository: rG LLVM

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssignmentsStyle``) + Style of aligning

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1222-1223 +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1) + ++Newlines; +else if (!Style.EmptyLineBeforeAccessModifier

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. Order of previous declarations may get confusable: ClassTemplateDecl1 <-(Prev)- ClassTemplateDecl2 <-(Prev)- ClassTemplateDecl3 | | | | | CXXRecorddDecl1 <-- CXXRecordDecl2 -(Prev)-> CXXRecordDecl3 - |

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:219 + ProgramStateManager = State->getStateManager(); + SValBuilder = Mgr.getSValBuilder(); + SVal Eval = `Bldr` is always equal to `*this` here, there's no need to

[PATCH] D92248: Inform the consumer on invalid template instantiations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02eb8e20b51b: Inform the consumer on invalid template instantiations. (authored by v.g.vassilev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 02eb8e2 - Inform the consumer on invalid template instantiations.

Author: Vassil Vassilev Date: 2021-01-05T09:43:38Z New Revision: 02eb8e20b51b3ea263bbfe696241b8541c72ee7a URL: https://github.com/llvm/llvm-project/commit/02eb8e20b51b3ea263bbfe696241b8541c72ee7a DIFF: https://github.com/llvm/llvm-project/commit/02eb8e20b51b3ea263bbfe696241b8541c72ee7a.diff

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch updated this revision to Diff 314566. kiausch edited the summary of this revision. kiausch added a comment. implemented review suggestions: - updated clang/docs/ClangCommandLineReference.rst - removed unneccessary HasEFPU2() wrapper function - initialize HasEFPU member - merged tests

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG489000d8516d: [VE] Change clang to support SjLj Lowering (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/

[clang] 489000d - [VE] Change clang to support SjLj Lowering

Author: Kazushi (Jam) Marukawa Date: 2021-01-05T22:19:02+09:00 New Revision: 489000d8516da7eaf6aabaad11cce0ed7e67c61f URL: https://github.com/llvm/llvm-project/commit/489000d8516da7eaf6aabaad11cce0ed7e67c61f DIFF:

[clang] 6f77029 - [OpenCL] Restrict pointer to member functions.

Author: Anastasia Stulova Date: 2021-01-05T13:32:18Z New Revision: 6f770292a39f265c985623b1550aa50566b0 URL: https://github.com/llvm/llvm-project/commit/6f770292a39f265c985623b1550aa50566b0 DIFF: https://github.com/llvm/llvm-project/commit/6f770292a39f265c985623b1550aa50566b0.diff

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

MarkMurrayARM updated this revision to Diff 314579. MarkMurrayARM added a comment. Fixed the parent commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews.llvm.org/D94083 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > BTW, I cannot optimize function f to returning zero directly with GCC-10.2.1 > and Clang-10.0.1 under -O3. Should I add any other flags? Or it is version > specific? Yeah I can't reproduce that with latest gcc/clang neither. Try gcc 4.x and gcc 5.x. > But

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments** (``AlignConsecutiveAssignmentsStyle``) + Style of aligning

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

sammccall added a comment. Sorry for the delay getting this landed, and thanks for the patch! It'll be part of the clangd 12 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 314565. aguinet marked 4 inline comments as done. aguinet added a comment. Rebase on current master, and take into account @aaron.ballman 's fixes (thanks!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: clang/test/Sema/callingconv-darwin_abi.c:10 + +void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; // expected-warning{{incompatible function pointer types}} aaron.ballman wrote: > You should also add some tests

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f770292a000: [OpenCL] Restrict pointer to member functions. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:526 +TraverseStmt(LE->getTrailingRequiresClause()); + +TraverseStmt(LE->getBody());

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93483/new/ https://reviews.llvm.org/D93483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

aaron.ballman added a comment. In D93988#2477961 , @steveire wrote: > In D93988#2477602 , @aaron.ballman > wrote: > >> Could you give me a bit more background about why you want to make this >> change? > > This

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. I guess I want to clarify one point here, after this patch the parser **will not assume** that statement always follows statement attributes. We simply turn off the assumption that what follows is a declaration, parser will simply determine whether it is a

[clang] 0e4d236 - [OpenCL] Warn about side effects for unevaluated vec_step arg

Author: Sven van Haastregt Date: 2021-01-05T11:51:10Z New Revision: 0e4d2361b817bd16f97cd45d5792017edc3891ee URL: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee DIFF: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee.diff

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4d2361b817: [OpenCL] Warn about side effects for unevaluated vec_step arg (authored by svenvh). Changed prior to commit:

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

sammccall added a comment. Seems fair enough to do something about this, though it's a bit sad we're doing it just because VSCode has bad UI. A couple of open design questions: 1. In the future it may make sense to have other documentLinks too. (e.g. imagine a comment `Configures the

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 314568. simoll marked an inline comment as done. simoll added a comment. NFC - Use `bool4` in docs. - Rebased, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files:

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. In D93452#2460646 , @qchateau wrote: > It does indeed look like facing the problem from the wrong side (fight the > end result instead of finding the root cause) but at that point it does solve > an annoying problem. As I

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

kaz7 added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. I tried to sketch a couple of tetris-based mental models for why these hashtables might never fit inside an existing gap, leading us to stack our arena size (tetris field height) higher and higher. This is predicated on the assumption that the index hashtables are the

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2478977 , @vsavchenko wrote: > I guess I want to clarify one point here, after this patch the parser **will > not assume** that statement always follows statement attributes. We simply > turn off the assumption

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM. This is the same hook hip & opencl use to indicate that a function is a kernel entry point. We may need to create the metadata openmp nvptx uses as well, but that's

[PATCH] D93796: [clangd][fuzzyFind] Do not show stale symbols in the result.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yup, as mentioned on D93393 this seems like a reasonable tradeoff to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94029: [clang-tidy] Add extra tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94029/new/ https://reviews.llvm.org/D94029

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch marked 4 inline comments as done. kiausch added inline comments. Comment at: llvm/test/CodeGen/PowerPC/efpu2.ll:6 +; Single tests +; identical to tests in spe.ll + nemanjai wrote: > It might make sense to just add a RUN line in that test case rather

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

SjoerdMeijer accepted this revision. SjoerdMeijer added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/arm_neon.td:1911 +// vcmlaq{ROT}_lane +def : SOpInst<"vcmla" # ROT # "_lane", "...qI", "Q" # type, Op<(call

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:213 ParsedStmtContext()) && -(GNUAttributeLoc.isValid() || isDeclarationStatement())) { +((GNUAttributeLoc.isValid() && !Attrs.back().isStmtAttr()) || +

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added a comment. Thank you for submitting this patch? Comment at: clang/include/clang/Format/Format.h:117 +/// int b= 23; +/// +/// int ccc = 23; tinloaf wrote: > HazardyKnusperkeks wrote: > > You are adding a Tab here, or

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We supports SjLj exception handling in the backend, so changing clang to allow

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 2 inline comments as done. tinloaf added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:198 -**AlignConsecutiveAssignments** (``bool``) - If ``true``, aligns consecutive assignments. +**AlignConsecutiveAssignments**

[clang-tools-extra] 2f8d1e9 - [clangd] When querying drivers by binary, look in PATH too

Author: Giulio Girardi Date: 2021-01-05T12:54:07+01:00 New Revision: 2f8d1e9eb27e111eb6dfd242d88dd7c98005fb5c URL: https://github.com/llvm/llvm-project/commit/2f8d1e9eb27e111eb6dfd242d88dd7c98005fb5c DIFF:

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8d1e9eb27e: [clangd] When querying drivers by binary, look in PATH too (authored by rapgenic, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2477937 , @emaste wrote: >> For now, only Linux/ARM64 is supported/tested. > > Is there any reason this is Linux-specific (as far as support; I understand > if it's not easy for you to test on non-Linux arm64). It's

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

simoll added a comment. You might want to fix the typo in the title before committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

steakhal added a comment. In D92634#2478503 , @OikawaKirie wrote: > Besides, as far as I am thinking, the compiler optimizes the expression as it > is literally inferable, i.e. the result should be determinable literally > during compilation. Otherwise,

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. I guess I could add a test for the example I posted, but I'm not sure of how much value that is. Or do you mean a test case that -ansi and -std=c89 behave the same in every situation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2479303 , @tbaeder wrote: > I guess I could add a test for the example I posted, but I'm not sure of how > much value that is. Or do you mean a test case that -ansi and -std=c89 behave > the same in every

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:1756 + +class VectorTypeLoc : public ConcreteTypeLoc { fhahn wrote: > Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` > just deal with the row/column

[PATCH] D94032: [ASTMatchers] Omit methods from explicit template instantations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting nit. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2288-2289 // TODO: If we could match on explicit

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel added a comment. In D93637#2479576 , @tdl-g wrote: > Ah, if it's just an optimization that makes sense. I still think it's worth > having a test case to confirm that one of the specially-handled cases works. Sure. I added one for unique

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

tlively added a comment. In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior" Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

jansvoboda11 created this revision. jansvoboda11 added a reviewer: arphaman. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes an issue where large integer values were rejected as

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added a comment. Now that the test is fixed, this could be re-landed, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-commits mailing list

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93385/new/ https://reviews.llvm.org/D93385

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel updated this revision to Diff 314642. ymandel marked an inline comment as done. ymandel added a comment. Added test for unique_ptr specifically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/ https://reviews.llvm.org/D93637

[clang] 675a297 - [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

Author: Yitzhak Mandelbaum Date: 2021-01-05T17:57:41Z New Revision: 675a2973ee7745d1859e3b72be40a803dd349e55 URL: https://github.com/llvm/llvm-project/commit/675a2973ee7745d1859e3b72be40a803dd349e55 DIFF: https://github.com/llvm/llvm-project/commit/675a2973ee7745d1859e3b72be40a803dd349e55.diff

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG675a2973ee77: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s. (authored by ymandel). Repository: rG LLVM Github

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballman wrote: >

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire updated this revision to Diff 314654. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94031/new/ https://reviews.llvm.org/D94031 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG497026c90233: [WebAssembly] Prototype prefetch instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 497026c - [WebAssembly] Prototype prefetch instructions

Author: Thomas Lively Date: 2021-01-05T11:32:03-08:00 New Revision: 497026c90233e82ffd3ce2438c5f9567be6dabe7 URL: https://github.com/llvm/llvm-project/commit/497026c90233e82ffd3ce2438c5f9567be6dabe7 DIFF: https://github.com/llvm/llvm-project/commit/497026c90233e82ffd3ce2438c5f9567be6dabe7.diff

[PATCH] D93354: [clang-tidy] Make clang-format and include-order-check coherent again

kadircet added a comment. i thought clang-format was also putting angled includes and "OtherHeaders" into same category, by looking at: LLVMStyle.IncludeStyle.IncludeCategories = { {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false}, {"^(<|\"(gtest|gmock|isl|json)/)", 3, 0,

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) Should we be

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

tlively accepted this revision. tlively added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:53 // throw / rethrow +// The immediate argument is an index to for a tag, which is 0 for C++. def

[clang] f111cf9 - [clang][cli] Specify correct integer width for -fbuild-session-timestamp

Author: Jan Svoboda Date: 2021-01-05T20:10:07+01:00 New Revision: f111cf992df4ec00acfdd026eac12b36c3831999 URL: https://github.com/llvm/llvm-project/commit/f111cf992df4ec00acfdd026eac12b36c3831999 DIFF: https://github.com/llvm/llvm-project/commit/f111cf992df4ec00acfdd026eac12b36c3831999.diff

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf111cf992df4: [clang][cli] Specify correct integer width for -fbuild-session-timestamp (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 16f3401 - [Coverage] Fix test failures from commit rG9f2967bcfe2f

Author: Alan Phipps Date: 2021-01-05T13:35:52-06:00 New Revision: 16f3401eae4310c95163269c41d9b45261f0c7c3 URL: https://github.com/llvm/llvm-project/commit/16f3401eae4310c95163269c41d9b45261f0c7c3 DIFF: https://github.com/llvm/llvm-project/commit/16f3401eae4310c95163269c41d9b45261f0c7c3.diff

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93785/new/ https://reviews.llvm.org/D93785

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

dmajor added a comment. I tried the updated patch against our build and it was successful. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 ___

[PATCH] D94032: [ASTMatchers] Omit methods from explicit template instantations

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22c0f40b5d6: [ASTMatchers] Omit methods from explicit template instantations (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94032?vs=314451=314643#toc Repository: rG

[clang] f22c0f4 - [ASTMatchers] Omit methods from explicit template instantations

Author: Stephen Kelly Date: 2021-01-05T17:42:33Z New Revision: f22c0f40b5d657c0293fc9332274c18d3c4f836c URL: https://github.com/llvm/llvm-project/commit/f22c0f40b5d657c0293fc9332274c18d3c4f836c DIFF: https://github.com/llvm/llvm-project/commit/f22c0f40b5d657c0293fc9332274c18d3c4f836c.diff

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) steveire wrote: >

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

dexonsmith added a comment. In D93701#2479574 , @jansvoboda11 wrote: > In D93701#2477239 , @jansvoboda11 > wrote: > >> Another solution would be to create a "dummy" `DiagnosticsEngine` for the >>

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballman wrote: >

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

tlively updated this revision to Diff 314647. tlively marked 3 inline comments as done. tlively added a comment. - Fix section headers in test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93883/new/ https://reviews.llvm.org/D93883 Files:

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

tlively added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318 + Intrinsic<[], [llvm_ptr_ty], +[IntrInaccessibleMemOrArgMemOnly, IntrWillReturn, + ReadOnly>, NoCapture>], aheejin wrote: > It [[ >

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479757 , @aaron.ballman wrote: > In D93630#2479343 , @vsavchenko > wrote: > >> In D93630#2479260 , @aaron.ballman >> wrote: >> >>>

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

dexonsmith added a comment. In D93701#2477239 , @jansvoboda11 wrote: > This will make more sense after looking at D84673 > . In short: parsing of diagnostic options > can happen outside of

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479260 , @aaron.ballman wrote: > In D93630#2478977 , @vsavchenko > wrote: > >> I guess I want to clarify one point here, after this patch the parser **will >> not assume**

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:727 + virtual bool IsMatchingChildrenNotSpelledInSource() const =

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3a21e5de3dc: [ASTMatchers] Ensure that we can match inside lambdas (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/

[clang] c3a21e5 - [ASTMatchers] Ensure that we can match inside lambdas

Author: Stephen Kelly Date: 2021-01-05T14:39:46Z New Revision: c3a21e5de3dc3f55e4d219afd55dec518159d356 URL: https://github.com/llvm/llvm-project/commit/c3a21e5de3dc3f55e4d219afd55dec518159d356 DIFF: https://github.com/llvm/llvm-project/commit/c3a21e5de3dc3f55e4d219afd55dec518159d356.diff

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added a comment. > (I only discovered the "Suggest Edit" feature halfway through the review; I > didn't update the comments I already made as I'm not sure in which format you > prefer them?) I do like the feature but I wish it would be more useful like on github that you can

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn created this revision. fhahn added reviewers: aaron.ballman, rjmccall, Bigcheese, erichkeane. fhahn requested review of this revision. Herald added a project: clang. The MatrixType, ExtVectorType and VectorSize attributes have arguments defined as ExprArguments in Attr.td. So their

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 314633. saiislam added a comment. Modified to handle multiple targets/outputs in one run of the tool for archive unbundling. Other minor changes as requested in the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 314631. segoon edited the summary of this revision. segoon added a comment. Herald added a subscriber: lxfind. - review fixes - drop of atomic::is_always_lock_free check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn updated this revision to Diff 314635. fhahn added a comment. In D94092#2479684 , @erichkeane wrote: > I'm not sure how well Attr.td's constraints are enforced on type attributes, > as these often happen before parsing is completely done. I'd

[PATCH] D93695: [clang-tidy] Update uses of deprecated Transformer APIs in StringFindStrContainsCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb2284f6039: [clang-tidy] Update uses of deprecated Transformer APIs in… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93695/new/

[clang-tools-extra] 9eb2284 - [clang-tidy] Update uses of deprecated Transformer APIs in StringFindStrContainsCheck.

Author: Yitzhak Mandelbaum Date: 2021-01-05T16:49:29Z New Revision: 9eb2284f60391eca246f12398d247fc1555d6bf5 URL: https://github.com/llvm/llvm-project/commit/9eb2284f60391eca246f12398d247fc1555d6bf5 DIFF: https://github.com/llvm/llvm-project/commit/9eb2284f60391eca246f12398d247fc1555d6bf5.diff

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7662 - Expr *sizeExpr; - - // Special case where the argument is a template id. - if (Attr.isArgIdent(0)) { -CXXScopeSpec SS; -SourceLocation TemplateKWLoc; -UnqualifiedId id; -

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn added a comment. In D94092#2479753 , @erichkeane wrote: >> I tried a few different things to construct matrix_type attributes with >> ArgIdents, but failed. The patch also adjusts the code for a bunch of >> attributes. So if there are indeed cases

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450897 , @thopre wrote: > In D92409#2450690 , @rsmith wrote: > >> In D92409#2450550 , @thopre wrote: >> >>> In D92409#2426196

  1   2   3   >