[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ChuanqiXu added a comment. In D100739#2700324 , @ychen wrote: > In D100739#2700273 , @ChuanqiXu > wrote: > >> I hadn't looked into the details. I would try to make it. >> But from my understanding to this

[PATCH] D68321: Fix clang Visual Studio build instructions

Loghorn added a comment. Is there a chance this will ever be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Is it okay to you? @kito-cheng @frasercrmck This patch could fix https://bugs.llvm.org/show_bug.cgi?id=49962, I hope this could be merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, kito-cheng, asb, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 338810. pdhaliwal added a comment. Reopening this. This version is supposed to fix the buildbot failures on PPC machines. Since I don't have PPC machine I am not sure if this will work. But the logic followed here is motivated from Clang ::

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre updated this revision to Diff 338811. thopre marked an inline comment as done. thopre added a comment. Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. Couple of minor points above. I think the increase in error reporting granularity will be helpful if this falls over in the field, as well as helping if we need a third try to get through PPC CI Comment at:

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2141 +in RVV builtins, and still be recognized as clang builtins equivalent to the +underlying name. For example, ``riscv_vector.h`` declares the

[clang] 8cee150 - [C++, test] Fix typo in NSS* vars

Author: Thomas Preud'homme Date: 2021-04-20T12:07:41+01:00 New Revision: 8cee150e9ac467dd93199722b8bd8af3024df697 URL: https://github.com/llvm/llvm-project/commit/8cee150e9ac467dd93199722b8bd8af3024df697 DIFF:

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 70193bd - Re-land [GreedyRA ORE] Add Cost of spill locations into remark

Author: Serguei Katkov Date: 2021-04-20T16:21:07+07:00 New Revision: 70193bdfc06fe85114f1dcea463991dbd0c7b630 URL: https://github.com/llvm/llvm-project/commit/70193bdfc06fe85114f1dcea463991dbd0c7b630 DIFF:

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a reviewer: mibintc. fhahn added a subscriber: mibintc. fhahn added a comment. Awesome, thanks for the patch! I'm also adding @mibintc who I think was working on adding support for the pragma & co. Could you add a brief description to the patch and also reference the bug report on

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv()

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light created this revision. Herald added a subscriber: tschuett. effective-light requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100834 Files:

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 338812. effective-light added a comment. Remove the unnecessary flags and add another test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files:

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. LGTM. Anything else would be wondering if it can be merged/genericised with Arm somehow but that's not a blocker. Comment at:

[PATCH] D100829: [analyzer][docs] Highlight some differences between ArrayBound and V2

steakhal updated this revision to Diff 338786. steakhal added a comment. Add 'Limitations and bugs' section with a false-positive example. It would also help users classifying certain types of false-positive reports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[clang] 3d4a603 - clang-format: [JS] do not merge imports and exports.

Author: Martin Probst Date: 2021-04-20T13:08:18+02:00 New Revision: 3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a URL: https://github.com/llvm/llvm-project/commit/3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a DIFF: https://github.com/llvm/llvm-project/commit/3d4a6037ff462bc3e41e4924c603f0e3dfc2c06a.diff

[PATCH] D100752: clang-format: [JS] do not merge imports and exports.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d4a6037ff46: clang-format: [JS] do not merge imports and exports. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100752/new/

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1771 +def RISCVBuiltinAlias : InheritableAttr, TargetSpecificAttr { + let Spellings = [Clang<"__clang_riscv_builtin_alias">]; + let Subjects = SubjectList<[Function], ErrorDiag>;

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

Leporacanthicus accepted this revision. Leporacanthicus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100558/new/ https://reviews.llvm.org/D100558

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

vsavchenko added a comment. In D97183#2699336 , @steakhal wrote: > In D97183#2699080 , @RedDocMD wrote: > >> For the following function: >> >> void foo(std::unique_ptr P) { >> A* praw = P.get(); >> A*

[PATCH] D100829: [analyzer][docs] Highlight some differences between ArrayBound and V2

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, Szelethus, martong. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this

[PATCH] D100829: [analyzer][docs] Highlight some differences between ArrayBound and V2

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2107 - // note: requires unix.Malloc or - // alpha.unix.MallocWithAnnotations checks enabled. void test() { There is no such checker, thus I removed this comment. Also, `unix.Malloc`

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

frasercrmck added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2141 +in RVV builtins, and still be recognized as clang builtins equivalent to the +underlying name. For example, ``riscv_vector.h`` declares the function ``vget`` with

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839

[PATCH] D100831: [RISCV] [2/2] Add intrinsic for Zbp extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, jrtc27, kito-cheng, asb, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, benna, psnobl, kadircet, jocewei, PkmX,

[clang] fce8c10 - Fix Wdocumentation warning by consistently using '///' comment blocks. NFCI.

Author: Simon Pilgrim Date: 2021-04-20T12:37:00+01:00 New Revision: fce8c10b6813ef283b68275b0dabc813f0310958 URL: https://github.com/llvm/llvm-project/commit/fce8c10b6813ef283b68275b0dabc813f0310958 DIFF: https://github.com/llvm/llvm-project/commit/fce8c10b6813ef283b68275b0dabc813f0310958.diff

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai updated this revision to Diff 338824. HsiangKai added a comment. Refine the document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

vsavchenko updated this revision to Diff 338835. vsavchenko added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100839/new/ https://reviews.llvm.org/D100839 Files:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

JonChesterfield added a comment. That is a great feature, thank you. Compiling state machines and scheme programs to C is now much prettier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl updated this revision to Diff 338864. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100794/new/ https://reviews.llvm.org/D100794 Files: clang/lib/Headers/__clang_hip_cmath.h

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:76-86 +#if !defined(__HIPCC_RTC__) #include <__clang_cuda_math_forward_declares.h> +#endif // __HIPCC_RTC__ #include <__clang_hip_cmath.h> +#if

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

mibintc added a comment. The diff appears to be 2 separate commits, so on first glance this is only patching the test files. Usually if I am working on a patch and have responded to comments, I compress the patch+updates into a single commit (git rebase -i) before creating a diff to upload to

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[clang] a8a3a43 - [AArch64] Add apple-m1 CPU, and default to it for macOS.

Author: Ahmed Bougacha Date: 2021-04-20T08:41:04-07:00 New Revision: a8a3a43792472c9775c60fa79b9357033d47ce40 URL: https://github.com/llvm/llvm-project/commit/a8a3a43792472c9775c60fa79b9357033d47ce40 DIFF:

[clang] cedb5b0 - [AArch64] Don't always override CPU for arm64e.

Author: Ahmed Bougacha Date: 2021-04-20T08:41:04-07:00 New Revision: cedb5b06df1bab31e0484df31a40585ac7e7af19 URL: https://github.com/llvm/llvm-project/commit/cedb5b06df1bab31e0484df31a40585ac7e7af19 DIFF:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 338843. pdhaliwal marked 2 inline comments as done. pdhaliwal added a comment. Review comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files:

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thank you for the debugging, and for the more descriptive failure reporting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); bader

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2147-2150 +This attribute can only be used to set up the aliases for certain RISC-V +C intrinsic functions; it is intended for use only inside

[PATCH] D98657: [flang][driver] Add options for -Werror

crownyanguan added a comment. How about -Wl option, it will cause link error like " Only `-Werror` is supported currently" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added a comment. Does anyone have any remaining concerns or a desire to take another pass through this patch? If not, then I'll commit this later this week on Aaron's LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. >> I think maybe reverting is not a good idea if we have a good progress on >> this slow down issue. > > Yes, if we can fix the regression in a few days, then all is good. Another ping here. check-clang is down to 5 min now, but it's still a 11% regression (used to be

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, wenlei, yaxunl. olestrohm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For templates diagnosis must be done after

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia

[PATCH] D98774: [AST] De-duplicate empty node introspection

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Definitely a step forward, so lg :) > AFAIK python is not a hard-requirement of the llvm/clang build. I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at least.

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper added a comment. In D99741#2701398 , @thakis wrote: >>> I think maybe reverting is not a good idea if we have a good progress on >>> this slow down issue. >> >> Yes, if we can fix the regression in a few days, then all is good. > > Another

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b4e8f82a3f8: [clangd] Use dirty filesystem when performing cross file tweaks (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 6b4e8f8 - [clangd] Use dirty filesystem when performing cross file tweaks

Author: Nathan James Date: 2021-04-20T17:13:44+01:00 New Revision: 6b4e8f82a3f85c6612997e5f9fce8da6f8cb4526 URL: https://github.com/llvm/llvm-project/commit/6b4e8f82a3f85c6612997e5f9fce8da6f8cb4526 DIFF: https://github.com/llvm/llvm-project/commit/6b4e8f82a3f85c6612997e5f9fce8da6f8cb4526.diff

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a comment. In D97183#2700810 , @vsavchenko wrote: > In D97183#2699336 , @steakhal wrote: > >> In D97183#2699080 , @RedDocMD wrote: >> >>> For the following

[clang] 0ed6136 - Ensure target-multiversioning emits deferred declarations

Author: Erich Keane Date: 2021-04-20T08:10:26-07:00 New Revision: 0ed613612c5daa047e639877b1c24b36f6069384 URL: https://github.com/llvm/llvm-project/commit/0ed613612c5daa047e639877b1c24b36f6069384 DIFF: https://github.com/llvm/llvm-project/commit/0ed613612c5daa047e639877b1c24b36f6069384.diff

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1951 + Args.hasFlag(options::OPT_mamdgpu_ieee, options::OPT_mno_amdgpu_ieee, + !LangOptsRef.NoHonorNaNs); + arsenm

[PATCH] D96738: [docs] Fix doxygen comments wrongly attached to the clang namespace

thakis added a comment. lgtm, landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96738/new/ https://reviews.llvm.org/D96738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 338933. RedDocMD added a comment. Changed to a different visitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, I have changed to the visitor that you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits mailing list

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 ___

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); Does this say that the fence will be silently

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

lebedev.ri added a comment. Patch description is empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100874/new/ https://reviews.llvm.org/D100874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:341 - typedef decltype(__test(std::declval<_Tp>())) type; - static const bool value = !std::is_same::value; + typedef decltype(__test(_Tp{})) type; + static const bool value = !is_same::value;

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1951 + Args.hasFlag(options::OPT_mamdgpu_ieee, options::OPT_mno_amdgpu_ieee, + !LangOptsRef.NoHonorNaNs); + arsenm

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

ab added a comment. This sounds nice! One idea, maybe more dangerous, not sure which is better: in `setTripleTypeForMachOArchName`, we already have a couple `setArchName` calls, I think that's why `arm64e` is left alone in the `aarch64-cpus.c` test. Maybe we can do the `setArchName` call

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm added a comment. In D77013#2702129 , @yaxunl wrote: > The recent change https://reviews.llvm.org/D96280 caused some difficulty for > this patch. I would like to have some suggestions. > > Basically current FE requires any codegen or target option

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1951 + Args.hasFlag(options::OPT_mamdgpu_ieee, options::OPT_mno_amdgpu_ieee, + !LangOptsRef.NoHonorNaNs); + yaxunl wrote: > arsenm wrote: > > This should

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added a comment. In D100567#2702394 , @yonghong-song wrote: > ping @dblaikie could you take a look of my new investigation? Yep, it's on my list to look at. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100874/new/ https://reviews.llvm.org/D100874

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

kpn added a comment. I don't know the matrix implementation so I can't swear this hits every place needed, but the uses of CGFPOptionsRAII in this patch look correct at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/

[PATCH] D100830: [RISCV] [1/2] Add IR intrinsic for Zbp extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:33 def riscv_shfl : SDNode<"RISCVISD::SHFL", SDTIntBinOp>; +def riscv_shflw : SDNode<"RISCVISD::SHFLW", SDT_RISCVIntBinOpW>; +def riscv_unshfl : SDNode<"RISCVISD::UNSHFL",

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 338958. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGae8b2cab6740: [Driver] Support default libc++ library location on Darwin (authored by phosek). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/37191/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ https://reviews.llvm.org/D45639 ___

[PATCH] D100820: [RISCV] Implement the vnot.v builtin.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100820/new/ https://reviews.llvm.org/D100820

[PATCH] D93185: [docs] Use make_unique in FrontendAction example

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2da4ceec936e: [docs] Use make_unique in FrontendAction example (authored by nicolas17, committed by thakis). Repository: rG LLVM Github Monorepo

[clang] 2da4cee - [docs] Use make_unique in FrontendAction example

Author: Nicolás Alvarez Date: 2021-04-20T13:47:16-04:00 New Revision: 2da4ceec936e0e3ddb3028c35e97e99ab1de7484 URL: https://github.com/llvm/llvm-project/commit/2da4ceec936e0e3ddb3028c35e97e99ab1de7484 DIFF:

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. ping @dblaikie could you take a look of my new investigation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100567/new/ https://reviews.llvm.org/D100567 ___ cfe-commits

[PATCH] D68321: Fix clang Visual Studio build instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e77a67171e6: Fix clang Visual Studio build instructions (authored by Loghorn, committed by amccarth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6e77a67 - Fix clang Visual Studio build instructions

Author: Alessandro Vergani Date: 2021-04-20T11:17:29-07:00 New Revision: 6e77a67171e68d9eda811799d5b1c2530282478e URL: https://github.com/llvm/llvm-project/commit/6e77a67171e68d9eda811799d5b1c2530282478e DIFF:

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); kpn wrote: > Does this say that the fence

[clang] 057b6f5 - clang: Update libstdc++ issue workaround

Author: Nathan Sidwell Date: 2021-04-20T11:34:12-07:00 New Revision: 057b6f5d0b3ec1c1d0a87eb3d99ac4a46ca68cb4 URL: https://github.com/llvm/llvm-project/commit/057b6f5d0b3ec1c1d0a87eb3d99ac4a46ca68cb4 DIFF:

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rjmccall. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM should be smarter about *known* malloc's alignment and this knowledge may enable other

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added a comment. GCC already knows about this guaranteed alignment, check: https://godbolt.org/z/sxn6K7Yq7 Alignment checks were optimized out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

jlebar added a comment. Other than the declval issue discussed above, this looks reasonable to me. I don't notice anything wrong with the standard library reimplementations here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100794/new/ https://reviews.llvm.org/D100794

[clang] f5efe0a - [Driver] Support both slashes

Author: Petr Hosek Date: 2021-04-20T13:25:38-07:00 New Revision: f5efe0aa048b2bd3363b3a53efe9ae7367244801 URL: https://github.com/llvm/llvm-project/commit/f5efe0aa048b2bd3363b3a53efe9ae7367244801 DIFF: https://github.com/llvm/llvm-project/commit/f5efe0aa048b2bd3363b3a53efe9ae7367244801.diff

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm requested changes to this revision. arsenm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1951 + Args.hasFlag(options::OPT_mamdgpu_ieee, options::OPT_mno_amdgpu_ieee, +

[PATCH] D100869: [libcxx] Stop using use c++ subdirectory for libc++ library

phosek created this revision. phosek added a reviewer: ldionne. Herald added subscribers: libcxx-commits, mgorny. Herald added a project: libunwind. Herald added a reviewer: libunwind. phosek requested review of this revision. Herald added projects: clang, libc++, libc++abi. Herald added a

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. In D97183#2701441 , @steakhal wrote: > I think we can conclude that `P` must be non-null (since it was > unconditionally dereferenced), thus the previous check on the inner pointer > and the branch it guards must be dead! Under the

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. > It's important to realize that with pure static analysis it is absolutely > impossible to reliably report a bug more severe than dead code. Any form of > static analysis only ever finds code that doesn't make sense. It cannot make > assumptions about how often the

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > kpn wrote: > > Does this say

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 338941. effective-light added a comment. Whoops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates the functions createDefaultOutputFile, createOutputFile, createOutputFileImpl to use OpenFlags

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2059 +case Builtin::BIstrdup: +case Builtin::BIstrndup: + RetAttrs.addAlignmentAttr(Context.getTargetInfo().getNewAlign() / As a followup, I need to teach Clang

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2060 +case Builtin::BIstrndup: + RetAttrs.addAlignmentAttr(Context.getTargetInfo().getNewAlign() / +Context.getTargetInfo().getCharWidth());

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2060 +case Builtin::BIstrndup: + RetAttrs.addAlignmentAttr(Context.getTargetInfo().getNewAlign() / +Context.getTargetInfo().getCharWidth());

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:341 - typedef decltype(__test(std::declval<_Tp>())) type; - static const bool value = !std::is_same::value; + typedef decltype(__test(_Tp{})) type; +

[clang] ae8b2ca - [Driver] Support default libc++ library location on Darwin

Author: Petr Hosek Date: 2021-04-20T12:30:35-07:00 New Revision: ae8b2cab67408a043a4fe964d16e4803553c4ee0 URL: https://github.com/llvm/llvm-project/commit/ae8b2cab67408a043a4fe964d16e4803553c4ee0 DIFF: https://github.com/llvm/llvm-project/commit/ae8b2cab67408a043a4fe964d16e4803553c4ee0.diff

  1   2   >