[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c2e7c9ca043: [clang-format] Ensure we can correctly parse lambda in the template argument… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D116806?vs=398124=398521#toc

[clang] 5c2e7c9 - [clang-format] Ensure we can correctly parse lambda in the template argument list

Author: mydeveloperday Date: 2022-01-10T08:29:35Z New Revision: 5c2e7c9ca043d92bed75b08e653fb47c384edd13 URL: https://github.com/llvm/llvm-project/commit/5c2e7c9ca043d92bed75b08e653fb47c384edd13 DIFF: https://github.com/llvm/llvm-project/commit/5c2e7c9ca043d92bed75b08e653fb47c384edd13.diff

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG4a4b8e4f99e2: [AST] Add more source information for DecltypeTypeLoc. (authored by hokein). Changed prior

[PATCH] D116713: [clangd] Support configuration of inlay hints.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:51 bool VisitCXXConstructExpr(CXXConstructExpr *E) { +if (!Cfg.InlayHints.DeducedTypes) + return true;

[PATCH] D115490: [clangd] Include fixer for missing functions in C

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:14995 +DeclFilterCCC CCC{}; +Corrected = CorrectTypo(DeclarationNameInfo(, Loc), LookupOrdinaryName, +

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1729 } else if (Current.is(tok::r_paren)) { if (rParenEndsCast(Current)) Current.setType(TT_CastRParen); The current solution looks a bit like a hack to me.

[PATCH] D116924: [clang-extdef-mapping] Allow clang-extdef-mapping tool to output customized filename for each index entry

OikawaKirie created this revision. OikawaKirie added reviewers: martong, NoQ, steakhal. OikawaKirie added a project: clang. Herald added subscribers: arphaman, rnkovacs. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. The clang-extdef-mapping tool can only

[PATCH] D116921: [clangd] Enable expand-auto for decltype(auto).

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Based on

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall added a comment. In D116387#3230893 , @hokein wrote: > Agree that __ reserved names are ugly, but I'm not sure this is a great > improvement. > > I played around the patch locally, and found the new behavior being confused > in some cases

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius added a comment. @aybassiouny, still interested in working on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius added a comment. @GoBigorGoHome, are you still interested in this review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 ___ cfe-commits mailing list

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, thakis. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/27037 Sorry its taken so long to

[PATCH] D116922: [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116922 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp

[clang] 27ea0c4 - [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

Author: Sam McCall Date: 2022-01-10T10:38:27+01:00 New Revision: 27ea0c4e7234f3b15cbbb696e6c408af7141f342 URL: https://github.com/llvm/llvm-project/commit/27ea0c4e7234f3b15cbbb696e6c408af7141f342 DIFF: https://github.com/llvm/llvm-project/commit/27ea0c4e7234f3b15cbbb696e6c408af7141f342.diff

[clang-tools-extra] 16fd5c2 - [clangd] Support configuration of inlay hints.

Author: Sam McCall Date: 2022-01-10T10:49:35+01:00 New Revision: 16fd5c278488b3d3275afc381a00ba0b51b070ee URL: https://github.com/llvm/llvm-project/commit/16fd5c278488b3d3275afc381a00ba0b51b070ee DIFF: https://github.com/llvm/llvm-project/commit/16fd5c278488b3d3275afc381a00ba0b51b070ee.diff

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ea0c4e7234: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse (authored by sammccall). Changed prior to commit:

[PATCH] D116713: [clangd] Support configuration of inlay hints.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16fd5c278488: [clangd] Support configuration of inlay hints. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116713/new/

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1729 } else if (Current.is(tok::r_paren)) { if (rParenEndsCast(Current)) Current.setType(TT_CastRParen); curdeius wrote: > The current solution looks a bit

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, this looks good (sorry, I missed this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4811 + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[clang] 4a4b8e4 - [AST] Add more source information for DecltypeTypeLoc.

Author: Haojian Wu Date: 2022-01-10T09:34:18+01:00 New Revision: 4a4b8e4f99e2a82286b0595d561a51e7ad1945d2 URL: https://github.com/llvm/llvm-project/commit/4a4b8e4f99e2a82286b0595d561a51e7ad1945d2 DIFF: https://github.com/llvm/llvm-project/commit/4a4b8e4f99e2a82286b0595d561a51e7ad1945d2.diff

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116919 Files:

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

kadircet added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:153 + // probably truncated, so don't eat more tokens. + if (!Toks.back().is(tok::code_completion)) +SkipMalformedDecl(); i don't follow the logic here. maybe

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

hokein added a comment. Agree that __ reserved names are ugly, but I'm not sure this is a great improvement. I played around the patch locally, and found the new behavior being confused in some cases (mostly inconsistencies between deuglified places vs uglified places), and seems hard for

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/SpecialMembers.cpp:72 +// +// e.g. given `struct S{};`, produces: +// struct S { nit: add trigger points. Comment at:

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch! I've landed on your behalf in f282b6809105075b65974989459ee420ecd406e9 . CHANGES SINCE LAST ACTION

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2cc6c2d0c2f: Use a sorted array instead of a map to store AttrBuilder string attributes (authored by serge-sans-paille). Herald added a subscriber:

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/64726/step_8.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116919/new/ https://reviews.llvm.org/D116919 ___ cfe-commits

Re: [clang] 80e2c58 - [clang] Remove redundant member initialization (NFC)

On Sun, 9 Jan 2022, Kazu Hirata via cfe-commits wrote: Author: Kazu Hirata Date: 2022-01-09T00:19:51-08:00 New Revision: 80e2c587498a7b2bf14dde47a33a058da6e88a9a URL: https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a DIFF:

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall added a comment. I wasn't sure whether to suppress this in clang or clangd, wonder what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116925/new/ https://reviews.llvm.org/D116925

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Not sure it's OK to

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:415-423 + // FIXME This should be done in getAsSymbol. But then getAsSymbol should be + // the member function of SValBuilder (?) + if (symRHS) +if (auto RLocAsInt =

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. I made some minor comments, that can be fixed before committing. Comment at: clang/docs/UsersManual.rst:3567 +Linking is done using `spirv-link` linker from `the

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein updated this revision to Diff 398588. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116643/new/ https://reviews.llvm.org/D116643 Files:

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein updated this revision to Diff 398589. hokein added a comment. remove accident changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116643/new/ https://reviews.llvm.org/D116643 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:171 +return true; + // FIXME: Remove this std symbol list, as they should be covered by the + // above isInSystemHeader check. kbobyrev wrote: > Any reason not to do

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

mstorsjo added a comment. In D116503#3223094 , @MaskRay wrote: > But make sure to wait a bit to see what others think. Do you think it's ok to go ahead and land this change now, or should I wait a bit more? (I'd like to have it landed with enough

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:420 + auto FromTy = symRHS->getType(); + auto ToTy = RLocAsInt->getType(this->Context); + symRHS = this->getSymbolManager().getCastSymbol(symRHS, FromTy, ToTy);

[PATCH] D115490: [clangd] Include fixer for missing functions in C

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG1ab13793beaf: [clangd] Include fixer for missing functions in C (authored by sammccall). Changed prior

[clang-tools-extra] 1ab1379 - [clangd] Include fixer for missing functions in C

Author: Sam McCall Date: 2022-01-10T12:17:19+01:00 New Revision: 1ab13793beafd1db0159a410560b3ce998b15f5e URL: https://github.com/llvm/llvm-project/commit/1ab13793beafd1db0159a410560b3ce998b15f5e DIFF: https://github.com/llvm/llvm-project/commit/1ab13793beafd1db0159a410560b3ce998b15f5e.diff

[PATCH] D116906: [OpenMP][AMDGPU] Optimize the linked in math libraries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Using the optimiser to hide errors in how we're pulling in libm is clearly not right, but it leaves us less obviously broken than we are at present. Repository: rG LLVM

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added a comment. Starting producing `SymbolCast` you should be careful. Please pay attention on my revision D105340 before doing this. I don't want you walk through the thing I fought. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

hokein added a comment. In D116925#3230991 , @sammccall wrote: > I wasn't sure whether to suppress this in clang or clangd, wonder what you > think. I think it is fine to do it in clang. `pp_pragma_once_in_main_file` is a similar diag, and clang has

[clang] d2cc6c2 - Use a sorted array instead of a map to store AttrBuilder string attributes

Author: Serge Guelton Date: 2022-01-10T14:49:53+01:00 New Revision: d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1 URL: https://github.com/llvm/llvm-project/commit/d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1 DIFF: https://github.com/llvm/llvm-project/commit/d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1.diff

[PATCH] D115490: [clangd] Include fixer for missing functions in C

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14995 +DeclFilterCCC CCC{}; +Corrected = CorrectTypo(DeclarationNameInfo(, Loc), LookupOrdinaryName, +S, nullptr, CCC,

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. Happy new year! - and a gentle ping ;) Afaict, there are only two smaller issues remaining (see non-closed inline comments): - do we want a test expectation to check for unmodified code - should we remove a couple of comments from the code Personally, I have no

[clang] d17fb46 - [Clang][AArch64][ARM] PMUv3.4 Option Added

Author: Mubashar Ahmad Date: 2022-01-10T11:28:19Z New Revision: d17fb46e894501568a1bf3b11a5d920817444630 URL: https://github.com/llvm/llvm-project/commit/d17fb46e894501568a1bf3b11a5d920817444630 DIFF: https://github.com/llvm/llvm-project/commit/d17fb46e894501568a1bf3b11a5d920817444630.diff

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd17fb46e8945: [Clang][AArch64][ARM] PMUv3.4 Option Added (authored by mubashar_). Changed prior to commit:

[clang] abe3003 - [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

Author: Haojian Wu Date: 2022-01-10T12:45:20+01:00 New Revision: abe3003ead808518190d1e9717495735786938d3 URL: https://github.com/llvm/llvm-project/commit/abe3003ead808518190d1e9717495735786938d3 DIFF: https://github.com/llvm/llvm-project/commit/abe3003ead808518190d1e9717495735786938d3.diff

[PATCH] D116922: [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe3003ead80: [AST] Use recovery-expr to preserve incomplete-type-member-access expression. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 55d96ac - [AST] Add RParen loc for decltype AutoTypeloc.

Author: Haojian Wu Date: 2022-01-10T12:46:27+01:00 New Revision: 55d96ac3dc56bdebea854952a724c2a50d96ce19 URL: https://github.com/llvm/llvm-project/commit/55d96ac3dc56bdebea854952a724c2a50d96ce19 DIFF: https://github.com/llvm/llvm-project/commit/55d96ac3dc56bdebea854952a724c2a50d96ce19.diff

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55d96ac3dc56: [AST] Add RParen loc for decltype AutoTypeloc. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added a comment. RFC to clang dev list: https://lists.llvm.org/pipermail/cfe-dev/2022-January/069658.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266 ___ cfe-commits mailing list

[clang-tools-extra] 37ec65e - [clangd] Enable expand-auto for decltype(auto).

Author: Haojian Wu Date: 2022-01-10T13:46:56+01:00 New Revision: 37ec65e1d705f56fe5551de1dfcbac1e071588a2 URL: https://github.com/llvm/llvm-project/commit/37ec65e1d705f56fe5551de1dfcbac1e071588a2 DIFF: https://github.com/llvm/llvm-project/commit/37ec65e1d705f56fe5551de1dfcbac1e071588a2.diff

[PATCH] D116921: [clangd] Enable expand-auto for decltype(auto).

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ec65e1d705: [clangd] Enable expand-auto for decltype(auto). (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116921/new/

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

aaron.ballman added inline comments. Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2 + +// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t -fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s +export import dummy; // expected-error {{export

[clang] f282b68 - set __NO_MATH_ERRNO__ if -fno-math-errno

Author: Alex Xu (Hello71) Date: 2022-01-10T08:45:46-05:00 New Revision: f282b6809105075b65974989459ee420ecd406e9 URL: https://github.com/llvm/llvm-project/commit/f282b6809105075b65974989459ee420ecd406e9 DIFF:

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398601. egorzhdan added a comment. Diagnose mismatches between class property of a class and a class property of its superclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. In D111566#3228949 , @rjmccall wrote: > Block pointers are actually data pointers and should stay in the generic > address space if they don't have an address space qualifier. That might > require new logic. Thanks! I kept

[libunwind] 914fffc - [libunwind][cmake] Create `LIBUNWIND_INSTALL_INCLUDE_DIR` CACHE PATH

Author: John Ericson Date: 2022-01-10T21:31:52Z New Revision: 914fffc7f2492a1e4bc419a80c30fdb3f9440698 URL: https://github.com/llvm/llvm-project/commit/914fffc7f2492a1e4bc419a80c30fdb3f9440698 DIFF: https://github.com/llvm/llvm-project/commit/914fffc7f2492a1e4bc419a80c30fdb3f9440698.diff LOG:

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood updated this revision to Diff 398754. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116518/new/ https://reviews.llvm.org/D116518 Files: clang/docs/LibASTMatchersReference.html clang/docs/ReleaseNotes.rst

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood updated this revision to Diff 398756. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D116967: [HIP] Fix device malloc/free

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:80 +#if HIP_VERSION_MAJOR > 4 || (HIP_VERSION_MAJOR == 4 && HIP_VERSION_MINOR >= 5) +extern "C" __device__

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks great with the option flag. Landing this patch will enable more people to test the new mode and produce feedback on whether the constraint solver keeps working well enough in presence of

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext,

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 398748. jhuber6 added a comment. Undoing accidental clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Driver.cpp

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c33b0ec976: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a2c33b0 - [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

Author: Richard Date: 2022-01-10T15:44:12-07:00 New Revision: a2c33b0ec976c894dc45558d0b50c9c2fe87e1da URL: https://github.com/llvm/llvm-project/commit/a2c33b0ec976c894dc45558d0b50c9c2fe87e1da DIFF: https://github.com/llvm/llvm-project/commit/a2c33b0ec976c894dc45558d0b50c9c2fe87e1da.diff LOG:

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11494 + const Type *TypePtr = T.getTypePtr(); + return TypePtr->isFunctionType() + ? llvm::DataLayout(getTargetInfo().getDataLayoutString()) rjmccall wrote: > You can just do

[clang] d789ea7 - [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

Author: Wolfgang Pieb Date: 2022-01-10T16:38:01-08:00 New Revision: d789ea713372d44e50ff52a85a198ac6bbedaef9 URL: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9 DIFF: https://github.com/llvm/llvm-project/commit/d789ea713372d44e50ff52a85a198ac6bbedaef9.diff

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3784-3790 + if (auto *TD = dyn_cast(D)) { +// CXXDeductionGuideDecls reference the class template parameters so we need +// to make sure not to call this twice on the same template

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When searching for AST nodes

[PATCH] D116721: [Tooling] When transferring compile commands between files, always use '--'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4258d68dc737: [Tooling] When transferring compile commands between files, always use -- (authored by sammccall). Repository: rG LLVM Github

[clang-tools-extra] 4258d68 - [Tooling] When transferring compile commands between files, always use '--'

Author: Sam McCall Date: 2022-01-11T01:41:42+01:00 New Revision: 4258d68dc73789bc7fc491734c9c392809b1b29a URL: https://github.com/llvm/llvm-project/commit/4258d68dc73789bc7fc491734c9c392809b1b29a DIFF: https://github.com/llvm/llvm-project/commit/4258d68dc73789bc7fc491734c9c392809b1b29a.diff

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 398779. sammccall added a comment. Fix printName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files: clang-tools-extra/clangd/AST.cpp

[clang] 86c5b87 - [AST] Don't consider 'ExportDecl' when calculating DeclContext 'Encloses'

Author: Chuanqi Xu Date: 2022-01-11T09:54:57+08:00 New Revision: 86c5b870b2e5192a9414204500a53b31524db065 URL: https://github.com/llvm/llvm-project/commit/86c5b870b2e5192a9414204500a53b31524db065 DIFF: https://github.com/llvm/llvm-project/commit/86c5b870b2e5192a9414204500a53b31524db065.diff

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11496 + .getProgramAddressSpace() + : getTargetAddressSpace(T.getQualifiers()); +} Oh, I'm sorry I missed this. Parsing the data layout string into an

[PATCH] D111566: [SYCL] Fix function pointer address space

rjmccall added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11494 + const Type *TypePtr = T.getTypePtr(); + return TypePtr->isFunctionType() + ? llvm::DataLayout(getTargetInfo().getDataLayoutString()) You can just do

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, hiraditya, inglorion, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

sammccall updated this revision to Diff 398775. sammccall added a comment. Never eat malformed decl while code completing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116294/new/ https://reviews.llvm.org/D116294 Files:

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

sammccall added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:153 + // probably truncated, so don't eat more tokens. + if (!Toks.back().is(tok::code_completion)) +SkipMalformedDecl(); kadircet wrote: > i don't follow

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

This revision was automatically updated to reflect the committed changes. Closed by commit rGd789ea713372: [Diagnostics] Dont drop a statically set NoWarningAsError flag during option… (authored by wolfgangp). Herald added a project: clang. Changed prior to commit:

[clang] 98ab43a - [HIP] Fix device only linking for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2022-01-10T17:38:02-05:00 New Revision: 98ab43a1d209875ce9cc39420d3e6af57ed0f5b2 URL: https://github.com/llvm/llvm-project/commit/98ab43a1d209875ce9cc39420d3e6af57ed0f5b2 DIFF:

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98ab43a1d209: [HIP] Fix device only linking for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

MaskRay accepted this revision. MaskRay added a comment. In D116503#3231138 , @mstorsjo wrote: > In D116503#3223094 , @MaskRay wrote: > >> But make sure to wait a bit to see what others think. > > Do you think

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG140a6b1e5c68: [clang][OpenMP5.1] Initial parsing/sema for indirect clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116764/new/

[clang] 140a6b1 - [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

Author: Jennifer Yu Date: 2022-01-10T16:58:56-08:00 New Revision: 140a6b1e5c6857617a83f66680b4829ff2b08d82 URL: https://github.com/llvm/llvm-project/commit/140a6b1e5c6857617a83f66680b4829ff2b08d82 DIFF: https://github.com/llvm/llvm-project/commit/140a6b1e5c6857617a83f66680b4829ff2b08d82.diff

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 398784. eandrews added a comment. Implement review comments - add a comment + remove unnecessary code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews updated this revision to Diff 398723. eandrews added a comment. Implemented review comment to move logic into function (`getTargetAddressSpace`) as opposed to call site. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files:

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3232584 , @fhahn wrote: > Rebased and made sure comments are consistent between different folders. > > In D116935#3232227 , @craig.topper > wrote: > >> In D116935#3232203

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione created this revision. kastiglione added reviewers: akyrtzi, jingham. Herald added subscribers: usaxena95, arphaman. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the `StringRef` summary provider in favor

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

rjmccall added a comment. Yes, this LGTM implementation-wise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/new/ https://reviews.llvm.org/D115440 ___ cfe-commits mailing list

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

efriedma added a comment. I'll just note here that doing this globally is likely to have unexpected results... consider, for example: #include void f() { long x = M_PI; } Currently, the implicit conversion warning points into math.h. That said, I don't see any problem with the current

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398753. egorzhdan added a comment. Fix clang-format warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D45438: [CodeView] Enable debugging of captured variables within C++ lambdas

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:812-814 + // CodeView types with C++ mangling need a type identifier. + if (CGM.getCodeGenOpts().EmitCodeView) +return true; Just came across this code today - it's /probably/ a

[clang] bbf234b - [CodeCompletion] Complete designators for fields in anonymous structs/unions

Author: Sam McCall Date: 2022-01-11T00:58:49+01:00 New Revision: bbf234b56a82d1b9b7fa58f8b10f16d417500d9b URL: https://github.com/llvm/llvm-project/commit/bbf234b56a82d1b9b7fa58f8b10f16d417500d9b DIFF: https://github.com/llvm/llvm-project/commit/bbf234b56a82d1b9b7fa58f8b10f16d417500d9b.diff

[PATCH] D116717: [CodeCompletion] Complete designators for fields in anonymous structs/unions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf234b56a82: [CodeCompletion] Complete designators for fields in anonymous structs/unions (authored by sammccall). Repository: rG LLVM Github

  1   2   3   >