[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), This seems to

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417534. cor3ntin added a comment. - Check That the type is dependant - Only emit the warning when Kind == Sema::CheckConstexprKind::Diagnose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417533. thieta added a comment. Added back removed blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417535. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122249/new/ https://reviews.llvm.org/D122249 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group, - Flags<[CC1Option, NoArgumentUnused,

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 417539. joaomoreira edited the summary of this revision. joaomoreira added a reviewer: nickdesaulniers. This revision is now accepted and ready to land. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417525. vabridgers added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files:

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if (!VD->getType()->isLiteralType(SemaRef.Context)) +SemaRef.Diag(VD->getLocation(), hubert.reinterpretcast wrote:

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. The patch itself seems sensible to me. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:119 + auto NonEmptyStringOptional = unaryOperator( + hasOperatorName("!"), + hasUnaryOperand(cxxMemberCallExpr( Why handle negation

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

hans accepted this revision. hans added a comment. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 ___ cfe-commits mailing list

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417504. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Diagnose "same name as its class" before setting the declarator invalid as otherwise it would not be diagnosed. This also aligns with gcc's behavior.

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

jansvoboda11 updated this revision to Diff 417527. jansvoboda11 added a comment. Remove slash from test to make it pass on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 Files:

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added a comment. I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- RoundTrip method. There, we can se the following statement: #ifndef NDEBUG bool DoRoundTripDefault = true; #else bool DoRoundTripDefault = false; #endif Comment in the file

[clang] 09c0685 - [NFC] Remove trailing whitespaces in clang/Driver/Options.td

Author: Tobias Hieta Date: 2022-03-23T10:23:33+01:00 New Revision: 09c0685a043dd4028545c134b562c2605e294855 URL: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855 DIFF: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855.diff

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added a comment. Pushed the whitespace fix as a NFC here: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang added a comment. In D122141#3400578 , @zixuw wrote: > LGTM. Need to rebase. Do you think `ProductName` should be a general property > of `APISerializer` or something specific to the `SymbolGraphSerializer`? Good question! I think I am going to

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

steakhal added a comment. > The notes are prunable, i.e. they won't bring-in entire stack frames worth of > notes just because they're there, but they will be always visible regardless > of whether the value is of interest to the bug report. I think this is > debatable, the arguably better

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. This sounds really cool! >> Overall I suspect making this a tidy check would make it more useful to more >> people. Yup, it would be super useful addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

MyDeveloperDay added a comment. I'm a little uncomfortable with //# becoming // # Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/ https://reviews.llvm.org/D121451 ___ cfe-commits

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:219 + NonLiteral n; // cxx2b-note {{non-literal type 'NonLiteral' cannot be used in a constant expression}} \ +// cxx2b-warning {{definition of a

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122278/new/ https://reviews.llvm.org/D122278

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417537. thieta added a comment. Split whitespace to it's own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td

[clang] a451a29 - [CodeGen][OpenMP] Add alignment to test (NFC)

Author: Nikita Popov Date: 2022-03-23T10:28:04+01:00 New Revision: a451a291278b22b031b2b6d8ca4a3b2517a491f6 URL: https://github.com/llvm/llvm-project/commit/a451a291278b22b031b2b6d8ca4a3b2517a491f6 DIFF: https://github.com/llvm/llvm-project/commit/a451a291278b22b031b2b6d8ca4a3b2517a491f6.diff

[clang] eb5ecbb - [llvm][AArch64] Insert "bti j" after call to setjmp

Author: David Spickett Date: 2022-03-23T09:51:02Z New Revision: eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74 URL: https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74 DIFF: https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74.diff

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5ecbbcbb6c: [llvm][AArch64] Insert bti j after call to setjmp (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98fd3b359866: Driver: Dont warn on -mbranch-protection when linking (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 98fd3b3 - Driver: Don't warn on -mbranch-protection when linking

Author: Tom Stellard Date: 2022-03-22T23:17:42-07:00 New Revision: 98fd3b359866f474ab1c097c22fb5c3be356b996 URL: https://github.com/llvm/llvm-project/commit/98fd3b359866f474ab1c097c22fb5c3be356b996 DIFF: https://github.com/llvm/llvm-project/commit/98fd3b359866f474ab1c097c22fb5c3be356b996.diff

[clang] 1089cdd - Revert "Driver: Don't warn on -mbranch-protection when linking"

Author: Tom Stellard Date: 2022-03-22T23:36:57-07:00 New Revision: 1089cdda776bbd437d6507242f2621ec83af7118 URL: https://github.com/llvm/llvm-project/commit/1089cdda776bbd437d6507242f2621ec83af7118 DIFF: https://github.com/llvm/llvm-project/commit/1089cdda776bbd437d6507242f2621ec83af7118.diff

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. Herald added a subscriber: StephenFan. In D70401#3391561 , @khchen wrote: > I found > https://github.com/llvm/llvm-test-suite/blob/main/SingleSource/UnitTests/2003-05-26-Shorts.c > result is mismatched with gcc's

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

hokein accepted this revision. hokein added a comment. OK, let's move forward with it. Thanks for the investigation and the fix! I will take a look on the invalid-bit problem, and monitor the crash report more closely. Comment at: clang/lib/Sema/TreeTransform.h:14708 }

[clang] 27f6cee - Revert "[CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()"

Author: Nikita Popov Date: 2022-03-23T10:24:39+01:00 New Revision: 27f6cee12d2ab52e44e78d26733ab92ced730f13 URL: https://github.com/llvm/llvm-project/commit/27f6cee12d2ab52e44e78d26733ab92ced730f13 DIFF: https://github.com/llvm/llvm-project/commit/27f6cee12d2ab52e44e78d26733ab92ced730f13.diff

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM with the test only requiring Arm. Please mention in the commit that it is possible to ignore this warning in system headers, but we chose not to because of potential

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta created this revision. thieta added reviewers: hans, mstorsjo, rnk. Herald added a project: All. thieta requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. MSVC supports passing /Wv and /Wv:17 to ignore

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417551. dang added a comment. Rebasing on top of latest main which includes https://reviews.llvm.org/rG89f6b26f1beb2c1344f5cfeb34e405128544c76b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. In D118493#3401448 , @tstellar wrote: > The rule that is broken is "standard RPATHs" Fedora installs libomp to > /usr/lib64. > > ... > > I think what we'll do in Fedora is just add -fno-openmp-implicit-rpath to > the

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

iains added a comment. I have no comment the patch itself, that seems fine, I even agree that this could be convenient :-) However, I am concerned that this now means that '-fprebuilt-module-path' has meaning for both clang modules and c++20 modules - which is something we agree is generally

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. Kind of surprised this wasn't already a thing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121099/new/ https://reviews.llvm.org/D121099

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

aaron.ballman added a comment. In D120397#3401380 , @ChuanqiXu wrote: > In D120397#3399808 , @aaron.ballman > wrote: > >> Can you also add a release note that explains we've fixed the crash? > > My thought is to

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417572. dang added a comment. Accidentally re-added some of the old files in SymbolGraph/ during the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files:

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa45ad3ca8ce7: [clang-format] [doc] Add script to automatically update help output in… (authored by curdeius). Changed prior to commit:

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417586. cor3ntin added a comment. - Fix test - Add a comment explaining why we do not use CheckLiteralType @aaron,ballman I completely missed that...! However, CheckLiteralType does a bunch of tests that we do not need to diagnose *why* a type is not

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

bjope added a comment. Hello. We've got some problem in our downstream tests after this patch and I'm trying to figure out how things are supposed to work. Maybe someone being part of this review knows. Problem is that we have some libc verification suites that include test cases using

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant added a comment. Note that some fix is important to make if we think that the -Wmissing-prototypes warning is valuable, because there are cases where it currently would fire where the function cannot explicitly be given internal linkage, e.g. namespace { struct Initialized {}; }

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes:

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

iains added a comment. for the record, I experimented with adding the linkage as an output for AST dumps (adding to TextNodeDumper / DeclPrinter), since it seems that this could be generally useful. this works fine, but, it would create a lot of testsuite churn - around 350 tests would need

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein updated this revision to Diff 417567. hokein added a comment. some tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122303/new/ https://reviews.llvm.org/D122303 Files: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, feel free to add the assert when you land. Comment at: clang/include/clang/Sema/ParsedAttr.h:813 void takeAllFrom(AttributePool ) { takePool(pool); pool.Attrs.clear();

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Name; I see we are

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

sammccall added a comment. I think my main suggestion is to sort the symbols, not just the rules. Having the rules in blocks grouped by the symbol they produce, but not in symbol order, seems confusing to reason about. The extraction of TestGrammar seems unrelated to the rest of the patch and

[clang] ba2be80 - [CGOpenMPRuntime] Reuse getDepobjElements() (NFC)

Author: Nikita Popov Date: 2022-03-23T11:31:49+01:00 New Revision: ba2be802b04a19c2398401867de3746df1bad7d6 URL: https://github.com/llvm/llvm-project/commit/ba2be802b04a19c2398401867de3746df1bad7d6 DIFF: https://github.com/llvm/llvm-project/commit/ba2be802b04a19c2398401867de3746df1bad7d6.diff

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei accepted this revision. pengfei added a comment. LGTM. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:6 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang

[clang] 8b62dd3 - Reapply [CodeGen] Avoid deprecated Address ctor in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-23T12:06:11+01:00 New Revision: 8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d URL: https://github.com/llvm/llvm-project/commit/8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d DIFF: https://github.com/llvm/llvm-project/commit/8b62dd3cd6d775a9c6ae3bfe841bf965dc2c944d.diff

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf updated this revision to Diff 417566. qiucf marked 3 inline comments as done. qiucf added a comment. - Move test to another file - Add documentation on option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

aaron.ballman added a comment. In D118052#3401861 , @joaomoreira wrote: > I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- > RoundTrip method. There, we can se the following statement: > > #ifndef NDEBUG > bool

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3401947 , @MyDeveloperDay wrote: > I'm a little uncomfortable with > > //# > > becoming > > // # > > At least without an option for it to not make changes Don't you think that `//#PPdirective` should be indented

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417570. dang added a comment. Missed some stuff in the previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files: clang/include/clang/Driver/Options.td

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

aaron.ballman added a comment. Thank you for the fix! This LGTM with a minor nit, but please also add a release note for the fix. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11062-11066 + if (auto *FirstNS = PrevNS->getFirstDecl()) +// 'inline' must appear on the original

[clang] 5fdc4dd - [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

Author: Vince Bridgers Date: 2022-03-23T08:26:37-05:00 New Revision: 5fdc4dd7770486c0127dc5919aafea3f8ff2e61e URL: https://github.com/llvm/llvm-project/commit/5fdc4dd7770486c0127dc5919aafea3f8ff2e61e DIFF:

[clang] 9ef7ac5 - [analyzer] Fix crash in RangedConstraintManager.cpp

Author: Vince Bridgers Date: 2022-03-23T08:26:40-05:00 New Revision: 9ef7ac51af67d08212dc69e5a932c4aa447ee9b7 URL: https://github.com/llvm/llvm-project/commit/9ef7ac51af67d08212dc69e5a932c4aa447ee9b7 DIFF:

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fdc4dd77704: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC) (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef7ac51af67: [analyzer] Fix crash in RangedConstraintManager.cpp (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c070d5c - [CGOpenMPRuntime] Remove uses of deprecated Address constructor

Author: Nikita Popov Date: 2022-03-23T12:40:44+01:00 New Revision: c070d5ceff05c3459b9a9add6d18aae9a3fa5916 URL: https://github.com/llvm/llvm-project/commit/c070d5ceff05c3459b9a9add6d18aae9a3fa5916 DIFF: https://github.com/llvm/llvm-project/commit/c070d5ceff05c3459b9a9add6d18aae9a3fa5916.diff

[clang] 0254f59 - Forgot to add a release note for WG14 N2412.

Author: Aaron Ballman Date: 2022-03-23T07:39:53-04:00 New Revision: 0254f59fef86f9b4f4489490795f3e31d3d324d3 URL: https://github.com/llvm/llvm-project/commit/0254f59fef86f9b4f4489490795f3e31d3d324d3 DIFF: https://github.com/llvm/llvm-project/commit/0254f59fef86f9b4f4489490795f3e31d3d324d3.diff

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

urnathan added a comment. In D122119#3401322 , @ChuanqiXu wrote: > > I think the example is invalid since it violates [[ > http://eel.is/c++draft/module.interface#6 | [module.interface]p6 ]] > explicitly. If this is intended behavior or by design,

[clang] b0bc93d - Revert "[clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""."

Author: Zahira Ammarguellat Date: 2022-03-23T04:54:00-07:00 New Revision: b0bc93da926a943cdc2d8b04f8dcbe23a774520c URL: https://github.com/llvm/llvm-project/commit/b0bc93da926a943cdc2d8b04f8dcbe23a774520c DIFF:

[clang] b26466d - Update the C and C++ status pages now that Clang 14 is out

Author: Aaron Ballman Date: 2022-03-23T07:59:52-04:00 New Revision: b26466d0019582f9b3dc65587cf8043da144b45d URL: https://github.com/llvm/llvm-project/commit/b26466d0019582f9b3dc65587cf8043da144b45d DIFF: https://github.com/llvm/llvm-project/commit/b26466d0019582f9b3dc65587cf8043da144b45d.diff

[PATCH] D122301: [clang-format] Fix invalid code generation with comments in lambda

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122301/new/ https://reviews.llvm.org/D122301

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Reductions need to be performed in

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

sammccall added a comment. We'd like to proceed here by extracting the include-cleaner functionality from clangd into a library. It would be used by: - clangd - a new clang-tidy check - possibly a standalone tool, if clang-tidy doesn't fit well into the cleanup workflow - some out-of-tree

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane added a comment. Can you add some tests for the OTHER forms of 'auto' as well? We have `decltype(auto)` and `auto_type`, and I want to make sure whatever we do with those 'looks right'. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4773 + QualType

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

Szelethus added a comment. LGTM on my end, this is awesome! In D122285#3401754 , @steakhal wrote: >> The notes are prunable, i.e. they won't bring-in entire stack frames worth >> of notes just because they're there, but they will be always visible >>

[clang] edb7ba7 - Revert "[llvm][AArch64] Insert "bti j" after call to setjmp"

Author: David Spickett Date: 2022-03-23T10:43:20Z New Revision: edb7ba714acba1d18a20d9f4986d2e38aee1d109 URL: https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109 DIFF: https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109.diff

[clang] 47eb4f7 - [CGOpenMPRuntime] Specify correct type in EmitLoadOfPointerLValue()

Author: Nikita Popov Date: 2022-03-23T11:51:14+01:00 New Revision: 47eb4f7dcd845878b16a53dadd765195b9c24b6e URL: https://github.com/llvm/llvm-project/commit/47eb4f7dcd845878b16a53dadd765195b9c24b6e DIFF: https://github.com/llvm/llvm-project/commit/47eb4f7dcd845878b16a53dadd765195b9c24b6e.diff

[clang] aaf2bcc - [CodeGen][OpenMP] Add alignment to test (NFC)

Author: Nikita Popov Date: 2022-03-23T12:01:00+01:00 New Revision: aaf2bccf1fa2f5c96de7354298bede139f8cb7e5 URL: https://github.com/llvm/llvm-project/commit/aaf2bccf1fa2f5c96de7354298bede139f8cb7e5 DIFF: https://github.com/llvm/llvm-project/commit/aaf2bccf1fa2f5c96de7354298bede139f8cb7e5.diff

[clang] c3b9819 - Reland "[llvm][AArch64] Insert "bti j" after call to setjmp"

Author: David Spickett Date: 2022-03-23T11:43:43Z New Revision: c3b98194df5572bc9b33024b48457538a7213b4c URL: https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c DIFF: https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c.diff

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman added a comment. I'm seeing precommit CI failures: Failed Tests (1): Clang :: SemaCXX/constant-expression-cxx2b.cpp Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905 +if (SemaRef.LangOpts.CPlusPlus2b) { + if

[clang] a45ad3c - [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

Author: Marek Kurdej Date: 2022-03-23T13:17:50+01:00 New Revision: a45ad3ca8ce78988a4d51b432455ce0bbf13 URL: https://github.com/llvm/llvm-project/commit/a45ad3ca8ce78988a4d51b432455ce0bbf13 DIFF: https://github.com/llvm/llvm-project/commit/a45ad3ca8ce78988a4d51b432455ce0bbf13.diff

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417593. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[clang] 59dadd1 - [clang][lex] Fix failures with Microsoft header search rules

Author: Jan Svoboda Date: 2022-03-23T14:49:17+01:00 New Revision: 59dadd178b0b12cb4a975a262ed20e7c3822aedc URL: https://github.com/llvm/llvm-project/commit/59dadd178b0b12cb4a975a262ed20e7c3822aedc DIFF: https://github.com/llvm/llvm-project/commit/59dadd178b0b12cb4a975a262ed20e7c3822aedc.diff

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

bc-lee updated this revision to Diff 417595. bc-lee added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121868/new/ https://reviews.llvm.org/D121868 Files: clang/include/clang/Driver/Options.td

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG59dadd178b0b: [clang][lex] Fix failures with Microsoft header search rules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417596. dang added a comment. Clarify doc comment for ExtractAPIAction::PrepareToExecuteAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files:

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D122083#3402440 , @royjacobson wrote: > In D122083#3402289 , @erichkeane > wrote: > >> Can you

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added a comment. In D121122#3402442 , @aaron.ballman wrote: > In D121122#3402334 , @bjope wrote: > >> Hello. We've got some problem in our downstream tests after this patch and >> I'm trying to figure

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122265/new/ https://reviews.llvm.org/D122265

[libunwind] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff

[clang-tools-extra] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG683fc6203cfa: [clang][AArc64][SVE] Implement vector-scalar operators (authored by DavidTruby). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3 + +// REQUIRES: shell + saudi wrote: > I was wondering whether it could be a concern that this test will be skipped > on Windows systems, where `clang-cl` specific

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f63cd763ec8: [Clang][NFC] Cleanup dcl.constexpr/p3 tests (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122265/new/

[clang] 9f63cd7 - [Clang][NFC] Cleanup dcl.constexpr/p3 tests

Author: Corentin Jabot Date: 2022-03-23T15:37:48+01:00 New Revision: 9f63cd763ec85e89212e071d5d50ae5a3d5f384d URL: https://github.com/llvm/llvm-project/commit/9f63cd763ec85e89212e071d5d50ae5a3d5f384d DIFF:

Re: [PATCH] D122255: Meta directive runtime support

I quickly went through the D120573. There are many overlapping. On Tue, Mar 22, 2022 at 4:23 PM Johannes Doerfert via Phabricator < revi...@reviews.llvm.org> wrote: > jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. > jdoerfert added a comment. > > This contains a lot of unrelated

[clang] 94fd00f - [Concepts] Fix placeholder constraints when references are involved

Author: Roy Jacobson Date: 2022-03-23T11:14:58-04:00 New Revision: 94fd00f41ebddf84148f494410130527169d9573 URL: https://github.com/llvm/llvm-project/commit/94fd00f41ebddf84148f494410130527169d9573 DIFF: https://github.com/llvm/llvm-project/commit/94fd00f41ebddf84148f494410130527169d9573.diff

[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fd00f41ebd: [Concepts] Fix placeholder constraints when references are involved (authored by royjacobson). Repository: rG LLVM Github Monorepo

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius added a comment. Relanded in https://github.com/llvm/llvm-project/commit/4e88cb6825eefca3c0eb66b5ae40ab123fcc7073 with a fix and a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121450/new/

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905-1907 + CheckLiteralType(SemaRef, Kind, VD->getLocation(), VD->getType(), + diag::warn_cxx20_compat_constexpr_var, +

[clang-tools-extra] b857a50 - [clangd] Support include-fixer inside macro arguments.

Author: Sam McCall Date: 2022-03-23T17:12:33+01:00 New Revision: b857a5092c5e07121426196e79d51400382ff27a URL: https://github.com/llvm/llvm-project/commit/b857a5092c5e07121426196e79d51400382ff27a DIFF: https://github.com/llvm/llvm-project/commit/b857a5092c5e07121426196e79d51400382ff27a.diff

[PATCH] D120619: [clangd] Support include-fixer inside macro arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb857a5092c5e: [clangd] Support include-fixer inside macro arguments. (authored by sammccall). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D120619?vs=411622=417655#toc

  1   2   3   4   >