[clang-tools-extra] 5091357 - [clangd] Disable ScopedMemoryLimit on tsan builds

Author: Kadir Cetinkaya Date: 2023-01-17T09:09:08+01:00 New Revision: 5091357e1ba8bc709680c327fe71a90676f86197 URL: https://github.com/llvm/llvm-project/commit/5091357e1ba8bc709680c327fe71a90676f86197 DIFF:

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 489720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index:

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:200 + using ExprVisitorFunc = std::function; + bool visitConditional(const AbstractConditionalOperator *E, +ExprVisitorFunc VisitFunc); tbaeder wrote: >

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { tkuchta wrote: > browneee wrote: > > The `s_label`

[PATCH] D141905: [C++20] [Modules] Only diagnose the non-inline external variable definitions in header units

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3eb004ca78f: [C++20] [Modules] Only diagnose the non-inline external variable (authored by ChuanqiXu). Herald added a project: clang. Herald added

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

LuoYuanke added a comment. @zixuan-wu, changing x86_amx would break our internal code. May I know the motivation to change the type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains created this revision. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address part of https://github.com/llvm/llvm-project/issues/60079. Deleted and Defaulted

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 489722. ckandeler marked 2 inline comments as done. ckandeler retitled this revision from "[clangd] Add semantic tokens for angle brackets" to "[clangd] Add semantic token for angle brackets". ckandeler added a comment. Added test cases, merged the two

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM ,thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422

[clang] b3eb004 - [C++20] [Modules] Only diagnose the non-inline external variable

Author: Chuanqi Xu Date: 2023-01-17T17:48:09+08:00 New Revision: b3eb004ca78f522c91c0d83bafeab2ee753417c8 URL: https://github.com/llvm/llvm-project/commit/b3eb004ca78f522c91c0d83bafeab2ee753417c8 DIFF: https://github.com/llvm/llvm-project/commit/b3eb004ca78f522c91c0d83bafeab2ee753417c8.diff

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers:

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

hokein added a comment. Have you run the script on the zombie_names page? Does it work? Comment at: clang/tools/include-mapping/gen_std.py:67 required=True) + parser.add_argument('-output', + default='SymbolMap.inc',

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky added a comment. Hey! I can see that the build: https://reviews.llvm.org/harbormaster/build/311598/ failed, but I am not sure whether this is related to my change. Could someone take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 489753. tblah marked 7 inline comments as done. tblah added a comment. - Implement operator!= as !(operator==) - Move insertion point computation to StackArraysAnalysisWrapper::analyseFunction - Remove special-casing for join(allocated, unknown) - Add

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:120 + // which operations we intend to rewrite before it calls the pattern rewriter + llvm::SmallDenseMap insertionPoints; + jeanPerier wrote: > It is definitely weird to

[clang] b164b04 - [Clang] Convert test to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-01-17T10:08:57+01:00 New Revision: b164b047f2b41ff0c0a3ede3baa29c230c78cd32 URL: https://github.com/llvm/llvm-project/commit/b164b047f2b41ff0c0a3ede3baa29c230c78cd32 DIFF: https://github.com/llvm/llvm-project/commit/b164b047f2b41ff0c0a3ede3baa29c230c78cd32.diff

[PATCH] D140415: [flang] stack arrays pass

jeanPerier added inline comments. Herald added a subscriber: sunshaoce. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:104 + + bool operator!=(const InsertionPoint ) const { +return (location != rhs.location) || It's better to negate the `==

[PATCH] D141892: Implement modernize-use-constraints

njames93 added a comment. In D141892#4057722 , @ccotter wrote: > 2. replace the non `_v` templates to the `_v` variants `is_same` -> > `is_same_v` or the equivalent concept `same_as` See D137302 Repository: rG

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

foad added a comment. Herald added a subscriber: luke. In D141798#4055050 , @barannikov88 wrote: > It would be nice to have comments reflecting the new behavior in the case of > 0 / max value. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140377: [clang][Interp] Compound assign operators for FP values

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140377/new/ https://reviews.llvm.org/D140377

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada created this revision. domada added reviewers: dpalermo, skatrak, kiranktp, RogerV-AMD, NimishMishra, jsjodin. Herald added subscribers: pmatos, asb, guansong, kbarton, hiraditya, jgravelle-google, sbc100, yaxunl, nemanjai, dschuff. Herald added a project: All. domada requested review of

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

jmorse added a comment. Hi, In D141381#4056661 , @fdeazeve wrote: > While SROA will not touch this: > > define @foo(ptr %arg) { > call void @llvm.dbg.declare(%arg, [...], metadata !DIExpression()) > > It completely destroys the debug information

[clang] 09e4449 - [PS5] Handle visibility options same as PS4

Author: Paul Robinson Date: 2023-01-17T11:27:51-08:00 New Revision: 09e4449901d7fc780806778181cf3136c1e08e98 URL: https://github.com/llvm/llvm-project/commit/09e4449901d7fc780806778181cf3136c1e08e98 DIFF: https://github.com/llvm/llvm-project/commit/09e4449901d7fc780806778181cf3136c1e08e98.diff

[clang] eae8d22 - [PS4] NFC: rewrite a test to use lit's DEFINE feature

Author: Paul Robinson Date: 2023-01-17T11:27:51-08:00 New Revision: eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45 URL: https://github.com/llvm/llvm-project/commit/eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45 DIFF: https://github.com/llvm/llvm-project/commit/eae8d22607027ddc9067ca8fa5fea1f1f6a9fb45.diff

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added a comment. In D141310#4054351 , @dblaikie wrote: > @adriandole do you plan to deploy this in a codebase? Have you tried it on a > codebase already? > > I'd worry this would just be too noisy, and there's probably enough benign >

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5869-5870 +if (IteratorModifier) { + HasIteratorModifier = true; + getTrailingObjects()[2 * varlist_size()] = IteratorModifier; +} Can we use just a nullptr as a

[clang] 3925fbc - nullptr returned from ActOnTag() is not a valid result

Author: Aaron Ballman Date: 2023-01-17T16:04:35-05:00 New Revision: 3925fbc80019f72bf3f5174736f348acfb5768b0 URL: https://github.com/llvm/llvm-project/commit/3925fbc80019f72bf3f5174736f348acfb5768b0 DIFF: https://github.com/llvm/llvm-project/commit/3925fbc80019f72bf3f5174736f348acfb5768b0.diff

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3925fbc80019: nullptr returned from ActOnTag() is not a valid result (authored by aaron.ballman). Changed prior to

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added a comment. In D141954#4060244 , @philnik wrote: > In D141954#4060212 , @erichkeane > wrote: > >> @ldionne @Mordante The libcxx failure isn't clear what it is complaining >> about, but I

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. The error handling inconsistency is kind of annoying too but this is an improvement. I thought traditionally GCC accepted whatever big number you put after -O Repository: rG LLVM Github

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

dblaikie added a subscriber: colinl. dblaikie added a comment. In D141625#4059486 , @steven_wu wrote: > @dblaikie Do we have any bots running reverse iteration? Hmm, not that I can see/find at a quick glance, which is unfortunate. @mgrang Are you still

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

craig.topper added a comment. Description repeats a slightly different version of the same statement. The existing codebase works correctly upon this bug because the default policy for unmasked intrinsics is set to TAMU. The existing code works because the default policy for unmasked

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141756/new/ https://reviews.llvm.org/D141756 ___ cfe-commits mailing list

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 ___ cfe-commits mailing list

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:428 +// The 0th bit simulates the `vta` of RVV +// The 1st bit simultaes the `vma` of RVV +// constexpr unsigned RVV_VTA = 0x1;

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 5 inline comments as done. TIFitis added a comment. In D131915#4056730 , @kiranchandramohan wrote: > LGTM. Thanks for making the changes and for your patience. Please wait a > couple of days to give other reviewers a chance to have a

[clang] 226ceeb - [RISCV] Use Zvl*b as a lower bound for VScaleRange.

Author: Craig Topper Date: 2023-01-17T11:32:29-08:00 New Revision: 226ceebfa232492d0c4613cd6c9f8e72b970fe08 URL: https://github.com/llvm/llvm-project/commit/226ceebfa232492d0c4613cd6c9f8e72b970fe08 DIFF: https://github.com/llvm/llvm-project/commit/226ceebfa232492d0c4613cd6c9f8e72b970fe08.diff

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG226ceebfa232: [RISCV] Use Zvl*b as a lower bound for VScaleRange. (authored by craig.topper). Herald added a subscriber: luke. Changed prior to commit:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489914. friss added a comment. The pre-commit CI showed some test failures on Windows. Try to address these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 489917. doru1004 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a763343e29f: [Clang] Reject in-class defaulting of previously declared comparison operators (authored by royjacobson). Changed prior to commit:

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

aaron.ballman added a comment. In D141580#4052496 , @sammccall wrote: > To offer the opposing argument: if DeclResult is just a bad idea, then using > it consistently/right might be worse than using it as little as possible. > > FWIW, I find every piece

[clang] 6a76334 - [Clang] Reject in-class defaulting of previously declared comparison operators

Author: Roy Jacobson Date: 2023-01-17T22:29:51+02:00 New Revision: 6a763343e29f339cf3a9d282a309589174c74f09 URL: https://github.com/llvm/llvm-project/commit/6a763343e29f339cf3a9d282a309589174c74f09 DIFF: https://github.com/llvm/llvm-project/commit/6a763343e29f339cf3a9d282a309589174c74f09.diff

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added subscribers: Mordante, ldionne. erichkeane added a comment. @ldionne @Mordante The libcxx failure isn't clear what it is complaining about, but I thought this fix might end up breaking a libcxx test, since it would be easy to fall into the trap of having an implicit conversion

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae updated this revision to Diff 489935. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add BinaryAnalyzeJobClass. Add -Vd to disable validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson updated this revision to Diff 489934. royjacobson added a comment. Reject non class types, update doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 Files:

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added projects: Flang, All. scott.linder requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, jdoerfert. Herald added projects: clang, OpenMP, LLVM.

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489968. friss added a comment. More Windows fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[clang] fe93da2 - [-Wunsafe-buffer-usage] Emit warnings about unsafe operations on arrays

Author: Rashmi Mudduluru Date: 2023-01-17T16:30:13-08:00 New Revision: fe93da22aa7bd57e277571cd692c7c0cc51c0478 URL: https://github.com/llvm/llvm-project/commit/fe93da22aa7bd57e277571cd692c7c0cc51c0478 DIFF:

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added a comment. Looks great! Sounds like you're looking for a more permanent fix, I guess `ConversionFixItGenerator` could try to avoid adding fixits to system header functions? Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI =

[PATCH] D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice new testcase snippets, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124286/new/ https://reviews.llvm.org/D124286

[clang] eec516a - [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading

Author: Joseph Huber Date: 2023-01-17T12:38:56-06:00 New Revision: eec516a0954a5a91490ac4b6e86196e9813d9185 URL: https://github.com/llvm/llvm-project/commit/eec516a0954a5a91490ac4b6e86196e9813d9185 DIFF: https://github.com/llvm/llvm-project/commit/eec516a0954a5a91490ac4b6e86196e9813d9185.diff

[PATCH] D141935: [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec516a0954a: [OpenMP] Make `-Xarch_host` and `-Xarch_device` work for OpenMP offloading (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. In D136554#4059723 , @aeubanks wrote: > one more regression bisected to this: > https://bugs.chromium.org/p/chromium/issues/detail?id=1408177 > `incomplete type 'blink::ResourceClient' used in type trait expression` > I'll try

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. Docs still missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. In D141310#4060069 , @aaron.ballman wrote: > In D141310#4054351 , @dblaikie > wrote: > >> @adriandole do you plan to deploy this in a codebase? Have you tried it on a >> codebase

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

arsenm added inline comments. Comment at: clang/test/CodeGen/complex-strictfp.c:8-9 // Include rounding metadata in the testing. -// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. -// FIXME: All cases of "round.tonearest" in this test are wrong. +// All cases of

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 489942. doru1004 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3474-3475 bool parseMapperModifier(Sema::OpenMPVarListDataTy ); + /// Parses the iterator modifier in map clause. + bool parseIteratorModifier(Sema::OpenMPVarListDataTy ); /// Parses

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:67 + inline std::optional getLevel(IDType ID) { +if (ID < 0 || ID > 3) + return std::nullopt; As I can see, clients do not check for nullopt. Either add checks or

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96 struct Policy { - bool PolicyNone = false; + bool IsUnspecified = false; enum PolicyType { Maybe this should default to true, and the constructor that

[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

steven_wu added a comment. In D141625#4059540 , @tschuett wrote: > EXPANSIVE_CHECKS will reshuffle the llvm::sort input: > https://lists.llvm.org/pipermail/llvm-dev/2018-April/122576.html This is a slightly different concern. The problem to catch is

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 created this revision. dkt01 added reviewers: MyDeveloperDay, owenpan. dkt01 added a project: clang-format. Herald added a project: All. dkt01 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Token annotator for clang-format

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. Happy new year all-- Is there anything left for me to do before this can be merged? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

This revision was automatically updated to reflect the committed changes. Closed by commit rG574a77ae8545: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Thanks for the review, Florian! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___ cfe-commits mailing list

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein updated this revision to Diff 489959. hokein added a comment. rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

craig.topper accepted this revision. craig.topper added a comment. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977 +llvm::SmallVector RVVIntrinsic::getSupportedUnMaskedPolicies() { + return { Possible

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. Hi -has anybody any more concern on this change? I'd like to submit it as soon as possible to unlock @mgorny . Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman closed this revision. aaron.ballman added a comment. Closing as completed by f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

tschuett added a comment. Could you please put an X86.rst file into llvm/docs? There is a Sphinx template with instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141899/new/ https://reviews.llvm.org/D141899

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } shafik wrote: > erichkeane wrote: > > Is there good reason to return true for all non-record types? Should we > >

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 489940. isuckatcs added a comment. - Renamed and moved `isMultiLevelConvertiblePointer()` to `ASTContext` - Added a unit test to test the said function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 arsenm wrote: > scott.linder wrote: > > This is ABI breaking, so maybe we

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 updated this revision to Diff 489967. dkt01 added a comment. Further changes based on HazardyKnusperkeks' review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:379 + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), nullptr, + VK_PRValue, FPOptionsOverride());

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

bryanpkc requested changes to this revision. bryanpkc added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj

[clang] f1f0a0d - Diagnose extensions in 'offsetof'

Author: Aaron Ballman Date: 2023-01-17T14:30:57-05:00 New Revision: f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee URL: https://github.com/llvm/llvm-project/commit/f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee DIFF: https://github.com/llvm/llvm-project/commit/f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee.diff

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. As reported in https://github.com/llvm/llvm-project/issues/54524, and later in https://github.com/llvm/llvm-project/issues/60038, we were

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060212 , @erichkeane wrote: > @ldionne @Mordante The libcxx failure isn't clear what it is complaining > about, but I thought this fix might end up breaking a libcxx test, since it > would be easy to fall into the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae added a comment. In D141705#4059162 , @beanz wrote: > Re-using the `VerifyDebug` action really doesn't make sense. That's not what > the DXIL validator does, and it will be a source of confusion forever. Added BinaryAnalyzeJobClass.

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa44477b1f4b5: [CompilerRT] Remove ubsan static runtime on Apple (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a44477b - [CompilerRT] Remove ubsan static runtime on Apple

Author: usama hameed Date: 2023-01-17T14:33:31-08:00 New Revision: a44477b1f4b5c462474c12144d5f914d04a674cb URL: https://github.com/llvm/llvm-project/commit/a44477b1f4b5c462474c12144d5f914d04a674cb DIFF: https://github.com/llvm/llvm-project/commit/a44477b1f4b5c462474c12144d5f914d04a674cb.diff

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 This is ABI breaking, so maybe we don't want/need to define the underlying

[PATCH] D141450: [Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20

Bigcheese updated this revision to Diff 489970. Bigcheese retitled this revision from "[Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default" to "[Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20". Bigcheese edited the summary of this

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 marked an inline comment as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1205 case tok::r_brace: + if (Scopes.size() > 1) +Scopes.pop_back(); HazardyKnusperkeks wrote: > How does this happen? The only

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060246 , @erichkeane wrote: > In D141954#4060244 , @philnik wrote: > >> In D141954#4060212 , @erichkeane >> wrote: >> >>> @ldionne

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921 PolicyAttrs.TailPolicy = Policy::PolicyType::Agnostic; //

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Oops I didn't mean to approve this with Kito's comments outstanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper added a comment. Herald added a subscriber: luke. Does this really depend on the earlier patches in the series? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

hzq added a comment. @bryanpkc Modified, Thanks for detailed guidance.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 ___ cfe-commits mailing list

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4055516 , @diseraluca wrote: > In D140756#4051383 , @aaron.ballman > wrote: > >> LGTM aside from some minor things you can correct when landing. >> > > Thank you

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 489881. TIFitis added a comment. Addressed reviewer comments. Updated printer and parser to remove the IntegerAttr from appearing. Removed none from map type modifiers, absence of other modifiers implicitly means none. This helps keep it in closer to the

[clang] 574a77a - [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

Author: Volodymyr Sapsai Date: 2023-01-17T15:33:36-06:00 New Revision: 574a77ae85451adc5e2dd9e73652c62bf18eed8d URL: https://github.com/llvm/llvm-project/commit/574a77ae85451adc5e2dd9e73652c62bf18eed8d DIFF:

[PATCH] D141310: [clang] add -Wcompare-function-pointers

dblaikie added a comment. But I don't mean to suggest I should be a decider/veto here - it's cheap to maintain/no big deal, so maybe that's fine - but for myself, having at least some large scale customer with existing experience testing the warning and a strong commitment/motivation to keep

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. I wasn't sure whether to include `getID` and unit-test it, or just drop it until it is used. If anyone has a preference let me know and I'll update the review. Repository: rG LLVM Github

  1   2   3   >