[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2022 + /// \version 17 + bool DecorateReflowedComments; + you are not setting the default value for this so it could be uninitialized, you need to set that in the LLVMStyle

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Not as compelling as user facing strings or comments that clearly refer to the RISC-V ISA rather than the "RISCV" LLVM backend. But I don't really see a good reason not to be consistent. LGTM.

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

tbaeder added a comment. Yeah I think https://reviews.llvm.org/D146358 was first and this patch doesn't add much over it, correct me if I'm wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867

[PATCH] D146947: [docs][clang] Added extra information inside the flag -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer Fix : #60712

aabhinavg created this revision. Herald added a project: All. aabhinavg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146947 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:20 + +AST_MATCHER(Expr, hasUnevaluatedContext) { + if (isa(Node) || isa(Node)) move this matcher to some utils/... It may

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 508517. sammccall marked 4 inline comments as done. sammccall edited the summary of this revision. sammccall added a comment. Address Dmitri's comments Update demo link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

asb added a comment. I've flagged this proposed change on Discourse (more the fact we're looking to change it, rather than the precise register we end up with). Repository: rG LLVM Github

[clang] a826b90 - [clang] source range of variable template specialization should include initializer

Author: Tomasz Kamiński Date: 2023-03-27T12:22:06+02:00 New Revision: a826b9034bbd046a5d0708ba656a3d345d179920 URL: https://github.com/llvm/llvm-project/commit/a826b9034bbd046a5d0708ba656a3d345d179920 DIFF:

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa826b9034bbd: [clang] source range of variable template specialization should include… (authored by tomasz-kaminski-sonarsource). Repository: rG

[clang] 4559e8e - Add Release Note for -mcode-object-v3 removal

Author: pvanhout Date: 2023-03-27T13:41:04+02:00 New Revision: 4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28 URL: https://github.com/llvm/llvm-project/commit/4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28 DIFF: https://github.com/llvm/llvm-project/commit/4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28.diff

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal (authored by Pierre-vh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

aaron.ballman added a comment. In D146945#4223702 , @Pierre-vh wrote: > In D146945#4223677 , @aaron.ballman > wrote: > >> LGTM! Adding the clang-vendors group for awareness since this technically >> could break

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM, but I'd appreciate it if a second set of eyes double-checked whether I missed anything, given the complexity of the changes. (So wait a day or so before

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. okk thankyou sir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#4222920 , @ccotter wrote: > @Febbe - checking in. is this still on your radar? I would love to see this > merged! Yes, this is still on my radar, but currently, I am not satisfied with my solution. There are too many

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. I do not have the commit access, can you commit on my behalf @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145726/new/ https://reviews.llvm.org/D145726 ___ cfe-commits mailing list

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Precommit CI is still falling over because of the libcxx bot. That issue is being actively investigated, but we don't have an ETA on it being resolved. I think these changes are sufficiently safe to land and watch for

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 508740. jp4a50 added a comment. Address minor review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > probinson wrote: > > This doesn't become `Foo` ? > The name stays as `Foo>` but the type of the template parameter > becomes

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. Thanks for all the input! I'll work on @cor3ntin points and take a look at the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146924/new/ https://reviews.llvm.org/D146924

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

aaron.ballman added a comment. In D146867#4224567 , @simideveloper wrote: > but I think this patch https://reviews.llvm.org/D146358 has not been accepted > yet so you should give me a chance. What we want to avoid is having reviewers review multiple

[clang] b530e1a - [LinkerWrapper] Do not extract globals with no offloading language

Author: Joseph Huber Date: 2023-03-27T11:38:27-05:00 New Revision: b530e1af62be16ffb06285ddca27a413f5089b7e URL: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e DIFF: https://github.com/llvm/llvm-project/commit/b530e1af62be16ffb06285ddca27a413f5089b7e.diff

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4c9c016caf: [RISCV] Replace RISCV-RISC-V in strings. (authored by craig.topper). Changed prior to commit:

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG29463612d21b: [RISCV] Replace RISCV - RISC-V in comments. NFC (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D146449?vs=506670=508710#toc Repository: rG LLVM Github

[clang] 2946361 - [RISCV] Replace RISCV -> RISC-V in comments. NFC

Author: Craig Topper Date: 2023-03-27T09:50:17-07:00 New Revision: 29463612d21b7d630476fcecdc8301ddf5634bf7 URL: https://github.com/llvm/llvm-project/commit/29463612d21b7d630476fcecdc8301ddf5634bf7 DIFF: https://github.com/llvm/llvm-project/commit/29463612d21b7d630476fcecdc8301ddf5634bf7.diff

[clang] 0f4c9c0 - [RISCV] Replace RISCV->RISC-V in strings.

Author: Craig Topper Date: 2023-03-27T09:50:17-07:00 New Revision: 0f4c9c016caf52dc45934e0cbf82b1daabcf1d96 URL: https://github.com/llvm/llvm-project/commit/0f4c9c016caf52dc45934e0cbf82b1daabcf1d96 DIFF: https://github.com/llvm/llvm-project/commit/0f4c9c016caf52dc45934e0cbf82b1daabcf1d96.diff

[PATCH] D146892: [documentation]Fixed Random Typo

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ https://reviews.llvm.org/D146892

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); Ensuring the right include order will be

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. I know this is a bit of a redirection/scope creep/etc - but I'd quite like to see a solution that is likely to be usable for the "std::function" problem (stepping into std::function should allow you to reach the underlying function - but lldb currently skips any call

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

simideveloper added a comment. but I think this patch https://reviews.llvm.org/D146358 has not been accepted yet so you should give me a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 508709. francii added a comment. Remove `NoArgumentUnused`, claim -K when checking target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files:

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146975/new/ https://reviews.llvm.org/D146975

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc,

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > Ensuring the right include

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.cpp:140 getFilePaths().clear(); - std::string CandidateLibPath = getArchSpecificLibPath(); - if (getVFS().exists(CandidateLibPath)) -getFilePaths().push_back(CandidateLibPath); + for (const

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

MaskRay added a comment. The new test can be placed in `arch-specific-libdir-rpath.c`. One or two additional RUN lines seem sufficient, no need to duplicate too many. Also, use `--target=` for new tests and avoid `^//$`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146686/new/

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

aaron.ballman added a comment. I think this LGTM, but I'm holding off on signing off until @shafik is satisfied with the part he was asking about. You should add a release note for the fix, too. Comment at: clang/lib/Sema/SemaExpr.cpp:17891-17894 + // It is possible

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); tra wrote: > jhuber6 wrote: > > tra

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. From the discussion on the issue: > Do we want this loosening of the restriction to apply to *only* `std` and the > same followed by a number, or to any reserved identifier used in a module? > e.g., > > module std; // error today, but will become a warning >

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6 wrote: > tra wrote: > >

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aprantl added a comment. In D146595#4225048 , @dblaikie wrote: > I know this is a bit of a redirection/scope creep/etc - but I'd quite like to > see a solution that is likely to be usable for the "std::function" problem > (stepping into std::function

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdedd7b6548f4: Added checking for completeness of lvalue in conditional operator (authored by Aditya-pixel, committed by aaron.ballman). Herald added

[clang] dedd7b6 - Added checking for completeness of lvalue in conditional operator

Author: Aditya Singh Date: 2023-03-27T14:47:08-04:00 New Revision: dedd7b6548f4a37f4f691aa0cd3a709756b7e794 URL: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794 DIFF: https://github.com/llvm/llvm-project/commit/dedd7b6548f4a37f4f691aa0cd3a709756b7e794.diff

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4343 + WhitespaceSensitiveMacros == R.WhitespaceSensitiveMacros && + Macros == R.Macros; } I put a lot of effort into bringing the stuff sorted. And

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. You cannot just enable it on gfx908 which does not have return version of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225121 , @dblaikie wrote: > From the discussion on the issue: > >> Do we want this loosening of the restriction to apply to *only* `std` and >> the same followed by a number, or to any reserved identifier used

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp added inline comments. Comment at: clang/test/SemaCXX/dllexport.cpp:437 +class Base {}; +class __declspec(dllexport) ExportedClass {}; hans wrote: > Is this one used somewhere? It's not. Thanks for finding it. Comment at:

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.html:19 +Function + + sammccall wrote: > gribozavr2 wrote: > > Could you add the file name and line number of the start location of the > > function? > > > > It might be

[clang] ea35740 - [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: ea35740e7e189cdcdd88344ac60a53a5b8a8318d URL: https://github.com/llvm/llvm-project/commit/ea35740e7e189cdcdd88344ac60a53a5b8a8318d DIFF:

[clang] 21750a1 - [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: 21750a1ae8c86ffefc72f115116c80a98a0792dc URL: https://github.com/llvm/llvm-project/commit/21750a1ae8c86ffefc72f115116c80a98a0792dc DIFF:

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21750a1ae8c8: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang). Changed prior to commit:

[clang] d0dd151 - Address code review feedback

Author: Daniel Grumberg Date: 2023-03-27T17:24:10+01:00 New Revision: d0dd151eed4bb9a6ea209790e2727c0a007f699a URL: https://github.com/llvm/llvm-project/commit/d0dd151eed4bb9a6ea209790e2727c0a007f699a DIFF:

[PATCH] D146946: [RISCV][MC] Add support for experimental zicond extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146946/new/ https://reviews.llvm.org/D146946

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb530e1af62be: [LinkerWrapper] Do not extract globals with no offloading language (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508708. VitaNuo added a comment. Remove extra check (already done in walkUsed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files:

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman created this revision. aaron.ballman added reviewers: ChuanqiXu, dblaikie, Mordante, iains. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Any project that wants to `import std;` potentially needs to be able to build a

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. In D146148#4224094 , @aaron.ballman wrote: > In D146148#4222306 , @zahiraam > wrote: > >> In D146148#4221651 , @rjmccall >> wrote: >> >>>

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:171 Builder.defineMacro("__NVPTX__"); - if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice) { + if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice || !HostTarget) { // Set

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

manojgupta added a comment. This is firing even in checked length codes, is that expected? example: https://godbolt.org/z/Todje76ao std::optional result; bool ReadDevice(uint8_t* data, size_t len) { if (!result) return false; memset(data, 0, len); if (len > 0) data[0]

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#4224236 , @firewave wrote: > Some additional thoughts I had a while ago about something I have raised > before: > I think the warnings which can only be fixed with c++14 should either only be > issued if that standard

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID InputType

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. In D137205#4225006 , @Febbe wrote: > Yes, I agree, while I can't understand, why someone still wants to use only > c++11 I can totally understand, that a single Software Engineer can't do > anything about this, when the

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added a subscriber: echristo. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); jhuber6

[PATCH] D144358: [clang][github] Added checking for completeness of lvalue in conditional operator [#59718]

aaron.ballman added a comment. In D144358#4225139 , @Aditya-pixel wrote: > Oh, okay, Ill change the patch now. Also, it seems my local directory is out > of sync. Should I always update it before submitting a patch, or is it > alright without updating

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

aaron.ballman added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added a comment. In D137379#4225000 , @manojgupta wrote: > This is firing even in checked length codes, is that expected? Yes, it is expected. The unsafe buffer analysis is syntax-based. The analysis warns operations that do not follow

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun updated this revision to Diff 508751. alvinhochun added a comment. Trying to fix the test... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146908/new/ https://reviews.llvm.org/D146908 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[clang] 1a35893 - [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

Author: Balázs Kéri Date: 2023-03-27T17:58:32+02:00 New Revision: 1a35893d2a58fdead33ec7daa9f1fe53f4787614 URL: https://github.com/llvm/llvm-project/commit/1a35893d2a58fdead33ec7daa9f1fe53f4787614 DIFF: https://github.com/llvm/llvm-project/commit/1a35893d2a58fdead33ec7daa9f1fe53f4787614.diff

[PATCH] D145479: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a35893d2a58: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D145479?vs=502947=508685#toc

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:34 +// the data into tags embedded in the HTML. (see inflate() in JS). +// +// SELECTION Comment at:

[clang] 9ea912f - [diagtool] explain that yellow is used to denote disabled-by-default warnings

Author: Nick Desaulniers Date: 2023-03-27T09:41:30-07:00 New Revision: 9ea912fe978df3057a74542d9e22d871e2b899dd URL: https://github.com/llvm/llvm-project/commit/9ea912fe978df3057a74542d9e22d871e2b899dd DIFF:

[PATCH] D146827: [diagtool] explain that yellow is used to denote disabled-by-default warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea912fe978d: [diagtool] explain that yellow is used to denote disabled-by-default warnings (authored by nickdesaulniers). Repository: rG LLVM

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

rjmccall added a comment. In D146188#4223249 , @xiongji90 wrote: > Hi, @rjmccall and @sepavloff > In UserManual, we include a section `Controlling Floating Point Behavior`: >

[PATCH] D146975: [NVPTX] Add __CUDA_ARCH__ macro to standalone NVPTX compilations

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:171 Builder.defineMacro("__NVPTX__"); - if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice) { + if (Opts.CUDAIsDevice || Opts.OpenMPIsDevice || !HostTarget) {

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 marked an inline comment as done. jp4a50 added a comment. All actionable comments have been addressed. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

dblaikie added a comment. In D146595#4225132 , @aprantl wrote: > In D146595#4225048 , @dblaikie > wrote: > >> I know this is a bit of a redirection/scope creep/etc - but I'd quite like >> to see a solution that

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp updated this revision to Diff 508747. wolfgangp marked an inline comment as done. wolfgangp added a comment. Added 2 test cases that check that dll{ex,im}ported classes that are instantiated with classes with internal linkage as template arguments are not exported or imported. Had to

[PATCH] D146973: [Clang] Implicitly include LLVM libc headers for the GPU

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1230 + llvm::sys::path::append(P, "llvm-libc"); + CmdArgs.push_back("-c-isystem"); + CmdArgs.push_back(Args.MakeArgString(P)); sivachandra wrote: > jhuber6 wrote: > > tra

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

bjope added a comment. In D126959#4222854 , @iains wrote: > In D126959#4222637 , @bjope wrote: > >> This seem to case problems when building with asan enabled >> (LLVM_USE_SANITIZER='Address'): > >

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146449/new/ https://reviews.llvm.org/D146449 ___

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1563 + + assert(PreviousBitfield->isBitField()); + probinson wrote: > Is this true for cases like > ``` > struct nonadjacent { > char a : 8; > char : 0; > int b; > char d :

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 508539. 4vtomat added a comment. Herald added subscribers: jobnoorman, luke. Updated to spec version 20230206. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files:

[PATCH] D146644: [documentation]Fixed Random Typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG4071dcf3549f: [documentation] Fix Typos (authored by ipriyanshi1708, committed by samtebbs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder added a comment. Ping. Please prioritize this patch over the other interpreter patches since the others depend on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 ___ cfe-commits mailing

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. This refactoring helps share code between Clang and Flang. Please wait a couple of days before submitting. Additional notes in support of approval: -> The llvm

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

aaron.ballman accepted this revision. aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto = AST.getTokens(); -auto SpelledForExpanded = -

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508586. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Use spelling locations for macro arguments, and expansion locations for everything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 added a comment. Yes, I am OK with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508543. SBallantyne marked an inline comment as done. SBallantyne added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet created this revision. kadircet added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Instead of

[PATCH] D146942: PowerPC ABI incompatibility with GNU on complex arguments

umesh.kalappa0 created this revision. umesh.kalappa0 added a reviewer: nikic. umesh.kalappa0 added projects: LLVM, clang. Herald added subscribers: StephenFan, shchenz, nemanjai. Herald added a project: All. umesh.kalappa0 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

aaron.ballman added a comment. (Btw, if you no longer plan to work on a patch, it's considered good form to "abandon" the patch in Phabricator. You can do this by clicking the Add Action drop-down menu and selecting Abandon Changes.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. @PiotrZSL thanks for the quick response. I've tried to work on the `Field` test case but seem to have hit a roadblock. From what I can see the `FunctionProtoType` exception specificaion is `EST_Unevaluated` which causes it to give up because of the check on Line 41. I'm

  1   2   3   >