[PATCH] D147989: Fix Attribute Placememt

ipriyanshi1708 updated this revision to Diff 512343. ipriyanshi1708 added a comment. Removed extra lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases ccotter wrote: > ccotter wrote: > > PiotrZSL wrote: > > > what about when

[clang-tools-extra] cebdf20 - [clang-tidy] Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2023-04-10T23:33:47-07:00 New Revision: cebdf206caad921ab4b1d231d90e42ed60d5998e URL: https://github.com/llvm/llvm-project/commit/cebdf206caad921ab4b1d231d90e42ed60d5998e DIFF: https://github.com/llvm/llvm-project/commit/cebdf206caad921ab4b1d231d90e42ed60d5998e.diff

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Yes I didn’t see them repeated below CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, just some style comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:84-86 + Str.append(ND->getName()); +} else +

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added a comment. arc land should work, I usually use arc patch --nobranch to check things before committing and then git push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d20e329690: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks… (authored by dougpuob, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 65d20e3 - [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

Author: Douglas Chen Date: 2023-04-11T06:43:07Z New Revision: 65d20e3296909169405f9286d2a2177a42789e06 URL: https://github.com/llvm/llvm-project/commit/65d20e3296909169405f9286d2a2177a42789e06 DIFF: https://github.com/llvm/llvm-project/commit/65d20e3296909169405f9286d2a2177a42789e06.diff LOG:

[PATCH] D147969: Add InsertBraces to ChromiumStyle

MyDeveloperDay added a comment. RFC https://groups.google.com/g/llvm-dev/c/wka1Bnrd-aU?pli=1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147969/new/ https://reviews.llvm.org/D147969 ___ cfe-commits

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL accepted this revision. PiotrZSL added a comment. Any plans in delivering this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 ___ cfe-commits

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512344. ipriyanshi1708 retitled this revision from "Fix Attribute Placememt" to "[clang] Fix Attribute Placement". ipriyanshi1708 added a comment. Updated the title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 added a comment. In D147876#4257197 , @carlosgalvezp wrote: > In D147876#4256182 , @njames93 > wrote: > >> with checked in configuration files > > I'm not sure I understand what you mean by "checked

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512349. ipriyanshi1708 edited the summary of this revision. ipriyanshi1708 added a comment. Updated the summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added reviewers: mboehme, aaron.ballman. samtebbs added a comment. Looping in some people who have worked on and reviewed patches in this area for some experienced eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:138 APIRecord(RecordKind Kind, StringRef USR, StringRef Name, -PresumedLoc Location, AvailabilitySet Availabilities, +PresumedLoc Location, const AvailabilitySet ,

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257721 , @aaron.ballman wrote: > Thank you for working on this! > > The changes are missing test coverage; please be sure to add that, along with > a release note about the fix. I think there's likely more

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. This commit eliminates crashes caused by a rare corner case (typedefs to types derived from unnamed structs) of the AST import procedure; but introduces some incorrect behavior in a

[PATCH] D148006: [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To ensure that we have a pointee for the

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman added a comment. Thank you for working on this! The changes are missing test coverage; please be sure to add that, along with a release note about the fix. I think there's likely more work to be done here as well, considering this behavior: https://godbolt.org/z/sdK3Gef75 (notice

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4249527 , @zequanwu wrote: > - Add a `-use-target-path-separator` flag for llc. > - Add test for llc with that flag. But where does `TM.Options.ObjectFilenameForDebug` come from? Presumably it comes from Clang at some

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

gribozavr2 added a comment. In D147698#4257698 , @mboehme wrote: > @gribozavr2 Just to make sure I understand you correctly here (before I make > any changes to the code): IIUC you recommend simply doing nothing on a delete > expression? (Your

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske updated this revision to Diff 512425. balazske added a comment. Fixed documentation issues. Check is added to list.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138777/new/ https://reviews.llvm.org/D138777 Files:

[PATCH] D147836: [clang] Add test for CWG1822

This revision was automatically updated to reflect the committed changes. Closed by commit rG86946ebb796c: [clang] Add test for CWG1822 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147836/new/ https://reviews.llvm.org/D147836

[clang] 86946eb - [clang] Add test for CWG1822

Author: Vlad Serebrennikov Date: 2023-04-11T11:08:22+03:00 New Revision: 86946ebb796c4ccde85b34aa52964e9aadabc692 URL: https://github.com/llvm/llvm-project/commit/86946ebb796c4ccde85b34aa52964e9aadabc692 DIFF:

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512365. Endill added a comment. Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary template instantiation (presumably to find overloaded unary `&`), and make Clang compliant since 3.4 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147848: [clang] Add test for CWG2370

Endill added a comment. Bug report filed: https://github.com/llvm/llvm-project/issues/62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848 ___ cfe-commits

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:4 // RUN: %clang_cc1 -fexperimental-strict-floating-point -ffp-exception-behavior=strict -triple %itanium_abi_triple -emit-llvm %s -o - -fms-extensions -DMS | FileCheck

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512388. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c

[PATCH] D147978: [RISCV] Remove getCPUFeaturesExceptStdExt.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147978/new/ https://reviews.llvm.org/D147978 ___

[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding the codegen code owners for their approval, but in general I think this is a good idea. Comment at: clang/lib/CodeGen/ABIInfoImpl.h:33-52 +bool isAggregateTypeForABI(QualType T); +

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added subscribers: aprantl, dblaikie. Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/no_unique_address/main.cpp:38 + long v = 42; +} _f3; + I haven't checked the reworked logic yet, but it still crashes on this: ```

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

mboehme added a comment. @gribozavr2 Just to make sure I understand you correctly here (before I make any changes to the code): IIUC you recommend simply doing nothing on a delete expression? (Your arguments for this make sense to me, just want to double-check I understood correctly.)

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak updated this revision to Diff 512399. skatrak added a comment. Address reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147941/new/ https://reviews.llvm.org/D147941 Files: clang/include/clang/Driver/Options.td

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

skatrak marked 4 inline comments as done. skatrak added a comment. In D147941#4255622 , @awarzynski wrote: > In the context of LLVM, I would normally associate "pass" with something > else. I'm not that familiar with offloading, so perhaps that's the

[PATCH] D147989: [clang] Fix Attribute Placement

mboehme added a comment. In D147989#4257539 , @samtebbs wrote: > Looping in some people who have worked on and reviewed patches in this area > for some experienced eyes. Nothing else to add beyond what @aaron.ballman has noted. Thanks for working on

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

BeMg added a comment. test_nontemporal_load_v16i8 test_nontemporal_load_v8i16 These two test cases in nontemporal.ll are affected by `areTwoSDNodeTargetMMOFlagsMergeable`. Does we need extra testcases for `areTwoSDNodeTargetMMOFlagsMergeable`? Repository: rG LLVM Github Monorepo

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. I think I haven't stressed it enough, but this whole test is copied from dr244, which is written by Richard. Comment at: clang/test/CXX/drs/dr3xx.cpp:1492 +// This is technically ill-formed; G is looked up in 'N::' and is not found. +//

[PATCH] D148004: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG991c7e11728f: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 991c7e1 - [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

Author: Martin Braenne Date: 2023-04-11T11:31:56Z New Revision: 991c7e11728f6f6372e5dc865e3a4c0636a575ea URL: https://github.com/llvm/llvm-project/commit/991c7e11728f6f6372e5dc865e3a4c0636a575ea DIFF: https://github.com/llvm/llvm-project/commit/991c7e11728f6f6372e5dc865e3a4c0636a575ea.diff

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems;

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512421. ipriyanshi1708 added a comment. Removed the spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added a comment. Thanks for the input Aaron and Martin. This is looking good. With the suggested changes (don't forget the test, you could try adding one to clang/test/Sema/attr-declspec-ignored.c and clang/test/SemaCXX/attr-declspec-ignored.cpp) and some formatting

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 512381. koops added a comment. Moving the code to SemaOpenMP.cpp from CodeGen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder marked an inline comment as done. tbaeder added a comment. Wow, in `FixIt/fixits-function-call`, this output: ./array.cpp:123:3: error: no matching function for call to 'f1' f1(a + 1); ^~ ./array.cpp:114:6: note: candidate function not viable: no known conversion from

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

Szelethus accepted this revision. Szelethus added a comment. LGTM! Most of the diagnostic messages are short but precise. I like this very much. Well done! Balázs actually tested the change on open source projects, but accidentally uploaded it to our internal server, so I have seen them, and

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 512377. sammccall marked an inline comment as done. sammccall added a comment. use llvm::printHTMLEscaped Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files:

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:77 + +void escape(char C, llvm::raw_ostream ) { + switch (C) { xazax.hun wrote: > We already sort of have a way to escape HTML here: >

[PATCH] D148004: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. Herald added a subscriber: bviyer. ping for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___ cfe-commits mailing

[PATCH] D147935: [RISCV] Add SiFive extension support

asb added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:465 RVV_REQ_FullMultiply = 1 << 1, + RVV_REQ_xsfvcp = 1 << 2, Nit: It would better match the surrounding capitalisation to call this RVV_REQ_Xsfvcp Repository:

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa added a comment. In D143813#4256969 , @ahatanak wrote: > I think this patch is causing the assertion in > `CodeGenFunction::setAddrOfLocalVar` to fail when the following code is > compiled: > > void foo(unsigned long long t) { >

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

mboehme updated this revision to Diff 512434. mboehme added a comment. Eliminate specific handling of delete expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147698/new/ https://reviews.llvm.org/D147698 Files:

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512437. ipriyanshi1708 added a comment. Added the Release note for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files:

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 2 inline comments as done. jrmolin added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1380 + Example uses + ``AlwaysBreakAfterReturnType`` set to ``All``. + MyDeveloperDay wrote: > This isn't relevant is it?

[PATCH] D147989: [clang] Fix Attribute Placement

tbaeder added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3424 "attribute %0 is ignored, place it after " - "\"%select{class|struct|interface|union|enum}1\" to apply attribute to " + "\"%select{class|struct|interface|union|enum|enum

[PATCH] D147909: [clang] Implement CWG 2397

Endill added a comment. Agree, this test clearly belongs to `clang/test/CXX/drs/dr23xx.cpp`. There is a `clang/www/make_cxx_dr_status` script to update cxx_dr_status page, so you don't have to edit it manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4257797 , @hans wrote: > In D147256#4249527 , @zequanwu > wrote: > >> - Add a `-use-target-path-separator` flag for llc. >> - Add test for llc with that flag. > > But where

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 512488. krzysz00 added a comment. Rebase, since we have addrspace 128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258396 , @aaron.ballman wrote: > In D147073#4258384 , @hans wrote: > >> Again not an expert here, but lgtm. >> >> (Nit: the >>

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin updated this revision to Diff 512505. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258529 , @aaron.ballman wrote: > In D147073#4258426 , @zequanwu > wrote: > >> In D147073#4258396 , >> @aaron.ballman wrote: >>

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2404 break; +case RawComment::RCK_Invalid: + // FIXME: are there other scenarios that could produce an invalid I don't get why we don't have to handle the other `RawComment` cases

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512532. Leporacanthicus added a comment. Rebase only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td

[PATCH] D148035: [clang] Add test for CWG1837

Endill updated this revision to Diff 512538. Endill added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148035/new/ https://reviews.llvm.org/D148035 Files: clang/test/CXX/drs/dr18xx.cpp clang/www/cxx_dr_status.html

[PATCH] D148035: [clang] Add test for CWG1837

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems right based on the paper listed/standardeeze. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148035/new/

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:19975 +llvm::Type *ResTy = ConvertType(E->getType()); +ConstantInt *Mode = llvm::cast(Ops[1]); + Is `llvm::` needed on the `cast`? I think cast is imported into the clang

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258664 , @zequanwu wrote: > In D147073#4258529 , @aaron.ballman > wrote: > >> In D147073#4258426 , @zequanwu >> wrote: >> >>>

[clang] a4beece - [clang] Add test for CWG2007

Author: Vlad Serebrennikov Date: 2023-04-11T22:13:43+03:00 New Revision: a4beecef8f40ad0d42f61e7c495acb2d2d819b10 URL: https://github.com/llvm/llvm-project/commit/a4beecef8f40ad0d42f61e7c495acb2d2d819b10 DIFF:

[PATCH] D147839: [clang] Add test for CWG2007

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4beecef8f40: [clang] Add test for CWG2007 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:844 "};"); - ASSERT_EQ(Tokens.size(), 44u); + ASSERT_EQ(Tokens.size(), 44u) << Tokens; EXPECT_TOKEN(Tokens[13], tok::kw_requires, TT_RequiresClause);

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes seem reasonable to me. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() <

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Sorry, we cannot do this. See https://reviews.llvm.org/D147983#4259132 I added --[no-]relax-gp to GNU ld master branch recently, which isn't in a released binutils version yet.

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4259197 , @erichkeane wrote: > has this had an RFC btw? I don't believe I've seen one, and this looks like > we probably need one. It has not had an RFC. It's almost a direct copy of AArch64's implementation,

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147660/new/ https://reviews.llvm.org/D147660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 512521. argentite marked 3 inline comments as done. argentite added a comment. Combined IncrementalCompilerBuilder and IncrementalCudaCompilerBuilder Added --cuda-path support Use sys::fs::createTemporaryFile() instead of hardcoding the path Other minor

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite added inline comments. Comment at: clang/lib/Interpreter/Offload.cpp:90-91 + PTXCode += '\0'; + while (PTXCode.size() % 8) +PTXCode += '\0'; + return PTXCode.str(); Hahnfeld wrote: > Is padding to 8 bytes a requirement for PTX? Maybe add a

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. So I don't see any handling of the dependent version of this, we probably need tests for those at minimum. Comment at: clang/docs/ReleaseNotes.rst:355 +- Added ``attribute(riscv_rvv_vector_bits(__RISCV_RVV_VLEN_BITS))`` to allow + the size of a

[PATCH] D147969: Add InsertBraces to ChromiumStyle

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) MyDeveloperDay wrote: > This is an code

[clang] aa7aedd - [clang] Add test for CWG1837

Author: Vlad Serebrennikov Date: 2023-04-11T22:15:11+03:00 New Revision: aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec URL: https://github.com/llvm/llvm-project/commit/aa7aedd8ea3f75ddfb3004b81f09c5f653bc8fec DIFF:

[PATCH] D148035: [clang] Add test for CWG1837

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7aedd8ea3f: [clang] Add test for CWG1837 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:122 +StringRef Text = getRawText(SourceMgr); +if (Text.size() < 6 || Text[0] != '/') + return false; Just to double-check, we don't have to worry about there

[clang-tools-extra] 32aaacc - [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

Author: Congcong Cai Date: 2023-04-11T21:28:11+02:00 New Revision: 32aaacc609e7a0523d498b244e081ac6f3df532b URL: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b DIFF: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b.diff

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG32aaacc609e7: [clang-tidy] support nested inline namespace in c++20 for modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon created this revision. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D147969: Add InsertBraces to ChromiumStyle

aaron.ballman added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) HazardyKnusperkeks wrote: > MyDeveloperDay

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix pointers, Add more tests, consider free standing value extraction functions like boost::get Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/

[PATCH] D147969: Add InsertBraces to ChromiumStyle

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) aaron.ballman wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147572/new/ https://reviews.llvm.org/D147572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:11390 +ResType = llvm::ScalableVectorType::get( +llvm::Type::getIntNTy(getVMContext(), XLen), 64 / XLen); +break; erichkeane wrote: > craig.topper wrote: > > erichkeane

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: aaron.ballman. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > Despite a couple of FIXME in CWG244 test (out of

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

ahatanak added a comment. In D143813#4257943 , @jonpa wrote: > I don't understand the first argument - I thought it was supposed to be just > an address... It's a statement expression. https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html The value

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

shafik added a comment. Do we have a test that covers valid doxygen comments? I was looking and I don't see an obvious one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

paulkirth created this revision. paulkirth added reviewers: phosek, mcgrathr, jrtc27, craig.topper, aaron.ballman. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project:

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin added a comment. In D148029#4258800 , @shafik wrote: > Do we have a test that covers valid doxygen comments? I was looking and I > don't see an obvious one. AFAICT, some in `CommentTextTest.cpp` - not that many though.

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

jrtc27 added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} Does this really belong in an MC patch? Comment at:

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4258419 , @zequanwu wrote: > In D147256#4257797 , @hans wrote: > >> In D147256#4249527 , @zequanwu >> wrote: >> >>> - Add a

[PATCH] D147946: [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512541. HerrCai0907 added a comment. update acc. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147946/new/ https://reviews.llvm.org/D147946 Files:

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512543. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147839/new/ https://reviews.llvm.org/D147839 Files: clang/test/CXX/drs/dr20xx.cpp clang/www/cxx_dr_status.html Index:

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 512559. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Add fixes, add suport for std:move, fixed operator*() calls, added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147839: [clang] Add test for CWG2007

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you again for all the effort in documenting these and adding tests, it is much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >