[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

efriedma created this revision. efriedma added reviewers: serge-sans-paille, aaron.ballman. Herald added a subscriber: dschuff. Herald added a project: All. efriedma requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. Back when the command-line

[clang] d2627cf - [clang-format] Add the KeepEmptyLinesAtEOF option

Author: Owen Pan Date: 2023-06-07T14:17:58-07:00 New Revision: d2627cf88d2553a4c2e850430bdb908a4b7d2e52 URL: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52 DIFF: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52.diff

[PATCH] D152305: [clang-format] Add the KeepEmptyLinesAtEOF option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152305/new/

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. In D149162#4404271 , @agozillon wrote: > I have hopefully fixed the sanitizer issue (the incorrect assert, thank you > again for the catch) with the following patch: >

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529446. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529447. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529444. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These two tests were pretty challenging to manage by hand, and in rebasing the next change in my stack I finally ran out of

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. durin42 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This allows us to remove most of the special knowledge

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: tra. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. alexander-shaposhnikov requested review of this

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. Are there any other comments on this patch? I would love to make this into clang-17! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___ cfe-commits mailing list

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Just realized this is probably going to be a bit more painful. the attribute propagation pass requires a `CodeGenModule` which isn't built without an `ASTContext` so it's not available here. Nothing those functions do explicitly requires the full `CGM`, they only use

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: MaskRay. For programs that don't use RTTI, the rtti component is just

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. We intend to build a deep learning model with code as input, then noticed clang does not currently have a convenient way of dumping tokens in huge projects. The dumped tokens are supposed to be converted to vectors, then given to a deep learning model.

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:14427 SDValue Callee = CLI.Callee; + bool IsCFICall = CLI.CB && CLI.CB->isIndirectCall() && CLI.CFIType; bool = CLI.IsTailCall; If `CLI.CFIType != 0`, is

[PATCH] D152285: Add support for the NO_COLOR environment variable

arichardson added a comment. >>> [...] I don't know what compelling use case there is for forcing colors >>> *on*, [...] until we know why users need to force-enable colors. >> >> The reason is that adding `-fcolor-diagnostics` to the command line is not >> always feasible, e.g. most build

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 529485. felix642 added a comment. Improved documentation Removed duplicated messages in tests. Added support for regular expressions Added method to store options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152415: [RISCV] Add test cases to show that rvv_vectreo-bits attributes is not accepted for vbool or LMUL!=1 RVV types. NFC

craig.topper created this revision. craig.topper added a reviewer: aaron.ballman. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

rupprecht added a comment. In D150226#4401188 , @jyknight wrote: > In D150226#4400782 , @rupprecht > wrote: > >> As a general question/feature request: is there a way to have specific >> warnings apply even for

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } tra wrote: > Should it be `AuxTI &&

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 529494. kushanam added a comment. rebasing and readding the first commit changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files:

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. In D152416#4404862 , @Anarion-zuo wrote: > I see that plugin is a more elegant way of doing this. Do you still want this > as a part of LLVM? No, I don't feel this is needed. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu abandoned this revision. Yunzezhu added a comment. In D151867#4401987 , @craig.topper wrote: > In D151867#4401952 , @Yunzezhu > wrote: > >> In D151867#4400255

[PATCH] D152250: [Clang][RISCV] Add test cases for intrinsics clz/ctz codegen when has extension zbb/xtheadbb

Yunzezhu abandoned this revision. Yunzezhu added a comment. Abandon this revision because https://reviews.llvm.org/D151867 is abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152250/new/ https://reviews.llvm.org/D152250

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 529491. akshaykhadse added a comment. Rename test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c

[PATCH] D152418: [clang] set python3 as required build dependency

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/ https://reviews.llvm.org/D152418

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. I see that plugin is a more elegant way of doing this. Do you still want this as a part of LLVM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/ https://reviews.llvm.org/D152416

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 updated this revision to Diff 529490. jhuber6 added a comment. Updating, in order to do this starting with bitcode I had to expose a helper that performs this operation using the options directly rather than through the `CodeGenModule`. This should keep the existing interfaces intact by

[PATCH] D152418: [clang] set python3 as required build dependency

Avimitin created this revision. Avimitin added reviewers: gribozavr, aaron.ballman, phosek. Herald added a project: All. Avimitin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The required HTMLLogger include file needs python3 to run

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay added a comment. Thanks for the description. The code generally looks good. If the kernel wants a specific code sequence, implementing conditions in the LLVMCodeGen looks good to me. Consider adding a link to the discussion. I wonder whether it will be more useful to give more context

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } zyounan wrote: > nridge wrote: > > zyounan wrote: > > >

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. What is the intended use case of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/ https://reviews.llvm.org/D152416 ___ cfe-commits mailing list

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. I think such requirement should be done by something like a plugin or an analysis tool by using clang as a library instead of implementing it in clang compiler itself directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/test/SemaCUDA/neon-attrs.cu:2 +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon -x cuda -fsyntax-only -DNO_DIAG -verify %s +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature -neon -x cuda

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

sameerds added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( vikramRH wrote: >

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Another argument for not having generated file in-tree. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo created this revision. Herald added a project: All. Anarion-zuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152416 Files:

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. It's my first time here. I don't know if I got everything right. CodeOwners.rst says you guys are relevant somewhat. Thanks! @ChuanqiXu @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( arsenm wrote: >

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

mcgrathr added a comment. It's not clear from the change description if this can be enabled orthogonally to relative-vtables. I think it should be possible to choose each switch independently, thus generating 4 variants of the vtable layout ABI. Does any runtime code (libc++abi) ever need to

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Scratch that, `ASTContext::getFunctionFeatureMap` is used. I wonder if we could forgo that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. In D149162#4404379 , @fmayer wrote: > In D149162#4404271 , @agozillon > wrote: > >> I have hopefully fixed the sanitizer issue (the incorrect assert, thank you >> again for the catch)

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404596 , @mcgrathr wrote: > It's not clear from the change description if this can be enabled > orthogonally to relative-vtables. I think it should be possible to choose > each switch independently, thus

[clang] e3f91ac - Fix namespace of operator<< defn

Author: Sam McCall Date: 2023-06-08T01:36:59+02:00 New Revision: e3f91acad38e6637f1589bb4b33e9c4b8b58581f URL: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f DIFF: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f.diff

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

dblaikie added a comment. https://github.com/llvm/llvm-project/issues/63169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 ___ cfe-commits mailing list

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } Should it be `AuxTI && (AuxTI->getTriple().isAArch64() ||

[clang] 94e7546 - Revert "[clang-format] Fix overlapping replacements before PPDirectives"

Author: Leonard Chan Date: 2023-06-07T23:44:32Z New Revision: 94e75469597f197f9c4b45baa6c8a576c78dbd02 URL: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02 DIFF: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02.diff LOG:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( vikramRH wrote: >

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

thakis added a comment. Looks like the revert broke tests: http://45.33.8.238/linux/109159/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

dwang created this revision. Herald added a project: All. dwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152412 Files: clang/test/CodeGen/lifetime3.cpp Index:

[clang] 9f00eb9 - Revert "Revert "[clang-format] Fix overlapping replacements before PPDirectives""

Author: Leonard Chan Date: 2023-06-08T00:15:30Z New Revision: 9f00eb99759b62c4a81ce84d686b212e46ec7452 URL: https://github.com/llvm/llvm-project/commit/9f00eb99759b62c4a81ce84d686b212e46ec7452 DIFF: https://github.com/llvm/llvm-project/commit/9f00eb99759b62c4a81ce84d686b212e46ec7452.diff LOG:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

mcgrathr added a comment. In D152405#4404616 , @leonardchan wrote: > Oh this is completely independent from relative vtables. I'll update the > wording. Great. I'd like to see us try some experiments with enabling both together in places like the

[clang] dc81d2a - [OpenMP] Fix using the target ID when using the new driver

Author: Joseph Huber Date: 2023-06-07T19:17:27-05:00 New Revision: dc81d2a4d5b38a82cdc76c41522e61f0de716904 URL: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904 DIFF: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904.diff

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc81d2a4d5b3: [OpenMP] Fix using the target ID when using the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D150998?vs=523924=529476#toc Repository: rG LLVM

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. > Can we extend the test cases to exercise both with and without > relative-vtables also enabled? Yup, the cases here already test with the regular itanium c++ abi and relative vtables abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. This needs a lit test. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:92-97 + StringRef Linker = + Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER); + if (Linker.empty() || Linker.equals_insensitive("lld")) +Linker =

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 529201. goldstein.w.n added a comment. Add header comments/license. Use enum for kMaybe, kYes, kNo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files:

[PATCH] D143260: [clangd] Add semantic token for labels

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. alright then, this patch LGTM. going forward let's try to introduce new kinds (or handling for different semantic constructs) in a more holistic manner. concerns with new language structs

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529207. vikramRH added a comment. Further review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://reviews.llvm.org/D151594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:176 + void reportSpecializations(SourceLocation Loc, NamedDecl *ND) { +if (const auto *TD =

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } nridge wrote: > zyounan wrote: > > `PrintCanonicalTypes` turns on

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added a comment. In D150843#4401189 , @tahonermann wrote: > The summary states that the changes are not quite NFC. In that case, we would > ideally have a test that demonstrates the changed behavior. Would adding such > a test be challenging?

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 22e95e0 - [clang] Fix assertion while parsing an invalid for loop

Author: Corentin Jabot Date: 2023-06-07T10:31:11+02:00 New Revision: 22e95e0bf375660dd3d083b16a5d92c33559a4a3 URL: https://github.com/llvm/llvm-project/commit/22e95e0bf375660dd3d083b16a5d92c33559a4a3 DIFF:

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG22e95e0bf375: [clang] Fix assertion while parsing an invalid for loop (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152009?vs=529186=529212#toc Repository: rG LLVM

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder updated this revision to Diff 529170. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin updated this revision to Diff 529186. cor3ntin added a comment. Add tests for missing semi colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152009/new/ https://reviews.llvm.org/D152009 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This will fix unused-include false positive. // primary.h namespace ns { template class Z {}; // primary

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 529174. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files:

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei added a comment. In D152318#4402234 , @mstorsjo wrote: > FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. > While it does match a GNU binutils tool, I'm kinda curious where it is needed. llvm-strings exists in the

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 529171. codemzs marked 4 inline comments as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Hi @tahonermann, Thank you for your insights on the patch. I concur with your perspective about the potential

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

mstorsjo added a comment. FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. While it does match a GNU binutils tool, I'm kinda curious where it is needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152318/new/

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152345: [include-cleaner] Report all specializations if the primary template is introduced by a using-decl.

hokein updated this revision to Diff 529215. hokein marked 5 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152345/new/ https://reviews.llvm.org/D152345 Files:

[PATCH] D152312: HIP: Use frexp builtins in math headers

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152312/new/ https://reviews.llvm.org/D152312 ___ cfe-commits mailing list

[PATCH] D138396: HIP: Directly call signbit builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138396/new/ https://reviews.llvm.org/D138396 ___ cfe-commits mailing list

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:35 +// INTERNALIZE: attributes #[[ATTR]] = {{.*}} "target-cpu"="gfx{{.*}}" "target-features"="+gfx11-insts" +// NOINTERNALIZE:

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin added a comment. As I told Aaron, someone who disables color for accessibility reason is likely to have both variables(NO_COLOR/CLICOLOR) set. So supporting one is enough. Picking the one that is the simplest and most popular makes perfect sense. This is great. Repository: rG LLVM

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. In D150446#4337657 , @donat.nagy wrote: > After some thinking and discussion with @gamesh411 I decided that it'd be > better to

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4484 + if (!TooManyActiveBits) { +AlignVal = Alignment.getZExtValue(); +// C++11 [dcl.align]p2: So looking more closely, THIS is the problem right here. I think we probably

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Pierre-vh marked 2 inline comments as done. Pierre-vh added inline comments. Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:34 +// CHECK: define {{.*}} i32 @do_intrin_stuff() #[[ATTR:[0-9]+]] +// CHECK: attributes #[[ATTR]] = {{.*}}

[clang] e60b30d - Reland "D144999 [MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs."

Author: Vy Nguyen Date: 2023-06-07T10:03:50-04:00 New Revision: e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc URL: https://github.com/llvm/llvm-project/commit/e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc DIFF: https://github.com/llvm/llvm-project/commit/e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc.diff

[clang] 4418434 - [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

Author: Kristina Bessonova Date: 2023-06-07T16:43:12+02:00 New Revision: 4418434c6de7a861e241ba2448ea4a12080cf08f URL: https://github.com/llvm/llvm-project/commit/4418434c6de7a861e241ba2448ea4a12080cf08f DIFF:

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4418434c6de7: [DebugMetadata] Simplify handling subprograms retainedNodes field. NFCI (1/7) (authored by krisb, committed by dzhidzhoev).

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC added a comment. In D152269#4402593 , @steakhal wrote: > I had some improvement opportunities in mind scattered, so I decided to do > them, and here is how the diff looks for me now: F27853795: > recommendation.patch

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

cor3ntin added a comment. In D146924#4224237 , @tahonermann wrote: >> It's not in the range of any of the universal-character-names. > > I assume you mean that it isn't included in the range of UCNs that are > allowed in identifiers. If so, that is

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1367 + Self.Context.doCXX23ExtendedFpTypesRulesApply(DestType, SrcType)) { +// Support for cast between fp16 and bf16 doesn't exist yet. +if (!((DestType->isBFloat16Type() ||

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Please update the title and the summary of this patch to reflect what it actually achieves. We also usually use the `[analyzer]` tag only for changes touching `StaticAnalyzer` stuff.

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev added a comment. I think this is heading in a good direction. Please find some comments inline. Comment at: clang/docs/ClangRepl.rst:60 + +Clang-Repl-Usage + Comment at:

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH marked 4 inline comments as done. vikramRH added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:137 + +__device__ float f1 = 3.14f; +__device__ double f2 = 2.71828; arsenm wrote: > Also half C++ default arg promotions does

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on the ongoing migration to

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && + LHSBuiltinTy && RHSBuiltinTy && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).EC != I think this

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 529287. Krishna-13-cyber added a comment. - Update with addressing the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109 Files:

  1   2   3   >