[PATCH] D153424: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM, this is a straightforward fix and if the repo can survive three copies of std-compare.h, then it'll also survive four copies. However I created a ticket (in our internal system)

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

DavidSpickett added a comment. > Perhaps "Unrecognized environment for , did you mean > -none-" I like explaining it like this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 ___ cfe-commits mailing

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo Chris' comment, but can you please add a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:628 CanonIncludes.addSystemHeadersMapping(Clang->getLangOpts()); - std::unique_ptr IWYUHandler = - collectIWYUHeaderMaps(); can you also add a FIXME here saying that we

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfa467bdc0e9: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bfa467b - [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-06-22T06:32:28-07:00 New Revision: bfa467bdc0e900dbd44e2b896678d6fb77daacf4 URL: https://github.com/llvm/llvm-project/commit/bfa467bdc0e900dbd44e2b896678d6fb77daacf4 DIFF: https://github.com/llvm/llvm-project/commit/bfa467bdc0e900dbd44e2b896678d6fb77daacf4.diff

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think adding support for ICU would be the better long-term solution since it seems to allow the same behaviour across

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:54 +"ignore-headers", +cl::desc("A comma-separated list of headers to ignore."), +cl::init(""), `A comma-separated list of regexes to match against

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

mboehme added a comment. High-level comment: I like the separation of concerns that this introduces. Would you like me to review https://reviews.llvm.org/D153469 or should we wait for this patch to converge first? Comment at:

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 533641. ymandel marked 2 inline comments as done. ymandel added a comment. responded to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files:

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f1aa87281f: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status. (authored by craig.topper). Changed prior to commit:

[PATCH] D153568: [ClangPackager] Add an option to extract inputs to an archive

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, jdoerfert, tianshilei1992, ronlieb, gregrodgers. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang.

[clang] 08f1aa8 - [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

Author: Craig Topper Date: 2023-06-22T09:22:58-07:00 New Revision: 08f1aa87281f969bb5a46a780385819079067826 URL: https://github.com/llvm/llvm-project/commit/08f1aa87281f969bb5a46a780385819079067826 DIFF: https://github.com/llvm/llvm-project/commit/08f1aa87281f969bb5a46a780385819079067826.diff

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:18583 << Callee << CallerTCB; } } arsenm wrote: > bob80905 wrote: > > I don't believe you intended to remove all this code in your latest update, > > did you? > I

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added a comment. Thank you @aaron.ballman and @Fznamznon for reviewing! I landed this patch with commit d2fafa79ef08f9ef9cd0108a6caa7fc61a31bdeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2fafa79ef08: [NFC] Fix potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/

[PATCH] D143241: [Clang] Reset FP options before function instantiations

rjmccall added a comment. Hmm. Why are we clearing the FP pragma stack instead of saving the old context onto it and then restoring after instantiation? I don't think semantic analysis ever depends on enclosing members of the stack, does it? Clearing the entire stack might not matter much if

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc3b4acbc92: [clang] Add a namespace for interesting identifiers. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I'd like to ask, is there a reason why there isn't a test for these new builtins under SemaCXX/builtins_elementwise_math.cpp? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

tahonermann accepted this revision. tahonermann added a comment. > is it ok to land this patch? No objection from me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. Description now needs updating since this diff no longer adds all the split out pieces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +inline

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper added a comment. The mulx function being 32-bit mode only is also true in gcc. It probably won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit only? But it should still be functionally correct. CHANGES SINCE LAST ACTION

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

rjmccall added a comment. Does https://reviews.llvm.org/D143241 solve the original problem here, or is there something deeper? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152818/new/ https://reviews.llvm.org/D152818

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. Can someone land for me? thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing list

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. The static analysis results look suspect since there does not appear to be a way for `Log2_32` to return a value larger than 31. Regardless, the change looks safe to me;

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: sunshaoce, arphaman, guansong, yaxunl. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. jyu2 requested review of this

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

paulwalker-arm updated this revision to Diff 533629. paulwalker-arm added a comment. Moved C++ test into CodeGenCXX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153560/new/ https://reviews.llvm.org/D153560 Files:

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. >selects the fallback GCC toolchain driver; did you mean > This is a correct description of the current behaviour, but I want to keep the freedom to change the behaviour in future. Therefore I'd like to avoid defining what behaviour an invalid target

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. > Would you like me to review https://reviews.llvm.org/D153469 or should we > wait for this patch to converge first? Similarly it'd be great to get high-level feedback there: whether the design of FormulaBoolValue is right, whether the changes to use Atom/Formula

[PATCH] D152858: OpenMP: Use generated checks and pragma declare target

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152858/new/ https://reviews.llvm.org/D152858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152857: OpenMP: Don't use target regions in library function test

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152857/new/ https://reviews.llvm.org/D152857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d2fafa7 - [NFC] Fix potential dereferencing of nullptr.

Author: Sindhu Chittireddy Date: 2023-06-22T09:53:28-07:00 New Revision: d2fafa79ef08f9ef9cd0108a6caa7fc61a31bdeb URL: https://github.com/llvm/llvm-project/commit/d2fafa79ef08f9ef9cd0108a6caa7fc61a31bdeb DIFF:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 533674. ychen marked 7 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1987 + void setDeductionCandidateKind(DeductionCandidateKind K) { +FunctionDeclBits.DeductionCandidateKind = static_cast(K); } shafik wrote: > aaron.ballman wrote: > > Er, seems a

[clang] 9fc3b4a - [clang] Add a namespace for interesting identifiers.

Author: Zahira Ammarguellat Date: 2023-06-22T13:24:00-04:00 New Revision: 9fc3b4acbc920dc93f4b6eefb4e2b3f795fa9aac URL: https://github.com/llvm/llvm-project/commit/9fc3b4acbc920dc93f4b6eefb4e2b3f795fa9aac DIFF:

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan added a comment. In D153418#4441603 , @efriedma wrote: > Even if we do decide we have to use platform-specific facilities because > there's no suitable library, I think we should at least have a hardcoded set > of encodings we

[PATCH] D153576: [Headers] Fix up some conditionals

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153576/new/ https://reviews.llvm.org/D153576 ___ cfe-commits mailing list

[PATCH] D153576: [Headers] Fix up some conditionals

probinson closed this revision. probinson added a comment. Committed [[here|https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df]] and closing manually because I forgot to put the review link in the commit message. CHANGES SINCE LAST ACTION

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 533619. TIFitis added a comment. Moved device clause emition after if clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files:

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb81c5070d545: [flang] add -flang-experimental-polymorphism flag to flang-new (authored by DavidTruby). Changed prior to commit:

[clang] b81c507 - [flang] add -flang-experimental-polymorphism flag to flang-new

Author: David Truby Date: 2023-06-22T16:21:09+01:00 New Revision: b81c5070d5451af127b2c9c2ae362ba1b0a96c01 URL: https://github.com/llvm/llvm-project/commit/b81c5070d5451af127b2c9c2ae362ba1b0a96c01 DIFF: https://github.com/llvm/llvm-project/commit/b81c5070d5451af127b2c9c2ae362ba1b0a96c01.diff

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc49fbd2df7d: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM (authored by stuij). Changed prior to commit:

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added a comment. In D152435#4433147 , @OikawaKirie wrote: > BTW, what does the `Done` checkbox mean in the code comments? "Done" means "Resolved" on GitHub - which is basically that some action was taken or the person who raised the issue

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel marked 2 inline comments as not done. ymandel added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) xazax.hun wrote: > Is it possible we end up adding the same

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3571-3585 + // Don't make replacements that replace nothing. This can affect e.g. the + // output of clang-format with the --output-replacements-xml option. +

[PATCH] D152746: [C++20][Modules] Complete implementation of module.import p7.

iains updated this revision to Diff 533656. iains added a comment. rebased and fixed some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152746/new/ https://reviews.llvm.org/D152746 Files: clang/include/clang/Basic/Module.h

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CollectMacros.cpp:37 Out.Names.insert(Name); - auto Range = halfOpenToRange( - SM,

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw updated this revision to Diff 533617. sstwcw added a comment. - limit change to Verilog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152623/new/ https://reviews.llvm.org/D152623 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw added a comment. > So I assume your `'` is a 'DictLiteral`? The brace following the quote is a `DictLiteral`. The quote is a `tok::identifier` and `TT_Unknown`. > Does it have to be one? The brace is set to this type when used this way in all other languages. I don't want to make an

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533623. HaohaiWen added a comment. Remove CoreOption for dumpdir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

paulwalker-arm updated this revision to Diff 533631. paulwalker-arm added a comment. Renamed test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153560/new/ https://reviews.llvm.org/D153560 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533640. dgoldman added a comment. Disable renaming categories Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 533694. kushanam added a comment. Updating the bf16 conversion arc requirements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a subscriber: ChuanqiXu. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add ExtractAPI

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

paulwalker-arm created this revision. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/63223 Repository: rG LLVM Github Monorepo

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks updated this revision to Diff 533627. aeubanks marked an inline comment as done. aeubanks added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153468/new/ https://reviews.llvm.org/D153468 Files:

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks added inline comments. Comment at: clang/test/CodeGen/verify-each.c:5 +// RUN: %clang_cc1 -O2 -o /dev/null -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s -fdebug-pass-manager 2>&1 | FileCheck %s --check-prefix=NO +// NO-NOT: Verifying + tejohnson

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. In D153294#4437381 , @Fznamznon wrote: > In fact, I can't come up with the test that this patch would break. Either > `ExprWithCleanups` is redundant or added by different parts of Sema. Same here, maybe @rsmith can come

[PATCH] D153418: Adding iconv support to CharSetConverter class

efriedma added a comment. Even if we do decide we have to use platform-specific facilities because there's no suitable library, I think we should at least have a hardcoded set of encodings we recognize, so we aren't passing arbitrary encoding names directly from the command-line to the iconv()

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

craig.topper added a comment. In D153170#4441462 , @jrtc27 wrote: > Can we have an expensive check that the table is sorted? Yeah. I was going to do it when I made use of the sorted property, but it makes more sense to be in this patch. I'll probably

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare abandoned this revision. gedare added a comment. I don't like the approach I took. It will be hard (impossible) to tune a default return penalty that ensures backward compatibility. The only way I see to make this work is to add an option to enable breaks after the return keyword. This

[clang] 3db8410 - [Headers] Fix up some conditionals

Author: Paul Robinson Date: 2023-06-22T11:21:16-07:00 New Revision: 3db8410487ce704f02ef8a175e87295d4e86c8df URL: https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df DIFF: https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df.diff

[PATCH] D153576: [Headers] Fix up some conditionals

probinson added a comment. The Intel documentation doesn't hint that `_mulx_32` isn't available in 64-bit mode. I'm guessing gcc messed up and we copied them. CHANGES SINCE LAST

[PATCH] D153510: [Clang] Check type support for local variable declaration

eopXD added a comment. In D153510#4440784 , @aaron.ballman wrote: > This checking already happens when the declaration is actually *used*, so I > question whether we need to do the check at all (declared but unused > variables seem like an edge case

[PATCH] D145302: [clangd] Add library for clangd main function

kadircet added a comment. thanks LG and seems to be working in a couple build configurations I tried. but there might still be breakages in different configs, so please be on the watchout after landing this for breakages in https://lab.llvm.org/. FWIW something like: # Needed by LLVM's

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

jrtc27 added a comment. Can we have an expensive check that the table is sorted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153170/new/ https://reviews.llvm.org/D153170 ___ cfe-commits mailing list

[PATCH] D153510: [Clang] Check type support for local variable declaration

craig.topper added a comment. @aaron.ballman The backend crashes at -O0 when scalable vector variables are declared because the stack frame code doesn't expect to see them when the vector extension isn't enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153510: [Clang] Check type support for local variable declaration

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8773 + + checkTypeSupport(T, NewVD->getLocation(), cast(CurContext)); } This feels heavy handed for not RISC-V vector types. Can we put the RISC-V code from checkTypeSupport in a

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

peter.smith added a comment. > clang: warning: mismatch between architecture and environment in target > triple 'aarch64-none-eabi'; did you mean 'aarch64-none-elf'? > [-Winvalid-command-line-argument] That looks good to me. Would be happy with that. Repository: rG LLVM Github Monorepo

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

craig.topper updated this revision to Diff 533678. craig.topper added a comment. Verify the table is sorted. This uses the same pattern we use to check sorted tables in other places like X86InstrFMA3Info.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140294: clang: Replace implementation of __builtin_isnormal

arsenm abandoned this revision. arsenm added a comment. Herald added a subscriber: StephenFan. Obsoleted by D112932 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140294/new/ https://reviews.llvm.org/D140294

[PATCH] D153576: [Headers] Fix up some conditionals

probinson created this revision. probinson added reviewers: craig.topper, RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. While looking at adding intrinsic function descriptions, I found some oddities in the conditionals. I've fiddled

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. These changes look fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

asb added a comment. OK, if this patch is going to verify the table is sorted then SupportedExtensions and SupportedExperimentalExtensions probably deserve a comment to explicitly note they must be kept in sort order. Otherwise, still LGTM. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

emosy added a comment. Is this tool abandoned? Are maintainers still open to adding this tool? I am interested in it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765

[clang] e4a93d8 - [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

Author: Craig Topper Date: 2023-06-22T11:25:47-07:00 New Revision: e4a93d80f425114e4d943ba176b34590c8d0fece URL: https://github.com/llvm/llvm-project/commit/e4a93d80f425114e4d943ba176b34590c8d0fece DIFF: https://github.com/llvm/llvm-project/commit/e4a93d80f425114e4d943ba176b34590c8d0fece.diff

[PATCH] D153170: [RISCV] Sort the extensions in SupportedExtensions and SupportedExperimentalExtensions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4a93d80f425: [RISCV] Sort the extensions in SupportedExtensions and… (authored by craig.topper). Changed prior to commit:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4438815 , @dblaikie wrote: > I haven't looked closely at this, but from a vague/quick reading, it sounds > like this is creating annotations on certain type DINodes, but then moving > them around to different types?

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153468/new/ https://reviews.llvm.org/D153468

[clang] da7f212 - [clang][LTO] Add flag to run verifier after every pass

Author: Arthur Eubanks Date: 2023-06-22T08:51:29-07:00 New Revision: da7f212f4a7ac8d99c9368770b9af3b628fd4e9f URL: https://github.com/llvm/llvm-project/commit/da7f212f4a7ac8d99c9368770b9af3b628fd4e9f DIFF:

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda7f212f4a7a: [clang][LTO] Add flag to run verifier after every pass (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 533668. garvitgupta08 added a comment. Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153370/new/ https://reviews.llvm.org/D153370 Files: llvm/docs/RISCVUsage.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:18583 << Callee << CallerTCB; } } arsenm wrote: > arsenm wrote: > > bob80905 wrote: > > > I don't believe you intended to remove all this code in your latest > > >

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D153424: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

balazske added inline comments. Comment at: clang/test/ASTMerge/cxx-rewritten-binary-operator/Inputs/std-compare.h:307 + +#endif // STD_COMPARE_H I do not like to add this file but could not find a better solution. The file is copied from other test, this file

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

peter.smith added a comment. I can confirm that we have seen several users of the LLVM Embedded Toolchain for Arm that work on both AArch64 and Arm make this mistake as it is easy to just alter an example triple by substituting the first element. Given that this is a warning, invalid is

[clang-tools-extra] 3889c82 - [clang-tidy][NFC] Add missing argument comment to LexerUtils.cpp

Author: Piotr Zegar Date: 2023-06-22T09:12:40Z New Revision: 3889c8214d1b4fcaa54f18b0944faa026f97b8ba URL: https://github.com/llvm/llvm-project/commit/3889c8214d1b4fcaa54f18b0944faa026f97b8ba DIFF: https://github.com/llvm/llvm-project/commit/3889c8214d1b4fcaa54f18b0944faa026f97b8ba.diff LOG:

[PATCH] D153510: [Clang] Check type support for local variable declaration

aaron.ballman added a comment. This checking already happens when the declaration is actually *used*, so I question whether we need to do the check at all (declared but unused variables seem like an edge case to me): https://godbolt.org/z/e4Y8qKMrW What is the behavior of the example I linked

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim added a comment. In D152788#4439714 , @shafik wrote: > Thank you for this improvement! Well, it would still be nice to have the instantiation trace, as Aaron suggested. So that is probably one of those "exercise for the reader" things. :D

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

jan-wassenberg added a comment. Thanks for your quick reply. Yes, we are tracking trunk with a short lag, and unfortunately this is mostly beyond our control. Now that I have updated the Highway code and toolchain reference in user code, we are fine for the moment. Please do update the

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains added subscribers: clang-modules, h-vetinari. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna marked an inline comment as done. Manna added a comment. ping @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >