[PATCH] D154123: [HIP] Start document HIP support by clang

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG795e934e15b7: [HIP] Start document HIP support by clang (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] a03f73c - Fix the Clang sphinx bot

Author: Aaron Ballman Date: 2023-07-25T11:23:36-04:00 New Revision: a03f73c3368dfa782bd6eadcd086cced190ef02a URL: https://github.com/llvm/llvm-project/commit/a03f73c3368dfa782bd6eadcd086cced190ef02a DIFF: https://github.com/llvm/llvm-project/commit/a03f73c3368dfa782bd6eadcd086cced190ef02a.diff

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:308 def : DiagGroup<"c++98-c++11-c++14-c++17-compat", [CXXPre20Compat]>; +def CXXPre20CompatCoroutines :

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fde372b3200: [Headers][doc] Add description of _mm256_movemask_epi8 (authored by probinson). Herald added a project: clang. Repository: rG LLVM

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL updated this revision to Diff 544034. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156161/new/ https://reviews.llvm.org/D156161 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 3 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1463 + if (object::Archive::getDefaultKindForHost() == object::Archive::K_AIXBIG) { +// If not specify -X option, get BitMode from enviorment variable

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 544055. yonghong-song added a comment. - Add more tests in assembler-disassembler-v4.s and gotol.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL updated this revision to Diff 544057. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 Files:

[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

SeanP updated this revision to Diff 544067. SeanP added a comment. remove extra blank line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155234/new/ https://reviews.llvm.org/D155234 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/builtins.h clang/lib/Headers/float.h

[PATCH] D156156: [clang] Implement constexpr evaluation for `__builtin_{add,sub}c`

aaron.ballman added a comment. Thank you for this! The code changes themselves look good to me, but there's a few minor things left to do. You should also update the documentation somewhere near

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 543982. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just exit instead. Fixes https://github.com/llvm/llvm-project/issues/42535 Repository: rG LLVM Github Monorepo

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

This revision was automatically updated to reflect the committed changes. Closed by commit rG3397dae69e09: [clang-tidy] Add performance-enum-size check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144135?vs=543196=544042#toc Repository: rG LLVM Github Monorepo

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit this on your behalf? (If you plan to do more patches, I'm also happy to let you ask for commit privileges

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl closed this revision. yaxunl added a comment. committed by 19d3b37196553372e963bd70718bba1b0bfc94ee CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. lgtm with nits Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1298 + CurrentProgramInfo.DynamicCallStack ? "True" : "False"; +

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

arsenm added a comment. In D156040#4526036 , @JonChesterfield wrote: > What's the use case I'm missing which makes this flag necessary/beneficial? The metadata is also irrelevant to this patch which is just reporting optimization hint information

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet added a comment. In D154366#4530536 , @dblaikie wrote: > @hazohelet can you commit this yourself, or do you need someone to commit it > on your behalf? (& if so, what name/email address would you like to be > credited) Thanks for the review.

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); It feels a bit weird that we are succeeding in finding the best viable function and what we find is invalid.

[clang] 1fde372 - [Headers][doc] Add description of _mm256_movemask_epi8

Author: Paul Robinson Date: 2023-07-25T10:00:13-07:00 New Revision: 1fde372b320015f22e24b67c41c7028974a4a223 URL: https://github.com/llvm/llvm-project/commit/1fde372b320015f22e24b67c41c7028974a4a223 DIFF: https://github.com/llvm/llvm-project/commit/1fde372b320015f22e24b67c41c7028974a4a223.diff

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

dkrupp added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2469-2472 + // User csa_mark_sanitize function is for the analyzer only + #ifdef __clang_analyzer__ +void csa_mark_sanitized(const void *); + #endif steakhal wrote: > I was

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

crobeck updated this revision to Diff 544049. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156040/new/ https://reviews.llvm.org/D156040 Files: clang/test/Frontend/amdgcn-machine-analysis-remarks.cl llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp

[PATCH] D156254: [clang][dataflow] Add convenience function for analysing and `FunctionDecl` and diagnosing it.

ymandel created this revision. ymandel added reviewers: xazax.hun, mboehme. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The convenience function captures running the

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

jcranmer-intel added a comment. In D155546#4510691 , @aaron.ballman wrote: > It's not yet clear to me what happens when any of these functions encounter a > signaling NaN at compile time. CC @hubert.reinterpretcast @jcranmer-intel > @rsmith

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN:

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

MitalAshok added a comment. Instead of checking for hard-coded names, you can check functions with the format(printf, x, y) attribute: if (auto *Format = FD->getAttr()) CheckPrintfPointerConversionSpecifierNULL(C, CE,

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

aaron.ballman added a comment. In D155546#4521383 , @tbaeder wrote: > In D155546#4510691 , @aaron.ballman > wrote: > >> I'd like to see test coverage for treatment of NaNs. According to the C23 >> standard, a

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4530916 , @wangpc wrote: > In D112921#4529182 , @Mordante > wrote: > >> I noticed some of the CI jobs are still failing with the patch, I didn't >> look into them. > > I

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

MitalAshok updated this revision to Diff 544046. MitalAshok added a comment. Rebase changelog to clang 18, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156064/new/ https://reviews.llvm.org/D156064 Files:

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added a comment. In D154568#4528274 , @efwright wrote: > Dropping off a simple test case. If this looks about what you would expect > for the tests I have a couple more involved ones that I can repurpose and add > in. For more complex tests

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2570 // CHECK_SRF_M64: #define __AVXNECONVERT__ 1 +// CHECK_ARLS_M64: #define __AVXVNNIINT16__ 1 // CHECK_SRF_M64: #define __AVXVNNIINT8__ 1 Do the CHECK_SRF_M64-NOT

[clang] 212d6aa - Revert "[LoongArch] Support -march=native and -mtune="

Author: Weining Lu Date: 2023-07-25T23:32:15+08:00 New Revision: 212d6aa0daa079dc0ca009a46f4993f05b008c0c URL: https://github.com/llvm/llvm-project/commit/212d6aa0daa079dc0ca009a46f4993f05b008c0c DIFF: https://github.com/llvm/llvm-project/commit/212d6aa0daa079dc0ca009a46f4993f05b008c0c.diff

[clang] e178824 - [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

Author: Yaxun (Sam) Liu Date: 2023-07-25T12:01:41-04:00 New Revision: e17882430e5c243c7244dadcd0a6b5cce2219386 URL: https://github.com/llvm/llvm-project/commit/e17882430e5c243c7244dadcd0a6b5cce2219386 DIFF:

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rGe17882430e5c: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals` (authored by yaxunl). Herald added

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7228 + } else { +Args.ClaimAllArgs(options::OPT_fgpu_approx_transcendentals); +Args.ClaimAllArgs(options::OPT_fno_gpu_approx_transcendentals); MaskRay wrote: > You can use

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

aaron.ballman added a comment. I think the changes make sense and generally look good, but because this is intended as a performance improvement, I'd like some measurements to prove it actually does improve performance. That then gives us something good to talk about in a release note as well.

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > Fznamznon wrote: > > shafik wrote: > > > shafik wrote: > > > > It feels a bit weird that we

[PATCH] D156219: [WIP] __builtin_amdgcn_read_exec_* should be implemented with llvm.amdgcn.ballot

ranapratap55 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17496-17497 +CallInst *CI = +cast(EmitAMDGCNBallotForExec(*this, E, Int64Ty, Int64Ty)); CI->setConvergent(); return CI; arsenm wrote: > Don't need the cast or

[PATCH] D156255: [clang-tidy] Update unchecked-optiona-access-check to use convenience function for diagnosing `FunctionDecl`s.

ymandel created this revision. ymandel added reviewers: xazax.hun, mboehme. Herald added subscribers: PiotrZSL, ChuanqiXu, carlosgalvezp. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. ymandel requested review of this revision. Herald added projects:

[clang] 795e934 - [HIP] Start document HIP support by clang

Author: Yaxun (Sam) Liu Date: 2023-07-25T09:36:58-04:00 New Revision: 795e934e15b7f74fc5f5dd88e3aac36c8cac4765 URL: https://github.com/llvm/llvm-project/commit/795e934e15b7f74fc5f5dd88e3aac36c8cac4765 DIFF:

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

jacek added a comment. `-fno-autoimport` sounds good to me. For linker implications, using `--disable-auto-import` in this case would seem consistent to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://reviews.llvm.org/D61670

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG! Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234 + if (!LT || !RT || !T) +return this->bail(BO); tbaeder wrote: >

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2010-2013 +OS << "R\"EFLPM(" + << PredefinedExpr::ComputeName(getPredefinedExprKind(Tok.getKind()), + currentDecl) + << ")EFLPM\"";

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

cor3ntin added a comment. I think getting a smaller reproducer would be useful indeed before talking about conformance, even though i think there is indeed something wrong there - an incomplete parameter should not be able to produce a valid call. Repository: rG LLVM Github Monorepo

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

aaron.ballman added a comment. In D155955#4528792 , @efriedma wrote: >> Note sure what you mean. Making sure we use size_t for all array extents is >> not something that can be fixed overnight but more importantly, it does not >> help: Would it not

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

aaron.ballman added a comment. In D155955#4532433 , @cor3ntin wrote: > In D155955#4532385 , @aaron.ballman > wrote: > >> In D155955#4528792 , @efriedma >> wrote: >>

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

sammccall added a comment. (ping - also happy to send this to someone else if you prefer!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155819/new/ https://reviews.llvm.org/D155819 ___ cfe-commits

[clang] d9832ef - Concatenate uses of isa<> into one call; NFC

Author: Aaron Ballman Date: 2023-07-25T12:30:24-04:00 New Revision: d9832ef815f529a0b912baa14e1b3e23af99bc86 URL: https://github.com/llvm/llvm-project/commit/d9832ef815f529a0b912baa14e1b3e23af99bc86 DIFF: https://github.com/llvm/llvm-project/commit/d9832ef815f529a0b912baa14e1b3e23af99bc86.diff

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1442 + +// -X option in ranlib do not accept "any" +if (BitMode == BitModeTy::Unknown || BitMode == BitModeTy::Any)

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

aaron.ballman added a comment. In D155356#4513303 , @tbaeder wrote: > One thing I'm wondering though is: > > constexpr char A[] = {'1', '2', '3'}; > constexpr double d = __builtin_nans(A); > > what's expected here? The given char array is not

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:237 static bool Verbose = false; ///< 'v' modifier -static bool Symtab = true;///< 's' modifier +static WriteSymTabType Symtab =

[PATCH] D155816: [Tooling/Inclusion] Make the Recognizer work for C99 code.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe93cbd18c112: [Tooling/Inclusion] Make the Recognizer work for C99 code. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e93cbd1 - [Tooling/Inclusion] Make the Recognizer work for C99 code.

Author: Haojian Wu Date: 2023-07-25T15:48:21+02:00 New Revision: e93cbd18c11281465246060d6c2a9ea1deae3360 URL: https://github.com/llvm/llvm-project/commit/e93cbd18c11281465246060d6c2a9ea1deae3360 DIFF: https://github.com/llvm/llvm-project/commit/e93cbd18c11281465246060d6c2a9ea1deae3360.diff

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1240 + // Fields + for (const Record::Field : R->fields()) { +const Descriptor *D = Field.Desc; It looks like you're not initializing base classes or padding bits:

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

philnik added a comment. In D152003#4531732 , @aaron.ballman wrote: > In D152003#4531404 , @Fznamznon > wrote: > >>> should we try to land that today? >> >> I'm not sure. It causes failures in libc++ testing:

[clang-tools-extra] 0478ef2 - [clangd] Exclude builtin headers from system include extraction

Author: Sam McCall Date: 2023-07-25T18:19:37+02:00 New Revision: 0478ef2d366c6f88678e37d54190dcdaa0ec69da URL: https://github.com/llvm/llvm-project/commit/0478ef2d366c6f88678e37d54190dcdaa0ec69da DIFF: https://github.com/llvm/llvm-project/commit/0478ef2d366c6f88678e37d54190dcdaa0ec69da.diff

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

This revision was automatically updated to reflect the committed changes. Closed by commit rG0478ef2d366c: [clangd] Exclude builtin headers from system include extraction (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin added a comment. In D155955#4532385 , @aaron.ballman wrote: > In D155955#4528792 , @efriedma > wrote: > >>> Note sure what you mean. Making sure we use size_t for all array extents is >>> not

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added a comment. I know this is a little late and we should have thought about it before cutting Clang 17 release. The plan is to cherry-pick this change into Clang 17 after it lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); Fznamznon wrote: > shafik wrote: > > shafik wrote: > > > It feels a bit weird that we are succeeding in finding

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

cor3ntin added a comment. We usually reserve these warnings for feature backported to older c++ standards, and I'm not sure "you are using a standard feature" is in general a useful warning. however, if there are important unresolved issues, why did we set `__cpp_impl_coroutine` ?

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156248/new/ https://reviews.llvm.org/D156248 ___ cfe-commits mailing list

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 544073. MitalAshok added a comment. Target clang 18 instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054/new/ https://reviews.llvm.org/D156054 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added a reviewer: efriedma. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/FPOptions.def:29 OPTION(Float16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) OPTION(BFloat16ExcessPrecision,

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

cor3ntin created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The attributes changes were left out of

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1387 +// with the source range that is being replaced using fix-its. Especially when +// we often cannot obtain accruate source ranges of cv-qualified type +// specifiers. typo:

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. Responded to comment. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking that casing differs. +// If

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

eddyz87 accepted this revision. eddyz87 added a comment. Hi Yonghong, Looks good to me, thanks! Before landing this, could you please adjust tests a little bit more? - Extend `assembler-disassembler-v4.s` with signed `div` and `mod`, e.g.: // CHECK: 3f 31 01 00 00 00 00 00 r1 s/= r3 //

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining added inline comments. Comment at: clang/docs/ReleaseNotes.rst:138-143 +- Patchable function entry (``-fpatchable-function-entry``) is now supported + on LoongArch. +- Unaligned memory accesses can be toggled by ``-m[no-]unaligned-access`` or the + aliases

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang 17 will land with unaddressed coroutine bugs, see -

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Missed one from the list of functions I was asked to document. This really should be the last review!)

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > It feels a bit weird that we are succeeding in finding the best viable > function and what we

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); Fznamznon wrote: > Fznamznon wrote: > > shafik wrote: > > > Fznamznon wrote: > > > > shafik wrote: > > >

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

MitalAshok added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); Does this handle padding bits correctly? E.g.,

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list

[clang-tools-extra] 3397dae - [clang-tidy] Add performance-enum-size check

Author: Piotr Zegar Date: 2023-07-25T17:50:19Z New Revision: 3397dae69e09d33301a7620171cabc301d1f3abb URL: https://github.com/llvm/llvm-project/commit/3397dae69e09d33301a7620171cabc301d1f3abb DIFF: https://github.com/llvm/llvm-project/commit/3397dae69e09d33301a7620171cabc301d1f3abb.diff LOG:

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > aaron.ballman wrote: > > Fznamznon wrote: > > > Fznamznon wrote: > > > > shafik wrote: >

[clang-tools-extra] b530eee - [clang-tidy] Add --enable-module-headers-parsing option

Author: Piotr Zegar Date: 2023-07-25T18:31:17Z New Revision: b530eeea5e7697d58af2adac66c8b86c79e649bb URL: https://github.com/llvm/llvm-project/commit/b530eeea5e7697d58af2adac66c8b86c79e649bb DIFF: https://github.com/llvm/llvm-project/commit/b530eeea5e7697d58af2adac66c8b86c79e649bb.diff LOG:

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb530eeea5e76: [clang-tidy] Add --enable-module-headers-parsing option (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 544066. DiggerLin marked an inline comment as done. DiggerLin added a comment. addressed partial comment, after deciding whether to delete the `bool NeedSymbols parameter` from functions API,(writeArchiveToStream etc), I will upload a update patch.

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155707/new/ https://reviews.llvm.org/D155707 ___ cfe-commits mailing list

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Mordante added a comment. In D152003#4531404 , @Fznamznon wrote: >> should we try to land that today? > > I'm not sure. It causes failures in libc++ testing: > > Failed Tests (3): > llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

crobeck added a subscriber: carlo.bertolli. crobeck added a comment. > The openmp runtime needs to do the same if not being done already. Should be on @carlo.bertolli's TODO list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156040/new/

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > It feels a bit weird that we are succeeding in finding the best viable > function and what

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); Fznamznon wrote: > shafik wrote: > > Fznamznon wrote: > > > shafik wrote: > > > > shafik wrote: > > > > > It

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); aaron.ballman wrote: > Fznamznon wrote: > > Fznamznon wrote: > > > shafik wrote: > > > > Fznamznon wrote: > > >

[clang] 08a2207 - Reapply "[OpenMP] Add the `ompx_attribute` clause for target directives"

Author: Johannes Doerfert Date: 2023-07-25T10:40:35-07:00 New Revision: 08a220764b1e266c4694f614fd4fda7bd2122580 URL: https://github.com/llvm/llvm-project/commit/08a220764b1e266c4694f614fd4fda7bd2122580 DIFF:

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/reference-to-constructed-temporary.rst:10 +This construction is often the result of multiple code refactorings or a lack +of developer

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:113 + static Boolean bitcastFromMemory(const std::byte *Buff) { +bool Val = static_cast(*Buff); +return Boolean(Val); MitalAshok wrote: > Does this handle padding bits correctly?

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

ziqingluo-90 added a comment. This is a lot of work, thank you @t-rasmud & @NoQ ! I have a minor suggestion: can we use some macros to make the debug stub even shorter? The prefix `"failed to produce fixit for declaration"` is used in many places so probably we do not have to repeat it

[clang] 1b162fa - [Support] Change SetVector's default template parameter to SmallVector<*, 0>

Author: Fangrui Song Date: 2023-07-25T13:13:35-07:00 New Revision: 1b162fabe8fa07b6758fe2bce51f0dc19dd6e265 URL: https://github.com/llvm/llvm-project/commit/1b162fabe8fa07b6758fe2bce51f0dc19dd6e265 DIFF: https://github.com/llvm/llvm-project/commit/1b162fabe8fa07b6758fe2bce51f0dc19dd6e265.diff

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 544088. RIscRIpt added a comment. Removed irrelevant changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1981 + // parsed yet). + assert(getLangOpts().MicrosoftExt); + I think I should remove this assertion so this function would be usable without MS ext, on the other hand it would be a noop

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

rnk added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3095 + StringRef CallOpName = CallOpFn->getName(); + std::string ImplName = ("__impl" + CallOpName).str(); + akhuang wrote: > rnk wrote: > > akhuang wrote: > > > The old code tried to find

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

NoQ accepted this revision. NoQ added a comment. LGTM, thanks!! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1095-1102 // Gadgets "claim" variables they're responsible for. Once this loop finishes, // the tracker will only track DREs that weren't claimed by any

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1981 + // parsed yet). + assert(getLangOpts().MicrosoftExt); + RIscRIpt wrote: > I think I should remove this assertion so this function would be usable > without MS ext, on the other

[clang] 15a484b - [clang][ConstExprEmitter] handle IntegerLiterals

Author: Nick Desaulniers Date: 2023-07-25T14:12:50-07:00 New Revision: 15a484bf6990c5c3b759f5bbf99055612c20b924 URL: https://github.com/llvm/llvm-project/commit/15a484bf6990c5c3b759f5bbf99055612c20b924 DIFF:

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang updated this revision to Diff 544101. akhuang added a comment. add TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154007/new/ https://reviews.llvm.org/D154007 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

  1   2   3   4   >