[clang-tools-extra] 840a968 - [clang-tools-extra] Use range-based for loops (NFC)

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T12:12:16-07:00 New Revision: 840a968226c2c6db792d7c1661dfb8a354ff3ebf URL: https://github.com/llvm/llvm-project/commit/840a968226c2c6db792d7c1661dfb8a354ff3ebf DIFF: https://github.com/llvm/llvm-project/commit/840a968226c2c6db792d7c1661dfb8a354ff3ebf.diff

[PATCH] D159233: [clang-format][NFC] Change duplicate config files to symlinks

2023-09-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan abandoned this revision. owenpan added a comment. It seems that git doesn't recreate symbolic links by default on Windows. (See e.g. `clang/test/Driver/Inputs/CUDA-symlinks/usr/bin/ptxas`.) I'll abandon this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-02 Thread Alexander Smarus via cfe-commits
https://github.com/lxbndr review_requested https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-02 Thread Alexander Smarus via cfe-commits
https://github.com/lxbndr opened https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 review_request_removed https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-09-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/CodeGen/Targets/RISCV.cpp:479 + // 2×XLEN-bit alignment and size at most 2×XLEN bits like `long long`, + // `unsigned long long` and `double` to have 4-bytes alignment. This + // behavior may be changed when

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

2023-09-02 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555604. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Driver/ToolChains/Haiku.h clang/test/Driver/pic.c

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 opened https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

2023-09-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-09-02 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc added a comment. In D70401#4635875 , @koute wrote: > I know that there are still open issues regarding the psABI, but considering > how slow it's been going, couldn't we merge this in anyway and mark it as > experimental and subject to change?

[clang] 5dd9568 - Fix typos in documentation

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T09:32:48-07:00 New Revision: 5dd956871785a5b04903d6da85109c9e1052a8a8 URL: https://github.com/llvm/llvm-project/commit/5dd956871785a5b04903d6da85109c9e1052a8a8 DIFF: https://github.com/llvm/llvm-project/commit/5dd956871785a5b04903d6da85109c9e1052a8a8.diff

[clang] cccdf5b - [StaticAnalyzer] Modernize ObjCLoopChecker (NFC)

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T09:32:38-07:00 New Revision: cccdf5b71d1ccec9155ff6c29a0364c89576a7df URL: https://github.com/llvm/llvm-project/commit/cccdf5b71d1ccec9155ff6c29a0364c89576a7df DIFF: https://github.com/llvm/llvm-project/commit/cccdf5b71d1ccec9155ff6c29a0364c89576a7df.diff

[clang] 5ac7fb4 - [StaticAnalyzer] Modernize GTestChecker (NFC)

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T09:32:41-07:00 New Revision: 5ac7fb45e1750fadf123bcd958b3ffdd3d71027a URL: https://github.com/llvm/llvm-project/commit/5ac7fb45e1750fadf123bcd958b3ffdd3d71027a DIFF: https://github.com/llvm/llvm-project/commit/5ac7fb45e1750fadf123bcd958b3ffdd3d71027a.diff

[clang] 2cdfdfd - [CodeGen] Modernize EHScopeStack::Cleanup::Flags (NFC)

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T09:32:36-07:00 New Revision: 2cdfdfd7b9bc9b4c6c329b1e33b377e24631e9a5 URL: https://github.com/llvm/llvm-project/commit/2cdfdfd7b9bc9b4c6c329b1e33b377e24631e9a5 DIFF: https://github.com/llvm/llvm-project/commit/2cdfdfd7b9bc9b4c6c329b1e33b377e24631e9a5.diff

[clang] 2fa1ad8 - [StaticAnalyzer] Modernize IsObjCTypeParamDependentTypeVisitor (NFC)

2023-09-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-02T09:32:40-07:00 New Revision: 2fa1ad8a022fc6ad88f7948d64d12e4a6cc3e39d URL: https://github.com/llvm/llvm-project/commit/2fa1ad8a022fc6ad88f7948d64d12e4a6cc3e39d DIFF: https://github.com/llvm/llvm-project/commit/2fa1ad8a022fc6ad88f7948d64d12e4a6cc3e39d.diff

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

2023-09-02 Thread David Pagan via Phabricator via cfe-commits
ddpagan abandoned this revision. ddpagan added a comment. Change no longer needed per review/comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157197/new/ https://reviews.llvm.org/D157197 ___ cfe-commits mailing list

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-02 Thread via cfe-commits
https://github.com/philnik777 labeled https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

2023-09-02 Thread Niels Sascha Reedijk via Phabricator via cfe-commits
nielx added a comment. Can confirm this is correct for Haiku. For PIC by default, see our GCC haiku.h . These changes have also been part of our patches for clang

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

2023-09-02 Thread Niels Sascha Reedijk via Phabricator via cfe-commits
nielx accepted this revision. nielx added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390

[clang] 890f11d - [Clang] Realize generic lambda call operators are dependent sooner

2023-09-02 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-02T08:05:49+02:00 New Revision: 890f11d60feffed4207afa58229da7bfaaff276e URL: https://github.com/llvm/llvm-project/commit/890f11d60feffed4207afa58229da7bfaaff276e DIFF:

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 63. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files:

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1761 + getCharAndSize(CurPtr, FirstCodeUnitSize); + const char *CharStart = CurPtr + FirstCodeUnitSize - 1; + const char *UnicodePtr = CharStart; shafik wrote: > Do we need to verify that

[PATCH] D158698: [Clang][M68k] Use `DefineStd` for target-specific macros

2023-09-02 Thread Min-Yih Hsu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230558e444c2: [Clang][M68k] Use `DefineStd` for target-specific macros (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

2023-09-02 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 64. brad added a comment. x86_64 test for TLS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h

[clang] 230558e - [Clang][M68k] Use `DefineStd` for target-specific macros

2023-09-02 Thread Min-Yih Hsu via cfe-commits
Author: Min-Yih Hsu Date: 2023-09-01T23:25:08-07:00 New Revision: 230558e444c2e1af8f34f99e59433a3fb87ed758 URL: https://github.com/llvm/llvm-project/commit/230558e444c2e1af8f34f99e59433a3fb87ed758 DIFF: https://github.com/llvm/llvm-project/commit/230558e444c2e1af8f34f99e59433a3fb87ed758.diff

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-02 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-02 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

2023-09-02 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890f11d60fef: [Clang] Realize generic lambda call operators are dependent sooner (authored by cor3ntin). Changed prior to commit:

[PATCH] D159398: [AArch64][Clang] Disable out-of-line atomics in ffreestanding env

2023-09-02 Thread Vladislav Khmelevsky via Phabricator via cfe-commits
yota9 added a comment. The build failure has nothing to do with the patch and it caused by https://reviews.llvm.org/D140612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159398/new/ https://reviews.llvm.org/D159398

[clang] 6081d33 - Fix indenting after Haiku addition

2023-09-02 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2023-09-02T06:27:36-04:00 New Revision: 6081d3342d0e641b03368c0dc8688c3e9ca3c193 URL: https://github.com/llvm/llvm-project/commit/6081d3342d0e641b03368c0dc8688c3e9ca3c193 DIFF: https://github.com/llvm/llvm-project/commit/6081d3342d0e641b03368c0dc8688c3e9ca3c193.diff

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

2023-09-02 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 77. zyounan marked an inline comment as done. zyounan added a comment. Remove the stray header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[clang-tools-extra] e257c0a - [clang][clangd] Ensure the stack bottom before building AST

2023-09-02 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-09-02T18:53:06+08:00 New Revision: e257c0a9190637e44e292271103a13d70bec4b03 URL: https://github.com/llvm/llvm-project/commit/e257c0a9190637e44e292271103a13d70bec4b03 DIFF: https://github.com/llvm/llvm-project/commit/e257c0a9190637e44e292271103a13d70bec4b03.diff

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

2023-09-02 Thread Younan Zhang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe257c0a91906: [clang][clangd] Ensure the stack bottom before building AST (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158883: [Matrix] Try to emit fmuladd for both vector and matrix types

2023-09-02 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. The newly added test cases in ffp-model.c fail on SystemZ, making CI red: https://lab.llvm.org/buildbot/#/builders/94/builds/16280 The root cause seems to be that by default, the SystemZ back-end targets a machine without SIMD support, and therefore vector return types

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

2023-09-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL opened https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

2023-09-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL labeled https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

2023-09-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

2023-09-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159397: [StaticAnalyzer] Use switch statement in MallocChecker::performKernelMalloc. NFC

2023-09-02 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added reviewers: vabridgers, NoQ. brad added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. brad requested review of this

[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-02 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 561d307 - Hook up Haiku AArch64 and RISCV64 support

2023-09-02 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2023-09-02T03:17:16-04:00 New Revision: 561d3076aa6a3de5ae3afcc1f96630df3943c921 URL: https://github.com/llvm/llvm-project/commit/561d3076aa6a3de5ae3afcc1f96630df3943c921 DIFF: https://github.com/llvm/llvm-project/commit/561d3076aa6a3de5ae3afcc1f96630df3943c921.diff

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

2023-09-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159398: [AArch64][Clang] Disable out-of-line atomics in ffreestanding env

2023-09-02 Thread Vladislav Khmelevsky via Phabricator via cfe-commits
yota9 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. yota9 requested review of this revision. Herald added subscribers: cfe-commits, wangpc, MaskRay. Herald added a project: clang. In freestanding environment we don't want extra dependencies on the