[clang] [clang][dataflow] Treat `BuiltinBitCastExpr` correctly in `PropagateResultObject()`. (PR #88875)

2024-04-17 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/88875 >From 0cacc5bfcd30a909be2695f54c089ce343e476ab Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 16 Apr 2024 11:13:00 + Subject: [PATCH] [clang][dataflow] Treat `BuiltinBitCastExpr` correctly in

[clang] 1bccbe1 - [clang][dataflow] Treat `BuiltinBitCastExpr` correctly in `PropagateResultObject()`. (#88875)

2024-04-17 Thread via cfe-commits
Author: martinboehme Date: 2024-04-17T08:17:56+02:00 New Revision: 1bccbe1f49abc39b9f980cf3f1b171da5541d1a4 URL: https://github.com/llvm/llvm-project/commit/1bccbe1f49abc39b9f980cf3f1b171da5541d1a4 DIFF: https://github.com/llvm/llvm-project/commit/1bccbe1f49abc39b9f980cf3f1b171da5541d1a4.diff

[clang] [clang][dataflow] Treat `BuiltinBitCastExpr` correctly in `PropagateResultObject()`. (PR #88875)

2024-04-17 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/88875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-04-17 Thread Mikhail Goncharov via cfe-commits
metaflow wrote: The problem is still present. I have reverted this chain of commits. https://github.com/llvm/llvm-project/pull/83124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e11b17a - [clang][NFC] Refactor `Sema::CheckedConversionKind`

2024-04-17 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-17T09:51:50+03:00 New Revision: e11b17a4ed90e74147594012207fc35a60515944 URL: https://github.com/llvm/llvm-project/commit/e11b17a4ed90e74147594012207fc35a60515944 DIFF:

[clang] [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (PR #88865)

2024-04-17 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/88865 >From 69f444532a9dd1da4c8018684fbf24edacfc91fd Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 16 Apr 2024 09:52:35 + Subject: [PATCH] [clang][dataflow] Refactor `PropagateResultObject()` with

[clang] [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (PR #88865)

2024-04-17 Thread via cfe-commits
martinboehme wrote: Ready for review. https://github.com/llvm/llvm-project/pull/88865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > > Clang is also mentioned for the diagnostic warnings reference, which mostly > > applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this, and > > I don't know a better solution. > > Do you mean that this PR fixes this, or that you noticed this problem

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I don't know what the policy is for promoting intrinsics from experimental to > first-class or if it's documented anywhere (?), but I would expect this to be > accompanied with an RFC / announcement on Discourse. I don't remember any intrinsic ever making the move out of

[clang] b090569 - [RISCV] Support Zama16b1p0 (#88474)

2024-04-17 Thread via cfe-commits
Author: Jesse Huang Date: 2024-04-17T14:36:27+08:00 New Revision: b090569685699abe4a8031ad442a0f81e373146b URL: https://github.com/llvm/llvm-project/commit/b090569685699abe4a8031ad442a0f81e373146b DIFF: https://github.com/llvm/llvm-project/commit/b090569685699abe4a8031ad442a0f81e373146b.diff

[clang] [llvm] [RISCV] Support Zama16b1p0 (PR #88474)

2024-04-17 Thread via cfe-commits
github-actions[bot] wrote: @jaidTw Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [llvm] [RISCV] Support Zama16b1p0 (PR #88474)

2024-04-17 Thread Jesse Huang via cfe-commits
https://github.com/jaidTw closed https://github.com/llvm/llvm-project/pull/88474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
@@ -18914,13 +18914,13 @@ This is an overloaded intrinsic. :: - declare <2 x double> @llvm.experimental.vector.splice.v2f64(<2 x double> %vec1, <2 x double> %vec2, i32 %imm) - declare @llvm.experimental.vector.splice.nxv4i32( %vec1, %vec2, i32 %imm) +

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
@@ -18779,13 +18779,13 @@ This is an overloaded intrinsic. :: - declare <2 x i8> @llvm.experimental.vector.reverse.v2i8(<2 x i8> %a) - declare @llvm.experimental.vector.reverse.nxv4i32( %a) + declare <2 x i8> @llvm.vector.reverse.v2i8(<2 x i8> %a) +

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-17 Thread Balazs Benics via cfe-commits
steakhal wrote: The `dyn_cast` fix was committed as e096c144921daba59963f15e89d2ca6fb32d3a78. The CDM:CLibrary matching mode is committed right after that as 024281d4d26344f9613b9115ea1fcbdbdba23235. I'll propose the `dyn_cast` patch for backporting, but leave the other.

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-17 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/88536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b851c7f - [clang][dataflow] Support `StmtExpr` in `PropagateResultObject()`. (#88872)

2024-04-17 Thread via cfe-commits
Author: martinboehme Date: 2024-04-17T08:05:43+02:00 New Revision: b851c7f1fc4fd83ea84d565bbdc30fd0d356788c URL: https://github.com/llvm/llvm-project/commit/b851c7f1fc4fd83ea84d565bbdc30fd0d356788c DIFF: https://github.com/llvm/llvm-project/commit/b851c7f1fc4fd83ea84d565bbdc30fd0d356788c.diff

[clang] [clang][dataflow] Support `StmtExpr` in `PropagateResultObject()`. (PR #88872)

2024-04-17 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/88872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d35a643 - Revert "Fix test from #83124 and #88902"

2024-04-17 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-04-17T08:37:21+02:00 New Revision: d35a64363bb851045387717d2ef7d6449b7b547f URL: https://github.com/llvm/llvm-project/commit/d35a64363bb851045387717d2ef7d6449b7b547f DIFF:

[clang] dbda478 - Revert "[Clang][Sema] placement new initializes typedef array with correct size (#88902)"

2024-04-17 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-04-17T08:37:21+02:00 New Revision: dbda478693104f78b142375862d66f3369ad8c78 URL: https://github.com/llvm/llvm-project/commit/dbda478693104f78b142375862d66f3369ad8c78 DIFF:

[clang] dd84d23 - Revert "[Clang][Sema] placement new initializes typedef array with correct size (#83124)"

2024-04-17 Thread Mikhail Goncharov via cfe-commits
Author: Mikhail Goncharov Date: 2024-04-17T08:37:22+02:00 New Revision: dd84d23adc84cc0c3d2b8fb8f0c353279d99d27a URL: https://github.com/llvm/llvm-project/commit/dd84d23adc84cc0c3d2b8fb8f0c353279d99d27a DIFF:

[clang] [clang-rel] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-17 Thread Vassil Vassilev via cfe-commits
@@ -73,7 +74,15 @@ llvm::Error IncrementalExecutor::addModule(PartialTranslationUnit ) { Jit->getMainJITDylib().createResourceTracker(); ResourceTrackers[] = RT; - return Jit->addIRModule(RT, {std::move(PTU.TheModule), TSCtx}); vgvassilev wrote:

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #89036)

2024-04-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (mahtohappy) Changes When in-place new-ing a local variable of an array of trivial type, the generated code calls 'memset' with the correct size of the array, earlier it was generating size (squared of the typedef array + size).

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-04-17 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: There's quite a few failures: https://gist.github.com/ilya-biryukov/380d84dfe53f839f449231eb9a2dd46c The logic that sets up module structure from module maps before starting to load PCMs definitely needs to be reworked (and I'm not sure if it can be in the first place). I

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Nikita Popov via cfe-commits
nikic wrote: > > I don't know what the policy is for promoting intrinsics from experimental > > to first-class or if it's documented anywhere (?), but I would expect this > > to be accompanied with an RFC / announcement on Discourse. > > I don't remember any intrinsic ever making the move out

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
https://github.com/mgabka edited https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
mgabka wrote: I was actually following this patch https://reviews.llvm.org/D127976 which promoted vector.insert/extract and there was no RFC for it. My understanding is that these intrinsics are so heavily used in LLVM now so there is no need to call them experimental, moreover the auto

[clang] [clang-rel] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-17 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev created https://github.com/llvm/llvm-project/pull/89031 Clang's CodeGen is designed to work with a single llvm::Module. In many cases for convenience various CodeGen parts have a reference to the llvm::Module (TheModule or Module) which does not change when a new

[clang] [clang-rel] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vassil Vassilev (vgvassilev) Changes Clang's CodeGen is designed to work with a single llvm::Module. In many cases for convenience various CodeGen parts have a reference to the llvm::Module (TheModule or Module) which does not change

[clang] Fix the double space and double attribute printing of the final keyword. (PR #88600)

2024-04-17 Thread Vassil Vassilev via cfe-commits
@@ -275,13 +278,15 @@ void DeclPrinter::prettyPrintAttributes(const Decl *D, if (Pos != AttrPosAsWritten::Left) Out << ' '; A->printPretty(Out, Policy); + hasPrinted = true; if (Pos == AttrPosAsWritten::Left) Out

[clang] [clang-format] Annotate ampamp after new/delete as BinaryOperator (PR #89033)

2024-04-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #78789. --- Full diff: https://github.com/llvm/llvm-project/pull/89033.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2) - (modified)

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Kruse (Meinersbur) Changes The help text was not updated in #87360. Clang is also mentioned for the diagnostic warnings reference, which mostly applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this, and I don't

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Michael Kruse (Meinersbur) Changes The help text was not updated in #87360. Clang is also mentioned for the diagnostic warnings reference, which mostly applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this, and I

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
@@ -1099,6 +1099,25 @@ static bool upgradeIntrinsicFunction1(Function *F, Function *, return true; } + ID = StringSwitch(Name) + .StartsWith("splice.", Intrinsic::vector_splice) + .StartsWith("reverse.",

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #89036)

2024-04-17 Thread via cfe-commits
https://github.com/mahtohappy created https://github.com/llvm/llvm-project/pull/89036 When in-place new-ing a local variable of an array of trivial type, the generated code calls 'memset' with the correct size of the array, earlier it was generating size (squared of the typedef array + size).

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Clang is also mentioned for the diagnostic warnings reference, which mostly > applies to C/C++/Obj-C, not Fortran. > https://github.com/llvm/llvm-project/pull/81726 already tried to fix this, > and I don't know a better solution. Do you mean that this PR fixes this, or

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-17 Thread Phoebe Wang via cfe-commits
@@ -1,13 +1,22 @@ // RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=return %s | FileCheck %s --check-prefix=RETURN // RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=branch %s | FileCheck %s --check-prefix=BRANCH // RUN: %clang_cc1 -E -triple i386 -dM -o -

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-17 Thread Phoebe Wang via cfe-commits
@@ -1,13 +1,22 @@ // RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=return %s | FileCheck %s --check-prefix=RETURN // RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=branch %s | FileCheck %s --check-prefix=BRANCH // RUN: %clang_cc1 -E -triple i386 -dM -o -

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread Michael Kruse via cfe-commits
Meinersbur wrote: > Do you mean that this PR fixes this, or that you noticed this problem while > working on this? I noticed this when working on the patch, .i.e that https://flang.llvm.org/docs/FlangCommandLineReference.html still mentioned Clang in several places and since it was common, I

[clang] [clang-repl] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-17 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/89031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-rel] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-17 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/89031 >From d396330fd004db50b3808e491cb45847888bb651 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Wed, 17 Apr 2024 07:12:40 + Subject: [PATCH] [clang-repl] Clone the llvm::Modules to avoid invalid

[clang] [clang-repl] Set up executor implicitly to account for init PTUs (PR #84758)

2024-04-17 Thread Vassil Vassilev via cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: @@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); }; // PartialTranslationUnit. inline A::~A() { printf("~A(%d)\n", a); } -// Create one instance with new and delete it. +// Create one instance

[clang] [clang-format] Annotate ampamp after new/delete as BinaryOperator (PR #89033)

2024-04-17 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/89033 Fixes #78789. >From 0e2d91d20a1c318868f2e791d859a047b83f0277 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 17 Apr 2024 00:39:36 -0700 Subject: [PATCH] [clang-format] Annotate ampamp after new/delete as

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. Nice, thank you! LGTM https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-04-17 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > Have you tried changing the behavior of the existing `-fmodule-map-file=` to > load the file after we load module files? If so, what kinds of things do you > see breaking or changing? If we can avoid it, I think it would be better to > only have a single mode here, and

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Cullen Rhodes via cfe-commits
c-rhodes wrote: > I was actually following this patch https://reviews.llvm.org/D127976 which > promoted vector.insert/extract and there was no RFC for it. My understanding > is that these intrinsics are so heavily used in LLVM now so there is no need > to call them experimental, moreover the

[clang] 64c6495 - [clang][NFC] Move `Sema::SkipBodyInfo` into namespace scope

2024-04-17 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-17T09:21:29+03:00 New Revision: 64c649585ca23a0c996d8814d2796cd348441d69 URL: https://github.com/llvm/llvm-project/commit/64c649585ca23a0c996d8814d2796cd348441d69 DIFF:

[clang] [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (PR #88865)

2024-04-17 Thread via cfe-commits
martinboehme wrote: > > It's unfortunate that the enum syntax is so bulky (the need for `Stmt::` > > and the `Class` suffix). > > Once we can use C++20, it could get a bit better thanks to > https://en.cppreference.com/w/cpp/language/enum#Using-enum-declaration. Good point, thanks. > > I'm

[clang] [clang] Handle trivial_abi attribute for Microsoft ABI. (PR #88857)

2024-04-17 Thread Tobias Hieta via cfe-commits
tru wrote: @efriedma-quic are you ok with this change? https://github.com/llvm/llvm-project/pull/88857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parse] Diagnose requires expressions with explicit object parameters (PR #88974)

2024-04-17 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks for spotting that. I think there are further cases that I'm not sure we protect against https://github.com/llvm/llvm-project/pull/88974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Parse] Diagnose requires expressions with explicit object parameters (PR #88974)

2024-04-17 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/88974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parse] Diagnose requires expressions with explicit object parameters (PR #88974)

2024-04-17 Thread via cfe-commits
@@ -0,0 +1,4 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s + +auto x0 = requires (this int) { true; }; // expected-error {{a requires clause cannot have an explicit object parameter}} +auto x1 = requires (int, this int) { true; }; // expected-error {{a requires

[clang] [clang]Treat arguments to builtin type traits as template type arguments (PR #87132)

2024-04-17 Thread via cfe-commits
cor3ntin wrote: @AMP999 Feel free to merge! https://github.com/llvm/llvm-project/pull/87132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-17 Thread Mike Weller via cfe-commits
MikeWeller wrote: FYI I don't have merge privs, not sure if I need to ping anybody. Then again I still see "This workflow requires approval from a maintainer", possibly because this is my first contribution? https://github.com/llvm/llvm-project/pull/88138

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Maciej Gabka via cfe-commits
mgabka wrote: > > vector.revert > > I think should be vector.reverse? Will fix the commit message when merging the PR. https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][SPIR-V] Set AS for the SPIR-V logical triple (PR #88939)

2024-04-17 Thread Nathan Gauër via cfe-commits
Keenuts wrote: Thanks all! Agree with Bogner, let's unblock the tests first. As for the address space for globals, this isn't something we have looked into yet, so I'd be in favor of keeping the same behavior as the SPIRN flavor until we have a reason to diverge (as in "thought about this

[clang] [llvm] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-17 Thread Cullen Rhodes via cfe-commits
c-rhodes wrote: Thanks for patch. We use `interleave2` in MLIR so it'll need updating there as well. I don't know what the policy is for promoting intrinsics from experimental to first-class or if it's documented anywhere (?), but I would expect this to be accompanied with an RFC /

[clang] e096c14 - [analyzer] Fix a security.cert.env.InvalidPtr crash

2024-04-17 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2024-04-17T08:02:49+02:00 New Revision: e096c144921daba59963f15e89d2ca6fb32d3a78 URL: https://github.com/llvm/llvm-project/commit/e096c144921daba59963f15e89d2ca6fb32d3a78 DIFF: https://github.com/llvm/llvm-project/commit/e096c144921daba59963f15e89d2ca6fb32d3a78.diff

[clang] 024281d - [analyzer] Harden security.cert.env.InvalidPtr checker fn matching

2024-04-17 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2024-04-17T08:02:49+02:00 New Revision: 024281d4d26344f9613b9115ea1fcbdbdba23235 URL: https://github.com/llvm/llvm-project/commit/024281d4d26344f9613b9115ea1fcbdbdba23235 DIFF: https://github.com/llvm/llvm-project/commit/024281d4d26344f9613b9115ea1fcbdbdba23235.diff

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-17 Thread Isha Agarwal via cfe-commits
https://github.com/iagarwa updated https://github.com/llvm/llvm-project/pull/88736 >From 821c61fb4905b491176e00ea9ed322aad04c98e3 Mon Sep 17 00:00:00 2001 From: Isha Agarwal Date: Mon, 15 Apr 2024 06:22:34 -0700 Subject: [PATCH 1/2] [X86][test] Added extra cet tests Updated cet test to:

[clang] [llvm] [InstCombine] Add canonicalization of `sitofp` -> `uitofp nneg` (PR #88299)

2024-04-17 Thread Yingwei Zheng via cfe-commits
@@ -1964,11 +1964,25 @@ Instruction *InstCombinerImpl::visitFPToSI(FPToSIInst ) { } Instruction *InstCombinerImpl::visitUIToFP(CastInst ) { - return commonCastTransforms(CI); + if (Instruction *R = commonCastTransforms(CI)) +return R; + if (!CI.hasNonNeg() &&

[clang] Fix the double space and double attribute printing of the final keyword. (PR #88600)

2024-04-17 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/88600 >From 9b2bb9068cbefcfffd0931fbbee46b1a0f536a4f Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 13 Apr 2024 06:39:34 + Subject: [PATCH 1/2] Fix the double space and double attribute printing of

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur ready_for_review https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"], "gcc-install-dir=">, "Note: executables (e.g. ld) used by the compiler are not overridden by the selected GCC installation">; def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>,

[clang] [compiler-rt] [llvm] [FMV] Remove useless features according the latest ACLE spec. (PR #88965)

2024-04-17 Thread Alexandros Lamprineas via cfe-commits
@@ -67,57 +67,42 @@ enum CPUFeatures { FEAT_FP, FEAT_SIMD, FEAT_CRC, - FEAT_SHA1, FEAT_SHA2, FEAT_SHA3, FEAT_AES, - FEAT_PMULL, FEAT_FP16, - FEAT_DIT, FEAT_DPB, FEAT_DPB2, FEAT_JSCVT, FEAT_FCMA, FEAT_RCPC, FEAT_RCPC2, FEAT_FRINTTS, -

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-17 Thread Mike Weller via cfe-commits
@@ -286,6 +286,10 @@ Changes in existing checks check by resolving fix-it overlaps in template code by disregarding implicit instances. +- Improved :doc:`bugprone-forwarding-reference-overload + ` + check to not flag deleted constructors which are unable to hide

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread Michael Kruse via cfe-commits
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"], "gcc-install-dir=">, "Note: executables (e.g. ld) used by the compiler are not overridden by the selected GCC installation">; def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>,

[clang] [llvm] [WIP] Expand variadic functions in IR (PR #89007)

2024-04-17 Thread Jon Chesterfield via cfe-commits
@@ -115,7 +115,13 @@ void AMDGPUABIInfo::computeInfo(CGFunctionInfo ) const { Address AMDGPUABIInfo::EmitVAArg(CodeGenFunction , Address VAListAddr, QualType Ty) const { - llvm_unreachable("AMDGPU does not support varargs"); + const bool

[clang] [llvm] [WIP] Expand variadic functions in IR (PR #89007)

2024-04-17 Thread Jon Chesterfield via cfe-commits
@@ -115,7 +115,13 @@ void AMDGPUABIInfo::computeInfo(CGFunctionInfo ) const { Address AMDGPUABIInfo::EmitVAArg(CodeGenFunction , Address VAListAddr, QualType Ty) const { - llvm_unreachable("AMDGPU does not support varargs"); + const bool

[clang] [clang][NFC] Fix FieldDecl::isUnnamedBitfield() capitalization (PR #89048)

2024-04-17 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-17 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: All good from my side, but asked @sam-mccall or @usx95 to check the context propagation bit as I'm missing context to make sure it's correct. https://github.com/llvm/llvm-project/pull/88381 ___ cfe-commits mailing list

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-17 Thread Ilya Biryukov via cfe-commits
@@ -112,7 +112,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks { // Index outlives TUScheduler (declared first) FIndex(FIndex), // shared_ptr extends lifetime - Stdlib(Stdlib)]() mutable { +

[clang] Revert "Improve stack usage to increase recursive initialization depth" (PR #89006)

2024-04-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Thank you for the revert! https://github.com/llvm/llvm-project/pull/89006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] set declaration invalid earlier to prevent crash in calculating record layout (PR #87173)

2024-04-17 Thread Qizhi Hu via cfe-commits
jcsxky wrote: gently ping. @erichkeane @shafik Any opinions on this pr? https://github.com/llvm/llvm-project/pull/87173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

2024-04-17 Thread Younan Zhang via cfe-commits
zyn0217 wrote: The pre-commit CI is still clogging after a few hours, and I'm opening it for feedback anyway. https://github.com/llvm/llvm-project/pull/89019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [AArch64][SME] Add intrinsics for multi-vector BFCLAMP (PR #88251)

2024-04-17 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/88251 >From fe692284cd248e372302671e094eb9950edb5ee5 Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Wed, 10 Apr 2024 10:20:03 + Subject: [PATCH 1/3] [AArch64][SME] Add intrinsics for multi-vector BFCLAMP ---

[clang] [llvm] [AArch64][SME] Add intrinsics for multi-vector BFCLAMP (PR #88251)

2024-04-17 Thread via cfe-commits
@@ -2148,6 +2148,11 @@ let TargetGuard = "sme2" in { def SVSCLAMP_X4 : SInst<"svclamp[_single_{d}_x4]", "44dd", "csil", MergeNone, "aarch64_sve_sclamp_single_x4", [IsStreaming], []>; def SVUCLAMP_X4 : SInst<"svclamp[_single_{d}_x4]", "44dd", "UcUsUiUl",

[clang] [Clang][Parse] Diagnose requires expressions with explicit object parameters (PR #88974)

2024-04-17 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-04-17 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 8f2e1a2d02227b14dc70fb6898b37b9e0565b296 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 01/24] [clang][MBD] set up module build daemon infrastructure The

[clang] [llvm] [AArch64][SME] Add intrinsics for vector groups ZERO (PR #88114)

2024-04-17 Thread via cfe-commits
@@ -0,0 +1,94 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc -verify-machineinstrs < %s | FileCheck %s + +target triple = "aarch64-linux" + +define void @test_svzero_za64_vg1x2(i32 %slice) #0 {

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-17 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/88666 >From 8d48a0bd1cf15b9cf00bc294912b674b5f94a11c Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 15 Apr 2024 00:36:06 +0800 Subject: [PATCH 1/4] [Clang] Allow the value of unroll count to be zero in '#pragma

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-17 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/88666 >From 8d48a0bd1cf15b9cf00bc294912b674b5f94a11c Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 15 Apr 2024 00:36:06 +0800 Subject: [PATCH 1/4] [Clang] Allow the value of unroll count to be zero in '#pragma

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The docbrief strings already use %Program/GlobalDocumentation.Program which > seems to work and made me think that HelpTextForVariants was actually > unnecessary. Would you like me to introduce DocBriefForVariants? IIRC it was unnessecary for the documentation because

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #89036)

2024-04-17 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/89036 >From 56c2b4f70735a6ef3b80cb8461a88ea51f2d02d7 Mon Sep 17 00:00:00 2001 From: mahtohappy Date: Tue, 16 Apr 2024 17:48:45 +0530 Subject: [PATCH 1/4] [Clang][Sema] placement new initializes typedef array with

[clang] [llvm] [WIP] Expand variadic functions in IR (PR #89007)

2024-04-17 Thread Jon Chesterfield via cfe-commits
@@ -0,0 +1,1056 @@ +//===-- ExpandVariadicsPass.cpp *- C++ -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm] [WIP] Expand variadic functions in IR (PR #89007)

2024-04-17 Thread Jon Chesterfield via cfe-commits
@@ -0,0 +1,1056 @@ +//===-- ExpandVariadicsPass.cpp *- C++ -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

2024-04-17 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/89019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][NFC] Make ConstExprEmitter a ConstStmtVisitor (PR #89041)

2024-04-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/89041 No reason for this to not be one. This gets rid of a few const_casts. >From 2edf794268aa825391a37053bb5908e362ad62a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 17 Apr 2024 11:02:20

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. The changes themselves LGTM, thanks for fixing this. https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #89036)

2024-04-17 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/89036 >From 56c2b4f70735a6ef3b80cb8461a88ea51f2d02d7 Mon Sep 17 00:00:00 2001 From: mahtohappy Date: Tue, 16 Apr 2024 17:48:45 +0530 Subject: [PATCH 1/4] [Clang][Sema] placement new initializes typedef array with

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-17 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I can help you to merge it.  https://github.com/llvm/llvm-project/pull/88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 792d437 - [clang-tidy NFC] Fix a typo in docs for sizeof-expression (#88912)

2024-04-17 Thread via cfe-commits
Author: NagyDonat Date: 2024-04-17T12:52:23+02:00 New Revision: 792d437b56adfb3416daf8105942d4899fb82763 URL: https://github.com/llvm/llvm-project/commit/792d437b56adfb3416daf8105942d4899fb82763 DIFF: https://github.com/llvm/llvm-project/commit/792d437b56adfb3416daf8105942d4899fb82763.diff

[clang-tools-extra] [clang-tidy NFC] Fix a typo in docs for sizeof-expression (PR #88912)

2024-04-17 Thread via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/88912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-17 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/89036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SPIR-V] Always add convervence intrinsics (PR #88918)

2024-04-17 Thread Nathan Gauër via cfe-commits
@@ -1109,6 +1124,10 @@ void CodeGenFunction::EmitForStmt(const ForStmt , llvm::BasicBlock *CondBlock = CondDest.getBlock(); EmitBlock(CondBlock); + if (getTarget().getTriple().isSPIRVLogical()) Keenuts wrote: Changed those for a module-level function

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

2024-04-17 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/89019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parse] Diagnose requires expressions with explicit object parameters (PR #88974)

2024-04-17 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/88974 >From 05e44aedb2acfa2945b7be0217db9f8bb8bf70f5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Apr 2024 15:42:45 -0400 Subject: [PATCH 1/2] [Clang][Parse] Diagnose requires expressions with

[clang] [llvm] [AArch64][SME] Add intrinsics for vector groups ZERO (PR #88114)

2024-04-17 Thread via cfe-commits
@@ -0,0 +1,94 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc -verify-machineinstrs < %s | FileCheck %s + +target triple = "aarch64-linux" + +define void @test_svzero_za64_vg1x2(i32 %slice) #0 {

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-04-17 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue edited https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Allow building with pre-built tools (PR #88922)

2024-04-17 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/88922 >From bff3b97b599e1c9529a95ead9d61f9ecc9cad129 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 16 Apr 2024 15:30:20 +0100 Subject: [PATCH 1/5] [libclc] Convert llvm-spirv to imported executable

  1   2   3   4   5   >