[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

anton-afanasyev added a comment. In D47196#1324540 , @Trass3r wrote: > Is this still in progress? AFAIK, this is abandoned by author now. I'm working on other implementation which is similar but with another angle of view. The implementation projected

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/Parse/ParseAST.cpp:154 if (HaveLexer) { +llvm::TimeTraceScope TimeScope("Frontend", StringRef("")); P.Initialize(); takuto.ikuta wrote: >

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 8 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:33 +switch (C) { +case '"': +case '\\': takuto.ikuta wrote: > Include escape for '/' too. >

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 192268. anton-afanasyev marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 14 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/lib/IR/LegacyPassManager.cpp:1632-1634 + bool profileTime = llvm::TimeTraceProfilerEnabled(); + if (profileTime) +llvm::TimeTraceProfilerBegin("OptFunction",

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 191934. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated following @rnk review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files:

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1448112 , @rnk wrote: > lgtm > > I think this is ready. We can adjust the overloads after the fact. I'd like > to get the feature in so we can make improvements independently. Ok, so I'm to commit this and fix

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL357340: Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing`… (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1449051 , @thakis wrote: > Looks like this landed without tests. Please add tests in a follow-up. > > Also, it looks like the flag is currently a cc1 flag. This should probably be > a CoreOption instead so that

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. In D58675#1449053 , @thakis wrote: > ps: Hooray for landing this, and thanks for the cool feature! Thanks! It's @aras_p accomplishment. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Parse/ParseAST.cpp:154 if (HaveLexer) { +llvm::TimeTraceScope TimeScope("Frontend", StringRef("")); P.Initialize(); takuto.ikuta wrote: >

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 192525. anton-afanasyev marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Fix hashing update: https://reviews.llvm.org/D60404 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev created this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, arphaman, mgrang, hiraditya, mgorny, mehdi_amini. Herald added projects: clang, LLVM. This is the first part of time tracing system, I have splitted them cause this part is mostly written by

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added a comment. Ok, I'm to add tests and reviewers. Comment at: clang/lib/Sema/Sema.cpp:113 + llvm::TimeTraceProfilerEnd(); +} S->DiagnoseNonDefaultPragmaPack( RKSimon

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23 #include "clang/Sema/Lookup.h" +#include "clang/Sema/SemaInternal.h" #include "clang/Sema/Template.h" RKSimon

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev updated this revision to Diff 11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/include/clang/Frontend/FrontendOptions.h

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 5 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/Parse/ParseAST.cpp:172 + { +llvm::TimeTraceScope scope("Backend", ""); +Consumer->HandleTranslationUnit(S.getASTContext()); rnk wrote: > I

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Ping! Should I add more FE guys to review this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Use native llvm JSON library update: https://reviews.llvm.org/D60609 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675 > > This is the first part of time tracing system, I have splitted them cause > > this

[PATCH] D60663: Time profiler: small fixes and optimizations

This revision was automatically updated to reflect the committed changes. Closed by commit rL358448: Time profiler: small fixes and optimizations (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 10 inline comments as done. anton-afanasyev added a comment. Patch by @thakis for BE passes tracing: https://reviews.llvm.org/D60782 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 23 inline comments as done. anton-afanasyev added a comment. In D58675#1465336 , @lebedev.ri wrote: > Some post-commit review (please submit a new review, don't replace this diff) > As usual, the incorrect license headers keep

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev created this revision. anton-afanasyev added a reviewer: lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, mgrang, hiraditya. Herald added projects: clang, LLVM. Fixes from Roman's review here: https://reviews.llvm.org/D58675#1465336 Repository: rG LLVM Github

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev updated this revision to Diff 195068. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files:

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev marked 7 inline comments as done. anton-afanasyev added a subscriber: aras-p. anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > >

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev updated this revision to Diff 195069. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60663/new/ https://reviews.llvm.org/D60663 Files: clang/tools/driver/cc1_main.cpp

[PATCH] D61945: ftime-trace as a CoreOption

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61945/new/ https://reviews.llvm.org/D61945

[PATCH] D61914: [Support][Test] Time profiler: add regression test

This revision was automatically updated to reflect the committed changes. Closed by commit rL362792: [Support][Test] Time profiler: add regression test (authored by anton-afanasyev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61914?vs=203532=203544#toc Repository: rL

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev updated this revision to Diff 203532. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914 Files:

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked 4 inline comments as done. anton-afanasyev added a comment. In D61914#1512021 , @aganea wrote: > Could you please move the test to a more approriate location? (ie. > clang/trunk/test/Driver/) Thanks, I've moved it there.

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. In D61914#1534508 , @plotfi wrote: > cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you > mean to pass the target explicitly ? This commit is

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205451. anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Parse/ParseAST.cpp:167 if (ADecl && !Consumer->HandleTopLevelDecl(ADecl.get())) return; } @lebedev.ri This `return` should follow

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked 10 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205446. anton-afanasyev marked 4 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1549316 , @lebedev.ri wrote: > Hmm, i'm only now noticing how fraglie this looks. > How do we know that `clang::ParseAST` will only ever be called with > `BackendConsumer` `ASTConsumer`? > How do we know that

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205673. anton-afanasyev added a comment. Updated, changed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Also, first `"Frontend"` section contains `"ParseTemplate"` and `"PerformPendingInstantiations"` sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205978. anton-afanasyev added a comment. Hi @lebedev.ri, I've turned back to the solution with one `TimeTraceScope` for "Frontend" inside `BackendConsumer::HandleTranslationUnit()`, since it looks more robust. This admits several (two for now)

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1553458 , @lebedev.ri wrote: > Hm, i started writing previous comment before you posted your last comment, > so i didn't see the last update. > This looks less intrusive, yes, but two observations: > > 1. You

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:67 // Only include sections longer than TimeTraceGranularity msec. -if (duration_cast(E.Duration).count() > TimeTraceGranularity)

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 206187. anton-afanasyev added a comment. Changed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205297. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:232 { +llvm::TimeTraceScope TimeScope("Frontend", StringRef("")); PrettyStackTraceString CrashInfo("Per-file LLVM IR generation"); lebedev.ri wrote: >

[PATCH] D61822: make -ftime-trace also print template arguments

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61822/new/ https://reviews.llvm.org/D61822 ___ cfe-commits

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev created this revision. anton-afanasyev added a reviewer: thakis. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test checking this option works as expected.

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. F9459646: spirit-c5ceba.json F9459650: Снимок экрана от 2019-07-04 18-54-58.png I've upload json-file and printscreen of its visualization (used https://speedscope.app). This is an example

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Is it ok now? I doubt that main code refactoring is a good way when adding support timer code. So ended with more robust solution, though it leads to two `Frontend` sections. Repository: rG LLVM Github

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL369308: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @nathanchance, @mgehre, fixed here: https://reviews.llvm.org/D66873, please, look at it to commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1645892 , @mgehre wrote: > I'm seeing the same issue `Not all CodeGen sections are inside any Frontend > section!` with python 3.7.1. Json: F9863382: check-time-trace-sections.json >

[PATCH] D66873: [Test][Time profiler] Fix test for python3

anton-afanasyev created this revision. anton-afanasyev added reviewers: mgehre, nathanchance. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test checking time profiler generates correct tracing json-file. `filter` works differently for python2 and python3, so unifying

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1643023 , @nathanchance wrote: > Done, thanks for looking into this! > > F9847579: check-time-trace-sections.json Hmm, I still didn't manage to reproduce the issue using

[PATCH] D66873: [Test][Time profiler] Fix test for python3

anton-afanasyev added a comment. Could you please give LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66873/new/ https://reviews.llvm.org/D66873 ___ cfe-commits mailing list

[PATCH] D66873: [Test][Time profiler] Fix test for python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL370300: [Test][Time profiler] Fix test for python3 (authored by anton-afanasyev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @nathanchance , I could not reproduce your failure using the same revision and `build-llvm` script. Could you please attach your json report located at

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1772 Opts.TimeTrace = Args.hasArg(OPT_ftime_trace); + Opts.TimeTraceGranularity = + getLastArgIntValue(Args,

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev updated this revision to Diff 211489. anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Remove default repeat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + anton-afanasyev wrote: > sammccall wrote: >

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:27 +static cl::opt TimeTraceGranularity( +"time-trace-granularity", sammccall wrote: > I know this is late, but...

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + sammccall wrote: > is there any possibility of wanting a granularity <1ms in the future? This

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev updated this revision to Diff 211481. anton-afanasyev marked 8 inline comments as done. anton-afanasyev added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202 Files:

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev marked an inline comment as done. anton-afanasyev added a subscriber: aras-p. anton-afanasyev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1943-1947 .. option:: -ftime-report +.. option:: -ftime-trace + +Turn on time profiler

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

anton-afanasyev created this revision. anton-afanasyev added a reviewer: sammccall. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Move `-ftime-trace-granularity` option to frontend options. Without patch this option is showed up in the help

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi all! Could it be accepted or reviewed more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___ cfe-commits mailing list

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Hi @lebedev.ri, could you please lgtm this or elaborate on possible issue with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325

[PATCH] D65202: [Support] Fix `-ftime-trace-granularity` option

This revision was automatically updated to reflect the committed changes. Closed by commit rL366911: [Support] Fix `-ftime-trace-granularity` option (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. I believe it's better solution, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68260/new/ https://reviews.llvm.org/D68260

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D68161: [TimeProfiler] Fix "OptModule" section and add new "Backend" sections

anton-afanasyev created this revision. anton-afanasyev added a reviewer: lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. Remove unnecessary "OptModule" section. Add "PerFunctionPasses", "PerModulePasses" and

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D68161: [TimeProfiler] Fix "OptModule" section and add new "Backend" sections

anton-afanasyev added a comment. In D68161#1686632 , @lebedev.ri wrote: > Oh nice! > F10096481: image.png > F10096488: image.png > I like this. > > One more related question -

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev created this revision. anton-afanasyev added reviewers: russell.gallop, lebedev.ri, thakis. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Add `Frontend` time trace entry to `HandleTranslationUnit()` function. Add test to check

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 204738. anton-afanasyev added a comment. Small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D69750: make -ftime-trace also trace time spent creating debug info

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69750/new/ https://reviews.llvm.org/D69750

[PATCH] D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71347/new/ https://reviews.llvm.org/D71347

[PATCH] D68161: [TimeProfiler] Fix "OptModule" section and add new "Backend" sections

anton-afanasyev closed this revision. anton-afanasyev added a comment. Commited long time ago (https://reviews.llvm.org/rL373142). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68161/new/ https://reviews.llvm.org/D68161

[PATCH] D68710: Remove time-trace message as it is inconsistent style

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. Yes, I agree. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___

[PATCH] D108625: [Test][Time profiler] Fix test time checking

anton-afanasyev created this revision. anton-afanasyev added reviewers: broadwaylamb, russell.gallop. anton-afanasyev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test sometimes triggers failures during build testing. For instance,

[PATCH] D108625: [Test][Time profiler] Fix test time checking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff780014b296: [Test][Time profiler] Fix test time checking (authored by anton-afanasyev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

anton-afanasyev updated this revision to Diff 391823. anton-afanasyev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113179/new/

[PATCH] D113179: [Passes] Move AggressiveInstCombine after InstCombine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc34d157fc739: [Passes] Move AggressiveInstCombine after InstCombine (authored by anton-afanasyev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf553287b5889: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++ (authored by anton-afanasyev). Changed prior to commit:

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

anton-afanasyev added a comment. In D129065#3631052 , @jrtc27 wrote: > Commit subject/body should say C++ in it Sure, updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129065/new/

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev created this revision. anton-afanasyev added reviewers: MaskRay, kito-cheng, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, jocewei, PkmX, the_o,

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain`

anton-afanasyev updated this revision to Diff 442069. anton-afanasyev added a comment. Update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129065/new/ https://reviews.llvm.org/D129065 Files:

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain`

anton-afanasyev created this revision. anton-afanasyev added reviewers: MaskRay, kito-cheng, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev added a comment. In D128625#3621030 , @MaskRay wrote: > The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC > installation selected while the requested target triple is > `riscv64-unknown-elf`? Yes, exactly (see

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; arichardson wrote: >

  1   2   >