Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#227951, @jroelofs wrote: In http://reviews.llvm.org/D11963#227441, @EricWF wrote: @jroelofs What do you think of an approach like this? Having two copies of the __config_site file makes me uncomfortable, but I could put up with

[libcxxabi] r245461 - [libcxxabi] Add install-libcxxabi target.

Author: ericwf Date: Wed Aug 19 12:17:21 2015 New Revision: 245461 URL: http://llvm.org/viewvc/llvm-project?rev=245461view=rev Log: [libcxxabi] Add install-libcxxabi target. Summary: Currently you can't install libc++abi from within the LLVM tree without installing all of LLVM. This patch adds

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#227933, @jroelofs wrote: In http://reviews.llvm.org/D11963#227444, @EricWF wrote: I also just realized that this change will currently likely play havoc with how libc++ and libc++abi build together. In order to build libc++ and

[libcxx] r245463 - [libcxx] Allow use of atomic in C++03. Try 3.

Author: ericwf Date: Wed Aug 19 12:21:46 2015 New Revision: 245463 URL: http://llvm.org/viewvc/llvm-project?rev=245463view=rev Log: [libcxx] Allow use of atomic in C++03. Try 3. Summary: After putting this question up on cfe-dev I have decided that it would be best to allow the use of `atomic`

[libcxx] r245335 - [libcxx] Fix PR23589: std::function doesn't recognize null pointer to varargs function.

Author: ericwf Date: Tue Aug 18 14:41:51 2015 New Revision: 245335 URL: http://llvm.org/viewvc/llvm-project?rev=245335view=rev Log: [libcxx] Fix PR23589: std::function doesn't recognize null pointer to varargs function. Summary: This patch fixes __not_null's detection of nullptr by breaking it

[libcxx] r245354 - Move atomic_support.h and config_elast.h into src/include

Author: ericwf Date: Tue Aug 18 16:08:54 2015 New Revision: 245354 URL: http://llvm.org/viewvc/llvm-project?rev=245354view=rev Log: Move atomic_support.h and config_elast.h into src/include Added: libcxx/trunk/src/include/ libcxx/trunk/src/include/atomic_support.h

Re: [PATCH] D11046: [libcxx] Add Atomic test helper and fix TSAN failures.

EricWF updated this revision to Diff 32454. EricWF added a comment. Add more explanation to the wait tests. http://reviews.llvm.org/D11046 Files: test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. I don't think the tricky part of this patch is actually implementing the ABI macros. The tricky part is defining how libc++ should use the macros. Some questions I would like to see answered: 1. How long is a major and minor ABI version supported? 2. When is the major

[libcxx] r245410 - Fix use of static_assert macro with nested commas

Author: ericwf Date: Tue Aug 18 22:38:41 2015 New Revision: 245410 URL: http://llvm.org/viewvc/llvm-project?rev=245410view=rev Log: Fix use of static_assert macro with nested commas Modified: libcxx/trunk/include/thread Modified: libcxx/trunk/include/thread URL:

[libcxx] r245411 - Remove commented out TODOs. They defined unneeded methods.

Author: ericwf Date: Tue Aug 18 22:48:08 2015 New Revision: 245411 URL: http://llvm.org/viewvc/llvm-project?rev=245411view=rev Log: Remove commented out TODOs. They defined unneeded methods. Modified: libcxx/trunk/include/experimental/any libcxx/trunk/src/any.cpp Modified:

Re: [PATCH] D12117: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Not really but I would add a `// UNSUPPORTED: clang-3.5, clang-3.6, clang-3.7` line to prevent the failures from appearing. http://reviews.llvm.org/D12117

[libcxx] r245513 - Add files that got missed in r245512.

Author: ericwf Date: Wed Aug 19 17:35:56 2015 New Revision: 245513 URL: http://llvm.org/viewvc/llvm-project?rev=245513view=rev Log: Add files that got missed in r245512. Added: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.single/unique.ptr.single.asgn/move_convert.pass.cpp

[PATCH] D12173: [libcxx] Constrain unique_ptr::operator=(unique_ptrTp, Dp) in C++03 mode

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch properly constrains the converting assignment operator in C++03. It also fixes a bug where std::forward was given the wrong type. The following two tests begin passing in C++03:

Re: [PATCH] D12173: [libcxx] Constrain unique_ptr::operator=(unique_ptrTp, Dp) in C++03 mode

EricWF updated this revision to Diff 32631. EricWF added a comment. Update diff so it has more context. http://reviews.llvm.org/D12173 Files: include/memory Index: include/memory === --- include/memory +++ include/memory @@

[libcxx] r245522 - Cleanup failing dynarray tests

Author: ericwf Date: Wed Aug 19 18:33:18 2015 New Revision: 245522 URL: http://llvm.org/viewvc/llvm-project?rev=245522view=rev Log: Cleanup failing dynarray tests Added: libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.cons/default_throws_bad_alloc.pass.cpp

[libcxxabi] r245531 - Fix or disable C++11 tests in C++03 mode

Author: ericwf Date: Wed Aug 19 20:22:17 2015 New Revision: 245531 URL: http://llvm.org/viewvc/llvm-project?rev=245531view=rev Log: Fix or disable C++11 tests in C++03 mode Modified: libcxxabi/trunk/test/catch_in_noexcept.pass.cpp libcxxabi/trunk/test/catch_pointer_nullptr.pass.cpp

[libcxx] r245525 - Fix more uses of uninitialized values in dynarray

Author: ericwf Date: Wed Aug 19 19:10:22 2015 New Revision: 245525 URL: http://llvm.org/viewvc/llvm-project?rev=245525view=rev Log: Fix more uses of uninitialized values in dynarray Modified: libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.data/default.pass.cpp

[libcxx] r245529 - Cleanup unique_ptr failure tests and convert them to Clang verify

Author: ericwf Date: Wed Aug 19 20:08:03 2015 New Revision: 245529 URL: http://llvm.org/viewvc/llvm-project?rev=245529view=rev Log: Cleanup unique_ptr failure tests and convert them to Clang verify Modified:

[libcxx] r245538 - Fix a typo: abreviated - abbreviated - Patch from Kai Zhao

Author: ericwf Date: Thu Aug 20 00:20:29 2015 New Revision: 245538 URL: http://llvm.org/viewvc/llvm-project?rev=245538view=rev Log: Fix a typo: abreviated - abbreviated - Patch from Kai Zhao Modified:

Re: [PATCH] D12183: Fix a typo: abreviated - abbreviated

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thanks again! A lot of these look like my mistakes :S http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12183: Fix a typo: abreviated - abbreviated

EricWF closed this revision. EricWF added a comment. commited as r245538. http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245539 - Fix a typo: overidden - overridden - Patch from Kai Zhao

Author: ericwf Date: Thu Aug 20 00:23:16 2015 New Revision: 245539 URL: http://llvm.org/viewvc/llvm-project?rev=245539view=rev Log: Fix a typo: overidden - overridden - Patch from Kai Zhao Modified: libcxx/trunk/src/new.cpp Modified: libcxx/trunk/src/new.cpp URL:

Re: [PATCH] D12182: Fix a typo: overriden - overridden in libcxx/src/new.cpp

EricWF closed this revision. EricWF added a comment. Committed as r245539. http://reviews.llvm.org/D12182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245793 - Refactor shared_timed_mutex tests.

Author: ericwf Date: Sat Aug 22 16:24:01 2015 New Revision: 245793 URL: http://llvm.org/viewvc/llvm-project?rev=245793view=rev Log: Refactor shared_timed_mutex tests. First I removed all of the uses of _LIBCPP_STD_VER and added LIT UNSUPPORTED tags to prevent the tests from being run in older

[libcxx] r245806 - Recommit rL245802: Cleanup fancy pointer rebinding in list using __rebind_pointer.

Author: ericwf Date: Sat Aug 22 21:56:05 2015 New Revision: 245806 URL: http://llvm.org/viewvc/llvm-project?rev=245806view=rev Log: Recommit rL245802: Cleanup fancy pointer rebinding in list using __rebind_pointer. Currently we need an #ifdef branch every time we use pointer traits to rebind a

[PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF created this revision. EricWF added reviewers: delcypher, silvas. EricWF added subscribers: llvm-commits, cfe-commits. http://reviews.llvm.org/D12265 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index:

[libcxx] r245788 - [libcxx] Add new Sphinx documentation

Author: ericwf Date: Sat Aug 22 14:40:49 2015 New Revision: 245788 URL: http://llvm.org/viewvc/llvm-project?rev=245788view=rev Log: [libcxx] Add new Sphinx documentation Summary: This patch adds Sphinx based documentation to libc++. The goal is to make it easier to write documentation for

[libcxx] r245802 - Cleanup fancy pointer rebinding in list using __rebind_pointer.

Author: ericwf Date: Sat Aug 22 21:34:18 2015 New Revision: 245802 URL: http://llvm.org/viewvc/llvm-project?rev=245802view=rev Log: Cleanup fancy pointer rebinding in list using __rebind_pointer. Currently we need an #ifdef branch every time we use pointer traits to rebind a pointer because it

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added inline comments. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when replacing the system's libc++. +**Your system will not be able to boot without a functioning libc++.** + jroelofs wrote: Is there a way to

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added a comment. Gentle ping. There is going to be a couple of days lag time between committing this and it showing up at libcxx.llvm.org/docs. Once it is available at `libcxx.llvm.org/docs` we still have time to review it before we link to it from the homepage. For this reason, and

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF updated this revision to Diff 32718. EricWF marked an inline comment as done. EricWF updated the summary for this revision. EricWF added a comment. Address review comments. http://reviews.llvm.org/D12129 Files: CMakeLists.txt cmake/Modules/HandleOutOfTreeLLVM.cmake

[libcxx] r245389 - [libcxx] Add Atomic test helper and fix TSAN failures.

Author: ericwf Date: Tue Aug 18 18:29:59 2015 New Revision: 245389 URL: http://llvm.org/viewvc/llvm-project?rev=245389view=rev Log: [libcxx] Add Atomic test helper and fix TSAN failures. Summary: This patch attempts to fix the last 3 TSAN failures on the libc++ bot

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF added a comment. I've uploaded a version of the docs built with the haiku theme to http://efcs.ca/libcxx-haiku-docs. I would like other's input on which style they prefer (Note: The LLVM themed docs are here http://efcs.ca/libcxx-docs). http://reviews.llvm.org/D12129

Re: [PATCH] D12117: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()

EricWF added a comment. Is this going to break this test with older versions of compiler-rt? http://reviews.llvm.org/D12117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11046: [libcxx] Add Atomic test helper and fix TSAN failures.

EricWF updated this revision to Diff 32473. EricWF added a comment. Fix more failing TSAN tests. http://reviews.llvm.org/D11046 Files: test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp test/std/thread/thread.condition/thread.condition.condvar/notify_one.pass.cpp

Re: [PATCH] D11682: [libcxxabi] Add install-libcxxabi target.

EricWF added a comment. Followup on @beanz comments. Comment at: src/CMakeLists.txt:123 @@ -124,1 +122,3 @@ + LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi + ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi )

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. I also just realized that this change will currently likely play havoc with how libc++ and libc++abi build together. In order to build libc++ and libc++abi together we would need to 1. Configure libc++ pointing to the libc++abi headers in order to generate the

Re: [PATCH] D11781: Refactored pthread usage in libcxx

EricWF added a comment. Added more inline comments. Comment at: include/__mutex_base:36 @@ -35,3 +37,3 @@ #else - mutex() _NOEXCEPT {__m_ = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;} #endif Why was the cast insignificant? Comment at:

Re: [PATCH] D11394: Fix warnings about pessimizing return moves for C++11 and higher

EricWF added a comment. @dim Has this been committed or is there something holding you back? http://reviews.llvm.org/D11394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10963: Implement LWG#2063: Contradictory requirements for string move assignment

EricWF added a comment. @mclow.lists: Do other containers need this update as well? If so it might be worth while writing noexcept traits that handle the `#ifdef` hell in one spot instead of repeating it throughout. http://reviews.llvm.org/D10963

Re: [PATCH] D11781: Refactored pthread usage in libcxx

EricWF added a reviewer: EricWF. EricWF added a comment. This patch has a long way to go but it has also come a long way. Here are a couple of problems I see with it. 1. There are still plenty of ABI breaks. I'll try and point them all out. 2. This patch adds a lot of headers. libc++ has

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. I'm not sure I understand the problem. Is it possible to provide a minimal reproducer of the bug/behavior you are describing? http://reviews.llvm.org/D12247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

EricWF added a comment. Added more review comments for the boyer_moore searcher. Comment at: include/experimental/functional:256 @@ +255,3 @@ + +public: // TODO private: +_RandomAccessIterator1 __first_; Is this for testing?

[libcxx] r245601 - Remove completed items from TODO.TXT

Author: ericwf Date: Thu Aug 20 14:22:35 2015 New Revision: 245601 URL: http://llvm.org/viewvc/llvm-project?rev=245601view=rev Log: Remove completed items from TODO.TXT Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL:

[PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

EricWF created this revision. EricWF added reviewers: mclow.lists, beanz, jroelofs. EricWF added a subscriber: cfe-commits. On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause your computer to fail to boot. This patch tries to make it harder to do that accidentally. If

Re: [PATCH] D12182: Fix a typo: overriden - overridden in libcxx/src/new.cpp

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Do you need somebody to commit this for you? http://reviews.llvm.org/D12182 ___ cfe-commits mailing list

Re: [PATCH] D11682: [libcxxabi] Add install-libcxxabi target.

EricWF added a comment. In http://reviews.llvm.org/D11682#216902, @jroelofs wrote: Does this install the headers too? No. Just the libraries. http://reviews.llvm.org/D11682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after renaming `tested_elsewhere.pass.cpp` http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D12299: [libcxx] ABI-Breaking Fix for ALL undefined behavior in list.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. This patch is an ABI-breaking version of D12297. However unlike D12297, this patch does not have any undefined behavior when `element_type` has a stricter alignment

[libcxx] r245877 - Move test/std/utilities/date.time to proper stable name utilities/time/date.time

Author: ericwf Date: Mon Aug 24 16:27:25 2015 New Revision: 245877 URL: http://llvm.org/viewvc/llvm-project?rev=245877view=rev Log: Move test/std/utilities/date.time to proper stable name utilities/time/date.time Added: libcxx/trunk/test/libcxx/utilities/time/

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF updated the summary for this revision. EricWF updated this revision to Diff 32997. EricWF added a comment. Update diff to remove misc cleanup stuff. http://reviews.llvm.org/D11963 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake include/CMakeLists.txt

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF commandeered this revision. EricWF edited reviewers, added: jroelofs; removed: EricWF. EricWF added a comment. Stealing this revision. I have a different plan. http://reviews.llvm.org/D11963 ___ cfe-commits mailing list

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF added a comment. Actually commit this as is and I'll handle the other cleanup. http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF added a comment. Can you move the `libcpp-has-no-threads` tests to `test/libcxx/atomics` instead of deleting them? (I imagine that's what you intended to do). Also `tested_elsewhere.pass.cpp` shouldn't really be called that because it contains the actual test. Could you rename it to

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting so I can commit. Comment at: buildbot/osuosl/master/config/builders.py:1166 @@ +1165,3 @@ +

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF updated this revision to Diff 33029. EricWF marked 2 inline comments as done. http://reviews.llvm.org/D12265 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zorg/buildbot/builders/SphinxDocsBuilder.py

Re: [libcxx] r251062 - Disable linker scripts when the ABI library is not specified or is none.

uld probably be done on it's own. On Thu, Oct 22, 2015 at 10:57 AM, Jonathan Roelofs < jonat...@codesourcery.com> wrote: > > > On 10/22/15 2:50 PM, Eric Fiselier via cfe-commits wrote: > >> Author: ericwf >> Date: Thu Oct 22 15:50:07 2015 >> New Revision: 2

[libcxx] r251063 - Only disable linker script when LIBCXX_CXX_ABI_LIBNAME is none

Author: ericwf Date: Thu Oct 22 15:54:27 2015 New Revision: 251063 URL: http://llvm.org/viewvc/llvm-project?rev=251063=rev Log: Only disable linker script when LIBCXX_CXX_ABI_LIBNAME is none Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake Modified:

[libcxx] r251062 - Disable linker scripts when the ABI library is not specified or is none.

Author: ericwf Date: Thu Oct 22 15:50:07 2015 New Revision: 251062 URL: http://llvm.org/viewvc/llvm-project?rev=251062=rev Log: Disable linker scripts when the ABI library is not specified or is none. Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

>> >> >> >> On Oct 20, 2015 9:39 PM, "Hahnfeld, Jonas" <hahnf...@itc.rwth-aachen.de> >> wrote: >> >>> > -Original Message- >>> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On >>>

[libcxx] r251065 - Dont required CMake 3 to install a linker script

Author: ericwf Date: Thu Oct 22 16:24:01 2015 New Revision: 251065 URL: http://llvm.org/viewvc/llvm-project?rev=251065=rev Log: Dont required CMake 3 to install a linker script Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMakeLists.txt URL:

[libcxx] r251334 - Fix test suite configuration. Sorry Marshall

Author: ericwf Date: Mon Oct 26 14:08:53 2015 New Revision: 251334 URL: http://llvm.org/viewvc/llvm-project?rev=251334=rev Log: Fix test suite configuration. Sorry Marshall Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

Re: [libcxx] r249929 - Split out of .

Hi Michael, Sorry I'm holding this patch up in review. The fix is quite "novel" and I want to make sure we get it right. If we can't land it over the weekend I'll ask Richard to revert while we work on it. /Eric On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" <

Re: [PATCH] D14119: [libcxxabi] Correctly align fallback heap

EricWF added a subscriber: EricWF. EricWF added a comment. This patch is incomplete and incorrect. The heap actually needs to be aligned to a 16 byte boundary, and all pointers returned from it must also be 16 byte aligned. I have a complete fix for this issue as http://reviews.llvm.org/D12669.

Re: [PATCH] D14119: [libcxxabi] Correctly align fallback heap

EricWF added a comment. @t.p.northover @olista01 A char array can legally alias any other type memory AFAIK. Its perfectly legal to use a char array to provide raw memory. There shouldn't be any undefined behavior here. Repository: rL LLVM http://reviews.llvm.org/D14119

Re: [libcxx] r251529 - Adapt to lit change in llvm r251478-r251481

Thanks for the fix. On Wed, Oct 28, 2015 at 11:20 AM, Matthias Braun via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: matze > Date: Wed Oct 28 12:20:33 2015 > New Revision: 251529 > > URL: http://llvm.org/viewvc/llvm-project?rev=251529=rev > Log: > Adapt to lit change in llvm

Re: [libcxx] r251065 - Dont required CMake 3 to install a linker script

ersion is 2.8.12.2 which > should be the minimum required version when building all LLVM projects. > > Cheers, > Jonas > > > -Original Message----- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > > Of Eric Fiselier via cfe-commit

[libcxx] r251100 - Use proper output directory when naminging the libc++ output

Author: ericwf Date: Fri Oct 23 02:04:24 2015 New Revision: 251100 URL: http://llvm.org/viewvc/llvm-project?rev=251100=rev Log: Use proper output directory when naminging the libc++ output Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMakeLists.txt URL:

RE: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

its [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > > Of Eric Fiselier via cfe-commits > > Sent: Wednesday, October 14, 2015 9:54 PM > > To: cfe-commits@lists.llvm.org > > Subject: [libcxx] r250319 - [libcxx] Make it drastically simpler to link > > libc++. > &g

Re: [PATCH] D10677: Allow deque to handle incomplete types

> I'm pretty sure it only affects template evaluation order, and does not change the mangling of any name. I agree it doesn't change the mangling of any name. I just want to make sure that moving the initializer won't result in incompatible code gen. I'm sure I'm insane for being concerned about

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Yep. That's a flaky test. No need to worry. Repository: rL LLVM http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF added a comment. No changes are needed in ``? Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r252274 - Cleanup foo.h headers and __config to work in C

Author: ericwf Date: Fri Nov 6 00:30:12 2015 New Revision: 252274 URL: http://llvm.org/viewvc/llvm-project?rev=252274=rev Log: Cleanup foo.h headers and __config to work in C Modified: libcxx/trunk/include/__config libcxx/trunk/include/errno.h libcxx/trunk/include/float.h

Re: [PATCH] D14410: Cleanup: move all visibility attributes to the first declaration.

EricWF added a comment. Thank you so much! I was procrastination taking this on. Repository: rL LLVM http://reviews.llvm.org/D14410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14130: Delete dead code in the LibcxxAndAbiBuilder

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks. http://reviews.llvm.org/D14130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10677: Allow deque to handle incomplete types

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think I've cleared up my own confusion. LGTM. Repository: rL LLVM http://reviews.llvm.org/D10677 ___ cfe-commits mailing list

Re: [PATCH] D14410: Cleanup: move all visibility attributes to the first declaration.

EricWF added a comment. Is this a mechanical change, or do you remove/add some attributes in this patch? Repository: rL LLVM http://reviews.llvm.org/D14410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14410: Cleanup: move all visibility attributes to the first declaration.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. It's not just libc++.so that could have it's ABI affected by adding/removing these. It's any shared library build against libc++. However if we are just moving the attribute to the proper

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added inline comments. Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:123-133 @@ +122,13 @@ + else(WIN32) +if(UNIX) + set(LLVM_ON_WIN32 0) + set(LLVM_ON_UNIX 1) + if(APPLE) +set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) + else(APPLE) +

[libcxxabi] r250307 - Add config.project_obj_root to the libc++abi testsuite

Author: ericwf Date: Wed Oct 14 13:20:48 2015 New Revision: 250307 URL: http://llvm.org/viewvc/llvm-project?rev=250307=rev Log: Add config.project_obj_root to the libc++abi testsuite Modified: libcxxabi/trunk/test/lit.site.cfg.in Modified: libcxxabi/trunk/test/lit.site.cfg.in URL:

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

EricWF added a comment. - I would love to have some documentation in libc++ about always-inline, the ABI problem it is trying to solve, and how it falls short. Because you tried to fix these semantics in clang would you be willing to write up a short summary of when always-inline does and

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

EricWF added a subscriber: EricWF. EricWF added reviewers: EricWF, mclow.lists. EricWF added a comment. > This is required by the standard and is needed if the user tries to > explicitly instantiate the transcendental functions using _Tp, for example, > std::abs(int_valarray). These may in

Re: [PATCH] D10677: Allow deque to handle incomplete types

EricWF added a comment. For the most part this looks good. I'm a touch concerned though about the changes to the static initialization. The initializer is moved from within the function body to outside it. Could you have somebody confirm this won't affect the existing ABI?

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. One thing does need to change though. For each overload you added you need to change all of the uses of `__is_val_expr` in the original overload to a new metafunction that only

[libcxx] r250279 - Fix GCC atomic implementation in C++03

Author: ericwf Date: Wed Oct 14 03:36:22 2015 New Revision: 250279 URL: http://llvm.org/viewvc/llvm-project?rev=250279=rev Log: Fix GCC atomic implementation in C++03 Modified: libcxx/trunk/include/atomic Modified: libcxx/trunk/include/atomic URL:

[libcxxabi] r250316 - Fix LIBCXXABI_HAS_NO_THREADS configuration.

Author: ericwf Date: Wed Oct 14 14:21:38 2015 New Revision: 250316 URL: http://llvm.org/viewvc/llvm-project?rev=250316=rev Log: Fix LIBCXXABI_HAS_NO_THREADS configuration. Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

[libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

Author: ericwf Date: Wed Oct 14 14:54:03 2015 New Revision: 250319 URL: http://llvm.org/viewvc/llvm-project?rev=250319=rev Log: [libcxx] Make it drastically simpler to link libc++. Summary: Currently on most platforms you have to manually link the c++ abi library used with libc++ whenever you

[libcxx] r250323 - Update testing guide for libc++

Author: ericwf Date: Wed Oct 14 15:44:44 2015 New Revision: 250323 URL: http://llvm.org/viewvc/llvm-project?rev=250323=rev Log: Update testing guide for libc++ Modified: libcxx/trunk/docs/TestingLibcxx.rst Modified: libcxx/trunk/docs/TestingLibcxx.rst URL:

[PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF created this revision. EricWF added reviewers: mclow.lists, jroelofs, danalbert, compnerd. EricWF added subscribers: cfe-commits, cbergstrom, rengolin, emaste. This patch turns on `LIBCXX_ENABLE_ABI_LINKER_SCRIPT` by default whenever `LLVM_HAVE_LINK_VERSION_SCRIPT` is ON. This turns out

[libcxxabi] r250313 - Configure for config site header

Author: ericwf Date: Wed Oct 14 14:01:47 2015 New Revision: 250313 URL: http://llvm.org/viewvc/llvm-project?rev=250313=rev Log: Configure for config site header Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

EricWF updated this revision to Diff 37376. EricWF added a comment. Updating diff so it merges cleanly against master. http://reviews.llvm.org/D12508 Files: CMakeLists.txt lib/CMakeLists.txt test/CMakeLists.txt utils/gen_link_script/gen_link_script.py Index:

[libcxx] r250325 - Link to new documentation from existing homepage

Author: ericwf Date: Wed Oct 14 15:51:33 2015 New Revision: 250325 URL: http://llvm.org/viewvc/llvm-project?rev=250325=rev Log: Link to new documentation from existing homepage Modified: libcxx/trunk/www/index.html Modified: libcxx/trunk/www/index.html URL:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. @cbergstrom After installing libcxxrt I ran the libc++ configuration with `-DLIBCXX_CXX_ABI=libcxxrt` and everything worked perfectly. It generated libc++.so as `INPUT(libc++.so.1 -lcxxrt)` and after running it against the test suite everything works great.

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. Thanks for the review. I'm going to wait a little to see if any objections crop up before committing. http://reviews.llvm.org/D13739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r250336 - Update issues status

Author: ericwf Date: Wed Oct 14 17:26:40 2015 New Revision: 250336 URL: http://llvm.org/viewvc/llvm-project?rev=250336=rev Log: Update issues status Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. In http://reviews.llvm.org/D13739#267286, @cbergstrom wrote: > ‎And does this hardcode the abi and break cxxrt? It's not just me who uses > that  No it does not hard code the ABI. The linker script is generated based on the name of the ABI library selected at build

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF updated this revision to Diff 37393. EricWF marked 5 inline comments as done. EricWF added a comment. Address review comments. http://reviews.llvm.org/D13739 Files: CMakeLists.txt cmake/Modules/HandleOutOfTreeLLVM.cmake docs/BuildingLibcxx.rst docs/UsingLibcxx.rst Index:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added inline comments. Comment at: CMakeLists.txt:71 @@ -70,1 +70,3 @@ +# Use a static copy of the ABI library when linking libc++. This option +# cannot be used with LIBCXX_ENABLE_ABI_LINKER_SCRIPT. option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY "Statically link the ABI

[PATCH] D13748: [libcxx] Fix PR15638 - Only allocate in parent when starting a thread to prevent calling terminate.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Hi, When creating a new thread libc++ performs at least 2 allocations. The first allocates a tuple of args and the functor that will be passed to the new thread. The

  1   2   3   4   5   6   7   8   9   10   >