[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

This revision was automatically updated to reflect the committed changes. Closed by commit rL297837: [Driver] Restructure handling of -ffast-math and similar options (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D30582?vs=91745=91871#toc Repository: rL LLVM

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:2452 + if (!HonorInfs && !HonorNans && !MathErrno && AssociativeMath && + ReciprocalMath && !SignedZeros && !TrappingMath && FpContract == "fast") +CmdArgs.push_back("-ffast-math");

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn created this revision. The way -ffast-math and the various related options to tweak floating-point handling are handled is inflexible and rather confusing. This patch restructures things so that we go through the options adjusting our idea of what's enabled as we go, instead of

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn updated this revision to Diff 91311. john.brawn added a comment. Rebase on top of recent driver changes. Repository: rL LLVM https://reviews.llvm.org/D30582 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/fast-math.c Index: test/Driver/fast-math.c

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn updated this revision to Diff 91745. john.brawn added a comment. Respond to review comments, and also fix a couple of 80-column violations that I spotted. Repository: rL LLVM https://reviews.llvm.org/D30582 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/fast-math.c

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

john.brawn added a comment. I know very little about how code completion works, but it's not immediately obvious to me that disabling plugin ast consumers when code completion is enabled is necessarily correct. In what kind of scenario would we both have a plugin loaded that wants to insert an

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361372: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation (authored by john.brawn, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

john.brawn created this revision. john.brawn added reviewers: chill, efriedma, t.p.northover, rjmccall. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Overaligned and underaligned types (i.e. types where the alignment has been increased or decreased using

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

john.brawn added a comment. In D62152#1508979 , @efriedma wrote: > Please verify my understanding of the following is correct: > > 1. getTypeUnadjustedAlign() is currently only used to compute calling > convention alignment for ARM and AArch64. Yes,

[PATCH] D64242: [AArch64] Fix scalar vuqadd intrinsics operands

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with one nitpick. Comment at: test/CodeGen/aarch64-neon-vuqadd-float-conversion-warning.c:2 +// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature

[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with a couple of nitpicks. > The existing unsigned argument can cause faulty code as float to unsigned > conversion is undefined, > which llvm/clang optimizes away. It's

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:144 + // otherwise return a default ParsedAttrInfo. + if (A.getKind() < sizeof(AttrInfoMap)/sizeof(AttrInfoMap[0])) +return *AttrInfoMap[A.getKind()];

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

john.brawn abandoned this revision. john.brawn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Abandoning this old obsolete patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239292. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: llvm-commits. john.brawn added a comment. Herald added a project: clang.

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239295. john.brawn retitled this revision from "Move ParsedAttrInfos into a registry and point to one in AttributeList" to "Move ParsedAttrInfos into a registry and point to one in ParsedAttr". john.brawn added reviewers: erichkeane, aaron.ballman,

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 239299. john.brawn edited the summary of this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 239307. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added a comment. Herald added a project: clang.

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 4 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:143 + // otherwise return a default ParsedAttrInfo. + const ParsedAttrInfo *Info = AttrInfoMap[A.getKind()]; + if (Info) erichkeane wrote:

[PATCH] D31343: Add an attribute plugin example

john.brawn added a comment. I've been looking into attribute merging, and as far as I can tell there's two things going on: - In SemaDeclAttr.cpp, the various handleXyzAttr functions may call mergeXyzAttr to handle clashes with other attributes within the same declaration. - In SemaDecl.cpp,

[PATCH] D31343: Add an attribute plugin example

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:35 +Spellings.push_back({ParsedAttr::AS_GNU, "example"}); +Spellings.push_back({ParsedAttr::AS_CXX11, "::example"}); +

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked 6 inline comments as done. john.brawn added inline comments. Comment at: clang/docs/ClangPlugins.rst:89 +The members of ``ParsedAttrInfo`` that a plugin attribute must define are: + * ``AttrKind``, which must be set to ``ParsedAttr::NoSemaHandlerAttribute``. +

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 247681. john.brawn added a comment. Update based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 Files: clang/docs/ClangPlugins.rst clang/docs/InternalsManual.rst

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 247683. john.brawn added a comment. Rebased and added link in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 Files: clang/docs/ClangPlugins.rst clang/examples/Attribute/Attribute.cpp

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/docs/ClangPlugins.rst:74 + + class ExampleAttrInfo : public ParsedAttrInfo { + public: aaron.ballman wrote: > We should be documenting the fields of

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 246987. john.brawn added a comment. Update based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 Files: clang/docs/ClangPlugins.rst clang/docs/InternalsManual.rst

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rG75d4d4bd028f: Add an attribute registry so plugins can add attributes (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31338?vs=246763=247014#toc Repository: rG LLVM

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 246989. john.brawn marked an inline comment as done. john.brawn added a comment. Update based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 Files:

[PATCH] D31343: Add an attribute plugin example

john.brawn marked 5 inline comments as done. john.brawn added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:25 +struct ExampleAttrInfo : public ParsedAttrInfo { + ExampleAttrInfo() { +// Set the kind to NoSemaHandlerAttribute to make sure clang doesn't

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG590dc8d02cd7: Use virtual functions in ParsedAttrInfo instead of function pointers (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31337?vs=242363=246765#toc Repository:

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 246763. john.brawn added a comment. Herald added a subscriber: krytarowski. This has been rewritten so that the registry is only used for attributes added by plugins, and everything else continues as before. This also removes the strange dependency I'd

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:101-103 + for (ParsedAttrInfoRegistry::iterator it = ParsedAttrInfoRegistry::begin(), +ie =

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:141 +static ParsedAttrInfo DefaultParsedAttrInfo; static const ParsedAttrInfo (const ParsedAttr ) { aaron.ballman wrote: > Might as well

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 242363. john.brawn added a comment. Move DefaultParsedAttrInfo out of file scope, and move custom appertains-to function generation out of the loop in EmitClangAttrParsedAttrImpl so we only need to use one output stream. CHANGES SINCE LAST ACTION

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239536. john.brawn added a comment. Updated to match latest changes to D31337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31338/new/ https://reviews.llvm.org/D31338 Files:

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239535. john.brawn added a comment. Update based on review comments. Also fix warnings due to missing virtual destructor that I hadn't noticed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31337/new/ https://reviews.llvm.org/D31337

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked 3 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type

[PATCH] D31343: Add an attribute plugin example

john.brawn added a comment. Release note added: https://reviews.llvm.org/rG0cff81cff05d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 ___ cfe-commits mailing

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3f171090f6: Dont normalise CXX11/C2X attribute names to start with :: (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D76704?vs=252308=252578#toc Repository: rG LLVM

[PATCH] D31343: Add an attribute plugin example

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f03c12a51be: Add an attribute plugin example (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

john.brawn added a comment. Herald added subscribers: frgossen, grosul1. Herald added a reviewer: MaskRay. With this patch the Threading.PhysicalConcurrency unit test fails when run with an affinity less than the number of physical cpus. I've raised https://bugs.llvm.org/show_bug.cgi?id=45556.

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 251113. john.brawn added a comment. Use an enum for the return value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 Files: clang/docs/ClangPlugins.rst clang/docs/InternalsManual.rst

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 251114. john.brawn added a comment. Updated to match the changes to D31342 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 Files: clang/docs/ClangPlugins.rst

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0320dd8d5a: Add ParsedAttrInfo::handleDeclAttribute (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

john.brawn created this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. john.brawn added a child revision: D31343: Add an attribute plugin example. Currently square-bracket-style (CXX11/C2X) attribute names are normalised to start with ::

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 252309. john.brawn added a comment. A few small changes: - Don't start C++11 spelling with :: (changes to name normalisation to allow this are in D76704 ) - Don't check that the Decl is null in diagAppertainsToDecl -

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn updated this revision to Diff 265279. john.brawn added a comment. Adjusted to not give multiple errors when more than one error criteria is met. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80295/new/ https://reviews.llvm.org/D80295 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn created this revision. john.brawn added reviewers: rsmith, rjmccall. Herald added a project: clang. We currently diagnose static data members directly contained in unnamed classes, but we should also diagnose when they're in a class that is nested (directly or indirectly) in an

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM (looks like the other example plugins just use PRIVATE as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86091/new/

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

john.brawn created this revision. john.brawn added reviewers: efriedma, vhscampos, chill. Herald added subscribers: dexonsmith, steven_wu, hiraditya, kristof.beyls. Herald added a project: clang. john.brawn requested review of this revision. LLVM assumes that when it creates a call to a C library

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88546/new/ https://reviews.llvm.org/D88546

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c906f7785da: [Sema] Diagnose more cases of static data members in local or unnamed classes (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { rjmccall wrote: >

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

john.brawn updated this revision to Diff 265779. john.brawn retitled this revision from "[Sema] Diagnose static data members in classes nested in unnamed classes" to "[Sema] Diagnose more cases of static data members in local or unnamed classes". john.brawn edited the summary of this revision.

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn updated this revision to Diff 265486. john.brawn marked an inline comment as done. john.brawn added a comment. Use the tag of the anonymous struct when emitting a diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80295/new/ https://reviews.llvm.org/D80295 Files:

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { rjmccall wrote: > This diagnostic actually ignores the tag kind that

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

john.brawn updated this revision to Diff 299420. john.brawn edited the summary of this revision. john.brawn added a comment. Adjusted to give an error when the specified float abi is incompatible with the default. Was a bit trickier than I expected as it required extracting out the logic to

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

john.brawn added a comment. This also causes the AnnotateFunctions example to no longer build: /home/jb/work/llvm-project/clang/examples/AnnotateFunctions/AnnotateFunctions.cpp: In member function ‘virtual bool

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1fa201af77: [Driver] When forcing a crash print the bug report message (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:518 + CRC.DumpStackAndCleanupOnFailure = true; + CRC.RunSafely([&]() { abort(); }); } aganea wrote: > The only concern I have

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn updated this revision to Diff 271757. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Moved BugReportMsg printing into CrashRecoveryContext, and stopped printing of backtrace

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 272471. john.brawn retitled this revision from "[Driver] When forcing a crash call abort to get the correct diagnostic" to "[Driver] When forcing a crash print the bug report message". john.brawn edited the summary of this revision. john.brawn added a

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL MaskRay wrote: > This variable is

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 273816. john.brawn edited the summary of this revision. john.brawn added a comment. Don't print the diagnostic with -gen-reproducer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 Files:

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > john.brawn wrote: > > MaskRay wrote: > > > Why ` llvm::dbgs()

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn added reviewers: aganea, rnk. john.brawn added a comment. Added a couple of reviewers that have recently worked on CrashRecoveryContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn created this revision. john.brawn added reviewers: gbreynoo, jhenderson, probinson. Herald added a project: clang. Commit a945037e8fd0c30e250a62211469eea6765a36ae moved the printing of the "PLEASE submit a bug

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c66606230df: [Driver] Incorporate -mfloat-abi in the computed triple on ARM (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99606: [clang][cli] Fix round-trip of OPT_plugin_arg

john.brawn created this revision. john.brawn added reviewers: jansvoboda11, dexonsmith, Bigcheese. john.brawn requested review of this revision. Herald added a project: clang. The test Frontend/plugin-delayed-template.cpp is failing when asserts are enabled because it hits an assertion in

[PATCH] D99606: [clang][cli] Fix round-trip of OPT_plugin_arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeae3b2a715d7: [clang][cli] Fix round-trip of OPT_plugin_arg (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. Looking at the behaviour of gcc it looks like there -march=armv8-r enables instructions that are present in 8-r but not 8-a, but doesn't disable any instructions. So e.g. it will accept the dcps3 instruction when compiling with -march=armv8-r whereas clang won't.

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1548 + +static const AArch64SysReg::SysReg *lookupSysReg(unsigned Val, bool Read, + const MCSubtargetInfo ) {

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. In D110065#3087330 , @labrinea wrote: > Added v8.1a_ops on AppleA10. However, the target parser lists it as v8.0a, > which seems odd. Out of the scope of this patch anyway. Looking at the definition of A10 in target parser

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. I have one small comment, but otherwise LGTM. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1558 + + if (Reg && !isValidSysReg(Reg, Read,

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. llvm/test/CodeGen/AArch64/fp-intrinsics-vector.ll is testing the asm generation, so it probably is fine to remove that here so I will. This test is specifically testing arm_neon.h intrinsics though, so wouldn't make sense unifying with other architectures.

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 416141. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e17c9613f36: [AArch64] Add some missing strict FP vector lowering (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 419494. john.brawn added a comment. Adjusted formatting slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 405213. john.brawn added a comment. Update based on review comments and adjust formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117795/new/ https://reviews.llvm.org/D117795 Files: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn planned changes to this revision. john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbca998ed3c9a: [AArch64] Generate fcmps when appropriate for neon intrinsics (authored by john.brawn). Repository: rG LLVM Github Monorepo

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

john.brawn added inline comments. Comment at: llvm/test/CodeGen/ARM/2013-05-05-IfConvertBug.ll:1-4 ; RUN: llc < %s -mtriple=thumbv7-apple-ios -mcpu=cortex-a8 | FileCheck %s ; RUN: llc < %s -mtriple=thumbv8 | FileCheck -check-prefix=CHECK-V8 %s -; RUN: llc < %s -mtriple=thumbv7

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 403614. john.brawn retitled this revision from "[AArch64] Fixes for strict FP vector instructions" to "[AArch64] Add some missing strict FP vector lowering". john.brawn edited the summary of this revision. john.brawn added a comment. The other parts of

[PATCH] D117795: [AArch64] Fixes for strict FP vector instructions

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added subscribers: hiraditya, kristof.beyls. john.brawn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Fix several

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. This test no longer fails during isel, but does need the expected

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 422257. john.brawn added a comment. Removed clang test changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1386 + + IsStrictFPEnabled = true; } dmgreen wrote: > What are the ramifications of setting this to true? The behaviour with IsStrictFPEnabled = false is that strict

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

john.brawn updated this revision to Diff 422285. john.brawn retitled this revision from "[AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL" to "[AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL". john.brawn edited the summary of this revision. john.brawn

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1466c34669: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL (authored by john.brawn). Repository: rG LLVM Github Monorepo

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed a test for the behaviour when we have invalid decls in https://reviews.llvm.org/rG6244e3840694. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed an updated version of this that checks for invalid decls when deciding if a decl has been hidden. This stops the assertion failure happening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/

  1   2   >