[PATCH] D27821: [OpenMP] support is_device_ptr clause with 'target parallel' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, hfinkel, carlo.bertolli, sfantao, arpith-jacob, mikerice. kkwli0 added a subscriber: cfe-commits. This patch is to add support of the 'is_device_ptr' clause in the 'target parallel' pragma. https://reviews.llvm.org/D27821 Files:

[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:757 Kind == OMPD_distribute_parallel_for_simd || Kind == OMPD_distribute_simd; // TODO add next directives. ABataev wrote: >

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

kkwli0 added a comment. I am okay with the changes. Thanks. Alexey will have the final say. https://reviews.llvm.org/D27488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:6444 + + CapturedStmt *CS = cast(AStmt); + // 1.2.2 OpenMP Language Terminology ABataev wrote: > auto * Will do. https://reviews.llvm.org/D28252

[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: test/OpenMP/nesting_of_regions.cpp:3326 } -#pragma omp ordered { ABataev wrote: > what about teams distribute parallel for simd inside the ordered directive? > Why this one

[PATCH] D28402: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for simd' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, mikerice, hfinkel. kkwli0 added a subscriber: cfe-commits. This patch is to add support of the 'is_device_ptr' clause in the 'target parallel for simd' pragma. https://reviews.llvm.org/D28402

[PATCH] D28255: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel, mikerice. kkwli0 added a subscriber: cfe-commits. This patch is to add support of the 'is_device_ptr' clause in the 'target parallel for' pragma. https://reviews.llvm.org/D28255

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

kkwli0 added inline comments. Comment at: docs/ClangCommandLineReference.rst:1454 +.. option:: -fopenmp-simd, -fno-openmp-simd + I am not sure if it is target architecture specific or not. If it is, should we be under the target flag instead?

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

kkwli0 added a comment. The original case has the variables named "foo1" and foo2". Using "foo1" or "foo2" causes the assert! I update the description. https://reviews.llvm.org/D40588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40588: [OpenMP] Diagnose undeclared variables on declare target clause

kkwli0 updated this revision to Diff 124811. kkwli0 added a comment. The assert occurs in VarOrFuncDeclFilterCCC::ValidateCandidate when clang::Sema::CorrectTypo is called. https://reviews.llvm.org/D40588 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/declare_target_messages.cpp Index:

[PATCH] D40996: Add --no-cuda-version-check in unknown-std.cpp

kkwli0 created this revision. This unit test fails on the system that has CUDA Toolkit 9.0 installed. And CUDA 9 does not support GPU arch sm_20. It results in the following error. clang-6.0: error: GPU arch sm_20 is supported by CUDA versions between 7.0 and 8.0 (inclusive), but

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12671 +void Sema::checkDeclIsAllowedInOpenMPTarget(Expr *E, Decl *D, +const DeclarationNameInfo *Id) { if (!D || D->isInvalidDecl()) ABataev wrote: >

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 updated this revision to Diff 126025. kkwli0 marked an inline comment as done. https://reviews.llvm.org/D40968 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaOpenMP.cpp test/OpenMP/declare_target_ast_print.cpp

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12576 +if (MT == OMPDeclareTargetDeclAttr::MT_Link && isa(ND)) { + Diag(Id.getLoc(), diag::err_omp_function_in_link_clause); ABataev wrote: > I

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:12671 +void Sema::checkDeclIsAllowedInOpenMPTarget(Expr *E, Decl *D, +const DeclarationNameInfo *Id) { if (!D ||

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 created this revision. This patch is to add diagnose when a function name is specified on the link clause. According to the OpenMP spec, only the list items that exclude the function name are allowed on the link clause. void foo() {} #pragma omp declare target link(foo)

[PATCH] D40968: [OpenMP] Diagnose function name on the link clause

kkwli0 updated this revision to Diff 126217. kkwli0 marked an inline comment as done. https://reviews.llvm.org/D40968 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaOpenMP.cpp test/OpenMP/declare_target_ast_print.cpp

[PATCH] D40996: Add --no-cuda-version-check in unknown-std.cpp

kkwli0 updated this revision to Diff 126258. kkwli0 added a comment. Using a mock CUDA installation works too. https://reviews.llvm.org/D40996 Files: test/Driver/unknown-std.cpp Index: test/Driver/unknown-std.cpp === ---

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

kkwli0 added a comment. Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp needs to update too. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3707 /// UB >= Var - bool TestIsLessOp = false; + /// This will has no value when the condition is != +

[PATCH] D51446: [OpenMP][bugfix] Add missing macros for Power

kkwli0 added a comment. Need to update the test too? Repository: rC Clang https://reviews.llvm.org/D51446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 added a comment. In D56733#1360221 , @gtbercea wrote: > Could we add the changes in D56790 to this > diff? Sure, I will do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 182384. kkwli0 added a reviewer: gtbercea. kkwli0 added a comment. Add changes in D56790 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 182556. kkwli0 marked an inline comment as done. kkwli0 added a comment. Addressed reviewer's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst docs/ReleaseNotes.rst

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:62 + +- Simplified code generation for distribute and parallel in SPMD mode. + gtbercea wrote: > Simplified SPMD code generation for `distribute parallel

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 181834. kkwli0 added a comment. Add update in OpenMP support release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst docs/ReleaseNotes.rst Index:

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + ABataev wrote: > -fopenmp-optimistic-collapse How about

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

kkwli0 added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the Clang C/C++/Objective-C/OpenCL frontend, part of the LLVM Compiler Infrastructure,

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

kkwli0 added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4077 + /// C++ nested name specifier for the assoicated user-defined mapper. + NestedNameSpecifierLoc MapperQualifierLoc; assoicated -> associated Comment at:

[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

kkwli0 added a comment. The change looks okay to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58243/new/ https://reviews.llvm.org/D58243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 created this revision. kkwli0 added a reviewer: ABataev. Herald added a subscriber: guansong. The compiler does not generate any error messages if there are more than one teams construct inside a target constructs. #pragma omp target { #pragma omp teams { ... }

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 updated this revision to Diff 185125. kkwli0 marked an inline comment as done. kkwli0 added a comment. Update based on review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7070 const auto *OED = dyn_cast(*I); -if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind())) { +if (!OED ||

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 closed this revision. kkwli0 added a comment. Committed: r353186 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:198 ++--+--+--++ +| device extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:184 ++--+--+--++ +| task extension |

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--++ +| device extension |

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604561 , @gtbercea wrote: > In D65341#1604440 , @ABataev wrote: > > > In D65341#1604411 , @Hahnfeld > > wrote: > > > > > There's already

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604562 , @kkwli0 wrote: > In D65341#1604561 , @gtbercea wrote: > > > In D65341#1604440 , @ABataev wrote: > > > > > In D65341#1604411

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. Looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1622042 , @ABataev wrote: > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > is_device_ptr with the private clauses? > > Yes, since it is allowed by the standard. Umm ... I probably

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause:

[PATCH] D69909: [OPENMP] [DOCS] fix section formatting issues [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f10cc2d124c: [OPENMP] [DOCS] fix section formatting issues [NFC] (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70608: [OPENMP] [DOCS] correct status for use_device_addr clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7a1c0cfc2a: [OPENMP] [DOCS] correct status for use_device_addr clause (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 created this revision. kkwli0 added reviewers: jdoerfert, ABataev, JonChesterfield, tra. Herald added a subscriber: guansong. kkwli0 edited the summary of this revision. This patch is to add CUDA 10.2 support. It essentially removes the warning message regarding the CUDA 10.2 toolkit not

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. In D74571#1874947 , @JonChesterfield wrote: > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the > same as whether it works but is the closest approximation we have available. > > Assuming yes, this

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. In D74571#1874950 , @jdoerfert wrote: > > in order to avoid bug 44587 which requires >9.0.1 to be the build compiler? > > Do we already require CUDA 10 as part of the libomptarget cmake (with a nice > message) to avoid the errors

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. > Somewhat related, that means Clang issues a warning for every compilation > should there be a "unsupported" CUDA version around, even if it's not used? > @tra maybe we can only issue the warning if CUDA is going to be used? Some related issues were discussed in D74571

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1891742 , @tra wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this way

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1891966 , @tra wrote: > In D75001#1891861 , @kkwli0 wrote: > > > @tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda? > > > If you're asking whether the warning will be

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16e267bb6ee: [OpenMP][cmake] ignore warning on unknown CUDA version (authored by kkwli0). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Repository: rG LLVM Github Monorepo

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 updated this revision to Diff 242166. kkwli0 added a comment. Change `requires unified_address` status to partial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 Files: clang/docs/OpenMPSupport.rst Index:

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:216

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rGac430336318a: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC] (authored by kkwli0). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Summary - In order to avoid the bug in PR44587 , one needs to build with >9.0. - With CUDA toolkit 10.2, building the trunk will fail because 10.0.0 does not support it yet. CHANGES SINCE LAST ACTION

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Thanks for all the comments. It makes sense to keep the warning there before any ptx65 features are added. The warning should also apply to both the CUDA and OpenMP compile paths. As a result, I will pursue to ignore the warning in the build of libomp (i.e.

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. > I am not sure I understand. Do we need to modify stuff outside of `/openmp`? > I was hoping it is our CMake that can be adjusted to make this work as > described earlier. TBH, he warning is even not my biggest problem. As long as > we get a libomptarget.bc we should

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. It turns out that having the warning message also affects the C_SUPPORTS_FPIC test in `cmake/modules/HandleLLVMOptions.cmake`. As a result, `cmake` thinks that `-fPIC` is not supported. Eventually, it leads to error in `libclang-cpp.so`.

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. So an alternative is to: - patch `openmp/runtime/cmake/LibompCheckLinkerFlag.cmake` to make the `libomp_check_linker_flag` function to ignore the "Unknown CUDA version" warning, AND - ask users to build with `-DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

kkwli0 added a comment. Since it is a TR8 feature, should we have this guarded by `-fopenmp-version=`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 ___

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

kkwli0 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1251 "expected '#pragma omp end declare target'">; +def err_expected_end_declare_target_or_variant : Error< + "expected '#pragma omp end declare %select{target|variant}0'">;

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 created this revision. kkwli0 added reviewers: tra, ABataev, JonChesterfield, jdoerfert, ye-luo. Herald added subscribers: guansong, mgorny. With CUDA 10.2 installed on the system, the compiler issues a warning about unknown CUDA version. The warning message makes the

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 13 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:216

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 updated this revision to Diff 239719. kkwli0 marked 2 inline comments as done. kkwli0 added a comment. Herald added a subscriber: jfb. Address review comments and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 Files:

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 created this revision. kkwli0 added reviewers: ABataev, RaviNarayanaswamy, jdoerfert. Herald added a subscriber: guansong. Add missing OMP5.0 features. https://reviews.llvm.org/D72901 Files: clang/docs/OpenMPSupport.rst Index: clang/docs/OpenMPSupport.rst

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 updated this revision to Diff 235894. kkwli0 added a comment. Update based on suggestion to simply the check and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG427ffa2cdbbc: [OpenMP] diagnose zero-length array section in the depend clause (authored by kkwli0). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 created this revision. kkwli0 added a reviewer: ABataev. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. The OpenMP specification disallows having zero-length array sections in the depend clause (OpenMP 5.0 2.17.11). https://reviews.llvm.org/D71969 Files:

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 added a comment. In D71969#1798224 , @jdoerfert wrote: > Is there a reason not to put this check right next to the one that issues > `err_omp_section_length_negative`. SemaExpr.cpp +4668 It is a good idea to group the checking together however

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1922789 , @jdoerfert wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `present` map type and motion modifier `default(firstprivate)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 ___ cfe-commits mailing

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `default(firstprivate)` was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

kkwli0 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +/// non-contiguous list items in

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

kkwli0 added a comment. Is the diff from HEAD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 added a comment. I tried the patch in our environment and it works. LG. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/new/ https://reviews.llvm.org/D98902 ___ cfe-commits mailing

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 accepted this revision. kkwli0 added a comment. This revision is now accepted and ready to land. No more comments from the community. I think it is okay to accept this revision. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea4aed50a9f: [OpenMP] Add search path for llvm-strip (authored by kkwli0). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

kkwli0 created this revision. kkwli0 added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. kkwli0 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add the search path for llvm-strip instead of solely

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4022493 , @awarzynski wrote: > Hi @madanial , thanks for posting this! > >> This patch adds user option -funderscoring/-fnounderscoring which behaves >> similar to the gfortran option be enabling/disabling the >>

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4033559 , @awarzynski wrote: >> However, I don't think the patch does what we want. Given a procedure name >> `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`. >> We will look into it. > >

[PATCH] D155852: [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rG00769d69fbaa: [flang] Add -fppc-native-vector-element-order option to control the element… (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG