[PATCH] D13190: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

2015-09-26 Thread Nemanja Ivanovic via cfe-commits
nemanjai created this revision. nemanjai added reviewers: wschmidt, seurer, kbarton, hfinkel. nemanjai added a subscriber: cfe-commits. nemanjai set the repository for this revision to rL LLVM. Implemented the following interfaces to conform to ELF V2 ABI version 1.1. vector signed __int128

Re: [PATCH] D13190: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

2015-09-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 35838. nemanjai added a comment. I forgot the test cases in the original upload. This patch contains the test cases and is ready for review. Repository: rL LLVM http://reviews.llvm.org/D13190 Files: include/clang/Basic/BuiltinsPPC.def

r248813 - Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

2015-09-29 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Sep 29 13:13:34 2015 New Revision: 248813 URL: http://llvm.org/viewvc/llvm-project?rev=248813=rev Log: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1 This patch corresponds to review: http://reviews.llvm.org/D13190 Implemented the following

r248815 - Forgot to remove a FIXME that has been fixed. NFC.

2015-09-29 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Sep 29 13:20:59 2015 New Revision: 248815 URL: http://llvm.org/viewvc/llvm-project?rev=248815=rev Log: Forgot to remove a FIXME that has been fixed. NFC. Modified: cfe/trunk/lib/Headers/altivec.h Modified: cfe/trunk/lib/Headers/altivec.h URL:

[PATCH] D15120: Add support for __float128 type to be used by targets that support it

2015-12-01 Thread Nemanja Ivanovic via cfe-commits
nemanjai created this revision. nemanjai added reviewers: hfinkel, wschmidt, kbarton, rsmith. nemanjai added a subscriber: cfe-commits. nemanjai set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. This patch adds support for the __float128 keyword and literals for

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2015-12-11 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: include/clang/Basic/TargetInfo.h:384 @@ +383,3 @@ + unsigned getFloat128Width() const { return 128; } + unsigned getFloat128Align() const { return 128; } + const llvm::fltSemantics () const { hubert.reinterpretcast

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2015-12-15 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. I think the correct course of action would be to allow/disallow promotion based on a condition that the two types are the same/different (respectively). I think a comparison of the float semantics is a valid way to check this. Also, should operations between long

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2015-12-10 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 42414. nemanjai added a comment. Updated to address review comments. Rather than listing responses and justification for some of the changes, I'll provide comments inline for better readability. Repository: rL LLVM http://reviews.llvm.org/D15120

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2015-12-10 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2064 @@ +2063,3 @@ +if (getASTContext().getTargetInfo().useFloat128ManglingForLongDouble()) + Out << "U10__float128"; // Match the GCC mangling +else Please refer to

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-02-08 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 47223. nemanjai added a comment. Fixed the naming, indentation and removed the use of dyn_cast for types. Repository: rL LLVM http://reviews.llvm.org/D15120 Files: bindings/python/clang/cindex.py include/clang-c/Index.h

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-02-10 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Basic/TargetInfo.cpp:231 @@ +230,3 @@ +if (hasFloat128Type() && +() == ::APFloat::IEEEquad) + return Float128; hubert.reinterpretcast wrote: > Is it necessary to check that `__float128` is IEEE quad

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-02-01 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. If the reviewers don't mind, I would like to keep this patch with diagnostics for interoperability between the two types for now. This is simply because enabling such interoperability requires changes to some of the conversion infrastructure (i.e. allowing

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-01-26 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 45998. nemanjai added a comment. Addressed review comments. The key differences are: - No assignments or operations between entities of long double and __float128 allowed if the two types have a different representation - Each type has a distinct rank

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-01-27 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Thank you for the discussion on rank. I'm glad we have an agreement on the rank of the two types. However, considering __float128 already has a higher rank in this patch, is there anything else that you would like me to change here before the patch is approved? Do

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

2016-03-01 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 49508. nemanjai added a comment. Removed questionable macro definitions. Renamed the test function for invalid conversions and changed the semantics so that it allows __float128 <-> long double conversions only if the two types have the same representation

r266186 - Enable support for __float128 in Clang

2016-04-13 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Wed Apr 13 04:49:45 2016 New Revision: 266186 URL: http://llvm.org/viewvc/llvm-project?rev=266186=rev Log: Enable support for __float128 in Clang This patch corresponds to review: http://reviews.llvm.org/D15120 It adds support for the __float128 keyword, literals and a

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

2016-03-03 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Headers/altivec.h:136 @@ -131,3 +135,3 @@ #if defined(__POWER8_VECTOR__) && defined(__powerpc64__) static vector double __ATTRS_o_ai vec_abs(vector double __a) { I thought we were going to change the guard here

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

2016-03-03 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. All of my comments are just nits and shouldn't hold up approval. As far as I can tell this looks fine, but I'll let the LGTM come from Kit or Hal. Comment at: lib/Headers/altivec.h:136 @@ -131,3 +135,3 @@ #if defined(__POWER8_VECTOR__) &&

Re: r266186 - Enable support for __float128 in Clang

2016-04-15 Thread Nemanja Ivanovic via cfe-commits
sts.llvm.org> >> > Sent: Thursday, April 14, 2016 8:07:58 PM >> > Subject: Re: r266186 - Enable support for __float128 in Clang >> > >> > On Wed, Apr 13, 2016 at 2:49 AM, Nemanja Ivanovic via cfe-commits >> > <cfe-commits@lists.llvm.org> wrote

Re: r266186 - Enable support for __float128 in Clang

2016-04-15 Thread Nemanja Ivanovic via cfe-commits
manja.i@gmail.com>, "Nico Weber" < >>>> tha...@chromium.org> >>>> > Cc: "cfe-commits" <cfe-commits@lists.llvm.org> >>>> > Sent: Thursday, April 14, 2016 8:07:58 PM >>>> > Subject: Re: r266186 - Enable support f

r266460 - Revert 266186 as it breaks anything that includes type_traits on some platforms

2016-04-15 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Apr 15 13:04:13 2016 New Revision: 266460 URL: http://llvm.org/viewvc/llvm-project?rev=266460=rev Log: Revert 266186 as it breaks anything that includes type_traits on some platforms Since this patch provided support for the __float128 type but disabled it on all

Re: r266186 - Enable support for __float128 in Clang

2016-04-15 Thread Nemanja Ivanovic via cfe-commits
eak* linux/x86? > > On Fri, Apr 15, 2016 at 11:53 AM, Nemanja Ivanovic via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I have just pinged the patch to see if I can get it approved today. Can I >> give it a few hours and if it isn't approved by tonight, I'll

[PATCH] D19684: Power9 - Support for -mcpu=pwr9 in the front end

2016-04-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai created this revision. nemanjai added reviewers: hfinkel, wschmidt, kbarton, amehsan, seurer, cycheng. nemanjai added a subscriber: cfe-commits. nemanjai set the repository for this revision to rL LLVM. This patch simply adds support for the new CPU in anticipation of Power9. There

Re: [PATCH] D19684: Power9 - Support for -mcpu=pwr9 in the front end

2016-04-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Basic/Targets.cpp:1239 @@ -1227,1 +1238,3 @@ + if (defs & ArchDefinePwr9) +Builder.defineMacro("_ARCH_PWR9"); if (defs & ArchDefineA2) Come to think of it - I should add a test case for this macro. It will

r268898 - Enable support for __float128 in Clang and enable it on pertinent platforms

2016-05-09 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Mon May 9 03:52:33 2016 New Revision: 268898 URL: http://llvm.org/viewvc/llvm-project?rev=268898=rev Log: Enable support for __float128 in Clang and enable it on pertinent platforms This patch corresponds to reviews: http://reviews.llvm.org/D15120

r268951 - [Power9] Enable -mcpu=pwr9 (-mcpu=power9) in the front end

2016-05-09 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Mon May 9 13:58:02 2016 New Revision: 268951 URL: http://llvm.org/viewvc/llvm-project?rev=268951=rev Log: [Power9] Enable -mcpu=pwr9 (-mcpu=power9) in the front end This patch corresponds to review: http://reviews.llvm.org/D19684 It simply adds the handling for the

Re: [PATCH] D19684: Power9 - Support for -mcpu=pwr9 in the front end

2016-05-09 Thread Nemanja Ivanovic via cfe-commits
nemanjai closed this revision. nemanjai added a comment. Committed revision 268951. Repository: rL LLVM http://reviews.llvm.org/D19684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-09 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Looking over the patch, I realized that I forgot to add a test case for the __POWER9_VECTOR__ macro and the builtins that target the record forms of the instructions. I'll add those on the next revision along with addressing any review comments. Repository: rL

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. In https://reviews.llvm.org/D24397#555470, @spatel wrote: > Having a clang regression/unit test that depends on optimizer behavior is > generally viewed as wrong. Can the tests be split into front-end (clang) > tests and separate tests for the IR optimizer? Both x86

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-28 Thread Nemanja Ivanovic via cfe-commits
Well, I don't know much about what Clang will actually do here, but I'll follow your advice and add -O0 and pipe to opt -S -mem2reg. I'll also add a test case in LLVM (test/CodeGen/PowerPC) that will test that after opt and llc, we generate the desired code for these builtins. Thanks Sanjay and

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-10-05 Thread Nemanja Ivanovic via cfe-commits
OK, I get testing that I'm fine with if I remove the -O2 and the checks for 'select i1'. Does that change suffice for the purposes of https://reviews.llvm.org/D24955 ? Namely, do I need to account for the possible addition of nsw/nuw flags to the add instructions even without -O2? On Wed, Oct

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-10-05 Thread Nemanja Ivanovic via cfe-commits
OK, will remove optimization and the selects and commit this now. Sorry about the delay. On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel wrote: > You should not need to account for any nsw/nuw flags if the clang test > does not enable the optimizer. > Ie, D24955 should not

r283363 - Removing optimization from the RUN lines and adjusting the checks

2016-10-05 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Wed Oct 5 14:11:36 2016 New Revision: 283363 URL: http://llvm.org/viewvc/llvm-project?rev=283363=rev Log: Removing optimization from the RUN lines and adjusting the checks to not rely on optimization. Modified: cfe/trunk/test/CodeGen/builtins-ppc-p9vector.c Modified:

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-10-05 Thread Nemanja Ivanovic via cfe-commits
Committed revision 283363. On Wed, Oct 5, 2016 at 9:18 PM, Nemanja Ivanovic wrote: > OK, will remove optimization and the selects and commit this now. > Sorry about the delay. > > On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel > wrote: > >> You

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-27 Thread Nemanja Ivanovic via cfe-commits
nemanjai closed this revision. nemanjai added a comment. Committed revision 282481. Repository: rL LLVM https://reviews.llvm.org/D24397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. In https://reviews.llvm.org/D24397#555057, @bjope wrote: > This test/CodeGen/builtins-ppc-p9vector.c test will fail together with this > upcoming LLVM patch https://reviews.llvm.org/D24955 > > Problem is that lots of your > > add i64 {{.*}}, 64 > > checks will fails

r282481 - [Power9] Builtins for ELF v.2 ABI conformance - front end portion

2016-09-27 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Sep 27 05:45:22 2016 New Revision: 282481 URL: http://llvm.org/viewvc/llvm-project?rev=282481=rev Log: [Power9] Builtins for ELF v.2 ABI conformance - front end portion This patch corresponds to review: https://reviews.llvm.org/D24397 It adds the __POWER9_VECTOR__

r285268 - [PPC] add vector byte reverse functions to altivec.h

2016-10-27 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Thu Oct 27 01:23:57 2016 New Revision: 285268 URL: http://llvm.org/viewvc/llvm-project?rev=285268=rev Log: [PPC] add vector byte reverse functions to altivec.h This patch corresponds to review https://reviews.llvm.org/D25915. Committing on behalf of Sean Fertile.

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

2016-10-27 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Other than the minor nit, this LGTM. Comment at: include/clang/Basic/BuiltinsPPC.def:275 + +BUILTIN(__builtin_altivec_vclzlsbb, "SiV16Uc", "") No need for this extra blank line. https://reviews.llvm.org/D26002

[PATCH] D26073: [PPC] Add vec_absd functions to altivec.h

2016-10-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. This patch LGTM. I'll let @kbarton/@echristo have a look as well and have the final say. https://reviews.llvm.org/D26073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285436 - Implement vector count leading/trailing bytes with zero lsb and vector parity

2016-10-28 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Oct 28 14:49:03 2016 New Revision: 285436 URL: http://llvm.org/viewvc/llvm-project?rev=285436=rev Log: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion This patch corresponds to review:

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

2016-10-28 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Committed revision 285436. Zaara, please close this review if there are no buildbot failures. https://reviews.llvm.org/D26002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26308: [PowerPC] Add vector conversion builtins to altivec.h - clang portion

2016-11-04 Thread Nemanja Ivanovic via cfe-commits
nemanjai created this revision. nemanjai added reviewers: hfinkel, echristo, kbarton, amehsan, syzaara, sfertile, jtony, lei. nemanjai added a subscriber: cfe-commits. nemanjai set the repository for this revision to rL LLVM. Herald added a subscriber: mehdi_amini. This patch adds the following

[PATCH] D26479: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-09 Thread Nemanja Ivanovic via cfe-commits
nemanjai created this revision. nemanjai added reviewers: hfinkel, kbarton, syzaara, lei, jtony, sfertile, amehsan. nemanjai added subscribers: cfe-commits, echristo. nemanjai set the repository for this revision to rL LLVM. This adds the following signatures into altivec.h: vector bool long

[PATCH] D26304: [Power9] vector load/store with length - clang portion

2016-11-08 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: include/clang/Basic/BuiltinsPPC.def:304 +BUILTIN(__builtin_vsx_lxvl, "V4ivC*Ui", "") +BUILTIN(__builtin_vsx_lxvll, "V4ivC*Ui", "") Also, in addition to guarding for 64-bit, these should be defined to take the length

[PATCH] D26479: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-10 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. In https://reviews.llvm.org/D26479#591723, @amehsan wrote: > more context? Really sorry. It appears that I uploaded the wrong patch file. Updating now. Repository: rL LLVM https://reviews.llvm.org/D26479 ___

[PATCH] D26479: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-10 Thread Nemanja Ivanovic via cfe-commits
nemanjai updated this revision to Diff 77494. nemanjai added a comment. Accidentally uploaded the wrong patch so it was missing full context. Repository: rL LLVM https://reviews.llvm.org/D26479 Files: include/clang/Basic/BuiltinsPPC.def lib/Headers/altivec.h

[PATCH] D26304: [Power9] vector load/store with length - clang portion

2016-11-04 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Zaara, prior to committing this patch, can you write a test case that will actually use these builtins in an executable test case and confirm the results. We'll then run it on the simulator to ensure functional correctness. Comment at:

r286627 - [PowerPC] Add vector conversion builtins to altivec.h - clang portion

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Nov 11 13:56:17 2016 New Revision: 286627 URL: http://llvm.org/viewvc/llvm-project?rev=286627=rev Log: [PowerPC] Add vector conversion builtins to altivec.h - clang portion This patch corresponds to review: https://reviews.llvm.org/D26308 It adds a number of vector

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

2016-11-22 Thread Nemanja Ivanovic via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Overall, I'd like to see another revision of this. This is not because I feel the patch requires major rework, but because there is a number of minor comments that I'd like to

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

2016-11-22 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8182 +ConstantInt *ArgCI = dyn_cast(Ops[2]); +assert(ArgCI); +int64_t index = clamp(ArgCI->getSExtValue(), 0, 12); ```assert(ArgCI && "The third operand of this intrinsic must be a

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Headers/altivec.h:12014 +#define vec_insert4b(__a, __b, __c) \ + ((vector unsigned char)__builtin_vsx_xxinsertw((__a), (__b), (__c) & 0xF)) +#endif As far as I can tell by looking at this patch and the

r286650 - [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Nov 11 16:34:44 2016 New Revision: 286650 URL: http://llvm.org/viewvc/llvm-project?rev=286650=rev Log: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion This patch corresponds to review: https://reviews.llvm.org/D26479 It adds the remaining

[PATCH] D26479: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
nemanjai closed this revision. nemanjai added a comment. Committed revision 286650. Repository: rL LLVM https://reviews.llvm.org/D26479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

2016-11-13 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Headers/altivec.h:11908 +#define vec_extract4b(__a, __b) \ + vec_reve((vector unsigned long long) \ +

[PATCH] D26544: [PPC] support for arithmetic builtins in the FE

2016-11-13 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: lib/Headers/altivec.h:314 + vector signed int __carry = __c & __mask; + return vec_add(vec_add(__a, __b), __mask); +} I don't understand why we're adding `__mask` to the sum of `__a` and `__b`. Shouldn't that be

[PATCH] D26308: [PowerPC] Add vector conversion builtins to altivec.h - clang portion

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
nemanjai closed this revision. nemanjai added a comment. Committed revision 286627. Repository: rL LLVM https://reviews.llvm.org/D26308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26479: [PowerPC] Implement remaining permute builtins in altivec.h - Clang portion

2016-11-11 Thread Nemanja Ivanovic via cfe-commits
nemanjai added inline comments. Comment at: include/clang/Basic/BuiltinsPPC.def:385-388 +BUILTIN(__builtin_altivec_vrlwmi, "V4UiV4UiV4UiV4Ui", "") +BUILTIN(__builtin_altivec_vrldmi, "V2ULLiV2ULLiV2ULLiV2ULLi", "") +BUILTIN(__builtin_altivec_vrlwnm, "V4UiV4UiV4Ui", "")

r285679 - [PPC] Add vec_absd functions to altivec.h

2016-11-01 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Nov 1 03:39:56 2016 New Revision: 285679 URL: http://llvm.org/viewvc/llvm-project?rev=285679=rev Log: [PPC] Add vec_absd functions to altivec.h This patch corresponds to review https://reviews.llvm.org/D26073. Committing on behalf of Sean Fertile. Modified:

[PATCH] D26073: [PPC] Add vec_absd functions to altivec.h

2016-11-01 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. Committed revision 285679. Sean, please close this review pending no buildbot failures. https://reviews.llvm.org/D26073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285694 - [PowerPC] Implement vector shift builtins - clang portion

2016-11-01 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Nov 1 09:46:20 2016 New Revision: 285694 URL: http://llvm.org/viewvc/llvm-project?rev=285694=rev Log: [PowerPC] Implement vector shift builtins - clang portion This patch corresponds to review https://reviews.llvm.org/D26092. Committing on behalf of Tony Jiang.

[PATCH] D26271: [PPC} add extract significand/ extract exponent/test data class for vector float and vector double -- clang portion

2016-11-03 Thread Nemanja Ivanovic via cfe-commits
nemanjai added a comment. LGTM but I'll let @kbarton have a look and provide the final approval. Comment at: lib/Headers/altivec.h:15629 +#define vec_test_data_class(__a, __b) \ +_Generic((__a),

r285439 - [PPC] add float and double overloads for vec_orc and vec_nand in altivec.h

2016-10-28 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Oct 28 15:04:53 2016 New Revision: 285439 URL: http://llvm.org/viewvc/llvm-project?rev=285439=rev Log: [PPC] add float and double overloads for vec_orc and vec_nand in altivec.h This patch corresponds to review https://reviews.llvm.org/D25950. Committing on behalf of

r285623 - NFC - Reorder test case names in a PPC test case

2016-10-31 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Mon Oct 31 14:02:54 2016 New Revision: 285623 URL: http://llvm.org/viewvc/llvm-project?rev=285623=rev Log: NFC - Reorder test case names in a PPC test case A few recent commits have messed up the order of some tests in a PPC test case. This just reorders them in a sensible

r296861 - [PowerPC] Enable -fomit-frame-pointer by default for PPC

2017-03-03 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Fri Mar 3 03:49:17 2017 New Revision: 296861 URL: http://llvm.org/viewvc/llvm-project?rev=296861=rev Log: [PowerPC] Enable -fomit-frame-pointer by default for PPC As is the case on platforms like Mips, X86 and SystemZ, the -fomit-frame-pointer should be enabled by default

r308985 - This test case is causing all PPC and SystemZ bots to remain red.

2017-07-25 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Jul 25 10:04:12 2017 New Revision: 308985 URL: http://llvm.org/viewvc/llvm-project?rev=308985=rev Log: This test case is causing all PPC and SystemZ bots to remain red. Notifying the author via Diffusion did not yield any answer. Therefore, I'm adding the missing

r309256 - [PowerPC] Pass CPU to assembler with -no-integrated-as

2017-07-27 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Thu Jul 27 01:58:28 2017 New Revision: 309256 URL: http://llvm.org/viewvc/llvm-project?rev=309256=rev Log: [PowerPC] Pass CPU to assembler with -no-integrated-as This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler.

r337451 - NFC: Remove extraneous semicolons as pointed out in the differential review

2018-07-19 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Thu Jul 19 05:49:27 2018 New Revision: 337451 URL: http://llvm.org/viewvc/llvm-project?rev=337451=rev Log: NFC: Remove extraneous semicolons as pointed out in the differential review The commit for https://reviews.llvm.org/D49424 missed the comment about the extraneous

r337449 - [PowerPC] Handle __builtin_xxpermdi the same way as GCC does

2018-07-19 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Thu Jul 19 05:44:15 2018 New Revision: 337449 URL: http://llvm.org/viewvc/llvm-project?rev=337449=rev Log: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does The codegen for this builtin was initially implemented to match GCC. However, due to interest from users

r347556 - [PowerPC] Vector load/store builtins overstate alignment of pointers

2018-11-26 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Mon Nov 26 06:35:38 2018 New Revision: 347556 URL: http://llvm.org/viewvc/llvm-project?rev=347556=rev Log: [PowerPC] Vector load/store builtins overstate alignment of pointers A number of builtins in altivec.h load/store vectors from pointers to scalar types. Currently

r354512 - Make predefined FLT16 macros conditional on support for the type

2019-02-20 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Wed Feb 20 12:27:33 2019 New Revision: 354512 URL: http://llvm.org/viewvc/llvm-project?rev=354512=rev Log: Make predefined FLT16 macros conditional on support for the type We unconditionally predefine these macros. However, they may be used to determine if the type is

r353163 - [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default

2019-02-05 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Feb 5 04:05:53 2019 New Revision: 353163 URL: http://llvm.org/viewvc/llvm-project?rev=353163=rev Log: [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default When Clang/LLVM is built with the CLANG_DEFAULT_STD_CXX CMake macro that sets the

r356111 - Fix invocation of Gold plugin with LTO after r355331

2019-03-13 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Wed Mar 13 16:54:52 2019 New Revision: 356111 URL: http://llvm.org/viewvc/llvm-project?rev=356111=rev Log: Fix invocation of Gold plugin with LTO after r355331 The above commit breaks the usage of PGO and LTO when -fprofile-use is supplied without a path. This patch

r362571 - Initial support for vectorization using MASSV (IBM MASS vector library)

2019-06-04 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Jun 4 18:57:57 2019 New Revision: 362571 URL: http://llvm.org/viewvc/llvm-project?rev=362571=rev Log: Initial support for vectorization using MASSV (IBM MASS vector library) Part 2 (the Clang portion) of D59881. This patch (first of two patches) enables the

r360220 - Fix buildbot break after r360195

2019-05-07 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue May 7 19:03:32 2019 New Revision: 360220 URL: http://llvm.org/viewvc/llvm-project?rev=360220=rev Log: Fix buildbot break after r360195 Modified: cfe/trunk/test/Modules/preprocess-umbrella.cpp Modified: cfe/trunk/test/Modules/preprocess-umbrella.cpp URL:

[clang] e0407f5 - [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-11-07 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2019-11-07T20:58:11-06:00 New Revision: e0407f54965318247c8fece2dfa5c9023acf0973 URL: https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973 DIFF:

[clang] 070e402 - [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

2019-11-07 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2019-11-07T20:40:32-06:00 New Revision: 070e4027b02453f0962e5b61335a517581c5528f URL: https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f DIFF:

RE: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

2019-12-12 Thread Nemanja Ivanovic via cfe-commits
Hi Michael, We are happy to help troubleshoot the issue this caused on our bot. Unfortunately, this bot is not one where we can give you access so we'll have to try and work together to debug this. Can you provide the link to the failing build so we can see which test case it was that caused the

RE: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

2019-12-16 Thread Nemanja Ivanovic via cfe-commits
Hi Michael, this turns out to be an assert failure:   clang/tools/clang-scan-deps/ClangScanDeps.cpp:340: const clang::tooling::dependencies::ModuleDeps& FullDeps::lookupModuleDeps(clang::tooling::dependencies::ClangModuleDep): Assertion `I != Modules.end()' failed.   Does this help with debugging

Re: [llvm-dev] Zorg migration to GitHub/monorepo

2019-10-28 Thread Nemanja Ivanovic via cfe-commits
I think what she is referring to was that the build seemed to be triggered by a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. the change was in llvm). I have a somewhat orthogonal but related question. In the past, commits to compiler-rt did not trigger builds on

[clang] aede24e - [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

2020-05-22 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-05-22T07:59:21-05:00 New Revision: aede24ecaa08db806fb173faf2de9cff95df8cee URL: https://github.com/llvm/llvm-project/commit/aede24ecaa08db806fb173faf2de9cff95df8cee DIFF:

[clang] 2d65294 - [PowerPC] Provide vec_cmpne on pre-Power9 architectures in altivec.h

2020-09-04 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-09-04T21:48:38-04:00 New Revision: 2d652949be4b772f2c11577621b0ad33052ac844 URL: https://github.com/llvm/llvm-project/commit/2d652949be4b772f2c11577621b0ad33052ac844 DIFF:

[clang] 3bc3983 - Fix bot failure after ccb4124a4172

2020-09-15 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-09-15T12:36:47-05:00 New Revision: 3bc3983f229f9277d5bea3692b691f72ab8740dd URL: https://github.com/llvm/llvm-project/commit/3bc3983f229f9277d5bea3692b691f72ab8740dd DIFF:

[clang] 54205f0 - [PowerPC] Allow const pointers for load builtins in altivec.h

2020-09-04 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-09-04T13:56:39-04:00 New Revision: 54205f0bd2377503b818d7f62cc4ed63ef5b1e94 URL: https://github.com/llvm/llvm-project/commit/54205f0bd2377503b818d7f62cc4ed63ef5b1e94 DIFF:

[clang] f9e94eb - [Clang] Enable _Complex __float128

2020-05-28 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-05-28T06:55:49-05:00 New Revision: f9e94eb8688d1fe1727360462e957fbbfb754e59 URL: https://github.com/llvm/llvm-project/commit/f9e94eb8688d1fe1727360462e957fbbfb754e59 DIFF:

[clang] 9021ce9 - [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-28 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-05-28T15:48:15-05:00 New Revision: 9021ce9576e438ae5a6fdb574327d30ea6b67fa8 URL: https://github.com/llvm/llvm-project/commit/9021ce9576e438ae5a6fdb574327d30ea6b67fa8 DIFF:

[clang] 3f7b4ce - [PowerPC] Add support for embedded devices with EFPU2

2021-01-12 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-01-12T09:47:00-06:00 New Revision: 3f7b4ce96065eea66bf4344973173e76ec1a4255 URL: https://github.com/llvm/llvm-project/commit/3f7b4ce96065eea66bf4344973173e76ec1a4255 DIFF:

[clang] ef90657 - [PowerPC] Fix vec_add for 64-bit on pre-Power7 subtargets

2021-06-24 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-06-24T18:42:44-05:00 New Revision: ef906573a127cffef7cae75d5155c15a8a2a3a5e URL: https://github.com/llvm/llvm-project/commit/ef906573a127cffef7cae75d5155c15a8a2a3a5e DIFF:

[clang] 7cd2833 - [PowerPC] Add vec_vupkhpx and vec_vupklpx for XL compatibility

2021-05-14 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-05-14T08:02:00-05:00 New Revision: 7cd2833311ab614775bc695e7bb808159a02e2a9 URL: https://github.com/llvm/llvm-project/commit/7cd2833311ab614775bc695e7bb808159a02e2a9 DIFF:

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

2021-05-06 Thread Nemanja Ivanovic via cfe-commits
now. > > On Thu, May 6, 2021 at 9:58 AM Nico Weber wrote: > >> Looks like this breaks tests: http://45.33.8.238/linux/45985/step_7.txt >> , https://lab.llvm.org/buildbot/#/builders/139/builds/3818 >> >> (Is there a phab link for this?) >> >> On Thu, May 6,

[clang] 1faf3b1 - [PowerPC] Re-commit ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8

2021-05-06 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-05-06T09:50:12-05:00 New Revision: 1faf3b195e71dbc469d658d450949439dbf92f9f URL: https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f DIFF:

[clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

2021-05-06 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-05-06T08:37:36-05:00 New Revision: ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8 URL: https://github.com/llvm/llvm-project/commit/ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8 DIFF:

[clang] 39e4676 - [PowerPC] Provide doubleword vector predicate form comparisons on Power7

2021-05-13 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-05-13T04:56:56-05:00 New Revision: 39e4676ca798d9aba58823515ac9d48eb64863be URL: https://github.com/llvm/llvm-project/commit/39e4676ca798d9aba58823515ac9d48eb64863be DIFF:

[clang] 41ce5ec - [PowerPC] Remove unnecessary 64-bit guards from altivec.h

2021-07-12 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-07-12T04:59:00-05:00 New Revision: 41ce5ec5f6f3a03d70e0010e3a140fe129800637 URL: https://github.com/llvm/llvm-project/commit/41ce5ec5f6f3a03d70e0010e3a140fe129800637 DIFF:

[clang] 84e4296 - [PowerPC] Fix rounding mode for vec_round in altivec.h

2021-07-12 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-07-12T06:11:27-05:00 New Revision: 84e429693fe5f225fe68b9dd54043cddb9c4cd4c URL: https://github.com/llvm/llvm-project/commit/84e429693fe5f225fe68b9dd54043cddb9c4cd4c DIFF:

[clang] bfd60b3 - [PowerPC] Add floating point overloads for vec_sldw

2021-04-30 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-04-30T20:29:03-05:00 New Revision: bfd60b36f825c299971bb0c2bf973031e2e0fc09 URL: https://github.com/llvm/llvm-project/commit/bfd60b36f825c299971bb0c2bf973031e2e0fc09 DIFF:

[clang] c3da07d - [PowerPC] Provide fastmath sqrt and div functions in altivec.h

2021-04-30 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-04-30T19:17:48-05:00 New Revision: c3da07d216dd20fbdb7302fd085c0a59e189ae3d URL: https://github.com/llvm/llvm-project/commit/c3da07d216dd20fbdb7302fd085c0a59e189ae3d DIFF:

[clang] 3bcd0ec - [PowerPC] Add vec_roundc as alias for vec_rint in altivec.h

2021-04-22 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-04-22T05:31:38-05:00 New Revision: 3bcd0ece43bd117b9931d2b010b50884aa74870a URL: https://github.com/llvm/llvm-project/commit/3bcd0ece43bd117b9931d2b010b50884aa74870a DIFF:

[clang] 6725b90 - [PowerPC] Add vec_ctsl and vec_ctul to altivec.h

2021-04-23 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-04-23T11:03:38-05:00 New Revision: 6725b90a02c6d2696385c0328bd000516913ce4b URL: https://github.com/llvm/llvm-project/commit/6725b90a02c6d2696385c0328bd000516913ce4b DIFF:

[clang] a1d325a - [PowerPC] Add vec_roundz as alias for vec_trunc in altivec.h

2021-04-22 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2021-04-22T10:31:00-05:00 New Revision: a1d325af6708ebd8ac9efb8d2d148f16feeda3fd URL: https://github.com/llvm/llvm-project/commit/a1d325af6708ebd8ac9efb8d2d148f16feeda3fd DIFF:

  1   2   3   >