[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. oontvoo added reviewers: gribozavr, ymandel. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80603 Files: clang/include/clang/ASTMatchers/ASTMatchers.

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. P.S: Please ignore the child revision ... accidentally committed it to the wrong branch. I've fixed the git branches locally but can't figure out how to tell phabricator ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2057014 , @aaron.ballman wrote: > Does the `hasParameter()` matcher not already do this? Yes, it does. But we'd like it to be able to match on the parmVarDecl(). Comment at: clang/include/clang/ASTM

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266615. oontvoo marked 7 inline comments as done. oontvoo added a comment. - Added docs - Make it work with {block,objcMethod}Decl too. More tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266642. oontvoo added a comment. Remove unrelated doc generated by the script Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2058019 , @aaron.ballman wrote: > In D80603#2057970 , @oontvoo wrote: > > > In D80603#2057014 , @aaron.ballman > > wrote: > > > > > Does

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266714. oontvoo added a comment. use helper for examining the node instead of nested matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibAST

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266735. oontvoo added a comment. More tests for Block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReference.html clang/include/c

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266887. oontvoo marked 2 inline comments as done. oontvoo added a comment. Change tests to us no/matchesObjC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: cl

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2061131 , @aaron.ballman wrote: > In D80603#2059122 , @gribozavr2 > wrote: > > > In D80603#2058019 , @aaron.ballman > > wrote: > > > > >

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266999. oontvoo added a comment. Updated Registry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReference.html clang/include/clang

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo closed this revision. oontvoo added a comment. Thanks, all! Committed https://github.com/llvm/llvm-project/commit/51401a676c036f2bd4e6b4b38f3538615799de40 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D8

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 267008. oontvoo added a comment. Move matcher to near forEachArgumentWithParam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReferen

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo added a comment. jyknight@ Hi, pinging again 🔔🔔🔔 (sorry!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo created this revision. oontvoo added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider: `const int* get_foo() {return nullptr;}` The suggested fix should be `static const int* get_foo(){}` and not `const static int* get_foo(){}` Repos

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo marked an inline comment as done. oontvoo added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14252 + FD->getReturnType().isConstQualified()) +return FD->getReturnTypeSourceRange().getBegin().getLocWithOffset( +/*strlen(

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo updated this revision to Diff 269627. oontvoo marked an inline comment as done. oontvoo added a comment. - Less brittle way to find the loc of const. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/ https://reviews.

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo updated this revision to Diff 269657. oontvoo marked an inline comment as done. oontvoo added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/ https://reviews.llvm.org/D81444 Files: clang/lib/Sem

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo marked 7 inline comments as done. oontvoo added inline comments. Comment at: clang/test/Sema/warn-missing-prototypes.c:62 + +const struct MyStruct get_struct() { // expected-warning{{no previous prototype for function 'get_struct'}} +

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa21a46205165: Make the diagnostic-missing-prototypes put the suggested `static` in front of… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repro: - Annotate the unique_ptr class with trivial_abi (eg., https://godbolt.org/z/-rprsc) - ./build/bin/clang++ -stdlib=libc++ -I../libcxx/memory Crash: @ 0x559d129463fc clang::CXXRe

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275866. oontvoo added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/trivial-abi-templ

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275885. oontvoo added a comment. Dont skip checking even for templated type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp cl

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275895. oontvoo added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivia

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275898. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275899. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276076. oontvoo marked 2 inline comments as done. oontvoo added a comment. prevent diagnostics for dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276077. oontvoo added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-abi.cpp

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 276084. oontvoo added a comment. one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. This helps avoiding hacks downstream. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83529 Files: clang/include/clang/AST/Stmt.h c

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo updated this revision to Diff 277115. oontvoo marked 3 inline comments as done. oontvoo added a comment. Added unit test and the missing serialisation code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83529/new/ https://reviews.llvm.org/D8

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo added a comment. In D83529#2145087 , @riccibruno wrote: > No objection from me, but I am not a reviewer. I am just accepting this to > cancel my comment on the missing serialization. No worries. Thanks for your input! I think Dmitri has already

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo updated this revision to Diff 277148. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83529/new/ https://reviews.llvm.org/D83529 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Parse/Parser.h c

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17ea41e47256: Summary: [clang] Provide a way for WhileStmt to report the location of its… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D85843: Add "status" to the list of absl libraries.

oontvoo created this revision. oontvoo added a reviewer: sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. oontvoo requested review of this revision. The Abseil-NoInternalDependenciesCheck currently mistakenly triggers on any usage of internal helpers even if it is wi

[PATCH] D85843: Add "status" to the list of absl libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG114c9fa0e46f: Add "status" to the list of absl libraries. (authored by oontvoo). Repository: rG LLVM Github Monorepo C

[PATCH] D85843: Add "status" to the list of absl libraries.

oontvoo added a comment. (With LGTM from sbenza) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85843/new/ https://reviews.llvm.org/D85843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

oontvoo accepted this revision. oontvoo added a comment. LG - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo created this revision. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. oontvoo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using XCTAssertEqual on NSString* objects are almost always wrong. Unfortunatley

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo updated this revision to Diff 391451. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp clang-tool

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo updated this revision to Diff 391472. oontvoo added a comment. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp clang-tools-extra/c

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaba8f320cc13: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 251801. oontvoo marked an inline comment as done. oontvoo added a comment. Additional change: Also keep "Importers" and de/serialise these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://revie

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 251804. oontvoo added a comment. Removed accidentally committed file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252110. oontvoo added a comment. Updated the reader to read the UIDs first, then we'll build up the Importers list at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252118. oontvoo added a comment. Clear pending action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/c

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252117. oontvoo marked an inline comment as done. oontvoo added a comment. Add a PendingHeaderSearch set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252203. oontvoo added a comment. (hopefully) Final revision ... running out of idea for edit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/incl

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252206. oontvoo added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252205. oontvoo added a comment. Fix build errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252237. oontvoo added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Prepr

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done. oontvoo added a comment. Addressed comments. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-com

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252371. oontvoo added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo added a comment. @jyknight Actually, please hold on on the review ... still working on it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-commi

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252685. oontvoo added a comment. Handle the case where the file is first seen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSea

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252728. oontvoo added a comment. Typo - missing ! operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/inclu

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252735. oontvoo added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocessor

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252738. oontvoo added a comment. ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preproces

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252761. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocesso

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252760. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocesso

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252768. oontvoo added a comment. Handle textual headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252791. oontvoo added a comment. Handle includes/import from outer mods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253155. oontvoo added a comment. Also serialise non-mods' imported headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253157. oontvoo added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocesso

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253162. oontvoo added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Pre

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253175. oontvoo added a comment. Merge master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253245. oontvoo added a comment. Updated tests and get it to pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clan

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253289. oontvoo added a comment. cleanup logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/L

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253382. oontvoo added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253388. oontvoo added a comment. Add more tests (From Bug 39206) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253623. oontvoo added a comment. Rebaase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Prepr

[PATCH] D77116: temp tests

oontvoo created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77116 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocessor.h clang/include/clang/Serialization

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 254321. oontvoo added a comment. clean up ... Ready to review. PTAL! =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 254384. oontvoo added a comment. Update docs. Note: The failure looks spurious ... They seemed to pass locally for me: One eg: [hi on] vyng@vyng:~/repo/llvm-project$ ./build/bin/llvm-lit -v ./clang/test/ClangScanDeps/modules-full.cpp llvm-lit: /usr/local/g

[PATCH] D75951: draft

oontvoo created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. oontvoo retitled this revision from "Make a distinction between import and pragma-once, and keep tracked of already-included pragma-once files." to "draft ". oontvoo edited the summary of this re

[PATCH] D75971: Should not need the second predicate.If `II->hasMacroDefinition()` is true, then the whole expr is always true.

oontvoo created this revision. oontvoo added a reviewer: jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. remove redundant pred Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75971 Files: clang/include/clang/Lex/Preprocessor.h Index: clang/i

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249690. oontvoo retitled this revision from "draft " to "draft". oontvoo added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249708. oontvoo added a comment. Updated typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSear

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249711. oontvoo added a comment. More typo correction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/He

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249712. oontvoo added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch.cpp

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 249717. oontvoo added a comment. Wrong name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/HeaderSearch

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done. oontvoo added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1266 + if (PP.isIncludeVisibleInLocalModule(File, M)) return false; + else PP.setIncludeVisibleForHeader(File, M); +} else { jyknigh

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done and an inline comment as not done. oontvoo added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1266 + if (PP.isIncludeVisibleInLocalModule(File, M)) return false; + else PP.setIncludeVisibleForHeader(File, M); +

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo reopened this revision. oontvoo added a comment. This revision is now accepted and ready to land. In D144999#4356218 , @thakis wrote: > Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 >

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519849. oontvoo added a comment. Herald added a subscriber: MaskRay. updated more clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/cl

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo marked an inline comment as done. oontvoo added a comment. In D144999#4319964 , @jyknight wrote: > I wonder if we actually need to define a clang frontend flag for this; I > suspect nobody will ever want to specify it, since the only non-canonica

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519939. oontvoo added a comment. addressed review comments: - added explanation on why we left out _gcc personality - updated more clang tests hopefully should be all green now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 520344. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Hi all! The CI builds are all clean now. Any further comment/review on this? Would love to close this out soon. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. @int3 @thakis, et al - friendly 🔔 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523147. oontvoo marked an inline comment as done. oontvoo edited the summary of this revision. oontvoo added a comment. updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523148. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523354. oontvoo added a comment. rebase again (windows failures in flang tests looked unrelated) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/includ

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09aaf53a05e3: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 518710. oontvoo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. updated clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519216. oontvoo added a comment. Herald added a subscriber: ormris. - defined equivalent flag in the clang driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 File

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 528965. oontvoo added a comment. rebase for rolling forward. (Will wait ~1 day before pushing to avoid possible stacking reverts because this depends on D151824 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 529283. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

  1   2   >